@appcircle/codepush-cli 0.0.1-alpha.4 → 0.0.2

package/README.md

@@ -58,11 +58,6 @@ appcircle-code-push login <optional: server-url> <optional: auth-url>
 
 This will launch a browser, asking you to authenticate with either your GitHub or Microsoft account. This will generate an access key that you need to copy/paste into the CLI (it will prompt you for it). You are now successfully authenticated and can safely close your browser window.
 
-If at any time you want to determine if you're already logged in, you can run the following command to display the e-mail address associated with your current authentication session, which identity providers your account is linked to (e.g. GitHub):
-
-```shell
-appcircle-code-push whoami
-```
 
 When you login from the CLI, your access key is persisted to disk for the duration of your session so that you don't have to login every time you attempt to access your account. In order to end your session and delete this access key, simply run the following command:
 
@@ -145,56 +140,6 @@ you can run the following command:
 appcircle-code-push app ls
 ```
 
-### App Collaboration
-
-If you will be working with other developers on the same CodePush app, you can add them as collaborators using the following command:
-
-```shell
-appcircle-code-push collaborator add <appName> <collaboratorEmail>
-```
-
-_NOTE: This expects the developer to have already [registered](#account-creation) with CodePush using the specified e-mail address, so ensure that they have done that before attempting to share the app with them._
-
-Once added, all collaborators will immediately have the following permissions with regards to the newly shared app:
-
-1. View the app, its collaborators, [deployments](#deployment-management) and [release history](#viewing-release-history)
-1. [Release](#releasing-updates) updates to any of the app's deployments
-1. [Promote](#promoting-updates) an update between any of the app's deployments
-1. [Rollback](#rolling-back-undesired-updates) any of the app's deployments
-1. [Patch](#updating-existing-releases) any releases within any of the app's deployments
-
-Inversely, that means that an app collaborator cannot do any of the following:
-
-1. Rename or delete the app
-1. Transfer ownership of the app
-1. Create, rename or delete new deployments within the app
-1. Clear a deployment's release history
-1. Add or remove collaborators from the app (\*)
-
-_NOTE: A developer can remove him/herself as a collaborator from an app that was shared with them._
-
-Over time, if someone is no longer working on an app with you, you can remove them as a collaborator using the following command:
-
-```shell
-appcircle-code-push collaborator rm <appName> <collaboratorEmail>
-```
-
-If at any time you want to list all collaborators that have been added to an app, you can simply run the following command:
-
-```shell
-appcircle-code-push collaborator ls <appName>
-```
-
-Finally, if at some point, you (as the app owner) will no longer be working on the app, and you want to transfer it to another developer (or a client), you can run the following command:
-
-```shell
-appcircle-code-push app transfer <appName> <newOwnerEmail>
-```
-
-_NOTE: Just like with the `appcircle-code-push collaborator add` command, this expects that the new owner has already registered with CodePush using the specified e-mail address._
-
-Once confirmed, the specified developer becomes the app's owner and immediately receives the permissions associated with that role. Besides the transfer of ownership, nothing else about the app is modified (e.g. deployments, release history, collaborators). This means that you will still be a collaborator of the app, and therefore, if you want to remove yourself, you simply need to run the `appcircle-code-push collaborator rm` command after successfully transferring ownership.
-
 ### Deployment Management
 
 From the CodePush perspective, an app is simply a named grouping for one or more things called "deployments". While the app represents a conceptual "namespace" or "scope" for a platform-specific version of an app (e.g. the iOS port of Foo app), its deployments represent the actual target for releasing updates (for developers) and synchronizing updates (for end-users). Deployments allow you to have multiple "environments" for each app in-flight at any given time, and help model the reality that apps typically move from a dev's personal environment to a testing/QA/staging environment, before finally making their way into production.

package/bin/script/command-executor.js

@@ -372,14 +372,6 @@ function execute(command) {
                 return appRemove(command);
             case cli.CommandType.appRename:
                 return appRename(command);
-            case cli.CommandType.appTransfer:
-                return appTransfer(command);
-            case cli.CommandType.collaboratorAdd:
-                return addCollaborator(command);
-            case cli.CommandType.collaboratorList:
-                return listCollaborators(command);
-            case cli.CommandType.collaboratorRemove:
-                return removeCollaborator(command);
             case cli.CommandType.debug:
                 return (0, debug_1.default)(command);
             case cli.CommandType.deploymentAdd:
@@ -416,8 +408,6 @@ function execute(command) {
                 return sessionList(command);
             case cli.CommandType.sessionRemove:
                 return sessionRemove(command);
-            case cli.CommandType.whoami:
-                return whoami(command);
             default:
                 // We should never see this message as invalid commands should be caught by the argument parser.
                 throw new Error("Invalid command:  " + JSON.stringify(command));
@@ -1254,6 +1244,7 @@ function throwForInvalidOutputFormat(format) {
             throw new Error("Invalid format:  " + format + ".");
     }
 }
+// DEPRECATED
 function whoami(command) {
     return exports.sdk.getAccountInfo().then((account) => {
         const accountInfo = `${account.email} (${account.linkedProviders.join(", ")})`;

package/bin/script/command-parser.js

@@ -278,26 +278,6 @@ yargs
     })
         .check((argv, aliases) => isValidCommand); // Report unrecognized, non-hyphenated command category.
     addCommonConfiguration(yargs);
-})
-    .command("collaborator", "View and manage app collaborators", (yargs) => {
-    isValidCommandCategory = true;
-    yargs
-        .usage(USAGE_PREFIX + " collaborator <command>")
-        .demand(/*count*/ 2, /*max*/ 2) // Require exactly two non-option arguments.
-        .command("add", "Add a new collaborator to an app", (yargs) => {
-        isValidCommand = true;
-        yargs
-            .usage(USAGE_PREFIX + " collaborator add <appName> <email>")
-            .demand(/*count*/ 2, /*max*/ 2) // Require exactly two non-option arguments
-            .example("collaborator add MyApp foo@bar.com", 'Adds foo@bar.com as a collaborator to app "MyApp"');
-        addCommonConfiguration(yargs);
-    })
-        .command("remove", "Remove a collaborator from an app", (yargs) => removeCollaborator("remove", yargs))
-        .command("rm", "Remove a collaborator from an app", (yargs) => removeCollaborator("rm", yargs))
-        .command("list", "List the collaborators for an app", (yargs) => listCollaborators("list", yargs))
-        .command("ls", "List the collaborators for an app", (yargs) => listCollaborators("ls", yargs))
-        .check((argv, aliases) => isValidCommand); // Report unrecognized, non-hyphenated command category.
-    addCommonConfiguration(yargs);
 })
     .command("debug", "View the CodePush debug logs for a running app", (yargs) => {
     isValidCommandCategory = true;
@@ -761,15 +741,6 @@ yargs
         .command("ls", "List the current login sessions associated with your account", (yargs) => sessionList("ls", yargs))
         .check((argv, aliases) => isValidCommand); // Report unrecognized, non-hyphenated command category.
     addCommonConfiguration(yargs);
-})
-    .command("whoami", "Display the account info for the current login session", (yargs) => {
-    isValidCommandCategory = true;
-    isValidCommand = true;
-    yargs
-        .usage(USAGE_PREFIX + " whoami")
-        .demand(/*count*/ 0, /*max*/ 0)
-        .example("whoami", "Display the account info for the current login session");
-    addCommonConfiguration(yargs);
 })
     .alias("v", "version")
     .version(packageJson.version)
@@ -856,41 +827,6 @@ function createCommand() {
                             appRenameCommand.newAppName = arg3;
                         }
                         break;
-                    case "transfer":
-                        if (arg2 && arg3) {
-                            cmd = { type: cli.CommandType.appTransfer };
-                            const appTransferCommand = cmd;
-                            appTransferCommand.appName = arg2;
-                            appTransferCommand.email = arg3;
-                        }
-                        break;
-                }
-                break;
-            case "collaborator":
-                switch (arg1) {
-                    case "add":
-                        if (arg2 && arg3) {
-                            cmd = { type: cli.CommandType.collaboratorAdd };
-                            cmd.appName = arg2;
-                            cmd.email = arg3;
-                        }
-                        break;
-                    case "list":
-                    case "ls":
-                        if (arg2) {
-                            cmd = { type: cli.CommandType.collaboratorList };
-                            cmd.appName = arg2;
-                            cmd.format = argv["format"];
-                        }
-                        break;
-                    case "remove":
-                    case "rm":
-                        if (arg2 && arg3) {
-                            cmd = { type: cli.CommandType.collaboratorRemove };
-                            cmd.appName = arg2;
-                            cmd.email = arg3;
-                        }
-                        break;
                 }
                 break;
             case "debug":
@@ -1083,9 +1019,6 @@ function createCommand() {
                         break;
                 }
                 break;
-            case "whoami":
-                cmd = { type: cli.CommandType.whoami };
-                break;
         }
         return cmd;
     }

package/bin/script/types/cli.js

@@ -13,28 +13,23 @@ var CommandType;
     CommandType[CommandType["appList"] = 5] = "appList";
     CommandType[CommandType["appRemove"] = 6] = "appRemove";
     CommandType[CommandType["appRename"] = 7] = "appRename";
-    CommandType[CommandType["appTransfer"] = 8] = "appTransfer";
-    CommandType[CommandType["collaboratorAdd"] = 9] = "collaboratorAdd";
-    CommandType[CommandType["collaboratorList"] = 10] = "collaboratorList";
-    CommandType[CommandType["collaboratorRemove"] = 11] = "collaboratorRemove";
-    CommandType[CommandType["debug"] = 12] = "debug";
-    CommandType[CommandType["deploymentAdd"] = 13] = "deploymentAdd";
-    CommandType[CommandType["deploymentHistory"] = 14] = "deploymentHistory";
-    CommandType[CommandType["deploymentHistoryClear"] = 15] = "deploymentHistoryClear";
-    CommandType[CommandType["deploymentList"] = 16] = "deploymentList";
-    CommandType[CommandType["deploymentMetrics"] = 17] = "deploymentMetrics";
-    CommandType[CommandType["deploymentRemove"] = 18] = "deploymentRemove";
-    CommandType[CommandType["deploymentRename"] = 19] = "deploymentRename";
-    CommandType[CommandType["link"] = 20] = "link";
-    CommandType[CommandType["login"] = 21] = "login";
-    CommandType[CommandType["logout"] = 22] = "logout";
-    CommandType[CommandType["patch"] = 23] = "patch";
-    CommandType[CommandType["promote"] = 24] = "promote";
-    CommandType[CommandType["register"] = 25] = "register";
-    CommandType[CommandType["release"] = 26] = "release";
-    CommandType[CommandType["releaseReact"] = 27] = "releaseReact";
-    CommandType[CommandType["rollback"] = 28] = "rollback";
-    CommandType[CommandType["sessionList"] = 29] = "sessionList";
-    CommandType[CommandType["sessionRemove"] = 30] = "sessionRemove";
-    CommandType[CommandType["whoami"] = 31] = "whoami";
+    CommandType[CommandType["debug"] = 8] = "debug";
+    CommandType[CommandType["deploymentAdd"] = 9] = "deploymentAdd";
+    CommandType[CommandType["deploymentHistory"] = 10] = "deploymentHistory";
+    CommandType[CommandType["deploymentHistoryClear"] = 11] = "deploymentHistoryClear";
+    CommandType[CommandType["deploymentList"] = 12] = "deploymentList";
+    CommandType[CommandType["deploymentMetrics"] = 13] = "deploymentMetrics";
+    CommandType[CommandType["deploymentRemove"] = 14] = "deploymentRemove";
+    CommandType[CommandType["deploymentRename"] = 15] = "deploymentRename";
+    CommandType[CommandType["link"] = 16] = "link";
+    CommandType[CommandType["login"] = 17] = "login";
+    CommandType[CommandType["logout"] = 18] = "logout";
+    CommandType[CommandType["patch"] = 19] = "patch";
+    CommandType[CommandType["promote"] = 20] = "promote";
+    CommandType[CommandType["register"] = 21] = "register";
+    CommandType[CommandType["release"] = 22] = "release";
+    CommandType[CommandType["releaseReact"] = 23] = "releaseReact";
+    CommandType[CommandType["rollback"] = 24] = "rollback";
+    CommandType[CommandType["sessionList"] = 25] = "sessionList";
+    CommandType[CommandType["sessionRemove"] = 26] = "sessionRemove";
 })(CommandType || (exports.CommandType = CommandType = {}));

package/bin/test/cli.js

@@ -482,68 +482,6 @@ describe("CLI", () => {
             done();
         });
     });
-    it("appTransfer transfers app", (done) => {
-        var command = {
-            type: cli.CommandType.appTransfer,
-            appName: "a",
-            email: "b@b.com",
-        };
-        var transferApp = sandbox.spy(cmdexec.sdk, "transferApp");
-        cmdexec.execute(command).done(() => {
-            sinon.assert.calledOnce(transferApp);
-            sinon.assert.calledOnce(log);
-            sinon.assert.calledWithExactly(log, 'Successfully transferred the ownership of app "a" to the account with email "b@b.com".');
-            done();
-        });
-    });
-    it("collaboratorAdd adds collaborator", (done) => {
-        var command = {
-            type: cli.CommandType.collaboratorAdd,
-            appName: "a",
-            email: "b@b.com",
-        };
-        var addCollaborator = sandbox.spy(cmdexec.sdk, "addCollaborator");
-        cmdexec.execute(command).done(() => {
-            sinon.assert.calledOnce(addCollaborator);
-            sinon.assert.calledOnce(log);
-            sinon.assert.calledWithExactly(log, 'Successfully added "b@b.com" as a collaborator to the app "a".');
-            done();
-        });
-    });
-    it("collaboratorList lists collaborators email and properties", (done) => {
-        var command = {
-            type: cli.CommandType.collaboratorList,
-            appName: "a",
-            format: "json",
-        };
-        cmdexec.execute(command).done(() => {
-            sinon.assert.calledOnce(log);
-            assert.equal(log.args[0].length, 1);
-            var actual = log.args[0][0];
-            var expected = {
-                collaborators: {
-                    "a@a.com": { permission: "Owner", isCurrentAccount: true },
-                    "b@b.com": { permission: "Collaborator", isCurrentAccount: false },
-                },
-            };
-            assertJsonDescribesObject(actual, expected);
-            done();
-        });
-    });
-    it("collaboratorRemove removes collaborator", (done) => {
-        var command = {
-            type: cli.CommandType.collaboratorRemove,
-            appName: "a",
-            email: "b@b.com",
-        };
-        var removeCollaborator = sandbox.spy(cmdexec.sdk, "removeCollaborator");
-        cmdexec.execute(command).done(() => {
-            sinon.assert.calledOnce(removeCollaborator);
-            sinon.assert.calledOnce(log);
-            sinon.assert.calledWithExactly(log, 'Successfully removed "b@b.com" as a collaborator from the app "a".');
-            done();
-        });
-    });
     it("deploymentAdd reports new app name and ID", (done) => {
         var command = {
             type: cli.CommandType.deploymentAdd,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@appcircle/codepush-cli",
-  "version": "0.0.1-alpha.4",
+  "version": "0.0.2",
   "description": "Management CLI for the CodePush service",
   "main": "./script/cli.js",
   "scripts": {

package/script/command-executor.ts

@@ -488,18 +488,6 @@ export function execute(command: cli.ICommand) {
       case cli.CommandType.appRename:
         return appRename(<cli.IAppRenameCommand>command);
 
-      case cli.CommandType.appTransfer:
-        return appTransfer(<cli.IAppTransferCommand>command);
-
-      case cli.CommandType.collaboratorAdd:
-        return addCollaborator(<cli.ICollaboratorAddCommand>command);
-
-      case cli.CommandType.collaboratorList:
-        return listCollaborators(<cli.ICollaboratorListCommand>command);
-
-      case cli.CommandType.collaboratorRemove:
-        return removeCollaborator(<cli.ICollaboratorRemoveCommand>command);
-
       case cli.CommandType.debug:
         return debugCommand(<cli.IDebugCommand>command);
 
@@ -554,9 +542,6 @@ export function execute(command: cli.ICommand) {
       case cli.CommandType.sessionRemove:
         return sessionRemove(<cli.ISessionRemoveCommand>command);
 
-      case cli.CommandType.whoami:
-        return whoami(command);
-
       default:
         // We should never see this message as invalid commands should be caught by the argument parser.
         throw new Error("Invalid command:  " + JSON.stringify(command));
@@ -1570,6 +1555,7 @@ function throwForInvalidOutputFormat(format: string): void {
   }
 }
 
+// DEPRECATED
 function whoami(command: cli.ICommand): Promise<void> {
   return sdk.getAccountInfo().then((account): void => {
     const accountInfo = `${account.email} (${account.linkedProviders.join(", ")})`;

package/script/command-parser.ts

@@ -334,28 +334,6 @@ yargs
 
     addCommonConfiguration(yargs);
   })
-  .command("collaborator", "View and manage app collaborators", (yargs: yargs.Argv) => {
-    isValidCommandCategory = true;
-    yargs
-      .usage(USAGE_PREFIX + " collaborator <command>")
-      .demand(/*count*/ 2, /*max*/ 2) // Require exactly two non-option arguments.
-      .command("add", "Add a new collaborator to an app", (yargs: yargs.Argv): void => {
-        isValidCommand = true;
-        yargs
-          .usage(USAGE_PREFIX + " collaborator add <appName> <email>")
-          .demand(/*count*/ 2, /*max*/ 2) // Require exactly two non-option arguments
-          .example("collaborator add MyApp foo@bar.com", 'Adds foo@bar.com as a collaborator to app "MyApp"');
-
-        addCommonConfiguration(yargs);
-      })
-      .command("remove", "Remove a collaborator from an app", (yargs: yargs.Argv) => removeCollaborator("remove", yargs))
-      .command("rm", "Remove a collaborator from an app", (yargs: yargs.Argv) => removeCollaborator("rm", yargs))
-      .command("list", "List the collaborators for an app", (yargs: yargs.Argv) => listCollaborators("list", yargs))
-      .command("ls", "List the collaborators for an app", (yargs: yargs.Argv) => listCollaborators("ls", yargs))
-      .check((argv: any, aliases: { [aliases: string]: string }): any => isValidCommand); // Report unrecognized, non-hyphenated command category.
-
-    addCommonConfiguration(yargs);
-  })
   .command("debug", "View the CodePush debug logs for a running app", (yargs: yargs.Argv) => {
     isValidCommandCategory = true;
     isValidCommand = true;
@@ -890,15 +868,6 @@ yargs
 
     addCommonConfiguration(yargs);
   })
-  .command("whoami", "Display the account info for the current login session", (yargs: yargs.Argv) => {
-    isValidCommandCategory = true;
-    isValidCommand = true;
-    yargs
-      .usage(USAGE_PREFIX + " whoami")
-      .demand(/*count*/ 0, /*max*/ 0)
-      .example("whoami", "Display the account info for the current login session");
-    addCommonConfiguration(yargs);
-  })
   .alias("v", "version")
   .version(packageJson.version)
   .wrap(/*columnLimit*/ null)
@@ -1004,50 +973,6 @@ export function createCommand(): cli.ICommand {
               appRenameCommand.newAppName = arg3;
             }
             break;
-
-          case "transfer":
-            if (arg2 && arg3) {
-              cmd = { type: cli.CommandType.appTransfer };
-
-              const appTransferCommand = <cli.IAppTransferCommand>cmd;
-
-              appTransferCommand.appName = arg2;
-              appTransferCommand.email = arg3;
-            }
-            break;
-        }
-        break;
-
-      case "collaborator":
-        switch (arg1) {
-          case "add":
-            if (arg2 && arg3) {
-              cmd = { type: cli.CommandType.collaboratorAdd };
-
-              (<cli.ICollaboratorAddCommand>cmd).appName = arg2;
-              (<cli.ICollaboratorAddCommand>cmd).email = arg3;
-            }
-            break;
-
-          case "list":
-          case "ls":
-            if (arg2) {
-              cmd = { type: cli.CommandType.collaboratorList };
-
-              (<cli.ICollaboratorListCommand>cmd).appName = arg2;
-              (<cli.ICollaboratorListCommand>cmd).format = argv["format"] as any;
-            }
-            break;
-
-          case "remove":
-          case "rm":
-            if (arg2 && arg3) {
-              cmd = { type: cli.CommandType.collaboratorRemove };
-
-              (<cli.ICollaboratorRemoveCommand>cmd).appName = arg2;
-              (<cli.ICollaboratorAddCommand>cmd).email = arg3;
-            }
-            break;
         }
         break;
 
@@ -1290,10 +1215,6 @@ export function createCommand(): cli.ICommand {
             break;
         }
         break;
-
-      case "whoami":
-        cmd = { type: cli.CommandType.whoami };
-        break;
     }
 
     return cmd;

package/script/types/cli.ts

@@ -12,10 +12,6 @@ export enum CommandType {
   appList,
   appRemove,
   appRename,
-  appTransfer,
-  collaboratorAdd,
-  collaboratorList,
-  collaboratorRemove,
   debug,
   deploymentAdd,
   deploymentHistory,
@@ -34,8 +30,7 @@ export enum CommandType {
   releaseReact,
   rollback,
   sessionList,
-  sessionRemove,
-  whoami,
+  sessionRemove
 }
 
 export interface ICommand {

package/test/cli.ts

@@ -579,83 +579,6 @@ describe("CLI", () => {
     });
   });
 
-  it("appTransfer transfers app", (done: Mocha.Done): void => {
-    var command: cli.IAppTransferCommand = {
-      type: cli.CommandType.appTransfer,
-      appName: "a",
-      email: "b@b.com",
-    };
-
-    var transferApp: sinon.SinonSpy = sandbox.spy(cmdexec.sdk, "transferApp");
-
-    cmdexec.execute(command).done((): void => {
-      sinon.assert.calledOnce(transferApp);
-      sinon.assert.calledOnce(log);
-      sinon.assert.calledWithExactly(log, 'Successfully transferred the ownership of app "a" to the account with email "b@b.com".');
-
-      done();
-    });
-  });
-
-  it("collaboratorAdd adds collaborator", (done: Mocha.Done): void => {
-    var command: cli.ICollaboratorAddCommand = {
-      type: cli.CommandType.collaboratorAdd,
-      appName: "a",
-      email: "b@b.com",
-    };
-
-    var addCollaborator: sinon.SinonSpy = sandbox.spy(cmdexec.sdk, "addCollaborator");
-
-    cmdexec.execute(command).done((): void => {
-      sinon.assert.calledOnce(addCollaborator);
-      sinon.assert.calledOnce(log);
-      sinon.assert.calledWithExactly(log, 'Successfully added "b@b.com" as a collaborator to the app "a".');
-
-      done();
-    });
-  });
-
-  it("collaboratorList lists collaborators email and properties", (done: Mocha.Done): void => {
-    var command: cli.ICollaboratorListCommand = {
-      type: cli.CommandType.collaboratorList,
-      appName: "a",
-      format: "json",
-    };
-
-    cmdexec.execute(command).done((): void => {
-      sinon.assert.calledOnce(log);
-      assert.equal(log.args[0].length, 1);
-
-      var actual: string = log.args[0][0];
-      var expected = {
-        collaborators: {
-          "a@a.com": { permission: "Owner", isCurrentAccount: true },
-          "b@b.com": { permission: "Collaborator", isCurrentAccount: false },
-        },
-      };
-
-      assertJsonDescribesObject(actual, expected);
-      done();
-    });
-  });
-
-  it("collaboratorRemove removes collaborator", (done: Mocha.Done): void => {
-    var command: cli.ICollaboratorRemoveCommand = {
-      type: cli.CommandType.collaboratorRemove,
-      appName: "a",
-      email: "b@b.com",
-    };
-
-    var removeCollaborator: sinon.SinonSpy = sandbox.spy(cmdexec.sdk, "removeCollaborator");
-
-    cmdexec.execute(command).done((): void => {
-      sinon.assert.calledOnce(removeCollaborator);
-      sinon.assert.calledOnce(log);
-      sinon.assert.calledWithExactly(log, 'Successfully removed "b@b.com" as a collaborator from the app "a".');
-
-      done();
-    });
-  });
 
   it("deploymentAdd reports new app name and ID", (done: Mocha.Done): void => {
     var command: cli.IDeploymentAddCommand = {