@app-vitals/agent-runtime 0.7.0 → 0.8.0

package/boot.ts

@@ -111,7 +111,13 @@ import {
 } from "./sync-config-clone.ts";
 import { createTranscriptUploader } from "./transcript-uploader.ts";
 import { resolveDisplayName, resolveUserEmail } from "./users.ts";
-import { synthesizeSpeech, transcribeAudio } from "./voice.ts";
+import {
+  buildVoiceConfig,
+  revertRemovedVoiceEnv,
+  synthesizeSpeech as synthesizeSpeechStatic,
+  transcribeAudio as transcribeAudioStatic,
+  VOICE_ENV_KEYS,
+} from "./voice.ts";
 import {
   buildProductionDeps as buildWorktreeReaperDeps,
   reconcileStaleWorktrees,
@@ -178,6 +184,16 @@ export async function startAgent(
   // saved to the admin DB after boot only reach this process via syncConfig()'s
   // `applyEnvToProcess(bundle.env)`, so re-reading `config.slack.*`
   // here would keep seeing the boot-time (absent) values forever.
+  // COS-62.1: voice settings are likewise resolved from live process.env at
+  // call time (per-agent ELEVENLABS_* arrive via syncConfig after boot). The
+  // config arg the call sites pass is the boot snapshot and is ignored.
+  const synthesizeSpeech: typeof synthesizeSpeechStatic = (
+    text,
+    _cfg,
+    ...rest
+  ) => synthesizeSpeechStatic(text, buildVoiceConfig(), ...rest);
+  const transcribeAudio: typeof transcribeAudioStatic = (path, _cfg, ...rest) =>
+    transcribeAudioStatic(path, buildVoiceConfig(), ...rest);
   function buildSlackAppConfig() {
     return {
       botToken: process.env.SLACK_BOT_TOKEN ?? "",
@@ -357,7 +373,7 @@ export async function startAgent(
       process.env.SENTRY_DSN ? Sentry : undefined,
       undefined, // fileDownloaderFn — default
       config.voice,
-      undefined, // transcribeAudioFn — default
+      transcribeAudio, // transcribeAudioFn — live-env wrapper
       synthesizeSpeech,
       (userId, client) => resolveDisplayName(userId, client),
       undefined, // botUserId — resolved by Bolt
@@ -461,6 +477,10 @@ export async function startAgent(
 
   if (runtimeClient && agentId) {
     let configNotFoundLogged = false;
+    const voiceEnvBaseline: Record<string, string | undefined> = {
+      ...process.env,
+    };
+    let bundleVoiceKeys = new Set<string>();
 
     async function syncConfig() {
       if (!runtimeClient || !agentId) return;
@@ -472,6 +492,16 @@ export async function startAgent(
         // federation the Anthropic credential keys never reach process.env,
         // even if a stale admin still serves them.
         const changed = applyEnvToProcess(bundle.env);
+        changed.push(
+          ...revertRemovedVoiceEnv(
+            bundleVoiceKeys,
+            bundle.env,
+            voiceEnvBaseline,
+          ),
+        );
+        bundleVoiceKeys = new Set(
+          VOICE_ENV_KEYS.filter((k) => k in bundle.env),
+        );
         if (changed.length > 0) {
           console.log(`[config-sync] updated: ${changed.join(", ")}`);
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@app-vitals/agent-runtime",
-  "version": "0.7.0",
+  "version": "0.8.0",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/app-vitals/agent.git",
@@ -40,8 +40,8 @@
     "./workspace-paths": "./workspace-paths.ts"
   },
   "dependencies": {
-    "@app-vitals/agent-admin": "0.7.0",
-    "@app-vitals/agent-lib": "0.7.0",
+    "@app-vitals/agent-admin": "0.8.0",
+    "@app-vitals/agent-lib": "0.8.0",
     "@octokit/auth-app": "^8.2.0",
     "@sentry/bun": "^10.63.0",
     "@slack/bolt": "^5.0.0",

package/voice.ts

@@ -16,6 +16,56 @@ export interface VoiceConfig {
   whisperServiceUrl?: string;
 }
 
+/** Env vars that make up VoiceConfig — the keys per-agent env may set/remove live. */
+export const VOICE_ENV_KEYS = [
+  "GROQ_API_KEY",
+  "ELEVENLABS_API_KEY",
+  "ELEVENLABS_VOICE_ID",
+  "PIPER_VOICE",
+  "WHISPER_SERVICE_URL",
+] as const;
+
+/**
+ * Resolve VoiceConfig from the live process env (COS-62.1). Per-agent env only
+ * reaches process.env via syncConfig()'s applyEnvToProcess after boot, so the
+ * boot-time `config.voice` snapshot can never contain it — mirrors
+ * buildSlackAppConfig() in boot.ts. Empty strings count as unset.
+ */
+export function buildVoiceConfig(
+  env: Record<string, string | undefined> = process.env,
+): VoiceConfig {
+  return {
+    groqApiKey: env.GROQ_API_KEY || undefined,
+    elevenLabsApiKey: env.ELEVENLABS_API_KEY || undefined,
+    voiceId: env.ELEVENLABS_VOICE_ID || undefined,
+    piperVoice: env.PIPER_VOICE || undefined,
+    whisperServiceUrl: env.WHISPER_SERVICE_URL || undefined,
+  };
+}
+
+/**
+ * applyEnvToProcess only ever sets keys, so a voice key removed from the
+ * per-agent bundle would linger in process.env until restart. Restores each
+ * previously bundle-supplied voice key that is now absent to its pre-sync
+ * value (`baseline`: the pod env, e.g. fleet-wide admin.extraEnv) or deletes
+ * it. Returns the keys reverted.
+ */
+export function revertRemovedVoiceEnv(
+  previousBundleKeys: ReadonlySet<string>,
+  bundleEnv: Record<string, string>,
+  baseline: Record<string, string | undefined>,
+  processEnv: Record<string, string | undefined> = process.env,
+): string[] {
+  const reverted: string[] = [];
+  for (const key of VOICE_ENV_KEYS) {
+    if (!previousBundleKeys.has(key) || key in bundleEnv) continue;
+    if (baseline[key] === undefined) delete processEnv[key];
+    else processEnv[key] = baseline[key];
+    reverted.push(key);
+  }
+  return reverted;
+}
+
 // DI seam for the whisper-svc HTTP client — replaces spawnFn from the old local-Whisper path
 export type WhisperClientFn = (
   audioBuffer: Buffer,
@@ -203,6 +253,7 @@ export async function synthesizeSpeech(
   mkdirSync(VOICE_DIR, { recursive: true });
 
   const elevenKey = voiceConfig.elevenLabsApiKey;
+  console.log(`[voice] TTS backend: ${elevenKey ? "elevenlabs" : "piper"}`);
   if (elevenKey) {
     return synthesizeElevenLabs(
       text,

package/voice.unit.test.ts

@@ -18,7 +18,11 @@
  */
 
 import { describe, expect, mock, test } from "bun:test";
-import { makeWhisperSvcClient } from "./voice.ts";
+import {
+  buildVoiceConfig,
+  makeWhisperSvcClient,
+  revertRemovedVoiceEnv,
+} from "./voice.ts";
 
 describe("makeWhisperSvcClient — onerahmet /asr contract", () => {
   test("POSTs to the /asr endpoint of the service URL", async () => {
@@ -103,3 +107,72 @@ describe("makeWhisperSvcClient — onerahmet /asr contract", () => {
     expect(result).toBeNull();
   });
 });
+
+describe("buildVoiceConfig — live env (COS-62.1)", () => {
+  test("picks up ELEVENLABS_* set after an earlier build (env mutation)", () => {
+    const env: Record<string, string | undefined> = {};
+    expect(buildVoiceConfig(env).elevenLabsApiKey).toBeUndefined();
+
+    env.ELEVENLABS_API_KEY = "xi-key";
+    env.ELEVENLABS_VOICE_ID = "nPczCjzI2devNBz1zQrb";
+    const cfg = buildVoiceConfig(env);
+    expect(cfg.elevenLabsApiKey).toBe("xi-key");
+    expect(cfg.voiceId).toBe("nPczCjzI2devNBz1zQrb");
+  });
+
+  test("falls back to unset once the key is removed or empty", () => {
+    const env: Record<string, string | undefined> = { ELEVENLABS_API_KEY: "k" };
+    delete env.ELEVENLABS_API_KEY;
+    expect(buildVoiceConfig(env).elevenLabsApiKey).toBeUndefined();
+    env.ELEVENLABS_API_KEY = "";
+    expect(buildVoiceConfig(env).elevenLabsApiKey).toBeUndefined();
+  });
+});
+
+describe("revertRemovedVoiceEnv", () => {
+  test("deletes a removed per-agent key with no pod baseline", () => {
+    const proc: Record<string, string | undefined> = {
+      ELEVENLABS_API_KEY: "k",
+      ELEVENLABS_VOICE_ID: "v",
+    };
+    const reverted = revertRemovedVoiceEnv(
+      new Set(["ELEVENLABS_API_KEY", "ELEVENLABS_VOICE_ID"]),
+      {},
+      {},
+      proc,
+    );
+    expect(reverted.sort()).toEqual([
+      "ELEVENLABS_API_KEY",
+      "ELEVENLABS_VOICE_ID",
+    ]);
+    expect(proc.ELEVENLABS_API_KEY).toBeUndefined();
+  });
+
+  test("restores the fleet/pod value when the per-agent override is removed", () => {
+    const proc: Record<string, string | undefined> = {
+      ELEVENLABS_API_KEY: "agent",
+    };
+    revertRemovedVoiceEnv(
+      new Set(["ELEVENLABS_API_KEY"]),
+      {},
+      { ELEVENLABS_API_KEY: "fleet" },
+      proc,
+    );
+    expect(proc.ELEVENLABS_API_KEY).toBe("fleet");
+  });
+
+  test("leaves keys alone that are still in the bundle or never came from it", () => {
+    const proc: Record<string, string | undefined> = {
+      ELEVENLABS_API_KEY: "a",
+      GROQ_API_KEY: "pod",
+    };
+    const reverted = revertRemovedVoiceEnv(
+      new Set(["ELEVENLABS_API_KEY"]),
+      { ELEVENLABS_API_KEY: "a" },
+      {},
+      proc,
+    );
+    expect(reverted).toEqual([]);
+    expect(proc.GROQ_API_KEY).toBe("pod");
+  });
+});