@app-vitals/agent-admin 0.16.2 → 1.1.0

package/src/agents-api.sentry.smoke.test.ts

@@ -247,10 +247,10 @@ function makeBaseDeps(
       listByAgentId: async () => [],
     },
     specialtyRegistry: {
-      getManifest: () => {
+      getType: () => {
         throw new Error("not implemented");
       },
-      tryGetManifest: () => undefined,
+      tryGetType: () => undefined,
       listTypes: () => [],
     },
     agentChatTokenService: {

package/src/agents-api.smoke.test.ts

@@ -22,28 +22,19 @@ import type { AgentTokenService } from "./agent-tokens.ts";
 import type { AdminDeps } from "./agents-api.ts";
 import { createAdminApp, parseAdminApiKeys } from "./agents-api.ts";
 import { PLATFORM_OPS_ROUTES } from "./api-auth.ts";
-import type { SpecialtyManifest } from "./specialty-registry.ts";
+import type { SpecialtyType } from "./specialty-types.ts";
 import { identityCrypto } from "./token-crypto.ts";
 
-// ─── Fake SpecialtyManifestResolver ────────────────────────────────────────
+// ─── Fake SpecialtyTypeResolver ────────────────────────────────────────
 //
 // Mirrors the shape used by agent-cron-jobs.unit.test.ts's fakeRegistry —
-// resolves a fixed set of manifests by specialty, with tryGetManifest()
+// resolves a fixed set of manifests by specialty, with tryGetType()
 // returning undefined (no fallback) for anything not in the map.
 
-const CODING_MANIFEST: SpecialtyManifest = {
-  apiVersion: "shipwright.dev/v1alpha1",
-  kind: "Specialty",
-  metadata: {
-    name: "coding",
-    displayName: "Coding Agent",
-    description: "test manifest",
-    version: "1.0.0",
-    skills: [],
-  },
-  identity: { templatesDir: "workspace/" },
-  crons: [],
-  plugins: ["shipwright"],
+const CODING_TYPE: SpecialtyType = {
+  name: "coding",
+  displayName: "Coding Agent",
+  templatesDir: "workspace/",
   tools: [
     "Read",
     "Write",
@@ -56,32 +47,28 @@ const CODING_MANIFEST: SpecialtyManifest = {
     "Skill",
     "Agent",
   ],
-  env: { required: [], optional: [] },
-  members: [],
-  repos: [],
-  chat: true,
-  voice: true,
+  requiredEnv: [],
 };
 
-function fakeSpecialtyRegistry(
+function fakeSpecialtyTypes(
   // The self-serve specialty is registered too: account users are forced to it
   // (the platform test run points it at the fixture specialty, not "coding").
-  byType: Record<string, SpecialtyManifest> = {
-    coding: CODING_MANIFEST,
-    [getSelfServeSpecialty()]: CODING_MANIFEST,
+  byType: Record<string, SpecialtyType> = {
+    coding: CODING_TYPE,
+    [getSelfServeSpecialty()]: CODING_TYPE,
   },
 ): AdminDeps["specialtyRegistry"] {
   return {
-    getManifest(specialty: string) {
-      return byType[specialty] ?? (byType.coding as SpecialtyManifest);
+    getType(specialty: string) {
+      return byType[specialty] ?? (byType.coding as SpecialtyType);
     },
-    tryGetManifest(specialty: string) {
+    tryGetType(specialty: string) {
       return byType[specialty];
     },
     listTypes() {
       return Object.entries(byType).map(([name, manifest]) => ({
         name,
-        displayName: manifest.metadata.displayName,
+        displayName: manifest.displayName,
       }));
     },
   };
@@ -578,7 +565,7 @@ function makeMockDeps(): AdminDeps {
         },
       ],
     },
-    specialtyRegistry: fakeSpecialtyRegistry(),
+    specialtyRegistry: fakeSpecialtyTypes(),
     agentChatTokenService: {
       upsertDailyByModel: async (
         _agentId: string,

package/src/agents-api.ts

@@ -49,10 +49,6 @@ import {
   registerAgentAskRoutes,
 } from "./agent-ask.ts";
 import type { AgentChatTokenService } from "./agent-chat-tokens.ts";
-import {
-  type CronRunNowDeps,
-  registerCronRunNowRoutes,
-} from "./cron-run-now.ts";
 import type {
   AgentCronJobService,
   AgentCronJobWithRunSummary,
@@ -93,6 +89,10 @@ import {
   memberOnlyCallerScopeResolver,
 } from "./caller-scope.ts";
 import type { ChatServiceProvisioningClient } from "./chat-service-provisioning-client.ts";
+import {
+  type CronRunNowDeps,
+  registerCronRunNowRoutes,
+} from "./cron-run-now.ts";
 import {
   type CronRunTranscriptDeps,
   registerCronRunTranscriptRoutes,
@@ -157,7 +157,7 @@ import {
 } from "./openapi-schemas.ts";
 import type { SelfServeConfig } from "./self-serve-config.ts";
 import type { SpecialtyDefaultsResolver } from "./specialty-defaults.ts";
-import type { SpecialtyManifestResolver } from "./specialty-manifest-loader.ts";
+import type { SpecialtyTypeResolver } from "./specialty-types.ts";
 import { managedReconcileTargets } from "./startup-policy-reconcile.ts";
 
 // ─── Types ────────────────────────────────────────────────────────────────────
@@ -218,15 +218,15 @@ export interface AdminDeps {
   /** Account-aware caller-scope resolver (SSP-2.1); defaults to AgentMember-only. */
   callerScopeResolver?: CallerScopeResolver;
   /**
-   * Resolves a specialty name to its parsed Specialty manifest. Consumed
+   * Resolves a specialty name to its type record. Consumed
    * by POST /agents (createAgentRoute, APA-2.1) to seed AgentTool/AgentPlugin
-   * rows from the resolved manifest during agent creation — the same
+   * rows from the resolved type during agent creation — the same
    * createAgent() call admin-ui.ts's POST /admin/agents form handler makes
    * with its own independently-constructed specialtyRegistry instance.
    * Required (not optional) because the route needs it unconditionally.
    */
-  specialtyRegistry: SpecialtyManifestResolver;
-  /** Extension-supplied specialty defaults, consulted before the manifest. */
+  specialtyRegistry: SpecialtyTypeResolver;
+  /** Extension-supplied specialty defaults, consulted before the built-in type. */
   specialtyDefaults?: SpecialtyDefaultsResolver;
   agentChatTokenService: Pick<
     AgentChatTokenService,
@@ -421,7 +421,7 @@ const GetAgentResultSchema = z
     createdAt: z.string().datetime(),
     updatedAt: z.string().datetime(),
     /**
-     * Required env keys declared by the agent's type manifest that have no
+     * Required env keys declared by the agent's type that have no
      * corresponding AgentEnv row yet — key names only, never values
      * (secrets_in_logs). Always present; informational only (ATS-4.2).
      */
@@ -585,7 +585,7 @@ const createAgentRoute = createRoute({
   path: "/agents",
   summary: "Create an agent",
   description:
-    'Admin-only. Validates name/specialty, creates the Agent row, seeds AgentTool/AgentPlugin rows from the resolved type manifest, attaches repos/allowlists/members, patches Claude credentials, and provisions Kubernetes when `runtime` is "in-cluster" — the same createAgent() implementation (APA-1.1) the web UI form at /admin/agents/new uses. Transactional: on any failure zero rows persist, and this route never returns a partial-success 200. Returns the created agent in the same shape as GET /agents/:id.',
+    'Admin-only. Validates name/specialty, creates the Agent row, seeds AgentTool/AgentPlugin rows from the resolved type, attaches repos/allowlists/members, patches Claude credentials, and provisions Kubernetes when `runtime` is "in-cluster" — the same createAgent() implementation (APA-1.1) the web UI form at /admin/agents/new uses. Transactional: on any failure zero rows persist, and this route never returns a partial-success 200. Returns the created agent in the same shape as GET /agents/:id.',
   request: {
     body: {
       content: { "application/json": { schema: CreateAgentBodySchema } },
@@ -606,7 +606,7 @@ const getAgentRoute = createRoute({
   path: "/agents/{id}",
   summary: "Get an agent",
   description:
-    "Admin-only. Returns the full agent record including `selfHosted`, `repos`, `reviewAuthorAllowlist`, `patchAuthorAllowlist`, `restrictSlackToMembers`, `specialty`, `accountId` (null for unassigned agents), and `missingRequiredEnv` — required env keys declared by the agent's type manifest with no corresponding AgentEnv row yet (informational only).",
+    "Admin-only. Returns the full agent record including `selfHosted`, `repos`, `reviewAuthorAllowlist`, `patchAuthorAllowlist`, `restrictSlackToMembers`, `specialty`, `accountId` (null for unassigned agents), and `missingRequiredEnv` — required env keys declared by the agent's type with no corresponding AgentEnv row yet (informational only).",
   request: { params: AgentIdParamSchema },
   responses: {
     200: {
@@ -809,7 +809,7 @@ const reconcileCronsRoute = createRoute({
   path: "/agents/{id}/crons/reconcile",
   summary: "Reconcile system crons",
   description:
-    "Reconciles the agent's system crons against the cron list declared by its Specialty manifest. Runs in three passes within a single transaction: create-or-update matched-by-name system crons (preserving IDs so run history survives), link/unlink parent-child cron relationships, and delete orphaned system crons no longer in the manifest. Called automatically on agent startup; returns created/updated/deleted counts.",
+    "Reconciles the agent's system crons against the cron list supplied by the AdminExtension for its specialty. Runs in three passes within a single transaction: create-or-update matched-by-name system crons (preserving IDs so run history survives), link/unlink parent-child cron relationships, and delete orphaned system crons no longer in the defaults. Called automatically on agent startup; returns created/updated/deleted counts.",
   request: { params: AgentIdParamSchema },
   responses: {
     200: {

package/src/agents.integration.test.ts

@@ -26,11 +26,13 @@ import { AgentMemberService } from "./agent-members.ts";
 import { AgentPluginService } from "./agent-plugins.ts";
 import type { AgentProvisioner, ProvisionResult } from "./agent-provisioner.ts";
 import { AgentToolService } from "./agent-tools.ts";
-import type { SpecialtyManifestResolver } from "./specialty-manifest-loader.ts";
-import type { SpecialtyManifest } from "./specialty-registry.ts";
 import type { CreateAgentDeps } from "./agents.ts";
 import { AgentService, createAgent } from "./agents.ts";
 import { createAdminPrismaClient } from "./prisma-client.ts";
+import type {
+  SpecialtyType,
+  SpecialtyTypeResolver,
+} from "./specialty-types.ts";
 import { makeTokenCrypto } from "./token-crypto.ts";
 
 const TEST_DB = process.env.DATABASE_URL_ADMIN_TEST;
@@ -42,35 +44,22 @@ function makePrisma(): PrismaClient {
 }
 
 /** A minimal valid "coding" manifest, matching agents-api.integration.test.ts's fixture. */
-const CODING_MANIFEST: SpecialtyManifest = {
-  apiVersion: "shipwright.dev/v1alpha1",
-  kind: "Specialty",
-  metadata: {
-    name: "coding",
-    displayName: "Coding Agent",
-    description: "test manifest",
-    version: "1.0.0",
-    skills: [],
-  },
-  identity: { templatesDir: "workspace/" },
-  crons: [],
-  plugins: ["shipwright"],
+const CODING_TYPE: SpecialtyType = {
+  name: "coding",
+  displayName: "Coding Agent",
+  templatesDir: "workspace/",
   tools: ["Read", "Write", "Edit", "Bash"],
-  env: { required: [], optional: [] },
-  members: [],
-  repos: [],
-  chat: true,
-  voice: true,
+  requiredEnv: [],
 };
 
-function fakeSpecialtyRegistry(
-  byType: Record<string, SpecialtyManifest> = { coding: CODING_MANIFEST },
-): SpecialtyManifestResolver {
+function fakeSpecialtyTypes(
+  byType: Record<string, SpecialtyType> = { coding: CODING_TYPE },
+): SpecialtyTypeResolver {
   return {
-    getManifest(specialty: string): SpecialtyManifest {
-      return byType[specialty] ?? (byType.coding as SpecialtyManifest);
+    getType(specialty: string): SpecialtyType {
+      return byType[specialty] ?? (byType.coding as SpecialtyType);
     },
-    tryGetManifest(specialty: string): SpecialtyManifest | undefined {
+    tryGetType(specialty: string): SpecialtyType | undefined {
       return byType[specialty];
     },
     listTypes() {
@@ -130,7 +119,7 @@ describeOrSkip("createAgent() — integration (real Postgres)", () => {
 
   beforeEach(async () => {
     prisma = makePrisma();
-    agentService = new AgentService(prisma, fakeSpecialtyRegistry());
+    agentService = new AgentService(prisma, fakeSpecialtyTypes());
     agentToolService = new AgentToolService(prisma);
     agentPluginService = new AgentPluginService(prisma);
     agentMemberService = new AgentMemberService(prisma);
@@ -141,7 +130,7 @@ describeOrSkip("createAgent() — integration (real Postgres)", () => {
     agentCronJobService = new AgentCronJobService(
       prisma,
       undefined,
-      fakeSpecialtyRegistry(),
+      fakeSpecialtyTypes(),
     );
 
     // Truncate between tests — this suite shares a DB with every other
@@ -171,7 +160,8 @@ describeOrSkip("createAgent() — integration (real Postgres)", () => {
       agentEnvService,
       agentCronJobService,
       provisioner: makeProvisioner(),
-      specialtyRegistry: fakeSpecialtyRegistry(),
+      specialtyRegistry: fakeSpecialtyTypes(),
+      specialtyDefaults: () => ({ plugins: ["shipwright"] }),
       ...overrides,
     };
   }
@@ -205,7 +195,7 @@ describeOrSkip("createAgent() — integration (real Postgres)", () => {
       where: { agentId: result.agent.id },
     });
     expect(tools.map((t) => t.pattern).sort()).toEqual(
-      [...CODING_MANIFEST.tools].sort(),
+      [...CODING_TYPE.tools].sort(),
     );
 
     const plugins = await prisma.agentPlugin.findMany({
@@ -518,7 +508,7 @@ describeOrSkip("Agent.specialty — final shape (AGR-6.3)", () => {
 
   beforeEach(() => {
     prisma = makePrisma();
-    agentService = new AgentService(prisma, fakeSpecialtyRegistry());
+    agentService = new AgentService(prisma, fakeSpecialtyTypes());
   });
 
   afterEach(async () => {

package/src/agents.ts

@@ -19,13 +19,13 @@ import { AgentMemberService } from "./agent-members.ts";
 import type { AgentPluginService } from "./agent-plugins.ts";
 import type { AgentProvisioner } from "./agent-provisioner.ts";
 import type { AgentToolService } from "./agent-tools.ts";
-import {
-  type SpecialtyManifestResolver,
-  SpecialtyRegistry,
-} from "./specialty-manifest-loader.ts";
-import type { SpecialtyDefaultsResolver } from "./specialty-defaults.ts";
 import { ANTHROPIC_CREDENTIALS_BLOCKED_CODE } from "./anthropic-credential-guard.ts";
 import type { PrismaTransactionClient } from "./prisma-tx.ts";
+import type { SpecialtyDefaultsResolver } from "./specialty-defaults.ts";
+import {
+  type SpecialtyTypeResolver,
+  SpecialtyTypes,
+} from "./specialty-types.ts";
 
 // ─── Types ────────────────────────────────────────────────────────────────────
 
@@ -35,7 +35,7 @@ interface CreateAgentInput {
   selfHosted?: boolean;
   /** Specialty name. Omitted means Prisma's column default ("specialist") applies. */
   specialty?: string;
-  /** Initial repos[] — the manifest repos merged with any request-supplied repos. */
+  /** Initial repos[] from the request. */
   repos?: string[];
   /** Initial reviewAuthorAllowlist[]. */
   reviewAuthorAllowlist?: string[];
@@ -108,7 +108,7 @@ export interface AgentDetail extends Partial<AgentAnthropicIdentity> {
   createdAt: Date;
   updatedAt: Date;
   /**
-   * Required env keys declared by the agent's type manifest that have no
+   * Required env keys declared by the agent's type that have no
    * corresponding AgentEnv row yet — key names only, never values
    * (secrets_in_logs). Always present (empty array when the type's required
    * contract is empty or every required key is set). Informational only —
@@ -302,7 +302,7 @@ const DETAIL_SELECT = {
 export class AgentService {
   constructor(
     private prisma: PrismaClient,
-    private specialtyRegistry: SpecialtyManifestResolver = new SpecialtyRegistry(),
+    private specialtyRegistry: SpecialtyTypeResolver = new SpecialtyTypes(),
     private agentMemberService: Pick<
       AgentMemberService,
       "listByAgentId"
@@ -407,11 +407,11 @@ export class AgentService {
   }
 
   /**
-   * The env-contract gap: the type manifest's required env keys minus the
+   * The env-contract gap: the type's required env keys minus the
    * keys already present in this agent's AgentEnv rows (key names only,
    * never values — the AgentEnv query below selects only `key`, never
    * `value`, so decrypted secrets can never reach this computation).
-   * Skips the AgentEnv query entirely when the manifest declares no required
+   * Skips the AgentEnv query entirely when the type declares no required
    * keys. Purely informational: never blocks create or gates provisioning
    * (ATS-4.2).
    */
@@ -420,9 +420,7 @@ export class AgentService {
     specialty: string,
     client: PrismaTransactionClient = this.prisma,
   ): Promise<string[]> {
-    const requiredKeys = this.specialtyRegistry
-      .getManifest(specialty)
-      .env.required.map((entry) => entry.key);
+    const requiredKeys = this.specialtyRegistry.getType(specialty).requiredEnv;
 
     if (requiredKeys.length === 0) return [];
 
@@ -785,10 +783,10 @@ export interface CreateAgentDeps {
   agentCronJobService: Pick<AgentCronJobService, "reconcileSystemCrons">;
   provisioner: Pick<AgentProvisioner, "canProvision" | "provision">;
   specialtyRegistry: Pick<
-    SpecialtyManifestResolver,
-    "tryGetManifest" | "hasExtensionType"
+    SpecialtyTypeResolver,
+    "tryGetType" | "hasExtensionType"
   >;
-  /** Extension-supplied tools/plugins, consulted before the manifest's. */
+  /** Extension-supplied tools/plugins, consulted before the type's tools floor. */
   specialtyDefaults?: SpecialtyDefaultsResolver;
   /** WIF-2.1: Anthropic federation is enabled; defaults to false. */
   anthropicFederationEnabled?: boolean;
@@ -839,7 +837,7 @@ type CreateAgentTxOutcome =
 
 /**
  * Atomically create an agent: validate name/specialty, create the Agent row,
- * seed AgentTool/AgentPlugin from the resolved type manifest, attach
+ * seed AgentTool/AgentPlugin from the resolved type, attach
  * repos/allowlists/members, patch Claude credentials, provision Kubernetes
  * resources when requested, and best-effort reconcile system crons.
  *
@@ -878,18 +876,18 @@ export async function createAgent(
   }
 
   // Resolve the requested type BEFORE creating any row — an unknown/missing
-  // type must fail with zero rows created. The resolved manifest is
-  // captured (not discarded) so its tools/plugins can be seeded below.
+  // type must fail with zero rows created. The resolved type is
+  // captured (not discarded) so its tools can be seeded below.
   const specialty = input.specialty;
-  const manifest = specialty
-    ? deps.specialtyRegistry.tryGetManifest(specialty)
+  const type = specialty
+    ? deps.specialtyRegistry.tryGetType(specialty)
     : undefined;
   const extensionDefaults = specialty
     ? deps.specialtyDefaults?.(specialty)
     : undefined;
   if (
     !specialty ||
-    (!manifest &&
+    (!type &&
       !extensionDefaults &&
       !deps.specialtyRegistry.hasExtensionType?.(specialty))
   ) {
@@ -947,21 +945,16 @@ export async function createAgent(
         tx,
       );
 
-      // Seed AgentTool/AgentPlugin rows from the resolved manifest. Roll the
-      // agent row back on any seeding failure so a retry with the same name
-      // doesn't collide with a half-seeded agent. Members/repos are NOT
-      // seeded from the manifest here — they have their own dedicated
-      // handling below, and the manifest's members/repos arrays are empty
-      // for every specialty that exists today.
+      // Seed AgentTool/AgentPlugin rows from the extension's defaults, else
+      // the type's tools floor. Roll the agent row back on any seeding
+      // failure so a retry with the same name doesn't collide with a
+      // half-seeded agent. Members/repos have their own dedicated handling
+      // below.
       try {
-        for (const pattern of extensionDefaults?.tools ??
-          manifest?.tools ??
-          []) {
+        for (const pattern of extensionDefaults?.tools ?? type?.tools ?? []) {
           await deps.agentToolService.add(agent.id, pattern, tx);
         }
-        for (const pluginName of extensionDefaults?.plugins ??
-          manifest?.plugins ??
-          []) {
+        for (const pluginName of extensionDefaults?.plugins ?? []) {
           await deps.agentPluginService.add(
             agent.id,
             pluginName,

package/src/agents.unit.test.ts

@@ -7,8 +7,6 @@
 
 import { describe, expect, it } from "bun:test";
 import { DEFAULT_AGENT_ENV } from "@app-vitals/agent-lib/default-agent-env";
-import type { SpecialtyManifestResolver } from "./specialty-manifest-loader.ts";
-import type { SpecialtyManifest } from "./specialty-registry.ts";
 import type {
   AgentDetail,
   CreateAgentDeps,
@@ -17,6 +15,11 @@ import type {
 } from "./agents.ts";
 import { AgentService, createAgent, resolveOwnerEmail } from "./agents.ts";
 import type { PrismaTransactionClient } from "./prisma-tx.ts";
+import {
+  SPECIALIST_TYPE,
+  type SpecialtyType,
+  type SpecialtyTypeResolver,
+} from "./specialty-types.ts";
 
 // ─── In-memory prisma.agent test double ────────────────────────────────────
 
@@ -255,24 +258,15 @@ type FakePrisma = ReturnType<typeof makeFakePrisma>;
  * fakeRegistry() pattern in agent-cron-jobs.unit.test.ts. */
 function fakeRegistry(
   requiredEnvByType: Record<string, string[]>,
-): SpecialtyManifestResolver {
+): SpecialtyTypeResolver {
   return {
-    getManifest(specialty: string): SpecialtyManifest {
+    getType(specialty: string): SpecialtyType {
       const required = requiredEnvByType[specialty] ?? [];
-      return {
-        env: {
-          required: required.map((key) => ({
-            key,
-            description: `${key} description`,
-            secret: true,
-          })),
-          optional: [],
-        },
-      } as unknown as SpecialtyManifest;
+      return { ...SPECIALIST_TYPE, requiredEnv: required };
     },
-    tryGetManifest(specialty: string): SpecialtyManifest | undefined {
+    tryGetType(specialty: string): SpecialtyType | undefined {
       if (!(specialty in requiredEnvByType)) return undefined;
-      return this.getManifest(specialty);
+      return this.getType(specialty);
     },
     listTypes() {
       return Object.keys(requiredEnvByType).map((name) => ({
@@ -1119,32 +1113,19 @@ describe("AgentService.updateFields", () => {
 // criterion this whole task is about) is covered separately by
 // agents.integration.test.ts against a real DB.
 
-const CODING_MANIFEST: SpecialtyManifest = {
-  apiVersion: "shipwright.dev/v1alpha1",
-  kind: "Specialty",
-  metadata: {
-    name: "coding",
-    displayName: "Coding Agent",
-    description: "test manifest",
-    version: "1.0.0",
-    skills: [],
-  },
-  identity: { templatesDir: "workspace/" },
-  crons: [],
-  plugins: ["shipwright"],
+const CODING_TYPE: SpecialtyType = {
+  name: "coding",
+  displayName: "Coding Agent",
+  templatesDir: "workspace/",
   tools: ["Read", "Write", "Bash"],
-  env: { required: [], optional: [] },
-  members: [],
-  repos: [],
-  chat: true,
-  voice: true,
-} as unknown as SpecialtyManifest;
-
-function fakeCreateSpecialtyRegistry(
-  byType: Record<string, SpecialtyManifest> = { coding: CODING_MANIFEST },
-): Pick<SpecialtyManifestResolver, "tryGetManifest"> {
+  requiredEnv: [],
+};
+
+function fakeCreateSpecialtyTypes(
+  byType: Record<string, SpecialtyType> = { coding: CODING_TYPE },
+): Pick<SpecialtyTypeResolver, "tryGetType"> {
   return {
-    tryGetManifest: (specialty: string) => byType[specialty],
+    tryGetType: (specialty: string) => byType[specialty],
   };
 }
 
@@ -1166,7 +1147,7 @@ interface CreateAgentHarnessCalls {
 
 function makeCreateAgentHarness(
   opts: {
-    manifests?: Record<string, SpecialtyManifest>;
+    manifests?: Record<string, SpecialtyType>;
     canProvision?: boolean;
     provisionImpl?: (agentId: string) => Promise<unknown>;
     toolAddImpl?: (agentId: string, pattern: string) => Promise<unknown>;
@@ -1283,7 +1264,7 @@ function makeCreateAgentHarness(
     },
   };
 
-  const specialtyRegistry = fakeCreateSpecialtyRegistry(opts.manifests);
+  const specialtyRegistry = fakeCreateSpecialtyTypes(opts.manifests);
 
   return {
     deps: {
@@ -1320,7 +1301,7 @@ function baseCreateAgentInput(
 }
 
 describe("createAgent() specialtyDefaults hook", () => {
-  it("seeds tools and plugins from the hook instead of the manifest", async () => {
+  it("seeds tools and plugins from the hook instead of the type", async () => {
     const { deps, calls } = makeCreateAgentHarness();
     deps.specialtyDefaults = () => ({
       tools: ["Grep"],
@@ -1334,18 +1315,16 @@ describe("createAgent() specialtyDefaults hook", () => {
     expect(calls.pluginsAdded.map((p) => p.name)).toEqual(["ext-plugin"]);
   });
 
-  it("falls back to the manifest when the hook returns nothing", async () => {
+  it("falls back to the type's tools floor when the hook returns nothing", async () => {
     const { deps, calls } = makeCreateAgentHarness();
     deps.specialtyDefaults = () => undefined;
 
     await createAgent(deps, baseCreateAgentInput());
 
-    expect(calls.toolsAdded.map((t) => t.pattern)).toEqual(
-      CODING_MANIFEST.tools,
-    );
-    expect(calls.pluginsAdded.map((p) => p.name)).toEqual(
-      CODING_MANIFEST.plugins,
-    );
+    expect(calls.toolsAdded.map((t) => t.pattern)).toEqual([
+      ...CODING_TYPE.tools,
+    ]);
+    expect(calls.pluginsAdded).toEqual([]);
   });
 
   it("falls back per field when the hook omits tools or plugins", async () => {
@@ -1354,9 +1333,9 @@ describe("createAgent() specialtyDefaults hook", () => {
 
     await createAgent(deps, baseCreateAgentInput());
 
-    expect(calls.toolsAdded.map((t) => t.pattern)).toEqual(
-      CODING_MANIFEST.tools,
-    );
+    expect(calls.toolsAdded.map((t) => t.pattern)).toEqual([
+      ...CODING_TYPE.tools,
+    ]);
     expect(calls.pluginsAdded.map((p) => p.name)).toEqual(["ext-plugin"]);
   });
 
@@ -1533,7 +1512,7 @@ describe("createAgent()", () => {
     expect(calls.created).toEqual([]);
   });
 
-  it("happy path: creates the agent, seeds manifest tools/plugins, attaches repos/allowlists/members, and reconciles crons", async () => {
+  it("happy path: creates the agent, seeds the type's tools, attaches repos/allowlists/members, and reconciles crons", async () => {
     const { deps, calls } = makeCreateAgentHarness({ canProvision: false });
 
     const result = await createAgent(
@@ -1557,7 +1536,7 @@ describe("createAgent()", () => {
       "Write",
       "Bash",
     ]);
-    expect(calls.pluginsAdded.map((p) => p.name)).toEqual(["shipwright"]);
+    expect(calls.pluginsAdded).toEqual([]);
     expect(calls.updateFieldsCalls).toEqual([
       { id: result.agent.id, fields: { repos: ["org/repo1", "org/repo2"] } },
       {
@@ -1615,6 +1594,7 @@ describe("createAgent()", () => {
         throw new Error("boom: plugin seeding failed");
       },
     });
+    deps.specialtyDefaults = () => ({ plugins: ["ext-plugin"] });
 
     const result = await createAgent(deps, baseCreateAgentInput());
 

package/src/api.smoke.test.ts

@@ -824,10 +824,10 @@ function buildCombinedApp() {
       runTransaction: async (fn) => fn(undefined as never),
     },
     specialtyRegistry: {
-      getManifest: () => {
+      getType: () => {
         throw new Error("not implemented");
       },
-      tryGetManifest: () => undefined,
+      tryGetType: () => undefined,
       listTypes: () => [],
     },
     agentEnvService: {

package/src/api.ts

@@ -66,7 +66,7 @@ export interface AgentConfigResponse {
    */
   accountStatus?: string | null;
   /**
-   * ARD-6.1: the agent's Specialty name (e.g. "coding"), read by the agent
+   * ARD-6.1: the agent's Specialty name (e.g. "specialist"), read by the agent
    * runtime to pick its workspace template directory.
    */
   specialty: string;

package/src/chat-service-provisioning-client.integration.test.ts

@@ -6,7 +6,7 @@
  * Drives the client through an INJECTED fetchFn that replays canned Responses
  * from a cassette keyed by scenario — no live API server, no global.fetch
  * override, no mock.module(). Mirrors the pattern in
- * task-store-provisioning-client.integration.test.ts.
+ * the other provisioning-client integration tests.
  */
 
 import { describe, expect, it } from "bun:test";