@app-vitals/agent-admin 0.16.1 → 1.0.0

package/src/admin-ui-pages.ts

@@ -28,7 +28,7 @@ import type {
   ThreadStats,
 } from "./http-chat-client.ts";
 import { renderPushToggle } from "./push-toggle.ts";
-import type { SpecialtyOption } from "./specialty-manifest-loader.ts";
+import type { SpecialtyOption } from "./specialty-types.ts";
 
 // ─── Helpers ──────────────────────────────────────────────────────────────────
 
@@ -83,7 +83,7 @@ export interface AgentDetail {
   /** The agent's type name (e.g. "specialist"), resolved at creation time. */
   specialty: string;
   /**
-   * Required env keys declared by the agent's type manifest with no
+   * Required env keys declared by the agent's type with no
    * corresponding AgentEnv row yet — key names only, never values. Always
    * present; purely informational (ATS-4.2), see renderAgentDetailPage's Env
    * Vars card.
@@ -2351,7 +2351,7 @@ const STALL_INDICATOR_CLASS = "chat-stall-indicator";
  * hard stop.
  */
 export const STALL_WARN_AFTER_MS = 120_000;
-// 65min — mirrors lib/claim-ttl.ts's DEFAULT_CLAIM_TTL_MS
+// 65min — mirrors DEFAULT_CLAIM_TTL_MS (Shipwright claim-ttl)
 // (DEFAULT_CLAUDE_TIMEOUT_MS 1hr + CLAIM_TTL_BUFFER_MS 5min). Inline JS can't
 // import the lib file, so the value is hardcoded here with this reference.
 export const ABSOLUTE_MAX_MS = 3_900_000;
@@ -2886,7 +2886,7 @@ export function renderChatThreadPage(
 
   // Stall-warning threshold — 120s in prod; e2e overrides to a tiny value.
   var STALL_WARN_AFTER_MS = ${stallWarnAfterMs};
-  // Hard ceiling: 65min, mirrors lib/claim-ttl.ts DEFAULT_CLAIM_TTL_MS
+  // Hard ceiling: 65min, mirrors Shipwright's DEFAULT_CLAIM_TTL_MS
   // (1hr DEFAULT_CLAUDE_TIMEOUT_MS + 5min CLAIM_TTL_BUFFER_MS). Only hard stop.
   var ABSOLUTE_MAX_MS = ${ABSOLUTE_MAX_MS};
 

package/src/admin-ui.smoke.test.ts

@@ -7,11 +7,11 @@
  */
 
 import { beforeAll, describe, expect, it } from "bun:test";
-import { existsSync } from "node:fs";
+import { existsSync, mkdtempSync } from "node:fs";
+import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { sign } from "hono/jwt";
-import { createAdminUIApp } from "./admin-ui.ts";
-import { SpecialtyRegistry } from "./specialty-manifest-loader.ts";
+import { withExtensionAgentTypes } from "./admin-extension.ts";
 import {
   AGENT_ID,
   CRON_ID,
@@ -26,16 +26,22 @@ import {
   TOKEN_ID,
   TOOL_ID,
 } from "./admin-ui.fixtures.ts";
+import { createAdminUIApp } from "./admin-ui.ts";
 import { AnthropicCredentialsBlockedError } from "./anthropic-credential-guard.ts";
 import type { PushService } from "./push-service.ts";
+import {
+  resolveDefaultSpecialtyName,
+  SPECIALIST_TYPE,
+  SpecialtyTypes,
+} from "./specialty-types.ts";
 
 // The specialty the create-agent flows use: the configured default type (the
 // platform test run points it at the fixture specialty; the monorepo falls
 // back to "coding").
-const TYPE_MANIFEST = new SpecialtyRegistry().getManifest(
-  process.env.SHIPWRIGHT_DEFAULT_AGENT_TYPE || "coding",
-);
-const TYPE = TYPE_MANIFEST.metadata.name;
+const TYPE = resolveDefaultSpecialtyName();
+const TYPE_RECORD = new SpecialtyTypes()
+  .listTypes()
+  .find((t) => t.name === TYPE) as { name: string; displayName: string };
 
 // ─── Auth redirect tests ──────────────────────────────────────────────────────
 
@@ -1288,7 +1294,7 @@ describe("admin UI — authenticated pages", () => {
       '<select id="type" name="type" class="form-input" required>',
     );
     expect(html).toContain(
-      `<option value="${TYPE}">${TYPE_MANIFEST.metadata.displayName}</option>`,
+      `<option value="${TYPE}">${TYPE_RECORD.displayName}</option>`,
     );
   });
 
@@ -5549,14 +5555,14 @@ describe("admin UI — create agent with patch author allowlist", () => {
   });
 });
 
-describe("admin UI — create agent seeds manifest tools and plugins", () => {
+describe("admin UI — create agent seeds type tools and extension plugins", () => {
   let cookie: string;
 
   beforeAll(async () => {
     cookie = await makeSessionCookie();
   });
 
-  it("POST /admin/agents with the default type seeds an AgentTool row for every manifest tool and an AgentPlugin row for every manifest plugin", async () => {
+  it("POST /admin/agents with the default type seeds an AgentTool row for every type tool and no AgentPlugin rows", async () => {
     const seededTools: string[] = [];
     const seededPlugins: string[] = [];
     const deps = makeMockDeps();
@@ -5594,28 +5600,13 @@ describe("admin UI — create agent seeds manifest tools and plugins", () => {
     });
     expect(res.status).toBe(302);
     expect(res.headers.get("Location")).toBe(`/admin/agents/${AGENT_ID}`);
-    expect(seededTools).toEqual(TYPE_MANIFEST.tools);
+    expect(seededTools).toEqual([...SPECIALIST_TYPE.tools]);
     expect(seededTools).toContain("Bash");
-    expect(seededPlugins).toEqual(TYPE_MANIFEST.plugins);
-  });
-
-  it("POST /admin/agents with the fixture specialty (AGR-1.9) seeds from its manifest and needs no product specialty", async () => {
-    const fixtureDir = [
-      join(
-        import.meta.dir,
-        "..",
-        "..",
-        "agent",
-        "src",
-        "fixtures",
-        "specialties",
-      ),
-      join(import.meta.dir, "..", "..", "runtime", "fixtures", "specialties"),
-    ].find((dir) => existsSync(dir)) as string;
-    const registry = new SpecialtyRegistry({
-      typesDir: fixtureDir,
-      defaultTypeName: "fixture",
-    });
+    expect(seededPlugins).toEqual([]);
+  });
+
+  it("POST /admin/agents with the configured default type (AGR-1.9) seeds the specialist floor and needs no product specialty", async () => {
+    const registry = new SpecialtyTypes({ defaultTypeName: "fixture" });
     const seededTools: string[] = [];
     const seededPlugins: string[] = [];
     const deps = makeMockDeps();
@@ -5647,7 +5638,7 @@ describe("admin UI — create agent seeds manifest tools and plugins", () => {
       headers: { Cookie: `admin_session=${cookie}` },
     });
     expect(await form.text()).toContain(
-      '<option value="fixture">Fixture Agent</option>',
+      '<option value="fixture">fixture</option>',
     );
     const res = await app.request("/admin/agents", {
       method: "POST",
@@ -5662,8 +5653,36 @@ describe("admin UI — create agent seeds manifest tools and plugins", () => {
     });
     expect(res.status).toBe(302);
     expect(res.headers.get("Location")).toBe(`/admin/agents/${AGENT_ID}`);
-    expect(seededTools).toEqual(registry.getManifest("fixture").tools);
-    expect(seededPlugins).toEqual(["fixture-plugin"]);
+    expect(seededTools).toEqual([...registry.getType("fixture").tools]);
+    expect(seededPlugins).toEqual([]);
+  });
+
+  it("an extension-contributed type (ETP-1.2) shows in the picker and POST /admin/agents accepts it", async () => {
+    const registry = withExtensionAgentTypes(new SpecialtyTypes(), [
+      { agentTypes: () => [{ name: "coding", displayName: "Coding Agent" }] },
+    ]);
+    const deps = makeMockDeps();
+    deps.specialtyRegistry = registry;
+    const app = createAdminUIApp(deps);
+    const form = await app.request("/admin/agents/new", {
+      headers: { Cookie: `admin_session=${cookie}` },
+    });
+    expect(await form.text()).toContain(
+      '<option value="coding">Coding Agent</option>',
+    );
+    const res = await app.request("/admin/agents", {
+      method: "POST",
+      body: new URLSearchParams({
+        name: "Ext Agent",
+        type: "coding",
+      }).toString(),
+      headers: {
+        "Content-Type": "application/x-www-form-urlencoded",
+        Cookie: `admin_session=${cookie}`,
+      },
+    });
+    expect(res.status).toBe(302);
+    expect(res.headers.get("Location")).toBe(`/admin/agents/${AGENT_ID}`);
   });
 
   it("POST /admin/agents rolls back the agent and redirects with error when tool seeding fails", async () => {
@@ -5701,6 +5720,7 @@ describe("admin UI — create agent seeds manifest tools and plugins", () => {
   it("POST /admin/agents rolls back the agent and redirects with error when plugin seeding fails", async () => {
     let deletedId: string | undefined;
     const deps = makeMockDeps();
+    deps.specialtyDefaults = () => ({ plugins: ["ext-plugin"] });
     deps.agentPluginService = {
       ...deps.agentPluginService,
       add: async () => {

package/src/admin-ui.ts

@@ -74,11 +74,6 @@ import type { AgentPluginService } from "./agent-plugins.ts";
 import type { AgentProvisioner } from "./agent-provisioner.ts";
 import type { AgentTokenService } from "./agent-tokens.ts";
 import type { AgentToolService } from "./agent-tools.ts";
-import {
-  type SpecialtyManifestResolver,
-  SpecialtyRegistry,
-} from "./specialty-manifest-loader.ts";
-import type { SpecialtyDefaultsResolver } from "./specialty-defaults.ts";
 import type { AgentService } from "./agents.ts";
 import { createAgent, describeRepoNameCollision } from "./agents.ts";
 import { AnthropicCredentialsBlockedError } from "./anthropic-credential-guard.ts";
@@ -86,7 +81,6 @@ import {
   audioContentTypeForFilename,
   validateAttachment,
 } from "./attachment-validation.ts";
-import { parseByteRange } from "./http-range.ts";
 import {
   type CallerScopeResolver,
   memberOnlyCallerScopeResolver,
@@ -105,6 +99,7 @@ import {
   filterSince,
   toPolledMessage,
 } from "./http-chat-client.ts";
+import { parseByteRange } from "./http-range.ts";
 import type { OktaAuthClient } from "./okta-auth-client.ts";
 import type { PrismaTransactionClient } from "./prisma-tx.ts";
 import type { PushService } from "./push-service.ts";
@@ -132,6 +127,11 @@ import {
   PROVISION_STATE_TTL_SECONDS,
   SlackProvisioningService,
 } from "./slack-provisioning-service.ts";
+import type { SpecialtyDefaultsResolver } from "./specialty-defaults.ts";
+import {
+  type SpecialtyTypeResolver,
+  SpecialtyTypes,
+} from "./specialty-types.ts";
 
 export type AdminUIEnv = { Variables: { userEmail: string; isAdmin: boolean } };
 
@@ -347,13 +347,13 @@ export interface AdminUIDeps {
   /** WIF-2.1: Anthropic federation is enabled; defaults to false. */
   anthropicFederationEnabled?: boolean;
   /**
-   * Resolves an agent's specialty to its parsed Specialty manifest and lists
-   * the registry's discoverable types (for the new-specialty picker).
-   * Defaults to a disk-backed SpecialtyRegistry, matching the DI pattern
+   * Resolves an agent's specialty to its type record and lists
+   * the registry's built-in types (for the new-specialty picker).
+   * Defaults to a disk-backed SpecialtyTypes, matching the DI pattern
    * already used by agents-api.ts's AdminDeps.
    */
-  specialtyRegistry?: SpecialtyManifestResolver;
-  /** Extension-supplied specialty defaults, consulted before the manifest. */
+  specialtyRegistry?: SpecialtyTypeResolver;
+  /** Extension-supplied specialty defaults, consulted before the built-in type. */
   specialtyDefaults?: SpecialtyDefaultsResolver;
   /**
    * Cleanup deps for the full delete-agent orchestration (POST
@@ -784,7 +784,7 @@ export function createAdminUIApp(deps: AdminUIDeps): Hono<AdminUIEnv> {
     accountOnboarding,
     accountCreatedNotifier,
     accountServices,
-    specialtyRegistry = new SpecialtyRegistry(),
+    specialtyRegistry = new SpecialtyTypes(),
     specialtyDefaults,
     callerScopeResolver = memberOnlyCallerScopeResolver(agentMemberService),
     serviceIntegrations,

package/src/agent-chat-tokens.smoke.test.ts

@@ -222,10 +222,10 @@ function makeMockDeps(opts?: {
       listByAgentId: async () => [],
     },
     specialtyRegistry: {
-      getManifest: () => {
+      getType: () => {
         throw new Error("not implemented");
       },
-      tryGetManifest: () => undefined,
+      tryGetType: () => undefined,
       listTypes: () => [],
     },
     agentChatTokenService: {

package/src/agent-cron-jobs.integration.test.ts

@@ -18,8 +18,14 @@ import {
 import { AgentCronJobService } from "./agent-cron-jobs.ts";
 import { NotFoundError, UnprocessableEntityError } from "./errors.ts";
 import { createAdminPrismaClient } from "./prisma-client.ts";
-import type { SpecialtyManifestResolver } from "./specialty-manifest-loader.ts";
-import type { SpecialtyManifest } from "./specialty-registry.ts";
+import type {
+  SpecialtyDefaultCron,
+  SpecialtyDefaultsResolver,
+} from "./specialty-defaults.ts";
+import {
+  SPECIALIST_TYPE,
+  type SpecialtyTypeResolver,
+} from "./specialty-types.ts";
 
 const TEST_DB = process.env.DATABASE_URL_ADMIN_TEST;
 
@@ -34,9 +40,7 @@ function makePrisma(): PrismaClient {
 // cron, covering every field reconcile maps into a row.
 const FIXTURE_TYPE = "fixture";
 
-type ManifestCron = SpecialtyManifest["crons"][number];
-
-const FIXTURE_CRONS: ManifestCron[] = [
+const FIXTURE_CRONS: SpecialtyDefaultCron[] = [
   {
     name: "fixture-loop",
     schedule: "*/30 * * * *",
@@ -70,23 +74,16 @@ const FIXTURE_CRONS: ManifestCron[] = [
   },
 ];
 
-const fixtureManifest = {
-  crons: FIXTURE_CRONS,
-} as unknown as SpecialtyManifest;
+/** The extension hook supplying FIXTURE_TYPE's crons. */
+const fixtureDefaults: SpecialtyDefaultsResolver = (specialty) =>
+  specialty === FIXTURE_TYPE ? { crons: FIXTURE_CRONS } : undefined;
 
 /** Resolves only FIXTURE_TYPE; every other type is unknown. */
-const fixtureResolver: SpecialtyManifestResolver = {
-  getManifest(specialty: string): SpecialtyManifest {
-    if (specialty !== FIXTURE_TYPE)
-      throw new Error(`no manifest: ${specialty}`);
-    return fixtureManifest;
-  },
-  tryGetManifest(specialty: string): SpecialtyManifest | undefined {
-    return specialty === FIXTURE_TYPE ? fixtureManifest : undefined;
-  },
-  listTypes() {
-    return [{ name: FIXTURE_TYPE, displayName: FIXTURE_TYPE }];
-  },
+const fixtureResolver: SpecialtyTypeResolver = {
+  getType: () => SPECIALIST_TYPE,
+  tryGetType: (specialty) =>
+    specialty === FIXTURE_TYPE ? SPECIALIST_TYPE : undefined,
+  listTypes: () => [{ name: FIXTURE_TYPE, displayName: FIXTURE_TYPE }],
 };
 
 async function createAgent(
@@ -109,7 +106,12 @@ describeOrSkip("AgentCronJobService (integration)", () => {
     await prisma.agentTool.deleteMany();
     await prisma.agentEnv.deleteMany();
     await prisma.agent.deleteMany();
-    service = new AgentCronJobService(prisma, undefined, fixtureResolver);
+    service = new AgentCronJobService(
+      prisma,
+      undefined,
+      fixtureResolver,
+      fixtureDefaults,
+    );
   });
 
   afterEach(async () => {

package/src/agent-cron-jobs.ts

@@ -15,17 +15,9 @@ import type {
   SpecialtyDefaultsResolver,
 } from "./specialty-defaults.ts";
 import {
-  type SpecialtyManifestResolver,
-  SpecialtyRegistry,
-} from "./specialty-manifest-loader.ts";
-import type { SpecialtyManifest } from "./specialty-registry.ts";
-
-/**
- * The shape of a single cron template resolved from a specialty's manifest.
- * Structurally identical to the former SYSTEM_CRONS SystemCron entries — the
- * manifest is now the source of truth (see specialty-manifest-loader.ts).
- */
-type ManifestCron = SpecialtyManifest["crons"][number];
+  type SpecialtyTypeResolver,
+  SpecialtyTypes,
+} from "./specialty-types.ts";
 
 export type { AgentCronJob };
 
@@ -87,7 +79,7 @@ export class AgentCronJobService {
   constructor(
     private prisma: PrismaClient,
     private clock: Clock = SystemClock(),
-    private specialtyRegistry: SpecialtyManifestResolver = new SpecialtyRegistry(),
+    private specialtyRegistry: SpecialtyTypeResolver = new SpecialtyTypes(),
     private specialtyDefaults: SpecialtyDefaultsResolver = () => undefined,
   ) {}
 
@@ -442,26 +434,25 @@ export class AgentCronJobService {
   /**
    * Reconcile system crons for the given agent.
    *
-   * The cron list is resolved from the agent's type manifest — the agent's
-   * stored `specialty` is looked up via the injected SpecialtyRegistry's
-   * `tryGetManifest()` (the parsed `specialties/{specialty}/manifest.yaml`),
-   * deliberately WITHOUT the default-type fallback: any type (the default
-   * included) with no loadable manifest logs an error and reconciles nothing
-   * (no seeding of another type's crons, no deletion of existing system
-   * crons). This replaced the former hardcoded
-   * SYSTEM_CRONS array as the source of truth (ATS-3.2).
+   * The cron list comes from the extension's specialtyDefaults() for the
+   * agent's stored `specialty`. Without extension crons the built-in types
+   * (looked up via the injected resolver's `tryGetType()`, deliberately
+   * WITHOUT a fallback) declare none, so their system crons are cleared; a
+   * specialty that is neither registered nor built in logs an error and
+   * reconciles nothing (no seeding of another type's crons, no deletion of
+   * existing system crons).
    *
-   * Two passes so parent/child links resolve regardless of the manifest's
+   * Two passes so parent/child links resolve regardless of the default
    * cron order or whether this is the agent's very first reconcile (i.e.
    * the parent row may not exist yet when a child entry is processed):
    *
-   * Pass 1 — for each manifest cron entry:
+   * Pass 1 — for each default cron entry:
    *   - If an existing system cron with matching name exists: update it in
-   *     place with the current manifest definition, preserving its id and
+   *     place with the current default definition, preserving its id and
    *     existing enabled state. Updating in place (rather than delete+create)
    *     keeps the row's id stable across restarts so AgentCronRun history
    *     (FK onDelete: Cascade) is never wiped out from under it.
-   *   - If no matching cron exists: create it with the manifest's default
+   *   - If no matching cron exists: create it with the default
    *     enabled state.
    *   Records each entry's resulting row id in a name → id map as it goes.
    *
@@ -472,10 +463,10 @@ export class AgentCronJobService {
    * non-null parentCronId on that row is cleared back to null. Self-heals
    * the link on every reconcile call in both directions — null→set (e.g.
    * a pre-existing row from before parentCron was introduced) and set→null
-   * (e.g. a parentCron declaration removed from the manifest).
+   * (e.g. a parentCron declaration removed from the defaults).
    *
    * Orphan pass: delete any cron with system=true whose name is no longer in
-   * the resolved manifest cron list.
+   * the resolved default cron list.
    *
    * All three passes run inside a single transaction for atomicity.
    *
@@ -484,7 +475,7 @@ export class AgentCronJobService {
   async reconcileSystemCrons(
     agentId: string,
   ): Promise<{ created: number; updated: number; deleted: number }> {
-    // Resolve the agent's type manifest → its declared cron list. No default-type
+    // Resolve the agent's default cron list. No default-type
     // fallback: seeding another type's crons on an agent is worse than
     // leaving its crons untouched.
     const agent = await this.prisma.agent.findUnique({
@@ -495,19 +486,18 @@ export class AgentCronJobService {
       throw new NotFoundError(`agent ${agentId} not found`);
     }
     const { specialty } = agent;
-    // Extension-supplied crons win; the manifest is the fallback.
+    // Extension-supplied crons win; built-in types declare none.
     const extensionCrons = this.specialtyDefaults(specialty)?.crons;
-    const manifest = extensionCrons
+    const knownType = extensionCrons
       ? undefined
-      : this.specialtyRegistry.tryGetManifest(specialty);
-    if (!extensionCrons && !manifest) {
+      : this.specialtyRegistry.tryGetType(specialty);
+    if (!extensionCrons && !knownType) {
       console.error(
-        `reconcileSystemCrons: no loadable manifest for specialty "${specialty}" (agent ${agentId}) — leaving crons untouched`,
+        `reconcileSystemCrons: no known type for specialty "${specialty}" (agent ${agentId}) — leaving crons untouched`,
       );
       return { created: 0, updated: 0, deleted: 0 };
     }
-    const manifestCrons: readonly (ManifestCron | SpecialtyDefaultCron)[] =
-      extensionCrons ?? manifest?.crons ?? [];
+    const defaultCrons: readonly SpecialtyDefaultCron[] = extensionCrons ?? [];
 
     // Fetch all existing system crons for this agent
     const existingSystemCrons = await this.prisma.agentCronJob.findMany({
@@ -522,8 +512,8 @@ export class AgentCronJobService {
       }
     }
 
-    // Build set of valid manifest cron names for orphan detection
-    const systemCronNames = new Set(manifestCrons.map((c) => c.name));
+    // Build set of valid default cron names for orphan detection
+    const systemCronNames = new Set(defaultCrons.map((c) => c.name));
 
     let created = 0;
     let updated = 0;
@@ -532,9 +522,9 @@ export class AgentCronJobService {
     // Wrap all mutations in a transaction so a crash mid-loop cannot leave
     // the agent missing required system crons (e.g. shipwright-dev-task).
     await this.prisma.$transaction(async (tx) => {
-      // Pass 1: reconcile each manifest cron entry, recording name → row id.
+      // Pass 1: reconcile each default cron entry, recording name → row id.
       const idByName = new Map<string, string>();
-      for (const systemCron of manifestCrons) {
+      for (const systemCron of defaultCrons) {
         const existing = existingByName.get(systemCron.name);
 
         if (existing) {
@@ -577,7 +567,7 @@ export class AgentCronJobService {
       // Also clears parentCronId back to null when an entry no longer
       // declares a resolvable parentCron, so the link self-heals in both
       // directions rather than only null→set.
-      for (const systemCron of manifestCrons) {
+      for (const systemCron of defaultCrons) {
         const childId = idByName.get(systemCron.name);
         if (!childId) continue;
         const parentId = systemCron.parentCron
@@ -600,7 +590,7 @@ export class AgentCronJobService {
         }
       }
 
-      // Orphan pass: delete any system cron whose name is not in the manifest.
+      // Orphan pass: delete any system cron whose name is not in the defaults.
       for (const cron of existingSystemCrons) {
         if (!cron.name || !systemCronNames.has(cron.name)) {
           await tx.agentCronJob.delete({ where: { id: cron.id } });