@app-vitals/agent-admin 0.12.0 → 0.13.1

package/src/specialty-manifest-loader.unit.test.ts

@@ -1,7 +1,7 @@
 /**
  * admin/src/specialty-manifest-loader.unit.test.ts
  * Unit tests for SpecialtyRegistry — the disk-backed resolver from an agent's
- * typeName to its parsed manifest, with the unknown-type "coding" fallback.
+ * specialty to its parsed manifest, with the unknown-type "coding" fallback.
  *
  * Pure logic against an injected reader/warner — no filesystem, no DB. See
  * docs/testing.md for the unit-layer contract.
@@ -44,7 +44,7 @@ voice: true
 }
 
 describe("SpecialtyRegistry", () => {
-  it("resolves a known typeName to its parsed manifest", () => {
+  it("resolves a known specialty to its parsed manifest", () => {
     const registry = new SpecialtyRegistry({
       defaultTypeName: DEFAULT_SPECIALTY_NAME,
       read: (t) => manifestYaml(t),
@@ -54,7 +54,7 @@ describe("SpecialtyRegistry", () => {
     expect(manifest.crons[0]?.name).toBe("coding-cron");
   });
 
-  it("falls back to the coding manifest with a warning for an unknown typeName", () => {
+  it("falls back to the coding manifest with a warning for an unknown specialty", () => {
     const warnings: string[] = [];
     const registry = new SpecialtyRegistry({
       defaultTypeName: DEFAULT_SPECIALTY_NAME,
@@ -97,10 +97,10 @@ describe("SpecialtyRegistry", () => {
       defaultTypeName: "absent",
     });
 
-    for (const typeName of ["absent", "some-other-type"]) {
+    for (const specialty of ["absent", "some-other-type"]) {
       let message = "";
       try {
-        registry.getManifest(typeName);
+        registry.getManifest(specialty);
       } catch (err) {
         message = (err as Error).message;
       }
@@ -131,12 +131,12 @@ describe("SpecialtyRegistry", () => {
   // ─── tryGetManifest — non-fallback lookup ────────────────────────────────
   //
   // Unlike getManifest(), tryGetManifest() must NOT fall back to "coding" for
-  // an unknown typeName — it returns undefined instead. This is what lets
+  // an unknown specialty — it returns undefined instead. This is what lets
   // POST /agents distinguish "resolved to the exact requested type" from
   // "silently degraded", which the cron-reconcile boot path (getManifest())
   // deliberately does not need to distinguish.
 
-  it("tryGetManifest resolves a known typeName to its parsed manifest", () => {
+  it("tryGetManifest resolves a known specialty to its parsed manifest", () => {
     const registry = new SpecialtyRegistry({
       defaultTypeName: DEFAULT_SPECIALTY_NAME,
       read: (t) => manifestYaml(t),
@@ -145,7 +145,7 @@ describe("SpecialtyRegistry", () => {
     expect(manifest?.metadata.name).toBe("coding");
   });
 
-  it("tryGetManifest returns undefined for an unknown typeName — no fallback, no warning", () => {
+  it("tryGetManifest returns undefined for an unknown specialty — no fallback, no warning", () => {
     const warnings: string[] = [];
     const registry = new SpecialtyRegistry({
       defaultTypeName: DEFAULT_SPECIALTY_NAME,

package/src/startup-policy-reconcile.unit.test.ts

@@ -80,7 +80,7 @@ function agent(overrides: Partial<AgentSummary> & { id: string }) {
   return {
     name: `${overrides.id}-slug`,
     selfHosted: false,
-    typeName: "dev",
+    specialty: "dev",
     accountId: null,
     ...overrides,
   } satisfies AgentSummary;

package/src/trial-expiry-sweeper.integration.test.ts

@@ -35,7 +35,7 @@ async function createAgent(
   const agent = await prisma.agent.create({
     data: {
       name: opts.name ?? "Test Agent",
-      typeName: "coding",
+      specialty: "coding",
       trialExpiresAt: opts.trialExpiresAt ?? null,
     },
   });

package/src/trial-expiry-warning-sweeper.integration.test.ts

@@ -88,7 +88,7 @@ function buildDeps(
         name: agent.name,
         slackId: null,
         selfHosted: false,
-        typeName: "coding",
+        specialty: "coding",
         createdAt: NOW,
         updatedAt: NOW,
         missingRequiredEnv: [],

package/src/agent-specialty.ts

@@ -1,22 +0,0 @@
-/**
- * AGR-6.1: typeName -> specialty rename, ADD step. `Agent.specialty` is a
- * nullable column written alongside `typeName`; reads prefer it and fall back
- * to `typeName` for rows that predate the column. Nothing is retired yet.
- */
-
-export interface SpecialtyBearingRow {
-  typeName: string;
-  specialty?: string | null;
-}
-
-/** The agent's specialty: the new column when set, else the legacy `typeName`. */
-export function resolveSpecialty(row: SpecialtyBearingRow): string {
-  return row.specialty ?? row.typeName;
-}
-
-/** Returns the row with `specialty` resolved to a non-null string. */
-export function withResolvedSpecialty<T extends SpecialtyBearingRow>(
-  row: T,
-): Omit<T, "specialty"> & { specialty: string } {
-  return { ...row, specialty: resolveSpecialty(row) };
-}

package/src/agent-specialty.unit.test.ts

@@ -1,43 +0,0 @@
-/**
- * Unit tests for the AGR-6.1 specialty mapper (typeName -> specialty ADD step).
- */
-
-import { describe, expect, it } from "bun:test";
-import { resolveSpecialty, withResolvedSpecialty } from "./agent-specialty.ts";
-
-describe("resolveSpecialty", () => {
-  it("prefers specialty when set", () => {
-    expect(
-      resolveSpecialty({ typeName: "coding", specialty: "research" }),
-    ).toBe("research");
-  });
-
-  it("falls back to typeName when specialty is null", () => {
-    expect(resolveSpecialty({ typeName: "coding", specialty: null })).toBe(
-      "coding",
-    );
-  });
-
-  it("falls back to typeName when specialty is absent", () => {
-    expect(resolveSpecialty({ typeName: "coding" })).toBe("coding");
-  });
-
-  it("does not treat an empty-string specialty as unset", () => {
-    expect(resolveSpecialty({ typeName: "coding", specialty: "" })).toBe("");
-  });
-});
-
-describe("withResolvedSpecialty", () => {
-  it("returns a copy with specialty resolved and typeName preserved", () => {
-    const row = { id: "a1", typeName: "coding", specialty: null };
-    const out = withResolvedSpecialty(row);
-    expect(out).toEqual({ id: "a1", typeName: "coding", specialty: "coding" });
-    expect(row.specialty).toBeNull();
-  });
-
-  it("keeps an explicit specialty", () => {
-    expect(
-      withResolvedSpecialty({ typeName: "coding", specialty: "research" }),
-    ).toEqual({ typeName: "coding", specialty: "research" });
-  });
-});