@app-vitals/agent-admin 0.0.1 → 0.1.1

package/src/push-service.unit.test.ts

@@ -0,0 +1,679 @@
+/**
+ * admin/src/push-service.unit.test.ts
+ * Unit tests for PushService orchestration: watcher → subscription lookup,
+ * per-subscription detail resolution, fan-out, and immediate pruning of the
+ * subscriptions the sender reports gone. All doubles are injected (no globals,
+ * no real Prisma, no real network).
+ */
+
+import { describe, expect, it } from "bun:test";
+import { buildSessionNotificationPayload } from "./push-content.ts";
+import type { PushSubscriptionLike } from "./push-sender.ts";
+import { PushService } from "./push-service.ts";
+
+const vapid = {
+  publicKey:
+    "BAl-hYOXgpZwx-qqRoAapu5iSeHrlcJdy89wjv1NyctfsYSyGKCVO97vvlOVR4h61MROU8CZLAxzQEj8vIFsTaI",
+  privateKey: "Sl9AT1gAl_yFgHlTToZkarQRWNYHVTAviDf5osjxXN0",
+  subject: "mailto:ops@example.com",
+};
+
+const P256DH =
+  "BCVxsr7N_eNgVRqvHtD0zTZsEc6-VV-JvLexhqUzORcxaOzi6-AYWXvTBHm4bjyPjs7Vd8pZGH6SRpkNtoIAiw4";
+const AUTH = "BTBZMqHH6r4Tts7J_aSIgg";
+
+interface Row {
+  id: string;
+  userEmail: string;
+  endpoint: string;
+  p256dh: string;
+  auth: string;
+  detailOptIn: string;
+}
+
+function fakePrisma(watchers: string[], subs: Row[]) {
+  const deleted: string[] = [];
+  const prisma = {
+    chatThreadWatch: {
+      findMany: async () => watchers.map((email) => ({ userEmail: email })),
+    },
+    pushSubscription: {
+      findMany: async ({ where }: { where: { userEmail: { in: string[] } } }) =>
+        subs.filter((s) => where.userEmail.in.includes(s.userEmail)),
+      deleteMany: async ({
+        where,
+      }: { where: { endpoint: { in: string[] } } }) => {
+        deleted.push(...where.endpoint.in);
+        return { count: where.endpoint.in.length };
+      },
+    },
+  };
+  return { prisma, deleted };
+}
+
+describe("PushService.notifyThreadReply", () => {
+  it("fans out to every watcher's subscription and prunes the gone ones", async () => {
+    const { prisma, deleted } = fakePrisma(
+      ["a@x.com", "b@x.com"],
+      [
+        {
+          id: "1",
+          userEmail: "a@x.com",
+          endpoint: "https://push/ok",
+          p256dh: P256DH,
+          auth: AUTH,
+          detailOptIn: "title",
+        },
+        {
+          id: "2",
+          userEmail: "b@x.com",
+          endpoint: "https://push/gone",
+          p256dh: P256DH,
+          auth: AUTH,
+          detailOptIn: "generic",
+        },
+      ],
+    );
+    const sent: Array<{ sub: PushSubscriptionLike; payload: string }> = [];
+    const fetchImpl = (async (url: string) => {
+      sent.push({
+        sub: { endpoint: url } as PushSubscriptionLike,
+        payload: "",
+      });
+      return new Response(null, {
+        status: url.endsWith("/gone") ? 410 : 201,
+      });
+    }) as unknown as typeof fetch;
+
+    const service = new PushService(prisma as never, vapid, fetchImpl, "title");
+    const result = await service.notifyThreadReply({
+      threadId: "thr_1",
+      agentId: "agt_1",
+      title: "Fix the thing",
+      preview: "the reply text",
+    });
+
+    expect(sent.length).toBe(2);
+    expect(result.delivered).toBe(1);
+    expect(deleted).toEqual(["https://push/gone"]);
+  });
+
+  it("is a no-op (no send) when the thread has no watchers", async () => {
+    const { prisma, deleted } = fakePrisma([], []);
+    let called = 0;
+    const fetchImpl = (async () => {
+      called += 1;
+      return new Response(null, { status: 201 });
+    }) as unknown as typeof fetch;
+    const service = new PushService(prisma as never, vapid, fetchImpl, "title");
+    const result = await service.notifyThreadReply({
+      threadId: "thr_x",
+      agentId: "agt_x",
+      title: "t",
+      preview: "p",
+    });
+    expect(called).toBe(0);
+    expect(result.delivered).toBe(0);
+    expect(deleted).toEqual([]);
+  });
+
+  it("caps each subscription's detail at the operator ceiling", async () => {
+    // Ceiling = generic; a subscription opted into preview still gets generic.
+    const { prisma } = fakePrisma(
+      ["a@x.com"],
+      [
+        {
+          id: "1",
+          userEmail: "a@x.com",
+          endpoint: "https://push/ok",
+          p256dh: P256DH,
+          auth: AUTH,
+          detailOptIn: "preview",
+        },
+      ],
+    );
+    const bodies: string[] = [];
+    const fetchImpl = (async (_url: string, init: RequestInit) => {
+      // Decrypt isn't feasible here; assert instead via the effective level the
+      // service exposes for auditing.
+      bodies.push(String(init.method));
+      return new Response(null, { status: 201 });
+    }) as unknown as typeof fetch;
+    const service = new PushService(
+      prisma as never,
+      vapid,
+      fetchImpl,
+      "generic",
+    );
+    const levels = await service.resolveLevelsForThread("thr_1");
+    expect(levels).toEqual(["generic"]);
+  });
+});
+
+describe("PushService.sendToUsers", () => {
+  it("fans out to given emails' subscriptions, groups by detail level, sends, and prunes gone endpoints", async () => {
+    const { prisma, deleted } = fakePrisma(
+      [],
+      [
+        {
+          id: "1",
+          userEmail: "a@x.com",
+          endpoint: "https://push/ok",
+          p256dh: P256DH,
+          auth: AUTH,
+          detailOptIn: "title",
+        },
+        {
+          id: "2",
+          userEmail: "b@x.com",
+          endpoint: "https://push/gone",
+          p256dh: P256DH,
+          auth: AUTH,
+          detailOptIn: "generic",
+        },
+      ],
+    );
+    const sent: Array<{ url: string; payload: unknown }> = [];
+    const fetchImpl = (async (url: string) => {
+      sent.push({ url, payload: "" });
+      return new Response(null, {
+        status: url.endsWith("/gone") ? 410 : 201,
+      });
+    }) as unknown as typeof fetch;
+
+    const service = new PushService(prisma as never, vapid, fetchImpl, "title");
+    const result = await service.sendToUsers(["a@x.com", "b@x.com"], (level) =>
+      JSON.stringify({ level }),
+    );
+
+    expect(sent.length).toBe(2);
+    expect(result.delivered).toBe(1);
+    expect(result.pruned).toBe(1);
+    expect(deleted).toEqual(["https://push/gone"]);
+  });
+
+  it("returns { delivered: 0, pruned: 0 } when no subscriptions match", async () => {
+    const { prisma } = fakePrisma([], []);
+    let called = 0;
+    const fetchImpl = (async () => {
+      called += 1;
+      return new Response(null, { status: 201 });
+    }) as unknown as typeof fetch;
+    const service = new PushService(prisma as never, vapid, fetchImpl, "title");
+    const result = await service.sendToUsers(["nobody@x.com"], () => "{}");
+
+    expect(called).toBe(0);
+    expect(result).toEqual({ delivered: 0, pruned: 0 });
+  });
+});
+
+describe("PushService.notifySession", () => {
+  it("resolves subscriptions for the emails on the session object and delivers via the extracted core", async () => {
+    const { prisma, deleted } = fakePrisma(
+      [],
+      [
+        {
+          id: "1",
+          userEmail: "a@x.com",
+          endpoint: "https://push/ok",
+          p256dh: P256DH,
+          auth: AUTH,
+          detailOptIn: "title",
+        },
+      ],
+    );
+    const sent: string[] = [];
+    const fetchImpl = (async (url: string) => {
+      sent.push(url);
+      return new Response(null, { status: 201 });
+    }) as unknown as typeof fetch;
+    const service = new PushService(prisma as never, vapid, fetchImpl, "title");
+
+    const result = await service.notifySession(
+      { slug: "sesh_1", emails: ["a@x.com"] },
+      "generic",
+      "immediate",
+    );
+
+    expect(sent).toEqual(["https://push/ok"]);
+    expect(result).toEqual({ delivered: 1, pruned: 0 });
+    expect(deleted).toEqual([]);
+  });
+
+  it("includes the session deep-link url in the payload it sends", async () => {
+    const { prisma } = fakePrisma(
+      [],
+      [
+        {
+          id: "1",
+          userEmail: "a@x.com",
+          endpoint: "https://push/ok",
+          p256dh: P256DH,
+          auth: AUTH,
+          detailOptIn: "title",
+        },
+      ],
+    );
+    const fetchImpl = (async () =>
+      new Response(null, { status: 201 })) as unknown as typeof fetch;
+    const service = new PushService(prisma as never, vapid, fetchImpl, "title");
+
+    // The encrypted push body isn't inspectable end-to-end, so capture the
+    // payload builder notifySession hands to the extracted core — same
+    // workaround the level-resolution tests below use.
+    const built: string[] = [];
+    const realSendToUsers = service.sendToUsers.bind(service);
+    service.sendToUsers = (emails, buildPayload) =>
+      realSendToUsers(emails, (subLevel) => {
+        const payload = buildPayload(subLevel);
+        built.push(payload);
+        return payload;
+      });
+
+    await service.notifySession(
+      { slug: "sesh_1", emails: ["a@x.com"] },
+      "generic",
+      "immediate",
+    );
+
+    expect(built).toHaveLength(1);
+    expect(JSON.parse(built[0] ?? "{}").url).toBe("/admin/sessions/sesh_1");
+  });
+
+  it("returns { delivered: 0, pruned: 0 } when the session has no emails", async () => {
+    const { prisma } = fakePrisma([], []);
+    let called = 0;
+    const fetchImpl = (async () => {
+      called += 1;
+      return new Response(null, { status: 201 });
+    }) as unknown as typeof fetch;
+    const service = new PushService(prisma as never, vapid, fetchImpl, "title");
+
+    const result = await service.notifySession(
+      { slug: "sesh_1", emails: [] },
+      "generic",
+      "reminder",
+    );
+
+    expect(called).toBe(0);
+    expect(result).toEqual({ delivered: 0, pruned: 0 });
+  });
+
+  it("builds each payload at min(caller level, operator ceiling, subscription opt-in)", async () => {
+    const { prisma } = fakePrisma(
+      [],
+      [
+        {
+          id: "1",
+          userEmail: "a@x.com",
+          endpoint: "https://push/ok",
+          p256dh: P256DH,
+          auth: AUTH,
+          detailOptIn: "preview",
+        },
+      ],
+    );
+    const fetchImpl = (async () =>
+      new Response(null, { status: 201 })) as unknown as typeof fetch;
+    // Operator ceiling = title, so every subscription resolves to at most
+    // "title" before the caller's own ceiling is applied.
+    const service = new PushService(prisma as never, vapid, fetchImpl, "title");
+
+    // The encrypted push body isn't inspectable, so capture the payload
+    // builder notifySession hands to the extracted core and exercise it with
+    // the per-subscription levels sendToUsers would resolve.
+    const built: string[] = [];
+    const realSendToUsers = service.sendToUsers.bind(service);
+    service.sendToUsers = (emails, buildPayload) =>
+      realSendToUsers(emails, (subLevel) => {
+        const payload = buildPayload(subLevel);
+        built.push(payload);
+        return payload;
+      });
+
+    await service.notifySession(
+      { slug: "sesh_1", title: "Something happened", emails: ["a@x.com"] },
+      "generic",
+      "immediate",
+    );
+
+    // Subscription opted into "preview", operator ceiling is "title", caller
+    // asked for "generic" — the lowest of the three wins. Comparing against
+    // buildSessionNotificationPayload's own output (rather than hand-rolling
+    // the expected JSON) proves the resolved level, not just some payload,
+    // reached the content builder — a title-level `body` would be non-empty here.
+    expect(built).toEqual([
+      JSON.stringify(
+        buildSessionNotificationPayload("generic", "immediate", {
+          slug: "sesh_1",
+          title: "Something happened",
+        }),
+      ),
+    ]);
+  });
+
+  it("never exceeds the per-subscription level even when the caller asks for more detail", async () => {
+    const { prisma } = fakePrisma(
+      [],
+      [
+        {
+          id: "1",
+          userEmail: "a@x.com",
+          endpoint: "https://push/ok",
+          p256dh: P256DH,
+          auth: AUTH,
+          detailOptIn: "generic",
+        },
+        {
+          id: "2",
+          userEmail: "b@x.com",
+          endpoint: "https://push/ok2",
+          p256dh: P256DH,
+          auth: AUTH,
+          detailOptIn: "preview",
+        },
+      ],
+    );
+    const fetchImpl = (async () =>
+      new Response(null, { status: 201 })) as unknown as typeof fetch;
+    const service = new PushService(prisma as never, vapid, fetchImpl, "title");
+
+    const built: string[] = [];
+    const realSendToUsers = service.sendToUsers.bind(service);
+    service.sendToUsers = (emails, buildPayload) =>
+      realSendToUsers(emails, (subLevel) => {
+        const payload = buildPayload(subLevel);
+        built.push(payload);
+        return payload;
+      });
+
+    await service.notifySession(
+      {
+        slug: "sesh_1",
+        title: "Something happened",
+        emails: ["a@x.com", "b@x.com"],
+      },
+      "preview",
+      "reminder",
+    );
+
+    // Per-subscriber, not one payload for everyone: the opted-out subscriber
+    // stays at "generic" while the opted-in one is still capped at the
+    // operator ceiling ("title"), never the requested "preview". Comparing
+    // against buildSessionNotificationPayload's own output at each expected
+    // level (rather than a `level` field the new payload shape doesn't have)
+    // proves the resolution — the two levels produce visibly different
+    // `body` values given a non-empty title.
+    expect(built).toEqual([
+      JSON.stringify(
+        buildSessionNotificationPayload("generic", "reminder", {
+          slug: "sesh_1",
+          title: "Something happened",
+        }),
+      ),
+      JSON.stringify(
+        buildSessionNotificationPayload("title", "reminder", {
+          slug: "sesh_1",
+          title: "Something happened",
+        }),
+      ),
+    ]);
+  });
+
+  it("swallows a downstream failure and never throws into the caller", async () => {
+    const prisma = {
+      chatThreadWatch: { findMany: async () => [] },
+      pushSubscription: {
+        findMany: async () => {
+          throw new Error("db down");
+        },
+        deleteMany: async () => ({ count: 0 }),
+      },
+    };
+    const fetchImpl = (async () =>
+      new Response(null, { status: 201 })) as unknown as typeof fetch;
+    const service = new PushService(prisma as never, vapid, fetchImpl, "title");
+
+    await expect(
+      service.notifySession(
+        { slug: "sesh_1", emails: ["a@x.com"] },
+        "generic",
+        "completed",
+      ),
+    ).resolves.toEqual({ delivered: 0, pruned: 0 });
+  });
+});
+
+// A fetchImpl is required by the PushService constructor but unused by the
+// write-path methods under test below (recordWatch/subscribe/unsubscribe
+// never touch PushSender).
+const unusedFetch = (async () =>
+  new Response(null, { status: 201 })) as unknown as typeof fetch;
+
+describe("PushService.recordWatch", () => {
+  it("upserts a ChatThreadWatch row scoped to userEmail+threadId", async () => {
+    const calls: unknown[] = [];
+    const prisma = {
+      chatThreadWatch: {
+        findMany: async () => [],
+        upsert: async (args: unknown) => {
+          calls.push(args);
+          return { id: "w1" };
+        },
+      },
+      pushSubscription: {
+        findMany: async () => [],
+        deleteMany: async () => ({ count: 0 }),
+      },
+    };
+    const service = new PushService(
+      prisma as never,
+      vapid,
+      unusedFetch,
+      "title",
+    );
+    await service.recordWatch("a@x.com", "agt_1", "thr_1");
+
+    expect(calls).toEqual([
+      {
+        where: {
+          userEmail_threadId: { userEmail: "a@x.com", threadId: "thr_1" },
+        },
+        create: { userEmail: "a@x.com", threadId: "thr_1", agentId: "agt_1" },
+        update: { agentId: "agt_1" },
+      },
+    ]);
+  });
+
+  it("is a no-op when the chatThreadWatch model is absent (migration not applied)", async () => {
+    const prisma = {
+      pushSubscription: {
+        findMany: async () => [],
+        deleteMany: async () => ({ count: 0 }),
+      },
+    };
+    const service = new PushService(
+      prisma as never,
+      vapid,
+      unusedFetch,
+      "title",
+    );
+    await expect(
+      service.recordWatch("a@x.com", "agt_1", "thr_1"),
+    ).resolves.toBeUndefined();
+  });
+
+  it("swallows an upsert failure and never throws into the caller", async () => {
+    const prisma = {
+      chatThreadWatch: {
+        findMany: async () => [],
+        upsert: async () => {
+          throw new Error("db down");
+        },
+      },
+      pushSubscription: {
+        findMany: async () => [],
+        deleteMany: async () => ({ count: 0 }),
+      },
+    };
+    const service = new PushService(
+      prisma as never,
+      vapid,
+      unusedFetch,
+      "title",
+    );
+    await expect(
+      service.recordWatch("a@x.com", "agt_1", "thr_1"),
+    ).resolves.toBeUndefined();
+  });
+});
+
+describe("PushService.subscribe", () => {
+  it("upserts the subscription and returns ok:true", async () => {
+    const calls: unknown[] = [];
+    const prisma = {
+      chatThreadWatch: { findMany: async () => [] },
+      pushSubscription: {
+        findMany: async () => [],
+        deleteMany: async () => ({ count: 0 }),
+        upsert: async (args: unknown) => {
+          calls.push(args);
+          return { id: "sub_1" };
+        },
+      },
+    };
+    const service = new PushService(
+      prisma as never,
+      vapid,
+      unusedFetch,
+      "title",
+    );
+    const result = await service.subscribe(
+      "a@x.com",
+      "https://push/ok",
+      P256DH,
+      AUTH,
+    );
+
+    expect(result).toEqual({ ok: true });
+    expect(calls).toEqual([
+      {
+        where: { endpoint: "https://push/ok" },
+        create: {
+          userEmail: "a@x.com",
+          endpoint: "https://push/ok",
+          p256dh: P256DH,
+          auth: AUTH,
+        },
+        update: { userEmail: "a@x.com", p256dh: P256DH, auth: AUTH },
+      },
+    ]);
+  });
+
+  it("returns reason:unavailable when the pushSubscription model is absent", async () => {
+    const prisma = {
+      chatThreadWatch: { findMany: async () => [] },
+    };
+    const service = new PushService(
+      prisma as never,
+      vapid,
+      unusedFetch,
+      "title",
+    );
+    const result = await service.subscribe(
+      "a@x.com",
+      "https://push/ok",
+      P256DH,
+      AUTH,
+    );
+    expect(result).toEqual({ ok: false, reason: "unavailable" });
+  });
+
+  it("returns reason:store_failed when the upsert throws", async () => {
+    const prisma = {
+      chatThreadWatch: { findMany: async () => [] },
+      pushSubscription: {
+        findMany: async () => [],
+        deleteMany: async () => ({ count: 0 }),
+        upsert: async () => {
+          throw new Error("db down");
+        },
+      },
+    };
+    const service = new PushService(
+      prisma as never,
+      vapid,
+      unusedFetch,
+      "title",
+    );
+    const result = await service.subscribe(
+      "a@x.com",
+      "https://push/ok",
+      P256DH,
+      AUTH,
+    );
+    expect(result).toEqual({ ok: false, reason: "store_failed" });
+  });
+});
+
+describe("PushService.unsubscribe", () => {
+  it("deletes the subscription scoped to endpoint+userEmail and returns ok:true", async () => {
+    const calls: unknown[] = [];
+    const prisma = {
+      chatThreadWatch: { findMany: async () => [] },
+      pushSubscription: {
+        findMany: async () => [],
+        deleteMany: async (args: unknown) => {
+          calls.push(args);
+          return { count: 1 };
+        },
+      },
+    };
+    const service = new PushService(
+      prisma as never,
+      vapid,
+      unusedFetch,
+      "title",
+    );
+    const result = await service.unsubscribe("a@x.com", "https://push/ok");
+
+    expect(result).toEqual({ ok: true });
+    expect(calls).toEqual([
+      { where: { endpoint: "https://push/ok", userEmail: "a@x.com" } },
+    ]);
+  });
+
+  it("returns reason:unavailable when the pushSubscription model is absent", async () => {
+    const prisma = {
+      chatThreadWatch: { findMany: async () => [] },
+    };
+    const service = new PushService(
+      prisma as never,
+      vapid,
+      unusedFetch,
+      "title",
+    );
+    const result = await service.unsubscribe("a@x.com", "https://push/ok");
+    expect(result).toEqual({ ok: false, reason: "unavailable" });
+  });
+
+  it("swallows a deleteMany failure and still returns ok:true", async () => {
+    const prisma = {
+      chatThreadWatch: { findMany: async () => [] },
+      pushSubscription: {
+        findMany: async () => [],
+        deleteMany: async () => {
+          throw new Error("db down");
+        },
+      },
+    };
+    const service = new PushService(
+      prisma as never,
+      vapid,
+      unusedFetch,
+      "title",
+    );
+    const result = await service.unsubscribe("a@x.com", "https://push/ok");
+    expect(result).toEqual({ ok: true });
+  });
+});