@app-connect/core 1.7.24 → 1.7.26

package/connector/registry.js

@@ -1,252 +1,252 @@
-// core/src/connector/registry.js
-const logger = require('../lib/logger');
-class ConnectorRegistry {
-  constructor() {
-      this.connectors = new Map();
-      this.manifests = new Map();
-      this.releaseNotes = {};
-      this.platformInterfaces = new Map(); // Store interface functions per platform
-  }
-
-  setDefaultManifest(manifest) {
-    this.manifests.set('default', manifest);
-  }
-
-  /**
-   * Register an interface function for a specific platform
-   * @param {string} platformName - Platform identifier (e.g., 'pipedrive', 'salesforce')
-   * @param {string} interfaceName - Interface function name (e.g., 'createCallLog', 'findContact')
-   * @param {Function} interfaceFunction - The interface function to register
-   */
-  registerConnectorInterface(platformName, interfaceName, interfaceFunction) {
-    if (typeof interfaceFunction !== 'function') {
-      throw new Error(`Interface function must be a function, got: ${typeof interfaceFunction}`);
-    }
-
-    if (!this.platformInterfaces.has(platformName)) {
-      this.platformInterfaces.set(platformName, new Map());
-    }
-
-    const platformInterfaceMap = this.platformInterfaces.get(platformName);
-    platformInterfaceMap.set(interfaceName, interfaceFunction);
-
-    logger.info(`Registered interface function: ${platformName}.${interfaceName}`);
-  }
-
-  /**
-   * Get registered interface functions for a platform
-   * @param {string} platformName - Platform identifier
-   * @returns {Map} Map of interface functions
-   */
-  getPlatformInterfaces(platformName) {
-    return this.platformInterfaces.get(platformName) || new Map();
-  }
-
-  /**
-   * Check if an interface function is registered for a platform
-   * @param {string} platformName - Platform identifier
-   * @param {string} interfaceName - Interface function name
-   * @returns {boolean} True if interface is registered
-   */
-  hasPlatformInterface(platformName, interfaceName) {
-    const platformInterfaceMap = this.platformInterfaces.get(platformName);
-    return platformInterfaceMap ? platformInterfaceMap.has(interfaceName) : false;
-  }
-
-  /**
-   * Unregister an interface function for a platform
-   * @param {string} platformName - Platform identifier
-   * @param {string} interfaceName - Interface function name
-   */
-  unregisterConnectorInterface(platformName, interfaceName) {
-    const platformInterfaceMap = this.platformInterfaces.get(platformName);
-    if (platformInterfaceMap && platformInterfaceMap.has(interfaceName)) {
-      platformInterfaceMap.delete(interfaceName);
-      logger.info(`Unregistered interface function: ${platformName}.${interfaceName}`);
-    }
-  }
-
-  /**
-   * Register an connector with the core system
-   * @param {string} platform - Platform identifier (e.g., 'pipedrive', 'salesforce')
-   * @param {Object} connector - Connector implementation
-   * @param {Object} manifest - Connector manifest configuration
-   */
-  registerConnector(platform, connector, manifest = null) {
-      // Validate connector interface
-      this.validateConnectorInterface(platform, connector);
-      
-      this.connectors.set(platform, connector);
-      if (manifest) {
-        this.manifests.set(platform, manifest);
-      }
-      
-      logger.info(`Registered connector: ${platform}`);
-  }
-
-  /**
-   * Get connector by platform name with composed interfaces
-   * @param {string} platform - Platform identifier
-   * @returns {Object} Composed connector with interface functions
-   */
-  getConnector(platform) {
-      let connector = this.connectors.get(platform);
-      const platformInterfaceMap = this.platformInterfaces.get(platform);
-
-      if (!connector && (!platformInterfaceMap || platformInterfaceMap.size === 0)) {
-        connector = this.connectors.get('proxy');
-        if (connector) {
-          return connector;
-        }
-        throw new Error(`Connector not found for platform: ${platform}`);
-      }
-
-      // If no connector but interfaces exist, create a composed object with just interfaces
-      if (!connector && platformInterfaceMap && platformInterfaceMap.size > 0) {
-          const composedConnector = {};
-
-          // Add interface functions to the composed connector
-          for (const [interfaceName, interfaceFunction] of platformInterfaceMap) {
-              composedConnector[interfaceName] = interfaceFunction;
-          }
-
-          logger.info(`Returning interface-only connector for platform: ${platform}`);
-          return composedConnector;
-      }
-
-      // If connector exists but no interfaces, return original connector
-      if (connector && (!platformInterfaceMap || platformInterfaceMap.size === 0)) {
-          return connector;
-      }
-
-      // If both connector and interfaces exist, create a composed object
-      const composedConnector = Object.create(connector);
-
-      // Add interface functions to the composed connector
-      for (const [interfaceName, interfaceFunction] of platformInterfaceMap) {
-        // Only add if the interface doesn't already exist in the connector
-        if (!Object.prototype.hasOwnProperty.call(connector, interfaceName)) {
-          composedConnector[interfaceName] = interfaceFunction;
-        }
-      }
-
-      return composedConnector;
-  }
-
-  /**
-   * Get the original connector without composed interfaces
-   * @param {string} platform - Platform identifier
-   * @returns {Object} Original connector implementation
-   */
-  getOriginalConnector(platform) {
-    const connector = this.connectors.get(platform);
-    if (!connector) {
-      throw new Error(`Connector not found for platform: ${platform}`);
-    }
-    return connector;
-  }
-
-  /**
-   * Get manifest for a platform
-   * @param {string} platform - Platform identifier
-   * @returns {Object} Manifest configuration
-   */
-  getManifest(platform, fallbackToDefault = false) {
-      let manifest = this.manifests.get(platform);
-      if (!manifest && fallbackToDefault) {
-        manifest = this.manifests.get('default');
-      }
-      if (!manifest) {
-        throw new Error(`Manifest not found for platform: ${platform}`);
-      }
-      return manifest;
-  }
-
-  /**
-   * Get all registered platforms
-   * @returns {Array<string>} Array of platform names
-   */
-  getRegisteredPlatforms() {
-      return Array.from(this.connectors.keys());
-  }
-
-  /**
-   * Check if platform is registered
-   * @param {string} platform - Platform identifier
-   * @returns {boolean} True if platform is registered
-   */
-  isRegistered(platform) {
-      return this.connectors.has(platform);
-  }
-
-  /**
-   * Validate that connector implements required interface
-   * @param {Object} connector - Connector to validate
-   */
-  validateConnectorInterface(platform, connector) {
-      const requiredMethods = [
-          'createCallLog',
-          'updateCallLog',
-      ];
-
-      for (const method of requiredMethods) {
-          if (typeof connector[method] !== 'function') {
-              throw new Error(`Connector ${platform} missing required method: ${method}`);
-          }
-      }
-  }
-
-  /**
-   * Unregister an connector
-   * @param {string} platform - Platform identifier
-   */
-  unregisterConnector(platform) {
-      this.connectors.delete(platform);
-      this.manifests.delete(platform);
-      this.platformInterfaces.delete(platform);
-      logger.info(`Unregistered connector: ${platform}`);
-  }
-
-  setReleaseNotes(releaseNotes) {
-    this.releaseNotes = releaseNotes;
-  }
-
-  getReleaseNotes() {
-    return this.releaseNotes; 
-  }
-
-  /**
-   * Get connector capabilities summary including composed interfaces
-   * @param {string} platform - Platform identifier
-   * @returns {Object} Connector capabilities
-   */
-  async getConnectorCapabilities(platform) {
-    const originalConnector = this.getOriginalConnector(platform);
-    const composedConnector = this.getConnector(platform);
-    const platformInterfaceMap = this.getPlatformInterfaces(platform);
-    
-    const capabilities = {
-      platform,
-      originalMethods: Object.keys(originalConnector),
-      composedMethods: Object.keys(composedConnector),
-      registeredInterfaces: Array.from(platformInterfaceMap.keys()),
-      authType: null
-    };
-
-    // Get auth type if available
-    if (typeof originalConnector.getAuthType === 'function') {
-      try {
-        capabilities.authType = await originalConnector.getAuthType();
-      } catch (error) {
-        logger.error('Error getting auth type', { stack: error.stack });
-        capabilities.authType = 'unknown';
-      }
-    }
-
-    return capabilities;
-  }
-}
-
-// Export singleton instance
-const connectorRegistry = new ConnectorRegistry();
-module.exports = connectorRegistry;
+// core/src/connector/registry.js
+const logger = require('../lib/logger');
+class ConnectorRegistry {
+  constructor() {
+      this.connectors = new Map();
+      this.manifests = new Map();
+      this.releaseNotes = {};
+      this.platformInterfaces = new Map(); // Store interface functions per platform
+  }
+
+  setDefaultManifest(manifest) {
+    this.manifests.set('default', manifest);
+  }
+
+  /**
+   * Register an interface function for a specific platform
+   * @param {string} platformName - Platform identifier (e.g., 'pipedrive', 'salesforce')
+   * @param {string} interfaceName - Interface function name (e.g., 'createCallLog', 'findContact')
+   * @param {Function} interfaceFunction - The interface function to register
+   */
+  registerConnectorInterface(platformName, interfaceName, interfaceFunction) {
+    if (typeof interfaceFunction !== 'function') {
+      throw new Error(`Interface function must be a function, got: ${typeof interfaceFunction}`);
+    }
+
+    if (!this.platformInterfaces.has(platformName)) {
+      this.platformInterfaces.set(platformName, new Map());
+    }
+
+    const platformInterfaceMap = this.platformInterfaces.get(platformName);
+    platformInterfaceMap.set(interfaceName, interfaceFunction);
+
+    logger.info(`Registered interface function: ${platformName}.${interfaceName}`);
+  }
+
+  /**
+   * Get registered interface functions for a platform
+   * @param {string} platformName - Platform identifier
+   * @returns {Map} Map of interface functions
+   */
+  getPlatformInterfaces(platformName) {
+    return this.platformInterfaces.get(platformName) || new Map();
+  }
+
+  /**
+   * Check if an interface function is registered for a platform
+   * @param {string} platformName - Platform identifier
+   * @param {string} interfaceName - Interface function name
+   * @returns {boolean} True if interface is registered
+   */
+  hasPlatformInterface(platformName, interfaceName) {
+    const platformInterfaceMap = this.platformInterfaces.get(platformName);
+    return platformInterfaceMap ? platformInterfaceMap.has(interfaceName) : false;
+  }
+
+  /**
+   * Unregister an interface function for a platform
+   * @param {string} platformName - Platform identifier
+   * @param {string} interfaceName - Interface function name
+   */
+  unregisterConnectorInterface(platformName, interfaceName) {
+    const platformInterfaceMap = this.platformInterfaces.get(platformName);
+    if (platformInterfaceMap && platformInterfaceMap.has(interfaceName)) {
+      platformInterfaceMap.delete(interfaceName);
+      logger.info(`Unregistered interface function: ${platformName}.${interfaceName}`);
+    }
+  }
+
+  /**
+   * Register an connector with the core system
+   * @param {string} platform - Platform identifier (e.g., 'pipedrive', 'salesforce')
+   * @param {Object} connector - Connector implementation
+   * @param {Object} manifest - Connector manifest configuration
+   */
+  registerConnector(platform, connector, manifest = null) {
+      // Validate connector interface
+      this.validateConnectorInterface(platform, connector);
+      
+      this.connectors.set(platform, connector);
+      if (manifest) {
+        this.manifests.set(platform, manifest);
+      }
+      
+      logger.info(`Registered connector: ${platform}`);
+  }
+
+  /**
+   * Get connector by platform name with composed interfaces
+   * @param {string} platform - Platform identifier
+   * @returns {Object} Composed connector with interface functions
+   */
+  getConnector(platform) {
+      let connector = this.connectors.get(platform);
+      const platformInterfaceMap = this.platformInterfaces.get(platform);
+
+      if (!connector && (!platformInterfaceMap || platformInterfaceMap.size === 0)) {
+        connector = this.connectors.get('proxy');
+        if (connector) {
+          return connector;
+        }
+        throw new Error(`Connector not found for platform: ${platform}`);
+      }
+
+      // If no connector but interfaces exist, create a composed object with just interfaces
+      if (!connector && platformInterfaceMap && platformInterfaceMap.size > 0) {
+          const composedConnector = {};
+
+          // Add interface functions to the composed connector
+          for (const [interfaceName, interfaceFunction] of platformInterfaceMap) {
+              composedConnector[interfaceName] = interfaceFunction;
+          }
+
+          logger.info(`Returning interface-only connector for platform: ${platform}`);
+          return composedConnector;
+      }
+
+      // If connector exists but no interfaces, return original connector
+      if (connector && (!platformInterfaceMap || platformInterfaceMap.size === 0)) {
+          return connector;
+      }
+
+      // If both connector and interfaces exist, create a composed object
+      const composedConnector = Object.create(connector);
+
+      // Add interface functions to the composed connector
+      for (const [interfaceName, interfaceFunction] of platformInterfaceMap) {
+        // Only add if the interface doesn't already exist in the connector
+        if (!Object.prototype.hasOwnProperty.call(connector, interfaceName)) {
+          composedConnector[interfaceName] = interfaceFunction;
+        }
+      }
+
+      return composedConnector;
+  }
+
+  /**
+   * Get the original connector without composed interfaces
+   * @param {string} platform - Platform identifier
+   * @returns {Object} Original connector implementation
+   */
+  getOriginalConnector(platform) {
+    const connector = this.connectors.get(platform);
+    if (!connector) {
+      throw new Error(`Connector not found for platform: ${platform}`);
+    }
+    return connector;
+  }
+
+  /**
+   * Get manifest for a platform
+   * @param {string} platform - Platform identifier
+   * @returns {Object} Manifest configuration
+   */
+  getManifest(platform, fallbackToDefault = false) {
+      let manifest = this.manifests.get(platform);
+      if (!manifest && fallbackToDefault) {
+        manifest = this.manifests.get('default');
+      }
+      if (!manifest) {
+        throw new Error(`Manifest not found for platform: ${platform}`);
+      }
+      return manifest;
+  }
+
+  /**
+   * Get all registered platforms
+   * @returns {Array<string>} Array of platform names
+   */
+  getRegisteredPlatforms() {
+      return Array.from(this.connectors.keys());
+  }
+
+  /**
+   * Check if platform is registered
+   * @param {string} platform - Platform identifier
+   * @returns {boolean} True if platform is registered
+   */
+  isRegistered(platform) {
+      return this.connectors.has(platform);
+  }
+
+  /**
+   * Validate that connector implements required interface
+   * @param {Object} connector - Connector to validate
+   */
+  validateConnectorInterface(platform, connector) {
+      const requiredMethods = [
+          'createCallLog',
+          'updateCallLog',
+      ];
+
+      for (const method of requiredMethods) {
+          if (typeof connector[method] !== 'function') {
+              throw new Error(`Connector ${platform} missing required method: ${method}`);
+          }
+      }
+  }
+
+  /**
+   * Unregister an connector
+   * @param {string} platform - Platform identifier
+   */
+  unregisterConnector(platform) {
+      this.connectors.delete(platform);
+      this.manifests.delete(platform);
+      this.platformInterfaces.delete(platform);
+      logger.info(`Unregistered connector: ${platform}`);
+  }
+
+  setReleaseNotes(releaseNotes) {
+    this.releaseNotes = releaseNotes;
+  }
+
+  getReleaseNotes() {
+    return this.releaseNotes; 
+  }
+
+  /**
+   * Get connector capabilities summary including composed interfaces
+   * @param {string} platform - Platform identifier
+   * @returns {Object} Connector capabilities
+   */
+  async getConnectorCapabilities(platform) {
+    const originalConnector = this.getOriginalConnector(platform);
+    const composedConnector = this.getConnector(platform);
+    const platformInterfaceMap = this.getPlatformInterfaces(platform);
+    
+    const capabilities = {
+      platform,
+      originalMethods: Object.keys(originalConnector),
+      composedMethods: Object.keys(composedConnector),
+      registeredInterfaces: Array.from(platformInterfaceMap.keys()),
+      authType: null
+    };
+
+    // Get auth type if available
+    if (typeof originalConnector.getAuthType === 'function') {
+      try {
+        capabilities.authType = await originalConnector.getAuthType();
+      } catch (error) {
+        logger.error('Error getting auth type', { stack: error.stack });
+        capabilities.authType = 'unknown';
+      }
+    }
+
+    return capabilities;
+  }
+}
+
+// Export singleton instance
+const connectorRegistry = new ConnectorRegistry();
+module.exports = connectorRegistry;

package/docs/README.md

@@ -1,50 +1,50 @@
-# App Connect Core Docs
-
-This docs set explains the maintained code under `packages/core`, excluding the `mcp/` subsystem.
-
-Use it when you need to change shared backend behavior, trace a request through the framework, or understand which module owns a feature.
-
-## Scope
-
-Included:
-
-- root package entrypoints and route assembly
-- connector infrastructure
-- handlers
-- models, including DynamoDB-backed schemas used outside MCP
-- shared libraries
-- tests that cover the non-MCP package surface
-
-Excluded:
-
-- `mcp/`
-- generated output such as `coverage/`
-- vendored dependencies such as `node_modules/`
-
-## Reading Order
-
-1. [Architecture](architecture.md) for the runtime shape and request flow
-2. [Routes](routes.md) for the HTTP surface in `index.js`
-3. [Handlers](handlers.md) for shared business logic
-4. [Connectors](connectors.md) for registration, proxy behavior, and developer-portal helpers
-5. [Models](models.md) for persistence
-6. [Libraries](libraries.md) for shared helpers and infrastructure code
-7. [Tests](tests.md) for current automated coverage
-
-## File Map
-
-| Area | Files |
-| --- | --- |
-| Package root | `index.js`, `package.json`, `README.md`, `releaseNotes.json`, `jest.config.js` |
-| Connectors | `connector/registry.js`, `connector/developerPortal.js`, `connector/mock.js`, `connector/proxy/index.js`, `connector/proxy/engine.js` |
-| Handlers | `handlers/admin.js`, `handlers/auth.js`, `handlers/calldown.js`, `handlers/contact.js`, `handlers/disposition.js`, `handlers/log.js`, `handlers/plugin.js`, `handlers/managedAuth.js`, `handlers/user.js` |
-| Sequelize models | `models/accountDataModel.js`, `models/adminConfigModel.js`, `models/cacheModel.js`, `models/callDownListModel.js`, `models/callLogModel.js`, `models/llmSessionModel.js`, `models/messageLogModel.js`, `models/sequelize.js`, `models/userModel.js` |
-| DynamoDB models | `models/dynamo/connectorSchema.js`, `models/dynamo/lockSchema.js`, `models/dynamo/noteCacheSchema.js` |
-| Libraries | `lib/analytics.js`, `lib/authSession.js`, `lib/callLogComposer.js`, `lib/constants.js`, `lib/debugTracer.js`, `lib/encode.js`, `lib/errorHandler.js`, `lib/generalErrorMessage.js`, `lib/jwt.js`, `lib/logger.js`, `lib/oauth.js`, `lib/ringcentral.js`, `lib/s3ErrorLogReport.js`, `lib/sharedSMSComposer.js`, `lib/util.js` |
-| Tests | `test/setup.js`, `test/connector/**`, `test/handlers/**`, `test/lib/**`, `test/models/**`, `test/routes/**` excluding `test/mcp/**` |
-
-## Relationship To The Package README
-
-The package [README.md](../README.md) is still the best public-facing quick start.
-
-This docs set is the maintainer-oriented reference for the internals behind that API surface.
+# App Connect Core Docs
+
+This docs set explains the maintained code under `packages/core`, excluding the `mcp/` subsystem.
+
+Use it when you need to change shared backend behavior, trace a request through the framework, or understand which module owns a feature.
+
+## Scope
+
+Included:
+
+- root package entrypoints and route assembly
+- connector infrastructure
+- handlers
+- models, including DynamoDB-backed schemas used outside MCP
+- shared libraries
+- tests that cover the non-MCP package surface
+
+Excluded:
+
+- `mcp/`
+- generated output such as `coverage/`
+- vendored dependencies such as `node_modules/`
+
+## Reading Order
+
+1. [Architecture](architecture.md) for the runtime shape and request flow
+2. [Routes](routes.md) for the HTTP surface in `index.js`
+3. [Handlers](handlers.md) for shared business logic
+4. [Connectors](connectors.md) for registration, proxy behavior, and developer-portal helpers
+5. [Models](models.md) for persistence
+6. [Libraries](libraries.md) for shared helpers and infrastructure code
+7. [Tests](tests.md) for current automated coverage
+
+## File Map
+
+| Area | Files |
+| --- | --- |
+| Package root | `index.js`, `package.json`, `README.md`, `releaseNotes.json`, `jest.config.js` |
+| Connectors | `connector/registry.js`, `connector/developerPortal.js`, `connector/mock.js`, `connector/proxy/index.js`, `connector/proxy/engine.js` |
+| Handlers | `handlers/admin.js`, `handlers/auth.js`, `handlers/calldown.js`, `handlers/contact.js`, `handlers/disposition.js`, `handlers/log.js`, `handlers/plugin.js`, `handlers/managedAuth.js`, `handlers/user.js` |
+| Sequelize models | `models/accountDataModel.js`, `models/adminConfigModel.js`, `models/cacheModel.js`, `models/callDownListModel.js`, `models/callLogModel.js`, `models/llmSessionModel.js`, `models/messageLogModel.js`, `models/sequelize.js`, `models/userModel.js` |
+| DynamoDB models | `models/dynamo/connectorSchema.js`, `models/dynamo/lockSchema.js`, `models/dynamo/noteCacheSchema.js` |
+| Libraries | `lib/analytics.js`, `lib/authSession.js`, `lib/callLogComposer.js`, `lib/constants.js`, `lib/debugTracer.js`, `lib/encode.js`, `lib/errorHandler.js`, `lib/generalErrorMessage.js`, `lib/jwt.js`, `lib/logger.js`, `lib/oauth.js`, `lib/ringcentral.js`, `lib/s3ErrorLogReport.js`, `lib/sharedSMSComposer.js`, `lib/util.js` |
+| Tests | `test/setup.js`, `test/connector/**`, `test/handlers/**`, `test/lib/**`, `test/models/**`, `test/routes/**` excluding `test/mcp/**` |
+
+## Relationship To The Package README
+
+The package [README.md](../README.md) is still the best public-facing quick start.
+
+This docs set is the maintainer-oriented reference for the internals behind that API surface.