@app-connect/core 1.7.21 → 1.7.23

package/test/lib/callLogComposer.test.js

@@ -136,7 +136,7 @@ describe('callLogComposer', () => {
       expect(result).toContain('Hello, this is a test transcript.');
     });
 
-    test('should add RingSense data when provided', async () => {
+    test('should add ACE data when provided', async () => {
       const result = await composeCallLog({
         ...baseParams,
         ringSenseTranscript: 'RS Transcript',
@@ -146,10 +146,10 @@ describe('callLogComposer', () => {
         ringSenseLink: 'https://ringsense.example.com/123'
       });
 
-      expect(result).toContain('RingSense transcript');
-      expect(result).toContain('RingSense summary');
+      expect(result).toContain('ACE transcript');
+      expect(result).toContain('ACE summary');
       expect(result).toContain('Call score: 85');
-      expect(result).toContain('RingSense recording link');
+      expect(result).toContain('ACE recording link');
     });
 
     test('should add call legs when provided', async () => {
@@ -1025,16 +1025,16 @@ describe('callLogComposer', () => {
     });
   });
 
-  describe('RingSense Functions', () => {
+  describe('ACE Functions', () => {
     describe('upsertRingSenseTranscript', () => {
-      test('should add RingSense transcript', () => {
+      test('should add ACE transcript', () => {
         const result = upsertRingSenseTranscript({
           body: '',
           transcript: 'RS transcript content',
           logFormat: LOG_DETAILS_FORMAT_TYPE.PLAIN_TEXT
         });
 
-        expect(result).toContain('RingSense transcript');
+        expect(result).toContain('ACE transcript');
         expect(result).toContain('RS transcript content');
       });
 
@@ -1045,7 +1045,7 @@ describe('callLogComposer', () => {
           logFormat: LOG_DETAILS_FORMAT_TYPE.HTML
         });
 
-        expect(result).toContain('<b>RingSense transcript</b>');
+        expect(result).toContain('<b>ACE transcript</b>');
       });
 
       test('should add in Markdown format', () => {
@@ -1055,20 +1055,20 @@ describe('callLogComposer', () => {
           logFormat: LOG_DETAILS_FORMAT_TYPE.MARKDOWN
         });
 
-        expect(result).toContain('### RingSense transcript');
+        expect(result).toContain('### ACE transcript');
         expect(result).toContain('RS transcript content');
       });
     });
 
     describe('upsertRingSenseSummary', () => {
-      test('should add RingSense summary', () => {
+      test('should add ACE summary', () => {
         const result = upsertRingSenseSummary({
           body: '',
           summary: 'RS summary content',
           logFormat: LOG_DETAILS_FORMAT_TYPE.PLAIN_TEXT
         });
 
-        expect(result).toContain('RingSense summary');
+        expect(result).toContain('ACE summary');
         expect(result).toContain('RS summary content');
       });
 
@@ -1079,7 +1079,7 @@ describe('callLogComposer', () => {
           logFormat: LOG_DETAILS_FORMAT_TYPE.HTML
         });
 
-        expect(result).toContain('<b>RingSense summary</b>');
+        expect(result).toContain('<b>ACE summary</b>');
       });
 
       test('should add in Markdown format', () => {
@@ -1089,13 +1089,13 @@ describe('callLogComposer', () => {
           logFormat: LOG_DETAILS_FORMAT_TYPE.MARKDOWN
         });
 
-        expect(result).toContain('### RingSense summary');
+        expect(result).toContain('### ACE summary');
         expect(result).toContain('RS summary content');
       });
     });
 
     describe('upsertRingSenseAIScore', () => {
-      test('should add RingSense AI score', () => {
+      test('should add ACE AI score', () => {
         const result = upsertRingSenseAIScore({
           body: '',
           score: '85',
@@ -1127,14 +1127,14 @@ describe('callLogComposer', () => {
     });
 
     describe('upsertRingSenseBulletedSummary', () => {
-      test('should add RingSense bulleted summary', () => {
+      test('should add ACE bulleted summary', () => {
         const result = upsertRingSenseBulletedSummary({
           body: '',
           summary: '- Point 1\n- Point 2',
           logFormat: LOG_DETAILS_FORMAT_TYPE.PLAIN_TEXT
         });
 
-        expect(result).toContain('RingSense bulleted summary');
+        expect(result).toContain('ACE bulleted summary');
         expect(result).toContain('- Point 1');
       });
 
@@ -1145,7 +1145,7 @@ describe('callLogComposer', () => {
           logFormat: LOG_DETAILS_FORMAT_TYPE.HTML
         });
 
-        expect(result).toContain('<b>RingSense bulleted summary</b>');
+        expect(result).toContain('<b>ACE bulleted summary</b>');
       });
 
       test('should add in Markdown format', () => {
@@ -1155,20 +1155,20 @@ describe('callLogComposer', () => {
           logFormat: LOG_DETAILS_FORMAT_TYPE.MARKDOWN
         });
 
-        expect(result).toContain('### RingSense bulleted summary');
+        expect(result).toContain('### ACE bulleted summary');
         expect(result).toContain('- Point 1');
       });
     });
 
     describe('upsertRingSenseLink', () => {
-      test('should add RingSense recording link', () => {
+      test('should add ACE recording link', () => {
         const result = upsertRingSenseLink({
           body: '',
           link: 'https://ringsense.example.com/123',
           logFormat: LOG_DETAILS_FORMAT_TYPE.PLAIN_TEXT
         });
 
-        expect(result).toContain('RingSense recording link: https://ringsense.example.com/123');
+        expect(result).toContain('ACE recording link: https://ringsense.example.com/123');
       });
 
       test('should add in HTML format with anchor', () => {
@@ -1188,7 +1188,7 @@ describe('callLogComposer', () => {
           logFormat: LOG_DETAILS_FORMAT_TYPE.MARKDOWN
         });
 
-        expect(result).toContain('**RingSense recording link**: https://ringsense.example.com/123');
+        expect(result).toContain('**ACE recording link**: https://ringsense.example.com/123');
       });
     });
   });

package/test/lib/jwt.test.js

@@ -35,6 +35,21 @@ describe('JWT Utility', () => {
       // Assert
       expect(token1).not.toBe(token2);
     });
+
+    test('should generate token with about 2 weeks lifetime', () => {
+      // Arrange
+      const payload = { id: 'user-ttl', platform: 'testCRM' };
+
+      // Act
+      const token = jwt.generateJwt(payload);
+      const decoded = jwt.decodeJwt(token);
+      const lifetimeSeconds = decoded.exp - decoded.iat;
+
+      // Assert
+      // Keep a tiny tolerance to avoid timing flakiness.
+      expect(lifetimeSeconds).toBeGreaterThanOrEqual((14 * 24 * 60 * 60) - 2);
+      expect(lifetimeSeconds).toBeLessThanOrEqual((14 * 24 * 60 * 60) + 2);
+    });
   });
 
   describe('decodeJwt', () => {

package/test/lib/util.test.js

@@ -8,8 +8,7 @@ const {
   getHashValue,
   secondsToHoursMinutesSeconds,
   getMostRecentDate,
-  getMediaReaderLinkByPlatformMediaLink,
-  getPluginsFromUserSettings
+  getMediaReaderLinkByPlatformMediaLink
 } = require('../../lib/util');
 
 describe('Utility Functions', () => {
@@ -326,335 +325,5 @@ describe('Utility Functions', () => {
     });
   });
 
-  describe('getPluginsFromUserSettings', () => {
-    test('should return empty array when userSettings is null', () => {
-      const result = getPluginsFromUserSettings({
-        userSettings: null,
-        logType: 'call'
-      });
-
-      expect(result).toEqual([]);
-    });
-
-    test('should return empty array when userSettings is undefined', () => {
-      const result = getPluginsFromUserSettings({
-        userSettings: undefined,
-        logType: 'call'
-      });
-
-      expect(result).toEqual([]);
-    });
-
-    test('should return empty array when userSettings is empty object', () => {
-      const result = getPluginsFromUserSettings({
-        userSettings: {},
-        logType: 'call'
-      });
-
-      expect(result).toEqual([]);
-    });
-
-    test('should return plugins matching logType', () => {
-      const userSettings = {
-        plugin_googleDrive: {
-          value: {
-            activated: true,
-            logTypes: ['call'],
-            name: 'Google Drive Upload',
-            isAsync: true
-          }
-        }
-      };
-
-      const result = getPluginsFromUserSettings({
-        userSettings,
-        logType: 'call'
-      });
-
-      expect(result).toHaveLength(1);
-      expect(result[0].id).toBe('googleDrive');
-      expect(result[0].value.name).toBe('Google Drive Upload');
-    });
-
-    test('should filter out non-plugin settings', () => {
-      const userSettings = {
-        plugin_piiRedaction: {
-          value: {
-            activated: true,
-            logTypes: ['call'],
-            name: 'PII Redaction'
-          }
-        },
-        theme: { value: 'dark' },
-        autoLog: { value: true },
-        notificationSound: { value: 'default' }
-      };
-
-      const result = getPluginsFromUserSettings({
-        userSettings,
-        logType: 'call'
-      });
-
-      expect(result).toHaveLength(1);
-      expect(result[0].id).toBe('piiRedaction');
-    });
-
-    test('should return all matching plugins regardless of logType mismatch', () => {
-      const userSettings = {
-        plugin_googleDrive: {
-          value: {
-            activated: false,
-            logTypes: ['message'],
-            name: 'Google Drive Upload'
-          }
-        },
-        plugin_piiRedaction: {
-          value: {
-            activated: true,
-            logTypes: ['call'],
-            name: 'PII Redaction'
-          }
-        }
-      };
-
-      const result = getPluginsFromUserSettings({
-        userSettings,
-        logType: 'call'
-      });
-
-      expect(result).toHaveLength(1);
-      expect(result[0].id).toBe('piiRedaction');
-    });
-
-    test('should correctly parse plugin ID from setting key', () => {
-      const userSettings = {
-        plugin_myCustomPlugin: {
-          value: {
-            activated: true,
-            logTypes: ['call'],
-            name: 'My Custom Plugin'
-          }
-        },
-        plugin_anotherOne: {
-          value: {
-            activated: true,
-            logTypes: ['call'],
-            name: 'Another One'
-          }
-        }
-      };
-
-      const result = getPluginsFromUserSettings({
-        userSettings,
-        logType: 'call'
-      });
-
-      expect(result).toHaveLength(2);
-      const ids = result.map(r => r.id);
-      expect(ids).toContain('myCustomPlugin');
-      expect(ids).toContain('anotherOne');
-    });
-
-    test('should return all plugins matching logType', () => {
-      const userSettings = {
-        plugin_piiRedaction: {
-          value: {
-            activated: true,
-            logTypes: ['call'],
-            name: 'PII Redaction'
-          }
-        },
-        plugin_googleDrive: {
-          value: {
-            activated: true,
-            logTypes: ['call'],
-            name: 'Google Drive Upload'
-          }
-        },
-        plugin_analytics: {
-          value: {
-            activated: true,
-            logTypes: ['call'],
-            name: 'Analytics'
-          }
-        }
-      };
-
-      const result = getPluginsFromUserSettings({
-        userSettings,
-        logType: 'call'
-      });
-
-      expect(result).toHaveLength(3);
-      const ids = result.map(r => r.id);
-      expect(ids).toContain('piiRedaction');
-      expect(ids).toContain('googleDrive');
-      expect(ids).toContain('analytics');
-    });
-
-    test('should filter by logType - call only', () => {
-      const userSettings = {
-        plugin_callOnly: {
-          value: {
-            activated: true,
-            logTypes: ['call'],
-            name: 'Call Only Plugin'
-          }
-        },
-        plugin_messageOnly: {
-          value: {
-            activated: true,
-            logTypes: ['message'],
-            name: 'Message Only Plugin'
-          }
-        }
-      };
-
-      const result = getPluginsFromUserSettings({
-        userSettings,
-        logType: 'call'
-      });
-
-      expect(result).toHaveLength(1);
-      expect(result[0].id).toBe('callOnly');
-    });
-
-    test('should filter by logType - message only', () => {
-      const userSettings = {
-        plugin_callOnly: {
-          value: {
-            activated: true,
-            logTypes: ['call'],
-            name: 'Call Only Plugin'
-          }
-        },
-        plugin_messageOnly: {
-          value: {
-            activated: true,
-            logTypes: ['message'],
-            name: 'Message Only Plugin'
-          }
-        }
-      };
-
-      const result = getPluginsFromUserSettings({
-        userSettings,
-        logType: 'message'
-      });
-
-      expect(result).toHaveLength(1);
-      expect(result[0].id).toBe('messageOnly');
-    });
-
-    test('should only return plugin when logType matches supportedLogType', () => {
-      const userSettings = {
-        plugin_callPlugin: {
-          value: {
-            activated: true,
-            logTypes: ['call'],
-            name: 'Call Plugin'
-          }
-        }
-      };
-
-      const callResult = getPluginsFromUserSettings({
-        userSettings,
-        logType: 'call'
-      });
-      expect(callResult).toHaveLength(1);
-      expect(callResult[0].id).toBe('callPlugin');
-
-      const messageResult = getPluginsFromUserSettings({
-        userSettings,
-        logType: 'message'
-      });
-      expect(messageResult).toHaveLength(0);
-    });
-
-    test('should return empty array when no plugins match logType', () => {
-      const userSettings = {
-        plugin_googleDrive: {
-          value: {
-            activated: true,
-            logTypes: ['call'],
-            name: 'Google Drive Upload'
-          }
-        }
-      };
-
-      const result = getPluginsFromUserSettings({
-        userSettings,
-        logType: 'message'
-      });
-      expect(result).toEqual([]);
-    });
-
-    test('should preserve full plugin value in result', () => {
-      const pluginValue = {
-        activated: true,
-        logTypes: ['call'],
-        name: 'Google Drive Upload',
-        isAsync: true,
-        customOption: 'someValue'
-      };
-
-      const userSettings = {
-        plugin_googleDrive: {
-          value: pluginValue
-        }
-      };
-
-      const result = getPluginsFromUserSettings({
-        userSettings,
-        logType: 'call'
-      });
-
-      expect(result).toHaveLength(1);
-      expect(result[0].value).toEqual(pluginValue);
-    });
-
-    test('should correctly parse plugin ID containing underscores', () => {
-      // Bug test: plugin IDs with underscores should be fully preserved
-      const userSettings = {
-        plugin_my_custom_plugin: {
-          value: {
-            activated: true,
-            logTypes: ['call'],
-            name: 'My Custom Plugin'
-          }
-        }
-      };
-
-      const result = getPluginsFromUserSettings({
-        userSettings,
-        logType: 'call'
-      });
-
-      expect(result).toHaveLength(1);
-      // The full ID should be 'my_custom_plugin', not just 'my'
-      expect(result[0].id).toBe('my_custom_plugin');
-    });
-
-    test('should handle plugin settings with missing value property gracefully', () => {
-      const userSettings = {
-        plugin_broken: null,
-        plugin_working: {
-          value: {
-            activated: true,
-            logTypes: ['call'],
-            name: 'Working Plugin'
-          }
-        }
-      };
-
-      // This should not throw, even with malformed settings
-      expect(() => {
-        getPluginsFromUserSettings({
-          userSettings,
-          logType: 'call'
-        });
-      }).toThrow(); // Currently throws - documenting existing behavior
-    });
-  });
 });
 

package/test/mcp/tools/createCallLog.test.js

@@ -292,6 +292,17 @@ describe('MCP Tool: createCallLog', () => {
       expect(result.error).toContain('Invalid JWT token');
     });
 
+    test('should return error when decodeJwt returns null', async () => {
+      jwt.decodeJwt.mockReturnValue(null);
+      const result = await createCallLog.execute({
+        jwtToken: 'invalid-token',
+        incomingData: { logInfo: { sessionId: 'session-123' } }
+      });
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain('Invalid JWT token');
+    });
+
     test('should return error when platform connector not found', async () => {
       // Arrange
       const mockIncomingData = {

package/test/mcp/tools/createContact.test.js

@@ -0,0 +1,58 @@
+const createContact = require('../../../mcp/tools/createContact');
+const jwt = require('../../../lib/jwt');
+const connectorRegistry = require('../../../connector/registry');
+const contactCore = require('../../../handlers/contact');
+
+jest.mock('../../../lib/jwt');
+jest.mock('../../../connector/registry');
+jest.mock('../../../handlers/contact');
+
+describe('MCP Tool: createContact', () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  test('should have correct tool definition', () => {
+    expect(createContact.definition).toBeDefined();
+    expect(createContact.definition.name).toBe('createContact');
+    expect(createContact.definition.inputSchema.required).toContain('phoneNumber');
+  });
+
+  test('should create contact successfully', async () => {
+    jwt.decodeJwt.mockReturnValue({ id: 'user-123', platform: 'testCRM' });
+    connectorRegistry.getConnector.mockReturnValue({ createContact: jest.fn() });
+    contactCore.createContact.mockResolvedValue({
+      successful: true,
+      returnMessage: { message: 'Created' },
+      contact: { id: 'contact-1' }
+    });
+
+    const result = await createContact.execute({
+      jwtToken: 'mock-jwt-token',
+      phoneNumber: '+14155551234',
+      newContactName: 'John Doe'
+    });
+
+    expect(result).toEqual({
+      success: true,
+      data: {
+        contact: { id: 'contact-1' },
+        message: 'Created'
+      }
+    });
+  });
+
+  test('should return error when decodeJwt returns null', async () => {
+    jwt.decodeJwt.mockReturnValue(null);
+
+    const result = await createContact.execute({
+      jwtToken: 'invalid-jwt',
+      phoneNumber: '+14155551234',
+      newContactName: 'John Doe'
+    });
+
+    expect(result.success).toBe(false);
+    expect(result.error).toContain('Invalid JWT token');
+  });
+});
+

package/test/mcp/tools/createMessageLog.test.js

@@ -427,6 +427,21 @@ describe('MCP Tool: createMessageLog', () => {
       expect(result.error).toContain('Invalid JWT token');
     });
 
+    test('should return error when decodeJwt returns null', async () => {
+      jwt.decodeJwt.mockReturnValue(null);
+
+      const result = await createMessageLog.execute({
+        jwtToken: 'invalid-token',
+        incomingData: {
+          sessionId: 'session-123',
+          messageInfo: { from: { phoneNumber: '+1234567890' }, to: [{ phoneNumber: '+1098765432' }] }
+        }
+      });
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain('Invalid JWT token');
+    });
+
     test('should return error when platform connector not found', async () => {
       // Arrange
       const mockIncomingData = {

package/test/mcp/tools/findContactByName.test.js

@@ -162,6 +162,18 @@ describe('MCP Tool: findContactByName', () => {
       expect(result.error).toContain('Invalid JWT token');
     });
 
+    test('should return error when decodeJwt returns null', async () => {
+      jwt.decodeJwt.mockReturnValue(null);
+
+      const result = await findContactByName.execute({
+        jwtToken: 'invalid-token',
+        name: 'John Doe'
+      });
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain('Invalid JWT token');
+    });
+
     test('should return error when platform connector not found', async () => {
       // Arrange
       jwt.decodeJwt.mockReturnValue({

package/test/mcp/tools/findContactByPhone.test.js

@@ -211,6 +211,18 @@ describe('MCP Tool: findContactByPhone', () => {
       expect(result.error).toContain('Invalid JWT token');
     });
 
+    test('should return error when decodeJwt returns null', async () => {
+      jwt.decodeJwt.mockReturnValue(null);
+
+      const result = await findContactByPhone.execute({
+        jwtToken: 'invalid-token',
+        phoneNumber: '+1234567890'
+      });
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain('Invalid JWT token');
+    });
+
     test('should return error when platform connector not found', async () => {
       // Arrange
       jwt.decodeJwt.mockReturnValue({

package/test/mcp/tools/getCallLog.test.js

@@ -213,6 +213,18 @@ describe('MCP Tool: getCallLog', () => {
       expect(result.error).toContain('Invalid JWT token');
     });
 
+    test('should return error when decodeJwt returns null', async () => {
+      jwt.decodeJwt.mockReturnValue(null);
+
+      const result = await getCallLog.execute({
+        jwtToken: 'invalid-token',
+        sessionIds: ['session-123']
+      });
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain('Invalid JWT token');
+    });
+
     test('should return error when platform connector not found', async () => {
       // Arrange
       jwt.decodeJwt.mockReturnValue({