@app-connect/core 1.7.11 → 1.7.12

package/mcp/tools/getPublicConnectors.js

@@ -13,9 +13,16 @@ const toolDefinition = {
         type: 'object',
         properties: {},
         required: []
+    },
+    annotations: {
+        readOnlyHint: true,
+        openWorldHint: false,
+        destructiveHint: false
     }
 };
 
+const supportedPlatforms = ['googleSheets','clio'];
+
 /**
  * Execute the getPublicConnectors tool
  * @returns {Object} Result object with connector names
@@ -30,7 +37,7 @@ async function execute() {
         }
         return {
             success: true,
-            data: connectorList.map(c => c.displayName)
+            data: connectorList.filter(c => supportedPlatforms.includes(c.name)).map(c => c.displayName)
         };
     }
     catch (error) {

package/mcp/tools/index.js

@@ -19,6 +19,8 @@ const createCallLog = require('./createCallLog');
 const updateCallLog = require('./updateCallLog');
 const createMessageLog = require('./createMessageLog');
 const rcGetCallLogs = require('./rcGetCallLogs');
+const getGoogleFilePicker = require('./getGoogleFilePicker');
+const createContact = require('./createContact');
 
 // Export all tools
 module.exports = {
@@ -31,11 +33,13 @@ module.exports = {
     logout,
     findContact,
     findContactWithName,
-    getCallLog,
+    //getCallLog,
     createCallLog,
-    updateCallLog,
-    createMessageLog,
-    rcGetCallLogs
+    //updateCallLog,
+    //createMessageLog,
+    rcGetCallLogs,
+    getGoogleFilePicker,
+    createContact
 };
 
 // Export tools as an array for easy iteration
@@ -49,10 +53,12 @@ module.exports.tools = [
     logout,
     findContact,
     findContactWithName,
-    getCallLog,
+    //getCallLog,
     createCallLog,
-    updateCallLog,
-    createMessageLog,
-    rcGetCallLogs
+    //updateCallLog,
+    //createMessageLog,
+    rcGetCallLogs,
+    getGoogleFilePicker,
+    createContact
 ];
 

package/mcp/tools/logout.js

@@ -19,6 +19,11 @@ const toolDefinition = {
                 description: 'JWT token containing userId and platform information. If user does not have this, direct them to use the "auth" tool first.'
             }
         }
+    },
+    annotations: {
+        readOnlyHint: false,
+        openWorldHint: false,
+        destructiveHint: true
     }
 };
 

package/mcp/tools/rcGetCallLogs.js

@@ -22,6 +22,11 @@ const toolDefinition = {
             }
         },
         required: ['jwtToken', 'timeFrom', 'timeTo']
+    },
+    annotations: {
+        readOnlyHint: true,
+        openWorldHint: false,
+        destructiveHint: false
     }
 }
 

package/mcp/tools/setConnector.js

@@ -8,7 +8,7 @@ const developerPortal = require('../../connector/developerPortal');
 
 const toolDefinition = {
     name: 'setConnector',
-    description: 'Auth flow step.2. Save connectorManifest to memory if successful. Next step is optional, if it is oauth, go to step.3 "collectAuthInfo" tool.',
+    description: 'Auth flow step.2. Save connectorManifest to memory if successful.',
     inputSchema: {
         type: 'object',
         properties: {
@@ -18,6 +18,11 @@ const toolDefinition = {
             }
         },
         required: ['connectorDisplayName']
+    },
+    annotations: {
+        readOnlyHint: true,
+        openWorldHint: false,
+        destructiveHint: false
     }
 };
 
@@ -46,7 +51,7 @@ async function execute(args) {
                 connectorDisplayName,
                 connectorName,
                 // Add explicit instruction
-                message: "IMPORTANT: Use connectorManifest, connectorDisplayName, and connectorName in the next few authentication steps.",
+                message: "IMPORTANT: Use connectorManifest, connectorDisplayName, and connectorName in the next few authentication steps. Call 'collectAuthInfo' tool if the connector is oauth, unless connectorManifest.platform[0].environment.type == 'fixed'.",
                 
             }
         };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@app-connect/core",
-  "version": "1.7.11",
+  "version": "1.7.12",
   "description": "RingCentral App Connect Core",
   "main": "index.js",
   "repository": {

package/releaseNotes.json

@@ -1,4 +1,16 @@
 {
+    "1.7.12": {
+        "global": [
+            {
+                "type": "New",
+                "description": "A button on Developer settings page to re-initialize user mapping"
+            },
+            {
+                "type": "Better",
+                "description": "Click-to-SMS button is disabled if RingCentral SMS service is not activated"
+            }
+        ]
+    },
     "1.7.11": {
         "global": [
             {

package/test/handlers/log.test.js

@@ -691,10 +691,12 @@ describe('Log Handler', () => {
         platformAdditionalInfo: {}
       });
 
+      // Create existing message log with same conversationLogId
       await MessageLogModel.create({
         id: 'msg-1',
         platform: 'testCRM',
         conversationId: 'conv-123',
+        conversationLogId: 'conv-log-123',
         thirdPartyLogId: 'existing-log',
         userId: 'test-user-id'
       });
@@ -720,7 +722,7 @@ describe('Log Handler', () => {
           ],
           correspondents: [{ phoneNumber: '+1234567890' }],
           conversationId: 'conv-123',
-          conversationLogId: 'new-conv-log-123'
+          conversationLogId: 'conv-log-123'  // Same conversationLogId as existing record
         },
         contactId: 'contact-123',
         contactType: 'Contact',
@@ -736,7 +738,7 @@ describe('Log Handler', () => {
 
       // Assert
       expect(result.successful).toBe(true);
-      // msg-1 is skipped (already logged), msg-2 uses updateMessageLog because same conversationId exists
+      // msg-1 is skipped (already logged), msg-2 uses updateMessageLog because same conversationLogId exists
       expect(mockConnector.createMessageLog).toHaveBeenCalledTimes(0);
       expect(mockConnector.updateMessageLog).toHaveBeenCalledTimes(1);
     });
@@ -771,7 +773,8 @@ describe('Log Handler', () => {
 
       // Assert
       expect(result.successful).toBe(false);
-      expect(result.returnMessage).toBe('Error saving note cache');
+      expect(result.returnMessage.message).toBe('Error performing saveNoteCache');
+      expect(result.returnMessage.messageType).toBe('warning');
     });
   });
 

package/test/lib/ringcentral.test.js

@@ -126,9 +126,6 @@ describe('ringcentral', () => {
         expect(result.refresh_token).toBe('new-refresh-token');
         expect(result.expire_time).toBeDefined();
         expect(result.refresh_token_expire_time).toBeDefined();
-        // These should not be included
-        expect(result.scope).toBeUndefined();
-        expect(result.endpoint_id).toBeUndefined();
       });
 
       test('should throw error on failed token generation', async () => {
@@ -317,9 +314,6 @@ describe('ringcentral', () => {
         }, token);
 
         expect(result.id).toBe('sub-123');
-        // These should not be included in result
-        expect(result.uri).toBeUndefined();
-        expect(result.creationTime).toBeUndefined();
       });
     });
 

package/test/lib/sharedSMSComposer.test.js

@@ -61,7 +61,7 @@ describe('sharedSMSComposer', () => {
         timezoneOffset: '+00:00'
       });
 
-      expect(result.subject).toBe('<b>SMS conversation with John Customer</b>');
+      expect(result.subject).toBe('SMS conversation with John Customer');
       expect(result.body).toContain('<b>Conversation summary</b>');
       expect(result.body).toContain('<b>Participants</b>');
       expect(result.body).toContain('<li>');

package/test/mcp/tools/collectAuthInfo.test.js

@@ -22,6 +22,13 @@ describe('MCP Tool: collectAuthInfo', () => {
         platforms: {
           salesforce: {
             name: 'salesforce',
+            auth: {
+              type: 'oauth',
+              oauth: {
+                authUrl: 'https://login.salesforce.com/services/oauth2/authorize',
+                clientId: 'test-client-id'
+              }
+            },
             environment: {
               type: 'selectable',
               selections: [
@@ -56,6 +63,13 @@ describe('MCP Tool: collectAuthInfo', () => {
         platforms: {
           netsuite: {
             name: 'netsuite',
+            auth: {
+              type: 'oauth',
+              oauth: {
+                authUrl: 'https://system.netsuite.com/app/login/oauth2/authorize.nl',
+                clientId: 'test-client-id'
+              }
+            },
             environment: {
               type: 'dynamic'
             }
@@ -86,6 +100,13 @@ describe('MCP Tool: collectAuthInfo', () => {
         platforms: {
           salesforce: {
             name: 'salesforce',
+            auth: {
+              type: 'oauth',
+              oauth: {
+                authUrl: 'https://login.salesforce.com/services/oauth2/authorize',
+                clientId: 'test-client-id'
+              }
+            },
             environment: {
               type: 'selectable',
               selections: [
@@ -115,6 +136,13 @@ describe('MCP Tool: collectAuthInfo', () => {
         platforms: {
           netsuite: {
             name: 'netsuite',
+            auth: {
+              type: 'oauth',
+              oauth: {
+                authUrl: 'https://system.netsuite.com/app/login/oauth2/authorize.nl',
+                clientId: 'test-client-id'
+              }
+            },
             environment: {
               type: 'dynamic'
             }
@@ -141,6 +169,13 @@ describe('MCP Tool: collectAuthInfo', () => {
         platforms: {
           salesforce: {
             name: 'salesforce',
+            auth: {
+              type: 'oauth',
+              oauth: {
+                authUrl: 'https://login.salesforce.com/services/oauth2/authorize',
+                clientId: 'test-client-id'
+              }
+            },
             environment: {
               type: 'selectable',
               selections: [
@@ -169,6 +204,13 @@ describe('MCP Tool: collectAuthInfo', () => {
         platforms: {
           netsuite: {
             name: 'netsuite',
+            auth: {
+              type: 'oauth',
+              oauth: {
+                authUrl: 'https://system.netsuite.com/app/login/oauth2/authorize.nl',
+                clientId: 'test-client-id'
+              }
+            },
             environment: {
               type: 'dynamic'
             }

package/test/mcp/tools/createCallLog.test.js

@@ -2,6 +2,7 @@ const createCallLog = require('../../../mcp/tools/createCallLog');
 const jwt = require('../../../lib/jwt');
 const connectorRegistry = require('../../../connector/registry');
 const logCore = require('../../../handlers/log');
+const contactCore = require('../../../handlers/contact');
 const util = require('../../../lib/util');
 const { CallLogModel } = require('../../../models/callLogModel');
 
@@ -9,6 +10,7 @@ const { CallLogModel } = require('../../../models/callLogModel');
 jest.mock('../../../lib/jwt');
 jest.mock('../../../connector/registry');
 jest.mock('../../../handlers/log');
+jest.mock('../../../handlers/contact');
 jest.mock('../../../lib/util');
 jest.mock('../../../models/callLogModel');
 
@@ -34,10 +36,8 @@ describe('MCP Tool: createCallLog', () => {
     test('should have detailed inputSchema for incomingData', () => {
       const incomingDataSchema = createCallLog.definition.inputSchema.properties.incomingData;
       expect(incomingDataSchema.properties).toHaveProperty('logInfo');
-      expect(incomingDataSchema.properties).toHaveProperty('contactId');
       expect(incomingDataSchema.properties).toHaveProperty('note');
       expect(incomingDataSchema.required).toContain('logInfo');
-      expect(incomingDataSchema.required).toContain('contactId');
     });
   });
 
@@ -55,7 +55,6 @@ describe('MCP Tool: createCallLog', () => {
           to: { phoneNumber: '+0987654321', name: 'Company' },
           accountId: 'rc-account-123'
         },
-        contactId: 'contact-123',
         contactName: 'John Doe',
         contactType: 'Contact',
         note: 'Test call note'
@@ -75,6 +74,12 @@ describe('MCP Tool: createCallLog', () => {
 
       util.getHashValue.mockReturnValue('hashed-account-id');
 
+      // Mock contactCore.findContact to return a contact
+      contactCore.findContact.mockResolvedValue({
+        successful: true,
+        contact: [{ id: 'contact-123', isNewContact: false }]
+      });
+
       logCore.createCallLog.mockResolvedValue({
         successful: true,
         logId: 'crm-log-123',
@@ -99,13 +104,6 @@ describe('MCP Tool: createCallLog', () => {
       expect(CallLogModel.findOne).toHaveBeenCalledWith({
         where: { sessionId: 'session-123' }
       });
-      expect(logCore.createCallLog).toHaveBeenCalledWith({
-        platform: 'testCRM',
-        userId: 'user-123',
-        incomingData: mockIncomingData,
-        hashedAccountId: 'hashed-account-id',
-        isFromSSCL: false
-      });
     });
 
     test('should create call log with AI note and transcript', async () => {
@@ -120,7 +118,6 @@ describe('MCP Tool: createCallLog', () => {
           from: { phoneNumber: '+0987654321' },
           to: { phoneNumber: '+1234567890' }
         },
-        contactId: 'contact-456',
         aiNote: 'AI generated summary of the call',
         transcript: 'Full call transcript text'
       };
@@ -137,6 +134,12 @@ describe('MCP Tool: createCallLog', () => {
 
       CallLogModel.findOne.mockResolvedValue(null);
 
+      // Mock contactCore.findContact to return a contact
+      contactCore.findContact.mockResolvedValue({
+        successful: true,
+        contact: [{ id: 'contact-456', isNewContact: false }]
+      });
+
       logCore.createCallLog.mockResolvedValue({
         successful: true,
         logId: 'crm-log-456'
@@ -165,7 +168,6 @@ describe('MCP Tool: createCallLog', () => {
           from: { phoneNumber: '+1234567890' },
           to: { phoneNumber: '+0987654321' }
         },
-        contactId: 'contact-789',
         additionalSubmission: {
           isAssignedToUser: true,
           adminAssignedUserToken: 'admin-jwt-token',
@@ -185,6 +187,12 @@ describe('MCP Tool: createCallLog', () => {
 
       CallLogModel.findOne.mockResolvedValue(null);
 
+      // Mock contactCore.findContact to return a contact
+      contactCore.findContact.mockResolvedValue({
+        successful: true,
+        contact: [{ id: 'contact-789', isNewContact: false }]
+      });
+
       logCore.createCallLog.mockResolvedValue({
         successful: true,
         logId: 'crm-log-789'
@@ -352,8 +360,7 @@ describe('MCP Tool: createCallLog', () => {
           duration: 45,
           from: { phoneNumber: '+1234567890' },
           to: { phoneNumber: '+0987654321' }
-        },
-        contactId: 'contact-999'
+        }
       };
 
       jwt.decodeJwt.mockReturnValue({
@@ -368,6 +375,12 @@ describe('MCP Tool: createCallLog', () => {
 
       CallLogModel.findOne.mockResolvedValue(null);
 
+      // Mock contactCore.findContact to return a contact
+      contactCore.findContact.mockResolvedValue({
+        successful: true,
+        contact: [{ id: 'contact-999', isNewContact: false }]
+      });
+
       logCore.createCallLog.mockResolvedValue({
         successful: false,
         returnMessage: { message: 'Failed to create log in CRM' }

package/test/mcp/tools/doAuth.test.js

@@ -37,7 +37,7 @@ describe('MCP Tool: doAuth', () => {
         platforms: {
           testCRM: {
             name: 'testCRM',
-            auth: { type: 'apiKey' },
+            auth: { type: 'apiKey', apiKey: { name: 'apiKey' } },
             environment: { type: 'fixed' }
           }
         }
@@ -88,7 +88,7 @@ describe('MCP Tool: doAuth', () => {
         platforms: {
           testCRM: {
             name: 'testCRM',
-            auth: { type: 'apiKey' }
+            auth: { type: 'apiKey', apiKey: { name: 'apiKey' } }
           }
         }
       };
@@ -135,7 +135,7 @@ describe('MCP Tool: doAuth', () => {
         platforms: {
           testCRM: {
             name: 'testCRM',
-            auth: { type: 'apiKey' }
+            auth: { type: 'apiKey', apiKey: { name: 'apiKey' } }
           }
         }
       };
@@ -203,7 +203,10 @@ describe('MCP Tool: doAuth', () => {
             name: 'salesforce',
             auth: {
               type: 'oauth',
-              oauth: {}
+              oauth: {
+                authUrl: 'https://login.salesforce.com/services/oauth2/authorize',
+                clientId: 'test-client-id'
+              }
             }
           }
         }
@@ -254,7 +257,10 @@ describe('MCP Tool: doAuth', () => {
             name: 'salesforce',
             auth: {
               type: 'oauth',
-              oauth: {}
+              oauth: {
+                authUrl: 'https://login.salesforce.com/services/oauth2/authorize',
+                clientId: 'test-client-id'
+              }
             }
           }
         }
@@ -264,12 +270,12 @@ describe('MCP Tool: doAuth', () => {
         userInfo: null
       });
 
-      // Act
+      // Act - callbackUri needs code= and state= to be treated as OAuth callback
       const result = await doAuth.execute({
         connectorManifest: mockManifest,
         connectorName: 'salesforce',
         hostname: 'login.salesforce.com',
-        callbackUri: 'https://redirect.com?error=access_denied'
+        callbackUri: 'https://redirect.com?code=invalid-code&state=test-state'
       });
 
       // Assert
@@ -305,9 +311,16 @@ describe('MCP Tool: doAuth', () => {
         connectorName: 'customCRM'
       });
 
-      // Assert
+      // Assert - state is now URL-encoded and includes sessionId, platform, hostname, plus customState
       expect(result.success).toBe(true);
-      expect(result.data.authUri).toContain('state=custom=state&other=value');
+      // The state parameter now contains session info and custom state appended
+      // Decode and verify custom state is included
+      const stateMatch = result.data.authUri.match(/state=([^&]+)/);
+      expect(stateMatch).toBeTruthy();
+      const decodedState = decodeURIComponent(stateMatch[1]);
+      expect(decodedState).toContain('custom=state&other=value');
+      expect(decodedState).toContain('sessionId=');
+      expect(decodedState).toContain('platform=customCRM');
     });
   });
 
@@ -318,7 +331,7 @@ describe('MCP Tool: doAuth', () => {
         platforms: {
           testCRM: {
             name: 'testCRM',
-            auth: { type: 'apiKey' }
+            auth: { type: 'apiKey', apiKey: { name: 'apiKey' } }
           }
         }
       };