@app-connect/core 1.7.10 → 1.7.12

package/test/mcp/tools/doAuth.test.js

@@ -0,0 +1,376 @@
+const doAuth = require('../../../mcp/tools/doAuth');
+const authCore = require('../../../handlers/auth');
+const jwt = require('../../../lib/jwt');
+
+// Mock dependencies
+jest.mock('../../../handlers/auth');
+jest.mock('../../../lib/jwt');
+
+describe('MCP Tool: doAuth', () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+    process.env.APP_SERVER_SECRET_KEY = 'test-secret-key';
+  });
+
+  describe('tool definition', () => {
+    test('should have correct tool definition', () => {
+      expect(doAuth.definition).toBeDefined();
+      expect(doAuth.definition.name).toBe('doAuth');
+      expect(doAuth.definition.description).toContain('Auth flow step.4');
+      expect(doAuth.definition.inputSchema).toBeDefined();
+    });
+
+    test('should have optional parameters', () => {
+      expect(doAuth.definition.inputSchema.properties).toHaveProperty('connectorManifest');
+      expect(doAuth.definition.inputSchema.properties).toHaveProperty('connectorName');
+      expect(doAuth.definition.inputSchema.properties).toHaveProperty('hostname');
+      expect(doAuth.definition.inputSchema.properties).toHaveProperty('apiKey');
+      expect(doAuth.definition.inputSchema.properties).toHaveProperty('additionalInfo');
+      expect(doAuth.definition.inputSchema.properties).toHaveProperty('callbackUri');
+    });
+  });
+
+  describe('execute - apiKey authentication', () => {
+    test('should authenticate with API key successfully', async () => {
+      // Arrange
+      const mockManifest = {
+        platforms: {
+          testCRM: {
+            name: 'testCRM',
+            auth: { type: 'apiKey', apiKey: { name: 'apiKey' } },
+            environment: { type: 'fixed' }
+          }
+        }
+      };
+
+      const mockUserInfo = {
+        id: 'test-user-123',
+        name: 'Test User'
+      };
+
+      authCore.onApiKeyLogin.mockResolvedValue({
+        userInfo: mockUserInfo
+      });
+
+      jwt.generateJwt.mockReturnValue('mock-jwt-token');
+
+      // Act
+      const result = await doAuth.execute({
+        connectorManifest: mockManifest,
+        connectorName: 'testCRM',
+        hostname: 'test.crm.com',
+        apiKey: 'test-api-key'
+      });
+
+      // Assert
+      expect(result).toEqual({
+        success: true,
+        data: {
+          jwtToken: 'mock-jwt-token',
+          message: expect.stringContaining('IMPORTANT')
+        }
+      });
+      expect(authCore.onApiKeyLogin).toHaveBeenCalledWith({
+        platform: 'testCRM',
+        hostname: 'test.crm.com',
+        apiKey: 'test-api-key',
+        additionalInfo: undefined
+      });
+      expect(jwt.generateJwt).toHaveBeenCalledWith({
+        id: 'test-user-123',
+        platform: 'testCRM'
+      });
+    });
+
+    test('should handle apiKey authentication with additional info', async () => {
+      // Arrange
+      const mockManifest = {
+        platforms: {
+          testCRM: {
+            name: 'testCRM',
+            auth: { type: 'apiKey', apiKey: { name: 'apiKey' } }
+          }
+        }
+      };
+
+      const additionalInfo = {
+        username: 'testuser',
+        password: 'testpass',
+        apiUrl: 'https://api.test.com'
+      };
+
+      const mockUserInfo = {
+        id: 'test-user-456',
+        name: 'Test User'
+      };
+
+      authCore.onApiKeyLogin.mockResolvedValue({
+        userInfo: mockUserInfo
+      });
+
+      jwt.generateJwt.mockReturnValue('mock-jwt-token-2');
+
+      // Act
+      const result = await doAuth.execute({
+        connectorManifest: mockManifest,
+        connectorName: 'testCRM',
+        hostname: 'test.crm.com',
+        apiKey: 'test-api-key',
+        additionalInfo
+      });
+
+      // Assert
+      expect(result.success).toBe(true);
+      expect(authCore.onApiKeyLogin).toHaveBeenCalledWith({
+        platform: 'testCRM',
+        hostname: 'test.crm.com',
+        apiKey: 'test-api-key',
+        additionalInfo
+      });
+    });
+
+    test('should return error when user info not found', async () => {
+      // Arrange
+      const mockManifest = {
+        platforms: {
+          testCRM: {
+            name: 'testCRM',
+            auth: { type: 'apiKey', apiKey: { name: 'apiKey' } }
+          }
+        }
+      };
+
+      authCore.onApiKeyLogin.mockResolvedValue({
+        userInfo: null
+      });
+
+      // Act
+      const result = await doAuth.execute({
+        connectorManifest: mockManifest,
+        connectorName: 'testCRM',
+        hostname: 'test.crm.com',
+        apiKey: 'invalid-api-key'
+      });
+
+      // Assert
+      expect(result).toEqual({
+        success: false,
+        error: 'Authentication failed',
+        errorDetails: 'User info not found'
+      });
+    });
+  });
+
+  describe('execute - OAuth authentication', () => {
+    test('should return auth URI when callback not provided', async () => {
+      // Arrange
+      const mockManifest = {
+        platforms: {
+          salesforce: {
+            name: 'salesforce',
+            auth: {
+              type: 'oauth',
+              oauth: {
+                authUrl: 'https://login.salesforce.com/services/oauth2/authorize',
+                clientId: 'test-client-id',
+                scope: 'api refresh_token',
+                customState: ''
+              }
+            }
+          }
+        }
+      };
+
+      // Act
+      const result = await doAuth.execute({
+        connectorManifest: mockManifest,
+        connectorName: 'salesforce'
+      });
+
+      // Assert
+      expect(result.success).toBe(true);
+      expect(result.data.authUri).toContain('https://login.salesforce.com');
+      expect(result.data.authUri).toContain('client_id=test-client-id');
+      expect(result.data.authUri).toContain('response_type=code');
+      expect(result.data.message).toContain('IMPORTANT');
+    });
+
+    test('should handle OAuth callback successfully', async () => {
+      // Arrange
+      const mockManifest = {
+        platforms: {
+          salesforce: {
+            name: 'salesforce',
+            auth: {
+              type: 'oauth',
+              oauth: {
+                authUrl: 'https://login.salesforce.com/services/oauth2/authorize',
+                clientId: 'test-client-id'
+              }
+            }
+          }
+        }
+      };
+
+      const mockUserInfo = {
+        id: 'sf-user-123',
+        name: 'SF User'
+      };
+
+      authCore.onOAuthCallback.mockResolvedValue({
+        userInfo: mockUserInfo
+      });
+
+      jwt.generateJwt.mockReturnValue('mock-jwt-token-oauth');
+
+      // Act
+      const result = await doAuth.execute({
+        connectorManifest: mockManifest,
+        connectorName: 'salesforce',
+        hostname: 'login.salesforce.com',
+        callbackUri: 'https://redirect.com?code=test-code&state=test-state'
+      });
+
+      // Assert
+      expect(result).toEqual({
+        success: true,
+        data: {
+          jwtToken: 'mock-jwt-token-oauth',
+          message: expect.stringContaining('IMPORTANT')
+        }
+      });
+      expect(authCore.onOAuthCallback).toHaveBeenCalledWith({
+        platform: 'salesforce',
+        hostname: 'login.salesforce.com',
+        callbackUri: 'https://redirect.com?code=test-code&state=test-state',
+        query: expect.objectContaining({
+          hostname: 'login.salesforce.com'
+        })
+      });
+    });
+
+    test('should return error when OAuth callback fails', async () => {
+      // Arrange
+      const mockManifest = {
+        platforms: {
+          salesforce: {
+            name: 'salesforce',
+            auth: {
+              type: 'oauth',
+              oauth: {
+                authUrl: 'https://login.salesforce.com/services/oauth2/authorize',
+                clientId: 'test-client-id'
+              }
+            }
+          }
+        }
+      };
+
+      authCore.onOAuthCallback.mockResolvedValue({
+        userInfo: null
+      });
+
+      // Act - callbackUri needs code= and state= to be treated as OAuth callback
+      const result = await doAuth.execute({
+        connectorManifest: mockManifest,
+        connectorName: 'salesforce',
+        hostname: 'login.salesforce.com',
+        callbackUri: 'https://redirect.com?code=invalid-code&state=test-state'
+      });
+
+      // Assert
+      expect(result).toEqual({
+        success: false,
+        error: 'Authentication failed',
+        errorDetails: 'User info not found'
+      });
+    });
+
+    test('should include custom state in auth URI', async () => {
+      // Arrange
+      const mockManifest = {
+        platforms: {
+          customCRM: {
+            name: 'customCRM',
+            auth: {
+              type: 'oauth',
+              oauth: {
+                authUrl: 'https://custom.com/oauth',
+                clientId: 'custom-client-id',
+                scope: '',
+                customState: 'custom=state&other=value'
+              }
+            }
+          }
+        }
+      };
+
+      // Act
+      const result = await doAuth.execute({
+        connectorManifest: mockManifest,
+        connectorName: 'customCRM'
+      });
+
+      // Assert - state is now URL-encoded and includes sessionId, platform, hostname, plus customState
+      expect(result.success).toBe(true);
+      // The state parameter now contains session info and custom state appended
+      // Decode and verify custom state is included
+      const stateMatch = result.data.authUri.match(/state=([^&]+)/);
+      expect(stateMatch).toBeTruthy();
+      const decodedState = decodeURIComponent(stateMatch[1]);
+      expect(decodedState).toContain('custom=state&other=value');
+      expect(decodedState).toContain('sessionId=');
+      expect(decodedState).toContain('platform=customCRM');
+    });
+  });
+
+  describe('error handling', () => {
+    test('should handle authentication errors gracefully', async () => {
+      // Arrange
+      const mockManifest = {
+        platforms: {
+          testCRM: {
+            name: 'testCRM',
+            auth: { type: 'apiKey', apiKey: { name: 'apiKey' } }
+          }
+        }
+      };
+
+      authCore.onApiKeyLogin.mockRejectedValue(
+        new Error('Invalid credentials')
+      );
+
+      // Act
+      const result = await doAuth.execute({
+        connectorManifest: mockManifest,
+        connectorName: 'testCRM',
+        hostname: 'test.crm.com',
+        apiKey: 'bad-key'
+      });
+
+      // Assert
+      expect(result.success).toBe(false);
+      expect(result.error).toBe('Invalid credentials');
+      expect(result.errorDetails).toBeDefined();
+    });
+
+    test('should handle missing platform in manifest', async () => {
+      // Arrange
+      const mockManifest = {
+        platforms: {}
+      };
+
+      // Act
+      const result = await doAuth.execute({
+        connectorManifest: mockManifest,
+        connectorName: 'nonExistent',
+        apiKey: 'test-key'
+      });
+
+      // Assert
+      expect(result.success).toBe(false);
+      expect(result.error).toBeDefined();
+    });
+  });
+});
+

package/test/mcp/tools/findContactByName.test.js

@@ -0,0 +1,263 @@
+const findContactByName = require('../../../mcp/tools/findContactByName');
+const jwt = require('../../../lib/jwt');
+const connectorRegistry = require('../../../connector/registry');
+const contactCore = require('../../../handlers/contact');
+
+// Mock dependencies
+jest.mock('../../../lib/jwt');
+jest.mock('../../../connector/registry');
+jest.mock('../../../handlers/contact');
+
+describe('MCP Tool: findContactByName', () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  describe('tool definition', () => {
+    test('should have correct tool definition', () => {
+      expect(findContactByName.definition).toBeDefined();
+      expect(findContactByName.definition.name).toBe('findContactByName');
+      expect(findContactByName.definition.description).toContain('REQUIRES AUTHENTICATION');
+      expect(findContactByName.definition.inputSchema).toBeDefined();
+    });
+
+    test('should require jwtToken and name parameters', () => {
+      expect(findContactByName.definition.inputSchema.required).toContain('jwtToken');
+      expect(findContactByName.definition.inputSchema.required).toContain('name');
+    });
+  });
+
+  describe('execute', () => {
+    test('should find contact by name successfully', async () => {
+      // Arrange
+      const mockContact = {
+        id: 'contact-123',
+        name: 'John Doe',
+        phone: '+1234567890',
+        type: 'Contact'
+      };
+
+      jwt.decodeJwt.mockReturnValue({
+        id: 'user-123',
+        platform: 'testCRM'
+      });
+
+      const mockConnector = {
+        findContactWithName: jest.fn()
+      };
+      connectorRegistry.getConnector.mockReturnValue(mockConnector);
+
+      contactCore.findContactWithName.mockResolvedValue({
+        successful: true,
+        contact: mockContact,
+        returnMessage: { message: 'Contact found' }
+      });
+
+      // Act
+      const result = await findContactByName.execute({
+        jwtToken: 'mock-jwt-token',
+        name: 'John Doe'
+      });
+
+      // Assert
+      expect(result).toEqual({
+        success: true,
+        data: mockContact
+      });
+      expect(jwt.decodeJwt).toHaveBeenCalledWith('mock-jwt-token');
+      expect(connectorRegistry.getConnector).toHaveBeenCalledWith('testCRM');
+      expect(contactCore.findContactWithName).toHaveBeenCalledWith({
+        platform: 'testCRM',
+        userId: 'user-123',
+        name: 'John Doe'
+      });
+    });
+
+    test('should find contact with partial name', async () => {
+      // Arrange
+      const mockContact = {
+        id: 'contact-456',
+        name: 'Jane Smith',
+        phone: '+9876543210',
+        type: 'Contact'
+      };
+
+      jwt.decodeJwt.mockReturnValue({
+        id: 'user-123',
+        platform: 'testCRM'
+      });
+
+      const mockConnector = {
+        findContactWithName: jest.fn()
+      };
+      connectorRegistry.getConnector.mockReturnValue(mockConnector);
+
+      contactCore.findContactWithName.mockResolvedValue({
+        successful: true,
+        contact: mockContact
+      });
+
+      // Act
+      const result = await findContactByName.execute({
+        jwtToken: 'mock-jwt-token',
+        name: 'Jane'
+      });
+
+      // Assert
+      expect(result.success).toBe(true);
+      expect(result.data).toEqual(mockContact);
+      expect(contactCore.findContactWithName).toHaveBeenCalledWith({
+        platform: 'testCRM',
+        userId: 'user-123',
+        name: 'Jane'
+      });
+    });
+
+    test('should return error when contact not found', async () => {
+      // Arrange
+      jwt.decodeJwt.mockReturnValue({
+        id: 'user-123',
+        platform: 'testCRM'
+      });
+
+      const mockConnector = {
+        findContactWithName: jest.fn()
+      };
+      connectorRegistry.getConnector.mockReturnValue(mockConnector);
+
+      contactCore.findContactWithName.mockResolvedValue({
+        successful: false,
+        contact: null,
+        returnMessage: { message: 'Contact not found' }
+      });
+
+      // Act
+      const result = await findContactByName.execute({
+        jwtToken: 'mock-jwt-token',
+        name: 'NonExistent Person'
+      });
+
+      // Assert
+      expect(result).toEqual({
+        success: false,
+        error: 'Contact not found'
+      });
+    });
+
+    test('should return error when JWT is invalid', async () => {
+      // Arrange
+      jwt.decodeJwt.mockReturnValue({
+        platform: 'testCRM'
+        // id is missing
+      });
+
+      // Act
+      const result = await findContactByName.execute({
+        jwtToken: 'invalid-token',
+        name: 'John Doe'
+      });
+
+      // Assert
+      expect(result.success).toBe(false);
+      expect(result.error).toContain('Invalid JWT token');
+    });
+
+    test('should return error when platform connector not found', async () => {
+      // Arrange
+      jwt.decodeJwt.mockReturnValue({
+        id: 'user-123',
+        platform: 'unknownCRM'
+      });
+
+      connectorRegistry.getConnector.mockReturnValue(null);
+
+      // Act
+      const result = await findContactByName.execute({
+        jwtToken: 'mock-jwt-token',
+        name: 'John Doe'
+      });
+
+      // Assert
+      expect(result.success).toBe(false);
+      expect(result.error).toContain('Platform connector not found');
+    });
+
+    test('should return error when findContactWithName is not implemented', async () => {
+      // Arrange
+      jwt.decodeJwt.mockReturnValue({
+        id: 'user-123',
+        platform: 'testCRM'
+      });
+
+      const mockConnector = {}; // No findContactWithName method
+      connectorRegistry.getConnector.mockReturnValue(mockConnector);
+
+      // Act
+      const result = await findContactByName.execute({
+        jwtToken: 'mock-jwt-token',
+        name: 'John Doe'
+      });
+
+      // Assert
+      expect(result.success).toBe(false);
+      expect(result.error).toContain('not implemented');
+    });
+
+    test('should handle unexpected errors gracefully', async () => {
+      // Arrange
+      jwt.decodeJwt.mockReturnValue({
+        id: 'user-123',
+        platform: 'testCRM'
+      });
+
+      const mockConnector = {
+        findContactWithName: jest.fn()
+      };
+      connectorRegistry.getConnector.mockReturnValue(mockConnector);
+
+      contactCore.findContactWithName.mockRejectedValue(
+        new Error('API rate limit exceeded')
+      );
+
+      // Act
+      const result = await findContactByName.execute({
+        jwtToken: 'mock-jwt-token',
+        name: 'John Doe'
+      });
+
+      // Assert
+      expect(result.success).toBe(false);
+      expect(result.error).toBe('API rate limit exceeded');
+      expect(result.errorDetails).toBeDefined();
+    });
+
+    test('should handle empty name parameter', async () => {
+      // Arrange
+      jwt.decodeJwt.mockReturnValue({
+        id: 'user-123',
+        platform: 'testCRM'
+      });
+
+      const mockConnector = {
+        findContactWithName: jest.fn()
+      };
+      connectorRegistry.getConnector.mockReturnValue(mockConnector);
+
+      contactCore.findContactWithName.mockResolvedValue({
+        successful: false,
+        returnMessage: { message: 'Name parameter is required' }
+      });
+
+      // Act
+      const result = await findContactByName.execute({
+        jwtToken: 'mock-jwt-token',
+        name: ''
+      });
+
+      // Assert
+      expect(result.success).toBe(false);
+      expect(result.error).toBe('Name parameter is required');
+    });
+  });
+});
+