@apollo/rover 0.4.8 → 0.5.0-rc.0

package/README.md

@@ -37,7 +37,7 @@ rover graph publish --schema ./path-to-valid-schema test@cats
 ## Command-line options
 
 ```console
-Rover 0.4.7
+Rover 0.5.0-rc.0
 
 Rover - Your Graph Companion
 Read the getting started guide by running:
@@ -66,18 +66,37 @@ USAGE:
     rover [FLAGS] [OPTIONS] <SUBCOMMAND>
 
 FLAGS:
-        --insecure-accept-invalid-certs        Accept invalid certificates when performing HTTPS requests
-        --insecure-accept-invalid-hostnames    Accept invalid hostnames when performing HTTPS requests
-    -h, --help                                 Prints help information
-    -V, --version                              Prints version information
+        --insecure-accept-invalid-certs        
+            Accept invalid certificates when performing HTTPS requests.
+            
+            You should think very carefully before using this flag.
+            
+            If invalid certificates are trusted, any certificate for any site will be trusted for use. This includes
+            expired certificates. This introduces significant vulnerabilities, and should only be used as a last resort.
+        --insecure-accept-invalid-hostnames    
+            Accept invalid hostnames when performing HTTPS requests.
+            
+            You should think very carefully before using this flag.
+            
+            If hostname verification is not used, any valid certificate for any site will be trusted for use from any
+            other. This introduces a significant vulnerability to man-in-the-middle attacks.
+    -h, --help                                 
+            Prints help information
+
+    -V, --version                              
+            Prints version information
+
 
 OPTIONS:
-        --client-timeout <client-timeout>    Configure the timeout length (in seconds) when performing HTTP(S) requests
-                                             [default: 30]
-    -l, --log <log-level>                    Specify Rover's log level [possible values: error, warn,
-                                             info, debug, trace]
-        --output <output-type>               Specify Rover's output type [default: plain]  [possible values:
-                                             json, plain]
+        --client-timeout <client-timeout>    
+            Configure the timeout length (in seconds) when performing HTTP(S) requests [default: 30]
+
+    -l, --log <log-level>                    
+            Specify Rover's log level [possible values: error, warn, info, debug,
+            trace]
+        --output <output-type>               
+            Specify Rover's output type [default: plain]  [possible values: json, plain]
+
 
 SUBCOMMANDS:
     config        Configuration profile commands
@@ -123,7 +142,7 @@ To install a specific version of Rover (note the `v` prefixing the version numbe
 > Note: If you're installing Rover in a CI environment, it's best to target a specific version rather than using the latest URL, since future major breaking changes could affect CI workflows otherwise.
 
 ```bash
-curl -sSL https://rover.apollo.dev/nix/v0.4.8 | sh
+curl -sSL https://rover.apollo.dev/nix/v0.5.0-rc.0 | sh
 ```
 
 You will need `curl` installed on your system to run the above installation commands. You can get the latest version from [the curl downloads page](https://curl.se/download.html).
@@ -141,7 +160,7 @@ To install a specific version of Rover (note the `v` prefixing the version numbe
 > Note: If you're installing Rover in a CI environment, it's best to target a specific version rather than using the latest URL, since future major breaking changes could affect CI workflows otherwise.
 
 ```bash
-iwr 'https://rover.apollo.dev/win/v0.4.8' | iex
+iwr 'https://rover.apollo.dev/win/v0.5.0-rc.0' | iex
 ```
 
 #### npm installer

package/binary.js

@@ -2,6 +2,8 @@ const { Binary } = require("binary-install");
 const os = require("os");
 const cTable = require("console.table");
 const libc = require("detect-libc");
+const { join } = require("path");
+const { spawnSync } = require("child_process");
 
 const error = (msg) => {
   console.error(msg);
@@ -9,7 +11,6 @@ const error = (msg) => {
 };
 
 const { version } = require("./package.json");
-const repository = "https://github.com/apollographql/rover";
 const name = "rover";
 
 const supportedPlatforms = [
@@ -49,9 +50,12 @@ const getPlatform = () => {
       architecture === supportedPlatform.ARCHITECTURE
     ) {
       if (supportedPlatform.TYPE === "Linux") {
-        let musl_warning = "Downloading musl binary that does not include `rover supergraph compose`.";
+        let musl_warning =
+          "Downloading musl binary that does not include `rover supergraph compose`.";
         if (libc.isNonGlibcLinuxSync()) {
-          console.warn("This operating system does not support dynamic linking to glibc.");
+          console.warn(
+            "This operating system does not support dynamic linking to glibc."
+          );
           console.warn(musl_warning);
           supportedPlatform.RUST_TARGET = "x86_64-unknown-linux-musl";
         } else {
@@ -61,8 +65,13 @@ const getPlatform = () => {
           let libc_minor_version = split_libc_version[1];
           let min_major_version = 2;
           let min_minor_version = 17;
-          if (libc_major_version < min_major_version || libc_minor_version < min_minor_version) {
-            console.warn(`This operating system needs glibc >= ${min_major_version}.${min_minor_version}, but only has ${libc_version} installed.`);
+          if (
+            libc_major_version < min_major_version ||
+            libc_minor_version < min_minor_version
+          ) {
+            console.warn(
+              `This operating system needs glibc >= ${min_major_version}.${min_minor_version}, but only has ${libc_version} installed.`
+            );
             console.warn(musl_warning);
             supportedPlatform.RUST_TARGET = "x86_64-unknown-linux-musl";
           }
@@ -82,9 +91,17 @@ const getPlatform = () => {
 const getBinary = () => {
   const platform = getPlatform();
   // the url for this binary is constructed from values in `package.json`
-  // https://github.com/apollographql/rover/releases/download/v1.0.0/binary-install-example-v1.0.0-x86_64-apple-darwin.tar.gz
-  const url = `${repository}/releases/download/v${version}/${name}-v${version}-${platform.RUST_TARGET}.tar.gz`;
-  return new Binary(platform.BINARY_NAME, url);
+  // https://rover.apollo.dev/tar/rover/x86_64-unknown-linux-gnu/v0.4.8
+  const url = `https://rover.apollo.dev/tar/${name}/${platform.RUST_TARGET}/v${version}`;
+  let binary = new Binary(platform.BINARY_NAME, url);
+
+  // binary-install doesn't put the binary in the right place, so just patch it.
+  binary.installDirectory = join(__dirname, "node_modules", ".bin");
+  binary.binaryPath = join(binary.installDirectory, binary.name);
+  // setting this allows us to extract supergraph plugins to the proper directory
+  // the variable itself is read in Rust code
+  process.env.APOLLO_NODE_MODULES_BIN_DIR = binary.installDirectory;
+  return binary;
 };
 
 const run = () => {
@@ -94,10 +111,33 @@ const run = () => {
 
 const install = () => {
   const binary = getBinary();
-  binary.install();
+  // binary.install();
+  let pluginInstallCommand = `${binary.binaryPath} install --plugin`;
+  let commands = [
+    `${pluginInstallCommand} supergraph@latest-0`,
+    `${pluginInstallCommand} supergraph@latest-2`,
+  ];
+  for (command of commands) {
+    try {
+      spawnSync(command, {
+        stdio: "inherit",
+        shell: true,
+      });
+    } catch (e) {
+      console.error(
+        `'${command.replace(
+          binary.binaryPath,
+          binary.name
+        )}' failed with message '${
+          e.message
+        }'. 'rover supergraph compose' might not work properly on your machine.`
+      );
+    }
+  }
 };
 
 module.exports = {
   install,
   run,
+  getBinary,
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@apollo/rover",
-  "version": "0.4.8",
+  "version": "0.5.0-rc.0",
   "description": "The new Apollo CLI",
   "main": "index.js",
   "bin": {
@@ -33,7 +33,7 @@
   },
   "volta": {
     "node": "17.5.0",
-    "npm": "8.5.0"
+    "npm": "8.5.4"
   },
   "homepage": "https://github.com/apollographql/rover#readme",
   "dependencies": {
@@ -42,6 +42,6 @@
     "detect-libc": "^2.0.0"
   },
   "devDependencies": {
-    "prettier": "2.5.1"
+    "prettier": "2.6.0"
   }
 }