@apollo/gateway 0.43.1 → 2.0.0-alpha.1

package/src/__tests__/executeQueryPlan.test.ts

@@ -2,12 +2,11 @@ import {
   buildClientSchema,
   getIntrospectionQuery,
   GraphQLObjectType,
-  GraphQLSchema,
   print,
 } from 'graphql';
 import { addResolversToSchema, GraphQLResolverMap } from 'apollo-graphql';
 import gql from 'graphql-tag';
-import { GraphQLRequestContext, VariableValues } from 'apollo-server-types';
+import { GraphQLExecutionResult, GraphQLRequestContext } from 'apollo-server-types';
 import { AuthenticationError } from 'apollo-server-core';
 import { buildOperationContext } from '../operationContext';
 import { executeQueryPlan } from '../executeQueryPlan';
@@ -17,15 +16,54 @@ import {
   queryPlanSerializer,
   superGraphWithInaccessible,
 } from 'apollo-federation-integration-testsuite';
-import { buildComposedSchema, QueryPlanner } from '@apollo/query-planner';
+import { QueryPlan, QueryPlanner } from '@apollo/query-planner';
 import { ApolloGateway } from '..';
 import { ApolloServerBase as ApolloServer } from 'apollo-server-core';
 import { getFederatedTestingSchema } from './execution-utils';
+import { Schema, Operation, parseOperation, buildSchemaFromAST } from '@apollo/federation-internals';
 
 expect.addSnapshotSerializer(astSerializer);
 expect.addSnapshotSerializer(queryPlanSerializer);
 
 describe('executeQueryPlan', () => {
+  let serviceMap: {
+    [serviceName: string]: LocalGraphQLDataSource;
+  };
+
+  let parseOp = (operation: string, operationSchema?: Schema): Operation => {
+    return parseOperation((operationSchema ?? schema), operation);
+  }
+
+  let buildPlan = (operation: string | Operation, operationQueryPlanner?: QueryPlanner, operationSchema?: Schema): QueryPlan => {
+    const op = typeof operation === 'string' ? parseOp(operation, operationSchema): operation;
+    return (operationQueryPlanner ?? queryPlanner).buildQueryPlan(op);
+  }
+
+  async function executePlan(
+    queryPlan: QueryPlan,
+    operation: Operation,
+    executeRequestContext?: GraphQLRequestContext,
+    executeSchema?: Schema,
+    executeServiceMap?: { [serviceName: string]: LocalGraphQLDataSource }
+  ): Promise<GraphQLExecutionResult> {
+    const operationContext = buildOperationContext({
+      schema: (executeSchema ?? schema).toAPISchema().toGraphQLJSSchema(),
+      operationDocument: gql`${operation.toString()}`,
+    });
+    return executeQueryPlan(
+      queryPlan,
+      executeServiceMap ?? serviceMap,
+      executeRequestContext ?? buildRequestContext(),
+      operationContext,
+    );
+  }
+
+  async function executeOperation(operationString: string, requestContext?: GraphQLRequestContext): Promise<GraphQLExecutionResult> {
+      const operation = parseOp(operationString);
+      const queryPlan = buildPlan(operation);
+      return executePlan(queryPlan, operation, requestContext);
+  }
+
   function overrideResolversInService(
     serviceName: string,
     resolvers: GraphQLResolverMap,
@@ -40,10 +78,7 @@ describe('executeQueryPlan', () => {
     return jest.spyOn(entitiesField, 'resolve');
   }
 
-  let serviceMap: {
-    [serviceName: string]: LocalGraphQLDataSource;
-  };
-  let schema: GraphQLSchema;
+  let schema: Schema;
   let queryPlanner: QueryPlanner;
   beforeEach(() => {
     expect(
@@ -52,15 +87,13 @@ describe('executeQueryPlan', () => {
     ).not.toThrow();
   });
 
-  function buildRequestContext(
-    variables: VariableValues = {},
-  ): GraphQLRequestContext {
+  function buildRequestContext(): GraphQLRequestContext {
     // @ts-ignore
     return {
       cache: undefined as any,
       context: {},
       request: {
-        variables,
+        variables: {},
       },
     };
   }
@@ -78,21 +111,7 @@ describe('executeQueryPlan', () => {
         }
       `;
 
-      const operationDocument = gql(operationString);
-
-      const operationContext = buildOperationContext({
-        schema,
-        operationDocument,
-      });
-
-      const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-      const response = await executeQueryPlan(
-        queryPlan,
-        serviceMap,
-        buildRequestContext(),
-        operationContext,
-      );
+      const response = await executeOperation(operationString);
 
       expect(response).not.toHaveProperty('errors');
     });
@@ -117,21 +136,7 @@ describe('executeQueryPlan', () => {
         }
       `;
 
-      const operationDocument = gql(operationString);
-
-      const operationContext = buildOperationContext({
-        schema,
-        operationDocument,
-      });
-
-      const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-      const response = await executeQueryPlan(
-        queryPlan,
-        serviceMap,
-        buildRequestContext(),
-        operationContext,
-      );
+      const response = await executeOperation(operationString);
 
       expect(response).toHaveProperty('data.me', null);
       expect(response).toHaveProperty(
@@ -176,21 +181,7 @@ describe('executeQueryPlan', () => {
         }
       `;
 
-      const operationDocument = gql(operationString);
-
-      const operationContext = buildOperationContext({
-        schema,
-        operationDocument,
-      });
-
-      const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-      const response = await executeQueryPlan(
-        queryPlan,
-        serviceMap,
-        buildRequestContext(),
-        operationContext,
-      );
+      const response = await executeOperation(operationString);
 
       expect(accountsEntitiesResolverSpy).not.toHaveBeenCalled();
 
@@ -253,21 +244,7 @@ describe('executeQueryPlan', () => {
         }
       `;
 
-      const operationDocument = gql(operationString);
-
-      const operationContext = buildOperationContext({
-        schema,
-        operationDocument,
-      });
-
-      const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-      const response = await executeQueryPlan(
-        queryPlan,
-        serviceMap,
-        buildRequestContext(),
-        operationContext,
-      );
+      const response = await executeOperation(operationString);
 
       expect(accountsEntitiesResolverSpy).toHaveBeenCalledTimes(1);
       expect(accountsEntitiesResolverSpy.mock.calls[0][1]).toEqual({
@@ -354,21 +331,7 @@ describe('executeQueryPlan', () => {
         }
       `;
 
-      const operationDocument = gql(operationString);
-
-      const operationContext = buildOperationContext({
-        schema,
-        operationDocument,
-      });
-
-      const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-      const response = await executeQueryPlan(
-        queryPlan,
-        serviceMap,
-        buildRequestContext(),
-        operationContext,
-      );
+      const response = await executeOperation(operationString);
 
       expect(reviewsEntitiesResolverSpy).not.toHaveBeenCalled();
 
@@ -402,21 +365,7 @@ describe('executeQueryPlan', () => {
         }
       `;
 
-      const operationDocument = gql(operationString);
-
-      const operationContext = buildOperationContext({
-        schema,
-        operationDocument,
-      });
-
-      const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-      const response = await executeQueryPlan(
-        queryPlan,
-        serviceMap,
-        buildRequestContext(),
-        operationContext,
-      );
+      const response = await executeOperation(operationString);
 
       expect(reviewsEntitiesResolverSpy).toHaveBeenCalledTimes(1);
       expect(reviewsEntitiesResolverSpy.mock.calls[0][1]).toEqual({
@@ -476,21 +425,7 @@ describe('executeQueryPlan', () => {
         }
       `;
 
-      const operationDocument = gql(operationString);
-
-      const operationContext = buildOperationContext({
-        schema,
-        operationDocument,
-      });
-
-      const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-      const response = await executeQueryPlan(
-        queryPlan,
-        serviceMap,
-        buildRequestContext(),
-        operationContext,
-      );
+      const response = await executeOperation(operationString);
 
       expect(response).toHaveProperty('data.me', null);
       expect(response).toHaveProperty('data.topReviews', expect.any(Array));
@@ -513,21 +448,7 @@ describe('executeQueryPlan', () => {
         }
       `;
 
-      const operationDocument = gql(operationString);
-
-      const operationContext = buildOperationContext({
-        schema,
-        operationDocument,
-      });
-
-      const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-      const response = await executeQueryPlan(
-        queryPlan,
-        serviceMap,
-        buildRequestContext(),
-        operationContext,
-      );
+      const response = await executeOperation(operationString);
 
       expect(response).toHaveProperty('data.me', null);
       expect(response).toHaveProperty('data.topReviews', expect.any(Array));
@@ -549,21 +470,7 @@ describe('executeQueryPlan', () => {
       }
     `;
 
-    const operationDocument = gql(operationString);
-
-    const operationContext = buildOperationContext({
-      schema,
-      operationDocument,
-    });
-
-    const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-    const response = await executeQueryPlan(
-      queryPlan,
-      serviceMap,
-      buildRequestContext(),
-      operationContext,
-    );
+    const response = await executeOperation(operationString);
 
     expect(response.data).toMatchInlineSnapshot(`
       Object {
@@ -642,24 +549,9 @@ describe('executeQueryPlan', () => {
       }
     `;
 
-    const operationDocument = gql(operationString);
-
-    const operationContext = buildOperationContext({
-      schema,
-      operationDocument,
-    });
-
-    const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
     const requestContext = buildRequestContext();
     requestContext.request.variables = { first: 3 };
-
-    const response = await executeQueryPlan(
-      queryPlan,
-      serviceMap,
-      requestContext,
-      operationContext,
-    );
+    const response = await executeOperation(operationString, requestContext);
 
     expect(response.data).toMatchInlineSnapshot(`
       Object {
@@ -741,24 +633,9 @@ describe('executeQueryPlan', () => {
       }
     `;
 
-    const operationDocument = gql(operationString);
-
-    const operationContext = buildOperationContext({
-      schema,
-      operationDocument,
-    });
-
-    const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
     const requestContext = buildRequestContext();
     requestContext.request.variables = { locale: 'en-US' };
-
-    const response = await executeQueryPlan(
-      queryPlan,
-      serviceMap,
-      requestContext,
-      operationContext,
-    );
+    const response = await executeOperation(operationString, requestContext);
 
     expect(response.data).toMatchInlineSnapshot(`
       Object {
@@ -819,20 +696,7 @@ describe('executeQueryPlan', () => {
   });
 
   it('can execute an introspection query', async () => {
-    const operationContext = buildOperationContext({
-      schema,
-      operationDocument: gql`
-        ${getIntrospectionQuery()}
-      `,
-    });
-    const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-    const response = await executeQueryPlan(
-      queryPlan,
-      serviceMap,
-      buildRequestContext(),
-      operationContext,
-    );
+    const response = await executeOperation(`${getIntrospectionQuery()}`);
 
     expect(response.data).toHaveProperty('__schema');
     expect(response.errors).toBeUndefined();
@@ -849,21 +713,7 @@ describe('executeQueryPlan', () => {
       }
     `;
 
-    const operationDocument = gql(operationString);
-
-    const operationContext = buildOperationContext({
-      schema,
-      operationDocument,
-    });
-
-    const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-    const response = await executeQueryPlan(
-      queryPlan,
-      serviceMap,
-      buildRequestContext(),
-      operationContext,
-    );
+    const response = await executeOperation(operationString);
 
     expect(response.data).toMatchInlineSnapshot(`
       Object {
@@ -893,21 +743,7 @@ describe('executeQueryPlan', () => {
       }
     `;
 
-    const operationDocument = gql(operationString);
-
-    const operationContext = buildOperationContext({
-      schema,
-      operationDocument,
-    });
-
-    const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-    const response = await executeQueryPlan(
-      queryPlan,
-      serviceMap,
-      buildRequestContext(),
-      operationContext,
-    );
+    const response = await executeOperation(operationString);
 
     expect(response.data).toMatchInlineSnapshot(`
       Object {
@@ -948,21 +784,7 @@ describe('executeQueryPlan', () => {
       }
     `;
 
-    const operationDocument = gql(operationString);
-
-    const operationContext = buildOperationContext({
-      schema,
-      operationDocument,
-    });
-
-    const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-    const response = await executeQueryPlan(
-      queryPlan,
-      serviceMap,
-      buildRequestContext(),
-      operationContext,
-    );
+    const response = await executeOperation(operationString);
 
     expect(response.data).toMatchInlineSnapshot(`
       Object {
@@ -990,21 +812,7 @@ describe('executeQueryPlan', () => {
       }
     `;
 
-    const operationDocument = gql(operationString);
-
-    const operationContext = buildOperationContext({
-      schema,
-      operationDocument,
-    });
-
-    const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-    const response = await executeQueryPlan(
-      queryPlan,
-      serviceMap,
-      buildRequestContext(),
-      operationContext,
-    );
+    const response = await executeOperation(operationString);
 
     expect(response.data).toMatchInlineSnapshot(`
       Object {
@@ -1045,21 +853,7 @@ describe('executeQueryPlan', () => {
       }
     `;
 
-    const operationDocument = gql(operationString);
-
-    const operationContext = buildOperationContext({
-      schema,
-      operationDocument,
-    });
-
-    const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-    const response = await executeQueryPlan(
-      queryPlan,
-      serviceMap,
-      buildRequestContext(),
-      operationContext,
-    );
+    const response = await executeOperation(operationString);
 
     expect(response.errors).toMatchInlineSnapshot(`undefined`);
 
@@ -1094,21 +888,7 @@ describe('executeQueryPlan', () => {
       }
     `;
 
-    const operationDocument = gql(operationString);
-
-    const operationContext = buildOperationContext({
-      schema,
-      operationDocument,
-    });
-
-    const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-    const response = await executeQueryPlan(
-      queryPlan,
-      serviceMap,
-      buildRequestContext(),
-      operationContext,
-    );
+    const response = await executeOperation(operationString);
 
     expect(response.errors).toBeUndefined();
 
@@ -1137,21 +917,7 @@ describe('executeQueryPlan', () => {
       }
     `;
 
-    const operationDocument = gql(operationString);
-
-    const operationContext = buildOperationContext({
-      schema,
-      operationDocument,
-    });
-
-    const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-    const response = await executeQueryPlan(
-      queryPlan,
-      serviceMap,
-      buildRequestContext(),
-      operationContext,
-    );
+    const response = await executeOperation(operationString);
 
     expect(response.data).toMatchInlineSnapshot(`
       Object {
@@ -1183,23 +949,12 @@ describe('executeQueryPlan', () => {
 
   describe('@inaccessible', () => {
     it(`should not include @inaccessible fields in introspection`, async () => {
-      schema = buildComposedSchema(superGraphWithInaccessible);
-      queryPlanner = new QueryPlanner(schema);
+      schema = buildSchemaFromAST(superGraphWithInaccessible);
 
-      const operationContext = buildOperationContext({
-        schema,
-        operationDocument: gql`
-          ${getIntrospectionQuery()}
-        `,
-      });
-      const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-      const response = await executeQueryPlan(
-        queryPlan,
-        serviceMap,
-        buildRequestContext(),
-        operationContext,
-      );
+      const operation = parseOp(`${getIntrospectionQuery()}`, schema);
+      queryPlanner = new QueryPlanner(schema);
+      const queryPlan = queryPlanner.buildQueryPlan(operation);
+      const response = await executePlan(queryPlan, operation, undefined, schema);
 
       expect(response.data).toHaveProperty('__schema');
       expect(response.errors).toBeUndefined();
@@ -1225,24 +980,14 @@ describe('executeQueryPlan', () => {
         }
       `;
 
-      const operationDocument = gql(operationString);
-
-      schema = buildComposedSchema(superGraphWithInaccessible);
+      const operation = parseOp(operationString);
 
-      const operationContext = buildOperationContext({
-        schema,
-        operationDocument,
-      });
+      schema = buildSchemaFromAST(superGraphWithInaccessible);
 
       queryPlanner = new QueryPlanner(schema);
-      const queryPlan = queryPlanner.buildQueryPlan(operationContext);
+      const queryPlan = queryPlanner.buildQueryPlan(operation);
 
-      const response = await executeQueryPlan(
-        queryPlan,
-        serviceMap,
-        buildRequestContext(),
-        operationContext,
-      );
+      const response = await executePlan(queryPlan, operation, undefined, schema);
 
       expect(response.data).toMatchInlineSnapshot(`
         Object {
@@ -1349,26 +1094,16 @@ describe('executeQueryPlan', () => {
         }
       `;
 
-      const operationDocument = gql(operationString);
+      const operation = parseOp(operationString);
 
       // Vehicle ID #1 is a "Car" type.
       // This supergraph marks the "Car" type as inaccessible.
-      schema = buildComposedSchema(superGraphWithInaccessible);
-
-      const operationContext = buildOperationContext({
-        schema,
-        operationDocument,
-      });
+      schema = buildSchemaFromAST(superGraphWithInaccessible);
 
       queryPlanner = new QueryPlanner(schema);
-      const queryPlan = queryPlanner.buildQueryPlan(operationContext);
+      const queryPlan = queryPlanner.buildQueryPlan(operation);
 
-      const response = await executeQueryPlan(
-        queryPlan,
-        serviceMap,
-        buildRequestContext(),
-        operationContext,
-      );
+      const response = await executePlan(queryPlan, operation, undefined, schema);
 
       expect(response.data?.vehicle).toEqual(null);
       expect(response.errors).toBeUndefined();
@@ -1381,259 +1116,530 @@ describe('executeQueryPlan', () => {
     });
   });
 
-  describe('top-level @skip / @include usages', () => {
-    it(`top-level skip never calls reviews service (using literals)`, async () => {
-      const operationDocument = gql`
-        query {
-          topReviews @skip(if: true) {
-            body
-          }
-        }
-      `;
+  it('can query other subgraphs when the Query type is the type of a field', async () => {
+    const s1 = gql`
+      type Query {
+        getA: A
+      }
 
-      const operationContext = buildOperationContext({
-        schema,
-        operationDocument,
-      });
+      type A {
+        q: Query
+      }
+    `;
 
-      const queryPlan = queryPlanner.buildQueryPlan(operationContext);
+    const s2 = gql`
+      type Query {
+        one: Int
+      }
+    `;
 
-      const response = await executeQueryPlan(
-        queryPlan,
-        serviceMap,
-        buildRequestContext(),
-        operationContext,
-      );
+    const { serviceMap, schema, queryPlanner} = getFederatedTestingSchema([
+      { name: 'S1', typeDefs: s1 },
+      { name: 'S2', typeDefs: s2 }
+    ]);
+
+    addResolversToSchema(serviceMap['S1'].schema, {
+      Query: {
+        getA() {
+          return {
+            getA: {
+              q: null
+            }
+          };
+        },
+      },
+      A: {
+        q() {
+          return Object.create(null);
+        }
+      }
+    });
 
-      expect(response.data).toMatchInlineSnapshot(`Object {}`);
-      expect(queryPlan).not.toCallService('reviews');
+    addResolversToSchema(serviceMap['S2'].schema, {
+      Query: {
+        one() {
+          return 1;
+        },
+      },
     });
 
-    it(`top-level skip never calls reviews service (using variables)`, async () => {
-      const operationDocument = gql`
-        query TopReviews($shouldSkip: Boolean!) {
-          topReviews @skip(if: $shouldSkip) {
-            body
+    const operation = parseOp(`
+      query {
+        getA {
+          q {
+            one
           }
         }
-      `;
+      }
+      `, schema);
 
-      const operationContext = buildOperationContext({
-        schema,
-        operationDocument,
-      });
+    const queryPlan = buildPlan(operation, queryPlanner);
 
-      const queryPlan = queryPlanner.buildQueryPlan(operationContext);
+    expect(queryPlan).toMatchInlineSnapshot(`
+      QueryPlan {
+        Sequence {
+          Fetch(service: "S1") {
+            {
+              getA {
+                q {
+                  __typename
+                }
+              }
+            }
+          },
+          Flatten(path: "getA.q") {
+            Fetch(service: "S2") {
+              {
+                ... on Query {
+                  one
+                }
+              }
+            },
+          },
+        },
+      }
+    `);
 
-      const variables = { shouldSkip: true };
-      const response = await executeQueryPlan(
-        queryPlan,
-        serviceMap,
-        buildRequestContext(variables),
-        operationContext,
-      );
+    const response = await executePlan(queryPlan, operation, undefined, schema, serviceMap);
 
-      expect(response.data).toMatchInlineSnapshot(`Object {}`);
-      expect({ queryPlan, variables }).not.toCallService('reviews');
-    });
+    expect(response.data).toMatchInlineSnapshot(`
+      Object {
+        "getA": Object {
+          "q": Object {
+            "one": 1,
+          },
+        },
+      }
+      `);
+  })
 
-    it(`call to service isn't skipped unless all top-level fields are skipped`, async () => {
-      const operationDocument = gql`
-        query {
-          user(id: "1") @skip(if: true) {
-            username
-          }
-          me @include(if: true) {
-            username
-          }
+  describe('interfaces on interfaces', () => {
+    it('can execute queries on an interface only implemented by other interfaces', async () => {
+      const s1 = gql`
+        type Query {
+          allValues: [TopInterface!]!
+        }
+
+        interface TopInterface {
+          a: Int
+        }
+
+        interface SubInterface1 implements TopInterface {
+          a: Int
+          b: String
+        }
+
+        interface SubInterface2 implements TopInterface {
+          a: Int
+          c: String
+        }
+
+        type T1 implements SubInterface1 & TopInterface {
+          a: Int
+          b: String
+        }
+
+        type T2 implements SubInterface1 & TopInterface @key(fields: "b") {
+          a: Int @external
+          b: String
+        }
+
+        type T3 implements SubInterface2 & TopInterface {
+          a: Int
+          c: String
+        }
+
+        type T4 implements SubInterface1 & SubInterface2 & TopInterface @key(fields: "a") {
+          a: Int
+          b: String @external
+          c: String @external
         }
       `;
 
-      const operationContext = buildOperationContext({
-        schema,
-        operationDocument,
-      });
+      const s2 = gql`
+        type T2 @key(fields: "b") {
+          a: Int
+          b: String
+        }
 
-      const queryPlan = queryPlanner.buildQueryPlan(operationContext);
+        type T4 @key(fields: "a") {
+          a: Int
+          b: String
+          c: String
+        }
+      `;
 
-      const response = await executeQueryPlan(
-        queryPlan,
-        serviceMap,
-        buildRequestContext(),
-        operationContext,
-      );
+      const { serviceMap, schema, queryPlanner} = getFederatedTestingSchema([
+        { name: 'S1', typeDefs: s1 },
+        { name: 'S2', typeDefs: s2 }
+      ]);
+
+      const t1s_s1: any[] = [{ __typename: 'T1', a: 1, b: 'T1_v1'}, {__typename: 'T1', a: 2, b: 'T1_v2'}];
+      const t2s_s1: any[] = [{__typename: 'T2', b: 'k1'}, {__typename: 'T2', b: 'k2'}];
+      const t3s_s1: any[] = [{__typename: 'T3', a: 42, c: 'T3_v1'}];
+      const t4s_s1: any[] = [{__typename: 'T4', a: 0}, {__typename: 'T4', a: 10}, {__typename: 'T4', a: 20}];
+
+      const t2s_s2 = new Map<string, {a: number, b: string}>();
+      t2s_s2.set('k1', {a: 12 , b: 'k1'});
+      t2s_s2.set('k2', {a: 24 , b: 'k2'});
+
+      const t4s_s2 = new Map<number, {a: number, b: string, c: string}>();
+      t4s_s2.set(0, {a: 0, b: 'b_0', c: 'c_0'});
+      t4s_s2.set(10, {a: 10, b: 'b_10', c: 'c_10'});
+      t4s_s2.set(20, {a: 20, b: 'b_20', c: 'c_20'});
+
+      addResolversToSchema(serviceMap['S1'].schema, {
+        Query: {
+          allValues() {
+            return t1s_s1.concat(t2s_s1).concat(t3s_s1).concat(t4s_s1);
+          },
+        },
+      });
 
-      expect(response.data).toMatchObject({
-        me: {
-          username: '@ada',
+      addResolversToSchema(serviceMap['S2'].schema, {
+        T2: {
+          __resolveReference(ref) {
+            return t2s_s2.get(ref.b);
+          }
+        },
+        T4: {
+          __resolveReference(ref) {
+            return t4s_s2.get(ref.a);
+          }
         },
       });
-      expect(queryPlan).toCallService('accounts');
-    });
 
-    it(`call to service is skipped when all top-level fields are skipped`, async () => {
-      const operationDocument = gql`
+      let operation = parseOp(`
         query {
-          user(id: "1") @skip(if: true) {
-            username
-          }
-          me @include(if: false) {
-            username
+          allValues {
+            a
+            ... on SubInterface1 {
+              b
+            }
+            ... on SubInterface2 {
+              c
+            }
           }
         }
-      `;
+        `, schema);
 
-      const operationContext = buildOperationContext({
-        schema,
-        operationDocument,
-      });
+      let queryPlan = buildPlan(operation, queryPlanner);
 
-      const queryPlan = queryPlanner.buildQueryPlan(operationContext);
+      expect(queryPlan).toMatchInlineSnapshot(`
+        QueryPlan {
+          Sequence {
+            Fetch(service: "S1") {
+              {
+                allValues {
+                  __typename
+                  ... on T1 {
+                    a
+                    b
+                  }
+                  ... on T2 {
+                    __typename
+                    b
+                  }
+                  ... on T3 {
+                    a
+                    c
+                  }
+                  ... on T4 {
+                    __typename
+                    a
+                  }
+                }
+              }
+            },
+            Flatten(path: "allValues.@") {
+              Fetch(service: "S2") {
+                {
+                  ... on T2 {
+                    __typename
+                    b
+                  }
+                  ... on T4 {
+                    __typename
+                    a
+                  }
+                } =>
+                {
+                  ... on T2 {
+                    a
+                  }
+                  ... on T4 {
+                    b
+                    c
+                  }
+                }
+              },
+            },
+          },
+        }
+      `);
 
-      const response = await executeQueryPlan(
-        queryPlan,
-        serviceMap,
-        buildRequestContext(),
-        operationContext,
-      );
+      let response = await executePlan(queryPlan, operation, undefined, schema, serviceMap);
 
-      expect(response.data).toMatchObject({});
-      expect(queryPlan).not.toCallService('accounts');
+      expect(response.data).toMatchInlineSnapshot(`
+        Object {
+          "allValues": Array [
+            Object {
+              "a": 1,
+              "b": "T1_v1",
+            },
+            Object {
+              "a": 2,
+              "b": "T1_v2",
+            },
+            Object {
+              "a": 12,
+              "b": "k1",
+            },
+            Object {
+              "a": 24,
+              "b": "k2",
+            },
+            Object {
+              "a": 42,
+              "c": "T3_v1",
+            },
+            Object {
+              "a": 0,
+              "b": "b_0",
+              "c": "c_0",
+            },
+            Object {
+              "a": 10,
+              "b": "b_10",
+              "c": "c_10",
+            },
+            Object {
+              "a": 20,
+              "b": "b_20",
+              "c": "c_20",
+            },
+          ],
+        }
+        `);
     });
 
-    describe('@skip and @include combinations', () => {
-      it(`include: false, skip: false`, async () => {
-        const operationDocument = gql`
-          query TopReviews($shouldInclude: Boolean!, $shouldSkip: Boolean!) {
-            topReviews @include(if: $shouldInclude) @skip(if: $shouldSkip) {
-              body
-            }
-          }
-        `;
+    it('does not type explode when it does not need to', async () => {
+      // Fairly similar example than the previous one, but ensure field `a` don't need
+      // type explosion and unsure it isn't type-exploded.
+      const s1 = gql`
+        type Query {
+          allValues: [TopInterface!]!
+        }
 
-        const operationContext = buildOperationContext({
-          schema,
-          operationDocument,
-        });
+        interface TopInterface {
+          a: Int
+        }
 
-        const queryPlan = queryPlanner.buildQueryPlan(operationContext);
+        interface SubInterface1 implements TopInterface {
+          a: Int
+          b: String
+        }
 
-        const variables = { shouldInclude: false, shouldSkip: false };
-        const response = await executeQueryPlan(
-          queryPlan,
-          serviceMap,
-          buildRequestContext(variables),
-          operationContext,
-        );
+        interface SubInterface2 implements TopInterface {
+          a: Int
+          c: String
+        }
 
-        expect(response.data).toMatchObject({});
-        expect({ queryPlan, variables }).not.toCallService('reviews');
-      });
+        type T1 implements SubInterface1 & TopInterface {
+          a: Int
+          b: String
+        }
 
-      it(`include: false, skip: true`, async () => {
-        const operationDocument = gql`
-          query TopReviews($shouldInclude: Boolean!, $shouldSkip: Boolean!) {
-            topReviews @include(if: $shouldInclude) @skip(if: $shouldSkip) {
-              body
-            }
-          }
-        `;
+        type T2 implements SubInterface1 & TopInterface @key(fields: "a") {
+          a: Int
+          b: String @external
+        }
 
-        const operationContext = buildOperationContext({
-          schema,
-          operationDocument,
-        });
+        type T3 implements SubInterface2 & TopInterface {
+          a: Int
+          c: String
+        }
 
-        const queryPlan = queryPlanner.buildQueryPlan(operationContext);
+        type T4 implements SubInterface1 & SubInterface2 & TopInterface @key(fields: "a") {
+          a: Int
+          b: String @external
+          c: String @external
+        }
+      `;
 
-        const variables = { shouldInclude: false, shouldSkip: true };
-        const response = await executeQueryPlan(
-          queryPlan,
-          serviceMap,
-          buildRequestContext(variables),
-          operationContext,
-        );
+      const s2 = gql`
+        type T2 @key(fields: "a") {
+          a: Int
+          b: String
+        }
 
-        expect(response.data).toMatchObject({});
-        expect({ queryPlan, variables }).not.toCallService('reviews');
+        type T4 @key(fields: "a") {
+          a: Int
+          b: String
+          c: String
+        }
+      `;
+
+      const { serviceMap, schema, queryPlanner} = getFederatedTestingSchema([
+        { name: 'S1', typeDefs: s1 },
+        { name: 'S2', typeDefs: s2 }
+      ]);
+
+      const t1s_s1: any[] = [{ __typename: 'T1', a: 1, b: 'T1_v1'}, {__typename: 'T1', a: 2, b: 'T1_v2'}];
+      const t2s_s1: any[] = [{__typename: 'T2', a: 12}, {__typename: 'T2', a: 24}];
+      const t3s_s1: any[] = [{__typename: 'T3', a: 42, c: 'T3_v1'}];
+      const t4s_s1: any[] = [{__typename: 'T4', a: 0}, {__typename: 'T4', a: 10}, {__typename: 'T4', a: 20}];
+
+      const t2s_s2 = new Map<number, {a: number, b: string}>();
+      t2s_s2.set(12, {a: 12 , b: 'k1'});
+      t2s_s2.set(24, {a: 24 , b: 'k2'});
+
+      const t4s_s2 = new Map<number, {a: number, b: string, c: string}>();
+      t4s_s2.set(0, {a: 0, b: 'b_0', c: 'c_0'});
+      t4s_s2.set(10, {a: 10, b: 'b_10', c: 'c_10'});
+      t4s_s2.set(20, {a: 20, b: 'b_20', c: 'c_20'});
+
+      addResolversToSchema(serviceMap['S1'].schema, {
+        Query: {
+          allValues() {
+            return t1s_s1.concat(t2s_s1).concat(t3s_s1).concat(t4s_s1);
+          },
+        },
       });
 
-      it(`include: true, skip: false`, async () => {
-        const operationDocument = gql`
-          query TopReviews($shouldInclude: Boolean!, $shouldSkip: Boolean!) {
-            topReviews(first: 2) @include(if: $shouldInclude) @skip(if: $shouldSkip) {
-              body
-            }
+      addResolversToSchema(serviceMap['S2'].schema, {
+        T2: {
+          __resolveReference(ref) {
+            return t2s_s2.get(ref.b);
           }
-        `;
-
-        const operationContext = buildOperationContext({
-          schema,
-          operationDocument,
-        });
+        },
+        T4: {
+          __resolveReference(ref) {
+            return t4s_s2.get(ref.a);
+          }
+        },
+      });
 
-        const queryPlan = queryPlanner.buildQueryPlan(operationContext);
+      let operation = parseOp(`
+        query {
+          allValues {
+            a
+          }
+        }
+        `, schema);
 
-        const variables = { shouldInclude: true, shouldSkip: false };
-        const response = await executeQueryPlan(
-          queryPlan,
-          serviceMap,
-          buildRequestContext(variables),
-          operationContext,
-        );
+      let queryPlan = buildPlan(operation, queryPlanner);
 
-        expect(response.data).toMatchObject({
-          topReviews: [
+      expect(queryPlan).toMatchInlineSnapshot(`
+        QueryPlan {
+          Fetch(service: "S1") {
             {
-              body: 'Love it!',
+              allValues {
+                __typename
+                a
+              }
+            }
+          },
+        }
+      `);
+
+      let response = await executePlan(queryPlan, operation, undefined, schema, serviceMap);
+      expect(response.data).toMatchInlineSnapshot(`
+        Object {
+          "allValues": Array [
+            Object {
+              "a": 1,
             },
-            {
-              body: 'Too expensive.',
+            Object {
+              "a": 2,
+            },
+            Object {
+              "a": 12,
+            },
+            Object {
+              "a": 24,
+            },
+            Object {
+              "a": 42,
+            },
+            Object {
+              "a": 0,
+            },
+            Object {
+              "a": 10,
+            },
+            Object {
+              "a": 20,
             },
           ],
-        });
-        expect({ queryPlan, variables }).toCallService('reviews');
-      });
+        }
+        `);
 
-      it(`include: true, skip: true`, async () => {
-        const operationDocument = gql`
-          query TopReviews($shouldInclude: Boolean!, $shouldSkip: Boolean!) {
-            topReviews @include(if: $shouldInclude) @skip(if: $shouldSkip) {
-              body
+      operation = parseOp(`
+        query {
+          allValues {
+            ... on SubInterface1 {
+              a
             }
           }
-        `;
-
-        const operationContext = buildOperationContext({
-          schema,
-          operationDocument,
-        });
-
-        const queryPlan = queryPlanner.buildQueryPlan(operationContext);
-
-        const variables = { shouldInclude: true, shouldSkip: true };
-        const response = await executeQueryPlan(
-          queryPlan,
-          serviceMap,
-          buildRequestContext(variables),
-          operationContext,
-        );
-
-        expect(response.data).toMatchObject({});
-        expect(queryPlan).toMatchInlineSnapshot(`
-          QueryPlan {
-            Fetch(service: "reviews", inclusionConditions: [{ include: "shouldInclude", skip: "shouldSkip" }]) {
-              {
-                topReviews @include(if: $shouldInclude) @skip(if: $shouldSkip) {
-                  body
+        }
+        `, schema);
+
+      queryPlan = buildPlan(operation, queryPlanner);
+
+      // TODO: we're actually type-exploding in this case because currently, as soon as we need to type-explode, we do
+      // so into all the runtime types, while here it could make sense to only type-explode into the direct sub-types=
+      // (the sub-interfaces). We should fix this (but it's only sub-optimal, not incorrect).
+      expect(queryPlan).toMatchInlineSnapshot(`
+        QueryPlan {
+          Fetch(service: "S1") {
+            {
+              allValues {
+                __typename
+                ... on T1 {
+                  a
+                }
+                ... on T2 {
+                  a
+                }
+                ... on T4 {
+                  a
                 }
               }
+            }
+          },
+        }
+      `);
+
+      response = await executePlan(queryPlan, operation, undefined, schema, serviceMap);
+      expect(response.data).toMatchInlineSnapshot(`
+        Object {
+          "allValues": Array [
+            Object {
+              "a": 1,
             },
-          }
+            Object {
+              "a": 2,
+            },
+            Object {
+              "a": 12,
+            },
+            Object {
+              "a": 24,
+            },
+            Object {},
+            Object {
+              "a": 0,
+            },
+            Object {
+              "a": 10,
+            },
+            Object {
+              "a": 20,
+            },
+          ],
+        }
         `);
-
-        expect({ queryPlan, variables }).not.toCallService('reviews');
-      });
     });
   });
 });