@apollo/federation-internals 2.4.5 → 2.4.7

package/src/utils.ts

@@ -401,7 +401,7 @@ export function printHumanReadableList(
 }
 
 export type Concrete<Type> = {
-  [Property in keyof Type]-?: Type[Property];
+  [Property in keyof Type]-?: Concrete<Type[Property]>;
 };
 
 // for use with Array.filter

package/CHANGELOG.md

@@ -1,211 +0,0 @@
-# CHANGELOG for `@apollo/federation-internals`
-
-## 2.4.5
-### Patch Changes
-
-
-- Supersedes v2.4.4 due to a publishing error with no dist/ folder ([#2583](https://github.com/apollographql/federation/pull/2583))
-
-## 2.4.4
-
-## 2.4.3
-### Patch Changes
-
-
-- Improves the heuristics used to try to reuse the query named fragments in subgraph fetches. Said fragment will be reused ([#2541](https://github.com/apollographql/federation/pull/2541))
-  more often, which can lead to smaller subgraph queries (and hence overall faster processing).
-
-## 2.4.2
-### Patch Changes
-
-
-- Allow passing print options to the `compose` method to impact how the supergraph is printed, and adds new printing ([#2042](https://github.com/apollographql/federation/pull/2042))
-  options to order all elements of the schema.
-
-- Fix potential bug when an `@interfaceObject` type has a `@requires`. When an `@interfaceObject` type has a field with a ([#2524](https://github.com/apollographql/federation/pull/2524))
-  `@requires` and the query requests that field only for some specific implementations of the corresponding interface,
-  then the generated query plan was sometimes invalid and could result in an invalid query to a subgraph (against a
-  subgraph that rely on `@apollo/subgraph`, this lead the subgraph to produce an error message looking like `"The
-  _entities resolver tried to load an entity for type X, but no object or interface type of that name was found in the
-  schema"`).
-
-## 2.4.1
-### Patch Changes
-
-
-- Fix issues (incorrectly rejected composition and/or subgraph errors) with `@interfaceObject`. Those issues may occur ([#2494](https://github.com/apollographql/federation/pull/2494))
-  either due to some use of `@requires` in an `@interfaceObject` type, or when some subgraph `S` defines a type that is an
-  implementation of an interface `I` in the supergraph, and there is an `@interfaceObject` for `I` in another subgraph,
-  but `S` does not itself defines `I`.
-
-- Fix assertion error during query planning in some cases where queries has some unsatisfiable branches (a part of the ([#2486](https://github.com/apollographql/federation/pull/2486))
-  query goes through type conditions that no runtime types satisfies).
-
-- Start building packages with TS 5.x, which should have no effect on consumers ([#2480](https://github.com/apollographql/federation/pull/2480))
-
-
-- Improves reuse of named fragments in subgraph fetches. When a question has named fragments, the code tries to reuse ([#2497](https://github.com/apollographql/federation/pull/2497))
-  those fragment in subgraph fetches is those can apply (so when the fragment is fully queried in a single subgraph fetch).
-  However, the existing was only able to reuse those fragment in a small subset of cases. This change makes it much more
-  likely that _if_ a fragment can be reused, it will be.
-
-## 2.4.0
-### Patch Changes
-
-
-- Refactor the internal implementation of selection sets used by the query planner to decrease the code complexity and ([#2387](https://github.com/apollographql/federation/pull/2387))
-  improve query plan generation performance in many cases.
-
-- Revert #2293. Removing URL import causes a problem when running under deno. ([#2451](https://github.com/apollographql/federation/pull/2451))
-
-
-- Use globally available URL object instead of node builtin "url" module ([#2293](https://github.com/apollographql/federation/pull/2293))
-
-
-- Optimises query plan generation for parts of queries that can statically be known to not cross across subgraphs ([#2449](https://github.com/apollographql/federation/pull/2449))
-
-## 2.4.0-alpha.1
-### Patch Changes
-
-
-- Revert #2293. Removing URL import causes a problem when running under deno. ([#2451](https://github.com/apollographql/federation/pull/2451))
-
-## 2.4.0-alpha.0
-### Patch Changes
-
-
-- Handle defaulted variables correctly during post-processing. ([#2443](https://github.com/apollographql/federation/pull/2443))
-  
-  Users who tried to use built-in conditional directives (skip/include) with _defaulted_ variables and no variable provided would encounter an error thrown by operation post-processing saying that the variables weren't provided. The defaulted values went unaccounted for, so the operation would validate but then fail an assertion while resolving the conditional.
-  
-  With this change, defaulted variable values are now collected and provided to post-processing (with defaults being overwritten by variables that are actually provided).
-
-
-## 2.3.5
-
-## 2.3.4
-### Patch Changes
-
-- Use globally available URL object instead of node builtin "url" module ([#2293](https://github.com/apollographql/federation/pull/2293))
-
-## 2.3.3
-
-## 2.3.2
-
-## 2.3.1
-
-## 2.3.0
-
-- Fix incorrect handling of `@external` on a type when dealing when adding `@shareable` during fed1 schema upgrades [PR #2343](https://github.com/apollographql/federation/pull/2343).
-
-## 2.2.1
-
-- Fix federation spec always being expanded to the last version [PR #2274](https://github.com/apollographql/federation/pull/2274).
-
-## 2.2.0
-
-- Preserve default values of input object fields [PR #2218](https://github.com/apollographql/federation/pull/2218).
-- Provide support for marking @external on object type [PR #2214](https://github.com/apollographql/federation/pull/2214)
-- Drop support for node12 [PR #2202](https://github.com/apollographql/federation/pull/2202)
-- Correctly reject field names starting with `__` [PR #2237](https://github.com/apollographql/federation/pull/2237).
-- Preserve default values of input object fields [PR #2218](https://github.com/apollographql/federation/pull/2218).
-
-## 2.1.4
-
-- Ensures supergraph `@defer`/`@stream` definitions of supergraph are not included in the API schema [PR #2212](https://github.com/apollographql/federation/pull/2212).
-- Fix validation of variable on input field not taking default into account [PR #2176](https://github.com/apollographql/federation/pull/2176).
-
-## 2.1.0
-
-- Update peer dependency `graphql` to `^16.5.0` to use `GraphQLErrorOptions` [PR #2060](https://github.com/apollographql/federation/pull/2060)
-- Don't require `@link` when using `@composeDirective` [PR #2046](https://github.com/apollographql/federation/pull/2046)
-- Add `@defer` support [PR #1958](https://github.com/apollographql/federation/pull/1958)
-- Add `@composeDirective` directive to specify directives that should be merged to the supergraph during composition [PR #1996](https://github.com/apollographql/federation/pull/1996).
-- Expand support for Node.js v18 [PR #1884](https://github.com/apollographql/federation/pull/1884)
-
-## 2.0.4
-
-- Fix issue when all root operations were defined in an `extend schema` [PR #1875](https://github.com/apollographql/federation/issues/1875).
-
-## 2.0.3
-
-- Fix bug with type extension of empty type definition [PR #1821](https://github.com/apollographql/federation/pull/1821)
-
-## 2.0.2
-
-- Fix bug removing an enum type [PR #1813](https://github.com/apollographql/federation/pull/1813)
-- Fix `Schema.clone` when directive application happens before definition [PR #1785](https://github.com/apollographql/federation/pull/1785)
-- More helpful error message for errors encountered while reading supergraphs generated pre-federation 2 [PR #1796](https://github.com/apollographql/federation/pull/1796)
-- Fix bug applying an imported federation directive on another directive definition [PR #1797](https://github.com/apollographql/federation/pull/1797).
-- Prevent non-core-feature elements from being marked @inaccessible if referenced by core feature elements [PR #1769](https://github.com/apollographql/federation/pull/1769)
-- Improve fed1 schema support during composition [PR #1735](https://github.com/apollographql/federation/pull/1735)
-- Honor directive imports when directive name is spec name [PR #1720](https://github.com/apollographql/federation/pull/1720)
-
-## v2.0.1
-
-- Use `for: SECURITY` in the core/link directive application in the supergraph for `@inaccessible` [PR #1715](https://github.com/apollographql/federation/pull/1715)
-
-## v2.0.0
-
-- Previous preview release promoted to general availability! Please see previous changelog entries for full info.
-
-## v2.0.0-preview.14
-
-- Implement `buildSubgraphSchema` using federation internals [PR #1697](https://github.com/apollographql/federation/pull/1697)
-
-
-## v2.0.0-preview.11
-
-- Add support for `@inaccessible` v0.2 [PR #1678](https://github.com/apollographql/federation/pull/1678)
-- Add a level to hints, uppercase their code and related fixes [PR #1683](https://github.com/apollographql/federation/pull/1683).
-
-## v2.0.0-preview.9
-
-- Adds Support for `@tag/v0.2`, which allows the `@tag` directive to be additionally placed on arguments, scalars, enums, enum values, input objects, and input object fields. [PR #1652](https://github.com/apollographql/federation/pull/1652).
-- Add missing `includeDeprecated` argument for `args` and `inputFields` when defining introspection fields [PR #1584](https://github.com/apollographql/federation/pull/1584)
-- Adds support for the `@override` directive on fields to indicate that a field should be moved from one subgraph to another. [PR #1484](https://github.com/apollographql/federation/pull/1484)
-
-## v2.0.0-preview.5
-
-- Fix propagation of `@tag` to the supergraph and allows @tag to be repeated. Additionally, merged directives (only `@tag` and `@deprecated` currently) are not allowed on external fields anymore [PR #1592](https://github.com/apollographql/federation/pull/1592).
-
-## v2.0.0-preview.4
-
-- Make error messages more actionable when constructing subgraphs from a supergraph [PR #1586](https://github.com/apollographql/federation/pull/1586)
-
-## v2.0.0-preview.3
-
-- Fix issue that created type extensions with descriptions, which is invalid graphQL syntax [PR #1582](https://github.com/apollographql/federation/pull/1582).
-
-## v2.0.0-preview.2
-
-- Re-publishing release which published to npm with stale build artifacts from `version-0.x` release.
-
-## v2.0.0-preview.1
-
-- No-op publish to account for publishing difficulties.
-
-## v2.0.0-preview.0
-
-- Initial "preview" release.
-
-## v2.0.0-alpha.6
-
-- Avoid incomplete subgraphs when extracting them from the supergraph. [PR #1511](https://github.com/apollographql/federation/pull/1511)
-
-## v2.0.0-alpha.5
-
-- Remove `graphql@15` from peer dependencies [PR #1472](https://github.com/apollographql/federation/pull/1472).
-
-## v2.0.0-alpha.3
-
-- Assign and document error codes for all errors [PR #1274](https://github.com/apollographql/federation/pull/1274).
-- Fix issue reading some 0.x generated supergraphs [PR #1351](https://github.com/apollographql/federation/pull/1351).
-
-## v2.0.0-alpha.2
-
-- __BREAKING__: Bump graphql peer dependency to `^15.7.0` [PR #1200](https://github.com/apollographql/federation/pull/1200)
-
-## v2.0.0-alpha.1
-
-- :tada: Initial alpha release of Federation 2.0.  For more information, see our [documentation](https://www.apollographql.com/docs/federation/v2/).  We look forward to your feedback!

package/jest.config.js

@@ -1,11 +0,0 @@
-const baseConfig = require('../jest.config.base');
-
-/** @typedef {import('ts-jest/dist/types')} */
-/** @type {import('@jest/types').Config.InitialOptions} */
-module.exports = {
-  ...baseConfig,
-  displayName: {
-    name: '@apollo/federation-internals',
-    color: 'magenta'
-  }
-};

package/src/__tests__/coreSpec.test.ts

@@ -1,212 +0,0 @@
-import { DocumentNode, GraphQLError } from "graphql";
-import gql from "graphql-tag";
-import { buildSubgraph } from "../federation";
-import { assert } from "../utils";
-import { buildSchemaFromAST } from "../buildSchema";
-import { removeAllCoreFeatures } from "../coreSpec";
-import { errorCauses } from "../error";
-
-function expectErrors(
-  subgraphDefs: DocumentNode,
-  expectedErrorMessages: string[],
-) {
-  let thrownError: Error | undefined = undefined;
-  expect(() => {
-    try {
-      // Note: we use buildSubgraph because currently it's the only one that does auto-magic import of
-      // directive definition, and we don't want to bother with adding the @link definition to every
-      // example.
-      buildSubgraph('S', '', subgraphDefs)
-    } catch (e) {
-      // Kind-of ugly, but if Jest has a better option, I haven't found it.
-      thrownError = e;
-      throw e;
-    }
-  }).toThrow(GraphQLError);
-
-  assert(thrownError, 'Should have thrown');
-  const causes = errorCauses(thrownError);
-  assert(causes, 'Should have some causes');
-  // Note: all the received message with start with "[S] <rest of message>", so the `slice` below
-  // strips the extra prefix. This avoid leaking the subgraph name to leak to the tests themselves.
-  expect(causes.map((e) => e.message.slice(4))).toStrictEqual(expectedErrorMessages);
-}
-
-describe('@link(import:) argument', () => {
-  test('errors on misformed values', () => {
-    const schema = gql`
-      extend schema @link(
-        url: "https://specs.apollo.dev/federation/v2.0",
-        import: [
-          2,
-          { foo: "bar" },
-          { name: "@key", badName: "foo"},
-          { name: 42 },
-          { as: "bar" },
-         ]
-      )
-
-      type Query {
-        q: Int
-      }
-    `;
-
-    expectErrors(schema, [
-      'Invalid sub-value 2 for @link(import:) argument: values should be either strings or input object values of the form { name: "<importedElement>", as: "<alias>" }.',
-      'Unknown field "foo" for sub-value {foo: "bar"} of @link(import:) argument.',
-      'Unknown field "badName" for sub-value {name: "@key", badName: "foo"} of @link(import:) argument.',
-      'Invalid value for the "name" field for sub-value {name: 42} of @link(import:) argument: must be a string.',
-      'Invalid sub-value {as: "bar"} for @link(import:) argument: missing mandatory "name" field.',
-    ]);
-  });
-
-  test('errors on mismatch between name and alias', () => {
-    const schema = gql`
-      extend schema @link(
-        url: "https://specs.apollo.dev/federation/v2.0",
-        import: [
-          { name: "@key", as: "myKey" },
-          { name: "FieldSet", as: "@fieldSet" },
-        ]
-      )
-
-      type Query {
-        q: Int
-      }
-    `;
-
-    expectErrors(schema, [
-      'Invalid @link import renaming: directive "@key" imported name should start with a \'@\' character, but got "myKey".',
-      'Invalid @link import renaming: type "FieldSet" imported name should not start with a \'@\' character, but got "@fieldSet" (or, if @FieldSet is a directive, then it should be referred to with a \'@\').',
-    ]);
-  });
-
-  test('errors on importing unknown elements for known features', () => {
-    const schema = gql`
-      extend schema @link(
-        url: "https://specs.apollo.dev/federation/v2.0",
-        import: [ "@foo", "key", { name: "@sharable" } ]
-      )
-
-      type Query {
-        q: Int
-      }
-    `;
-
-    expectErrors(schema, [
-      'Cannot import unknown element "@foo".',
-      'Cannot import unknown element "key". Did you mean directive "@key"?',
-      'Cannot import unknown element "@sharable\". Did you mean "@shareable"?',
-    ]);
-  });
-});
-
-describe('removeAllCoreFeatures', () => {
-  it('removes core (and only core) feature definitions, accounting for aliasing', () => {
-    const schema = buildSchemaFromAST(gql`
-      directive @lonk(url: String, as: String, for: Porpoise, import: [lonk__Import]) repeatable on SCHEMA
-
-      scalar lonk__Import
-
-      enum Porpoise {
-        """
-        \`SECURITY\` features provide metadata necessary to securely resolve fields.
-        """
-        SECURITY
-
-        """
-        \`EXECUTION\` features provide metadata necessary for operation execution.
-        """
-        EXECUTION
-      }
-
-      extend schema
-        @lonk(
-          url: "https://specs.apollo.dev/link/v1.0",
-          as: "lonk",
-          import: [
-            { name: "Purpose", as: "Porpoise" }
-          ]
-        )
-        @lonk(
-          url: "https://localhost/foobar/v1.0",
-          as: "foo"
-          import: [
-            "bar",
-            "@baz",
-            { name: "qux", as: "qax" },
-            { name: "@quz", as: "@qaz" },
-          ]
-        )
-
-      type Query {
-        q: Int
-      }
-
-      # Shouldn't remove original spec name
-      scalar foobar
-      scalar foobar__Scalar
-      directive @foobar on FIELD
-      directive @foobar__directive on FIELD
-
-      # Should remove aliased spec name (other than type "foo")
-      scalar foo
-      scalar foo__Scalar
-      directive @foo on FIELD
-      directive @foo__directive on FIELD
-
-      # Should remove imports (prefixed or not)
-      type bar implements foo__bar {
-        someField: foo!
-      }
-      interface foo__bar {
-        someField: foo!
-      }
-      directive @baz on FIELD
-      directive @foo__baz on FIELD
-
-      # Shouldn't remove original import names
-      input qux {
-        someField: ID!
-      }
-      directive @quz on FIELD
-
-      # Should remove aliased import names (and prefixed original)
-      union qax = bar
-      enum foo__qax {
-        SOME_VALUE
-      }
-      scalar foo__qux
-      directive @qaz on FIELD
-      directive @foo__qaz on FIELD
-      directive @foo__quz on FIELD
-    `);
-
-    removeAllCoreFeatures(schema);
-    schema.validate();
-
-    expect(schema.elementByCoordinate("@lonk")).toBeUndefined();
-    expect(schema.elementByCoordinate("lonk__Import")).toBeUndefined();
-    expect(schema.elementByCoordinate("Porpoise")).toBeUndefined();
-    expect(schema.elementByCoordinate("foobar")).toBeDefined();
-    expect(schema.elementByCoordinate("foobar__Scalar")).toBeDefined();
-    expect(schema.elementByCoordinate("@foobar")).toBeDefined();
-    expect(schema.elementByCoordinate("@foobar__directive")).toBeDefined();
-    expect(schema.elementByCoordinate("foo")).toBeDefined();
-    expect(schema.elementByCoordinate("foo__Scalar")).toBeUndefined();
-    expect(schema.elementByCoordinate("@foo")).toBeUndefined();
-    expect(schema.elementByCoordinate("@foo__directive")).toBeUndefined();
-    expect(schema.elementByCoordinate("bar")).toBeUndefined();
-    expect(schema.elementByCoordinate("foo__bar")).toBeUndefined();
-    expect(schema.elementByCoordinate("@baz")).toBeUndefined();
-    expect(schema.elementByCoordinate("@foo__baz")).toBeUndefined();
-    expect(schema.elementByCoordinate("qux")).toBeDefined();
-    expect(schema.elementByCoordinate("@quz")).toBeDefined();
-    expect(schema.elementByCoordinate("qax")).toBeUndefined();
-    expect(schema.elementByCoordinate("foo__qax")).toBeUndefined();
-    expect(schema.elementByCoordinate("foo__qux")).toBeUndefined();
-    expect(schema.elementByCoordinate("@qaz")).toBeUndefined();
-    expect(schema.elementByCoordinate("@foo__qaz")).toBeUndefined();
-    expect(schema.elementByCoordinate("@foo__quz")).toBeUndefined();
-  });
-});