@apollo/client 4.3.0-alpha.5 → 4.3.0-alpha.7

package/CHANGELOG.md

@@ -1,5 +1,27 @@
 # @apollo/client
 
+## 4.3.0-alpha.7
+
+### Minor Changes
+
+- [#13406](https://github.com/apollographql/apollo-client/pull/13406) [`bd74ccb`](https://github.com/apollographql/apollo-client/commit/bd74ccb2f75bc434afc4f5172311b551266f8196) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Emit a development-only warning when a feud is detected between queries that overwrite each other's data. This should make it easier to detect when you need to select a key field or add a `merge` function to a field policy.
+
+- [#13406](https://github.com/apollographql/apollo-client/pull/13406) [`bd74ccb`](https://github.com/apollographql/apollo-client/commit/bd74ccb2f75bc434afc4f5172311b551266f8196) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Fixes an issue where cache feuds between queries selecting incompatible non-normalized data could return untransformed network values.
+
+  Apollo Client now always writes network results to the cache before delivering them, ensuring custom scalars and field `read` functions are applied. To prevent repeated refetches when competing queries repeatedly make each other's cache results incomplete, Apollo Client stops automatically refetching a query after it sees the same incomplete result again.
+
+  This may add one network request in these cache-feud scenarios.
+
+## 4.3.0-alpha.6
+
+### Minor Changes
+
+- [#13405](https://github.com/apollographql/apollo-client/pull/13405) [`f923ab4`](https://github.com/apollographql/apollo-client/commit/f923ab422e1bcd35c1bcd2939f58dc3723508b55) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Field policy `read` and `merge` functions are now ignored when the field policy configures the `scalar` option. If a `read` or `merge` function is provided alongside `scalar`, a development-only warning is emitted.
+
+### Patch Changes
+
+- [#13408](https://github.com/apollographql/apollo-client/pull/13408) [`7a5164d`](https://github.com/apollographql/apollo-client/commit/7a5164d3ce21b7f88f625588ec72dbce8ea33810) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Fix `dataState` to report `"streaming"` instead of `"partial"` when `returnPartialData` is `true` and the cache result is missing only `@defer` fields.
+
 ## 4.3.0-alpha.5
 
 ### Minor Changes

package/__cjs/cache/core/cache.cjs

@@ -147,7 +147,7 @@ class ApolloCache {
             if (environment_1.__DEV__) {
                 const actualFragmentName = fragmentName || (0, internal_1.getFragmentDefinition)(fragment).name.value;
                 if (id === undefined) {
-                    __DEV__ && invariant_1.invariant.warn(120, actualFragmentName);
+                    __DEV__ && invariant_1.invariant.warn(122, actualFragmentName);
                 }
             }
             return id;

package/__cjs/cache/inmemory/entityStore.cjs

@@ -82,7 +82,7 @@ class EntityStore {
         // then there are no fields to be merged, so we're done.
         if (!incoming)
             return;
-        (0, invariant_1.invariant)(typeof dataId === "string", 105);
+        (0, invariant_1.invariant)(typeof dataId === "string", 106);
         // Parse all scalars before merging so that the storeObjectReconciler can
         // deep compare the parsed value with the existing value
         incoming = this.coerceStoreObject(incoming, (scalar, value) => scalar.coerceToParsed(value), incoming.__typename ||
@@ -189,7 +189,7 @@ class EntityStore {
                             if (environment_1.__DEV__) {
                                 const checkReference = (ref) => {
                                     if (this.lookup(ref.__ref) === undefined) {
-                                        __DEV__ && invariant_1.invariant.warn(106, ref);
+                                        __DEV__ && invariant_1.invariant.warn(107, ref);
                                         return true;
                                     }
                                 };
@@ -218,7 +218,7 @@ class EntityStore {
                                             }
                                         }
                                         if (seenReference && someNonReference !== undefined) {
-                                            __DEV__ && invariant_1.invariant.warn(107, someNonReference);
+                                            __DEV__ && invariant_1.invariant.warn(108, someNonReference);
                                             break;
                                         }
                                     }

package/__cjs/cache/inmemory/key-extractor.cjs

@@ -41,7 +41,7 @@ function keyFieldsFnFromSpecifier(specifier) {
                     // context.readField for this extraction.
                     extracted = extractKeyPath(object, schemaKeyPath, extractKey);
                 }
-                (0, invariant_1.invariant)(extracted !== void 0, 108, schemaKeyPath.join("."), object);
+                (0, invariant_1.invariant)(extracted !== void 0, 109, schemaKeyPath.join("."), object);
                 return extracted;
             }));
             return `${context.typename}:${JSON.stringify(keyObject)}`;

package/__cjs/cache/inmemory/policies.cjs

@@ -194,13 +194,32 @@ class Policies {
                 }
                 const incoming = fields[fieldName];
                 if (typeof incoming === "function") {
-                    existing.read = incoming;
+                    if (existing.scalar) {
+                        if (environment_1.__DEV__) {
+                            warnAboutScalarConfig(typename, fieldName, existing.scalar, "read");
+                        }
+                    }
+                    else {
+                        existing.read = incoming;
+                    }
                 }
                 else {
-                    const { keyArgs, read, merge, scalar } = incoming;
+                    let { keyArgs, read, merge, scalar } = incoming;
                     if (scalar) {
                         existing.scalar = scalar;
                     }
+                    if (existing.scalar) {
+                        if (environment_1.__DEV__) {
+                            if (read !== undefined || existing.read !== undefined) {
+                                warnAboutScalarConfig(typename, fieldName, existing.scalar, "read");
+                            }
+                            if (merge !== undefined || existing.merge !== undefined) {
+                                warnAboutScalarConfig(typename, fieldName, existing.scalar, "merge");
+                            }
+                        }
+                        existing.read = read = undefined;
+                        existing.merge = merge = undefined;
+                    }
                     existing.keyFn =
                         // Pass false to disable argument-based differentiation of
                         // field identities.
@@ -232,7 +251,7 @@ class Policies {
         const rootId = "ROOT_" + which.toUpperCase();
         const old = this.rootTypenamesById[rootId];
         if (typename !== old) {
-            (0, invariant_1.invariant)(!old || old === which, 109, which);
+            (0, invariant_1.invariant)(!old || old === which, 110, which);
             // First, delete any old __typename associated with this rootId from
             // rootIdsByTypename.
             if (old)
@@ -375,7 +394,7 @@ class Policies {
                 if (supertypeSet.has(supertype)) {
                     if (!typenameSupertypeSet.has(supertype)) {
                         if (checkingFuzzySubtypes) {
-                            __DEV__ && invariant_1.invariant.warn(110, typename, supertype);
+                            __DEV__ && invariant_1.invariant.warn(111, typename, supertype);
                         }
                         // Record positive results for faster future lookup.
                         // Unfortunately, we cannot safely cache negative results,
@@ -632,7 +651,7 @@ function normalizeReadFieldOptions(readFieldArgs, objectOrReference, variables)
         }
     }
     if (environment_1.__DEV__ && options.from === void 0) {
-        __DEV__ && invariant_1.invariant.warn(111, (0, internal_2.stringifyForDisplay)(Array.from(readFieldArgs)));
+        __DEV__ && invariant_1.invariant.warn(112, (0, internal_2.stringifyForDisplay)(Array.from(readFieldArgs)));
     }
     if (void 0 === options.variables) {
         options.variables = variables;
@@ -642,7 +661,7 @@ function normalizeReadFieldOptions(readFieldArgs, objectOrReference, variables)
 function makeMergeObjectsFunction(store) {
     return function mergeObjects(existing, incoming) {
         if ((0, internal_2.isArray)(existing) || (0, internal_2.isArray)(incoming)) {
-            throw (0, invariant_1.newInvariantError)(112);
+            throw (0, invariant_1.newInvariantError)(113);
         }
         // These dynamic checks are necessary because the parameters of a
         // custom merge function can easily have the any type, so the type
@@ -678,4 +697,7 @@ function makeMergeObjectsFunction(store) {
         return incoming;
     };
 }
+function warnAboutScalarConfig(typename, fieldName, scalar, kind) {
+    __DEV__ && invariant_1.invariant.warn(114, `${typename}.${fieldName}`, scalar, kind);
+}
 //# sourceMappingURL=policies.cjs.map