@apollo/client 4.3.0-alpha.4 → 4.3.0-alpha.5

package/core/QueryManager.js

@@ -11,6 +11,7 @@ import { cacheSizes, DocumentTransform, isNetworkRequestInFlight, print, } from
 import { __DEV__ } from "@apollo/client/utilities/environment";
 import { AutoCleanedWeakCache, checkDocument, extensionsSymbol, filterMap, getDefaultValues, getOperationDefinition, getOperationName, graphQLResultHasError, hasDirectives, hasForcedResolvers, isDocumentNode, isNonNullObject, makeUniqueId, mergeOptions, removeDirectivesFromDocument, streamInfoSymbol, toQueryResult, } from "@apollo/client/utilities/internal";
 import { invariant, newInvariantError, } from "@apollo/client/utilities/invariant";
+import { dataStateErrorCache } from "./dataStateErrorCache.js";
 import { NetworkStatus } from "./networkStatus.js";
 import { logMissingFieldErrors, ObservableQuery } from "./ObservableQuery.js";
 import { QueryInfo } from "./QueryInfo.js";
@@ -75,6 +76,12 @@ export class QueryManager {
                     // selections and fragments from the fragment registry.
                     .concat(defaultDocumentTransform)
                 : defaultDocumentTransform;
+        // Put the incremental transform last so custom document transforms don't
+        // revert changes made to the document accidentally. Adding last also
+        // ensures `@defer` fragments added by the fragment registry are labeled.
+        if (this.incrementalHandler.documentTransform) {
+            this.documentTransform = this.documentTransform.concat(this.incrementalHandler.documentTransform);
+        }
         this.defaultContext = options.defaultContext || {};
         if ((this.onBroadcast = options.onBroadcast)) {
             this.mutationStore = {};
@@ -92,7 +99,7 @@ export class QueryManager {
      */
     stop() {
         this.obsQueries.forEach((oq) => oq.stop());
-        this.cancelPendingFetches(newInvariantError(89));
+        this.cancelPendingFetches(newInvariantError(90));
     }
     cancelPendingFetches(error) {
         this.fetchCancelFns.forEach((cancel) => cancel(error));
@@ -105,7 +112,7 @@ export class QueryManager {
         variables = this.getVariables(mutation, variables);
         if (hasClientExports) {
             if (__DEV__) {
-                invariant(this.localState, 90, getOperationName(mutation, "(anonymous)"));
+                invariant(this.localState, 91, getOperationName(mutation, "(anonymous)"));
             }
             variables = await this.localState.getExportedVariables({
                 client: this.client,
@@ -338,7 +345,7 @@ export class QueryManager {
         // depend on values that previously existed in the data portion of the
         // store. So, we cancel the promises and observers that we have issued
         // so far and not yet resolved (in the case of queries).
-        this.cancelPendingFetches(newInvariantError(91));
+        this.cancelPendingFetches(newInvariantError(92));
         this.obsQueries.forEach((observableQuery) => {
             // Set loading to true so listeners don't trigger unless they want
             // results with partial data.
@@ -408,10 +415,10 @@ export class QueryManager {
                 if (!included) {
                     const queryName = queryNames.get(nameOrQueryString);
                     if (queryName) {
-                        __DEV__ && invariant.warn(92, queryName);
+                        __DEV__ && invariant.warn(93, queryName);
                     }
                     else {
-                        __DEV__ && invariant.warn(93);
+                        __DEV__ && invariant.warn(94);
                     }
                 }
             });
@@ -440,7 +447,7 @@ export class QueryManager {
         if (__DEV__) {
             invariant(
                 !this.getDocumentInfo(query).hasClientExports || this.localState,
-                94,
+                95,
                 getOperationName(query, "(anonymous)")
             );
         }
@@ -585,14 +592,14 @@ export class QueryManager {
             if (__DEV__) {
                 invariant(
                     this.localState,
-                    95,
+                    96,
                     operation[0].toUpperCase() + operation.slice(1),
                     operationName ?? "(anonymous)"
                 );
             }
             invariant(
                 !hasIncrementalDirective,
-                96,
+                97,
                 operation[0].toUpperCase() + operation.slice(1),
                 operationName ?? "(anonymous)"
             );
@@ -616,7 +623,7 @@ export class QueryManager {
             })),
         };
     }
-    getResultsFromLink(options, { queryInfo, cacheWriteBehavior, observableQuery, exposeExtensions, }) {
+    getResultsFromLink(options, { queryInfo, cacheWriteBehavior, observableQuery, exposeExtensions, prunePendingDeferFragments, }) {
         const { errorPolicy } = options;
         // Performing transformForLink here gives this.cache a chance to fill in
         // missing fragment definitions (for example) before sending this document
@@ -631,12 +638,15 @@ export class QueryManager {
                 document: linkDocument,
                 cacheWriteBehavior,
                 returnPartialData: options.returnPartialData,
+                prunePendingDeferFragments,
             });
             const hasErrors = graphQLResultHasError(result);
             if (hasErrors && errorPolicy === "none") {
                 queryInfo.resetLastWrite();
                 observableQuery?.["resetNotifications"]();
-                throw new CombinedGraphQLErrors(removeStreamDetailsFromExtensions(result));
+                const error = new CombinedGraphQLErrors(removeStreamDetailsFromExtensions(result));
+                dataStateErrorCache.set(error, dataState);
+                throw error;
             }
             const partial = dataState !== "complete";
             const aqr = {
@@ -658,16 +668,10 @@ export class QueryManager {
             if (exposeExtensions && "extensions" in result) {
                 aqr[extensionsSymbol] = result.extensions;
             }
-            if (hasErrors) {
-                if (errorPolicy === "none") {
-                    aqr.data = void 0;
-                    aqr.dataState = "empty";
-                }
-                if (errorPolicy !== "ignore") {
-                    aqr.error = new CombinedGraphQLErrors(removeStreamDetailsFromExtensions(result));
-                    if (aqr.networkStatus !== NetworkStatus.streaming) {
-                        aqr.networkStatus = NetworkStatus.error;
-                    }
+            if (hasErrors && errorPolicy !== "ignore") {
+                aqr.error = new CombinedGraphQLErrors(removeStreamDetailsFromExtensions(result));
+                if (aqr.networkStatus !== NetworkStatus.streaming) {
+                    aqr.networkStatus = NetworkStatus.error;
                 }
             }
             return aqr;
@@ -765,7 +769,7 @@ export class QueryManager {
         // we deprecated and removed LocalState.
         if (this.getDocumentInfo(normalized.query).hasClientExports) {
             if (__DEV__) {
-                invariant(this.localState, 97, getOperationName(normalized.query, "(anonymous)"));
+                invariant(this.localState, 98, getOperationName(normalized.query, "(anonymous)"));
             }
             observable = from(this.localState.getExportedVariables({
                 client: this.client,
@@ -938,7 +942,7 @@ export class QueryManager {
                 !isFullyUnmaskedOperation(document) &&
                 !this.noCacheWarningsByCause.has(cause)) {
                 this.noCacheWarningsByCause.add(cause);
-                __DEV__ && invariant.warn(98, getOperationName(document, `Unnamed ${operationType ?? "operation"}`));
+                __DEV__ && invariant.warn(99, getOperationName(document, `Unnamed ${operationType ?? "operation"}`));
             }
         }
         return (this.dataMasking ?
@@ -986,6 +990,10 @@ export class QueryManager {
                 return of({
                     kind: "N",
                     value: toResult(data),
+                    // Always attach the variables used for this fetch so @export
+                    // resolution can update ObservableQuery.options.variables and
+                    // resubscribe the cache watch under the correct variable set.
+                    resolvedVariables: variables,
                     source: "cache",
                 });
             };
@@ -996,7 +1004,7 @@ export class QueryManager {
             (diff.complete || returnPartialData) &&
                 this.getDocumentInfo(query).hasForcedResolvers) {
                 if (__DEV__) {
-                    invariant(this.localState, 99, getOperationName(query, "(anonymous)"));
+                    invariant(this.localState, 100, getOperationName(query, "(anonymous)"));
                 }
                 onCacheHit();
                 return from(this.localState.execute({
@@ -1011,6 +1019,10 @@ export class QueryManager {
                 }).then((resolved) => ({
                     kind: "N",
                     value: toResult(resolved.data || void 0),
+                    // Always attach the variables used for this fetch so @export
+                    // resolution can update ObservableQuery.options.variables and
+                    // resubscribe the cache watch under the correct variable set.
+                    resolvedVariables: variables,
                     source: "cache",
                 })));
             }
@@ -1025,7 +1037,7 @@ export class QueryManager {
             }
             return fromData(data || undefined);
         };
-        const resultsFromLink = () => this.getResultsFromLink({
+        const resultsFromLink = ({ prunePendingDeferFragments = true, } = {}) => this.getResultsFromLink({
             query,
             variables,
             context,
@@ -1038,8 +1050,13 @@ export class QueryManager {
             queryInfo,
             observableQuery,
             exposeExtensions,
+            prunePendingDeferFragments,
         }).pipe(validateDidEmitValue(), materialize(), map((result) => ({
             ...result,
+            // Always attach the variables used for this fetch so @export
+            // resolution can update ObservableQuery.options.variables and
+            // resubscribe the cache watch under the correct variable set.
+            resolvedVariables: variables,
             source: "network",
         })));
         switch (fetchPolicy) {
@@ -1065,7 +1082,7 @@ export class QueryManager {
                 if (diff.complete || returnPartialData) {
                     return {
                         fromLink: true,
-                        observable: concat(resultsFromCache(diff, NetworkStatus.loading), resultsFromLink()),
+                        observable: concat(resultsFromCache(diff, NetworkStatus.loading), resultsFromLink({ prunePendingDeferFragments: false })),
                     };
                 }
                 return { fromLink: true, observable: resultsFromLink() };
@@ -1076,7 +1093,12 @@ export class QueryManager {
                     observable: concat(resultsFromCache(readCache(), NetworkStatus.ready)),
                 };
             case "network-only":
-                return { fromLink: true, observable: resultsFromLink() };
+                return {
+                    fromLink: true,
+                    observable: resultsFromLink({
+                        prunePendingDeferFragments: networkStatus !== NetworkStatus.refetch,
+                    }),
+                };
             case "no-cache":
                 return { fromLink: true, observable: resultsFromLink() };
             case "standby":
@@ -1091,7 +1113,7 @@ function validateDidEmitValue() {
             didEmitValue = true;
         },
         complete() {
-            invariant(didEmitValue, 100);
+            invariant(didEmitValue, 101);
         },
     });
 }