@apollo/client 3.9.0-beta.0 → 3.9.0-rc.0

package/.changeset/chatty-comics-yawn.md

@@ -0,0 +1,8 @@
+---
+"@apollo/client": patch
+---
+
+Adds a deprecation warning to the HOC and render prop APIs.
+
+The HOC and render prop APIs have already been deprecated since 2020,
+but we previously didn't have a @deprecated tag in the DocBlocks.

package/.changeset/curvy-seas-hope.md

@@ -0,0 +1,13 @@
+---
+"@apollo/client": minor
+---
+
+Simplify RetryLink, fix potential memory leak
+
+Historically, `RetryLink` would keep a `values` array of all previous values,
+in case the operation would get an additional subscriber at a later point in time.
+In practice, this could lead to a memory leak (#11393) and did not serve any
+further purpose, as the resulting observable would only be subscribed to by
+Apollo Client itself, and only once - it would be wrapped in a `Concast` before
+being exposed to the user, and that `Concast` would handle subscribers on its
+own.

package/.changeset/late-rabbits-protect.md

@@ -0,0 +1,7 @@
+---
+'@apollo/client': minor
+---
+
+Remove the need to call `retain` from `useLoadableQuery` since `useReadQuery` will now retain the query. This means that a `queryRef` that is not consumed by `useReadQuery` within the given `autoDisposeTimeoutMs` will now be auto diposed for you.
+
+Thanks to [#11412](https://github.com/apollographql/apollo-client/pull/11412), disposed query refs will be automatically resubscribed to the query when consumed by `useReadQuery` after it has been disposed.

package/.changeset/pink-apricots-yawn.md

@@ -0,0 +1,5 @@
+---
+"@apollo/client": minor
+---
+
+Increase the default memory limits for `executeSelectionSet` and `executeSelectionSetArray`.

package/.changeset/pre.json

@@ -1,27 +1,33 @@
 {
   "mode": "pre",
-  "tag": "beta",
+  "tag": "rc",
   "initialVersions": {
     "@apollo/client": "3.8.3"
   },
   "changesets": [
     "beige-geese-wink",
     "breezy-spiders-tap",
+    "chatty-comics-yawn",
     "clean-items-smash",
     "cold-llamas-turn",
+    "curvy-seas-hope",
     "dirty-kids-crash",
     "dirty-tigers-matter",
     "forty-cups-shop",
     "friendly-clouds-laugh",
     "hot-ducks-burn",
+    "late-rabbits-protect",
     "mighty-coats-check",
+    "pink-apricots-yawn",
     "polite-avocados-warn",
     "quick-hats-marry",
     "rare-snakes-melt",
     "shaggy-ears-scream",
     "shaggy-sheep-pull",
     "sixty-boxes-rest",
+    "smooth-plums-shout",
     "sour-sheep-walk",
+    "spicy-drinks-camp",
     "strong-terms-perform",
     "swift-zoos-collect",
     "thick-mice-collect",
@@ -32,6 +38,7 @@
     "violet-lions-draw",
     "wet-forks-rhyme",
     "wild-dolphins-jog",
+    "wise-news-grab",
     "yellow-flies-repeat"
   ]
 }

package/.changeset/smooth-plums-shout.md

@@ -0,0 +1,5 @@
+---
+"@apollo/client": patch
+---
+
+ObservableQuery: prevent reporting results of previous queries if the variables changed since

package/.changeset/spicy-drinks-camp.md

@@ -0,0 +1,5 @@
+---
+'@apollo/client': patch
+---
+
+Address bundling issue introduced in [#11412](https://github.com/apollographql/apollo-client/pull/11412) where the `react/cache` internals ended up duplicated in the bundle. This was due to the fact that we had a `react/hooks` entrypoint that imported these files along with the newly introduced `createQueryPreloader` function, which lived outside of the `react/hooks` folder.

package/.changeset/wise-news-grab.md

@@ -0,0 +1,7 @@
+---
+'@apollo/client': minor
+---
+
+Remove the need to call `retain` from `useBackgroundQuery` since `useReadQuery` will now retain the query. This means that a `queryRef` that is not consumed by `useReadQuery` within the given `autoDisposeTimeoutMs` will now be auto diposed for you.
+
+Thanks to [#11412](https://github.com/apollographql/apollo-client/pull/11412), disposed query refs will be automatically resubscribed to the query when consumed by `useReadQuery` after it has been disposed.

package/CHANGELOG.md

@@ -1,5 +1,56 @@
 # @apollo/client
 
+## 3.9.0-rc.0
+
+### Minor Changes
+
+- [#11495](https://github.com/apollographql/apollo-client/pull/11495) [`1190aa5`](https://github.com/apollographql/apollo-client/commit/1190aa59a106217f7192c1f81099adfa5e4365c1) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Increase the default memory limits for `executeSelectionSet` and `executeSelectionSetArray`.
+
+## 3.8.9
+
+### Patch Changes
+
+- [#11472](https://github.com/apollographql/apollo-client/pull/11472) [`afc844d`](https://github.com/apollographql/apollo-client/commit/afc844dd8d6f9f7a3e2003f9a5b541291dfe3fb4) Thanks [@alessbell](https://github.com/alessbell)! - Fix delay: Infinity when set on a MockResponse passed to Mocked Provider so it indefinitely enters loading state.
+
+- [#11464](https://github.com/apollographql/apollo-client/pull/11464) [`aac12b2`](https://github.com/apollographql/apollo-client/commit/aac12b221a6cb776d4941b6c8aadf04f0f0acd27) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Prevent `useFragment` from excessively unsubscribing and resubscribing the fragment with the cache on every render.
+
+- [#11449](https://github.com/apollographql/apollo-client/pull/11449) [`f40cda4`](https://github.com/apollographql/apollo-client/commit/f40cda45841e93b056c781c19651b54464f7346a) Thanks [@phryneas](https://github.com/phryneas)! - Removes refences to the typescript "dom" lib.
+
+- [#11470](https://github.com/apollographql/apollo-client/pull/11470) [`e293bc9`](https://github.com/apollographql/apollo-client/commit/e293bc90d6f7937a6fc7c169f7b16eeb39d5fd49) Thanks [@phryneas](https://github.com/phryneas)! - Remove an unnecessary check from parseAndCheckHttpResponse.
+
+## 3.9.0-beta.1
+
+### Minor Changes
+
+- [#11424](https://github.com/apollographql/apollo-client/pull/11424) [`62f3b6d`](https://github.com/apollographql/apollo-client/commit/62f3b6d0e89611e27d9f29812ee60e5db5963fd6) Thanks [@phryneas](https://github.com/phryneas)! - Simplify RetryLink, fix potential memory leak
+
+  Historically, `RetryLink` would keep a `values` array of all previous values,
+  in case the operation would get an additional subscriber at a later point in time.
+  In practice, this could lead to a memory leak (#11393) and did not serve any
+  further purpose, as the resulting observable would only be subscribed to by
+  Apollo Client itself, and only once - it would be wrapped in a `Concast` before
+  being exposed to the user, and that `Concast` would handle subscribers on its
+  own.
+
+- [#11442](https://github.com/apollographql/apollo-client/pull/11442) [`4b6f2bc`](https://github.com/apollographql/apollo-client/commit/4b6f2bccf3ba94643b38689b32edd2839e47aec1) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Remove the need to call `retain` from `useLoadableQuery` since `useReadQuery` will now retain the query. This means that a `queryRef` that is not consumed by `useReadQuery` within the given `autoDisposeTimeoutMs` will now be auto diposed for you.
+
+  Thanks to [#11412](https://github.com/apollographql/apollo-client/pull/11412), disposed query refs will be automatically resubscribed to the query when consumed by `useReadQuery` after it has been disposed.
+
+- [#11438](https://github.com/apollographql/apollo-client/pull/11438) [`6d46ab9`](https://github.com/apollographql/apollo-client/commit/6d46ab930a5e9bd5cae153d3b75b8966784fcd4e) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Remove the need to call `retain` from `useBackgroundQuery` since `useReadQuery` will now retain the query. This means that a `queryRef` that is not consumed by `useReadQuery` within the given `autoDisposeTimeoutMs` will now be auto diposed for you.
+
+  Thanks to [#11412](https://github.com/apollographql/apollo-client/pull/11412), disposed query refs will be automatically resubscribed to the query when consumed by `useReadQuery` after it has been disposed.
+
+### Patch Changes
+
+- [#11443](https://github.com/apollographql/apollo-client/pull/11443) [`ff5a332`](https://github.com/apollographql/apollo-client/commit/ff5a332ff8b190c418df25371e36719d70061ebe) Thanks [@phryneas](https://github.com/phryneas)! - Adds a deprecation warning to the HOC and render prop APIs.
+
+  The HOC and render prop APIs have already been deprecated since 2020,
+  but we previously didn't have a @deprecated tag in the DocBlocks.
+
+- [#11078](https://github.com/apollographql/apollo-client/pull/11078) [`14edebe`](https://github.com/apollographql/apollo-client/commit/14edebebefb7634c32b921d02c1c85c6c8737989) Thanks [@phryneas](https://github.com/phryneas)! - ObservableQuery: prevent reporting results of previous queries if the variables changed since
+
+- [#11439](https://github.com/apollographql/apollo-client/pull/11439) [`33454f0`](https://github.com/apollographql/apollo-client/commit/33454f0a40a05ea2b00633bda20a84d0ec3a4f4d) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Address bundling issue introduced in [#11412](https://github.com/apollographql/apollo-client/pull/11412) where the `react/cache` internals ended up duplicated in the bundle. This was due to the fact that we had a `react/hooks` entrypoint that imported these files along with the newly introduced `createQueryPreloader` function, which lived outside of the `react/hooks` folder.
+
 ## 3.9.0-beta.0
 
 ### Minor Changes

package/apollo-client.cjs

@@ -13,6 +13,7 @@ var optimism = require('optimism');
 var trie = require('@wry/trie');
 var graphqlTag = require('graphql-tag');
 var React = require('rehackt');
+var React$1 = require('react');
 
 function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e["default"] : e; }
 
@@ -30,8 +31,9 @@ function _interopNamespace(e) {
 
 var equal__default = /*#__PURE__*/_interopDefaultLegacy(equal);
 var React__namespace = /*#__PURE__*/_interopNamespace(React);
+var React__namespace$1 = /*#__PURE__*/_interopNamespace(React$1);
 
-var version = "3.9.0-beta.0";
+var version = "3.9.0-rc.0";
 
 function maybe(thunk) {
     try {
@@ -320,8 +322,8 @@ function getCurrentCacheSizes() {
         "cache.fragmentQueryDocuments": 1000 ,
         "removeTypenameFromVariables.getVariableDefinitions": 2000 ,
         "inMemoryCache.maybeBroadcastWatch": 5000 ,
-        "inMemoryCache.executeSelectionSet": 10000 ,
-        "inMemoryCache.executeSubSelectedArray": 5000 ,
+        "inMemoryCache.executeSelectionSet": 50000 ,
+        "inMemoryCache.executeSubSelectedArray": 10000 ,
     };
     return Object.fromEntries(Object.entries(defaults).map(function (_a) {
         var k = _a[0], v = _a[1];
@@ -2067,9 +2069,6 @@ function parseAndCheckHttpResponse(operations) {
             .text()
             .then(function (bodyText) { return parseJsonBody(response, bodyText); })
             .then(function (result) {
-            if (response.status >= 300) {
-                throwServerError(response, result, "Response not successful: Received status code ".concat(response.status));
-            }
             if (!Array.isArray(result) &&
                 !hasOwnProperty$3.call(result, "data") &&
                 !hasOwnProperty$3.call(result, "errors")) {
@@ -3202,7 +3201,7 @@ var StoreReader =  (function () {
         }, {
             max: this.config.resultCacheMaxSize ||
                 cacheSizes["inMemoryCache.executeSelectionSet"] ||
-                10000 ,
+                50000 ,
             keyArgs: execSelectionSetKeyArgs,
             makeCacheKey: function (selectionSet, parent, context, canonizeResults) {
                 if (supportsResultCaching(context.store)) {
@@ -3216,7 +3215,7 @@ var StoreReader =  (function () {
         }, {
             max: this.config.resultCacheMaxSize ||
                 cacheSizes["inMemoryCache.executeSubSelectedArray"] ||
-                5000 ,
+                10000 ,
             makeCacheKey: function (_a) {
                 var field = _a.field, array = _a.array, context = _a.context;
                 if (supportsResultCaching(context.store)) {
@@ -5294,12 +5293,16 @@ var ObservableQuery =  (function (_super) {
         var _a = this.fetch(options, newNetworkStatus, query), concast = _a.concast, fromLink = _a.fromLink;
         var observer = {
             next: function (result) {
-                finishWaitingForOwnResult();
-                _this.reportResult(result, variables);
+                if (equal.equal(_this.variables, variables)) {
+                    finishWaitingForOwnResult();
+                    _this.reportResult(result, variables);
+                }
             },
             error: function (error) {
-                finishWaitingForOwnResult();
-                _this.reportError(error, variables);
+                if (equal.equal(_this.variables, variables)) {
+                    finishWaitingForOwnResult();
+                    _this.reportError(error, variables);
+                }
             },
         };
         if (!useDisposableConcast && (fromLink || !this.concast)) {
@@ -7975,44 +7978,6 @@ function useReactiveVar(rv) {
     }, [rv]), rv, rv);
 }
 
-function useFragment(options) {
-    var cache = useApolloClient().cache;
-    var fragment = options.fragment, fragmentName = options.fragmentName, from = options.from, _a = options.optimistic, optimistic = _a === void 0 ? true : _a, rest = tslib.__rest(options, ["fragment", "fragmentName", "from", "optimistic"]);
-    var diffOptions = tslib.__assign(tslib.__assign({}, rest), { returnPartialData: true, id: typeof from === "string" ? from : cache.identify(from), query: cache["getFragmentDoc"](fragment, fragmentName), optimistic: optimistic });
-    var resultRef = React__namespace.useRef();
-    var latestDiff = cache.diff(diffOptions);
-    var getSnapshot = function () {
-        var latestDiffToResult = diffToResult(latestDiff);
-        return (resultRef.current &&
-            equal.equal(resultRef.current.data, latestDiffToResult.data)) ?
-            resultRef.current
-            : (resultRef.current = latestDiffToResult);
-    };
-    return useSyncExternalStore(function (forceUpdate) {
-        var lastTimeout = 0;
-        var unsubcribe = cache.watch(tslib.__assign(tslib.__assign({}, diffOptions), { immediate: true, callback: function (diff) {
-                if (!equal.equal(diff, latestDiff)) {
-                    resultRef.current = diffToResult((latestDiff = diff));
-                    lastTimeout = setTimeout(forceUpdate);
-                }
-            } }));
-        return function () {
-            unsubcribe();
-            clearTimeout(lastTimeout);
-        };
-    }, getSnapshot, getSnapshot);
-}
-function diffToResult(diff) {
-    var result = {
-        data: diff.result,
-        complete: !!diff.complete,
-    };
-    if (diff.missing) {
-        result.missing = mergeDeepArray(diff.missing.map(function (error) { return error.missing; }));
-    }
-    return result;
-}
-
 function useDeepMemo(memoFn, deps) {
     var ref = React__namespace.useRef();
     if (!ref.current || !equal.equal(ref.current.deps, deps)) {
@@ -8033,6 +7998,15 @@ function useRenderGuard() {
     }, []);
 }
 
+var INIT = {};
+function useLazyRef(getInitialValue) {
+    var ref = React__namespace$1.useRef(INIT);
+    if (ref.current === INIT) {
+        ref.current = getInitialValue();
+    }
+    return ref;
+}
+
 var useKey = "use";
 var realHook = React__namespace[useKey];
 var __use = realHook ||
@@ -8048,6 +8022,42 @@ var __use = realHook ||
         }
     };
 
+function useFragment(options) {
+    var cache = useApolloClient().cache;
+    var diffOptions = useDeepMemo(function () {
+        var fragment = options.fragment, fragmentName = options.fragmentName, from = options.from, _a = options.optimistic, optimistic = _a === void 0 ? true : _a, rest = tslib.__rest(options, ["fragment", "fragmentName", "from", "optimistic"]);
+        return tslib.__assign(tslib.__assign({}, rest), { returnPartialData: true, id: typeof from === "string" ? from : cache.identify(from), query: cache["getFragmentDoc"](fragment, fragmentName), optimistic: optimistic });
+    }, [options]);
+    var resultRef = useLazyRef(function () {
+        return diffToResult(cache.diff(diffOptions));
+    });
+    var getSnapshot = React__namespace.useCallback(function () { return resultRef.current; }, []);
+    return useSyncExternalStore(React__namespace.useCallback(function (forceUpdate) {
+        var lastTimeout = 0;
+        var unsubscribe = cache.watch(tslib.__assign(tslib.__assign({}, diffOptions), { immediate: true, callback: function (diff) {
+                if (!equal.equal(diff.result, resultRef.current.data)) {
+                    resultRef.current = diffToResult(diff);
+                    clearTimeout(lastTimeout);
+                    lastTimeout = setTimeout(forceUpdate);
+                }
+            } }));
+        return function () {
+            unsubscribe();
+            clearTimeout(lastTimeout);
+        };
+    }, [cache, diffOptions]), getSnapshot, getSnapshot);
+}
+function diffToResult(diff) {
+    var result = {
+        data: diff.result,
+        complete: !!diff.complete,
+    };
+    if (diff.missing) {
+        result.missing = mergeDeepArray(diff.missing.map(function (error) { return error.missing; }));
+    }
+    return result;
+}
+
 var QUERY_REFERENCE_SYMBOL = Symbol();
 var PROMISE_SYMBOL = Symbol();
 function wrapQueryRef(internalQueryRef) {
@@ -8458,7 +8468,6 @@ function useBackgroundQuery(query, options) {
         var promise = queryRef.applyOptions(watchQueryOptions);
         updateWrappedQueryRef(wrappedQueryRef, promise);
     }
-    React__namespace.useEffect(function () { return queryRef.retain(); }, [queryRef]);
     var fetchMore = React__namespace.useCallback(function (options) {
         var promise = queryRef.fetchMore(options);
         setWrappedQueryRef(wrapQueryRef(queryRef));
@@ -8488,7 +8497,6 @@ function useLoadableQuery(query, options) {
         updateWrappedQueryRef(queryRef, promise);
     }
     var calledDuringRender = useRenderGuard();
-    React__namespace.useEffect(function () { return internalQueryRef === null || internalQueryRef === void 0 ? void 0 : internalQueryRef.retain(); }, [internalQueryRef]);
     var fetchMore = React__namespace.useCallback(function (options) {
         if (!internalQueryRef) {
             throw new Error("The query has not been loaded. Please load the query.");