@apollo/client 3.12.0-rc.0 → 3.12.0-rc.1

package/.changeset/brown-readers-smash.md

@@ -0,0 +1,5 @@
+---
+"@apollo/client": patch
+---
+
+Maintain the existing document if its unchanged by the codemod and move to more naive whitespace formatting

package/.changeset/gorgeous-zebras-confess.md

@@ -0,0 +1,5 @@
+---
+"@apollo/client": patch
+---
+
+Fix issue where data went missing when an unmasked fragment in migrate mode selected fields that the parent did not.

package/.changeset/long-zoos-ring.md

@@ -0,0 +1,5 @@
+---
+"@apollo/client": minor
+---
+
+Allow `null` as a valid `from` value in `useFragment`.

package/.changeset/nice-countries-share.md

@@ -0,0 +1,5 @@
+---
+"@apollo/client": patch
+---
+
+Fix error thrown when applying unmask migrate mode warnings on interface types with selection sets that contain inline fragment conditions.

package/.changeset/pre.json

@@ -5,11 +5,17 @@
     "@apollo/client": "3.11.5"
   },
   "changesets": [
+    "brown-readers-smash",
     "cold-apes-bow",
     "early-bobcats-eat",
     "flat-beans-knock",
+    "gorgeous-zebras-confess",
     "kind-toys-tie",
+    "long-zoos-ring",
     "nasty-camels-pay",
-    "nervous-owls-hear"
+    "nervous-owls-hear",
+    "nice-countries-share",
+    "slimy-points-end",
+    "small-bears-confess"
   ]
 }

package/.changeset/slimy-points-end.md

@@ -0,0 +1,5 @@
+---
+"@apollo/client": patch
+---
+
+Ensure documents unchanged by the codemod are left untouched.

package/.changeset/small-bears-confess.md

@@ -0,0 +1,5 @@
+---
+"@apollo/client": patch
+---
+
+Ensure `null` is retained in nullable types when unmasking a type with the `Unmasked` helper type.

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @apollo/client
 
+## 3.12.0-rc.1
+
+### Minor Changes
+
+- [#12131](https://github.com/apollographql/apollo-client/pull/12131) [`21c3f08`](https://github.com/apollographql/apollo-client/commit/21c3f083013445707b7b50ae6390318bc568d0f5) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Allow `null` as a valid `from` value in `useFragment`.
+
+### Patch Changes
+
+- [#12126](https://github.com/apollographql/apollo-client/pull/12126) [`d10d702`](https://github.com/apollographql/apollo-client/commit/d10d702ee9bd4d1d1dee2551821140f2c49d5c0c) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Maintain the existing document if its unchanged by the codemod and move to more naive whitespace formatting
+
+- [#12134](https://github.com/apollographql/apollo-client/pull/12134) [`cfaf4ef`](https://github.com/apollographql/apollo-client/commit/cfaf4efc6dea56ae46a5b5199d8ed9414b0f17d8) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Fix issue where data went missing when an unmasked fragment in migrate mode selected fields that the parent did not.
+
+- [#12130](https://github.com/apollographql/apollo-client/pull/12130) [`1e7d009`](https://github.com/apollographql/apollo-client/commit/1e7d009e4a52949dab0065f3219dfe148837531e) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Fix error thrown when applying unmask migrate mode warnings on interface types with selection sets that contain inline fragment conditions.
+
+- [#12126](https://github.com/apollographql/apollo-client/pull/12126) [`d10d702`](https://github.com/apollographql/apollo-client/commit/d10d702ee9bd4d1d1dee2551821140f2c49d5c0c) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Ensure documents unchanged by the codemod are left untouched.
+
+- [#12133](https://github.com/apollographql/apollo-client/pull/12133) [`a6ece37`](https://github.com/apollographql/apollo-client/commit/a6ece375119ce12c19749471c55b0059843a7217) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Ensure `null` is retained in nullable types when unmasking a type with the `Unmasked` helper type.
+
 ## 3.12.0-rc.0
 
 ### Patch Changes

package/apollo-client.cjs

@@ -31,7 +31,7 @@ function _interopNamespace(e) {
 var equal__default = /*#__PURE__*/_interopDefaultLegacy(equal);
 var React__namespace = /*#__PURE__*/_interopNamespace(React);
 
-var version = "3.12.0-rc.0";
+var version = "3.12.0-rc.1";
 
 function maybe(thunk) {
     try {
@@ -2602,7 +2602,10 @@ function maskSelectionSet(data, selectionSet, context, path) {
         });
         return [changed_1 ? masked : data, changed_1];
     }
-    var result = selectionSet.selections.reduce(function (_a, selection) {
+    var result = selectionSet.selections
+        .concat()
+        .sort(sortFragmentsLast)
+        .reduce(function (_a, selection) {
         var memo = _a[0], changed = _a[1];
         switch (selection.kind) {
             case graphql.Kind.FIELD: {
@@ -2612,7 +2615,9 @@ function maskSelectionSet(data, selectionSet, context, path) {
                 if (memo[keyName] === void 0) {
                     delete memo[keyName];
                 }
-                if (keyName in memo && childSelectionSet && data[keyName] !== null) {
+                if (keyName in memo &&
+                    childSelectionSet &&
+                    data[keyName] !== null) {
                     var _b = maskSelectionSet(data[keyName], childSelectionSet, context, globalThis.__DEV__ !== false ? "".concat(path || "", ".").concat(keyName) : void 0), masked = _b[0], childChanged = _b[1];
                     if (childChanged ||
                         Object.keys(masked).length !== Object.keys(data[keyName]).length) {
@@ -2667,20 +2672,29 @@ function addFieldAccessorWarnings(memo, data, selectionSetNode, path, context) {
             return addFieldAccessorWarnings(memo[index] || Object.create(null), item, selectionSetNode, "".concat(path, "[").concat(index, "]"), context);
         });
     }
-    return selectionSetNode.selections.reduce(function (memo, selection) {
+    return selectionSetNode.selections
+        .concat()
+        .sort(sortFragmentsLast)
+        .reduce(function (memo, selection) {
         switch (selection.kind) {
             case graphql.Kind.FIELD: {
                 var keyName = resultKeyNameFromField(selection);
                 var childSelectionSet = selection.selectionSet;
-                if (keyName in memo) {
+                if (keyName in memo && !childSelectionSet) {
                     return memo;
                 }
                 var value = data[keyName];
                 if (childSelectionSet) {
-                    value = addFieldAccessorWarnings(memo[keyName] || Object.create(null), data[keyName], childSelectionSet, "".concat(path, ".").concat(keyName), context);
+                    value = addFieldAccessorWarnings(memo[keyName] ||
+                        (Array.isArray(data[keyName]) ? [] : Object.create(null)), data[keyName], childSelectionSet, "".concat(path, ".").concat(keyName), context);
                 }
                 if (globalThis.__DEV__ !== false) {
-                    addAccessorWarning(memo, value, keyName, path, context);
+                    if (keyName in memo) {
+                        memo[keyName] = value;
+                    }
+                    else {
+                        addAccessorWarning(memo, value, keyName, path, context);
+                    }
                 }
                 if (!(globalThis.__DEV__ !== false)) {
                     memo[keyName] = data[keyName];
@@ -2688,6 +2702,10 @@ function addFieldAccessorWarnings(memo, data, selectionSetNode, path, context) {
                 return memo;
             }
             case graphql.Kind.INLINE_FRAGMENT: {
+                if (selection.typeCondition &&
+                    !context.cache.fragmentMatches(selection, data.__typename)) {
+                    return memo;
+                }
                 return addFieldAccessorWarnings(memo, data, selection.selectionSet, path, context);
             }
             case graphql.Kind.FRAGMENT_SPREAD: {
@@ -2737,6 +2755,12 @@ function warnOnImproperCacheImplementation() {
         globalThis.__DEV__ !== false && invariant.warn(43);
     }
 }
+function sortFragmentsLast(a, b) {
+    if (a.kind === b.kind) {
+        return 0;
+    }
+    return a.kind === graphql.Kind.FRAGMENT_SPREAD ? 1 : -1;
+}
 
 var ApolloCache =  (function () {
     function ApolloCache() {
@@ -8566,10 +8590,22 @@ function _useFragment(options) {
     var client = useApolloClient(options.client);
     var cache = client.cache;
     var from = options.from, rest = tslib.__rest(options, ["from"]);
-    var id = React__namespace.useMemo(function () { return (typeof from === "string" ? from : cache.identify(from)); }, [cache, from]);
+    var id = React__namespace.useMemo(function () {
+        return typeof from === "string" ? from
+            : from === null ? null
+                : cache.identify(from);
+    }, [cache, from]);
     var stableOptions = useDeepMemo(function () { return (tslib.__assign(tslib.__assign({}, rest), { from: id })); }, [rest, id]);
     var diff = React__namespace.useMemo(function () {
         var fragment = stableOptions.fragment, fragmentName = stableOptions.fragmentName, from = stableOptions.from, _a = stableOptions.optimistic, optimistic = _a === void 0 ? true : _a;
+        if (from === null) {
+            return {
+                result: diffToResult({
+                    result: {},
+                    complete: false,
+                }),
+            };
+        }
         var cache = client.cache;
         var diff = cache.diff(tslib.__assign(tslib.__assign({}, stableOptions), { returnPartialData: true, id: from, query: cache["getFragmentDoc"](fragment, fragmentName), optimistic: optimistic }));
         return {
@@ -8583,17 +8619,19 @@ function _useFragment(options) {
     var getSnapshot = React__namespace.useCallback(function () { return diff.result; }, [diff]);
     return useSyncExternalStore(React__namespace.useCallback(function (forceUpdate) {
         var lastTimeout = 0;
-        var subscription = client.watchFragment(stableOptions).subscribe({
-            next: function (result) {
-                if (equal__default(result, diff.result))
-                    return;
-                diff.result = result;
-                clearTimeout(lastTimeout);
-                lastTimeout = setTimeout(forceUpdate);
-            },
-        });
+        var subscription = stableOptions.from === null ?
+            null
+            : client.watchFragment(stableOptions).subscribe({
+                next: function (result) {
+                    if (equal__default(result, diff.result))
+                        return;
+                    diff.result = result;
+                    clearTimeout(lastTimeout);
+                    lastTimeout = setTimeout(forceUpdate);
+                },
+            });
         return function () {
-            subscription.unsubscribe();
+            subscription === null || subscription === void 0 ? void 0 : subscription.unsubscribe();
             clearTimeout(lastTimeout);
         };
     }, [client, stableOptions, diff]), getSnapshot, getSnapshot);