@apollo/client 3.10.4 → 3.10.5

package/CHANGELOG.md

@@ -1,5 +1,30 @@
 # @apollo/client
 
+## 3.10.5
+
+### Patch Changes
+
+- [#11888](https://github.com/apollographql/apollo-client/pull/11888) [`7fb7939`](https://github.com/apollographql/apollo-client/commit/7fb7939edb7ca8f4273b75554f96ea9936731458) Thanks [@phryneas](https://github.com/phryneas)! - switch `useRenderGuard` to an approach not accessing React's internals
+
+- [#11511](https://github.com/apollographql/apollo-client/pull/11511) [`6536369`](https://github.com/apollographql/apollo-client/commit/6536369cf213469d20d15b779c344268d70fecd5) Thanks [@phryneas](https://github.com/phryneas)! - `useLoadableQuery`: ensure that `loadQuery` is updated if the ApolloClient instance changes
+
+- [#11860](https://github.com/apollographql/apollo-client/pull/11860) [`8740f19`](https://github.com/apollographql/apollo-client/commit/8740f198805a99e01136617c4055d611b92cc231) Thanks [@alessbell](https://github.com/alessbell)! - Fixes [#11849](https://github.com/apollographql/apollo-client/issues/11849) by reevaluating `window.fetch` each time `BatchHttpLink` uses it, if not configured via `options.fetch`. Takes the same approach as PR [#8603](https://github.com/apollographql/apollo-client/pull/8603) which fixed the same issue in `HttpLink`.
+
+- [#11852](https://github.com/apollographql/apollo-client/pull/11852) [`d502a69`](https://github.com/apollographql/apollo-client/commit/d502a69654d8ffa31e09467da028304a934a9874) Thanks [@phryneas](https://github.com/phryneas)! - Fix a bug where calling the `useMutation` `reset` function would point the hook to an outdated `client` reference.
+
+- [#11329](https://github.com/apollographql/apollo-client/pull/11329) [`3d164ea`](https://github.com/apollographql/apollo-client/commit/3d164ea16c17d271f6fa9e5ad8f013623eec23a0) Thanks [@PaLy](https://github.com/PaLy)! - Fix graphQLErrors in Error Link if networkError.result is an empty string
+
+- [#11852](https://github.com/apollographql/apollo-client/pull/11852) [`d502a69`](https://github.com/apollographql/apollo-client/commit/d502a69654d8ffa31e09467da028304a934a9874) Thanks [@phryneas](https://github.com/phryneas)! - Prevent writing to a ref in render in `useMutation`.
+  As a result, you might encounter problems in the future if you call the mutation's `execute` function during render. Please note that this was never supported behavior, and we strongly recommend against it.
+
+- [#11848](https://github.com/apollographql/apollo-client/pull/11848) [`ad63924`](https://github.com/apollographql/apollo-client/commit/ad6392424ddbeb6f91b165c806251490e1cdd69e) Thanks [@phryneas](https://github.com/phryneas)! - Ensure covariant behavior: `MockedResponse<X,Y>` should be assignable to `MockedResponse`
+
+- [#11851](https://github.com/apollographql/apollo-client/pull/11851) [`45c47be`](https://github.com/apollographql/apollo-client/commit/45c47be26d4e020cfcff359a5af19ccfc39b930e) Thanks [@phryneas](https://github.com/phryneas)! - Avoid usage of useRef in useInternalState to prevent ref access in render.
+
+- [#11877](https://github.com/apollographql/apollo-client/pull/11877) [`634d91a`](https://github.com/apollographql/apollo-client/commit/634d91aeb10ab308b05d5ffb918678806046af09) Thanks [@phryneas](https://github.com/phryneas)! - Add missing name to tuple member (fix TS5084)
+
+- [#11851](https://github.com/apollographql/apollo-client/pull/11851) [`45c47be`](https://github.com/apollographql/apollo-client/commit/45c47be26d4e020cfcff359a5af19ccfc39b930e) Thanks [@phryneas](https://github.com/phryneas)! - Fix a bug where `useLazyQuery` would not pick up a client change.
+
 ## 3.10.4
 
 ### Patch Changes

package/apollo-client.cjs

@@ -31,7 +31,7 @@ function _interopNamespace(e) {
 var equal__default = /*#__PURE__*/_interopDefaultLegacy(equal);
 var React__namespace = /*#__PURE__*/_interopNamespace(React);
 
-var version = "3.10.4";
+var version = "3.10.5";
 
 function maybe(thunk) {
     try {
@@ -7421,15 +7421,26 @@ function useDeepMemo(memoFn, deps) {
     return ref.current.value;
 }
 
-function getRenderDispatcher() {
-    var _a, _b;
-    return (_b = (_a = React__namespace.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED) === null || _a === void 0 ? void 0 : _a.ReactCurrentDispatcher) === null || _b === void 0 ? void 0 : _b.current;
-}
-var RenderDispatcher = null;
+var Ctx;
+function noop() { }
 function useRenderGuard() {
-    RenderDispatcher = getRenderDispatcher();
-    return React__namespace.useCallback(function () {
-        return (RenderDispatcher != null && RenderDispatcher === getRenderDispatcher());
+    if (!Ctx) {
+        Ctx = React__namespace.createContext(null);
+    }
+    return React__namespace.useCallback(
+ function () {
+        var orig = console.error;
+        try {
+            console.error = noop;
+            React__namespace["useContext" ](Ctx);
+            return true;
+        }
+        catch (e) {
+            return false;
+        }
+        finally {
+            console.error = orig;
+        }
     }, []);
 }
 
@@ -7474,14 +7485,16 @@ function _useQuery(query, options) {
     return useInternalState(useApolloClient(options.client), query).useQuery(options);
 }
 function useInternalState(client, query) {
-    var stateRef = React__namespace.useRef();
-    if (!stateRef.current ||
-        client !== stateRef.current.client ||
-        query !== stateRef.current.query) {
-        stateRef.current = new InternalState(client, query, stateRef.current);
-    }
-    var state = stateRef.current;
-    state.forceUpdateState = React__namespace.useReducer(function (tick) { return tick + 1; }, 0)[1];
+    var forceUpdateState = React__namespace.useReducer(function (tick) { return tick + 1; }, 0)[1];
+    function createInternalState(previous) {
+        return Object.assign(new InternalState(client, query, previous), {
+            forceUpdateState: forceUpdateState,
+        });
+    }
+    var _a = React__namespace.useState(createInternalState), state = _a[0], updateState = _a[1];
+    if (client !== state.client || query !== state.query) {
+        updateState((state = createInternalState(state)));
+    }
     return state;
 }
 var InternalState =  (function () {
@@ -7544,7 +7557,8 @@ var InternalState =  (function () {
         this.renderPromises = React__namespace.useContext(getApolloContext()).renderPromises;
         this.useOptions(options);
         var obsQuery = this.useObservableQuery();
-        var result = useSyncExternalStore(React__namespace.useCallback(function (handleStoreChange) {
+        var result = useSyncExternalStore(
+        React__namespace.useCallback(function (handleStoreChange) {
             if (_this.renderPromises) {
                 return function () { };
             }
@@ -7779,17 +7793,15 @@ function useLazyQuery(query, options) {
     var useQueryResult = internalState.useQuery(tslib.__assign(tslib.__assign({}, merged), { skip: !execOptionsRef.current }));
     var initialFetchPolicy = useQueryResult.observable.options.initialFetchPolicy ||
         internalState.getDefaultFetchPolicy();
-    var result = Object.assign(useQueryResult, {
-        called: !!execOptionsRef.current,
-    });
+    var forceUpdateState = internalState.forceUpdateState, obsQueryFields = internalState.obsQueryFields;
     var eagerMethods = React__namespace.useMemo(function () {
         var eagerMethods = {};
         var _loop_1 = function (key) {
-            var method = result[key];
+            var method = obsQueryFields[key];
             eagerMethods[key] = function () {
                 if (!execOptionsRef.current) {
                     execOptionsRef.current = Object.create(null);
-                    internalState.forceUpdateState();
+                    forceUpdateState();
                 }
                 return method.apply(this, arguments);
             };
@@ -7799,8 +7811,9 @@ function useLazyQuery(query, options) {
             _loop_1(key);
         }
         return eagerMethods;
-    }, []);
-    Object.assign(result, eagerMethods);
+    }, [forceUpdateState, obsQueryFields]);
+    var called = !!execOptionsRef.current;
+    var result = React__namespace.useMemo(function () { return (tslib.__assign(tslib.__assign(tslib.__assign({}, useQueryResult), eagerMethods), { called: called })); }, [useQueryResult, eagerMethods, called]);
     var execute = React__namespace.useCallback(function (executeOptions) {
         execOptionsRef.current =
             executeOptions ? tslib.__assign(tslib.__assign({}, executeOptions), { fetchPolicy: executeOptions.fetchPolicy || initialFetchPolicy }) : {
@@ -7812,7 +7825,7 @@ function useLazyQuery(query, options) {
             .then(function (queryResult) { return Object.assign(queryResult, eagerMethods); });
         promise.catch(function () { });
         return promise;
-    }, []);
+    }, [eagerMethods, initialFetchPolicy, internalState]);
     return [execute, result];
 }
 
@@ -7832,9 +7845,9 @@ function useMutation(mutation, options) {
         mutation: mutation,
         options: options,
     });
-    {
+    React__namespace.useLayoutEffect(function () {
         Object.assign(ref.current, { client: client, options: options, mutation: mutation });
-    }
+    });
     var execute = React__namespace.useCallback(function (executeOptions) {
         if (executeOptions === void 0) { executeOptions = {}; }
         var _a = ref.current, options = _a.options, mutation = _a.mutation;
@@ -7908,15 +7921,20 @@ function useMutation(mutation, options) {
     }, []);
     var reset = React__namespace.useCallback(function () {
         if (ref.current.isMounted) {
-            var result_3 = { called: false, loading: false, client: client };
+            var result_3 = {
+                called: false,
+                loading: false,
+                client: ref.current.client,
+            };
             Object.assign(ref.current, { mutationId: 0, result: result_3 });
             setResult(result_3);
         }
     }, []);
     React__namespace.useEffect(function () {
-        ref.current.isMounted = true;
+        var current = ref.current;
+        current.isMounted = true;
         return function () {
-            ref.current.isMounted = false;
+            current.isMounted = false;
         };
     }, []);
     return [execute, tslib.__assign({ reset: reset }, result)];
@@ -8469,11 +8487,11 @@ function _useSuspenseQuery(query, options) {
         };
     }, [queryRef.result]);
     var result = fetchPolicy === "standby" ? skipResult : __use(promise);
-    var fetchMore = React__namespace.useCallback((function (options) {
+    var fetchMore = React__namespace.useCallback(function (options) {
         var promise = queryRef.fetchMore(options);
         setPromise([queryRef.key, queryRef.promise]);
         return promise;
-    }), [queryRef]);
+    }, [queryRef]);
     var refetch = React__namespace.useCallback(function (variables) {
         var promise = queryRef.refetch(variables);
         setPromise([queryRef.key, queryRef.promise]);
@@ -8636,10 +8654,17 @@ function useLoadableQuery(query, options) {
             return client.watchQuery(tslib.__assign(tslib.__assign({}, watchQueryOptions), { variables: variables }));
         });
         setQueryRef(wrapQueryRef(queryRef));
-    }, [query, queryKey, suspenseCache, watchQueryOptions, calledDuringRender]);
+    }, [
+        query,
+        queryKey,
+        suspenseCache,
+        watchQueryOptions,
+        calledDuringRender,
+        client,
+    ]);
     var reset = React__namespace.useCallback(function () {
         setQueryRef(null);
-    }, [queryRef]);
+    }, []);
     return [loadQuery, queryRef, { fetchMore: fetchMore, refetch: refetch, reset: reset }];
 }
 
@@ -8694,7 +8719,7 @@ function _useReadQuery(queryRef) {
             updateWrappedQueryRef(queryRef, promise);
             forceUpdate();
         });
-    }, [internalQueryRef]), getPromise, getPromise);
+    }, [internalQueryRef, queryRef]), getPromise, getPromise);
     var result = __use(promise);
     return React__namespace.useMemo(function () {
         return {