@apolitical/server 2.3.2 → 2.3.3-rc.test.1

package/CHANGELOG.md

@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.3.3] - 2022-02-21
+### Changed
+- maging sure index.html is not considered as a static asset by the middleware loader
+
 ## [2.3.2] - 2022-02-21
 ### Changed
 - loading static files middleware after the app has been loaded

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@apolitical/server",
-  "version": "2.3.2",
+  "version": "2.3.3-rc.test.1",
   "description": "Node.js module to encapsulate Apolitical's express server setup",
   "author": "Apolitical Group Limited <engineering@apolitical.co>",
   "license": "MIT",

package/src/container.js

@@ -35,7 +35,6 @@ const jwtPassportHelper = require('./helpers/jwt/passport.helper');
 const documentationLoader = require('./loaders/documentation.loader');
 const loggerLoader = require('./loaders/logger.loader');
 const middlewaresLoader = require('./loaders/middlewares.loader');
-const staticLoader = require('./loaders/static.loader');
 const probesLoader = require('./loaders/probes.loader');
 const fallbackLoader = require('./loaders/fallback.loader');
 // Middleware
@@ -85,7 +84,6 @@ container.register({
   documentationLoader: asFunction(documentationLoader).singleton(),
   loggerLoader: asFunction(loggerLoader).singleton(),
   middlewaresLoader: asFunction(middlewaresLoader).singleton(),
-  staticLoader: asFunction(staticLoader).singleton(),
   probesLoader: asFunction(probesLoader).singleton(),
   fallbackLoader: asFunction(fallbackLoader).singleton(),
   // Middlewares

package/src/loaders/middlewares.loader.js

@@ -1,12 +1,21 @@
 'use strict';
 
-module.exports = ({ bodyParser: { json, urlencoded }, compression, cors, cookieParser, prerender, config, logger }) => {
+module.exports = ({
+  bodyParser: { json, urlencoded },
+  express,
+  compression,
+  cors,
+  cookieParser,
+  prerender,
+  config,
+  logger,
+}) => {
   const {
     BODY_PARSER_OPTIONS: { JSON_OPTIONS, URL_ENCODED_OPTIONS },
     CORS_OPTIONS,
   } = config.SERVER;
 
-  return function load(app, { corsOptions, prerenderToken }) {
+  return function load(app, { corsOptions, prerenderToken, staticFiles }) {
     const childLogger = logger.where(__filename, 'load');
     childLogger.debug('Started');
     // Load useful middlewares
@@ -18,6 +27,10 @@ module.exports = ({ bodyParser: { json, urlencoded }, compression, cors, cookieP
     if (prerenderToken) {
       app.use(prerender.set('prerenderToken', prerenderToken));
     }
+    if (staticFiles) {
+      const { baseUrl, folderPath } = staticFiles;
+      app.use(baseUrl, express.static(folderPath, { index: false }));
+    }
     childLogger.debug('Finished');
   };
 };

package/src/services/server.service.js

@@ -10,7 +10,6 @@ module.exports = ({
   authorisationMiddleware,
   errorMiddleware,
   middlewaresLoader,
-  staticLoader,
   probesLoader,
   fallbackLoader,
   jwtService,
@@ -51,8 +50,6 @@ module.exports = ({
       if (opts.appLoader) {
         await opts.appLoader(app);
       }
-      // Load static files middleware
-      staticLoader(app, opts);
       // Load documentation
       documentationLoader(app, opts);
       // Load fallback routing

package/src/loaders/static.loader.js

@@ -1,14 +0,0 @@
-'use strict';
-
-module.exports = ({ express, logger }) => {
-  return function load(app, { staticFiles }) {
-    const childLogger = logger.where(__filename, 'load');
-    childLogger.debug('Started');
-
-    if (staticFiles) {
-      const { baseUrl, folderPath } = staticFiles;
-      app.use(baseUrl, express.static(folderPath));
-    }
-    childLogger.debug('Finished');
-  };
-};