@apocaliss92/scrypted-reolink-native 0.5.4 → 0.5.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@apocaliss92/scrypted-reolink-native",
-  "version": "0.5.4",
+  "version": "0.5.6",
   "description": "Use any reolink camera with Scrypted, even older/unsupported models without HTTP protocol support",
   "author": "@apocaliss92",
   "license": "Apache",

package/src/accessories/siren.ts

@@ -26,8 +26,6 @@ export class ReolinkCameraSiren extends ScryptedDeviceBase implements OnOff {
       await this.camera.withBaichuanRetry(async () => {
         const api = await this.camera.ensureClient();
         await api.setSiren(channel, false);
-        const sirenState = await api.getSiren(channel);
-        this.on = sirenState.enabled;
       });
       this.logger.log(`Siren toggle: turnOff ok (device=${this.nativeId})`);
     } catch (e: any) {
@@ -48,11 +46,10 @@ export class ReolinkCameraSiren extends ScryptedDeviceBase implements OnOff {
       await this.camera.withBaichuanRetry(async () => {
         const api = await this.camera.ensureClient();
         await api.setSiren(channel, true);
-        const sirenState = await api.getSiren(channel);
-        this.on = sirenState.enabled;
       });
       this.logger.log(`Siren toggle: turnOn ok (device=${this.nativeId})`);
     } catch (e: any) {
+      this.on = false;
       this.logger.error(
         `Siren toggle: turnOn failed (device=${this.nativeId})`,
         e?.message || String(e),

package/src/camera.ts

@@ -2787,19 +2787,10 @@ export class ReolinkCamera
       }
     }
 
-    // Align siren state (direct control)
-    if (hasSiren && this.siren) {
-      if (isInCooldown(this.auxDeviceCooldowns.siren)) {
-        logger.log(`[alignAuxDevicesState] Skipping siren (in cooldown)`);
-      } else {
-        try {
-          const sirenState = await api.getSiren(channel);
-          this.siren.on = sirenState.enabled;
-        } catch (e) {
-          logger.warn("Failed to align siren state", e?.message || String(e));
-        }
-      }
-    }
+    // Siren direct control: state is managed manually by turnOn/turnOff.
+    // The camera reports siren as "off" immediately after triggering (fire-and-forget),
+    // so polling would always reset the switch to OFF. We skip alignment entirely
+    // and let the user control the switch: ON triggers the siren, OFF stops it.
 
     // Align motion-floodlight state
     if (hasFloodlight && this.motionFloodlight) {