@apocaliss92/scrypted-reolink-native 0.5.19 → 0.5.21

package/src/main.ts

@@ -11,16 +11,16 @@ if (typeof globalThis.File === "undefined") {
   };
 }
 
-import type { AutoDetectMode, ReolinkBaichuanApi, DiscoveredDevice as LibDiscoveredDevice, AutodiscoveryClient } from "@apocaliss92/nodelink-js" with {
-  "resolution-mode": "import"
+import type {
+  AutoDetectMode,
+  ReolinkBaichuanApi,
+} from "@apocaliss92/nodelink-js" with {
+  "resolution-mode": "import",
 };
 import sdk, {
-  AdoptDevice,
   DeviceCreator,
   DeviceCreatorSettings,
-  DeviceDiscovery,
   DeviceProvider,
-  DiscoveredDevice,
   HttpRequest,
   HttpResponse,
   ScryptedDeviceBase,
@@ -28,15 +28,23 @@ import sdk, {
   ScryptedInterface,
   ScryptedNativeId,
   Setting,
-  Settings
+  Settings,
 } from "@scrypted/sdk";
 import { randomBytes } from "crypto";
 import { BaseBaichuanClass } from "./baichuan-base";
 import { ReolinkCamera } from "./camera";
-import { createBaichuanApi, normalizeUid, type BaichuanTransport } from "./connect";
 import {
-  ReolinkNativeIntercom,
+  createBaichuanApi,
+  normalizeUid,
+  type BaichuanTransport,
+} from "./connect";
+import {
+  EMAIL_PUSH_SERVER_NATIVE_ID,
+  EmailPushServerDevice,
+} from "./email-push-server-device";
+import {
   INTERCOM_PROVIDER_NATIVE_ID,
+  ReolinkNativeIntercom,
 } from "./intercom-provider";
 import { ReolinkNativeMultiFocalDevice } from "./multiFocal";
 import { ReolinkNativeNvrDevice } from "./nvr";
@@ -54,14 +62,22 @@ import {
 
 class ReolinkNativePlugin
   extends ScryptedDeviceBase
-  implements DeviceProvider, DeviceCreator, DeviceDiscovery, Settings {
+  implements DeviceProvider, DeviceCreator, Settings
+{
   devices = new Map<string, BaseBaichuanClass>();
   camerasMap = new Map<string, ReolinkCamera>();
   nvrDeviceId: string;
   private intercomProvider?: ReolinkNativeIntercom;
-  private networkDiscoveredDevices = new Map<string, { discovered: DiscoveredDevice; libDevice: LibDiscoveredDevice }>();
-  private discoverDevicesPromise: Promise<DiscoveredDevice[]> | undefined;
-  private autodiscoveryClient: AutodiscoveryClient | undefined;
+  // Public so `ReolinkCamera` can call the device's
+  // `getManagerSetupParamsForCamera()` when the user clicks
+  // "Auto-configure from Email Push Server" on the camera page.
+  // May be undefined until `getDevice(EMAIL_PUSH_SERVER_NATIVE_ID)`
+  // is invoked at least once — callers materialise it via
+  // `await plugin.getDevice(EMAIL_PUSH_SERVER_NATIVE_ID)`.
+  emailPushServer?: EmailPushServerDevice;
+  // private networkDiscoveredDevices = new Map<string, { discovered: DiscoveredDevice; libDevice: LibDiscoveredDevice }>();
+  // private discoverDevicesPromise: Promise<DiscoveredDevice[]> | undefined;
+  // private autodiscoveryClient: AutodiscoveryClient | undefined;
 
   // Shared Baichuan API connections for external devices (non-Reolink Native cameras).
   // Keyed by Scrypted device ID. Multiple mixins on the same device share one connection.
@@ -85,58 +101,66 @@ class ReolinkNativePlugin
       providerNativeId: this.nativeId,
     });
 
-    // Start background autodiscovery
-    this.startBackgroundDiscovery();
-  }
-
-  private async startBackgroundDiscovery() {
-    const { AutodiscoveryClient: AutodiscoveryClientClass } = await import("@apocaliss92/nodelink-js");
-
-    // Stop previous client if settings changed
-    this.autodiscoveryClient?.stop();
-
-    const methods: string[] = JSON.parse(this.storage.getItem("discoveryMethods") || '["arp","onvif"]');
-    const subnetsRaw = this.storage.getItem("discoverySubnets") || "";
-    const subnets = subnetsRaw.split(",").map((s: string) => s.trim()).filter(Boolean);
-
-    this.autodiscoveryClient = new AutodiscoveryClientClass({
-      enableHttpScanning: methods.includes("http"),
-      enableUdpDiscovery: methods.includes("udp"),
-      enableTcpPortScan: methods.includes("tcp"),
-      enableArpLookup: methods.includes("arp"),
-      enableDhcpListener: methods.includes("dhcp"),
-      enableOnvifDiscovery: methods.includes("onvif"),
-      logger: this.console,
-      httpProbeTimeoutMs: 3000,
-      udpBroadcastTimeoutMs: 5000,
-      tcpProbeTimeoutMs: 1500,
-      dhcpListenerTimeoutMs: 10000,
-      scanIntervalMs: 120_000, // 2 minutes
-      autoStart: true,
-      ...(subnets.length > 0 ? { networkCidr: subnets[0] } : {}),
-      onDeviceDiscovered: (libDevice) => {
-        this.handleBackgroundDiscovery(libDevice);
-      },
+    sdk.deviceManager.onDeviceDiscovered({
+      nativeId: EMAIL_PUSH_SERVER_NATIVE_ID,
+      name: "Reolink E-mail Push Server",
+      interfaces: [ScryptedInterface.Settings, ScryptedInterface.Online],
+      type: ScryptedDeviceType.API,
+      providerNativeId: this.nativeId,
     });
-  }
-
-  private handleBackgroundDiscovery(libDevice: LibDiscoveredDevice) {
-    const existingIps = this.getExistingDeviceIps();
-    if (existingIps.has(libDevice.host)) return;
-
-    const nativeId = `discovered-${libDevice.host}`;
-    if (this.networkDiscoveredDevices.has(nativeId)) return;
-
-    this.addToDiscoveryList(libDevice);
-    this.console.log(`[Discovery] Background: new device ${libDevice.host} (${libDevice.name || libDevice.model || "unknown"})`);
 
-    // Notify Scrypted of updated discovery list
-    this.onDeviceEvent(
-      ScryptedInterface.DeviceDiscovery,
-      [...this.networkDiscoveredDevices.values()].map((d) => d.discovered),
-    );
+    // Start background autodiscovery
+    // this.startBackgroundDiscovery();
   }
 
+  // private async startBackgroundDiscovery() {
+  //   const { AutodiscoveryClient: AutodiscoveryClientClass } = await import("@apocaliss92/nodelink-js");
+
+  //   // Stop previous client if settings changed
+  //   this.autodiscoveryClient?.stop();
+
+  //   const methods: string[] = JSON.parse(this.storage.getItem("discoveryMethods") || '["arp","onvif"]');
+  //   const subnetsRaw = this.storage.getItem("discoverySubnets") || "";
+  //   const subnets = subnetsRaw.split(",").map((s: string) => s.trim()).filter(Boolean);
+
+  //   this.autodiscoveryClient = new AutodiscoveryClientClass({
+  //     enableHttpScanning: methods.includes("http"),
+  //     enableUdpDiscovery: methods.includes("udp"),
+  //     enableTcpPortScan: methods.includes("tcp"),
+  //     enableArpLookup: methods.includes("arp"),
+  //     enableDhcpListener: methods.includes("dhcp"),
+  //     enableOnvifDiscovery: methods.includes("onvif"),
+  //     logger: this.console,
+  //     httpProbeTimeoutMs: 3000,
+  //     udpBroadcastTimeoutMs: 5000,
+  //     tcpProbeTimeoutMs: 1500,
+  //     dhcpListenerTimeoutMs: 10000,
+  //     scanIntervalMs: 120_000, // 2 minutes
+  //     autoStart: true,
+  //     ...(subnets.length > 0 ? { networkCidr: subnets[0] } : {}),
+  //     onDeviceDiscovered: (libDevice) => {
+  //       this.handleBackgroundDiscovery(libDevice);
+  //     },
+  //   });
+  // }
+
+  // private handleBackgroundDiscovery(libDevice: LibDiscoveredDevice) {
+  //   const existingIps = this.getExistingDeviceIps();
+  //   if (existingIps.has(libDevice.host)) return;
+
+  //   const nativeId = `discovered-${libDevice.host}`;
+  //   if (this.networkDiscoveredDevices.has(nativeId)) return;
+
+  //   this.addToDiscoveryList(libDevice);
+  //   this.console.log(`[Discovery] Background: new device ${libDevice.host} (${libDevice.name || libDevice.model || "unknown"})`);
+
+  //   // Notify Scrypted of updated discovery list
+  //   this.onDeviceEvent(
+  //     ScryptedInterface.DeviceDiscovery,
+  //     [...this.networkDiscoveredDevices.values()].map((d) => d.discovered),
+  //   );
+  // }
+
   async acquireExternalClient(
     deviceId: string,
     config: {
@@ -198,6 +222,20 @@ class ReolinkNativePlugin
       return this.intercomProvider;
     }
 
+    if (nativeId === EMAIL_PUSH_SERVER_NATIVE_ID) {
+      if (!this.emailPushServer) {
+        this.emailPushServer = new EmailPushServerDevice(nativeId);
+        this.emailPushServer.plugin = this;
+        // Fire-and-forget: starts the SMTP server if enabled in storage.
+        void this.emailPushServer.start().catch((e: unknown) => {
+          this.console.error(
+            `Email push server start failed: ${e instanceof Error ? e.message : e}`,
+          );
+        });
+      }
+      return this.emailPushServer;
+    }
+
     if (this.devices.has(nativeId)) {
       return this.devices.get(nativeId)!;
     }
@@ -229,8 +267,7 @@ class ReolinkNativePlugin
     this.console.log(
       `[AutoDetect] Starting device type detection for ${ipAddress}...${forceType ? ` (forcing type: ${forceType})` : ""}`,
     );
-    const { autoDetectDeviceType } =
-      await import("@apocaliss92/nodelink-js");
+    const { autoDetectDeviceType } = await import("@apocaliss92/nodelink-js");
     // 'Auto', 'NVR', 'Battery Camera', 'Regular Camera
     const mode: AutoDetectMode =
       forceType === "Auto"
@@ -426,8 +463,8 @@ class ReolinkNativePlugin
   private getExistingDeviceIps(): Set<string> {
     const ips = new Set<string>();
     for (const [, device] of this.devices) {
-        const ip = (device as any).storageSettings?.values?.ipAddress;
-        if (ip) ips.add(ip);
+      const ip = (device as any).storageSettings?.values?.ipAddress;
+      if (ip) ips.add(ip);
     }
     // Also check storage for devices not yet instantiated
     const nativeIds = sdk.deviceManager.getNativeIds().filter((nid) => !!nid);
@@ -443,133 +480,136 @@ class ReolinkNativePlugin
     return ips;
   }
 
-  async discoverDevices(scan?: boolean): Promise<DiscoveredDevice[]> {
-    if (scan) {
-      if (this.discoverDevicesPromise) {
-        return await this.discoverDevicesPromise;
-      }
-      this.discoverDevicesPromise = (async () => {
-        try {
-          // Trigger immediate scan on the background client
-          if (this.autodiscoveryClient) {
-            await this.autodiscoveryClient.scanNow();
-          }
-
-          // Rebuild the discovery list from the client's cumulative results
-          this.rebuildDiscoveryList();
-
-          return [...this.networkDiscoveredDevices.values()].map((d) => d.discovered);
-        } catch (e: any) {
-          this.console.error(`[Discovery] Scan failed: ${e?.message || String(e)}`);
-          return [];
-        } finally {
-          this.discoverDevicesPromise = undefined;
-        }
-      })();
-      return await this.discoverDevicesPromise;
-    }
-
-    // No scan: return cached results
-    return [...this.networkDiscoveredDevices.values()].map((d) => d.discovered);
-  }
-
-  private rebuildDiscoveryList() {
-    const existingIps = this.getExistingDeviceIps();
-    const allDevices = this.autodiscoveryClient?.getDiscoveredDevices() ?? [];
-    this.networkDiscoveredDevices.clear();
-
-    for (const libDevice of allDevices) {
-      const alreadyAdded = existingIps.has(libDevice.host);
-      this.console.log(`[Discovery] Found ${libDevice.host} (${libDevice.name || libDevice.model || "unknown"})${alreadyAdded ? " — already added, skipping" : ""}`);
-      if (alreadyAdded) continue;
-      this.addToDiscoveryList(libDevice);
-    }
-
-    this.console.log(`[Discovery] ${this.networkDiscoveredDevices.size} new device(s), ${existingIps.size} already added`);
-  }
-
-  private addToDiscoveryList(libDevice: LibDiscoveredDevice) {
-    const nativeId = `discovered-${libDevice.host}`;
-    const name = libDevice.name || libDevice.model || `Reolink ${libDevice.host}`;
-    const descParts: string[] = [libDevice.host];
-    if (libDevice.model) descParts.push(libDevice.model);
-    if (libDevice.uid) descParts.push(`UID: ${libDevice.uid}`);
-
-    const discovered: DiscoveredDevice = {
-      nativeId,
-      name,
-      description: descParts.join(" — "),
-      type: ScryptedDeviceType.Camera,
-      settings: [
-        { key: "username", title: "Username", value: "admin" },
-        { key: "password", title: "Password", type: "password" },
-      ],
-    };
-
-    if (libDevice.firmwareVersion || libDevice.model) {
-      discovered.info = {
-        manufacturer: "Reolink",
-        ...(libDevice.model ? { model: libDevice.model } : {}),
-        ...(libDevice.firmwareVersion ? { firmware: libDevice.firmwareVersion } : {}),
-      };
-    }
-
-    this.networkDiscoveredDevices.set(nativeId, { discovered, libDevice });
-  }
-
-  async adoptDevice(adopt: AdoptDevice): Promise<string> {
-    const entry = this.networkDiscoveredDevices.get(adopt.nativeId);
-    if (!entry) throw new Error("Device not found in discovery cache");
-
-    const { libDevice } = entry;
-    const username = adopt.settings?.username?.toString() || "admin";
-    const password = adopt.settings?.password?.toString();
-    if (!password) throw new Error("Password is required");
-
-    // Delegate to createDevice which handles auto-detection, capabilities, etc.
-    const nativeId = await this.createDevice({
-      ip: libDevice.host,
-      username,
-      password,
-      uid: libDevice.uid || "",
-      deviceType: "Auto",
-    });
-
-    // Remove from discovered cache
-    this.networkDiscoveredDevices.delete(adopt.nativeId);
-
-    // Notify Scrypted of updated discovery list
-    await this.onDeviceEvent(
-      ScryptedInterface.DeviceDiscovery,
-      [...this.networkDiscoveredDevices.values()].map((d) => d.discovered),
-    );
-
-    return nativeId;
-  }
+  // async discoverDevices(scan?: boolean): Promise<DiscoveredDevice[]> {
+  //   if (scan) {
+  //     if (this.discoverDevicesPromise) {
+  //       return await this.discoverDevicesPromise;
+  //     }
+  //     this.discoverDevicesPromise = (async () => {
+  //       try {
+  //         // Trigger immediate scan on the background client
+  //         if (this.autodiscoveryClient) {
+  //           await this.autodiscoveryClient.scanNow();
+  //         }
+
+  //         // Rebuild the discovery list from the client's cumulative results
+  //         this.rebuildDiscoveryList();
+
+  //         return [...this.networkDiscoveredDevices.values()].map((d) => d.discovered);
+  //       } catch (e: any) {
+  //         this.console.error(`[Discovery] Scan failed: ${e?.message || String(e)}`);
+  //         return [];
+  //       } finally {
+  //         this.discoverDevicesPromise = undefined;
+  //       }
+  //     })();
+  //     return await this.discoverDevicesPromise;
+  //   }
+
+  //   // No scan: return cached results
+  //   return [...this.networkDiscoveredDevices.values()].map((d) => d.discovered);
+  // }
+
+  // private rebuildDiscoveryList() {
+  //   const existingIps = this.getExistingDeviceIps();
+  //   const allDevices = this.autodiscoveryClient?.getDiscoveredDevices() ?? [];
+  //   this.networkDiscoveredDevices.clear();
+
+  //   for (const libDevice of allDevices) {
+  //     const alreadyAdded = existingIps.has(libDevice.host);
+  //     this.console.log(`[Discovery] Found ${libDevice.host} (${libDevice.name || libDevice.model || "unknown"})${alreadyAdded ? " — already added, skipping" : ""}`);
+  //     if (alreadyAdded) continue;
+  //     this.addToDiscoveryList(libDevice);
+  //   }
+
+  //   this.console.log(`[Discovery] ${this.networkDiscoveredDevices.size} new device(s), ${existingIps.size} already added`);
+  // }
+
+  // private addToDiscoveryList(libDevice: LibDiscoveredDevice) {
+  //   const nativeId = `discovered-${libDevice.host}`;
+  //   const name = libDevice.name || libDevice.model || `Reolink ${libDevice.host}`;
+  //   const descParts: string[] = [libDevice.host];
+  //   if (libDevice.model) descParts.push(libDevice.model);
+  //   if (libDevice.uid) descParts.push(`UID: ${libDevice.uid}`);
+
+  //   const discovered: DiscoveredDevice = {
+  //     nativeId,
+  //     name,
+  //     description: descParts.join(" — "),
+  //     type: ScryptedDeviceType.Camera,
+  //     settings: [
+  //       { key: "username", title: "Username", value: "admin" },
+  //       { key: "password", title: "Password", type: "password" },
+  //     ],
+  //   };
+
+  //   if (libDevice.firmwareVersion || libDevice.model) {
+  //     discovered.info = {
+  //       manufacturer: "Reolink",
+  //       ...(libDevice.model ? { model: libDevice.model } : {}),
+  //       ...(libDevice.firmwareVersion ? { firmware: libDevice.firmwareVersion } : {}),
+  //     };
+  //   }
+
+  //   this.networkDiscoveredDevices.set(nativeId, { discovered, libDevice });
+  // }
+
+  // async adoptDevice(adopt: AdoptDevice): Promise<string> {
+  //   const entry = this.networkDiscoveredDevices.get(adopt.nativeId);
+  //   if (!entry) throw new Error("Device not found in discovery cache");
+
+  //   const { libDevice } = entry;
+  //   const username = adopt.settings?.username?.toString() || "admin";
+  //   const password = adopt.settings?.password?.toString();
+  //   if (!password) throw new Error("Password is required");
+
+  //   // Delegate to createDevice which handles auto-detection, capabilities, etc.
+  //   const nativeId = await this.createDevice({
+  //     ip: libDevice.host,
+  //     username,
+  //     password,
+  //     uid: libDevice.uid || "",
+  //     deviceType: "Auto",
+  //   });
+
+  //   // Remove from discovered cache
+  //   this.networkDiscoveredDevices.delete(adopt.nativeId);
+
+  //   // Notify Scrypted of updated discovery list
+  //   await this.onDeviceEvent(
+  //     ScryptedInterface.DeviceDiscovery,
+  //     [...this.networkDiscoveredDevices.values()].map((d) => d.discovered),
+  //   );
+
+  //   return nativeId;
+  // }
 
   async getSettings(): Promise<Setting[]> {
     return [
-      {
-        key: "discoveryMethods",
-        title: "Discovery Methods",
-        description: "ARP: reads ARP table for Reolink MAC prefixes (fast, like Home Assistant). ONVIF: WS-Discovery multicast (most Reolink cameras). DHCP: passive listener on port 67 (requires root).",
-        type: "string",
-        choices: ["arp", "onvif", "dhcp"],
-        multiple: true,
-        value: JSON.parse(this.storage.getItem("discoveryMethods") || '["arp","onvif"]'),
-      },
-      {
-        key: "discoverySubnets",
-        title: "Discovery Subnets",
-        description: "Comma-separated list of subnets to scan in CIDR notation (e.g. 192.168.1.0/24, 10.0.0.0/24). Leave empty to auto-detect the local network. Used for HTTP and TCP scanning; ARP/UDP/DHCP methods don't need this.",
-        type: "string",
-        placeholder: "192.168.1.0/24, 10.0.0.0/24",
-        value: this.storage.getItem("discoverySubnets") || "",
-      },
+      // {
+      //   key: "discoveryMethods",
+      //   title: "Discovery Methods",
+      //   description: "ARP: reads ARP table for Reolink MAC prefixes (fast, like Home Assistant). ONVIF: WS-Discovery multicast (most Reolink cameras). DHCP: passive listener on port 67 (requires root).",
+      //   type: "string",
+      //   choices: ["arp", "onvif", "dhcp"],
+      //   multiple: true,
+      //   value: JSON.parse(this.storage.getItem("discoveryMethods") || '["arp","onvif"]'),
+      // },
+      // {
+      //   key: "discoverySubnets",
+      //   title: "Discovery Subnets",
+      //   description: "Comma-separated list of subnets to scan in CIDR notation (e.g. 192.168.1.0/24, 10.0.0.0/24). Leave empty to auto-detect the local network. Used for HTTP and TCP scanning; ARP/UDP/DHCP methods don't need this.",
+      //   type: "string",
+      //   placeholder: "192.168.1.0/24, 10.0.0.0/24",
+      //   value: this.storage.getItem("discoverySubnets") || "",
+      // },
     ];
   }
 
-  async putSetting(key: string, value: string | number | boolean | string[]): Promise<void> {
+  async putSetting(
+    key: string,
+    value: string | number | boolean | string[],
+  ): Promise<void> {
     if (Array.isArray(value)) {
       this.storage.setItem(key, JSON.stringify(value));
     } else {
@@ -577,9 +617,9 @@ class ReolinkNativePlugin
     }
 
     // Restart background discovery when discovery settings change
-    if (key === "discoveryMethods" || key === "discoverySubnets") {
-      this.startBackgroundDiscovery();
-    }
+    // if (key === "discoveryMethods" || key === "discoverySubnets") {
+    //   this.startBackgroundDiscovery();
+    // }
   }
 
   async getCreateDeviceSettings(): Promise<Setting[]> {