@apocaliss92/scrypted-reolink-native 0.2.10 → 0.2.12

package/package.json

@@ -1,6 +1,6 @@
 {
    "name": "@apocaliss92/scrypted-reolink-native",
-   "version": "0.2.10",
+   "version": "0.2.12",
    "description": "Use any reolink camera with Scrypted, even older/unsupported models without HTTP protocol support",
    "author": "@apocaliss92",
    "license": "Apache",

package/src/camera.ts

@@ -1162,17 +1162,17 @@ export class ReolinkCamera extends BaseBaichuanClass implements VideoCamera, Cam
         const useNvr = clipsSource === "NVR" && this.nvrDevice && fileId.includes('/');
 
         if (useNvr) {
-            logger.debug(`[getVideoClipRtmpUrl] Using NVR API for fileId="${fileId}", forThumbnail=${forThumbnail}`);
+            // logger.debug(`[getVideoClipRtmpUrl] Using NVR API for fileId="${fileId}", forThumbnail=${forThumbnail}`);
             const api = await this.ensureClient();
             const channel = this.storageSettings.values.rtspChannel ?? 0;
 
             try {
-                logger.debug(`[getVideoClipRtmpUrl] Trying getVodUrl with Download requestType...`);
+                // logger.debug(`[getVideoClipRtmpUrl] Trying getVodUrl with Download requestType...`);
                 const url = await api.getVodUrl(fileId, channel, {
                     requestType: "Download",
                     streamType: "main",
                 });
-                logger.debug(`[getVideoClipRtmpUrl] NVR getVodUrl Download URL received: url="${url || 'none'}"`);
+                // logger.debug(`[getVideoClipRtmpUrl] NVR getVodUrl Download URL received: url="${url || 'none'}"`);
                 if (url) return url;
             } catch (e: any) {
                 logger.error(`[getVideoClipRtmpUrl] getVodUrl Download failed: ${e?.message || String(e)}`);
@@ -1181,7 +1181,7 @@ export class ReolinkCamera extends BaseBaichuanClass implements VideoCamera, Cam
             throw new Error(`No streaming URL found from NVR for file ${fileId} after trying Playback and Download methods`);
         } else {
             // Camera standalone: DEVE usare RTMP da Baichuan API
-            logger.debug(`[getVideoClipRtmpUrl] Getting RTMP URL from Baichuan API for fileId="${fileId}" (camera standalone)`);
+            // logger.debug(`[getVideoClipRtmpUrl] Getting RTMP URL from Baichuan API for fileId="${fileId}" (camera standalone)`);
             const api = await this.ensureClient();
             const result = await api.getRecordingPlaybackUrls({
                 fileName: fileId,
@@ -2438,11 +2438,11 @@ export class ReolinkCamera extends BaseBaichuanClass implements VideoCamera, Cam
                     // logger.log({ supportedStreams, variantType, lensParam, rtspChannel, onNvr: this.isOnNvr, nativeStreams: nativeStreams.map(s => ({ id: s.id, nativeVariant: s.nativeVariant, lens: s.lens })), rtspStreams: rtspStreams.map(s => ({ id: s.id, lens: s.lens })), rtmpStreams: rtmpStreams.map(s => ({ id: s.id, lens: s.lens })) });
 
                     for (const supportedStream of supportedStreams) {
-                        const { id, metadata, url, name, container, lens } = supportedStream;
+                        const { id, metadata, url, name, container, lens, channel, profile, nativeVariant } = supportedStream;
 
                         // Composite streams are re-encoded to H.264 by the library (ffmpeg/libx264).
                         // Do not infer codec from underlying camera metadata.
-                        const isComposite = id.startsWith('composite_') || lens === 'composite';
+                        const isComposite = lens === 'composite' || channel === undefined;
                         const codec = (() => {
                             if (isComposite) return 'h264';
 
@@ -2472,7 +2472,14 @@ export class ReolinkCamera extends BaseBaichuanClass implements VideoCamera, Cam
                             container,
                             video: { codec, width: metadata.width, height: metadata.height },
                             // audio: { codec: metadata.audioCodec }
-                        })
+
+                            // Provide explicit RFC4571 metadata so stream-utils can avoid parsing the streamKey.
+                            reolinkRfc4571: {
+                                channel,
+                                profile,
+                                variant: nativeVariant,
+                            },
+                        } as any)
                     }
                 } catch (e) {
                     if (!this.isRecoverableBaichuanError?.(e)) {
@@ -2725,7 +2732,7 @@ export class ReolinkCamera extends BaseBaichuanClass implements VideoCamera, Cam
             this.intercom = new ReolinkBaichuanIntercom(this);
         }
 
-        if (hasPtz) {
+        if (hasPtz && !this.multiFocalDevice) {
             const choices = (this.presets || []).map((preset: any) => preset.id + '=' + preset.name);
 
             this.storageSettings.settings.presets.choices = choices;

package/src/stream-utils.ts

@@ -17,8 +17,8 @@ export interface StreamManagerOptions {
     /**
      * Creates a dedicated Baichuan session for streaming.
      * Required to support concurrent main+ext streams on firmwares where streamType overlaps.
-     * @param streamKey The unique stream key (e.g., "composite_default_main", "channel_0_main", etc.)
-     *                  Contains all necessary information (profile, variantType, channel) for stream identification.
+    * @param streamKey The unique stream key (e.g., "composite-rtsp-default-sub-sub", "channel_0_main", etc.)
+    *                  Forwarded to the library as `requestedId`.
      */
     createStreamClient: (streamKey: string) => Promise<ReolinkBaichuanApi>;
     logger: Console;
@@ -93,89 +93,13 @@ export function parseStreamProfileFromId(id: string | undefined): StreamProfile
     return;
 }
 
-function parseRfcStreamKey(streamKey: string): {
-    isComposite: boolean;
+type ReolinkRfc4571Metadata = {
+    profile: StreamProfile;
     channel?: number;
     variant?: NativeVideoStreamVariant;
-    profile?: StreamProfile;
-} {
-    const key = String(streamKey ?? '');
-    if (!key) {
-        throw new Error('parseRfcStreamKey: missing streamKey');
-    }
-
-    // Composite forms supported by the library/server:
-    // - composite-main-main (wider-tele)
-    // - composite_<profile>
-    // - composite_<variant>_<profile>
-    // - composite_<variant>_<wider>_<tele>
-    if (key.startsWith('composite-')) {
-        const parts = key.split('-').filter(Boolean);
-        const tele = parts.length >= 3 ? parts[2] : undefined;
-        const teleProfile = tele === 'main' || tele === 'sub' || tele === 'ext' ? (tele as StreamProfile) : undefined;
-        return { isComposite: true, profile: teleProfile };
-    }
-
-    if (key.startsWith('composite_')) {
-        const parts = key.split('_').filter(Boolean);
-        // parts[0] === 'composite'
-        const maybeVariant = parts.length >= 2 ? parts[1] : undefined;
-        const variant =
-            maybeVariant === 'default' || maybeVariant === 'autotrack' || maybeVariant === 'telephoto'
-                ? (maybeVariant as NativeVideoStreamVariant)
-                : undefined;
-
-        // Heuristic: pick last token that looks like a profile as the tele profile.
-        const last = parts[parts.length - 1];
-        const profile = last === 'main' || last === 'sub' || last === 'ext' ? (last as StreamProfile) : undefined;
-        return {
-            isComposite: true,
-            ...(variant && variant !== 'default' ? { variant } : {}),
-            ...(profile ? { profile } : {}),
-        };
-    }
-
-    // Non-composite forms supported by the plugin:
-    // - channel_<ch>_<profile>
-    // - channel_<ch>_<variant>_<profile>
-    // - <ch>_<profile>
-    // - <ch>_<variant>_<profile>
-    const parts = key.split('_').filter(Boolean);
-    if (!parts.length) {
-        throw new Error(`parseRfcStreamKey: invalid streamKey='${key}'`);
-    }
-
-    let idx = 0;
-    if (parts[0] === 'channel') {
-        idx = 1;
-    }
-
-    const channelStr = parts[idx];
-    const channel = channelStr !== undefined ? Number(channelStr) : NaN;
-    if (!Number.isFinite(channel)) {
-        throw new Error(`parseRfcStreamKey: could not parse channel from streamKey='${key}'`);
-    }
-
-    const tail = parts.slice(idx + 1);
-    const last = tail[tail.length - 1];
-    const profile = last === 'main' || last === 'sub' || last === 'ext' ? (last as StreamProfile) : undefined;
-
-    // tail can be:
-    // - [profile]
-    // - [variant, profile]
-    const maybeVariant = tail.length >= 2 ? tail[0] : undefined;
-    const variant =
-        maybeVariant === 'default' || maybeVariant === 'autotrack' || maybeVariant === 'telephoto'
-            ? (maybeVariant as NativeVideoStreamVariant)
-            : undefined;
-
-    return {
-        isComposite: false,
-        channel,
-        ...(variant && variant !== 'default' ? { variant } : {}),
-        ...(profile ? { profile } : {}),
-    };
-}
+    /** Explicitly mark composite (channel-less) streams. If omitted, `channel===undefined` implies composite. */
+    isComposite?: boolean;
+};
 
 /**
  * Extract and normalize variant type from stream ID or URL (e.g., "autotrack" from "native_autotrack_main" or "?variant=autotrack")
@@ -253,7 +177,12 @@ export async function createRfc4571MediaObjectFromStreamManager(params: {
 }): Promise<MediaObject> {
     const { streamManager, streamKey, selected, sourceId } = params;
 
-    const { host, port, sdp, audio, username, password } = await streamManager.getRfcServer(streamKey);
+    const meta = (selected as any)?.reolinkRfc4571 as ReolinkRfc4571Metadata | undefined;
+    if (!meta?.profile) {
+        throw new Error(`Missing RFC4571 metadata/profile for streamKey='${streamKey}'`);
+    }
+
+    const { host, port, sdp, audio, username, password } = await streamManager.getRfcServer(streamKey, meta);
 
     const { url: _ignoredUrl, ...mso }: any = selected;
     mso.container = 'rtp';
@@ -311,21 +240,20 @@ export class StreamManager {
     /**
      * Unified RFC4571 server accessor.
      *
-     * The streamKey is the single source of truth:
-     * - Composite: composite_* (channel-less)
-     * - Single channel: channel_<ch>_* or <ch>_*
+     * `stream-utils` does not parse `streamKey`. It forwards the `streamKey` as `requestedId`
+     * and relies on explicit metadata from the selected stream option (profile/channel/variant).
      */
-    async getRfcServer(streamKey: string, profile?: StreamProfile): Promise<RfcServerInfo> {
-        const parsed = parseRfcStreamKey(streamKey);
-        const resolvedProfile = profile ?? parsed.profile;
-        if (!resolvedProfile) {
-            throw new Error(`getRfcServer: could not infer profile from streamKey='${streamKey}'`);
+    async getRfcServer(streamKey: string, meta: ReolinkRfc4571Metadata): Promise<RfcServerInfo> {
+        if (!meta?.profile) {
+            throw new Error(`getRfcServer: missing profile for streamKey='${streamKey}'`);
         }
 
-        return await this.ensureRfcServer(streamKey, resolvedProfile, {
-            channel: parsed.isComposite ? undefined : parsed.channel,
-            variant: parsed.variant,
-            compositeOptions: parsed.isComposite ? this.opts.compositeOptions : undefined,
+        const isComposite = meta.isComposite ?? (meta.channel === undefined);
+
+        return await this.ensureRfcServer(streamKey, meta.profile, {
+            channel: isComposite ? undefined : meta.channel,
+            variant: meta.variant,
+            compositeOptions: isComposite ? this.opts.compositeOptions : undefined,
         });
     }
 

package/src/utils.ts

@@ -198,11 +198,11 @@ export async function recordingFileToVideoClip(
     let videoHref: string | undefined = providedVideoHref;
     let thumbnailHref: string | undefined;
 
-    logger?.debug(`[recordingFileToVideoClip] URL generation: useWebhook=${useWebhook}, hasPlugin=${!!plugin}, deviceId=${deviceId}, providedVideoHref=${providedVideoHref || 'none'}, hasApi=${!!api}`);
+    // logger?.debug(`[recordingFileToVideoClip] URL generation: useWebhook=${useWebhook}, hasPlugin=${!!plugin}, deviceId=${deviceId}, providedVideoHref=${providedVideoHref || 'none'}, hasApi=${!!api}`);
 
     // If webhook is enabled, generate webhook URLs
     if (useWebhook && plugin && deviceId) {
-        logger?.debug(`[recordingFileToVideoClip] Generating webhook URLs for fileId=${id}`);
+        // logger?.debug(`[recordingFileToVideoClip] Generating webhook URLs for fileId=${id}`);
         try {
             const { videoUrl, thumbnailUrl } = await getVideoClipWebhookUrls({
                 deviceId,
@@ -212,24 +212,24 @@ export async function recordingFileToVideoClip(
             });
             videoHref = videoUrl;
             thumbnailHref = thumbnailUrl;
-            logger?.debug(`[recordingFileToVideoClip] Webhook URLs generated successfully: videoHref="${videoHref}", thumbnailHref="${thumbnailHref}"`);
+            // logger?.debug(`[recordingFileToVideoClip] Webhook URLs generated successfully: videoHref="${videoHref}", thumbnailHref="${thumbnailHref}"`);
         } catch (e) {
             logger?.error(`[recordingFileToVideoClip] Failed to generate webhook URLs for fileId=${id}:`, e?.message || String(e));
         }
     } else if (!videoHref && api) {
         // Fallback to direct RTMP URL if webhook is not used
-        logger?.debug(`[recordingFileToVideoClip] Fetching RTMP playback URL for fileName=${rec.fileName}`);
+        // logger?.debug(`[recordingFileToVideoClip] Fetching RTMP playback URL for fileName=${rec.fileName}`);
         try {
             const { rtmpVodUrl } = await api.getRecordingPlaybackUrls({
                 fileName: rec.fileName,
             });
             videoHref = rtmpVodUrl;
-            logger?.debug(`[recordingFileToVideoClip] RTMP URL fetched successfully: videoHref="${videoHref}"`);
+            // logger?.debug(`[recordingFileToVideoClip] RTMP URL fetched successfully: videoHref="${videoHref}"`);
         } catch (e) {
             logger?.debug(`[recordingFileToVideoClip] Failed to build playback URL for recording fileName=${rec.fileName}:`, e?.message || String(e));
         }
     } else {
-        logger?.debug(`[recordingFileToVideoClip] No URL generation: useWebhook=${useWebhook}, hasPlugin=${!!plugin}, deviceId=${deviceId}, providedVideoHref=${providedVideoHref || 'none'}, hasApi=${!!api}`);
+        // logger?.debug(`[recordingFileToVideoClip] No URL generation: useWebhook=${useWebhook}, hasPlugin=${!!plugin}, deviceId=${deviceId}, providedVideoHref=${providedVideoHref || 'none'}, hasApi=${!!api}`);
     }
 
     const description = ('name' in rec && typeof rec.name === 'string' && rec.name) ? rec.name : (rec.fileName ?? rec.id ?? '');