@api-client/core 0.18.24 → 0.18.26

package/data/models/example-generator-api.json

@@ -42068,13 +42068,13 @@
 "@id": "#194"
 },
 {
-"@id": "#197"
+"@id": "#200"
 },
 {
-"@id": "#203"
+"@id": "#197"
 },
 {
-"@id": "#200"
+"@id": "#203"
 },
 {
 "@id": "#206"
@@ -43478,7 +43478,7 @@
 "doc:ExternalDomainElement",
 "doc:DomainElement"
 ],
-"doc:raw": "code: '5'\ndescription: 'Limited company'\n",
+"doc:raw": "class: '3'\ndescription: '150 - 300'\nnumberOfFte: 5500\nnumberOfEmployees: 5232\n",
 "core:mediaType": "application/yaml",
 "sourcemaps:sources": [
 {
@@ -43499,7 +43499,7 @@
 "doc:ExternalDomainElement",
 "doc:DomainElement"
 ],
-"doc:raw": "code: 'J'\ndescription: 'Information and communication'\n",
+"doc:raw": "code: '5'\ndescription: 'Limited company'\n",
 "core:mediaType": "application/yaml",
 "sourcemaps:sources": [
 {
@@ -43520,7 +43520,7 @@
 "doc:ExternalDomainElement",
 "doc:DomainElement"
 ],
-"doc:raw": "class: '3'\ndescription: '150 - 300'\nnumberOfFte: 5500\nnumberOfEmployees: 5232\n",
+"doc:raw": "code: 'J'\ndescription: 'Information and communication'\n",
 "core:mediaType": "application/yaml",
 "sourcemaps:sources": [
 {
@@ -44766,7 +44766,7 @@
 {
 "@id": "#199/source-map/lexical/element_0",
 "sourcemaps:element": "amf://id#199",
-"sourcemaps:value": "[(1,0)-(3,0)]"
+"sourcemaps:value": "[(1,0)-(5,0)]"
 },
 {
 "@id": "#202/source-map/lexical/element_0",
@@ -44776,7 +44776,7 @@
 {
 "@id": "#205/source-map/lexical/element_0",
 "sourcemaps:element": "amf://id#205",
-"sourcemaps:value": "[(1,0)-(5,0)]"
+"sourcemaps:value": "[(1,0)-(3,0)]"
 },
 {
 "@id": "#208/source-map/lexical/element_0",

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@api-client/core",
   "description": "The API Client's core client library. Works in NodeJS and in a ES enabled browser.",
-  "version": "0.18.24",
+  "version": "0.18.26",
   "license": "Apache-2.0",
   "exports": {
     "./browser.js": {

package/src/modeling/DomainEntity.ts

@@ -412,7 +412,7 @@ export class DomainEntity extends DomainElement {
    * ```
    */
   addParent(key: string, domain?: string): this {
-    const effectiveKey = domain ? `${domain}:${key}` : key
+    const effectiveKey = this.domain.buildReferenceKey(key, domain)
     // Prevent adding self as parent
     if (effectiveKey === this.key) {
       const message = 'Entity cannot be a parent of itself'
@@ -486,19 +486,41 @@ export class DomainEntity extends DomainElement {
    * Removes a parent from this entity.
    *
    * @param key The key of the parent entity to remove.
+   * @param domain Optional domain key if the parent belongs to a foreign domain.
    * @returns `this` for chaining.
    * @throws Error When the parent does not exist.
    * @example
    * ```typescript
+   * // Remove local parent
    * entity.removeParent('baseEntity');
+   *
+   * // Remove foreign domain parent
+   * entity.removeParent('baseEntity', 'externalDomain');
    * ```
    */
-  removeParent(key: string): this {
+  removeParent(key: string, domain?: string): this {
     const { graph } = this.root
-    if (!graph.hasEdge(this.key, key)) {
-      throw new Error(`Trying to remove a parent ${key} from ${this.key}, but it doesn't exist`)
+    const effectiveKey = this.domain.buildReferenceKey(key, domain)
+
+    if (!graph.hasEdge(this.key, effectiveKey)) {
+      let message = `Trying to remove a parent ${key} from ${this.key}, but it doesn't exist`
+      if (domain) {
+        message = `Trying to remove a foreign parent ${key} from domain "${domain}" from ${this.key}, but it doesn't exist`
+      }
+      throw new Error(message)
     }
-    graph.removeEdge(this.key, key)
+
+    // Verify it's actually a parent edge
+    const edge = graph.edge(this.key, effectiveKey)
+    if (!edge || edge.type !== 'parent') {
+      let message = `Edge between ${this.key} and ${key} exists but is not a parent relationship`
+      if (domain) {
+        message = `Edge between ${this.key} and ${key} in domain "${domain}" exists but is not a parent relationship`
+      }
+      throw new Error(message)
+    }
+
+    graph.removeEdge(this.key, effectiveKey)
     this.root.notifyChange()
     return this
   }