@api-client/core 0.18.12 → 0.18.13

package/tests/unit/runtime/http-engine/responses.spec.ts

@@ -2,16 +2,15 @@ import { test } from '@japa/runner'
 import {
   IResponse,
   Response,
-  DummyLogger,
+  createLogger,
   CoreEngine,
   IHttpRequest,
   HttpEngineOptions,
   Headers,
   IRequestsSize,
-  RequestState,
 } from '../../../../src/index.js'
 
-const logger = new DummyLogger()
+const logger = createLogger()
 
 test.group('Request size', () => {
   test('has the request size value', async ({ assert, httpConfig }) => {
@@ -79,112 +78,6 @@ test.group('Responses test', () => {
   })
 })
 
-test.group('Data buffer responses', (group) => {
-  // https://github.com/advanced-rest-client/arc-electron/issues/75#issuecomment-399204512
-  const parts = [
-    Buffer.from([
-      72, 84, 84, 80, 47, 49, 46, 48, 32, 50, 48, 48, 32, 79, 75, 13, 10, 67, 111, 110, 116, 101, 110, 116, 45, 84, 121,
-      112, 101, 58, 32, 97, 112, 112, 108, 105, 99, 97, 116, 105, 111, 110, 47, 106, 115, 111, 110, 13, 10, 67, 111,
-      110, 116, 101, 110, 116, 45, 76, 101, 110, 103, 116, 104, 58, 32, 49, 49, 52, 13, 10,
-    ]),
-    Buffer.from([
-      83, 101, 114, 118, 101, 114, 58, 32, 87, 101, 114, 107, 122, 101, 117, 103, 47, 48, 46, 49, 52, 46, 49, 32, 80,
-      121, 116, 104, 111, 110, 47, 50, 46, 55, 46, 49, 52, 13, 10, 68, 97, 116, 101, 58, 32, 84, 104, 117, 44, 32, 50,
-      49, 32, 74, 117, 110, 32, 50, 48, 49, 56, 32, 49, 56, 58, 51, 48, 58, 53, 49, 32, 71, 77, 84, 13, 10, 13, 10, 123,
-      34, 105, 110, 115, 116, 114, 117, 109, 101, 110, 116, 95, 105, 100, 34, 58, 32, 50, 52, 49, 56, 54, 44, 32, 34,
-      117, 115, 101, 114, 95, 105, 100, 34, 58, 32, 53, 57, 44, 32, 34, 112, 114, 111, 100, 117, 99, 116, 95, 105, 100,
-      34, 58, 32, 51, 50, 54, 57, 44, 32, 34, 112, 114, 105, 99, 101, 34, 58, 32, 50, 46, 48, 44, 32, 34, 115, 105, 100,
-      101, 34, 58, 32, 34, 83, 101, 108, 108, 34, 44, 32, 34, 105, 100, 34, 58, 32, 50, 44, 32, 34, 113, 117, 97, 110,
-      116, 105, 116, 121, 34, 58, 32, 48, 125, 10,
-    ]),
-    // After processing status line
-    Buffer.from([
-      67, 111, 110, 116, 101, 110, 116, 45, 84, 121, 112, 101, 58, 32, 97, 112, 112, 108, 105, 99, 97, 116, 105, 111,
-      110, 47, 106, 115, 111, 110, 13, 10, 67, 111, 110, 116, 101, 110, 116, 45, 76, 101, 110, 103, 116, 104, 58, 32,
-      49, 49, 52, 13, 10,
-    ]),
-  ]
-  const headersMap: Record<string, string> = {
-    'Content-Type': 'application/json',
-    'Content-Length': '114',
-    'Server': 'Werkzeug/0.14.1 Python/2.7.14',
-    'Date': 'Thu, 21 Jun 2018 18:30:51 GMT',
-  }
-  let request: IHttpRequest
-  let opts: HttpEngineOptions
-
-  let engine: CoreEngine
-  group.each.setup((ctx) => {
-    request = {
-      url: `http://localhost:${ctx.context.httpConfig.httpPort}/v1/stream`,
-      method: 'GET',
-      headers: 'Host: test.com\nContent-Length: 0',
-      payload: 'abc',
-    }
-    opts = {
-      timeout: 50000,
-      followRedirects: false,
-      logger,
-    }
-    engine = new CoreEngine(request, opts)
-  })
-
-  test('returns data from the _processStatus()', ({ assert }) => {
-    const result = engine._processStatus(parts[0]) as Buffer
-    assert.equal(result.compare(parts[2]), 0)
-  }).tags(['@http-engine', '@response'])
-
-  test('reads the status line', ({ assert }) => {
-    engine._processSocketMessage(parts[0])
-    const cr = engine.currentResponse as Response
-    assert.equal(cr.status, 200, 'Status code is set')
-    assert.equal(cr.statusText, 'OK', 'Status message is set')
-  }).tags(['@http-engine', '@response'])
-
-  test('puts headers from part #1 after processing status to temp variable', ({ assert }) => {
-    engine._processHeaders(parts[2])
-    const headers = engine.rawHeaders as Buffer
-    assert.equal(headers.compare(parts[2]), 0)
-  }).tags(['@http-engine', '@response'])
-
-  test('sets the state to HEADERS after first part', ({ assert }) => {
-    engine._processSocketMessage(parts[0])
-    assert.equal(engine.state, RequestState.Headers)
-  }).tags(['@http-engine', '@response'])
-
-  function processMessages(): void {
-    engine._processSocketMessage(parts[0])
-    engine._processSocketMessage(parts[1])
-  }
-
-  test('processes both messages', ({ assert }) => {
-    processMessages()
-    assert.equal(engine.state, RequestState.Done)
-  }).tags(['@http-engine', '@response'])
-
-  test('sets the status', ({ assert }) => {
-    processMessages()
-    const cr = engine.currentResponse as Response
-    assert.equal(cr.status, 200, 'Status code is set')
-    assert.equal(cr.statusText, 'OK', 'Status message is set')
-  }).tags(['@http-engine', '@response'])
-
-  test('sets the headers', ({ assert }) => {
-    processMessages()
-    const cr = engine.currentResponse as Response
-    assert.typeOf(cr.headers, 'string')
-    assert.typeOf(engine.currentHeaders, 'object')
-    engine.currentHeaders.forEach((value, name) => {
-      assert.equal(headersMap[name], value)
-    })
-  }).tags(['@http-engine', '@response'])
-
-  test('sets the body', ({ assert }) => {
-    processMessages()
-    assert.isTrue(engine._rawBody instanceof Buffer)
-  }).tags(['@http-engine', '@response'])
-})
-
 test.group('Chunked responses', (group) => {
   let request: IHttpRequest
   let opts: HttpEngineOptions
@@ -217,171 +110,171 @@ test.group('Chunked responses', (group) => {
   }).tags(['@http-engine', '@response', '@chunked'])
 })
 
-test.group('readChunkSize()', (group) => {
-  let engine: CoreEngine
-  let request: IHttpRequest
-  let opts: HttpEngineOptions
-
-  group.each.setup((ctx) => {
-    request = {
-      url: `http://localhost:${ctx.context.httpConfig.httpPort}/v1/stream`,
-      method: 'GET',
-      headers: 'Host: test.com\nContent-Length: 0',
-      payload: 'abc',
-    }
-    opts = {
-      timeout: 50000,
-      followRedirects: false,
-      logger,
-    }
-    engine = new CoreEngine(request, opts)
-  })
-
-  test('returns the the same array when new line is not found', ({ assert }) => {
-    const b = Buffer.from('test')
-    const result = engine.readChunkSize(b)
-    assert.isTrue(b === result)
-  }).tags(['@http-engine', '@response', '@chunked'])
-
-  test('does not set chunkSize property', ({ assert }) => {
-    const b = Buffer.from('test')
-    engine.readChunkSize(b)
-    assert.isUndefined(engine.responseInfo.chunkSize)
-  }).tags(['@http-engine', '@response', '@chunked'])
-
-  test('parses chunk size', ({ assert }) => {
-    let chunk = Number(128).toString(16)
-    chunk += '\r\ntest'
-    const b = Buffer.from(chunk)
-    engine.readChunkSize(b)
-    assert.equal(engine.responseInfo.chunkSize, 128)
-  }).tags(['@http-engine', '@response', '@chunked'])
-
-  test('truncates the buffer', ({ assert }) => {
-    let chunk = Number(128).toString(16)
-    chunk += '\r\ntest'
-    const b = Buffer.from(chunk)
-    const result = engine.readChunkSize(b) as Buffer
-    assert.equal(result.toString(), 'test')
-  }).tags(['@http-engine', '@response', '@chunked'])
-})
-
-test.group('_processBodyChunked()', (group) => {
-  let engine: CoreEngine
-  let request: IHttpRequest
-  let opts: HttpEngineOptions
-
-  group.each.setup((ctx) => {
-    request = {
-      url: `http://localhost:${ctx.context.httpConfig.httpPort}/v1/stream`,
-      method: 'GET',
-      headers: 'Host: test.com\nContent-Length: 0',
-      payload: 'abc',
-    }
-    opts = {
-      timeout: 50000,
-      followRedirects: false,
-      logger,
-    }
-    engine = new CoreEngine(request, opts)
-    engine._reportResponse = (): void => {}
-  })
-
-  test('reads body chunk', ({ assert }) => {
-    let chunk = Number(4).toString(16)
-    chunk += '\r\ntest\r\n0\r\n'
-    const b = Buffer.from(chunk)
-    engine._processBodyChunked(b)
-    assert.equal(engine.responseInfo.chunkSize, 0)
-    assert.equal((engine._rawBody as Buffer).toString(), 'test')
-  }).tags(['@http-engine', '@response', '@chunked'])
-
-  test('Reads multi chunks', ({ assert }) => {
-    let chunk = Number(6).toString(16)
-    chunk += '\r\ntest\r\n\r\n'
-    chunk += Number(8).toString(16)
-    chunk += '\r\ntest1234\r\n'
-    chunk += '0\r\n'
-    const b = Buffer.from(chunk)
-    engine._processBodyChunked(b)
-    assert.equal(engine.responseInfo.chunkSize, 0)
-    assert.equal((engine._rawBody as Buffer).toString(), 'test\r\ntest1234')
-  }).tags(['@http-engine', '@response', '@chunked'])
-
-  test('Reads multi chunks with partial buffer', ({ assert }) => {
-    let chunk = Number(6).toString(16)
-    chunk += '\r\nte'
-    engine._processBodyChunked(Buffer.from(chunk))
-    chunk = 'st\r\n\r\n'
-    engine._processBodyChunked(Buffer.from(chunk))
-    chunk = Number(8).toString(16)
-    chunk += '\r\ntest'
-    engine._processBodyChunked(Buffer.from(chunk))
-    chunk = '1234\r\n0\r\n'
-    engine._processBodyChunked(Buffer.from(chunk))
-    assert.equal(engine.responseInfo.chunkSize, 0)
-    assert.equal((engine._rawBody as Buffer).toString(), 'test\r\ntest1234')
-  }).tags(['@http-engine', '@response', '@chunked'])
-})
-
-test.group('_processBody()', (group) => {
-  const testData = Buffer.from('abcdefghijklmn')
-  const testLength = testData.length
-  let engine: CoreEngine
-  let request: IHttpRequest
-  let opts: HttpEngineOptions
-
-  group.each.setup((ctx) => {
-    request = {
-      url: `http://localhost:${ctx.context.httpConfig.httpPort}/v1/stream`,
-      method: 'GET',
-      headers: 'Host: test.com\nContent-Length: 0',
-      payload: 'abc',
-    }
-    opts = {
-      timeout: 50000,
-      followRedirects: false,
-      logger,
-    }
-    engine = new CoreEngine(request, opts)
-    engine._reportResponse = (): void => {}
-  })
-
-  test('sets the responseInfo.body property', ({ assert }) => {
-    engine.responseInfo.contentLength = testLength + 1
-    engine.responseInfo.chunked = false
-    engine._processBody(testData)
-    assert.equal((engine.responseInfo.body as Buffer).toString(), testData.toString())
-  }).tags(['@http-engine', '@response'])
-
-  test('does not call _reportResponse when length is higher than data', ({ assert }) => {
-    engine.responseInfo.contentLength = testLength + 1
-    let called = false
-    engine._reportResponse = (): void => {
-      called = true
-    }
-    engine._processBody(testData)
-    assert.isFalse(called)
-  }).tags(['@http-engine', '@response'])
-
-  test('reports response when the data is read as whole on one socket buffer', ({ assert }) => {
-    engine.responseInfo.contentLength = testLength
-    let called = false
-    engine._reportResponse = (): void => {
-      called = true
-    }
-    engine._processBody(testData)
-    assert.isTrue(called, '_reportResponse was called')
-  }).tags(['@http-engine', '@response'])
-
-  test('reports response after more calls', ({ assert }) => {
-    engine.responseInfo.contentLength = testLength
-    let called = false
-    engine._reportResponse = (): void => {
-      called = true
-    }
-    engine._processBody(Buffer.from('abcdef'))
-    engine._processBody(Buffer.from('ghijklmn'))
-    assert.isTrue(called, '_reportResponse was called')
-  }).tags(['@http-engine', '@response'])
-})
+// test.group('readChunkSize()', (group) => {
+//   let engine: CoreEngine
+//   let request: IHttpRequest
+//   let opts: HttpEngineOptions
+
+//   group.each.setup((ctx) => {
+//     request = {
+//       url: `http://localhost:${ctx.context.httpConfig.httpPort}/v1/stream`,
+//       method: 'GET',
+//       headers: 'Host: test.com\nContent-Length: 0',
+//       payload: 'abc',
+//     }
+//     opts = {
+//       timeout: 50000,
+//       followRedirects: false,
+//       logger,
+//     }
+//     engine = new CoreEngine(request, opts)
+//   })
+
+//   test('returns the the same array when new line is not found', ({ assert }) => {
+//     const b = Buffer.from('test')
+//     const result = engine.readChunkSize(b)
+//     assert.isTrue(b === result)
+//   }).tags(['@http-engine', '@response', '@chunked'])
+
+//   test('does not set chunkSize property', ({ assert }) => {
+//     const b = Buffer.from('test')
+//     engine.readChunkSize(b)
+//     assert.isUndefined(engine.responseInfo.chunkSize)
+//   }).tags(['@http-engine', '@response', '@chunked'])
+
+//   test('parses chunk size', ({ assert }) => {
+//     let chunk = Number(128).toString(16)
+//     chunk += '\r\ntest'
+//     const b = Buffer.from(chunk)
+//     engine.readChunkSize(b)
+//     assert.equal(engine.responseInfo.chunkSize, 128)
+//   }).tags(['@http-engine', '@response', '@chunked'])
+
+//   test('truncates the buffer', ({ assert }) => {
+//     let chunk = Number(128).toString(16)
+//     chunk += '\r\ntest'
+//     const b = Buffer.from(chunk)
+//     const result = engine.readChunkSize(b) as Buffer
+//     assert.equal(result.toString(), 'test')
+//   }).tags(['@http-engine', '@response', '@chunked'])
+// })
+
+// test.group('_processBodyChunked()', (group) => {
+//   let engine: CoreEngine
+//   let request: IHttpRequest
+//   let opts: HttpEngineOptions
+
+//   group.each.setup((ctx) => {
+//     request = {
+//       url: `http://localhost:${ctx.context.httpConfig.httpPort}/v1/stream`,
+//       method: 'GET',
+//       headers: 'Host: test.com\nContent-Length: 0',
+//       payload: 'abc',
+//     }
+//     opts = {
+//       timeout: 50000,
+//       followRedirects: false,
+//       logger,
+//     }
+//     engine = new CoreEngine(request, opts)
+//     engine._reportResponse = (): void => {}
+//   })
+
+//   test('reads body chunk', ({ assert }) => {
+//     let chunk = Number(4).toString(16)
+//     chunk += '\r\ntest\r\n0\r\n'
+//     const b = Buffer.from(chunk)
+//     engine._processBodyChunked(b)
+//     assert.equal(engine.responseInfo.chunkSize, 0)
+//     assert.equal((engine._rawBody as Buffer).toString(), 'test')
+//   }).tags(['@http-engine', '@response', '@chunked'])
+
+//   test('Reads multi chunks', ({ assert }) => {
+//     let chunk = Number(6).toString(16)
+//     chunk += '\r\ntest\r\n\r\n'
+//     chunk += Number(8).toString(16)
+//     chunk += '\r\ntest1234\r\n'
+//     chunk += '0\r\n'
+//     const b = Buffer.from(chunk)
+//     engine._processBodyChunked(b)
+//     assert.equal(engine.responseInfo.chunkSize, 0)
+//     assert.equal((engine._rawBody as Buffer).toString(), 'test\r\ntest1234')
+//   }).tags(['@http-engine', '@response', '@chunked'])
+
+//   test('Reads multi chunks with partial buffer', ({ assert }) => {
+//     let chunk = Number(6).toString(16)
+//     chunk += '\r\nte'
+//     engine._processBodyChunked(Buffer.from(chunk))
+//     chunk = 'st\r\n\r\n'
+//     engine._processBodyChunked(Buffer.from(chunk))
+//     chunk = Number(8).toString(16)
+//     chunk += '\r\ntest'
+//     engine._processBodyChunked(Buffer.from(chunk))
+//     chunk = '1234\r\n0\r\n'
+//     engine._processBodyChunked(Buffer.from(chunk))
+//     assert.equal(engine.responseInfo.chunkSize, 0)
+//     assert.equal((engine._rawBody as Buffer).toString(), 'test\r\ntest1234')
+//   }).tags(['@http-engine', '@response', '@chunked'])
+// })
+
+// test.group('_processBody()', (group) => {
+//   const testData = Buffer.from('abcdefghijklmn')
+//   const testLength = testData.length
+//   let engine: CoreEngine
+//   let request: IHttpRequest
+//   let opts: HttpEngineOptions
+
+//   group.each.setup((ctx) => {
+//     request = {
+//       url: `http://localhost:${ctx.context.httpConfig.httpPort}/v1/stream`,
+//       method: 'GET',
+//       headers: 'Host: test.com\nContent-Length: 0',
+//       payload: 'abc',
+//     }
+//     opts = {
+//       timeout: 50000,
+//       followRedirects: false,
+//       logger,
+//     }
+//     engine = new CoreEngine(request, opts)
+//     engine._reportResponse = (): void => {}
+//   })
+
+//   test('sets the responseInfo.body property', ({ assert }) => {
+//     engine.responseInfo.contentLength = testLength + 1
+//     engine.responseInfo.chunked = false
+//     engine._processBody(testData)
+//     assert.equal((engine.responseInfo.body as Buffer).toString(), testData.toString())
+//   }).tags(['@http-engine', '@response'])
+
+//   test('does not call _reportResponse when length is higher than data', ({ assert }) => {
+//     engine.responseInfo.contentLength = testLength + 1
+//     let called = false
+//     engine._reportResponse = (): void => {
+//       called = true
+//     }
+//     engine._processBody(testData)
+//     assert.isFalse(called)
+//   }).tags(['@http-engine', '@response'])
+
+//   test('reports response when the data is read as whole on one socket buffer', ({ assert }) => {
+//     engine.responseInfo.contentLength = testLength
+//     let called = false
+//     engine._reportResponse = (): void => {
+//       called = true
+//     }
+//     engine._processBody(testData)
+//     assert.isTrue(called, '_reportResponse was called')
+//   }).tags(['@http-engine', '@response'])
+
+//   test('reports response after more calls', ({ assert }) => {
+//     engine.responseInfo.contentLength = testLength
+//     let called = false
+//     engine._reportResponse = (): void => {
+//       called = true
+//     }
+//     engine._processBody(Buffer.from('abcdef'))
+//     engine._processBody(Buffer.from('ghijklmn'))
+//     assert.isTrue(called, '_reportResponse was called')
+//   }).tags(['@http-engine', '@response'])
+// })

package/tests/unit/runtime/http-engine/timeout.spec.ts

@@ -1,7 +1,7 @@
 import { test } from '@japa/runner'
 import sinon from 'sinon'
 import {
-  DummyLogger,
+  createLogger,
   CoreEngine,
   IHttpRequest,
   HttpEngineOptions,
@@ -9,7 +9,7 @@ import {
   ISerializedError,
 } from '../../../../src/index.js'
 
-const logger = new DummyLogger()
+const logger = createLogger()
 
 test.group('Timeout test', (group) => {
   let opts: HttpEngineOptions
@@ -34,6 +34,6 @@ test.group('Timeout test', (group) => {
     assert.isFalse(spy.called, 'loadend was not called')
     const response = info.response as IErrorResponse
     assert.equal(response.status, 0, 'status is 0')
-    assert.equal((response.error as ISerializedError).message, 'Connection timeout.')
+    assert.equal((response.error as ISerializedError).message, 'Connection timeout after 60ms')
   })
 })

package/tests/unit/runtime/http-engine/timings.spec.ts

@@ -1,7 +1,7 @@
 import { test } from '@japa/runner'
-import { IResponse, DummyLogger, CoreEngine, IRequestTime } from '../../../../src/index.js'
+import { IResponse, createLogger, CoreEngine, IRequestTime } from '../../../../src/index.js'
 
-const logger = new DummyLogger()
+const logger = createLogger()
 
 test.group('Timings tests', () => {
   test('has the stats object', async ({ assert, httpConfig }) => {