@apex-actions/cli 0.99.0 → 0.100.0

package/README.md

@@ -125,7 +125,6 @@ refused · 2 usage or configuration · 3 not found on `delete`.
 - `src/application/` — use cases over ports
 - `src/infrastructure/` — adapters: the engine and runner binaries, the REST API
 - Documentation is the root's: decisions in `docs/adrs/cli/`, the rest by category in `docs/` (TASK-0526)
-- `VERSION` — the release version, which `version:sync` writes from the root (ADR-0048); never edited by hand
 
 ## Licence
 

package/dist/cli/main.js

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 import { packageVersion } from '../src/infrastructure/binary-install.js';
 import { buildProgram } from './program.js';
-// The version from the nearest `package.json` — what ships, and what `version:check` keeps equal to
-// `VERSION` (see `packageVersion`); it also names which engine and runner the CLI downloads.
+// The version from the nearest `package.json` — the tag's, written at publish (ADR-0053; see `packageVersion`);
+// it also names which engine and runner the CLI downloads.
 buildProgram(packageVersion()).parse(process.argv);

package/dist/src/infrastructure/binary-install.js

@@ -12,24 +12,35 @@ import { promisify } from 'node:util';
  * platform and a SHA256SUMS file per command, under the lockstep version.
  */
 export const DIST_BASE = 'https://apexactions.com/dl';
-/**
- * The CLI's version, from the nearest `package.json` above this file.
- *
- * `VERSION` is the source of truth in the repository and is not in the published package; what ships is
- * `package.json`, and `version:check` guarantees the two agree. Walking up survives the layout differing
- * between `tsx` (`src/…`) and a tarball (`dist/src/…`).
- */
-export const packageVersion = (from = import.meta.dirname) => {
+/** What every workspace's `package.json` says in the repository: a constant, not a release (ADR-0053). */
+const UNRELEASED = '0.0.0';
+/** The first directory at or above `from` that `read` succeeds in, read; undefined when none does. */
+const nearest = (from, read) => {
     for (let dir = from;; dir = dirname(dir)) {
         try {
-            return JSON.parse(readFileSync(join(dir, 'package.json'), 'utf8')).version;
+            return read(dir);
         }
         catch {
             if (dirname(dir) === dir)
-                return '0.0.0-unknown';
+                return undefined;
         }
     }
 };
+/**
+ * The CLI's version, from the nearest `package.json` above this file.
+ *
+ * In the repository a workspace's `package.json` carries `0.0.0` and the release is the root `VERSION` alone
+ * (ADR-0053), so a release changes nothing a build hashes; `publish.yml` writes the tag's version into the package
+ * it publishes, and that is what an installed CLI reads. A checkout's `0.0.0` reads on to the root `VERSION`, so a
+ * development CLI downloads the last release's binaries rather than ones nobody published. Walking up survives the
+ * layout differing between `tsx` (`src/…`) and a tarball (`dist/src/…`).
+ */
+export const packageVersion = (from = import.meta.dirname) => {
+    const declared = nearest(from, (dir) => JSON.parse(readFileSync(join(dir, 'package.json'), 'utf8')).version);
+    if (declared !== undefined && declared !== UNRELEASED)
+        return declared;
+    return nearest(from, (dir) => readFileSync(join(dir, 'VERSION'), 'utf8').trim()) ?? '0.0.0-unknown';
+};
 /** Node's names to Go's, for the four targets that are published; anything else has no download. */
 export const platformOf = (platform, arch) => {
     const os = platform === 'darwin' ? 'darwin' : platform === 'linux' ? 'linux' : undefined;

package/dist/src/infrastructure/binary-install.test.js

@@ -111,4 +111,11 @@ describe('the names', () => {
         writeFileSync(join(root, 'package.json'), JSON.stringify({ version: '9.8.7' }));
         expect(packageVersion(join(root, 'dist', 'src'))).toBe('9.8.7');
     });
+    it("reads a checkout's 0.0.0 on to the root VERSION, the release (ADR-0053)", () => {
+        const root = mkdtempSync(join(tmpdir(), 'repo-'));
+        mkdirSync(join(root, 'apps', 'cli', 'src'), { recursive: true });
+        writeFileSync(join(root, 'VERSION'), '0.99.0\n');
+        writeFileSync(join(root, 'apps', 'cli', 'package.json'), JSON.stringify({ version: '0.0.0' }));
+        expect(packageVersion(join(root, 'apps', 'cli', 'src'))).toBe('0.99.0');
+    });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@apex-actions/cli",
-  "version": "0.99.0",
+  "version": "0.100.0",
   "license": "SEE LICENSE IN LICENSE",
   "//files": "Without this npm ships src, test and the CI config alongside the binary a user installs.",
   "files": [