@aperant/framework 0.8.7 → 0.9.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +74 -0
- package/agents/apt-pr-review-fixer.md +9 -4
- package/dist/cli/commands/init.mjs +140 -22
- package/dist/cli/commands/init.mjs.map +1 -1
- package/dist/cli/commands/toolchain-detect.d.mts.map +1 -1
- package/dist/cli/commands/toolchain-detect.mjs +44 -0
- package/dist/cli/commands/toolchain-detect.mjs.map +1 -1
- package/dist/cli/commands/triage.d.mts.map +1 -1
- package/dist/cli/commands/triage.mjs +346 -13
- package/dist/cli/commands/triage.mjs.map +1 -1
- package/dist/cli/commands/uninstall.d.mts.map +1 -1
- package/dist/cli/commands/uninstall.mjs +11 -8
- package/dist/cli/commands/uninstall.mjs.map +1 -1
- package/dist/cli/install/runtime-detect.d.mts +26 -0
- package/dist/cli/install/runtime-detect.d.mts.map +1 -1
- package/dist/cli/install/runtime-detect.mjs +27 -0
- package/dist/cli/install/runtime-detect.mjs.map +1 -1
- package/dist/cli/util/aperant-section.d.mts +12 -0
- package/dist/cli/util/aperant-section.d.mts.map +1 -1
- package/dist/cli/util/aperant-section.mjs +12 -0
- package/dist/cli/util/aperant-section.mjs.map +1 -1
- package/dist/cli/util/copy.d.mts +27 -0
- package/dist/cli/util/copy.d.mts.map +1 -1
- package/dist/cli/util/copy.mjs +49 -5
- package/dist/cli/util/copy.mjs.map +1 -1
- package/dist/cli/verify-proof/idl/index.d.mts +12 -1
- package/dist/cli/verify-proof/idl/index.d.mts.map +1 -1
- package/dist/cli/verify-proof/idl/index.mjs +50 -1
- package/dist/cli/verify-proof/idl/index.mjs.map +1 -1
- package/dist/cli/verify-proof/resolver.d.mts.map +1 -1
- package/dist/cli/verify-proof/resolver.mjs +51 -1
- package/dist/cli/verify-proof/resolver.mjs.map +1 -1
- package/dist/plugin/.claude-plugin/plugin.json +1 -1
- package/dist/plugin/agents/apt-pr-review-fixer.md +9 -4
- package/dist/plugin/skills/apt-pr-review/SKILL.md +52 -15
- package/dist/plugin/skills/apt-setup/SKILL.md +7 -6
- package/dist/plugin/skills/apt-triage/SKILL.md +8 -6
- package/dist/plugin/skills/apt-update/SKILL.md +1 -1
- package/package.json +1 -1
- package/skills/apt-pr-review/SKILL.md +52 -15
- package/skills/apt-setup/SKILL.md +7 -6
- package/skills/apt-triage/SKILL.md +8 -6
- package/skills/apt-update/SKILL.md +1 -1
- package/src/cli/commands/init.mjs +144 -19
- package/src/cli/commands/toolchain-detect.mjs +44 -0
- package/src/cli/commands/triage.mjs +352 -11
- package/src/cli/commands/uninstall.mjs +11 -8
- package/src/cli/install/runtime-detect.mjs +27 -0
- package/src/cli/util/aperant-section.mjs +14 -0
- package/src/cli/util/copy.mjs +53 -8
- package/src/cli/verify-proof/idl/index.mjs +49 -11
- package/src/cli/verify-proof/resolver.mjs +49 -2
|
@@ -65,11 +65,12 @@ PHASE 3 -- PARALLEL REVIEW (6 agents, independent, all spawned in ONE message):
|
|
|
65
65
|
PHASE 4 -- VALIDATION (1 agent):
|
|
66
66
|
validator -> Re-investigates every finding, confirms or dismisses
|
|
67
67
|
|
|
68
|
-
PHASE 6 -- FIX LOOP (up to 3
|
|
69
|
-
fixer-1, fixer-2, fixer-3
|
|
68
|
+
PHASE 6 -- FIX LOOP (up to 3 fixers per iteration, spawned ONE AT A TIME, max 4 iterations):
|
|
69
|
+
fixer-1, fixer-2, fixer-3 (groups still exist; they run SEQUENTIALLY, never concurrently)
|
|
70
70
|
- Read validated finding files directly
|
|
71
|
-
- Fix assigned issues, run verification,
|
|
71
|
+
- Fix assigned issues, run verification, commit atomically per finding
|
|
72
72
|
- Report brief status to orchestrator
|
|
73
|
+
- NEVER run pr-review fixers in parallel in a shared worktree (FRAMEWORK-BUG-006)
|
|
73
74
|
|
|
74
75
|
PHASE 7 -- SELF-REVIEW (1 fresh agent):
|
|
75
76
|
self-reviewer
|
|
@@ -594,6 +595,16 @@ Construct a toolchain commands object:
|
|
|
594
595
|
|
|
595
596
|
Save to `.aperant/pr-reviews/${REVIEW_ID}/toolchain.json`.
|
|
596
597
|
|
|
598
|
+
**Cache-bypass variant (FRAMEWORK-BUG-006 Part B).** `toolchain-detect` emits an additive
|
|
599
|
+
`no_cache_command` field on `typecheck` (and `test`) when the project's verify command is turbo-backed
|
|
600
|
+
(e.g. `typecheck: { tool, command, no_cache_command: "pnpm run typecheck --force" }`). A turbo-backed
|
|
601
|
+
verify can return a STALE CACHE HIT ("replaying logs") that reports PASS while a fixer-introduced broken
|
|
602
|
+
import sits on disk — sighted on PR #244, where only a `--force` (no-cache) typecheck exposed it.
|
|
603
|
+
**Whenever a `no_cache_command` exists for a check, every POST-FIX verification (auto-checks re-runs,
|
|
604
|
+
the Phase 6 fixer verification, and the Phase 7 self-reviewer) MUST use it instead of the plain
|
|
605
|
+
`command`** so a stale cache cannot mask a broken import. Non-turbo projects have no `no_cache_command`
|
|
606
|
+
(plain `tsc`/`vitest` have no cache to bust) and use the plain command unchanged.
|
|
607
|
+
|
|
597
608
|
Update `metadata.json` with the toolchain summary and trigger count.
|
|
598
609
|
|
|
599
610
|
---
|
|
@@ -663,8 +674,8 @@ cd {WORKTREE_PATH}
|
|
|
663
674
|
```
|
|
664
675
|
|
|
665
676
|
1. Lint: {LINT_COMMAND}
|
|
666
|
-
2. Typecheck: {TYPECHECK_COMMAND}
|
|
667
|
-
3. Tests: {TEST_COMMAND}
|
|
677
|
+
2. Typecheck: {TYPECHECK_COMMAND} (use toolchain.json `typecheck.no_cache_command` if present — FRAMEWORK-BUG-006: a turbo-backed typecheck can replay a stale cached PASS and mask a broken import)
|
|
678
|
+
3. Tests: {TEST_COMMAND} (use toolchain.json `test.no_cache_command` if present, same cache-bypass rationale)
|
|
668
679
|
|
|
669
680
|
## Output
|
|
670
681
|
|
|
@@ -1171,8 +1182,9 @@ This is the owned-mode path. External-mode invocations run Phase 6b instead of t
|
|
|
1171
1182
|
for ITERATION in 1 2 3 4:
|
|
1172
1183
|
1. Create iteration directory
|
|
1173
1184
|
2. Group findings into fix assignments (max 3 groups)
|
|
1174
|
-
3. Spawn fix agents
|
|
1175
|
-
|
|
1185
|
+
3. Spawn fix agents ONE AT A TIME (never in parallel — FRAMEWORK-BUG-006):
|
|
1186
|
+
for each group: spawn fixer → wait → audit (Step 4b) → next group
|
|
1187
|
+
4. (folded into step 3's per-fixer wait)
|
|
1176
1188
|
5. Generate new diff
|
|
1177
1189
|
6. If fixes were applied: spawn fresh review on new diff
|
|
1178
1190
|
7. If ITERATION <= 2: accept new findings into the backlog
|
|
@@ -1197,6 +1209,14 @@ Take all confirmed, fixable findings and group them into up to 3 independent gro
|
|
|
1197
1209
|
|
|
1198
1210
|
#### Step 3: Spawn Fix Agents
|
|
1199
1211
|
|
|
1212
|
+
> **HARD RULE (FRAMEWORK-BUG-006): NEVER run pr-review fixers in parallel in a shared worktree.**
|
|
1213
|
+
> All fixers share ONE worktree, ONE git index, and ONE branch. git's index is not a
|
|
1214
|
+
> concurrency-safe surface — concurrent `git add` / `git commit` / self-audit `git log`/`git diff`
|
|
1215
|
+
> from sibling fixers either SWEEP one fixer's staged files into another's commit (PR #114
|
|
1216
|
+
> entanglement) or CLOBBER another fixer's working-tree edits entirely (PR #244 work-loss). Spawn
|
|
1217
|
+
> fixers **one at a time**: spawn fixer-1, wait for it to return, run the Step 4b audit-fixer gate on
|
|
1218
|
+
> it, THEN spawn fixer-2, and so on. At most one fixer touches the shared worktree at any moment.
|
|
1219
|
+
|
|
1200
1220
|
**Capture the iteration-start SHA BEFORE spawning fixers** (used by both the Step 4b audit gate AND the per-fixer Pre-Return Self-Audit added in BUG-016 — fixers now commit atomically per finding, and the audit window is scoped by this SHA):
|
|
1201
1221
|
|
|
1202
1222
|
```bash
|
|
@@ -1211,9 +1231,9 @@ For each fix group, spawn a fix agent. Read the agent definition from `.claude/a
|
|
|
1211
1231
|
| `[FIX_ASSIGNMENT]` | List of finding IDs and files for this group |
|
|
1212
1232
|
| `[N]` | Current iteration number |
|
|
1213
1233
|
| `[FIXER_NAME]` | `fixer-1`, `fixer-2`, or `fixer-3` |
|
|
1214
|
-
| `[TOOLCHAIN_COMMANDS]` | Commands from `toolchain.json` (the `all` command, or individual commands) |
|
|
1234
|
+
| `[TOOLCHAIN_COMMANDS]` | Commands from `toolchain.json` (the `all` command, or individual commands). **For the post-fix typecheck/test, pass the `no_cache_command` variant when `toolchain.json` provides one** (FRAMEWORK-BUG-006: a turbo-backed verify can replay a stale cached PASS and mask the fixer's own broken import). |
|
|
1215
1235
|
| `[CRITICAL_APPROVAL]` | `true` or `false` for each critical finding in this group |
|
|
1216
|
-
| `[PARALLEL_FIXERS]` | `
|
|
1236
|
+
| `[PARALLEL_FIXERS]` | Always `false` (FRAMEWORK-BUG-006). Fixers are spawned one at a time in the shared worktree — never concurrently. The placeholder is retained only so the fixer-agent Coordination Protocol can assert "you are the only fixer touching this worktree right now." |
|
|
1217
1237
|
| `[WORKTREE_PATH]` | The worktree path — fix agents edit files HERE, not in the user's working directory |
|
|
1218
1238
|
| `[ITERATION_START_SHA]` | The SHA captured BEFORE spawning fixers (see Step 4b's `ITERATION_START_SHA=$(...)` capture). Required for BUG-016 commit-discipline Pre-Return Self-Audit. |
|
|
1219
1239
|
|
|
@@ -1226,18 +1246,31 @@ Agent(
|
|
|
1226
1246
|
)
|
|
1227
1247
|
```
|
|
1228
1248
|
|
|
1229
|
-
If there are 2-3 groups, spawn
|
|
1249
|
+
If there are 2-3 groups, spawn the fixers **sequentially — one fixer at a time, never in parallel**
|
|
1250
|
+
(FRAMEWORK-BUG-006). Concretely, loop over the groups:
|
|
1251
|
+
|
|
1252
|
+
```
|
|
1253
|
+
for each fix group (in order):
|
|
1254
|
+
1. Spawn the fixer for THIS group only (a single Agent call in its own message)
|
|
1255
|
+
2. Wait for it to return its brief status line (Step 4)
|
|
1256
|
+
3. Run the Step 4b audit-fixer gate on it
|
|
1257
|
+
4. Only THEN spawn the fixer for the next group
|
|
1258
|
+
```
|
|
1259
|
+
|
|
1260
|
+
Do NOT batch multiple `Agent(...)` fixer calls into one message — that is the parallel-shared-worktree
|
|
1261
|
+
race this bug fixes. The atomic-per-finding commit discipline (BUG-016) and the Step 4b audit gate are
|
|
1262
|
+
UNCHANGED; they now simply run without a concurrent sibling mutating the index.
|
|
1230
1263
|
|
|
1231
1264
|
#### Step 4: Wait for Completion
|
|
1232
1265
|
|
|
1233
|
-
Wait for
|
|
1266
|
+
Wait for the **current** fix agent to return its brief status (you spawned only one this turn):
|
|
1234
1267
|
```
|
|
1235
1268
|
FIXED: X | FAILED: Y | SKIPPED: Z | VERIFICATION: PASS/FAIL
|
|
1236
1269
|
```
|
|
1237
1270
|
|
|
1238
1271
|
#### Step 4b: Audit Fixer Output (Hallucination Gate)
|
|
1239
1272
|
|
|
1240
|
-
On 2026-04-20 a live fix agent returned `FIXED: 2 | FAILED: 0 | SKIPPED: 0 | VERIFICATION: PASS` and wrote a convincing 140-line `fixes-applied.md` — but the worktree had zero edits matching the claimed files. The orchestrator trusted the self-reported status line and nearly shipped two fabricated fixes. This step is the deterministic gate that closes that hole: for
|
|
1273
|
+
On 2026-04-20 a live fix agent returned `FIXED: 2 | FAILED: 0 | SKIPPED: 0 | VERIFICATION: PASS` and wrote a convincing 140-line `fixes-applied.md` — but the worktree had zero edits matching the claimed files. The orchestrator trusted the self-reported status line and nearly shipped two fabricated fixes. This step is the deterministic gate that closes that hole: for the fixer that just returned in Step 4 (fixers run one at a time — FRAMEWORK-BUG-006), run the audit CLI and cross-check the fixer's claims against the actual git state BEFORE spawning the next group's fixer.
|
|
1241
1274
|
|
|
1242
1275
|
**Capture the iteration-start SHA BEFORE spawning fixers** so the audit can cover committed fixes (bug-5, 2026-04-23 — fixers that commit their edits before returning would otherwise present an empty working tree and trip a false-positive hallucination verdict):
|
|
1243
1276
|
|
|
@@ -1271,7 +1304,7 @@ Rule of thumb: pass `--since-sha "${ITERATION_START_SHA}"` on every audit invoca
|
|
|
1271
1304
|
|
|
1272
1305
|
The CLI returns a JSON envelope with `verdict` ∈ `verified | hallucinated | skipped`, writes `iterations/${ITERATION}/audit.json` (append-only), and bumps `metadata.json.fixer_hallucinations_total` on every `hallucinated` outcome. The envelope's `observed.since_sha` + `observed.since_sha_source` fields record which SHA was used and where it came from (`flag` | `merge-base` | `null`). The same envelope is used for the fixer and the self-reviewer (Phase 7) — `--fixer self-reviewer` reads from `self-review.md`.
|
|
1273
1306
|
|
|
1274
|
-
**Canonical fix-report filename per fixer (BUG-030):** each fixer agent writes to `fixes-applied-${FIXER_NAME}.md` (e.g. `fixes-applied-fixer-1.md`). The audit CLI resolves candidates in strict order: `fixes-applied-group{N}.md` (legacy group-named, pre-BUG-030 reviews) → `fixes-applied-fixer-{N}.md` (NEW fixer-named) → `fixes-applied-${FIXER_NAME}.md` (exact match, preferred for non-numeric fixer names) → `fixes-applied.md` (legacy unscoped, single-fixer reviews only). Writing the canonical name eliminates the cross-fixer false-positive `hallucinated` verdict that fired when
|
|
1307
|
+
**Canonical fix-report filename per fixer (BUG-030):** each fixer agent writes to `fixes-applied-${FIXER_NAME}.md` (e.g. `fixes-applied-fixer-1.md`). The audit CLI resolves candidates in strict order: `fixes-applied-group{N}.md` (legacy group-named, pre-BUG-030 reviews) → `fixes-applied-fixer-{N}.md` (NEW fixer-named) → `fixes-applied-${FIXER_NAME}.md` (exact match, preferred for non-numeric fixer names) → `fixes-applied.md` (legacy unscoped, single-fixer reviews only). Writing the canonical name eliminates the cross-fixer false-positive `hallucinated` verdict that fired when fixers shared `fixes-applied.md` (a per-fixer report path is still correct now that fixers run sequentially — each fixer owns its own report file).
|
|
1275
1308
|
|
|
1276
1309
|
| Verdict | Orchestrator Action |
|
|
1277
1310
|
|---------|---------------------|
|
|
@@ -1430,7 +1463,7 @@ Read the agent definition from `.claude/agents/apt-pr-review-self-reviewer.md` a
|
|
|
1430
1463
|
|-------------|-------|
|
|
1431
1464
|
| `[FIX_DIFF]` | The combined fix diff content or path to the concatenated file |
|
|
1432
1465
|
| `[REVIEW_DIR]` | `.aperant/pr-reviews/{REVIEW_ID}` |
|
|
1433
|
-
| `[TOOLCHAIN_COMMANDS]` | Commands from `toolchain.json` |
|
|
1466
|
+
| `[TOOLCHAIN_COMMANDS]` | Commands from `toolchain.json`. **Use the `no_cache_command` variant for the typecheck/test when one is present** (FRAMEWORK-BUG-006: a turbo-backed verify can replay a stale cached PASS and mask a broken import the fixes introduced). |
|
|
1434
1467
|
| `[WORKTREE_PATH]` | The worktree path — self-reviewer works HERE |
|
|
1435
1468
|
|
|
1436
1469
|
```
|
|
@@ -1683,11 +1716,15 @@ Fix agents self-report their outcome via a status line (`FIXED: X | FAILED: Y |
|
|
|
1683
1716
|
**Wrong:** Reading the full finding text from agent responses and processing it in orchestrator context.
|
|
1684
1717
|
**Right:** Agent responses are brief (3-5 lines). All detail goes to files. Orchestrator reads files via Read tool only when needed.
|
|
1685
1718
|
|
|
1686
|
-
### Mistake 2: Spawning Agents Sequentially
|
|
1719
|
+
### Mistake 2: Spawning the Phase 3 REVIEW Agents Sequentially
|
|
1687
1720
|
|
|
1688
1721
|
**Wrong:** Spawn security agent, wait, spawn quality agent, wait, etc.
|
|
1689
1722
|
**Right:** Spawn all 6 review agents in ONE message using 6 parallel Agent tool calls. They run concurrently.
|
|
1690
1723
|
|
|
1724
|
+
> Scope note: this applies ONLY to the Phase 3 review specialists, which are read-only (Read/Grep/Glob,
|
|
1725
|
+
> no Edit/Bash, no git writes) and therefore cannot race the index. The Phase 6 FIXERS are the
|
|
1726
|
+
> opposite — they MUST be spawned one at a time (FRAMEWORK-BUG-006). Never parallelize fixers.
|
|
1727
|
+
|
|
1691
1728
|
### Mistake 3: Skipping the Validator
|
|
1692
1729
|
|
|
1693
1730
|
**Wrong:** Sending raw review findings directly to fix agents.
|
|
@@ -966,8 +966,9 @@ ST-3 apt:execute --tdd).
|
|
|
966
966
|
|
|
967
967
|
Per ID-01 (Framework full-featured locally; backends are pluggable), the
|
|
968
968
|
default is `local-only` — zero GitHub auth required on first run. Users
|
|
969
|
-
can switch to `github-issues` (
|
|
970
|
-
the
|
|
969
|
+
can switch to `github-issues` (implemented — creates + syncs real issues
|
|
970
|
+
via the `gh` CLI) or `app-inbox` (still a stub) later; the framework
|
|
971
|
+
abstraction is open for further adapter implementations.
|
|
971
972
|
|
|
972
973
|
### 3g.1 Present the task-tracking picker
|
|
973
974
|
|
|
@@ -979,10 +980,10 @@ AskUserQuestion([
|
|
|
979
980
|
options: [
|
|
980
981
|
{ label: "Local files only (recommended for solo / 2-founder)",
|
|
981
982
|
description: "Writes to .aperant/tasks/{id}/triage.json. Zero net dep." },
|
|
982
|
-
{ label: "GitHub Issues (
|
|
983
|
-
description: "
|
|
984
|
-
{ label: "App inbox (post-app-launch — stub
|
|
985
|
-
description: "Convex-backed; same state machine, app-rendered." }
|
|
983
|
+
{ label: "GitHub Issues (creates + syncs real issues via the gh CLI)",
|
|
984
|
+
description: "First mirror creates an issue; transitions update the same issue (label swap), wontfix closes it as not-planned. Requires gh installed + authed + a git remote." },
|
|
985
|
+
{ label: "App inbox (post-app-launch — stub)",
|
|
986
|
+
description: "Convex-backed; same state machine, app-rendered. Still a stub." }
|
|
986
987
|
]
|
|
987
988
|
},
|
|
988
989
|
{
|
|
@@ -127,16 +127,18 @@ needed.
|
|
|
127
127
|
|
|
128
128
|
`.aperant/config.json.task_tracking.backend` selects the mirror:
|
|
129
129
|
|
|
130
|
-
| Backend |
|
|
130
|
+
| Backend | behavior |
|
|
131
131
|
|---|---|
|
|
132
132
|
| `local-only` (default) | State mirrors to `.aperant/tasks/{task-id}/triage.json` only. Zero network dependency. |
|
|
133
|
-
| `github-issues` |
|
|
134
|
-
| `app-inbox` |
|
|
133
|
+
| `github-issues` | Mirrors triage state to a real GitHub issue via the `gh` CLI. The first mirror CREATES an issue (`triage: <task-id>`, labelled `<category>` + `<vocab>:<state>`); subsequent transitions UPDATE the same issue (label swap), and `wontfix` CLOSES it as "not planned". The issue pointer (`github.{issue_number, issue_url, repo}`) persists on `triage.json` so transitions stay idempotent — no duplicates. Honors `task_tracking.tracker_label_vocabulary` (default → `triage:<state>`). Requires `gh` installed + authenticated + a resolvable git remote; otherwise returns a structured error (`reason: gh-unavailable | gh-unauthenticated | no-remote | gh-command-failed`) and exits non-zero — never a crash/stacktrace. Label ops are best-effort: an unknown label degrades to a `warnings[]` entry while the open/closed state change still lands. |
|
|
134
|
+
| `app-inbox` | Still a stub: returns `{status: 'not-implemented', backend: 'app-inbox', v2_issue: '#TBD'}`. Belongs to a future Convex-backed task (post-app-launch). |
|
|
135
135
|
|
|
136
136
|
Skill body reads `task_tracking.backend` at the start of every
|
|
137
|
-
invocation.
|
|
138
|
-
|
|
139
|
-
|
|
137
|
+
invocation. For `app-inbox` (still unimplemented), the skill fails fast
|
|
138
|
+
with the `not-implemented` envelope — it does NOT silently fall back to
|
|
139
|
+
`local-only`. The `github-issues` backend is fully implemented (see
|
|
140
|
+
above); its preflight/`gh` failures surface as structured errors, again
|
|
141
|
+
without falling back to `local-only`.
|
|
140
142
|
|
|
141
143
|
## Fast Path Guarantee — QUICK never enters triage (AC9, ID-05)
|
|
142
144
|
|
|
@@ -287,6 +287,6 @@ Runtime files were still refreshed; `/apt` will still work from PATH if `apt-too
|
|
|
287
287
|
- **Worker hasn't run yet**: the cache file is missing. That's fine — run check-version directly (step 1 is robust to a missing cache). Proceed normally.
|
|
288
288
|
- **Re-install fails (non-zero exit from init)**: surface the JSON `error` field verbatim in a single line, then stop. Do NOT delete the cache file — the chip should remain visible so the user sees the failure persists.
|
|
289
289
|
- **Kernel install fails but runtime install succeeds**: see Scenario D above. Do not treat this as a total failure; the user's skills still work via PATH fallback.
|
|
290
|
-
- **
|
|
290
|
+
- **Instruction-file foreign rows (exit 2, `instruction-file.foreign-rows`)** — 0.7.0+ — init now refuses to silently clobber custom rows in the `<!-- APT:framework-* -->` block. Since the multi-file fix, init stamps the block into EVERY instruction file the selected runtimes read (claude → CLAUDE.md, codex/opencode → AGENTS.md, gemini → GEMINI.md) and runs an all-target foreign-row preflight: if ANY target has foreign rows, init writes NOTHING and exits 2 (no partial install). If `init` exits 2 with `code: instruction-file.foreign-rows`, the `foreignRowIds[]` field lists the rows the generator did NOT produce and `instructionFiles[]` lists the offending files. Two paths: (a) remove the foreign rows from the listed file(s) by hand and re-run init, or (b) re-run with `--force-overwrite-catalog` to regenerate anyway. Unattended upgrade flows should detect this code and surface it to the operator — silent bypass is a regression.
|
|
291
291
|
|
|
292
292
|
</edge_cases>
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@aperant/framework",
|
|
3
|
-
"version": "0.
|
|
3
|
+
"version": "0.9.0",
|
|
4
4
|
"description": "AI coding framework — composable skills for planning, executing, verifying, and reviewing code with any LLM provider. Works as Claude Code commands, Codex tasks, or programmatically.",
|
|
5
5
|
"author": "Mikalsen AI <hello@mikalsen.ai>",
|
|
6
6
|
"type": "module",
|
|
@@ -65,11 +65,12 @@ PHASE 3 -- PARALLEL REVIEW (6 agents, independent, all spawned in ONE message):
|
|
|
65
65
|
PHASE 4 -- VALIDATION (1 agent):
|
|
66
66
|
validator -> Re-investigates every finding, confirms or dismisses
|
|
67
67
|
|
|
68
|
-
PHASE 6 -- FIX LOOP (up to 3
|
|
69
|
-
fixer-1, fixer-2, fixer-3
|
|
68
|
+
PHASE 6 -- FIX LOOP (up to 3 fixers per iteration, spawned ONE AT A TIME, max 4 iterations):
|
|
69
|
+
fixer-1, fixer-2, fixer-3 (groups still exist; they run SEQUENTIALLY, never concurrently)
|
|
70
70
|
- Read validated finding files directly
|
|
71
|
-
- Fix assigned issues, run verification,
|
|
71
|
+
- Fix assigned issues, run verification, commit atomically per finding
|
|
72
72
|
- Report brief status to orchestrator
|
|
73
|
+
- NEVER run pr-review fixers in parallel in a shared worktree (FRAMEWORK-BUG-006)
|
|
73
74
|
|
|
74
75
|
PHASE 7 -- SELF-REVIEW (1 fresh agent):
|
|
75
76
|
self-reviewer
|
|
@@ -594,6 +595,16 @@ Construct a toolchain commands object:
|
|
|
594
595
|
|
|
595
596
|
Save to `.aperant/pr-reviews/${REVIEW_ID}/toolchain.json`.
|
|
596
597
|
|
|
598
|
+
**Cache-bypass variant (FRAMEWORK-BUG-006 Part B).** `toolchain-detect` emits an additive
|
|
599
|
+
`no_cache_command` field on `typecheck` (and `test`) when the project's verify command is turbo-backed
|
|
600
|
+
(e.g. `typecheck: { tool, command, no_cache_command: "pnpm run typecheck --force" }`). A turbo-backed
|
|
601
|
+
verify can return a STALE CACHE HIT ("replaying logs") that reports PASS while a fixer-introduced broken
|
|
602
|
+
import sits on disk — sighted on PR #244, where only a `--force` (no-cache) typecheck exposed it.
|
|
603
|
+
**Whenever a `no_cache_command` exists for a check, every POST-FIX verification (auto-checks re-runs,
|
|
604
|
+
the Phase 6 fixer verification, and the Phase 7 self-reviewer) MUST use it instead of the plain
|
|
605
|
+
`command`** so a stale cache cannot mask a broken import. Non-turbo projects have no `no_cache_command`
|
|
606
|
+
(plain `tsc`/`vitest` have no cache to bust) and use the plain command unchanged.
|
|
607
|
+
|
|
597
608
|
Update `metadata.json` with the toolchain summary and trigger count.
|
|
598
609
|
|
|
599
610
|
---
|
|
@@ -663,8 +674,8 @@ cd {WORKTREE_PATH}
|
|
|
663
674
|
```
|
|
664
675
|
|
|
665
676
|
1. Lint: {LINT_COMMAND}
|
|
666
|
-
2. Typecheck: {TYPECHECK_COMMAND}
|
|
667
|
-
3. Tests: {TEST_COMMAND}
|
|
677
|
+
2. Typecheck: {TYPECHECK_COMMAND} (use toolchain.json `typecheck.no_cache_command` if present — FRAMEWORK-BUG-006: a turbo-backed typecheck can replay a stale cached PASS and mask a broken import)
|
|
678
|
+
3. Tests: {TEST_COMMAND} (use toolchain.json `test.no_cache_command` if present, same cache-bypass rationale)
|
|
668
679
|
|
|
669
680
|
## Output
|
|
670
681
|
|
|
@@ -1171,8 +1182,9 @@ This is the owned-mode path. External-mode invocations run Phase 6b instead of t
|
|
|
1171
1182
|
for ITERATION in 1 2 3 4:
|
|
1172
1183
|
1. Create iteration directory
|
|
1173
1184
|
2. Group findings into fix assignments (max 3 groups)
|
|
1174
|
-
3. Spawn fix agents
|
|
1175
|
-
|
|
1185
|
+
3. Spawn fix agents ONE AT A TIME (never in parallel — FRAMEWORK-BUG-006):
|
|
1186
|
+
for each group: spawn fixer → wait → audit (Step 4b) → next group
|
|
1187
|
+
4. (folded into step 3's per-fixer wait)
|
|
1176
1188
|
5. Generate new diff
|
|
1177
1189
|
6. If fixes were applied: spawn fresh review on new diff
|
|
1178
1190
|
7. If ITERATION <= 2: accept new findings into the backlog
|
|
@@ -1197,6 +1209,14 @@ Take all confirmed, fixable findings and group them into up to 3 independent gro
|
|
|
1197
1209
|
|
|
1198
1210
|
#### Step 3: Spawn Fix Agents
|
|
1199
1211
|
|
|
1212
|
+
> **HARD RULE (FRAMEWORK-BUG-006): NEVER run pr-review fixers in parallel in a shared worktree.**
|
|
1213
|
+
> All fixers share ONE worktree, ONE git index, and ONE branch. git's index is not a
|
|
1214
|
+
> concurrency-safe surface — concurrent `git add` / `git commit` / self-audit `git log`/`git diff`
|
|
1215
|
+
> from sibling fixers either SWEEP one fixer's staged files into another's commit (PR #114
|
|
1216
|
+
> entanglement) or CLOBBER another fixer's working-tree edits entirely (PR #244 work-loss). Spawn
|
|
1217
|
+
> fixers **one at a time**: spawn fixer-1, wait for it to return, run the Step 4b audit-fixer gate on
|
|
1218
|
+
> it, THEN spawn fixer-2, and so on. At most one fixer touches the shared worktree at any moment.
|
|
1219
|
+
|
|
1200
1220
|
**Capture the iteration-start SHA BEFORE spawning fixers** (used by both the Step 4b audit gate AND the per-fixer Pre-Return Self-Audit added in BUG-016 — fixers now commit atomically per finding, and the audit window is scoped by this SHA):
|
|
1201
1221
|
|
|
1202
1222
|
```bash
|
|
@@ -1211,9 +1231,9 @@ For each fix group, spawn a fix agent. Read the agent definition from `.claude/a
|
|
|
1211
1231
|
| `[FIX_ASSIGNMENT]` | List of finding IDs and files for this group |
|
|
1212
1232
|
| `[N]` | Current iteration number |
|
|
1213
1233
|
| `[FIXER_NAME]` | `fixer-1`, `fixer-2`, or `fixer-3` |
|
|
1214
|
-
| `[TOOLCHAIN_COMMANDS]` | Commands from `toolchain.json` (the `all` command, or individual commands) |
|
|
1234
|
+
| `[TOOLCHAIN_COMMANDS]` | Commands from `toolchain.json` (the `all` command, or individual commands). **For the post-fix typecheck/test, pass the `no_cache_command` variant when `toolchain.json` provides one** (FRAMEWORK-BUG-006: a turbo-backed verify can replay a stale cached PASS and mask the fixer's own broken import). |
|
|
1215
1235
|
| `[CRITICAL_APPROVAL]` | `true` or `false` for each critical finding in this group |
|
|
1216
|
-
| `[PARALLEL_FIXERS]` | `
|
|
1236
|
+
| `[PARALLEL_FIXERS]` | Always `false` (FRAMEWORK-BUG-006). Fixers are spawned one at a time in the shared worktree — never concurrently. The placeholder is retained only so the fixer-agent Coordination Protocol can assert "you are the only fixer touching this worktree right now." |
|
|
1217
1237
|
| `[WORKTREE_PATH]` | The worktree path — fix agents edit files HERE, not in the user's working directory |
|
|
1218
1238
|
| `[ITERATION_START_SHA]` | The SHA captured BEFORE spawning fixers (see Step 4b's `ITERATION_START_SHA=$(...)` capture). Required for BUG-016 commit-discipline Pre-Return Self-Audit. |
|
|
1219
1239
|
|
|
@@ -1226,18 +1246,31 @@ Agent(
|
|
|
1226
1246
|
)
|
|
1227
1247
|
```
|
|
1228
1248
|
|
|
1229
|
-
If there are 2-3 groups, spawn
|
|
1249
|
+
If there are 2-3 groups, spawn the fixers **sequentially — one fixer at a time, never in parallel**
|
|
1250
|
+
(FRAMEWORK-BUG-006). Concretely, loop over the groups:
|
|
1251
|
+
|
|
1252
|
+
```
|
|
1253
|
+
for each fix group (in order):
|
|
1254
|
+
1. Spawn the fixer for THIS group only (a single Agent call in its own message)
|
|
1255
|
+
2. Wait for it to return its brief status line (Step 4)
|
|
1256
|
+
3. Run the Step 4b audit-fixer gate on it
|
|
1257
|
+
4. Only THEN spawn the fixer for the next group
|
|
1258
|
+
```
|
|
1259
|
+
|
|
1260
|
+
Do NOT batch multiple `Agent(...)` fixer calls into one message — that is the parallel-shared-worktree
|
|
1261
|
+
race this bug fixes. The atomic-per-finding commit discipline (BUG-016) and the Step 4b audit gate are
|
|
1262
|
+
UNCHANGED; they now simply run without a concurrent sibling mutating the index.
|
|
1230
1263
|
|
|
1231
1264
|
#### Step 4: Wait for Completion
|
|
1232
1265
|
|
|
1233
|
-
Wait for
|
|
1266
|
+
Wait for the **current** fix agent to return its brief status (you spawned only one this turn):
|
|
1234
1267
|
```
|
|
1235
1268
|
FIXED: X | FAILED: Y | SKIPPED: Z | VERIFICATION: PASS/FAIL
|
|
1236
1269
|
```
|
|
1237
1270
|
|
|
1238
1271
|
#### Step 4b: Audit Fixer Output (Hallucination Gate)
|
|
1239
1272
|
|
|
1240
|
-
On 2026-04-20 a live fix agent returned `FIXED: 2 | FAILED: 0 | SKIPPED: 0 | VERIFICATION: PASS` and wrote a convincing 140-line `fixes-applied.md` — but the worktree had zero edits matching the claimed files. The orchestrator trusted the self-reported status line and nearly shipped two fabricated fixes. This step is the deterministic gate that closes that hole: for
|
|
1273
|
+
On 2026-04-20 a live fix agent returned `FIXED: 2 | FAILED: 0 | SKIPPED: 0 | VERIFICATION: PASS` and wrote a convincing 140-line `fixes-applied.md` — but the worktree had zero edits matching the claimed files. The orchestrator trusted the self-reported status line and nearly shipped two fabricated fixes. This step is the deterministic gate that closes that hole: for the fixer that just returned in Step 4 (fixers run one at a time — FRAMEWORK-BUG-006), run the audit CLI and cross-check the fixer's claims against the actual git state BEFORE spawning the next group's fixer.
|
|
1241
1274
|
|
|
1242
1275
|
**Capture the iteration-start SHA BEFORE spawning fixers** so the audit can cover committed fixes (bug-5, 2026-04-23 — fixers that commit their edits before returning would otherwise present an empty working tree and trip a false-positive hallucination verdict):
|
|
1243
1276
|
|
|
@@ -1271,7 +1304,7 @@ Rule of thumb: pass `--since-sha "${ITERATION_START_SHA}"` on every audit invoca
|
|
|
1271
1304
|
|
|
1272
1305
|
The CLI returns a JSON envelope with `verdict` ∈ `verified | hallucinated | skipped`, writes `iterations/${ITERATION}/audit.json` (append-only), and bumps `metadata.json.fixer_hallucinations_total` on every `hallucinated` outcome. The envelope's `observed.since_sha` + `observed.since_sha_source` fields record which SHA was used and where it came from (`flag` | `merge-base` | `null`). The same envelope is used for the fixer and the self-reviewer (Phase 7) — `--fixer self-reviewer` reads from `self-review.md`.
|
|
1273
1306
|
|
|
1274
|
-
**Canonical fix-report filename per fixer (BUG-030):** each fixer agent writes to `fixes-applied-${FIXER_NAME}.md` (e.g. `fixes-applied-fixer-1.md`). The audit CLI resolves candidates in strict order: `fixes-applied-group{N}.md` (legacy group-named, pre-BUG-030 reviews) → `fixes-applied-fixer-{N}.md` (NEW fixer-named) → `fixes-applied-${FIXER_NAME}.md` (exact match, preferred for non-numeric fixer names) → `fixes-applied.md` (legacy unscoped, single-fixer reviews only). Writing the canonical name eliminates the cross-fixer false-positive `hallucinated` verdict that fired when
|
|
1307
|
+
**Canonical fix-report filename per fixer (BUG-030):** each fixer agent writes to `fixes-applied-${FIXER_NAME}.md` (e.g. `fixes-applied-fixer-1.md`). The audit CLI resolves candidates in strict order: `fixes-applied-group{N}.md` (legacy group-named, pre-BUG-030 reviews) → `fixes-applied-fixer-{N}.md` (NEW fixer-named) → `fixes-applied-${FIXER_NAME}.md` (exact match, preferred for non-numeric fixer names) → `fixes-applied.md` (legacy unscoped, single-fixer reviews only). Writing the canonical name eliminates the cross-fixer false-positive `hallucinated` verdict that fired when fixers shared `fixes-applied.md` (a per-fixer report path is still correct now that fixers run sequentially — each fixer owns its own report file).
|
|
1275
1308
|
|
|
1276
1309
|
| Verdict | Orchestrator Action |
|
|
1277
1310
|
|---------|---------------------|
|
|
@@ -1430,7 +1463,7 @@ Read the agent definition from `.claude/agents/apt-pr-review-self-reviewer.md` a
|
|
|
1430
1463
|
|-------------|-------|
|
|
1431
1464
|
| `[FIX_DIFF]` | The combined fix diff content or path to the concatenated file |
|
|
1432
1465
|
| `[REVIEW_DIR]` | `.aperant/pr-reviews/{REVIEW_ID}` |
|
|
1433
|
-
| `[TOOLCHAIN_COMMANDS]` | Commands from `toolchain.json` |
|
|
1466
|
+
| `[TOOLCHAIN_COMMANDS]` | Commands from `toolchain.json`. **Use the `no_cache_command` variant for the typecheck/test when one is present** (FRAMEWORK-BUG-006: a turbo-backed verify can replay a stale cached PASS and mask a broken import the fixes introduced). |
|
|
1434
1467
|
| `[WORKTREE_PATH]` | The worktree path — self-reviewer works HERE |
|
|
1435
1468
|
|
|
1436
1469
|
```
|
|
@@ -1683,11 +1716,15 @@ Fix agents self-report their outcome via a status line (`FIXED: X | FAILED: Y |
|
|
|
1683
1716
|
**Wrong:** Reading the full finding text from agent responses and processing it in orchestrator context.
|
|
1684
1717
|
**Right:** Agent responses are brief (3-5 lines). All detail goes to files. Orchestrator reads files via Read tool only when needed.
|
|
1685
1718
|
|
|
1686
|
-
### Mistake 2: Spawning Agents Sequentially
|
|
1719
|
+
### Mistake 2: Spawning the Phase 3 REVIEW Agents Sequentially
|
|
1687
1720
|
|
|
1688
1721
|
**Wrong:** Spawn security agent, wait, spawn quality agent, wait, etc.
|
|
1689
1722
|
**Right:** Spawn all 6 review agents in ONE message using 6 parallel Agent tool calls. They run concurrently.
|
|
1690
1723
|
|
|
1724
|
+
> Scope note: this applies ONLY to the Phase 3 review specialists, which are read-only (Read/Grep/Glob,
|
|
1725
|
+
> no Edit/Bash, no git writes) and therefore cannot race the index. The Phase 6 FIXERS are the
|
|
1726
|
+
> opposite — they MUST be spawned one at a time (FRAMEWORK-BUG-006). Never parallelize fixers.
|
|
1727
|
+
|
|
1691
1728
|
### Mistake 3: Skipping the Validator
|
|
1692
1729
|
|
|
1693
1730
|
**Wrong:** Sending raw review findings directly to fix agents.
|
|
@@ -966,8 +966,9 @@ ST-3 apt:execute --tdd).
|
|
|
966
966
|
|
|
967
967
|
Per ID-01 (Framework full-featured locally; backends are pluggable), the
|
|
968
968
|
default is `local-only` — zero GitHub auth required on first run. Users
|
|
969
|
-
can switch to `github-issues` (
|
|
970
|
-
the
|
|
969
|
+
can switch to `github-issues` (implemented — creates + syncs real issues
|
|
970
|
+
via the `gh` CLI) or `app-inbox` (still a stub) later; the framework
|
|
971
|
+
abstraction is open for further adapter implementations.
|
|
971
972
|
|
|
972
973
|
### 3g.1 Present the task-tracking picker
|
|
973
974
|
|
|
@@ -979,10 +980,10 @@ AskUserQuestion([
|
|
|
979
980
|
options: [
|
|
980
981
|
{ label: "Local files only (recommended for solo / 2-founder)",
|
|
981
982
|
description: "Writes to .aperant/tasks/{id}/triage.json. Zero net dep." },
|
|
982
|
-
{ label: "GitHub Issues (
|
|
983
|
-
description: "
|
|
984
|
-
{ label: "App inbox (post-app-launch — stub
|
|
985
|
-
description: "Convex-backed; same state machine, app-rendered." }
|
|
983
|
+
{ label: "GitHub Issues (creates + syncs real issues via the gh CLI)",
|
|
984
|
+
description: "First mirror creates an issue; transitions update the same issue (label swap), wontfix closes it as not-planned. Requires gh installed + authed + a git remote." },
|
|
985
|
+
{ label: "App inbox (post-app-launch — stub)",
|
|
986
|
+
description: "Convex-backed; same state machine, app-rendered. Still a stub." }
|
|
986
987
|
]
|
|
987
988
|
},
|
|
988
989
|
{
|
|
@@ -127,16 +127,18 @@ needed.
|
|
|
127
127
|
|
|
128
128
|
`.aperant/config.json.task_tracking.backend` selects the mirror:
|
|
129
129
|
|
|
130
|
-
| Backend |
|
|
130
|
+
| Backend | behavior |
|
|
131
131
|
|---|---|
|
|
132
132
|
| `local-only` (default) | State mirrors to `.aperant/tasks/{task-id}/triage.json` only. Zero network dependency. |
|
|
133
|
-
| `github-issues` |
|
|
134
|
-
| `app-inbox` |
|
|
133
|
+
| `github-issues` | Mirrors triage state to a real GitHub issue via the `gh` CLI. The first mirror CREATES an issue (`triage: <task-id>`, labelled `<category>` + `<vocab>:<state>`); subsequent transitions UPDATE the same issue (label swap), and `wontfix` CLOSES it as "not planned". The issue pointer (`github.{issue_number, issue_url, repo}`) persists on `triage.json` so transitions stay idempotent — no duplicates. Honors `task_tracking.tracker_label_vocabulary` (default → `triage:<state>`). Requires `gh` installed + authenticated + a resolvable git remote; otherwise returns a structured error (`reason: gh-unavailable | gh-unauthenticated | no-remote | gh-command-failed`) and exits non-zero — never a crash/stacktrace. Label ops are best-effort: an unknown label degrades to a `warnings[]` entry while the open/closed state change still lands. |
|
|
134
|
+
| `app-inbox` | Still a stub: returns `{status: 'not-implemented', backend: 'app-inbox', v2_issue: '#TBD'}`. Belongs to a future Convex-backed task (post-app-launch). |
|
|
135
135
|
|
|
136
136
|
Skill body reads `task_tracking.backend` at the start of every
|
|
137
|
-
invocation.
|
|
138
|
-
|
|
139
|
-
|
|
137
|
+
invocation. For `app-inbox` (still unimplemented), the skill fails fast
|
|
138
|
+
with the `not-implemented` envelope — it does NOT silently fall back to
|
|
139
|
+
`local-only`. The `github-issues` backend is fully implemented (see
|
|
140
|
+
above); its preflight/`gh` failures surface as structured errors, again
|
|
141
|
+
without falling back to `local-only`.
|
|
140
142
|
|
|
141
143
|
## Fast Path Guarantee — QUICK never enters triage (AC9, ID-05)
|
|
142
144
|
|
|
@@ -287,6 +287,6 @@ Runtime files were still refreshed; `/apt` will still work from PATH if `apt-too
|
|
|
287
287
|
- **Worker hasn't run yet**: the cache file is missing. That's fine — run check-version directly (step 1 is robust to a missing cache). Proceed normally.
|
|
288
288
|
- **Re-install fails (non-zero exit from init)**: surface the JSON `error` field verbatim in a single line, then stop. Do NOT delete the cache file — the chip should remain visible so the user sees the failure persists.
|
|
289
289
|
- **Kernel install fails but runtime install succeeds**: see Scenario D above. Do not treat this as a total failure; the user's skills still work via PATH fallback.
|
|
290
|
-
- **
|
|
290
|
+
- **Instruction-file foreign rows (exit 2, `instruction-file.foreign-rows`)** — 0.7.0+ — init now refuses to silently clobber custom rows in the `<!-- APT:framework-* -->` block. Since the multi-file fix, init stamps the block into EVERY instruction file the selected runtimes read (claude → CLAUDE.md, codex/opencode → AGENTS.md, gemini → GEMINI.md) and runs an all-target foreign-row preflight: if ANY target has foreign rows, init writes NOTHING and exits 2 (no partial install). If `init` exits 2 with `code: instruction-file.foreign-rows`, the `foreignRowIds[]` field lists the rows the generator did NOT produce and `instructionFiles[]` lists the offending files. Two paths: (a) remove the foreign rows from the listed file(s) by hand and re-run init, or (b) re-run with `--force-overwrite-catalog` to regenerate anyway. Unattended upgrade flows should detect this code and surface it to the operator — silent bypass is a regression.
|
|
291
291
|
|
|
292
292
|
</edge_cases>
|