@aoxborrow/registrar-client 0.2.0 → 0.4.0

package/dist/index.d.cts

@@ -181,6 +181,7 @@ interface Registrar {
     readonly name: string;
     readonly environment: RegistrarEnvironment;
     readonly features: readonly RegistrarFeature[];
+    readonly requiresNameserversFetch: boolean;
     supports(feature: RegistrarFeature): boolean;
     testConnection(opts?: RequestOptions): Promise<ConnectionResult>;
     listDomains(opts?: ListDomainsOptions): Promise<Domain[]>;
@@ -361,6 +362,7 @@ declare abstract class BaseRegistrar implements Registrar {
     static get features(): readonly RegistrarFeature[];
     get features(): readonly RegistrarFeature[];
     supports(feature: RegistrarFeature): boolean;
+    readonly requiresNameserversFetch: boolean;
     constructor(credentials: RegistrarCredentials, httpConfig: Omit<HttpClientConfig, 'options'>, options?: RegistrarOptions);
     testConnection(_opts?: RequestOptions): Promise<ConnectionResult>;
     listDomains(_opts?: ListDomainsOptions): Promise<Domain[]>;
@@ -450,6 +452,7 @@ declare class DynadotRegistrar extends BaseRegistrar {
     listDomains(opts?: ListDomainsOptions): Promise<Domain[]>;
     getDomain(domainName: string, opts?: RequestOptions): Promise<Domain>;
     private domainInfo;
+    readonly requiresNameserversFetch = false;
     getNameservers(domainName: string, opts?: RequestOptions): Promise<string[]>;
     getContacts(domainName: string, opts?: RequestOptions): Promise<ContactSet>;
     getDnsRecords(domainName: string, opts?: RequestOptions): Promise<DnsRecord[]>;
@@ -532,6 +535,7 @@ declare class GoDaddyRegistrar extends BaseRegistrar {
     private listDomainsV3;
     private listDomainsV1;
     getDomain(domainName: string, opts?: RequestOptions): Promise<Domain>;
+    readonly requiresNameserversFetch = false;
     getNameservers(domainName: string, opts?: RequestOptions): Promise<string[]>;
     checkAvailability(domainNames: string[], opts?: RequestOptions): Promise<DomainAvailability[]>;
     getPricing(tldOrDomain: string, opts?: RequestOptions): Promise<TldPricing>;
@@ -647,6 +651,7 @@ declare class NameSiloRegistrar extends BaseRegistrar {
     testConnection(opts?: RequestOptions): Promise<ConnectionResult>;
     listDomains(opts?: ListDomainsOptions): Promise<Domain[]>;
     getDomain(domainName: string, opts?: RequestOptions): Promise<Domain>;
+    readonly requiresNameserversFetch = false;
     getNameservers(domainName: string, opts?: RequestOptions): Promise<string[]>;
     getContacts(domainName: string, opts?: RequestOptions): Promise<ContactSet>;
     getDnsRecords(domainName: string, opts?: RequestOptions): Promise<DnsRecord[]>;
@@ -716,6 +721,7 @@ declare class SpaceshipRegistrar extends BaseRegistrar {
     testConnection(opts?: RequestOptions): Promise<ConnectionResult>;
     listDomains(opts?: ListDomainsOptions): Promise<Domain[]>;
     getDomain(domainName: string, opts?: RequestOptions): Promise<Domain>;
+    readonly requiresNameserversFetch = false;
     getNameservers(domainName: string, opts?: RequestOptions): Promise<string[]>;
     getAuthCode(domainName: string, opts?: RequestOptions): Promise<string>;
     checkAvailability(domainNames: string[], opts?: RequestOptions): Promise<DomainAvailability[]>;

package/dist/index.d.ts

@@ -181,6 +181,7 @@ interface Registrar {
     readonly name: string;
     readonly environment: RegistrarEnvironment;
     readonly features: readonly RegistrarFeature[];
+    readonly requiresNameserversFetch: boolean;
     supports(feature: RegistrarFeature): boolean;
     testConnection(opts?: RequestOptions): Promise<ConnectionResult>;
     listDomains(opts?: ListDomainsOptions): Promise<Domain[]>;
@@ -361,6 +362,7 @@ declare abstract class BaseRegistrar implements Registrar {
     static get features(): readonly RegistrarFeature[];
     get features(): readonly RegistrarFeature[];
     supports(feature: RegistrarFeature): boolean;
+    readonly requiresNameserversFetch: boolean;
     constructor(credentials: RegistrarCredentials, httpConfig: Omit<HttpClientConfig, 'options'>, options?: RegistrarOptions);
     testConnection(_opts?: RequestOptions): Promise<ConnectionResult>;
     listDomains(_opts?: ListDomainsOptions): Promise<Domain[]>;
@@ -450,6 +452,7 @@ declare class DynadotRegistrar extends BaseRegistrar {
     listDomains(opts?: ListDomainsOptions): Promise<Domain[]>;
     getDomain(domainName: string, opts?: RequestOptions): Promise<Domain>;
     private domainInfo;
+    readonly requiresNameserversFetch = false;
     getNameservers(domainName: string, opts?: RequestOptions): Promise<string[]>;
     getContacts(domainName: string, opts?: RequestOptions): Promise<ContactSet>;
     getDnsRecords(domainName: string, opts?: RequestOptions): Promise<DnsRecord[]>;
@@ -532,6 +535,7 @@ declare class GoDaddyRegistrar extends BaseRegistrar {
     private listDomainsV3;
     private listDomainsV1;
     getDomain(domainName: string, opts?: RequestOptions): Promise<Domain>;
+    readonly requiresNameserversFetch = false;
     getNameservers(domainName: string, opts?: RequestOptions): Promise<string[]>;
     checkAvailability(domainNames: string[], opts?: RequestOptions): Promise<DomainAvailability[]>;
     getPricing(tldOrDomain: string, opts?: RequestOptions): Promise<TldPricing>;
@@ -647,6 +651,7 @@ declare class NameSiloRegistrar extends BaseRegistrar {
     testConnection(opts?: RequestOptions): Promise<ConnectionResult>;
     listDomains(opts?: ListDomainsOptions): Promise<Domain[]>;
     getDomain(domainName: string, opts?: RequestOptions): Promise<Domain>;
+    readonly requiresNameserversFetch = false;
     getNameservers(domainName: string, opts?: RequestOptions): Promise<string[]>;
     getContacts(domainName: string, opts?: RequestOptions): Promise<ContactSet>;
     getDnsRecords(domainName: string, opts?: RequestOptions): Promise<DnsRecord[]>;
@@ -716,6 +721,7 @@ declare class SpaceshipRegistrar extends BaseRegistrar {
     testConnection(opts?: RequestOptions): Promise<ConnectionResult>;
     listDomains(opts?: ListDomainsOptions): Promise<Domain[]>;
     getDomain(domainName: string, opts?: RequestOptions): Promise<Domain>;
+    readonly requiresNameserversFetch = false;
     getNameservers(domainName: string, opts?: RequestOptions): Promise<string[]>;
     getAuthCode(domainName: string, opts?: RequestOptions): Promise<string>;
     checkAvailability(domainNames: string[], opts?: RequestOptions): Promise<DomainAvailability[]>;

package/dist/index.js

@@ -256,7 +256,7 @@ var RegistrarClient = class {
         try {
           const detail = await this.provider.getDomain(name, opts);
           let merged = { ...domains[index], ...detail };
-          if (merged.nameservers.length === 0) {
+          if (merged.nameservers.length === 0 && this.provider.requiresNameserversFetch) {
             try {
               const nameservers = normalizeNameservers(
                 await this.provider.getNameservers(name, opts)
@@ -644,6 +644,11 @@ var BaseRegistrar = class {
   supports(feature) {
     return this.features.includes(feature);
   }
+  // See Registrar.requiresNameserversFetch. Defaults true, so a provider
+  // whose getNameservers hits a real endpoint keeps the enrichment fallback
+  // without opting in; the providers whose getNameservers just re-reads getDomain
+  // override this to false to drop the redundant call.
+  requiresNameserversFetch = true;
   constructor(credentials, httpConfig, options) {
     const { environment = "production", ...clientOptions } = options ?? {};
     this.credentials = credentials;
@@ -1714,6 +1719,9 @@ ${bodyStr}`;
     if (!data.domain_info) throw new NotFoundError(`Dynadot: domain '${domainName}' not found`);
     return data.domain_info;
   }
+  // getNameservers re-reads getDomain (domain_info carries NS inline; no separate
+  // endpoint), so listing enrichment gains nothing from the fallback — skip it.
+  requiresNameserversFetch = false;
   async getNameservers(domainName, opts) {
     const domain = await this.getDomain(domainName, opts);
     return domain.nameservers;
@@ -3034,12 +3042,24 @@ var GoDaddyRegistrar = class _GoDaddyRegistrar extends BaseRegistrar {
   name = "godaddy";
   static displayName = "GoDaddy";
   static website = "godaddy.com";
-  static helpText = 'Authenticate one of two ways. For production, create a Personal Access Token (PAT) at https://developer.godaddy.com and pass it as `apiToken` \u2014 this enables the modern v3 API. For sandbox testing, create OTE (test environment) keys and pass `apiKey` + `apiSecret` with { environment: "sandbox" }; OTE only exposes the legacy v1 API. The sso-key (API Key/Secret) scheme is deprecated by GoDaddy in 2026. Domain forwarding uses the v2 customer-scoped API \u2014 set `customerId` to your GoDaddy customer UUID, or to your numeric shopper/account ID (which the client resolves to the UUID via an sso-key-authenticated lookup).';
+  static helpText = "Create a Personal Access Token (PAT) at https://developer.godaddy.com and paste it here. The PAT is GoDaddy's modern credential: it unlocks the v3 API (discovery, registration, DNS, nameservers) and also authenticates the legacy v1 API for management operations (renew, transfer, auto-renew, lock, privacy, contacts) \u2014 one token covers everything.";
+  // Only the PAT is exposed for configuration — it is the sole credential
+  // GoDaddy recommends going forward, and it covers every production operation.
+  //
+  // The legacy `apiKey` + `apiSecret` (sso-key) pair and the `customerId` field
+  // are intentionally NOT advertised here. The code that consumes them is kept
+  // (see `authHeader`, `useV3`, `resolveCustomerId`, and the forwarding methods)
+  // so OTE/sandbox testing and direct programmatic use still work when those
+  // values are passed in credentials explicitly. But because they are no longer
+  // configurable, two capabilities are effectively unreachable through normal
+  // (config-driven) setup:
+  //   - OTE/sandbox, which needs an sso-key (`apiKey` + `apiSecret`), and
+  //   - domain forwarding, which needs `customerId` (a customer UUID), plus an
+  //     sso-key to resolve a numeric shopper ID to that UUID.
+  // GoDaddy is deprecating the sso-key scheme in 2026, so this is the direction
+  // of travel regardless.
   static configFields = [
-    { name: "apiToken", label: "API Token (PAT)", type: "password", required: false },
-    { name: "apiKey", label: "API Key", type: "password", required: false },
-    { name: "apiSecret", label: "API Secret", type: "password", required: false },
-    { name: "customerId", label: "Customer ID or Shopper ID", type: "text", required: false }
+    { name: "apiToken", label: "API Token (PAT)", type: "password", required: true }
   ];
   // GoDaddy's OTE ("Operational Test Environment") is its sandbox
   static supportsSandbox = true;
@@ -3157,6 +3177,9 @@ var GoDaddyRegistrar = class _GoDaddyRegistrar extends BaseRegistrar {
     });
     return this.toDomain(d);
   }
+  // getNameservers re-reads getDomain (GoDaddy has no dedicated NS endpoint), so
+  // listing enrichment gains nothing from the fallback — skip it.
+  requiresNameserversFetch = false;
   async getNameservers(domainName, opts) {
     const domain = await this.getDomain(domainName, opts);
     return domain.nameservers;
@@ -5058,6 +5081,9 @@ var NameSiloRegistrar = class extends BaseRegistrar {
       nameservers: extractNsHosts(r.nameservers)
     });
   }
+  // getNameservers re-reads getDomain (getDomainInfo carries NS; no separate
+  // endpoint), so listing enrichment gains nothing from the fallback — skip it.
+  requiresNameserversFetch = false;
   async getNameservers(domainName, opts) {
     const domain = await this.getDomain(domainName, opts);
     return domain.nameservers;
@@ -6299,6 +6325,9 @@ var SpaceshipRegistrar = class extends BaseRegistrar {
   async getDomain(domainName, opts) {
     return this.toDomain(await this.getRaw(domainName, opts));
   }
+  // getNameservers reads the same getRaw payload as getDomain (no dedicated NS
+  // endpoint), so listing enrichment gains nothing from the fallback — skip it.
+  requiresNameserversFetch = false;
   async getNameservers(domainName, opts) {
     const d = await this.getRaw(domainName, opts);
     return d.nameservers?.hosts ?? [];