@anysphere/file-service 0.0.0-5d343fb9 → 0.0.0-63cdba18

package/Cargo.toml

@@ -17,6 +17,9 @@ tempfile = "3.8.0"
 anyhow = "1.0.75"
 tonic = "0.9.2"
 prost = "0.11.9"
+tracing = "0.1.37"
+tracing-subscriber = "0.3.17"
+tracing-appender = "0.2.2"
 
 [build-dependencies]
 napi-build = "2.0.1"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@anysphere/file-service",
-  "version": "0.0.0-5d343fb9",
+  "version": "0.0.0-63cdba18",
   "main": "index.js",
   "types": "index.d.ts",
   "napi": {
@@ -35,11 +35,11 @@
     "version": "napi version"
   },
   "optionalDependencies": {
-    "@anysphere/file-service-win32-x64-msvc": "0.0.0-5d343fb9",
-    "@anysphere/file-service-darwin-x64": "0.0.0-5d343fb9",
-    "@anysphere/file-service-linux-x64-gnu": "0.0.0-5d343fb9",
-    "@anysphere/file-service-darwin-arm64": "0.0.0-5d343fb9",
-    "@anysphere/file-service-win32-arm64-msvc": "0.0.0-5d343fb9",
-    "@anysphere/file-service-darwin-universal": "0.0.0-5d343fb9"
+    "@anysphere/file-service-win32-x64-msvc": "0.0.0-63cdba18",
+    "@anysphere/file-service-darwin-x64": "0.0.0-63cdba18",
+    "@anysphere/file-service-linux-x64-gnu": "0.0.0-63cdba18",
+    "@anysphere/file-service-darwin-arm64": "0.0.0-63cdba18",
+    "@anysphere/file-service-win32-arm64-msvc": "0.0.0-63cdba18",
+    "@anysphere/file-service-darwin-universal": "0.0.0-63cdba18"
   }
 }

package/src/file_utils.rs

@@ -12,9 +12,8 @@ pub fn is_in_bad_dir(file_path: &Path) -> Result<bool, Error> {
   let item_path = file_path
     .to_str()
     .ok_or(anyhow::anyhow!("Failed to convert path to string"))?;
-  let is_bad_dir = (item_path.contains("node_modules")
-    || item_path.contains(".git"))
-    && !(item_path.ends_with(".git") || item_path.ends_with("node_modules"));
+  let is_bad_dir =
+    item_path.contains("node_modules") || item_path.contains(".git");
   Ok(is_bad_dir)
 }
 
@@ -38,14 +37,14 @@ pub fn is_good_file(file_path: &Path) -> Result<(), Error> {
 
   match file_name {
     "package-lock.json" | "pnpm-lock.yaml" | "yarn.lock" | "composer.lock"
-    | "Gemfile.lock" => {
+    | "Gemfile.lock" | "bun.lockb" => {
       return Err(anyhow::anyhow!("File is just a lock file"));
     }
     _ => {}
   }
 
   match extension {
-    "lock" | "bak" | "tmp" | "bin" | "exe" | "dll" | "so" => {
+    "lock" | "bak" | "tmp" | "bin" | "exe" | "dll" | "so" | "lockb" => {
       return Err(anyhow::anyhow!("File is just a lock file"));
     }
     _ => {}

package/src/git_utils.rs

@@ -1,10 +1,10 @@
 use std::collections::HashSet;
-use std::path::PathBuf;
 use std::process::Command;
 
 pub fn list_ignored_files(
   workspace_root_path: &str,
-) -> Result<HashSet<PathBuf>, Box<dyn std::error::Error>> {
+  should_return_absolute_paths: bool,
+) -> Result<HashSet<String>, Box<dyn std::error::Error>> {
   let mut gitignored_files = HashSet::new();
 
   let commands = vec![
@@ -15,12 +15,66 @@ pub fn list_ignored_files(
       "--ignored",
       "--exclude-standard",
     ],
+    // FIXME(sualeh): this is super sketchy and might totally break in like a bazillion ways. i dont like it.
+    vec![
+      "sh",
+      "-c",
+      "git submodule foreach --quiet 'git ls-files --others --ignored --exclude-standard | sed \"s|^|$path/|\"'",
+    ],
+  ];
+
+  for command in commands {
+    let output = Command::new(&command[0])
+      .args(&command[1..])
+      .current_dir(workspace_root_path)
+      .output()?;
+
+    if output.status.success() {
+      let files = String::from_utf8(output.stdout)?
+        .lines()
+        .filter(|line| !line.is_empty())
+        .map(|line| {
+          if should_return_absolute_paths {
+            let mut path = std::path::PathBuf::from(workspace_root_path);
+            path.push(line);
+
+            match path.canonicalize() {
+              Ok(canonical_path) => {
+                canonical_path.to_string_lossy().into_owned()
+              }
+              Err(_) => String::from(line),
+            }
+          } else {
+            String::from(line)
+          }
+        })
+        .collect::<HashSet<_>>();
+
+      gitignored_files.extend(files);
+    }
+  }
+
+  Ok(gitignored_files)
+}
+
+pub fn list_ignored_files_with_absolute_paths(
+  workspace_root_path: &str,
+) -> Result<HashSet<String>, Box<dyn std::error::Error>> {
+  let mut gitignored_files = HashSet::new();
+
+  let commands = vec![
     vec![
       "git",
-      "submodule",
-      "foreach",
-      "--quiet",
-      "git ls-files --others --ignored --exclude-standard | sed 's|^|$path/|'",
+      "ls-files",
+      "--others",
+      "--ignored",
+      "--exclude-standard",
+    ],
+    // FIXME(sualeh): this is super sketchy and might totally break in like a bazillion ways. i dont like it.
+    vec![
+      "sh",
+      "-c",
+      "git submodule foreach --quiet 'git ls-files --others --ignored --exclude-standard | sed \"s|^|$path/|\"'",
     ],
   ];
 
@@ -34,7 +88,7 @@ pub fn list_ignored_files(
       let files = String::from_utf8(output.stdout)?
         .lines()
         .filter(|line| !line.is_empty())
-        .map(|line| PathBuf::from(line))
+        .map(|line| String::from(line))
         .collect::<HashSet<_>>();
 
       gitignored_files.extend(files);
@@ -66,7 +120,8 @@ mod tests {
   #[test]
   fn test_no_ignored_files() {
     let dir = tempfile::tempdir().unwrap();
-    let gitignored_files = list_ignored_files(dir.path().to_str().unwrap()).unwrap();
+    let gitignored_files =
+      list_ignored_files(dir.path().to_str().unwrap(), false).unwrap();
     Command::new("git")
       .args(&["init"])
       .current_dir(dir.path())
@@ -92,13 +147,14 @@ mod tests {
       .current_dir(dir.path())
       .output()
       .unwrap();
-    let gitignored_files = list_ignored_files(dir.path().to_str().unwrap()).unwrap();
+    let gitignored_files =
+      list_ignored_files(dir.path().to_str().unwrap(), false).unwrap();
     println!(
       "ignored files for test_one_ignored_file: {:?}",
       gitignored_files
     );
     // assert_eq!(gitignored_files.len(), 1);
-    assert!(gitignored_files.contains(&PathBuf::from("ignored.txt")));
+    assert!(gitignored_files.contains(&String::from("ignored.txt")));
   }
 
   #[test]
@@ -121,19 +177,83 @@ mod tests {
       .current_dir(dir.path())
       .output()
       .unwrap();
-    let gitignored_files = list_ignored_files(dir.path().to_str().unwrap()).unwrap();
+    let gitignored_files =
+      list_ignored_files(dir.path().to_str().unwrap(), false).unwrap();
     println!(
       "ignored files for test_multiple_ignored_files: {:?}",
       gitignored_files
     );
     // assert_eq!(gitignored_files.len(), 2);
-    assert!(gitignored_files.contains(&PathBuf::from("ignored1.txt")));
-    assert!(gitignored_files.contains(&PathBuf::from("ignored2.txt")));
+    assert!(gitignored_files.contains(&String::from("ignored1.txt")));
+    assert!(gitignored_files.contains(&String::from("ignored2.txt")));
+  }
+
+  #[test]
+  fn test_git_submodule_ignored_files() {
+    let dir = tempfile::tempdir().unwrap();
+    let submodule_path = dir.path().join("submodule");
+    std::fs::create_dir(&submodule_path).unwrap();
+
+    let o = Command::new("git")
+      .args(&["init"])
+      .current_dir(&submodule_path)
+      .output()
+      .unwrap();
+    println!("git init output: {:?}", o);
+
+    let file_path = submodule_path.join("ignored.txt");
+    let mut file = File::create(&file_path).unwrap();
+    writeln!(file, "This is an ignored file.").unwrap();
+
+    let file2 = submodule_path.join("ignored2.txt");
+    let mut file = File::create(&file2).unwrap();
+    writeln!(file, "This is another ignored file.").unwrap();
+
+    let gitignore_path = submodule_path.join(".gitignore");
+    let mut gitignore = File::create(&gitignore_path).unwrap();
+    writeln!(gitignore, "*.txt").unwrap();
+
+    let o = Command::new("git")
+      .args(&["init"])
+      .current_dir(dir.path())
+      .output()
+      .unwrap();
+    println!("git init output: {:?}", o);
+
+    // make a commit in the submodule
+    let o = Command::new("git")
+      .args(&["add", "."])
+      .current_dir(&submodule_path)
+      .output()
+      .unwrap();
+    println!("git add output: {:?}", o);
+    let o = Command::new("git")
+      .args(&["commit", "-m", "initial commit"])
+      .current_dir(&submodule_path)
+      .output()
+      .unwrap();
+    println!("git commit output: {:?}", o);
+
+    let o = Command::new("git")
+      .args(&["submodule", "add", "./submodule"])
+      .current_dir(dir.path())
+      .output()
+      .unwrap();
+    println!("git submodule add output: {:?}", o);
+
+    let gitignored_files =
+      list_ignored_files(dir.path().to_str().unwrap(), false).unwrap();
+    println!(
+      "ignored files for test_git_submodule_ignored_files: {:?}",
+      gitignored_files
+    );
+    assert!(gitignored_files.contains(&String::from("submodule/ignored.txt")));
+    assert!(gitignored_files.contains(&String::from("submodule/ignored2.txt")));
   }
 
   #[test]
   fn test_multiple_ignored_files_in_current_dir() {
-    let gitignored_files = list_ignored_files(".").unwrap();
+    let gitignored_files = list_ignored_files(".", false).unwrap();
     assert!(gitignored_files.len() > 1);
 
     // print a sample of the ignored files
@@ -147,7 +267,6 @@ mod tests {
     }
   }
 
-
   #[tokio::test]
   async fn test_file_not_ignored() {
     let dir = tempfile::tempdir().unwrap();
@@ -160,7 +279,10 @@ mod tests {
       .current_dir(dir.path())
       .output()
       .unwrap();
-    let is_ignored = is_git_ignored(dir.path().to_str().unwrap(), "not_ignored.txt").await.unwrap();
+    let is_ignored =
+      is_git_ignored(dir.path().to_str().unwrap(), "not_ignored.txt")
+        .await
+        .unwrap();
     assert_eq!(is_ignored, false);
   }
 
@@ -180,7 +302,10 @@ mod tests {
       .current_dir(dir.path())
       .output()
       .unwrap();
-    let is_ignored = is_git_ignored(dir.path().to_str().unwrap(), "ignored.txt").await.unwrap();
+    let is_ignored =
+      is_git_ignored(dir.path().to_str().unwrap(), "ignored.txt")
+        .await
+        .unwrap();
     assert_eq!(is_ignored, true);
   }
 
@@ -200,8 +325,10 @@ mod tests {
       .current_dir(dir.path())
       .output()
       .unwrap();
-    let is_ignored = is_git_ignored(dir.path().to_str().unwrap(), "ignored.txt").await.unwrap();
+    let is_ignored =
+      is_git_ignored(dir.path().to_str().unwrap(), "ignored.txt")
+        .await
+        .unwrap();
     assert_eq!(is_ignored, true);
   }
-
 }

package/src/lib.rs

@@ -1,4 +1,5 @@
 #![deny(clippy::all)]
+#![deny(unsafe_op_in_unsafe_fn)]
 pub mod file_utils;
 pub mod git_utils;
 pub mod merkle_tree;
@@ -6,6 +7,9 @@ pub mod merkle_tree;
 use std::vec;
 
 use merkle_tree::{LocalConstruction, MerkleTree};
+use tracing::{info, Level};
+use tracing_appender::rolling::{RollingFileAppender, Rotation};
+use tracing_subscriber::fmt;
 
 #[macro_use]
 extern crate napi_derive;
@@ -14,15 +18,35 @@ extern crate napi_derive;
 pub struct MerkleClient {
   tree: MerkleTree,
   root_directory: String,
+  _guard: tracing_appender::non_blocking::WorkerGuard,
+}
+
+pub fn init_logger() -> tracing_appender::non_blocking::WorkerGuard {
+  let file_appender =
+    RollingFileAppender::new(Rotation::NEVER, "./", "rust_log.txt");
+  let (non_blocking, _guard) = tracing_appender::non_blocking(file_appender);
+  let subscriber = fmt::Subscriber::builder()
+    .with_max_level(Level::TRACE)
+    .with_writer(non_blocking)
+    .with_ansi(false)
+    .with_line_number(true)
+    .finish();
+
+  let _ = tracing::subscriber::set_global_default(subscriber);
+
+  _guard
 }
 
 #[napi]
 impl MerkleClient {
   #[napi(constructor)]
   pub fn new(root_directory: String) -> MerkleClient {
+    let _guard = init_logger();
+
     MerkleClient {
       tree: MerkleTree::empty_tree(),
       root_directory,
+      _guard,
     }
   }
 
@@ -31,7 +55,9 @@ impl MerkleClient {
     // 1. compute the merkle tree
     // 2. update the backend
     // 3. sync with the remote
-    self.compute_merkle_tree().await?;
+    unsafe {
+      self.compute_merkle_tree().await?;
+    }
 
     Ok(())
   }
@@ -47,6 +73,17 @@ impl MerkleClient {
     let t =
       MerkleTree::construct_merkle_tree(self.root_directory.clone()).await;
 
+    let files = self.tree.get_all_files().await;
+
+    match files {
+      Ok(files) => {
+        info!("files: {:?}", files);
+      }
+      Err(e) => {
+        info!("Error in get_all_files: {:?}", e);
+      }
+    }
+
     match t {
       Ok(tree) => {
         self.tree = tree;
@@ -74,9 +111,13 @@ impl MerkleClient {
     &self,
     relative_path: String,
   ) -> Result<String, napi::Error> {
+    info!("relative_path: {:?}", relative_path);
     let absolute_path =
       std::path::Path::new(&self.root_directory).join(relative_path);
-    let hash = self.tree.get_subtree_hash(absolute_path).await;
+    let canonical_path = absolute_path.canonicalize().unwrap();
+
+    info!("canonical_path: {:?}", canonical_path);
+    let hash = self.tree.get_subtree_hash(canonical_path).await;
 
     match hash {
       Ok(hash) => Ok(hash),
@@ -104,8 +145,10 @@ impl MerkleClient {
     &self,
     relative_path: String,
   ) -> Result<i32, napi::Error> {
-    let absolute_path =
-      std::path::Path::new(&self.root_directory).join(relative_path);
+    let absolute_path = std::path::Path::new(&self.root_directory)
+      .join(relative_path)
+      .canonicalize()?;
+
     let num = self
       .tree
       .get_num_embeddable_files_in_subtree(absolute_path)
@@ -166,7 +209,10 @@ impl MerkleClient {
         // TODO(sualeh): we should assert that the path is ascending up to the path.
 
         let ret = vec![file];
+        info!("file: {:?}", ret);
+
         let ret = ret.into_iter().chain(path.into_iter()).collect::<Vec<_>>();
+        info!("ret to js: {:?}", ret);
 
         Ok(ret)
       }

package/src/merkle_tree/local_construction.rs

@@ -1,11 +1,11 @@
+use crate::git_utils;
 use crate::merkle_tree::{
   File, MerkleNode, MerkleNodePtr, NodeType, PinnedFuture,
 };
 
 use super::{LocalConstruction, MerkleTree};
-use std::collections::BTreeMap;
-use std::path::PathBuf;
-use std::{collections::HashMap, path::Path, sync::Arc};
+use std::collections::{BTreeMap, HashSet};
+use std::path::{Path, PathBuf};
 use tonic::async_trait;
 
 #[async_trait]
@@ -29,20 +29,30 @@ impl LocalConstruction for MerkleTree {
   /// 3. construct merkle tree
   /// 4. return merkle tree
   async fn construct_merkle_tree(
-    root_directory: String,
+    absolute_path_to_root_directory: String,
   ) -> Result<MerkleTree, anyhow::Error> {
-    let path = PathBuf::from(root_directory.clone());
+    let path = PathBuf::from(absolute_path_to_root_directory.clone());
     if !path.exists() {
       // FIXME: we should report this via a good logger.
       panic!("Root directory does not exist!");
     }
 
-    let root_node = MerkleNode::new(path, None).await;
+    // 1. get all the gitignored files
+    let git_ignored_files = match git_utils::list_ignored_files(
+      absolute_path_to_root_directory.as_str(),
+      true,
+    ) {
+      Ok(git_ignored) => git_ignored,
+      Err(_e) => HashSet::new(),
+    };
+
+    let root_node = MerkleNode::new(path, None, &git_ignored_files).await;
     let mut mt = MerkleTree {
       root: root_node,
       files: BTreeMap::new(),
-      root_path: root_directory,
+      root_path: absolute_path_to_root_directory,
       cursor: None,
+      git_ignored_files,
     };
 
     // we now iterate over all the nodes and add them to the hashmap

package/src/merkle_tree/mod.rs

@@ -1,10 +1,11 @@
 use super::file_utils;
 use sha2::Digest;
-use std::collections::BTreeMap;
+use std::collections::{BTreeMap, HashSet};
 use std::path::PathBuf;
 use std::{fs, path::Path, sync::Arc};
 use tokio::sync::RwLock;
 use tonic::async_trait;
+use tracing::info;
 pub mod local_construction;
 pub mod test;
 
@@ -15,6 +16,7 @@ pub struct MerkleTree {
   root: MerkleNodePtr,
   files: BTreeMap<String, File>,
   cursor: Option<usize>,
+  git_ignored_files: HashSet<String>,
 }
 
 #[derive(Debug)]
@@ -91,6 +93,7 @@ impl MerkleTree {
       files: BTreeMap::new(),
       root_path: "".to_string(),
       cursor: None,
+      git_ignored_files: HashSet::new(),
     }
   }
 
@@ -301,26 +304,51 @@ impl MerkleTree {
     Ok(files)
   }
 
+  // TODO(sualeh): i need tests for this!!
   pub async fn get_spline(
     &self,
     absolute_path: &str,
   ) -> Result<Vec<String>, anyhow::Error> {
+    info!("get_spline called with absolute_path: {}", absolute_path);
     let mut files = Vec::new();
 
     let current_node = match self.files.get(absolute_path) {
-      Some(node) => node.node.clone(),
-      None => return Err(anyhow::anyhow!("File not found: {}", absolute_path)),
+      Some(node) => {
+        info!("Found node for absolute_path: {}", absolute_path);
+        node.node.clone()
+      }
+      None => {
+        info!("File not found for absolute_path: {}", absolute_path);
+        return Err(anyhow::anyhow!("File not found: {}", absolute_path));
+      }
     };
+
     let mut stack = Vec::new();
     stack.push(current_node);
 
     while let Some(node) = stack.pop() {
       let parent = node.read().await.parent.clone();
       if let Some(parent) = parent {
-        files.push(parent.read().await.hash.clone());
+        info!("Adding parent hash to files vector");
+        {
+          let parent_node = parent.read().await;
+          match &parent_node.node_type {
+            NodeType::File(file_name) => {
+              files.push(file_name.clone());
+            }
+            NodeType::Branch((branch_name, _)) => {
+              files.push(branch_name.clone());
+            }
+            _ => {
+              continue;
+            }
+          }
+        }
+
         stack.push(parent);
       }
     }
+    info!("Returning files vector with {} elements", files.len());
     Ok(files)
   }
 
@@ -363,8 +391,12 @@ impl MerkleTree {
       0 => {
         // this means that the ancestor is the root.
         // we need to create a new node and attach it to the ancestor.
-        let new_node =
-          MerkleNode::new(file_path.clone(), Some(ancestor.clone())).await;
+        let new_node = MerkleNode::new(
+          file_path.clone(),
+          Some(ancestor.clone()),
+          &self.git_ignored_files,
+        )
+        .await;
         ancestor.write().await.attach_child(new_node.clone()).await;
         new_node
       }
@@ -375,9 +407,12 @@ impl MerkleTree {
         // UNSURE: not sure this is the correct thing to do but it is the fastest.
         // get the last thing that is not in the tree.
         let first_child_path = path.last().unwrap();
-        let first_child =
-          MerkleNode::new(first_child_path.clone(), Some(ancestor.clone()))
-            .await;
+        let first_child = MerkleNode::new(
+          first_child_path.clone(),
+          Some(ancestor.clone()),
+          &self.git_ignored_files,
+        )
+        .await;
 
         // TODO(sualeh): we should do an assertion check that the entire vec is contained here.
 
@@ -654,18 +689,34 @@ use std::future::Future;
 use std::pin::Pin;
 
 type PinnedFuture<'a, T> = Pin<Box<dyn Future<Output = T> + Send + 'a>>;
+type IgnoredFiles = HashSet<String>;
 
 impl MerkleNode {
   /// please be careful using this.
   async fn __new_unchecked(
     file_or_directory: String,
     parent: ParentPtr,
+    ignored_files: &IgnoredFiles,
   ) -> MerkleNodePtr {
-    MerkleNode::construct_node(Path::new(&file_or_directory), parent).await
+    MerkleNode::construct_node(
+      Path::new(&file_or_directory),
+      parent,
+      ignored_files,
+    )
+    .await
   }
 
-  async fn new(file_or_directory: PathBuf, parent: ParentPtr) -> MerkleNodePtr {
-    MerkleNode::construct_node(Path::new(&file_or_directory), parent).await
+  async fn new(
+    absolute_file_or_directory: PathBuf,
+    parent: ParentPtr,
+    ignored_files: &IgnoredFiles,
+  ) -> MerkleNodePtr {
+    MerkleNode::construct_node(
+      Path::new(&absolute_file_or_directory),
+      parent,
+      ignored_files,
+    )
+    .await
   }
 
   /// NOT added to the tree by default.
@@ -676,38 +727,40 @@ impl MerkleNode {
   // 		let file_hash = self.files.get_mut(&file_path).unwrap();
 
   fn construct_node<'a>(
-    file_or_directory: &'a Path,
+    absolute_file_or_directory: &'a Path,
     parent: ParentPtr,
+    ignored_files: &'a IgnoredFiles,
   ) -> PinnedFuture<'a, MerkleNodePtr> {
     Box::pin(async move {
       // check if it is a file
-      let path_str = file_or_directory.to_str().unwrap().to_string();
-      if file_or_directory.is_file() {
+      let path_str = absolute_file_or_directory.to_str().unwrap().to_string();
+      if absolute_file_or_directory.is_file() {
         return Arc::new(RwLock::new(
           MerkleNode::construct_file_node_or_error_node(
-            file_or_directory,
+            absolute_file_or_directory,
             parent,
+            ignored_files,
           )
           .await,
         ));
       }
 
       // check if the directory fails the bad dir test.
-      let is_bad_dir = file_utils::is_in_bad_dir(file_or_directory);
+      let is_bad_dir = file_utils::is_in_bad_dir(absolute_file_or_directory);
       if is_bad_dir.is_err() || is_bad_dir.unwrap_or(false) {
         // println!("skipping directory: {}", path_str);
         return Arc::new(RwLock::new(MerkleNode::empty_node(
-          Some(file_or_directory),
+          Some(absolute_file_or_directory),
           Some("Directory is in bad dir!".to_string()),
         )));
       }
 
-      let entries = fs::read_dir(file_or_directory);
+      let entries = fs::read_dir(absolute_file_or_directory);
       match entries {
         Ok(_) => (),
         Err(e) => {
           return Arc::new(RwLock::new(MerkleNode::empty_node(
-            Some(file_or_directory),
+            Some(absolute_file_or_directory),
             Some(e.to_string()),
           )));
         }
@@ -727,13 +780,17 @@ impl MerkleNode {
         match entry {
           Ok(entry) => {
             children.push(
-              MerkleNode::construct_node(&entry.path(), Some(node.clone()))
-                .await,
+              MerkleNode::construct_node(
+                &entry.path(),
+                Some(node.clone()),
+                ignored_files,
+              )
+              .await,
             );
           }
           Err(e) => {
             children.push(Arc::new(RwLock::new(MerkleNode::empty_node(
-              Some(file_or_directory),
+              Some(absolute_file_or_directory),
               Some(e.to_string()),
             ))));
           }
@@ -753,23 +810,33 @@ impl MerkleNode {
   }
 
   async fn construct_file_node(
-    file_path: &Path,
+    absolute_file_path: &Path,
     parent: ParentPtr,
+    ignored_files: &IgnoredFiles,
   ) -> Result<MerkleNode, String> {
-    let file_str = file_path
+    let file_str = absolute_file_path
       .to_str()
       .ok_or("Could not convert file path to string!")?
       .to_string();
     // first see if it passes the
-    match file_utils::is_good_file(file_path) {
+    match file_utils::is_good_file(absolute_file_path) {
       Ok(_) => {}
       Err(e) => {
         return Err(format!("File failed runtime checks! {}", e.to_string()));
       }
     }
 
+    // check if the file is in the git ignore buffer.
+    // this is a bug right because we are not checking absoluteness here.
+    match ignored_files.contains(&file_str) {
+      true => {
+        return Err(format!("File is in git ignore buffer!"));
+      }
+      false => {}
+    }
+
     // read the file_content to a buffer
-    let file_content = match tokio::fs::read(file_path).await {
+    let file_content = match tokio::fs::read(absolute_file_path).await {
       Ok(content) => content,
       Err(e) => {
         return Err(format!("Could not read file! {}", e.to_string()));
@@ -777,7 +844,11 @@ impl MerkleNode {
     };
 
     // check if the file passes runtime checks.
-    match file_utils::is_good_file_runtime_check(file_path, &file_content).await
+    match file_utils::is_good_file_runtime_check(
+      absolute_file_path,
+      &file_content,
+    )
+    .await
     {
       Ok(_) => {}
       Err(e) => {
@@ -808,15 +879,22 @@ impl MerkleNode {
   }
 
   async fn construct_file_node_or_error_node(
-    file_path: &Path,
+    absolute_file_path: &Path,
     parent: ParentPtr,
+    ignored_files: &IgnoredFiles,
   ) -> MerkleNode {
-    let node = match MerkleNode::construct_file_node(file_path, parent).await {
+    let node = match MerkleNode::construct_file_node(
+      absolute_file_path,
+      parent,
+      ignored_files,
+    )
+    .await
+    {
       Ok(node) => node,
       Err(e) => {
         // println!("constructing error node. error: {}", e);
         // println!("file_path: {:?}", file_path);
-        MerkleNode::empty_node(Some(file_path), Some(e))
+        MerkleNode::empty_node(Some(absolute_file_path), Some(e))
       }
     };
 

package/src/test.rs

@@ -0,0 +1,5 @@
+#[cfg(test)]
+mod tests {
+  use super::super::*;
+  use std::path::PathBuf;
+}