@antzsoft/chat-core 1.1.0 → 1.1.1

package/docs/integration-guide.html

@@ -457,6 +457,48 @@ section.sec>h2:hover{color:#fff}
         </div>
       </div>
 
+      <div class="wn-item" id="wn-109-7">
+        <div class="wn-item-header" onclick="toggleItem('wn-109-7')">
+          <span class="wn-tag fix">Fix</span>
+          <span class="wn-item-title">Removed user could re-enter conversation room via <code>join_room</code></span>
+          <span class="wn-chevron-sm">▾</span>
+        </div>
+        <div class="wn-item-body">
+          <p>The socket access check for <code>join_room</code> was missing the <code>isActive</code> participant check. A removed user whose client re-emitted <code>joinRoom</code> (e.g. on reconnect or by navigating back to the chat screen) would be silently re-admitted to the conversation room and continue receiving <code>new_message</code> events. The check now requires <code>isActive: true</code>, consistent with the write-access check.</p>
+          <p><strong>Action required:</strong> None. Server-side fix only.</p>
+        </div>
+      </div>
+
+      <div class="wn-item" id="wn-109-8">
+        <div class="wn-item-header" onclick="toggleItem('wn-109-8')">
+          <span class="wn-tag fix">Fix</span>
+          <span class="wn-item-title">Re-added user's conversation missing from list when they had previously deleted it</span>
+          <span class="wn-chevron-sm">▾</span>
+        </div>
+        <div class="wn-item-body">
+          <p>When a user deleted a conversation (<code>isHidden: true</code>), was then removed from the group, and later re-added by an admin, the conversation never reappeared in their list. The reactivation path now resets <code>isHidden</code> to <code>false</code> alongside <code>isActive</code>.</p>
+          <p>Additionally, the server now server-side joins the re-added user's active sockets into the conversation room and emits <code>conversation_created</code> to their personal room so the conversation appears immediately — no reconnect or <code>joinRoom</code> call needed.</p>
+          <p><strong>Action required:</strong> None. Server-side fix only. Existing <code>conversation_created → joinRoom</code> listeners remain safe (idempotent).</p>
+        </div>
+      </div>
+
+      <div class="wn-item" id="wn-109-9">
+        <div class="wn-item-header" onclick="toggleItem('wn-109-9')">
+          <span class="wn-tag new">New</span>
+          <span class="wn-item-title">Optional <code>role</code> parameter on <code>addParticipants</code></span>
+          <span class="wn-chevron-sm">▾</span>
+        </div>
+        <div class="wn-item-body">
+          <p><code>addParticipants</code> now accepts an optional <code>role</code> parameter (<code>'admin' | 'member'</code>, default <code>'member'</code>). This applies to both newly added users and previously removed users being re-added. A former admin who is re-added without specifying <code>role: 'admin'</code> will come back as a member — their previous role is never silently restored.</p>
+          <pre><code><span class="cm">// Default — added as member (backward compatible)</span>
+<span class="kw">await</span> conversationsApi.<span class="fn">addParticipants</span>(conversationId, [<span class="str">'user-3'</span>]);
+
+<span class="cm">// Explicitly add as admin</span>
+<span class="kw">await</span> conversationsApi.<span class="fn">addParticipants</span>(conversationId, [<span class="str">'user-3'</span>], <span class="str">'admin'</span>);</code></pre>
+          <p><strong>Action required:</strong> None for existing code — the parameter is optional and defaults to <code>'member'</code>. No call sites need updating unless you want to add members as admins directly.</p>
+        </div>
+      </div>
+
     </div>
   </div>
 
@@ -1536,7 +1578,8 @@ chatClient.<span class="fn">disconnect</span>();
 
 <span class="cm">// Participants</span>
 <span class="kw">const</span> members = <span class="kw">await</span> conversationsApi.<span class="fn">getMembers</span>(conversationId);
-<span class="kw">await</span> conversationsApi.<span class="fn">addParticipants</span>(conversationId, [<span class="str">'user-3'</span>]);
+<span class="kw">await</span> conversationsApi.<span class="fn">addParticipants</span>(conversationId, [<span class="str">'user-3'</span>]);               <span class="cm">// added as member (default)</span>
+<span class="kw">await</span> conversationsApi.<span class="fn">addParticipants</span>(conversationId, [<span class="str">'user-3'</span>], <span class="str">'admin'</span>);  <span class="cm">// added as admin</span>
 <span class="kw">await</span> conversationsApi.<span class="fn">removeParticipant</span>(conversationId, <span class="str">'user-2'</span>);
 <span class="kw">await</span> conversationsApi.<span class="fn">updateParticipantRole</span>(conversationId, <span class="str">'user-1'</span>, <span class="str">'admin'</span>);
 
@@ -1582,16 +1625,15 @@ chatClient.<span class="fn">disconnect</span>();
 
   <h4>When to call <code>joinRoom</code></h4>
   <p>
-    There is only one real use case — when the <strong>user is added to a conversation while their socket is already connected</strong>
-    (either someone created a new group and added them, or they were added to an existing group at runtime).
-    The server does <strong>not</strong> auto-join the user's socket to the new room — it only emits <code>conversation_created</code>
-    to the user's personal room. Without calling <code>joinRoom</code>, the socket will not receive any
-    <code>new_message</code>, <code>typing_indicator</code>, or other room events for that conversation.
+    When the <strong>user is added to a conversation while their socket is already connected</strong>, the server now automatically joins their active sockets into the new room and emits <code>conversation_created</code> to their personal room. No <code>joinRoom</code> call is required — <code>new_message</code>, <code>typing_indicator</code>, and all other room events will arrive immediately.
+  </p>
+  <p>
+    Calling <code>joinRoom</code> on <code>conversation_created</code> is still safe (idempotent) and can be kept for defensive compatibility, but is no longer necessary:
   </p>
 
-  <pre><code><span class="cm">// Fires when you're added to a new or existing conversation at runtime</span>
+  <pre><code><span class="cm">// Optional — server already handles this automatically</span>
 client.socket.<span class="fn">on</span>(<span class="str">'conversation_created'</span>, (conv) => {
-  client.socket.emit.<span class="fn">joinRoom</span>(conv.id);
+  client.socket.emit.<span class="fn">joinRoom</span>(conv.id); <span class="cm">// safe no-op if already in room</span>
 });</code></pre>
 
   <p><code>leaveRoom</code> is only needed if you want to intentionally stop receiving events for a room the user is still a member of (e.g. archiving client-side). It is not needed when navigating away from a screen.</p>
@@ -1622,9 +1664,9 @@ client.socket.<span class="fn">on</span>(<span class="str">'new_message'</span>,
   });
 });
 
-<span class="cm">// Only case where joinRoom is needed</span>
+<span class="cm">// Optional — server auto-joins the room, but this is safe to keep</span>
 client.socket.<span class="fn">on</span>(<span class="str">'conversation_created'</span>, (conv) => {
-  client.socket.emit.<span class="fn">joinRoom</span>(conv.id);
+  client.socket.emit.<span class="fn">joinRoom</span>(conv.id); <span class="cm">// idempotent no-op if already joined</span>
 });</code></pre>
   </div>
   <div data-p="node">
@@ -1635,6 +1677,7 @@ client.socket.<span class="fn">on</span>(<span class="str">'new_message'</span>,
   client.socket.emit.<span class="fn">markRead</span>(message.conversationId, message.id);
 });
 
+<span class="cm">// Optional — server auto-joins the room, but safe to keep</span>
 client.socket.<span class="fn">on</span>(<span class="str">'conversation_created'</span>, (conv) => {
   client.socket.emit.<span class="fn">joinRoom</span>(conv.id);
 });</code></pre>
@@ -1644,7 +1687,7 @@ client.socket.<span class="fn">on</span>(<span class="str">'conversation_created
     <strong>Summary of rules:</strong>
     <ul>
       <li>All existing rooms are auto-joined on socket connect — no <code>joinRoom</code> needed on screen open.</li>
-      <li>Call <code>joinRoom</code> only after a <code>conversation_created</code> event.</li>
+      <li>When added to a conversation at runtime, the server now auto-joins the socket room and emits <code>conversation_created</code>. No <code>joinRoom</code> call needed, but safe to keep for compatibility.</li>
       <li>Add the <code>new_message</code> listener once at app root, never per screen.</li>
       <li>Use <code>message.conversationId</code> to route to the right view or badge update.</li>
       <li>Track <code>activeConversationId</code> to decide whether to increment the unread count.</li>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antzsoft/chat-core",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "Platform-agnostic core for Antz Chat — API, socket, stores, types. Works in browser, React Native (Expo or bare), and Node.js.",
   "author": "Antz",
   "license": "MIT",