@antora/playbook-builder 3.1.10 → 3.1.11

package/lib/build-playbook.js

@@ -2,8 +2,12 @@
 
 const convict = require('./solitary-convict')
 const defaultSchema = require('./config/schema')
-const fs = require('fs')
-const ospath = require('path')
+const fs = require('node:fs')
+const ospath = require('node:path')
+const parseArgs = require('yargs-parser')
+const yaml = require('js-yaml')
+
+const COERCE_SCHEMA = yaml.FAILSAFE_SCHEMA
 
 /**
  * Builds a playbook object according to the provided schema from the specified
@@ -28,8 +32,22 @@ const ospath = require('path')
  *   marked in the schema as preserve, all keys in the playbook are camelCased.
  */
 function buildPlaybook (args = [], env = process.env, schema = defaultSchema, beforeValidate = undefined) {
-  const config = Object.assign(convict(schema, { args, env }), { getModel })
-  const playbook = config.has('playbook') && config.get('playbook')
+  const parsedArgs = parseArgs(args, { configuration: { 'dot-notation': false } })
+  const opts = { args: [], env: {} }
+  const config = Object.assign(convict(schema, opts), { getModel, getSchema })
+  Object.assign(opts, { args, env })
+  let playbook
+  if ('playbook' in schema) {
+    const playbookEnv = schema.playbook.env
+    if (playbookEnv != null) playbook = env[playbookEnv]
+    const playbookArg = schema.playbook.arg
+    if (playbookArg != null) playbook = parsedArgs[playbookArg] ?? playbook
+    if (playbook === undefined) {
+      if (config.has('playbook')) playbook = config.get('playbook')
+    } else {
+      config.set('playbook', playbook)
+    }
+  }
   let absPlaybookPath
   if (playbook) {
     if (ospath.extname((absPlaybookPath = ospath.resolve(playbook)))) {
@@ -50,10 +68,11 @@ function buildPlaybook (args = [], env = process.env, schema = defaultSchema, be
     }
   }
   try {
-    if (playbook) {
-      config.loadFile(absPlaybookPath)
-      if (playbook !== absPlaybookPath) config.set('playbook', absPlaybookPath)
-    }
+    Object.assign(opts, { args: [] })
+    playbook ? config.loadFile(absPlaybookPath) : config.load({})
+    importArguments(config, parsedArgs)
+    Object.assign(opts, { args })
+    if (playbook && playbook !== absPlaybookPath) config.set('playbook', absPlaybookPath)
     const beforeValidateFromSchema = config._def[Symbol.for('convict.beforeValidate')]
     if (beforeValidateFromSchema) beforeValidateFromSchema(config)
     if (beforeValidate) beforeValidate(config)
@@ -82,9 +101,8 @@ function camelCaseKeys (o, stopPaths = [], p = '') {
 function getModel (name) {
   let config = this
   const data = config.get(name)
-  let schema = config._schema
+  const schema = config.getSchema(name)
   if (name) {
-    schema = name.split('.').reduce((accum, key) => accum._cvtProperties[key], schema)
     config = Object.assign(convict(name.split('.').reduce((def, key) => def[key], config._def)), { _instance: data })
   }
   config.validate({ allowed: 'strict' })
@@ -97,6 +115,10 @@ function getModel (name) {
   return model
 }
 
+function getSchema (name) {
+  return name ? name.split('.').reduce((accum, key) => accum._cvtProperties[key], this._schema) : this._schema
+}
+
 function getStopPaths (schemaProperties, schemaPath = [], stopPaths = []) {
   for (const [key, { preserve, _cvtProperties }] of Object.entries(schemaProperties)) {
     if (preserve) {
@@ -110,6 +132,22 @@ function getStopPaths (schemaProperties, schemaPath = [], stopPaths = []) {
   return stopPaths
 }
 
+function importArguments (config, args) {
+  for (const [argName, configKey] of Object.entries(config._argv)) {
+    const argVal = args[argName]
+    if (argVal === undefined) continue
+    const argFormat = config.getSchema(configKey).format
+    let argValStr = argVal
+    if (argFormat === 'map' || argFormat === 'primitive-map') {
+      const dumpOpts = { condenseFlow: true, flowLevel: 0, quotingType: '"' }
+      argValStr = yaml.dump(Array.isArray(argVal) ? argVal : [argVal], dumpOpts)
+    } else if (Array.isArray(argVal)) {
+      argValStr = argVal.join(',')
+    }
+    config.set(configKey, argValStr)
+  }
+}
+
 function getDetails (playbook, absPlaybookPath) {
   if (playbook === absPlaybookPath) return ''
   return ` (${ospath.isAbsolute(playbook) ? '' : 'cwd: ' + process.cwd() + ', '}playbook: ${playbook})`

package/lib/config/schema.js

@@ -170,6 +170,11 @@ module.exports = {
       format: 'int',
       default: 1,
     },
+    fetch_depth: {
+      doc: 'Preferred number of commits to fetch from remote repository. 0 indicates full history.',
+      format: 'int',
+      default: 1,
+    },
     plugins: {
       credential_manager: {
         doc: 'A require request for a plugin to replace the built-in credential manager used by the git client.',

package/lib/solitary-convict.js

@@ -5,8 +5,9 @@ const json = require('json5')
 const toml = require('@iarna/toml')
 const yaml = require('js-yaml')
 
-const ARGS_SCANNER_RX = /(?:([^=,]+)|(?==))(?:,|$|=(|("|').*?\3|[^,]+)(?:,|$))/g
+const ARG_RX = /(?:([^=]+)|(?==))(?:$|=(|("|').*?\3|.*)(?:$))/
 const PRIMITIVE_TYPES = [Boolean, Number, String]
+const COERCE_SCHEMA = yaml.FAILSAFE_SCHEMA
 const YAML_SCHEMA = yaml.CORE_SCHEMA.extend({ implicit: [yaml.types.merge] })
 
 /**
@@ -51,13 +52,14 @@ function registerFormats (convict) {
     coerce: (val, config, name) => {
       if (config == null) return val
       const accum = config.has(name) ? config.get(name) : {}
-      let match
-      ARGS_SCANNER_RX.lastIndex = 0
-      while ((match = ARGS_SCANNER_RX.exec(val))) {
-        const [, k, v = ''] = match
+      const entries = yaml.load(val, { schema: COERCE_SCHEMA })
+      for (const entry of Array.isArray(entries) ? entries : [entries]) {
+        let k, v, match
+        if (!(match = entry.match(ARG_RX))) continue
+        ;[, k, v = ''] = match
         if (!k) continue
         let parsed = v
-        if (parsed && parsed !== '-') {
+        if (v && v !== '-') {
           try {
             parsed = yaml.load(v, { schema: yaml.CORE_SCHEMA })
           } catch {}
@@ -83,20 +85,18 @@ function registerFormats (convict) {
     coerce: (val, config, name) => {
       if (config == null) return val
       const accum = config.has(name) ? config.get(name) : {}
-      let match
-      ARGS_SCANNER_RX.lastIndex = 0
-      while ((match = ARGS_SCANNER_RX.exec(val))) {
-        const [, k, v] = match
-        if (k) {
-          let parsed
-          if (v && v !== '-') {
-            parsed = yaml.load(v, { schema: yaml.CORE_SCHEMA })
-            if (parsed && PRIMITIVE_TYPES.indexOf(parsed.constructor) < 0) parsed = v
-          } else {
-            parsed = v || ''
-          }
-          accum[~k.indexOf('-') ? k.replace(/-/g, '_') : k] = parsed
+      const entries = yaml.load(val, { schema: COERCE_SCHEMA })
+      for (const entry of Array.isArray(entries) ? entries : [entries]) {
+        let k, v, match
+        if (!(match = entry.match(ARG_RX))) continue
+        ;[, k, v = ''] = match
+        if (!k) continue
+        let parsed = v
+        if (v && v !== '-') {
+          parsed = yaml.load(v, { schema: yaml.CORE_SCHEMA })
+          if (parsed && PRIMITIVE_TYPES.indexOf(parsed.constructor) < 0) parsed = v
         }
+        accum[~k.indexOf('-') ? k.replace(/-/g, '_') : k] = parsed
       }
       return accum
     },
@@ -104,19 +104,19 @@ function registerFormats (convict) {
   convict.addFormat({
     name: 'require-array',
     validate: (val) => {
-      if (!Array.isArray(val)) throw new Error('must be of type Array')
+      if (!Array.isArray(val)) throw new Error('must be an array')
     },
     coerce: (val, config, name) => {
       const accum = config?.has(name) ? config.get(name) : []
-      val.split(',').forEach((v) => {
-        if (~accum.indexOf(v)) return
+      for (const v of val.split(',')) {
+        if (~accum.indexOf(v)) continue
         const match = accum.find((it) => it.constructor === Object && it.id === v)
         if (match) {
           if (match.enabled === false) match.enabled = true
         } else {
           accum.push(v)
         }
-      })
+      }
       return accum
     },
   })
@@ -124,7 +124,7 @@ function registerFormats (convict) {
     name: 'boolean-or-string',
     validate: (val) => {
       if (!(val == null || val.constructor === String || val.constructor === Boolean)) {
-        throw new Error('must be a boolean or string')
+        throw new Error('must be a boolean, string, or null')
       }
     },
   })
@@ -166,6 +166,10 @@ function registerFormats (convict) {
       }
       if (~parsedUrl.pathname.indexOf('%20')) throw new Error('pathname segment must not contain spaces')
     },
+    coerce: (val) => {
+      if (!val || val === '~') return null
+      return val.length > 1 && val.charAt(val.length - 1) === '/' ? val.slice(0, -1) : val
+    },
   })
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antora/playbook-builder",
-  "version": "3.1.10",
+  "version": "3.1.11",
   "description": "Builds a playbook object from user input for configuring successive documentation components in an Antora pipeline.",
   "license": "MPL-2.0",
   "author": "OpenDevise Inc. (https://opendevise.com)",
@@ -12,7 +12,8 @@
   "homepage": "https://antora.org",
   "repository": {
     "type": "git",
-    "url": "git+https://gitlab.com/antora/antora.git"
+    "url": "git+https://gitlab.com/antora/antora.git",
+    "directory": "packages/playbook-builder"
   },
   "bugs": {
     "url": "https://gitlab.com/antora/antora/issues"
@@ -29,10 +30,11 @@
     "@iarna/toml": "~2.2",
     "convict": "~6.2",
     "js-yaml": "~4.1",
-    "json5": "~2.2"
+    "json5": "~2.2",
+    "yargs-parser": "~20.2"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.0.0"
   },
   "files": [
     "lib/"
@@ -47,7 +49,7 @@
   ],
   "scripts": {
     "test": "_mocha",
-    "prepublishOnly": "npx -y downdoc --prepublish",
-    "postpublish": "npx -y downdoc --postpublish"
+    "prepublishOnly": "npx -y downdoc@latest --prepublish",
+    "postpublish": "npx -y downdoc@latest --postpublish"
   }
 }