@antoneeo/kb-agentic-skill 1.19.0 → 1.21.0

package/skills/kb-agentic-skill/scripts/sdlc_check.py

@@ -1,62 +1,62 @@
-#!/usr/bin/env python3
-"""Knowledge lens entry point. Ship with sdlc_core.py and knowledge.py."""
-import sys
-from pathlib import Path
-sys.path.insert(0, str(Path(__file__).resolve().parent))
-try:
-    import sdlc_core
-except ImportError as exc:
-    sys.stderr.write("[ERROR] missing sdlc_core.py: %s\n"
-                     "Copy entry point, sdlc_core.py and knowledge.py together.\n" % exc)
-    sys.exit(1)
-from sdlc_core import *
-from sdlc_core import _map_refs
-import knowledge
-from knowledge import *
-from knowledge import _kb_extra_validate, _kb_original_candidates
-
-DOMAIN = "knowledge"
-
-sdlc_core.set_entry_point(DOMAIN, provides=("code", "knowledge"))
-
-sdlc_core.set_profile(
-    skill_name="kb-agentic",
-    unit_noun="topic",
-    support_files=("templates.md", "taxonomy.md", "guides.md", "vision.md",
-                   "distillation.md", "reconciliation.md", "elicitation.md",
-                   "review.md", "dispatch.md", "routing.md", "portability.md",
-                   "ENFORCEMENT.md", "memory.md"),
-    capabilities=(
-        # spine
-        "triage", "write_triggers", "workstream_registry", "vision_gate",
-        "design_review_gate", "guide_router", "worktree_hygiene",
-        # knowledge overlay
-        # `knowledge_portability` (F-030) is deliberately NOT declared: the
-        # capability vocabulary lives in the shared spine, and no shared test
-        # guards on portability, so adding a label there would mean editing
-        # sdlc_core.py in three distributions to buy nothing.
-        "taxonomy_pass", "subagent_dispatch", "question_discipline",
-    ),
-    # F-046: the per-turn line moved from this file's own `remind` command into
-    # the shared spine, which now carries the machine for all three lenses. The
-    # kb duties below are unchanged; what is new is the first one -- an unread
-    # protocol cannot be applied, and until now nothing said so.
-    remind_line=(
-        "first decide if this skill governs the work; if yes, LOAD it once -- an "
-        "unread protocol cannot be applied. Triage: L1 quick fact, L2 propagation, "
-        "L3 new knowledge unit, Spike; declare the level. On this project's "
-        "domain, read topics/INDEX.md first and cite claim ids, or state no "
-        "coverage. Decisions today get recorded in the KB at close. Revising a "
-        "document? Re-read it whole and rewrite to current state -- never append "
-        "a delta."
-    ),
-    design_gate_between=("### 3. Request Analysis & Taxonomy Pass",
-                         "### 4. Knowledge Processing & Distillation"),
-)
-
-
-def main(argv=None):
-    return knowledge.main(argv)
-
-if __name__ == "__main__":
-    sys.exit(main())
+#!/usr/bin/env python3
+"""Knowledge lens entry point. Ship with sdlc_core.py and knowledge.py."""
+import sys
+from pathlib import Path
+sys.path.insert(0, str(Path(__file__).resolve().parent))
+try:
+    import sdlc_core
+except ImportError as exc:
+    sys.stderr.write("[ERROR] missing sdlc_core.py: %s\n"
+                     "Copy entry point, sdlc_core.py and knowledge.py together.\n" % exc)
+    sys.exit(1)
+from sdlc_core import *
+from sdlc_core import _map_refs
+import knowledge
+from knowledge import *
+from knowledge import _kb_extra_validate, _kb_original_candidates
+
+DOMAIN = "knowledge"
+
+sdlc_core.set_entry_point(DOMAIN, provides=("code", "knowledge"))
+
+sdlc_core.set_profile(
+    skill_name="kb-agentic",
+    unit_noun="topic",
+    support_files=("templates.md", "taxonomy.md", "guides.md", "vision.md",
+                   "distillation.md", "reconciliation.md", "elicitation.md",
+                   "review.md", "dispatch.md", "routing.md", "portability.md",
+                   "ENFORCEMENT.md", "memory.md"),
+    capabilities=(
+        # spine
+        "triage", "write_triggers", "workstream_registry", "vision_gate",
+        "design_review_gate", "guide_router", "worktree_hygiene",
+        # knowledge overlay
+        # `knowledge_portability` (F-030) is deliberately NOT declared: the
+        # capability vocabulary lives in the shared spine, and no shared test
+        # guards on portability, so adding a label there would mean editing
+        # sdlc_core.py in three distributions to buy nothing.
+        "taxonomy_pass", "subagent_dispatch", "question_discipline",
+    ),
+    # F-046: the per-turn line moved from this file's own `remind` command into
+    # the shared spine, which now carries the machine for all three lenses. The
+    # kb duties below are unchanged; what is new is the first one -- an unread
+    # protocol cannot be applied, and until now nothing said so.
+    remind_line=(
+        "first decide if this skill governs the work; if yes, LOAD it once -- an "
+        "unread protocol cannot be applied. Triage: L1 quick fact, L2 propagation, "
+        "L3 new knowledge unit, Spike; declare the level. On this project's "
+        "domain, read topics/INDEX.md first and cite claim ids, or state no "
+        "coverage. Decisions today get recorded in the KB at close. Revising a "
+        "document? Re-read it whole and rewrite to current state -- never append "
+        "a delta."
+    ),
+    design_gate_between=("### 3. Request Analysis & Taxonomy Pass",
+                         "### 4. Knowledge Processing & Distillation"),
+)
+
+
+def main(argv=None):
+    return knowledge.main(argv)
+
+if __name__ == "__main__":
+    sys.exit(main())

package/skills/kb-agentic-skill/scripts/sdlc_core.py

@@ -203,6 +203,11 @@ DOMAINS = {
         "risk_label": "## Threat Map / Plan Risks",
         "id_prefix": "M-",
     },
+    "course": {
+        "risk_section": ("## Learning and Content Risks",),
+        "risk_label": "## Learning and Content Risks",
+        "id_prefix": "C-",
+    },
 }
 # Absent everything -- no `default_domain:` line, no `domain:` field -- a project is
 # `code`. That is what every project created before this field existed already is,
@@ -1298,7 +1303,7 @@ def cmd_validate(root, strict=False, hybrid=False):
                               "have the user validate it")
 
     # ANALYSIS: frontmatter and mandatory sections
-    # Ids are unique WITHIN a domain (prefixes F-/K-/M- keep them apart in practice):
+    # Ids are unique WITHIN a domain (prefixes F-/K-/M-/C- keep them apart in practice):
     # two lenses over one tree must not collide on a number neither of them chose.
     seen_ids = {}
     default_domain = project_default_domain(root)
@@ -1349,10 +1354,10 @@ def cmd_validate(root, strict=False, hybrid=False):
                               "doing the work it triggers")
         # comment-stripped, anchored: a '<!-- TODO: the ## Capability Ledger -->'
         # must not read as the section being present
-        # Hybrid: the design lives in devPNT and its §4.5 gate owns this slot
-        # (the Hybrid ownership matrix: "run ONE of them, never both"), and its log
-        # rows are keyed on e_isp_/e_tdd_ doc_keys, not on this filename -- so
-        # firing here would be a permanent, unfixable false positive.
+        # Hybrid: the design lives in devPNT, and the agent review of it (the
+        # same review.md review, run before the proposal) logs a row keyed on
+        # its e_isp_/e_tdd_ doc_key, not on this filename -- so firing here
+        # would be a permanent, unfixable false positive.
         if not hybrid and design_review_due(meta) and not review_logged(root, p.name):
             advisories.append(f"{rel}: L3 in implementation with no design-review row in "
                               f"{review_log_rel()} -- the design was reviewed by nobody but its "
@@ -1864,15 +1869,26 @@ def print_orient_hook_note(root):
         pass  # detection must never break check
 
 
-def cmd_check(root, strict=False, hybrid=False):
+def cmd_check(root, strict=False, hybrid=False, extra_validate=None, extra_sections=()):
+    """An overlay adds its checks through the two hooks, never after the call:
+    the summary line is the verdict, so every check that can fail runs before
+    it. `extra_validate()` folds into the validate stage; each
+    (title, fn) in `extra_sections` gets its own banner and summary rc."""
     print("===== validate =====")
     rc_v = cmd_validate(root, strict=strict, hybrid=hybrid)
+    if extra_validate is not None:
+        rc_v = max(rc_v, extra_validate())
     print("\n===== stale =====")
     rc_s = cmd_stale(root, hybrid=hybrid)
-    print(f"\ncheck: {'CLEAN' if not (rc_v or rc_s) else 'NOT CLEAN'} "
-          f"(validate rc={rc_v}, stale rc={rc_s})")
+    rcs = [("validate", rc_v), ("stale", rc_s)]
+    for title, fn in extra_sections:
+        print(f"\n===== {title} =====")
+        rcs.append((title, fn()))
+    failed = any(rc for _, rc in rcs)
+    print(f"\ncheck: {'NOT CLEAN' if failed else 'CLEAN'} "
+          f"({', '.join(f'{title} rc={rc}' for title, rc in rcs)})")
     print_orient_hook_note(root)
-    return 1 if (rc_v or rc_s) else 0
+    return 1 if failed else 0
 
 
 # --------------------------------------------------------------------- gate

package/skills/kb-agentic-skill/templates.md

@@ -20,6 +20,8 @@ supersedes: old_doc.md       # only if it replaces another canonical doc
 
 When a doc replaces another: the new one declares `supersedes:`, the old one switches to `status: SUPERSEDED` (it stays as history, do not delete it). `sdlc_check.py validate` warns if `status` is missing or if a superseded doc is still `CURRENT`.
 
+For a course in the same `ai_docs/` tree, `vision/features/VISION_course_<slug>.md` and `solutions/ANALYSIS_course_<slug>.md` declare `domain: course` explicitly and the ANALYSIS uses a `C-` ID. The feature Vision is scoped to that course; the project-wide Vision stays above all four domains. Course design belongs to `course-creator`.
+
 ## ai_docs/reference/GUIDE_[topic].md
 
 A guide is either OPERATIVE (`source_kind: document` — distilled from USER-PROVIDED
@@ -441,7 +443,7 @@ One row per completed review (`review.md` §When a review is due). Append-only;
 is the record that the gate ran and what it was worth. **One schema for both
 modes** — one required CORE (`date`, `doc_key`, `tier`, `model`, `findings_raised`,
 `findings_real`, `verdict`, `revise_rounds`) plus each mode's own realization
-columns: Standalone adds `reviewer`, a Hybrid devPNT row adds `instrument` and
+columns: Standalone adds `reviewer`, a Hybrid row adds `instrument` and
 `notes` and carries no `reviewer` at all. Both modes write this same file.
 
 ```markdown