@antoneeo/agentic-sdlc-skill 1.36.0 → 1.38.0

package/skills/agentic-sdlc-skill/scripts/sdlc_check.py

@@ -1,71 +1,71 @@
-#!/usr/bin/env python3
-# -*- coding: utf-8 -*-
-"""Domain entry point with shared project memory.
-
-Ship this file, sdlc_core.py and knowledge.py together. The core alone omits
-knowledge integrity and this entry point\'s domain-specific behavior.
-"""
-import sys
-from pathlib import Path
-
-sys.path.insert(0, str(Path(__file__).resolve().parent))
-
-try:
-    import sdlc_core
-except ImportError as exc:  # pragma: no cover - exercised by TS12, not by unit tests
-    sys.stderr.write(
-        "[ERROR] sdlc_check.py cannot find sdlc_core.py next to it: " + str(exc) + "\n"
-        "        The validator needs entry point, sdlc_core.py and knowledge.py.\n"
-        "        Copy all three together; core alone omits memory and overlay checks.\n")
-    sys.exit(1)
-
-# Re-export the core's surface: existing importers (`import sdlc_check as sc`)
-# and the test batteries reach for these names on this module.
-from sdlc_core import *            # noqa: F401,F403
-from sdlc_core import _map_refs    # noqa: F401  underscore helper used by the batteries
-import knowledge
-
-# The domain this distribution implements. It does NOT decide any document's
-# owning domain -- that is resolved per project (`default_domain:` in the docs
-# root's README) and per artifact (`domain:`), so the same tree gets the same
-# verdict from every installed distribution. What it decides is which portable
-# checks a document may import here by name; the rest warn as unavailable.
-DOMAIN = "code"
-
-sdlc_core.set_entry_point(DOMAIN, provides=("code", "knowledge"))
-
-# What this distribution carries. The shared battery reads it; the spine
-# capabilities are not optional, and a shared test refuses a profile that drops one.
-sdlc_core.set_profile(
-    skill_name="agentic-sdlc",
-    unit_noun="feature",
-    support_files=("templates.md", "architect.md", "guides.md", "vision.md", "tdd.md",
-                   "debugging.md", "elicitation.md", "review.md", "dispatch.md",
-                   "routing.md", "hybrid.md", "ENFORCEMENT.md", "memory.md"),
-    capabilities=(
-        # spine
-        "triage", "write_triggers", "workstream_registry", "vision_gate",
-        "design_review_gate", "guide_router", "worktree_hygiene",
-        # code overlay
-        "architect_pass", "interaction_contract", "comprehension_guides", "tdd",
-        "subagent_dispatch", "legacy_narrative_handoff", "question_discipline",
-    ),
-    design_gate_between=("### 3. Request Analysis", "### 4. Development and Testing"),
-    remind_line=(
-        "first decide if this skill governs the work; if yes, LOAD it once -- an "
-        "unread protocol cannot be applied. Declare the level (L1/L2/L3/Spike) "
-        "and the guide-router verdict before acting; an imperative is a request "
-        "to triage. Name the mechanism before fixing the first defect you can "
-        "measure -- symptom patches recur and stack. Replay governing text -- "
-        "doctrine, a prompt, a schema -- against the case that motivated it: red "
-        "under the old text, green under the new."
-    ),
-)
-
-
-def main(argv=None):
-    return knowledge.main(argv)
-
-
-if __name__ == "__main__":
-    sys.exit(main())
+#!/usr/bin/env python3
+# -*- coding: utf-8 -*-
+"""Domain entry point with shared project memory.
+
+Ship this file, sdlc_core.py and knowledge.py together. The core alone omits
+knowledge integrity and this entry point\'s domain-specific behavior.
+"""
+import sys
+from pathlib import Path
+
+sys.path.insert(0, str(Path(__file__).resolve().parent))
+
+try:
+    import sdlc_core
+except ImportError as exc:  # pragma: no cover - exercised by TS12, not by unit tests
+    sys.stderr.write(
+        "[ERROR] sdlc_check.py cannot find sdlc_core.py next to it: " + str(exc) + "\n"
+        "        The validator needs entry point, sdlc_core.py and knowledge.py.\n"
+        "        Copy all three together; core alone omits memory and overlay checks.\n")
+    sys.exit(1)
+
+# Re-export the core's surface: existing importers (`import sdlc_check as sc`)
+# and the test batteries reach for these names on this module.
+from sdlc_core import *            # noqa: F401,F403
+from sdlc_core import _map_refs    # noqa: F401  underscore helper used by the batteries
+import knowledge
+
+# The domain this distribution implements. It does NOT decide any document's
+# owning domain -- that is resolved per project (`default_domain:` in the docs
+# root's README) and per artifact (`domain:`), so the same tree gets the same
+# verdict from every installed distribution. What it decides is which portable
+# checks a document may import here by name; the rest warn as unavailable.
+DOMAIN = "code"
+
+sdlc_core.set_entry_point(DOMAIN, provides=("code", "knowledge"))
+
+# What this distribution carries. The shared battery reads it; the spine
+# capabilities are not optional, and a shared test refuses a profile that drops one.
+sdlc_core.set_profile(
+    skill_name="agentic-sdlc",
+    unit_noun="feature",
+    support_files=("templates.md", "architect.md", "guides.md", "vision.md", "tdd.md",
+                   "debugging.md", "elicitation.md", "review.md", "dispatch.md",
+                   "routing.md", "hybrid.md", "ENFORCEMENT.md", "memory.md"),
+    capabilities=(
+        # spine
+        "triage", "write_triggers", "workstream_registry", "vision_gate",
+        "design_review_gate", "guide_router", "worktree_hygiene",
+        # code overlay
+        "architect_pass", "interaction_contract", "comprehension_guides", "tdd",
+        "subagent_dispatch", "legacy_narrative_handoff", "question_discipline",
+    ),
+    design_gate_between=("### 3. Request Analysis", "### 4. Development and Testing"),
+    remind_line=(
+        "first decide if this skill governs the work; if yes, LOAD it once -- an "
+        "unread protocol cannot be applied. Declare the level (L1/L2/L3/Spike) "
+        "and the guide-router verdict before acting; an imperative is a request "
+        "to triage. Name the mechanism before fixing the first defect you can "
+        "measure -- symptom patches recur and stack. Replay governing text -- "
+        "doctrine, a prompt, a schema -- against the case that motivated it: red "
+        "under the old text, green under the new."
+    ),
+)
+
+
+def main(argv=None):
+    return knowledge.main(argv)
+
+
+if __name__ == "__main__":
+    sys.exit(main())

package/skills/agentic-sdlc-skill/scripts/sdlc_core.py

@@ -203,6 +203,11 @@ DOMAINS = {
         "risk_label": "## Threat Map / Plan Risks",
         "id_prefix": "M-",
     },
+    "course": {
+        "risk_section": ("## Learning and Content Risks",),
+        "risk_label": "## Learning and Content Risks",
+        "id_prefix": "C-",
+    },
 }
 # Absent everything -- no `default_domain:` line, no `domain:` field -- a project is
 # `code`. That is what every project created before this field existed already is,
@@ -1298,7 +1303,7 @@ def cmd_validate(root, strict=False, hybrid=False):
                               "have the user validate it")
 
     # ANALYSIS: frontmatter and mandatory sections
-    # Ids are unique WITHIN a domain (prefixes F-/K-/M- keep them apart in practice):
+    # Ids are unique WITHIN a domain (prefixes F-/K-/M-/C- keep them apart in practice):
     # two lenses over one tree must not collide on a number neither of them chose.
     seen_ids = {}
     default_domain = project_default_domain(root)
@@ -1349,10 +1354,10 @@ def cmd_validate(root, strict=False, hybrid=False):
                               "doing the work it triggers")
         # comment-stripped, anchored: a '<!-- TODO: the ## Capability Ledger -->'
         # must not read as the section being present
-        # Hybrid: the design lives in devPNT and its §4.5 gate owns this slot
-        # (the Hybrid ownership matrix: "run ONE of them, never both"), and its log
-        # rows are keyed on e_isp_/e_tdd_ doc_keys, not on this filename -- so
-        # firing here would be a permanent, unfixable false positive.
+        # Hybrid: the design lives in devPNT, and the agent review of it (the
+        # same review.md review, run before the proposal) logs a row keyed on
+        # its e_isp_/e_tdd_ doc_key, not on this filename -- so firing here
+        # would be a permanent, unfixable false positive.
         if not hybrid and design_review_due(meta) and not review_logged(root, p.name):
             advisories.append(f"{rel}: L3 in implementation with no design-review row in "
                               f"{review_log_rel()} -- the design was reviewed by nobody but its "
@@ -1864,15 +1869,26 @@ def print_orient_hook_note(root):
         pass  # detection must never break check
 
 
-def cmd_check(root, strict=False, hybrid=False):
+def cmd_check(root, strict=False, hybrid=False, extra_validate=None, extra_sections=()):
+    """An overlay adds its checks through the two hooks, never after the call:
+    the summary line is the verdict, so every check that can fail runs before
+    it. `extra_validate()` folds into the validate stage; each
+    (title, fn) in `extra_sections` gets its own banner and summary rc."""
     print("===== validate =====")
     rc_v = cmd_validate(root, strict=strict, hybrid=hybrid)
+    if extra_validate is not None:
+        rc_v = max(rc_v, extra_validate())
     print("\n===== stale =====")
     rc_s = cmd_stale(root, hybrid=hybrid)
-    print(f"\ncheck: {'CLEAN' if not (rc_v or rc_s) else 'NOT CLEAN'} "
-          f"(validate rc={rc_v}, stale rc={rc_s})")
+    rcs = [("validate", rc_v), ("stale", rc_s)]
+    for title, fn in extra_sections:
+        print(f"\n===== {title} =====")
+        rcs.append((title, fn()))
+    failed = any(rc for _, rc in rcs)
+    print(f"\ncheck: {'NOT CLEAN' if failed else 'CLEAN'} "
+          f"({', '.join(f'{title} rc={rc}' for title, rc in rcs)})")
     print_orient_hook_note(root)
-    return 1 if (rc_v or rc_s) else 0
+    return 1 if failed else 0
 
 
 # --------------------------------------------------------------------- gate

package/skills/agentic-sdlc-skill/templates.md

@@ -14,14 +14,14 @@ Every durable canonical document opens with this frontmatter: it feeds the gener
 description: One line — what the document is and when to read it.
 status: CURRENT              # CURRENT | SUPERSEDED | DRAFT | DEPRECATED
 supersedes: old_doc.md       # only if it replaces another canonical doc
-domain: code                 # optional — code | knowledge | marketing; omit in a single-domain project
+domain: code                 # optional — code | knowledge | marketing | course
 ---
 # Document Title
 ```
 
 When a doc replaces another: the new one declares `supersedes:`, the old one switches to `status: SUPERSEDED` (it stays as history, do not delete it). `sdlc_check.py validate` warns if `status` is missing or if a superseded doc is still `CURRENT`.
 
-**`domain:` — write it only when it says something.** It names the domain whose fidelity discipline the document was written under, and it *records* an answer the work already has; it never decides one. Omit it and the project default applies (`default_domain:` in `ai_docs/README.md`, absent → `code`), so a single-domain project never writes the field at all. Documents under `vision/` sit above the split and take no `domain:`. In a mixed project, a wrong or forgotten field surfaces as a validation error on the missing mandatory risk section — never as a silent pass.
+**`domain:` — write it only when it says something.** It names the domain whose fidelity discipline the document was written under, and it *records* an answer the work already has; it never decides one. Omit it and the project default applies (`default_domain:` in `ai_docs/README.md`, absent → `code`), so a single-domain project never writes the field at all. Project-wide documents under `vision/` sit above the split. A course's feature Vision is the exception: `vision/features/VISION_course_<slug>.md` carries `domain: course` explicitly, even in a marketing-default project, so its owner remains unambiguous. In a mixed project, a wrong or forgotten field surfaces as a validation error on the missing mandatory risk section — never as a silent pass.
 
 ## ai_docs/reference/GUIDE_[topic].md
 
@@ -216,7 +216,7 @@ Only for features spanning multiple ANALYSIS documents or multiple milestones: o
 
 The frontmatter is the source of truth for the feature state (the `features_history.md` index is generated from it).
 
-`domain:` and `checks:` are optional and only earn their place in a project where more than one lens is installed (see the canonical-header note above for how an omitted `domain:` resolves). `checks:` names **portable checks** imported from another domain — e.g. `domain: knowledge` with `checks: [marketing.funnel]`. An imported check can only ADD findings, never relax what the owning domain requires, so importing one is always safe; naming a check this installation does not carry produces a visible warning, never a silent pass. `id:` is unique **within a domain**, and its prefix says which: `F-` code, `K-` knowledge, `M-` marketing. Projects that predate the prefixes keep their `F-` ids — uniqueness was already scoped to the one domain they have.
+`domain:` and `checks:` are optional for ordinary analyses and only earn their place in a project where more than one lens is installed; a course ANALYSIS always declares `domain: course`. `checks:` names **portable checks** imported from another domain — e.g. `domain: knowledge` with `checks: [marketing.funnel]`. An imported check can only ADD findings, never relax what the owning domain requires, so importing one is always safe; naming a check this installation does not carry produces a visible warning, never a silent pass. `id:` is unique **within a domain**, and its prefix says which: `F-` code, `K-` knowledge, `M-` marketing, `C-` course. Projects that predate the prefixes keep their `F-` ids — uniqueness was already scoped to the one domain they have.
 
 ```markdown
 ---
@@ -226,7 +226,7 @@ status: PLANNED
 level: L3
 start_date: 2026-06-11
 end_date:
-domain: code                    # optional — code | knowledge | marketing
+domain: code                    # optional — code | knowledge | marketing | course
 checks: [marketing.funnel]      # optional — extra portable checks to run on this document
 ---
 # Feature Analysis: [Name]
@@ -501,7 +501,7 @@ One row per completed review (`review.md` §When a review is due). Append-only;
 is the record that the gate ran and what it was worth. **One schema for both
 modes** — one required CORE (`date`, `doc_key`, `tier`, `model`, `findings_raised`,
 `findings_real`, `verdict`, `revise_rounds`) plus each mode's own realization
-columns: Standalone adds `reviewer`, a Hybrid devPNT row adds `instrument` and
+columns: Standalone adds `reviewer`, a Hybrid row adds `instrument` and
 `notes` and carries no `reviewer` at all. Both modes write this same file.
 
 ```markdown