@antoneeo/agentic-sdlc-skill 1.26.0 → 1.26.1

package/CHANGELOG.md

@@ -2,6 +2,53 @@
 
 Tutte le modifiche significative a questa skill saranno documentate in questo file.
 
+## [1.26.1 / kb 1.4.7 / mkt 0.4.7] - 2026-08-06
+
+The late design review of F-034 (`review.md` row 1b, run after 1.26.0 had shipped because the
+gate had been skipped) returned FAIL with four blockers. Three were defects in the shipped
+doctrine and are fixed here; the fourth was a governance-record gap, fixed in `ai_docs/`.
+
+### Fixed
+- **`dispatch.md` contradicted the scoped re-review it delegates to `review.md` to define.**
+  It said "exactly three review touches per task, never a loop" and "not an extra review slot",
+  while `review.md` requires every review-driven correction to be re-reviewed — so an agent
+  executing a dispatched plan received two irreconcilable instructions. Reconciled: the scoped
+  re-review is a round **inside** slot 2 or 3, never a fourth slot; "never a loop" bounds the
+  slots, not the rounds within one. (Shared spine — the contradiction had shipped in all three
+  distributions; `dispatch.md` was missing from 1.26.0's impact map.)
+- **The claim-to-evidence rule had no enforcement point.** Its acceptance criterion promised a
+  completion claim without fresh proof would be "nameable by the closure review", but
+  `review.md` §Reviewing had no such finding class and the reviewer is never handed `SKILL.md`.
+  Added: an unproven or stale completion claim — including one resting on a narrower check than
+  the claim needs, or on a delegated agent's report rather than the diff — is now a finding.
+- **`SKILL.md`'s branch hygiene contradicted its own destructive guard.** One bullet ordered the
+  agent to "clean up the branch/worktree; never leave orphan branches"; the next reserved
+  destruction for the user's explicit request. The cleanup is now PROPOSED once the user has
+  chosen, with the anti-orphan duty kept as something to raise rather than to perform.
+- **Two gaps in the scoped re-review's own wording:** a PASS that carried findings is now
+  explicitly provisional until its corrections pass a round (the commonest real case, previously
+  unruled — the rule's trigger fired but its gate was already behind the fixes); and the single
+  REVIEW_LOG row now carries the round-1 verdict alongside the final one (`FAIL → PASS`) instead
+  of collapsing a first-round FAIL into a bare PASS, which erased the evidence the same file
+  says logging exists to preserve.
+
+- **`revise_rounds` had no defined meaning**, in the very document `SKILL.md` names as the owner
+  of the review log's schema and column meanings — and the historical rows already used it both
+  ways. Defined: it counts **review rounds**, not fix cycles (the first review is round 1, each
+  scoped re-review adds one), so a review whose findings were corrected always reads ≥ 2 and 3 is
+  the ceiling. The `verdict` column's format is defined alongside it (`FAIL → PASS` when the
+  round-1 and final verdicts differ), and the second example row — which taught a bare `PASS`
+  after two real findings closed in one round — now teaches both rules instead of contradicting
+  one. Raised at the review's round-3 cap and fixed before release rather than deferred.
+
+### Changed
+- `ai_docs/solutions/ANALYSIS_execution_integrity.md` gains what the design review found
+  missing: the **ceremony-cost disclosure** Non-Goal 3 requires (measured on the shipped diff)
+  with the owner's explicit acceptance recorded; the **rulings placement** run per mechanism
+  against the ledger's own criterion (the previous claim used a narrower "user-facing" test the
+  ledger does not define); the **lens-scoping decision** stated; and a named disposition for the
+  chronic `stale` debt. No shipped file changes from these.
+
 ## [1.26.0 / kb 1.4.6 / mkt 0.4.6] - 2026-08-06
 
 ### Added

package/gemini-extension.json

@@ -1,6 +1,6 @@
 {
   "name": "agentic-sdlc-skill",
-  "version": "1.26.0",
+  "version": "1.26.1",
   "description": "Documentation-First SDLC protocol with triage, Vision governance and optional devPNT integration.",
   "author": "Antonio Pinto (https://github.com/Antoneeo)"
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antoneeo/agentic-sdlc-skill",
-  "version": "1.26.0",
+  "version": "1.26.1",
   "description": "Documentation-First SDLC protocol for Claude Code, Gemini CLI, Google Antigravity and Codex with risk triage, Vision governance, installed support files and optional devPNT integration.",
   "keywords": [
     "claude-code",

package/skills/agentic-sdlc-skill/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: agentic-sdlc
-version: 1.26.0
+version: 1.26.1
 description: Documentation-First SDLC protocol with risk-proportional triage, Vision as a guide, a complete Standalone mode and optional symbiosis with devPNT. Use for features, significant bugs, refactors, audits and documented maintenance.
 author: Antonio Pinto (https://github.com/Antoneeo)
 copyright: (c) 2026 Antonio Pinto
@@ -289,7 +289,7 @@ Hybrid L3:
 - If an architectural decision was taken (new pattern, layer or contract change, structural dependency), record an ADR before DONE — Standalone in `architecture/`, Hybrid propose the ADR/KL update in the devPNT DB. No decision, no ADR (Write Triggers).
 - In Standalone, if the project adopts `sdlc_check.py`, run `python <skill_dir>/scripts/sdlc_check.py check --root <project_root>` or the equivalent local copy.
 - Updated documents must travel in the same commit/PR as the code they describe.
-- **Branch/worktree hygiene**: an L3 ran on its own branch (Phase 4) — close it with an explicit merge decision (merge, keep open, or discard) and clean up the branch/worktree; never leave orphan branches. In Hybrid, the running devPNT server locks `.devpnt/*.db`, so the merge is done from a separate git worktree or via a ref-only push, never an in-place branch switch in the primary worktree.
+- **Branch/worktree hygiene**: an L3 ran on its own branch (Phase 4) — close it with an explicit merge decision (merge, keep open, or discard), and once the user has chosen, PROPOSE the branch/worktree cleanup their choice implies; an orphan branch left behind with nothing said is the failure this bullet prevents — the cleanup itself is theirs to authorize (next bullet). In Hybrid, the running devPNT server locks `.devpnt/*.db`, so the merge is done from a separate git worktree or via a ref-only push, never an in-place branch switch in the primary worktree.
 - **Destructive guards (integration is the user's; destruction is explicit).** The integration choice — merge, push/PR, keep — belongs to the user. Discard happens ONLY on the user's explicit request, and the confirmation names exactly what dies: the branch, its commits, the worktree path. Never force-push without explicit authorization; a rejected push means the remote moved — investigate, don't force. Never clean up a worktree this workflow did not create — the host or another workflow owns it. Repository-specific release/finish commands are the project guide layer's (the router in `## Operative Guides`): the skill owns this discipline, the matched `GUIDE_*.md` owns the commands — cite it, never restate it.
 
 ## ai_docs documents: two indexes + lifecycle

package/skills/agentic-sdlc-skill/dispatch.md

@@ -65,6 +65,15 @@ Exactly three review touches per task, never a loop:
 If a review FAILs, fix and re-run `verify` — that is a normal loop iteration
 via the ledger's fail path, not an extra review slot.
 
+**The scoped re-review is a round INSIDE slot 2 or 3, never a fourth slot.**
+`review.md` §Receiving requires every review-driven correction to be
+re-reviewed against the correction alone — that round belongs to the slot whose
+findings caused it, and is bounded by the same cap of 3 rounds. "Never a loop"
+bounds the SLOTS (no unbounded re-reviewing of a task), not the rounds inside
+one slot: a fix nobody looked at is the defect the round exists to catch. Slot 1
+is the implementer's own pass, not an independent review, so its fixes carry no
+re-review round. The ledger records the round on the task's fail path as usual.
+
 ## Ledger protocol summary
 
 Read → skip-if-done → dispatch-if-pending → write. The ledger is the only

package/skills/agentic-sdlc-skill/review.md

@@ -124,14 +124,20 @@ A fix made in response to a finding is new, unreviewed work — stopping after
 therefore gets a **scoped re-review** before the review can PASS: hand the
 re-reviewer the original findings and ONLY the correction (the fix diff/range
 for code, the amended sections for a document), and require a per-finding
-verdict — `ADDRESSED`, `NOT ADDRESSED`, or `CONTESTED` with evidence. The
-re-review also checks the correction itself for new blocker-level
-breakage — and nothing else: out-of-scope observations become separately
+verdict — `ADDRESSED`, `NOT ADDRESSED`, or `CONTESTED` with evidence. **A PASS
+that carried findings is provisional until its corrections pass that round** —
+the commonest real case is a PASS with non-blocking findings the author then
+fixes, and stopping there ships precisely the unreviewed version this rule
+exists to catch. The re-review also checks the correction itself for new
+blocker-level breakage — and nothing else: out-of-scope observations become separately
 recorded findings, never an extension of the loop. Expect two rounds as the
 norm, not the exception — round 1 finds, round 2 verifies the fixes — inside
 the same cap of 3 (§When a review is due). One logical review stays ONE
-REVIEW_LOG row, its rounds narrated inside; a scoped re-review is a round,
-not a new review.
+REVIEW_LOG row — a scoped re-review is a round, not a new review — with the
+rounds narrated in the row's notes and **the verdict column carrying the
+round-1 verdict and the final one (`FAIL → PASS`), never the final one alone**:
+a first-round FAIL is the highest-value evidence the gate produces (§When a
+review is due), and collapsing it into a bare `PASS` erases exactly that.
 
 ## Reviewing
 
@@ -145,6 +151,15 @@ When you are the reviewer:
   (see `## Requesting`).
 - Cite evidence as `file:line` for every finding — a finding without a
   location is not actionable.
+- **An unproven completion claim is a finding** (closure reviews, on the diff).
+  When the work under review states or implies that something passes, is fixed,
+  is clean or is complete, the evidence must be present and must post-date the
+  final relevant change; a claim resting on a stale run, on a narrower check
+  than the claim needs, or on a delegated agent's own report rather than the
+  diff, is a finding — name the claim and what would prove it. This is the
+  enforcement point of the author-side rule in `SKILL.md` §5 Closure, and the
+  reason a requester hands it over is that the reviewer cannot cite a rule it
+  was never given.
 - **Say what you could NOT verify.** When a claim in the artifact cannot be
   verified from the inputs you were given (it lives in unchanged code, another
   document, or an environment you cannot reach), report it as a

package/skills/agentic-sdlc-skill/templates.md

@@ -507,8 +507,8 @@ adds values to the existing columns rather than a second table.
 
 | date | doc_key | tier | reviewer | findings_raised | findings_real | verdict | revise_rounds |
 |---|---|---|---|---|---|---|---|
-| 2026-06-11 | ANALYSIS_login_sso.md | design | subagent (opus, fresh ctx) | 4 | 3 | PASS | 2 |
-| 2026-06-12 | diff feature/sso-login | closure | self-pass (declared; no subagent facility) | 2 | 2 | PASS | 1 |
+| 2026-06-11 | ANALYSIS_login_sso.md | design | subagent (opus, fresh ctx) | 4 | 3 | FAIL → PASS | 2 |
+| 2026-06-12 | diff feature/sso-login | closure | self-pass (declared; no subagent facility) | 2 | 2 | PASS with findings → corrections re-reviewed, PASS | 2 |
 
 ## Notes
 <!-- One short paragraph per review that found something worth remembering: what
@@ -527,6 +527,13 @@ records the realization actually used — fresh subagent, one-shot client run, o
 honest; writing nothing, or implying independence you did not have, is the failure
 this column exists to prevent. `findings_real` is how many raised findings survived
 triage: over time it is the only evidence of whether the gate earns its cost.
+`revise_rounds` counts **review rounds**, not fix cycles: the first review is round 1
+and every scoped re-review adds one. A review that produced findings which were then
+corrected therefore always reads ≥ 2 — the corrections are unreviewed work until a
+round verifies them (`review.md` §Receiving) — and 3 is the ceiling, past which the
+residue goes to the user rather than into a fourth round. `verdict` carries the
+round-1 verdict and the final one when they differ (`FAIL → PASS`): collapsing a
+first-round FAIL into a bare `PASS` erases the evidence this log exists to keep.
 Concurrent reviews: `init` writes a `.gitattributes` stanza giving this file
 `merge=union` — a **built-in** driver (no per-clone `git config`, unlike
 `merge=ours`, which silently does nothing until every clone configures it).