@antonbabenko/deliberation-mcp 3.6.2 → 3.7.0

package/dist/index.js

@@ -241,7 +241,10 @@ var require_provider = __commonJS({
     var STRIP_TRAIL = /[*_`~\s]+$/;
     var HEADING_RE = /^#{1,6}\s/;
     function normVerdict(tok) {
-      return tok.replace(/\s+/g, "_").toUpperCase();
+      return (
+        /** @type {any} */
+        tok.replace(/\s+/g, "_").toUpperCase()
+      );
     }
     function parseReview(text) {
       const raw = safeString(text);
@@ -259,36 +262,24 @@ var require_provider = __commonJS({
     function resolveVerdict(lines) {
       for (const ln of lines) {
         const m = ln.match(SENTINEL_RE);
-        if (m) return (
-          /** @type {any} */
-          normVerdict(m[1])
-        );
+        if (m) return normVerdict(m[1]);
       }
       for (const ln of lines) {
         const m = ln.match(VERDICT_RE);
-        if (m) return (
-          /** @type {any} */
-          normVerdict(m[1])
-        );
+        if (m) return normVerdict(m[1]);
       }
       for (let i = 0; i < lines.length; i++) {
         if (!VERDICT_WORD_RE.test(lines[i].trim())) continue;
         for (let j = i + 1; j < lines.length && j <= i + 3; j++) {
           const t = lines[j].replace(MD_EMPHASIS, "").trim();
           if (!t) continue;
-          if (TOKEN_LINE_RE.test(t)) return (
-            /** @type {any} */
-            normVerdict(t)
-          );
+          if (TOKEN_LINE_RE.test(t)) return normVerdict(t);
           break;
         }
       }
       const nonEmpty = lines.map((l) => l.replace(MD_EMPHASIS, "").trim()).filter((t) => t !== "");
       for (const t of [nonEmpty[0], nonEmpty[nonEmpty.length - 1]]) {
-        if (t && TOKEN_LINE_RE.test(t)) return (
-          /** @type {any} */
-          normVerdict(t)
-        );
+        if (t && TOKEN_LINE_RE.test(t)) return normVerdict(t);
       }
       return null;
     }
@@ -345,6 +336,7 @@ var require_consensus_loop = __commonJS({
     "use strict";
     var MAX_ROUNDS_DEFAULT = 5;
     var VERDICTS = Object.freeze(["APPROVE", "REQUEST_CHANGES", "REJECT"]);
+    var REVIEW_FORMAT_INSTRUCTION = "End with a line by itself in exactly this form (no markdown, token on the SAME line): VERDICT: APPROVE   (or VERDICT: REQUEST_CHANGES, or VERDICT: REJECT). Then list any critical issues, one per line as: - [category] description   where category is one of security, correctness, scope, ambiguity, performance, ops.";
     function assertStatus(state, expected, op) {
       if (state.status !== expected) {
         throw new Error(`${op}: expected status '${expected}', got '${state.status}'`);
@@ -387,12 +379,12 @@ ${state.currentPlan}`
       const peerPrompt = [
         body,
         "Review the plan for correctness, security, scope, ambiguity, performance, and ops gaps.",
-        "End with a line by itself in exactly this form (no markdown, token on the SAME line): VERDICT: APPROVE   (or VERDICT: REQUEST_CHANGES, or VERDICT: REJECT). Then list any critical issues, one per line as: - [category] description   where category is one of security, correctness, scope, ambiguity, performance, ops."
+        REVIEW_FORMAT_INSTRUCTION
       ].join("\n\n");
       const blindPrompt = [
         body,
         "Give your own independent verdict BEFORE seeing peer opinions.",
-        "End with a line by itself in exactly this form (no markdown, token on the SAME line): VERDICT: APPROVE   (or VERDICT: REQUEST_CHANGES, or VERDICT: REJECT). Then list any critical issues, one per line as: - [category] description   where category is one of security, correctness, scope, ambiguity, performance, ops."
+        REVIEW_FORMAT_INSTRUCTION
       ].join("\n\n");
       return { peerPrompt, blindPrompt };
     }
@@ -1699,24 +1691,27 @@ var require_antigravity = __commonJS({
       );
       if (!bridge) throw new Error("makeAntigravityProvider requires opts.bridge (core is transport-agnostic; inject the gemini bridge)");
       const model = opts.model || process.env.GEMINI_DEFAULT_MODEL || "auto-gemini-3";
+      const allowImplement = opts.allowImplement === true;
       return {
         name: "gemini",
-        capabilities: { canImplement: true, fileUpload: false, multiTurn: true, walksFilesystem: true },
+        // canImplement reflects the construction lock so discovery (panel) is honest about THIS process.
+        capabilities: { canImplement: allowImplement, fileUpload: false, multiTurn: true, walksFilesystem: true },
         async health() {
           return typeof bridge.runGemini === "function" ? { ok: true } : { ok: false, reason: "agy bridge unavailable" };
         },
         async ask(req) {
           const started = Date.now();
+          const implement = allowImplement && req.mode === "implement";
           const includeDirs = (req.files || []).filter((f) => f.dir).map((f) => f.dir);
           const args = bridge.buildAgyArgs({
             prompt: req.prompt,
             model,
-            sandbox: "read-only",
+            sandbox: implement ? "workspace-write" : "read-only",
             developerInstructions: req.developerInstructions,
             includeDirs
           });
           try {
-            const out = await bridge.runGemini(args, req.cwd, req.timeoutMs, void 0, { readOnly: true, includeDirs });
+            const out = await bridge.runGemini(args, req.cwd, req.timeoutMs, void 0, { readOnly: !implement, includeDirs });
             return { provider: "gemini", model, text: out.response || "", threadId: out.threadId, isError: false, ms: Date.now() - started, reasoningEffort: null, ...out.workspaceMutated ? { workspaceMutated: true } : {} };
           } catch (e) {
             const err = (
@@ -1751,12 +1746,13 @@ var require_codex = __commonJS({
       if (s.includes("rate")) return { errorKind: "rate-limit", retryable: true };
       return { errorKind: "unknown", retryable: false };
     }
-    function codexExecArgs() {
-      return ["exec", "--sandbox", "read-only", "--skip-git-repo-check"];
+    function codexExecArgs(mode) {
+      const sandbox = mode === "implement" ? "workspace-write" : "read-only";
+      return ["exec", "--sandbox", sandbox, "--skip-git-repo-check"];
     }
-    function defaultRun({ prompt, cwd, timeoutMs }) {
+    function defaultRun({ prompt, cwd, timeoutMs, mode }) {
       return new Promise((resolve) => {
-        const child = spawn("codex", codexExecArgs(), { cwd: cwd || process.cwd() });
+        const child = spawn("codex", codexExecArgs(mode), { cwd: cwd || process.cwd() });
         let stdout = "", stderr = "", settled = false;
         const timer = timeoutMs ? setTimeout(() => child.kill("SIGKILL"), timeoutMs) : null;
         if (timer) timer.unref();
@@ -1780,21 +1776,24 @@ var require_codex = __commonJS({
     function makeCodexProvider(opts = {}) {
       const run = opts.run || defaultRun;
       const model = opts.model || "default";
+      const allowImplement = opts.allowImplement === true;
       return {
         name: "codex",
-        capabilities: { canImplement: true, fileUpload: false, multiTurn: false, walksFilesystem: true },
-        // Option A: no threadId continuity
+        // canImplement reflects the construction lock so discovery (panel) is honest about THIS
+        // process. Option A: no threadId continuity (multiTurn:false).
+        capabilities: { canImplement: allowImplement, fileUpload: false, multiTurn: false, walksFilesystem: true },
         async health() {
           return { ok: true };
         },
         async ask(req) {
           const started = Date.now();
+          const mode = allowImplement && req.mode === "implement" ? "implement" : "advisory";
           const full = req.developerInstructions ? `${req.developerInstructions}
 
 ---
 
 ${req.prompt}` : req.prompt;
-          const { code, stdout, stderr } = await run({ prompt: full, cwd: req.cwd, timeoutMs: req.timeoutMs });
+          const { code, stdout, stderr } = await run({ prompt: full, cwd: req.cwd, timeoutMs: req.timeoutMs, mode });
           if (code === 0) {
             return { provider: "codex", model, text: stdout.trim(), isError: false, ms: Date.now() - started, reasoningEffort: null };
           }
@@ -2225,7 +2224,7 @@ ${prompt}`;
       args.push("-p", prompt);
       return args;
     }
-    var ADVISORY_ENV_SCRUB = ["GITHUB_TOKEN", "GH_TOKEN", "GIT_ASKPASS", "SSH_AUTH_SOCK"];
+    var ADVISORY_ENV_SCRUB = ["GIT_ASKPASS", "SSH_AUTH_SOCK"];
     var CREDENTIAL_NAME_RE = /(?:^|_)(?:KEY|TOKEN|SECRET|SECRETS|PASSWORD|PASSWD|CREDENTIAL|CREDENTIALS)$|API_KEY|ACCESS_KEY|SESSION_TOKEN|PRIVATE_KEY/i;
     function advisoryEnv(env) {
       const out = { ...env };
@@ -2397,7 +2396,10 @@ ${prompt}`;
           process.stderr.write("[deliberation] agy read-only run wrapped in sandbox-exec (workspace writes denied)\n");
         }
         const agyProcess = spawn(spawnPlan.cmd, spawnPlan.argv, {
-          env: readOnly ? advisoryEnv(process.env) : process.env,
+          // Scrub credentials in BOTH read-only and workspace-write runs. A write run
+          // legitimately mutates the worktree but still has no need for the operator's
+          // API keys / GIT_ASKPASS / SSH_AUTH_SOCK - the human commits and pushes, not agy.
+          env: advisoryEnv(process.env),
           shell: false,
           cwd: effCwd,
           // agy -p (print mode) waits for stdin EOF before returning; if the stdin
@@ -3045,6 +3047,12 @@ var require_glob = __commonJS({
         for (const c of res) if (c.re.test(rel)) return true;
         return false;
       }
+      function pushFile(rel, abs, size) {
+        files.push({ rel, abs, size });
+        totalBytes += size;
+        if (files.length > maxFiles) throw new Error(`directory expansion exceeded maxFiles=${maxFiles}. Narrow include or raise the limit.`);
+        if (totalBytes > maxBytes) throw new Error(`directory expansion exceeded maxBytes=${maxBytes} bytes. Narrow include or raise the limit.`);
+      }
       function descend(absDir, relDir) {
         let entries;
         try {
@@ -3076,10 +3084,7 @@ var require_glob = __commonJS({
             if (!st.isFile()) continue;
             if (matches(excludeRes, relPosix)) continue;
             if (!matches(includeRes, relPosix)) continue;
-            files.push({ rel: relPosix, abs: realTarget, size: st.size });
-            totalBytes += st.size;
-            if (files.length > maxFiles) throw new Error(`directory expansion exceeded maxFiles=${maxFiles}. Narrow include or raise the limit.`);
-            if (totalBytes > maxBytes) throw new Error(`directory expansion exceeded maxBytes=${maxBytes} bytes. Narrow include or raise the limit.`);
+            pushFile(relPosix, realTarget, st.size);
           } else if (ent.isDirectory()) {
             if (matches(excludeRes, relPosix) || matches(excludeRes, relPosix + "/**")) continue;
             descend(absChild, relPosix);
@@ -3092,20 +3097,11 @@ var require_glob = __commonJS({
             } catch (_) {
               continue;
             }
-            files.push({ rel: relPosix, abs: absChild, size: st.size });
-            totalBytes += st.size;
-            if (files.length > maxFiles) throw new Error(`directory expansion exceeded maxFiles=${maxFiles}. Narrow include or raise the limit.`);
-            if (totalBytes > maxBytes) throw new Error(`directory expansion exceeded maxBytes=${maxBytes} bytes. Narrow include or raise the limit.`);
+            pushFile(relPosix, absChild, st.size);
           }
         }
       }
       descend(rootAbs, "");
-      if (files.length > maxFiles) {
-        throw new Error(`directory expansion selected ${files.length} files; exceeds maxFiles=${maxFiles}. Narrow include or raise the limit.`);
-      }
-      if (totalBytes > maxBytes) {
-        throw new Error(`directory expansion selected ${totalBytes} bytes; exceeds maxBytes=${maxBytes}. Narrow include or raise the limit.`);
-      }
       files.sort((a, b) => a.rel.localeCompare(b.rel, "en"));
       return { files, totalBytes };
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antonbabenko/deliberation-mcp",
-  "version": "3.6.2",
+  "version": "3.7.0",
   "description": "Deliberation for Claude Code and any MCP host - GPT, Gemini, Grok, and OpenRouter expert subagents.",
   "mcpName": "io.github.antonbabenko/deliberation",
   "repository": { "type": "git", "url": "git+https://github.com/antonbabenko/deliberation.git", "directory": "server/mcp" },