@anthusai/papyrus 2.0.2 → 3.0.0

package/components/newsroom-article-editor.tsx

@@ -48,7 +48,17 @@ import {
 import { getNewsroomNavHref } from "../lib/newsroom-nav";
 import { SITE_BRAND } from "../lib/site-brand";
 import { cn } from "../lib/utils";
+import amplifyOutputs from "papyrus-amplify-outputs";
+import { applyReplacement, editorialChecksEnabled, inlineFindings, visibleFindings } from "../lib/editorial-checks";
+import { graphqlEditorialBackend } from "../lib/editorial-checks-client";
+import { demoEditorialBackend } from "../lib/editorial-checks-demo";
+import type { PluginOutputs } from "../lib/plugin-settings";
+import type { FindingActions } from "./editorial-finding-card";
+import { EditorialFindingsPanel } from "./editorial-findings-panel";
+import { EditorialPreviewPopover, type PreviewPopoverTarget } from "./editorial-preview-popover";
+import { MarkusBodyEditor, type MarkusBodyEditorHandle } from "./markus-body-editor";
 import { MarkusIrPreview } from "./markus-ir-preview";
+import { useEditorialChecks } from "./use-editorial-checks";
 import { useOptionalNewsDeskClient } from "./news-desk-client-provider";
 import { NewsDeskAccessGate } from "./newsroom-access-gate";
 import { NewsroomOpsShell, NewsroomOpsStatusBanner } from "./newsroom-ops-shell";
@@ -118,6 +128,9 @@ export function NewsroomArticleEditor({ articleId, demo, embedded = false }: { a
   const [notice, setNotice] = useState<Notice | null>(null);
   const [conflictOpen, setConflictOpen] = useState(false);
   const [unpublishOpen, setUnpublishOpen] = useState(false);
+  const [publishWarningOpen, setPublishWarningOpen] = useState(false);
+  const [previewPopover, setPreviewPopover] = useState<PreviewPopoverTarget | null>(null);
+  const previewRef = useRef<HTMLDivElement | null>(null);
   const [mobileTab, setMobileTab] = useState<MobileTab>("preview");
   const [focusedReferenceId, setFocusedReferenceId] = useState<string | null>(null);
   const [lineageId, setLineageId] = useState<string | null>(null);
@@ -133,7 +146,7 @@ export function NewsroomArticleEditor({ articleId, demo, embedded = false }: { a
   const [imageError, setImageError] = useState<string | null>(null);
 
   const frontMatterRef = useRef<HTMLTextAreaElement | null>(null);
-  const bodyRef = useRef<HTMLTextAreaElement | null>(null);
+  const bodyRef = useRef<MarkusBodyEditorHandle | null>(null);
   const imageInputRef = useRef<HTMLInputElement | null>(null);
   const mediaBackend = useMemo(() => resolveMediaBackend(previewMode), [previewMode]);
   const validationSequence = useRef(0);
@@ -205,6 +218,21 @@ export function NewsroomArticleEditor({ articleId, demo, embedded = false }: { a
 
   const frontMatterYaml = editor?.frontMatterYaml ?? null;
   const bodyMarkus = editor?.bodyMarkus ?? null;
+  const editorialBackend = useMemo(
+    () => (demo ? demoEditorialBackend : !previewMode && editorialChecksEnabled(amplifyOutputs as PluginOutputs) ? graphqlEditorialBackend : null),
+    [demo, previewMode],
+  );
+  const editorial = useEditorialChecks({
+    backend: editorialBackend,
+    body: bodyMarkus,
+    section: editor?.section ?? "",
+    itemId: editor?.id ?? null,
+  });
+  const editorialOpen = useMemo(
+    () => (editorial.result ? visibleFindings(editorial.result.findings, editorial.dismissed) : []),
+    [editorial.result, editorial.dismissed],
+  );
+  const editorialMarks = useMemo(() => inlineFindings(editorialOpen), [editorialOpen]);
 
   useEffect(() => {
     if (frontMatterYaml === null || bodyMarkus === null) return;
@@ -381,7 +409,45 @@ export function NewsroomArticleEditor({ articleId, demo, embedded = false }: { a
     }
   }, [aliases, backend, demo, editor]);
 
+  const requestPublish = () => {
+    if (editorial.openWarnings.length > 0) {
+      setPublishWarningOpen(true);
+      return;
+    }
+    void publish();
+  };
+
+  const applyEditorialRewrite = (
+    option: { span: { start: number; end: number }; replacement: string; expected: string },
+    finding: Parameters<typeof editorial.fixed>[0] | null,
+  ) => {
+    if (!editor) return;
+    const next = applyReplacement(editor.bodyMarkus, option.span, option.expected, option.replacement);
+    if (next === null) {
+      setNotice({ tone: "info", text: "That text changed since the check. Check again, then apply the rewrite." });
+      return;
+    }
+    patchEditor({ bodyMarkus: next });
+    if (finding) editorial.fixed(finding);
+    setPreviewPopover(null);
+  };
+
+  const editorialActions: FindingActions = {
+    onSelect: (finding) => {
+      editorial.setActiveFindingId(finding.id);
+      if (editorial.inlineResult && finding.excerpt) bodyRef.current?.reveal(finding.span.start, finding.span.end);
+    },
+    onDismiss: (finding, reason) => {
+      editorial.dismiss(finding, reason);
+      setPreviewPopover(null);
+    },
+    onAccept: editorial.accept,
+    onSuggest: editorial.suggest,
+    onApply: applyEditorialRewrite,
+  };
+
   const publish = async () => {
+    setPublishWarningOpen(false);
     if (!editor) return;
     let id = editor.id;
     if (editor.dirty || id === null) {
@@ -551,7 +617,7 @@ export function NewsroomArticleEditor({ articleId, demo, embedded = false }: { a
               <Button
                 data-newsroom-article-publish
                 disabled={publishBlocked}
-                onClick={() => void publish()}
+                onClick={requestPublish}
                 size="sm"
                 type="button"
               >
@@ -714,18 +780,29 @@ export function NewsroomArticleEditor({ articleId, demo, embedded = false }: { a
                     {imageError}
                   </p>
                 ) : null}
-                <Textarea
-                  className={TEXTAREA_CLASS}
-                  data-newsroom-article-body
-                  id="newsroom-article-body"
-                  onChange={(event) => patchEditor({ bodyMarkus: event.target.value })}
+                <MarkusBodyEditor
+                  activeFindingId={editorial.activeFindingId}
+                  findings={editorialMarks}
+                  onChange={(value) => patchEditor({ bodyMarkus: value })}
+                  onFindingClick={editorial.setActiveFindingId}
+                  onSelectionChange={editorial.setSelection}
                   ref={bodyRef}
-                  rows={28}
-                  spellCheck={false}
                   value={editor.bodyMarkus}
                 />
               </div>
 
+              {editorial.enabled ? (
+                <EditorialFindingsPanel
+                  {...editorialActions}
+                  activeFindingId={editorial.activeFindingId}
+                  dismissed={editorial.dismissed}
+                  onCheck={() => void editorial.check()}
+                  result={editorial.result}
+                  selection={editorial.selection}
+                  status={editorial.status}
+                />
+              ) : null}
+
               {validation.status === "unavailable" ? (
                 <NewsroomOpsStatusBanner tone="error">{validation.message}</NewsroomOpsStatusBanner>
               ) : null}
@@ -763,7 +840,7 @@ export function NewsroomArticleEditor({ articleId, demo, embedded = false }: { a
               className={cn("min-w-0", mobileTab === "preview" ? "block" : "hidden")}
               data-newsroom-article-preview-column
             >
-              <div className="rounded-xl border border-border bg-card p-4" data-newsroom-article-preview>
+              <div className="relative rounded-xl border border-border bg-card p-4" data-newsroom-article-preview ref={previewRef}>
                 {(readFrontMatterText(editor.frontMatterYaml, FRONT_MATTER_SUBTITLE_KEY) || readFrontMatterText(editor.frontMatterYaml, FRONT_MATTER_BLURB_KEY)) ? (
                   <div className="newsroom-article-summary" data-newsroom-article-summary>
                     {readFrontMatterText(editor.frontMatterYaml, FRONT_MATTER_SUBTITLE_KEY) ? <p className="newsroom-article-subtitle">{readFrontMatterText(editor.frontMatterYaml, FRONT_MATTER_SUBTITLE_KEY)}</p> : null}
@@ -774,12 +851,40 @@ export function NewsroomArticleEditor({ articleId, demo, embedded = false }: { a
                   <p className="mb-2 text-xs text-muted-foreground">Showing the last valid version.</p>
                 ) : null}
                 {bodyIr ? (
-                  <MarkusIrPreview bodyIr={bodyIr} imageUrls={imageUrls} />
+                  <MarkusIrPreview
+                    bodyIr={bodyIr}
+                    editorial={
+                      editorial.inlineResult
+                        ? {
+                            result: editorial.inlineResult,
+                            findings: editorialOpen,
+                            activeFindingIds: previewPopover?.kind === "findings" ? previewPopover.findingIds : editorial.activeFindingId ? [editorial.activeFindingId] : [],
+                            onOpenMark: (findingIds, anchor) => {
+                              editorial.setActiveFindingId(findingIds[0] ?? null);
+                              setPreviewPopover({ kind: "findings", findingIds, anchor: anchor.getBoundingClientRect() });
+                            },
+                            onSelectSource: (source, anchor) => setPreviewPopover({ kind: "selection", source, anchor }),
+                          }
+                        : undefined
+                    }
+                    imageUrls={imageUrls}
+                  />
                 ) : (
                   <p className="text-sm text-muted-foreground">
                     {invalid ? "Fix the errors to see a preview." : "The preview appears once the markup is valid."}
                   </p>
                 )}
+                {previewPopover && editorial.enabled ? (
+                  <EditorialPreviewPopover
+                    actions={editorialActions}
+                    body={editor.bodyMarkus}
+                    container={previewRef.current}
+                    findings={editorialOpen}
+                    key={previewPopover.kind === "findings" ? previewPopover.findingIds.join() : `${previewPopover.source.start}-${previewPopover.source.end}`}
+                    onClose={() => setPreviewPopover(null)}
+                    target={previewPopover}
+                  />
+                ) : null}
               </div>
             </div>
           </div>
@@ -801,6 +906,28 @@ export function NewsroomArticleEditor({ articleId, demo, embedded = false }: { a
           </DialogContent>
         </Dialog>
 
+        <Dialog onOpenChange={setPublishWarningOpen} open={publishWarningOpen}>
+          <DialogContent>
+            <DialogHeader>
+              <DialogTitle>Publish with open editorial findings?</DialogTitle>
+              <DialogDescription>
+                {editorial.openWarnings.length === 1
+                  ? "One editorial finding is still open."
+                  : `${editorial.openWarnings.length} editorial findings are still open.`}{" "}
+                Findings are advice: you can publish anyway.
+              </DialogDescription>
+            </DialogHeader>
+            <ul className="max-h-48 list-disc space-y-1 overflow-auto pl-5 text-sm" data-newsroom-article-publish-warnings>
+              {editorial.openWarnings.slice(0, 8).map((finding) => (
+                <li key={finding.id}>{finding.message}{finding.excerpt ? `: “${finding.excerpt}”` : ""}</li>
+              ))}
+            </ul>
+            <DialogFooter>
+              <Button onClick={() => setPublishWarningOpen(false)} type="button" variant="outline">Keep editing</Button>
+              <Button data-newsroom-article-publish-anyway onClick={() => void publish()} type="button">Publish anyway</Button>
+            </DialogFooter>
+          </DialogContent>
+        </Dialog>
         <Dialog onOpenChange={setUnpublishOpen} open={unpublishOpen}>
           <DialogContent>
             <DialogHeader>

package/components/newsroom-board-view.tsx

@@ -4,9 +4,7 @@ import { useCallback, useEffect, useMemo, useRef, useState } from "react";
 import Link from "next/link";
 import { usePathname, useRouter, useSearchParams } from "next/navigation";
 import { IssueCollection, IssueDetailPanel, IssueTypeFilter, issueTypeFromFilter, useBoardColumnState } from "@kanbus/ui";
-import "@kanbus/ui/styles/kanban.css";
-import "@kanbus/ui/styles/newsprint.css";
-import "./newsroom-newsprint-board.css";
+import "./newsroom-theme";
 import { PlusIcon } from "lucide-react";
 import { newsroomHref } from "../lib/newsroom-base-path";
 import {
@@ -35,7 +33,6 @@ import { isLocalPreviewEnabled } from "../lib/local-preview";
 import { NewsroomArticleEditor } from "./newsroom-article-editor";
 import { NewsroomAssignmentDetail } from "./newsroom-assignment-detail";
 import { NewsroomOpsShell, NewsroomOpsStatusBanner } from "./newsroom-ops-shell";
-import { useResolvedPapyrusTheme } from "./use-resolved-papyrus-theme";
 import { readLocalReaderSettings, subscribeReaderSettingsChanges } from "./reader-settings";
 
 /** A board with a story or assignment open lives at `?open=<id>`, distinct from the standalone page for that record. */
@@ -61,7 +58,6 @@ export type NewsroomBoardSubject = "contentItem" | "assignment" | "desk";
 export function NewsroomBoardView({ subject, deskId }: { subject: NewsroomBoardSubject; deskId?: string }) {
   const session = useOptionalNewsDeskClient();
   const allowed = canReadNewsroomBoard(session?.shell.phase);
-  const theme = useResolvedPapyrusTheme();
   const [lowMotion, setLowMotion] = useState(false);
   const [assignmentBoardIssues, setAssignmentBoardIssues] = useState<NativeBoardIssue[]>([]);
   const [publishedVersions, setPublishedVersions] = useState<ContentItemVersionRecord[]>([]);
@@ -172,7 +168,7 @@ export function NewsroomBoardView({ subject, deskId }: { subject: NewsroomBoardS
         </Link>
       )}
     </>}>
-    <div className="organizer-native-board papyrus-newsprint-board" data-kanbus-theme="newsprint" data-color-mode={theme}>
+    <div className="organizer-native-board">
       {error && <NewsroomOpsStatusBanner tone="error">{error}</NewsroomOpsStatusBanner>}
       {subject === "desk" && <IssueTypeFilter config={config} value={typeFilter} onChange={setTypeFilter} name="Record type" className="organizer-board-type-filter" />}
       <div className="organizer-board-body" data-detail-open={Boolean(issue)} ref={boardBodyRef} onScrollCapture={handleBoardScroll}>

package/components/newsroom-ops-shell.tsx

@@ -19,6 +19,7 @@ import { ProspectusAccountChooser, useProspectusAccountSummary } from "./prospec
 import { Sheet, SheetContent, SheetHeader, SheetTitle, SheetDescription, SheetTrigger } from "./ui/sheet";
 import { DropdownMenu, DropdownMenuTrigger, DropdownMenuContent, DropdownMenuGroup, DropdownMenuLabel, DropdownMenuItem, DropdownMenuSeparator } from "./ui/dropdown-menu";
 import "./newsroom-organizer.css";
+import { NewsroomThemeFonts, useNewsroomThemeAttributes } from "./newsroom-theme";
 
 export type NewsroomNavCount = {
   count: number | null;
@@ -85,11 +86,12 @@ function Account({ placement }: { placement: "sidebar" | "header" }) {
     media.addEventListener("change", close);
     return () => media.removeEventListener("change", close);
   }, []);
+  const themeAttributes = useNewsroomThemeAttributes();
   return <DropdownMenu open={open} onOpenChange={setOpen}>
     <DropdownMenuTrigger id={`organizer-account-trigger-${placement}`} className={`organizer-account organizer-account-${placement}`} aria-label="Account menu" title="Account menu">
       <UserRound size={18} aria-hidden="true" /><span><strong>{auth.label}</strong><small>{accountSummary ?? (auth.status === "signedIn" ? "Account & preferences" : auth.status === "signedOut" ? "Not signed in" : "Checking session")}</small></span>
     </DropdownMenuTrigger>
-    <DropdownMenuContent className="organizer-account-popup" side={placement === "sidebar" ? "top" : "bottom"} align="end">
+    <DropdownMenuContent className="organizer-account-popup" {...themeAttributes} side={placement === "sidebar" ? "top" : "bottom"} align="end">
       <DropdownMenuGroup>
         <DropdownMenuLabel>{auth.label}</DropdownMenuLabel><DropdownMenuSeparator />
         <ProspectusAccountChooser />
@@ -104,6 +106,7 @@ function Account({ placement }: { placement: "sidebar" | "header" }) {
 
 export function NewsroomOpsShell({ activeTab, appTitle, backHref = "/", backLabel, children, demo = false, headerActions, pageTitle, showNavigation = true }: NewsroomOpsShellProps) {
   const pathname = usePathname();
+  const themeAttributes = useNewsroomThemeAttributes();
   const session = useOptionalNewsDeskClient();
   const admin = demo || session?.shell.dashboard?.canManageUsers === true;
   const [menuOpen, setMenuOpen] = useState(false);
@@ -145,7 +148,8 @@ export function NewsroomOpsShell({ activeTab, appTitle, backHref = "/", backLabe
     aria-label={sidebarToggleLabel} aria-expanded={!collapsed} aria-controls="organizer-sidebar" onClick={() => setCollapsed(value => !value)}>
     {collapsed ? <PanelLeftOpen size={16} aria-hidden="true" /> : <PanelLeftClose size={16} aria-hidden="true" />}
   </button>;
-  return <div className="newsroom-organizer" data-news-desk data-newsroom-ops-shell="true" data-newsroom-chrome="organizer" data-sidebar-collapsed={collapsed || !showNavigation ? "true" : "false"}>
+  return <div className="newsroom-organizer" {...themeAttributes} data-news-desk data-newsroom-ops-shell="true" data-newsroom-chrome="organizer" data-sidebar-collapsed={collapsed || !showNavigation ? "true" : "false"}>
+    <NewsroomThemeFonts />
     {showNavigation && <aside className="organizer-sidebar" hidden={collapsed} id="organizer-sidebar">
       <div className="organizer-sidebar-head">
         <Link className="organizer-brand" href={getNewsroomNavHref("/newsroom", demo)}>{SITE_BRAND.components?.NewsroomLogo ? <SITE_BRAND.components.NewsroomLogo className="organizer-brand-logo" /> : appTitle}<small>The newsroom</small></Link>
@@ -167,7 +171,7 @@ export function NewsroomOpsShell({ activeTab, appTitle, backHref = "/", backLabe
         href={getNewsroomNavHref(item.path, demo)} title={item.description} aria-label={item.label} aria-current={activeTab === item.key ? "page" : undefined}>
         <Icon size={18} aria-hidden="true" /><span>{item.label}</span></Link></li>; })}
       <li><Sheet open={menuOpen} onOpenChange={setMenuOpen}><SheetTrigger className="organizer-more" aria-label="More"><Menu size={18} aria-hidden="true" /><span>More</span></SheetTrigger>
-        <SheetContent side="bottom" className="organizer-menu"><SheetHeader><SheetTitle>Newsroom</SheetTitle><SheetDescription>Workspaces and administration</SheetDescription></SheetHeader>
+        <SheetContent side="bottom" className="organizer-menu" {...themeAttributes}><SheetHeader><SheetTitle>Newsroom</SheetTitle><SheetDescription>Workspaces and administration</SheetDescription></SheetHeader>
           <Navigation activePath={activePath} demo={demo} admin={admin} surface="menu" onNavigate={() => setMenuOpen(false)} />
         </SheetContent>
       </Sheet></li>