@antfu/eslint-config 6.7.1 → 6.7.3

package/README.md

@@ -868,7 +868,7 @@ Well, you can still use Prettier to format files that are not supported well by
 
 ### oxlint?
 
-We do have a plan to integrate [oxlint](https://github.com/Asiashield/oxlint) in someway to speed up the linting process. However there are still some blocks we are waiting for. Track the progress [in this issue: **Oxlint Integration Plan**](https://github.com/antfu/eslint-config/issues/767).
+We do have a plan to integrate [oxlint](https://github.com/oxc-project/oxc) in someway to speed up the linting process. However there are still some blocks we are waiting for. Track the progress [in this issue: **Oxlint Integration Plan**](https://github.com/antfu/eslint-config/issues/767).
 
 ### dprint?
 

package/dist/cli.mjs

@@ -1,6 +1,6 @@
 import process from "node:process";
-import fs from "node:fs/promises";
-import fs$1 from "node:fs";
+import fsPromises from "node:fs/promises";
+import fs from "node:fs";
 import path from "node:path";
 import * as p from "@clack/prompts";
 import c, { green } from "ansis";
@@ -9,7 +9,7 @@ import parse from "parse-gitignore";
 import { execSync } from "node:child_process";
 
 //#region package.json
-var version = "6.7.1";
+var version = "6.7.3";
 
 //#endregion
 //#region src/cli/constants.ts
@@ -143,13 +143,13 @@ async function updateEslintFiles(result) {
 	const cwd = process.cwd();
 	const pathESLintIgnore = path.join(cwd, ".eslintignore");
 	const pathPackageJSON = path.join(cwd, "package.json");
-	const pkgContent = await fs.readFile(pathPackageJSON, "utf-8");
+	const pkgContent = await fsPromises.readFile(pathPackageJSON, "utf-8");
 	const configFileName = JSON.parse(pkgContent).type === "module" ? "eslint.config.js" : "eslint.config.mjs";
 	const pathFlatConfig = path.join(cwd, configFileName);
 	const eslintIgnores = [];
-	if (fs$1.existsSync(pathESLintIgnore)) {
+	if (fs.existsSync(pathESLintIgnore)) {
 		p.log.step(c.cyan`Migrating existing .eslintignore`);
-		const globs = parse(await fs.readFile(pathESLintIgnore, "utf-8")).globs();
+		const globs = parse(await fsPromises.readFile(pathESLintIgnore, "utf-8")).globs();
 		for (const glob of globs) if (glob.type === "ignore") eslintIgnores.push(...glob.patterns);
 		else if (glob.type === "unignore") eslintIgnores.push(...glob.patterns.map((pattern) => `!${pattern}`));
 	}
@@ -159,9 +159,9 @@ async function updateEslintFiles(result) {
 	if (result.extra.includes("unocss")) configLines.push(`unocss: true,`);
 	for (const framework of result.frameworks) configLines.push(`${framework}: true,`);
 	const eslintConfigContent = getEslintConfigContent(configLines.map((i) => `  ${i}`).join("\n"), []);
-	await fs.writeFile(pathFlatConfig, eslintConfigContent);
+	await fsPromises.writeFile(pathFlatConfig, eslintConfigContent);
 	p.log.success(c.green`Created ${configFileName}`);
-	const files = fs$1.readdirSync(cwd);
+	const files = fs.readdirSync(cwd);
 	const legacyConfig = [];
 	files.forEach((file) => {
 		if (/eslint|prettier/.test(file) && !/eslint\.config\./.test(file)) legacyConfig.push(file);
@@ -173,14 +173,14 @@ async function updateEslintFiles(result) {
 //#region src/cli/constants-generated.ts
 const versionsMap = {
 	"@eslint-react/eslint-plugin": "^2.3.13",
-	"@next/eslint-plugin-next": "^16.0.10",
+	"@next/eslint-plugin-next": "^16.1.0",
 	"@unocss/eslint-plugin": "^66.5.10",
 	"astro-eslint-parser": "^1.2.2",
 	"eslint": "^9.39.2",
 	"eslint-plugin-astro": "^1.5.0",
 	"eslint-plugin-format": "^1.1.0",
 	"eslint-plugin-react-hooks": "^7.0.1",
-	"eslint-plugin-react-refresh": "^0.4.24",
+	"eslint-plugin-react-refresh": "^0.4.26",
 	"eslint-plugin-solid": "^0.14.5",
 	"eslint-plugin-svelte": "^3.13.1",
 	"prettier-plugin-astro": "^0.14.1",
@@ -194,7 +194,7 @@ async function updatePackageJson(result) {
 	const cwd = process.cwd();
 	const pathPackageJSON = path.join(cwd, "package.json");
 	p.log.step(c.cyan`Bumping @antfu/eslint-config to v${version}`);
-	const pkgContent = await fs.readFile(pathPackageJSON, "utf-8");
+	const pkgContent = await fsPromises.readFile(pathPackageJSON, "utf-8");
 	const pkg = JSON.parse(pkgContent);
 	pkg.devDependencies ??= {};
 	pkg.devDependencies["@antfu/eslint-config"] = `^${version}`;
@@ -225,7 +225,7 @@ async function updatePackageJson(result) {
 		});
 	}
 	if (addedPackages.length) p.note(c.dim(addedPackages.join(", ")), "Added packages");
-	await fs.writeFile(pathPackageJSON, JSON.stringify(pkg, null, 2));
+	await fsPromises.writeFile(pathPackageJSON, JSON.stringify(pkg, null, 2));
 	p.log.success(c.green`Changes wrote to package.json`);
 }
 
@@ -236,16 +236,16 @@ async function updateVscodeSettings(result) {
 	if (!result.updateVscodeSettings) return;
 	const dotVscodePath = path.join(cwd, ".vscode");
 	const settingsPath = path.join(dotVscodePath, "settings.json");
-	if (!fs$1.existsSync(dotVscodePath)) await fs.mkdir(dotVscodePath, { recursive: true });
-	if (!fs$1.existsSync(settingsPath)) {
-		await fs.writeFile(settingsPath, `{${vscodeSettingsString}}\n`, "utf-8");
+	if (!fs.existsSync(dotVscodePath)) await fsPromises.mkdir(dotVscodePath, { recursive: true });
+	if (!fs.existsSync(settingsPath)) {
+		await fsPromises.writeFile(settingsPath, `{${vscodeSettingsString}}\n`, "utf-8");
 		p.log.success(green`Created .vscode/settings.json`);
 	} else {
-		let settingsContent = await fs.readFile(settingsPath, "utf8");
+		let settingsContent = await fsPromises.readFile(settingsPath, "utf8");
 		settingsContent = settingsContent.trim().replace(/\s*\}$/, "");
 		settingsContent += settingsContent.endsWith(",") || settingsContent.endsWith("{") ? "" : ",";
 		settingsContent += `${vscodeSettingsString}}\n`;
-		await fs.writeFile(settingsPath, settingsContent, "utf-8");
+		await fsPromises.writeFile(settingsPath, settingsContent, "utf-8");
 		p.log.success(green`Updated .vscode/settings.json`);
 	}
 }
@@ -256,7 +256,7 @@ async function run(options = {}) {
 	const argSkipPrompt = !!process.env.SKIP_PROMPT || options.yes;
 	const argTemplate = options.frameworks?.map((m) => m?.trim()).filter(Boolean);
 	const argExtra = options.extra?.map((m) => m?.trim()).filter(Boolean);
-	if (fs$1.existsSync(path.join(process.cwd(), "eslint.config.js"))) {
+	if (fs.existsSync(path.join(process.cwd(), "eslint.config.js"))) {
 		p.log.warn(c.yellow`eslint.config.js already exists, migration wizard exited.`);
 		return process.exit(1);
 	}

package/dist/index.d.mts

@@ -682,6 +682,11 @@ interface RuleOptions {
    * @see https://github.com/9romise/eslint-plugin-import-lite/blob/main/src/rules/consistent-type-specifier-style/README.md
    */
   'import/consistent-type-specifier-style'?: Linter.RuleEntry<ImportConsistentTypeSpecifierStyle>;
+  /**
+   * Ensure all exports appear after other statements.
+   * @see https://github.com/9romise/eslint-plugin-import-lite/blob/main/src/rules/exports-last/README.md
+   */
+  'import/exports-last'?: Linter.RuleEntry<[]>;
   /**
    * Ensure all imports appear before other statements.
    * @see https://github.com/9romise/eslint-plugin-import-lite/blob/main/src/rules/first/README.md
@@ -1779,7 +1784,7 @@ interface RuleOptions {
    */
   'next/inline-script-id'?: Linter.RuleEntry<[]>;
   /**
-   * Prefer `next/script` component when using the inline script for Google Analytics.
+   * Prefer `@next/third-parties/google` when using the inline script for Google Analytics and Tag Manager.
    * @see https://nextjs.org/docs/messages/next-script-for-ga
    */
   'next/next-script-for-ga'?: Linter.RuleEntry<[]>;
@@ -5412,6 +5417,11 @@ interface RuleOptions {
    * @see https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/no-test-return-statement.md
    */
   'test/no-test-return-statement'?: Linter.RuleEntry<[]>;
+  /**
+   * Disallow unnecessary async function wrapper for expected promises
+   * @see https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/no-unneeded-async-expect-function.md
+   */
+  'test/no-unneeded-async-expect-function'?: Linter.RuleEntry<[]>;
   /**
    * Enforce padding around `afterAll` blocks
    * @see https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/padding-around-after-all-blocks.md
@@ -6231,6 +6241,11 @@ interface RuleOptions {
    * @see https://typescript-eslint.io/rules/no-useless-constructor
    */
   'ts/no-useless-constructor'?: Linter.RuleEntry<[]>;
+  /**
+   * Disallow default values that will never be used
+   * @see https://typescript-eslint.io/rules/no-useless-default-assignment
+   */
+  'ts/no-useless-default-assignment'?: Linter.RuleEntry<[]>;
   /**
    * Disallow empty exports that don't change anything in a module file
    * @see https://typescript-eslint.io/rules/no-useless-empty-export

package/dist/index.mjs

@@ -1,8 +1,8 @@
 import { FlatConfigComposer } from "eslint-flat-config-utils";
 import process from "node:process";
-import fs from "node:fs/promises";
+import fsPromises from "node:fs/promises";
 import { fileURLToPath } from "node:url";
-import fs$1 from "node:fs";
+import fs from "node:fs";
 import path from "node:path";
 import { isPackageExists } from "local-pkg";
 import createCommand from "eslint-plugin-command/config";
@@ -27,7 +27,7 @@ async function findUp(name, { cwd = process.cwd(), type = "file", stopAt } = {})
 	while (directory) {
 		const filePath = isAbsoluteName ? name : path.join(directory, name);
 		try {
-			const stats = await fs.stat(filePath);
+			const stats = await fsPromises.stat(filePath);
 			if (type === "file" && stats.isFile() || type === "directory" && stats.isDirectory()) return filePath;
 		} catch {}
 		if (directory === stopAt || directory === root) break;
@@ -42,7 +42,7 @@ function findUpSync(name, { cwd = process.cwd(), type = "file", stopAt } = {}) {
 	while (directory) {
 		const filePath = isAbsoluteName ? name : path.join(directory, name);
 		try {
-			const stats = fs$1.statSync(filePath, { throwIfNoEntry: false });
+			const stats = fs.statSync(filePath, { throwIfNoEntry: false });
 			if (type === "file" && stats?.isFile() || type === "directory" && stats?.isDirectory()) return filePath;
 		} catch {}
 		if (directory === stopAt || directory === root) break;
@@ -1143,7 +1143,7 @@ async function perfectionist() {
 async function detectCatalogUsage() {
 	const workspaceFile = await findUp("pnpm-workspace.yaml");
 	if (!workspaceFile) return false;
-	const yaml$1 = await fs.readFile(workspaceFile, "utf-8");
+	const yaml$1 = await fsPromises.readFile(workspaceFile, "utf-8");
 	return yaml$1.includes("catalog:") || yaml$1.includes("catalogs:");
 }
 async function pnpm(options) {
@@ -1161,7 +1161,10 @@ async function pnpm(options) {
 		name: "antfu/pnpm/package-json",
 		plugins: { pnpm: pluginPnpm },
 		rules: {
-			...catalogs ? { "pnpm/json-enforce-catalog": ["error", { autofix: !isInEditor }] } : {},
+			...catalogs ? { "pnpm/json-enforce-catalog": ["error", {
+				autofix: !isInEditor,
+				ignores: ["@types/vscode"]
+			}] } : {},
 			"pnpm/json-prefer-workspace-settings": ["error", { autofix: !isInEditor }],
 			"pnpm/json-valid-catalog": ["error", { autofix: !isInEditor }]
 		}
@@ -1175,8 +1178,7 @@ async function pnpm(options) {
 			rules: {
 				"pnpm/yaml-enforce-settings": ["error", { settings: {
 					shellEmulator: true,
-					trustPolicy: "no-downgrade",
-					...catalogs ? { catalogMode: "prefer" } : {}
+					trustPolicy: "no-downgrade"
 				} }],
 				"pnpm/yaml-no-duplicate-catalog-item": "error",
 				"pnpm/yaml-no-unused-catalog-item": "error"
@@ -1321,8 +1323,10 @@ async function react(options = {}) {
 			},
 			name: "antfu/react/rules",
 			rules: {
+				"react/jsx-key-before-spread": "warn",
 				"react/jsx-no-comment-textnodes": "warn",
 				"react/jsx-no-duplicate-props": "warn",
+				"react/jsx-uses-react": "warn",
 				"react/jsx-uses-vars": "warn",
 				"react/no-access-state-in-setstate": "error",
 				"react/no-array-index-key": "warn",
@@ -1339,11 +1343,12 @@ async function react(options = {}) {
 				"react/no-create-ref": "error",
 				"react/no-default-props": "error",
 				"react/no-direct-mutation-state": "error",
-				"react/no-duplicate-key": "warn",
+				"react/no-duplicate-key": "error",
 				"react/no-forward-ref": "warn",
 				"react/no-implicit-key": "warn",
 				"react/no-missing-key": "error",
 				"react/no-nested-component-definitions": "error",
+				"react/no-nested-lazy-component-declarations": "error",
 				"react/no-prop-types": "error",
 				"react/no-redundant-should-component-update": "error",
 				"react/no-set-state-in-component-did-mount": "warn",
@@ -1354,10 +1359,6 @@ async function react(options = {}) {
 				"react/no-unsafe-component-will-mount": "warn",
 				"react/no-unsafe-component-will-receive-props": "warn",
 				"react/no-unsafe-component-will-update": "warn",
-				"react/no-unstable-context-value": "warn",
-				"react/no-unstable-default-props": "warn",
-				"react/no-unused-class-component-members": "warn",
-				"react/no-unused-state": "warn",
 				"react/no-use-context": "warn",
 				"react/no-useless-forward-ref": "warn",
 				"react/prefer-use-state-lazy-initialization": "warn",
@@ -1366,14 +1367,11 @@ async function react(options = {}) {
 				"react-dom/no-find-dom-node": "error",
 				"react-dom/no-flush-sync": "error",
 				"react-dom/no-hydrate": "error",
-				"react-dom/no-missing-button-type": "warn",
-				"react-dom/no-missing-iframe-sandbox": "warn",
 				"react-dom/no-namespace": "error",
 				"react-dom/no-render": "error",
 				"react-dom/no-render-return-value": "error",
 				"react-dom/no-script-url": "warn",
 				"react-dom/no-unsafe-iframe-sandbox": "warn",
-				"react-dom/no-unsafe-target-blank": "warn",
 				"react-dom/no-use-form-state": "error",
 				"react-dom/no-void-elements-with-children": "error",
 				"react-hooks/rules-of-hooks": "error",
@@ -2030,7 +2028,7 @@ async function typescript(options = {}) {
 		}] : [],
 		...erasableOnly ? [{
 			name: "antfu/typescript/erasable-syntax-only",
-			plugins: { "erasable-syntax-only": await interopDefault(import("./lib-CJKU7XKI.mjs")) },
+			plugins: { "erasable-syntax-only": await interopDefault(import("./lib-Bxfuo2Ed.mjs")) },
 			rules: {
 				"erasable-syntax-only/enums": "error",
 				"erasable-syntax-only/import-aliases": "error",