@antelopejs/dms 0.7.21 → 0.8.1

package/frontend-vue/tests/save-bar.test.ts

@@ -61,7 +61,7 @@ afterEach(() => {
   vi.unstubAllGlobals();
 });
 
-it("shows an empty modal action form's way out and its held submit", async () => {
+it("shows a modal action form's way out and its ready submit", async () => {
   const { onCancel } = await mount({
     variant: "band",
     kind: "action",
@@ -73,12 +73,24 @@ it("shows an empty modal action form's way out and its held submit", async () =>
   expect(host.firstElementChild!.getAttribute("aria-hidden")).toBeNull();
   expect(buttons()).toEqual([
     { label: "dms.button.cancel", disabled: false },
-    { label: "Invite", disabled: true },
+    { label: "Invite", disabled: false },
   ]);
   host.querySelector("button")!.click();
   expect(onCancel).toHaveBeenCalledOnce();
 });
 
+it("sends an untouched page action form as it is, its submit alone", async () => {
+  await mount({
+    variant: "band",
+    kind: "action",
+    dirty: false,
+    saveLabel: "Send",
+  });
+
+  expect(host.firstElementChild!.getAttribute("aria-hidden")).toBeNull();
+  expect(buttons()).toEqual([{ label: "Send", disabled: false }]);
+});
+
 it("resets an action form once a value changed, and sends it", async () => {
   await mount({
     variant: "band",
@@ -146,7 +158,7 @@ it("gives Cancel and Unsaved changes the same fixed height", async () => {
 });
 
 it("keeps a hidden band's place in its footer", async () => {
-  await mount({ variant: "band", kind: "action", dirty: false });
+  await mount({ variant: "band", kind: "record", dirty: false });
 
   expect(anchor().getAttribute("aria-hidden")).toBe("true");
   expect(classesOf(anchor())).toContain("invisible");

package/frontend-vue/tests/save-status-error.test.ts

@@ -56,11 +56,11 @@ describe("DmsSaveStatus: a failed save", () => {
     expect(onRetry).toHaveBeenCalledOnce();
   });
 
-  it("turns the header pill red, its wording unchanged", async () => {
+  it("turns the header pill red and says it was not saved", async () => {
     await mount(() => h(InstantSaveBadge, { state: "error" }));
     const pill = host.querySelector<HTMLElement>("[data-instant-save-badge]")!;
 
-    expect(pill.textContent?.trim()).toBe("Saved instantly");
+    expect(pill.textContent?.trim()).toBe("Not saved");
     expect(pill.className).toContain("text-error");
   });
 });

package/frontend-vue/tests/table-cell-wrap.test.ts

@@ -58,16 +58,4 @@ describe("Table grid cell layout theme", () => {
       expect(theme().rowCell({ cellWrap })).toContain("py-0");
     }
   });
-
-  it("reads each column's policy for its cell too", () => {
-    expect(tableSource).toMatch(
-      /uiTable\.rowCell\(\{[^}]*cellWrap: \(cell\.column\.columnDef as TableColumn<T>\)\s*\.cellWrap,?\s*\}\)/,
-    );
-  });
-
-  it("reads each column's policy inside the default slot fallback", () => {
-    expect(tableSource).toMatch(
-      /uiTable\.rowSpan\(\{\s*cellWrap: \(\s*cell\.column\.columnDef as TableColumn<T>\s*\)\.cellWrap[\s,]*\}\)/,
-    );
-  });
 });

package/frontend-vue/tests/table-density-menu.test.ts

@@ -11,19 +11,9 @@ import {
   type App,
 } from "vue";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
-import { readFileSync } from "node:fs";
-import { resolve } from "node:path";
 import TableMenuDensity from "../layers/dms-ui/app/build/components/table/MenuDensity.vue";
 import TableMenuRoot from "../layers/dms-ui/app/build/components/table/MenuRoot.vue";
 
-const tableViewSource = readFileSync(
-  resolve(
-    __dirname,
-    "../layers/dms-ui/app/components/table-view/TableView.vue",
-  ),
-  "utf8",
-);
-
 describe("table density menu", () => {
   let app: App | undefined;
 
@@ -115,15 +105,4 @@ describe("table density menu", () => {
       "dms.table.density_title",
     );
   });
-
-  it("keeps the user's density with the table state, the module's as default", () => {
-    expect(tableViewSource).toMatch(
-      /defaultDensity = props\.density \?\? DEFAULT_DENSITY/,
-    );
-    expect(tableViewSource).toContain(
-      'tablePreferences.restore("density", density);',
-    );
-    expect(tableViewSource).toMatch(/\["density", density, defaultDensity\]/);
-    expect(tableViewSource).toContain('v-model:density="density"');
-  });
 });

package/frontend-vue/tests/table-live-hold.test.ts

@@ -6,8 +6,6 @@
  * pagination included), and Show reads the rows once without leaving the
  * pause.
  */
-import { readFileSync } from "node:fs";
-import { resolve } from "node:path";
 import { createApp, defineComponent, h, nextTick, ref, type App } from "vue";
 import { refreshPageBlocks } from "../layers/dms-ui/app/utils/blockRefresh";
 import { afterEach, beforeEach, expect, it, vi } from "vitest";
@@ -43,13 +41,6 @@ const { useTableLiveHold } = await import(
 );
 
 const TOPIC = "api:requests";
-const tableViewSource = readFileSync(
-  resolve(
-    __dirname,
-    "../layers/dms-ui/app/components/table-view/TableView.vue",
-  ),
-  "utf8",
-);
 
 let apps: App[] = [];
 let live: PageLiveController;
@@ -203,23 +194,6 @@ it("reads on a user's refresh while held, and holds from then", async () => {
   });
 });
 
-it("wires the table view's rows, row events and banner to the hold", () => {
-  expect(tableViewSource).toMatch(
-    /liveHold\?: boolean \| TableViewLiveHoldOptions;/,
-  );
-  expect(tableViewSource).toContain(
-    "isRowOpen: () => openRowId.value !== undefined,",
-  );
-  expect(tableViewSource).toContain('ref="tableRoot"');
-  expect(tableViewSource).toContain("heldQuery: liveHold.heldQuery,");
-  expect(tableViewSource).toContain("refreshCallback: refreshByUser,");
-  expect(tableViewSource).toContain('@refresh="refreshByUser"');
-  expect(tableViewSource).toContain("gateRowEvent(payload.type, ids, event);");
-  expect(tableViewSource).toMatch(
-    /<LiveHoldBanner[\s\S]*@show="liveHold.showNew"/,
-  );
-});
-
 it("holds the table alone while a row is open, the page staying live", async () => {
   const isRowOpen = ref(false);
   const { refresh, hold } = mountTable({
@@ -338,19 +312,6 @@ it("holds for no search nor sort the options leave off", async () => {
   expect(hold.reason.value).toBe(null);
 });
 
-it("tells the hold about the table's search and sort, and the banner why", () => {
-  expect(tableViewSource).toContain(
-    "isSearching: () => !!effectiveGlobalFilter.value,",
-  );
-  expect(tableViewSource).toContain(
-    "isSorted: () => !isSameSorting(effectiveSorting.value, defaultSortState),",
-  );
-  expect(tableViewSource).toMatch(
-    /v-if="liveHold\.newCount\.value > 0 \|\| liveHold\.reason\.value"/,
-  );
-  expect(tableViewSource).toContain(':reason="liveHold.reason.value"');
-});
-
 it("hands the strip the paused page's breakdown and the table's missedLabel", async () => {
   const isRowOpen = ref(false);
   const { hold } = mountTable({
@@ -377,8 +338,3 @@ it("hands the strip the paused page's breakdown and the table's missedLabel", as
   await nextTick();
   expect(hold.missedDetail.value).toBe(null);
 });
-
-it("passes the strip its wording and breakdown", () => {
-  expect(tableViewSource).toContain(':missed-label="liveHold.missedLabel"');
-  expect(tableViewSource).toContain(':detail="liveHold.missedDetail.value"');
-});

package/frontend-vue/tests/table-row-action-errors.test.ts

@@ -140,7 +140,7 @@ describe("Table row actions: refusals", () => {
         label: "Resend",
         target: {
           type: "api",
-          url: "/api/invites/{_id}/resend",
+          url: "/api/invites/{{row._id}}/resend",
           successMessage: "Sent",
         },
         confirm: { title: "Resend?", description: "" },
@@ -170,7 +170,7 @@ describe("Table row actions: refusals", () => {
         target: {
           type: "api",
           method: "GET",
-          url: "/api/invites/{_id}/link",
+          url: "/api/invites/{{row._id}}/link",
           successMessage: "Copied",
           copy: "url",
         },
@@ -267,7 +267,7 @@ describe("Table row actions: refusals", () => {
         label: "Ban",
         target: {
           type: "api",
-          url: "/api/users/{_id}/ban",
+          url: "/api/users/{{row._id}}/ban",
           body: { notify: true, scope: "all" },
           successMessage: "Banned",
         },
@@ -293,7 +293,7 @@ describe("Table row actions: refusals", () => {
     const { deleteRows } = await rowActions();
 
     const done = await deleteRows(["t1"], {
-      confirm: { from: "/api/task/{id}/delete-confirm" },
+      confirm: { from: "/api/task/{{row.id}}/delete-confirm" },
     });
 
     expect(done).toBe(true);
@@ -329,7 +329,7 @@ describe("Table row actions: refusals", () => {
     const { deleteRows } = await rowActions();
 
     await deleteRows(["t1", "t2"], {
-      confirm: { from: "/api/task/{id}/delete-confirm" },
+      confirm: { from: "/api/task/{{row.id}}/delete-confirm" },
     });
 
     expect(api).not.toHaveBeenCalledWith("/api/task/t1/delete-confirm");

package/frontend-vue/tests/table-row-hover.test.ts

@@ -95,16 +95,6 @@ describe("row hover affordance", () => {
     });
     expect(pinned).toContain("group-data-[presence=true]:bg-elevated");
   });
-
-  it("feeds the same condition to the row, its pinned cells and the rail", () => {
-    expect(tableSource).toMatch(
-      /uiTable\.row\(\{\s*loading,\s*rowClickable: isRowClickable\(row\.original\),/,
-    );
-    expect(tableSource).toMatch(
-      /uiTable\.rowCell\(\{[^}]*rowClickable: isRowClickable\(row\.original\),/,
-    );
-    expect(tableSource).toContain("presenceRailBackground(row.original)");
-  });
 });
 
 describe("resolveRowClickAction", () => {
@@ -164,13 +154,13 @@ describe("rowCustomActions", () => {
   const stopSelling: CustomRowAction = {
     id: "stop_selling",
     label: "Stop selling",
-    target: { type: "api", url: "/plans/{_id}/stop", method: "POST" },
+    target: { type: "api", url: "/plans/{{row._id}}/stop", method: "POST" },
     rule: { field: "isActive", equals: true },
   };
   const remove: CustomRowAction = {
     id: "delete",
     label: "Delete",
-    target: { type: "api", url: "/plans/{_id}", method: "DELETE" },
+    target: { type: "api", url: "/plans/{{row._id}}", method: "DELETE" },
     rule: { field: "workspaces", equals: 0 },
   };
 

package/frontend-vue/tests/table-scroll-area.test.ts

@@ -34,12 +34,4 @@ describe("Table scroll area", () => {
     expect(theme().headCell()).not.toContain("sticky");
     expect(theme().tableRoot()).not.toContain("overflow-y-auto");
   });
-
-  it("opens the scroll area from `maxHeight` alone", () => {
-    expect(tableSource).not.toContain("stickyHeader");
-    expect(tableSource).toMatch(
-      /hasScrollArea = computed\(\(\) => !!props\.maxHeight\)/,
-    );
-    expect(tableSource).toMatch(/maxHeight: props\.maxHeight,/);
-  });
 });

package/frontend-vue/tests/table-view-card-props.test.ts

@@ -1,8 +1,6 @@
 // @vitest-environment jsdom
 import { computed, createApp, defineComponent, h, ref, type App } from "vue";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
-import { readFileSync } from "node:fs";
-import { resolve } from "node:path";
 import CardsDisplay from "../layers/dms-ui/app/build/components/table-view/CardsDisplay.vue";
 import {
   buildCardProps,
@@ -21,14 +19,6 @@ vi.mock("../layers/dms-ui/app/build/components/table/Empty.vue", () => ({
   default: { render: () => null },
 }));
 
-const kanbanBoardSource = readFileSync(
-  resolve(
-    __dirname,
-    "../layers/dms-ui/app/components/table-view/KanbanBoard.vue",
-  ),
-  "utf8",
-);
-
 const rows = [
   { _id: "t1", name: "Write the docs" },
   { _id: "t2", name: "Ship it" },
@@ -79,13 +69,6 @@ describe("table view card props", () => {
     expect(opened).toEqual([rows[0]]);
     expect(buildCardProps(rows[1]!, context).selected).toBe(true);
   });
-
-  it("gives a kanban card the same props, plus its column's value", () => {
-    expect(kanbanBoardSource).toMatch(
-      /buildCardProps\(item, props\.cardContext\)/,
-    );
-    expect(kanbanBoardSource).toMatch(/groupValue,\n\s*\}\);/);
-  });
 });
 
 describe("cards display with a custom card", () => {

package/frontend-vue/tests/table-view-cards-reorder.test.ts

@@ -11,8 +11,6 @@ import {
   type PropType,
 } from "vue";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
-import { readFileSync } from "node:fs";
-import { resolve } from "node:path";
 import CardsDisplay from "../layers/dms-ui/app/build/components/table-view/CardsDisplay.vue";
 import { useTableReorder } from "../layers/dms-ui/app/build/composables/table-view/useTableReorder";
 import { moveRow } from "../layers/dms-ui/app/build/composables/table-view/utils/reorder";
@@ -31,14 +29,6 @@ vi.mock("../layers/dms-ui/app/build/components/table/Empty.vue", () => ({
 type Row = { _id: string; name: string };
 type Api = Parameters<typeof useTableReorder>[0]["api"];
 
-const tableViewSource = readFileSync(
-  resolve(
-    __dirname,
-    "../layers/dms-ui/app/components/table-view/TableView.vue",
-  ),
-  "utf8",
-);
-
 const TaskCard = defineComponent({
   props: {
     rowId: String,
@@ -223,12 +213,6 @@ describe("the cards display of a hand-ordered table", () => {
 });
 
 describe("which displays move rows", () => {
-  it("offers moving on the grid and the cards, never on the board or the groups", () => {
-    expect(tableViewSource).toMatch(
-      /ORDERED_DISPLAY_IDS = new Set\(\[TABLE_DISPLAY_ID, CARDS_DISPLAY_ID\]\)/,
-    );
-    expect(tableViewSource).toMatch(/reorder: reorderState\.value,/);
-  });
 
   it("draws no handle on a display that does not draw the rows in their order", () => {
     vi.stubGlobal("computed", computed);

package/frontend-vue/tests/table-view-grouped.test.ts

@@ -1,6 +1,4 @@
 // @vitest-environment jsdom
-import { readFileSync } from "node:fs";
-import { resolve } from "node:path";
 import {
   computed,
   createApp,
@@ -25,25 +23,6 @@ import {
 } from "../layers/dms-ui/app/build/composables/table-view/utils/groupedRows";
 import type { TableViewColumn } from "../layers/dms-ui/app/composables/table-view/types";
 
-const tableSource = readFileSync(
-  resolve(__dirname, "../layers/dms-ui/app/build/components/table/Table.vue"),
-  "utf8",
-);
-const menuViewModeSource = readFileSync(
-  resolve(
-    __dirname,
-    "../layers/dms-ui/app/build/components/table/MenuViewMode.vue",
-  ),
-  "utf8",
-);
-const tableViewSource = readFileSync(
-  resolve(
-    __dirname,
-    "../layers/dms-ui/app/components/table-view/TableView.vue",
-  ),
-  "utf8",
-);
-
 const LABELS = {
   today: "Today",
   yesterday: "Yesterday",
@@ -117,40 +96,6 @@ describe("grouped rows", () => {
   });
 });
 
-describe("grouped display wiring", () => {
-  it("draws a header row before each group of the page", () => {
-    expect(tableSource).toMatch(
-      /v-for="\{ kind, id, row, key, header \} in bodyEntries"/,
-    );
-    // Drawn by the entry, not by reading the prop when the header renders:
-    // leaving the grouped display then cannot leave it undefined.
-    expect(tableSource).toContain('<component :is="header" />');
-    expect(tableSource).not.toContain("grouping!.header");
-    expect(tableSource).toContain(':class="uiTable.groupCell()"');
-    expect(tableSource).toMatch(/if \(key !== currentKey\) \{/);
-  });
-
-  it("sorts the list on the grouped column while the grouped display shows", () => {
-    expect(tableViewSource).toMatch(
-      /isGroupedDisplay\.value && activeGroupedOptions\.value\s*\?\s*groupedSorting\(picked, activeGroupedOptions\.value\)/,
-    );
-    expect(tableViewSource).toContain(':grouping="grouping"');
-  });
-
-  it("lets the user pick the grouped column from the options menu, as on the kanban", () => {
-    expect(tableViewSource).toContain(
-      'v-model:grouped-group-by="groupedGroupBy"',
-    );
-    expect(tableViewSource).toContain(
-      ':grouped-group-by-options="groupedGroupByOptions"',
-    );
-    expect(tableViewSource).toMatch(/grouped: activeGroupedOptions,/);
-    expect(menuViewModeSource).toMatch(
-      /\[GROUPED_DISPLAY_ID\]: \(shared\) => \(\{\s*options: shared\.groupedGroupByOptions,/,
-    );
-  });
-});
-
 describe("grouped group-by", () => {
   const column = (accessorKey: string, typeId: string, options = {}) =>
     ({

package/frontend-vue/tests/table-view-pinned-rows.test.ts

@@ -3,8 +3,6 @@
  * base language of a languages table stays on top whichever column the user
  * sorts on, and on the first page.
  */
-import { readFileSync } from "node:fs";
-import { resolve } from "node:path";
 import { describe, expect, it, vi } from "vitest";
 import {
   processSourceRows,
@@ -128,16 +126,3 @@ describe("rows a route sorts", () => {
     expect(ids((await rows.list({}))!.results)).toEqual(ids(LANGUAGES));
   });
 });
-
-it("hands the table view's pinnedRows to its rows, except while grouped", () => {
-  const source = readFileSync(
-    resolve(
-      __dirname,
-      "../layers/dms-ui/app/components/table-view/TableView.vue",
-    ),
-    "utf8",
-  );
-  expect(source).toMatch(
-    /pinnedRows: \(\) => \(isGroupedDisplay\.value \? undefined : props\.pinnedRows\)/,
-  );
-});

package/frontend-vue/tests/table-view-record-link.test.ts

@@ -5,8 +5,6 @@
  * closed meanwhile: the table removes the key in place, so the route still
  * holds the same value and only the visit tells the link was followed again.
  */
-import { readFileSync } from "node:fs";
-import { resolve } from "node:path";
 import { createApp, defineComponent, h, nextTick, reactive } from "vue";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 import type { CustomRowAction } from "../layers/dms-ui/app/types/row-action";
@@ -190,18 +188,3 @@ describe("the URL a closed drawer leaves", () => {
     });
   });
 });
-
-it("wires the record link and the filter chips into the table view", () => {
-  const source = readFileSync(
-    resolve(
-      __dirname,
-      "../layers/dms-ui/app/components/table-view/TableView.vue",
-    ),
-    "utf8",
-  );
-  expect(source).toContain("useTableRecordLink<T>({");
-  expect(source).toContain("onRecordShown: (id) => recordLink?.shown(id),");
-  expect(source).toContain(
-    "withoutQueryParam(currentQuery(route.query), param)",
-  );
-});

package/frontend-vue/tests/table-view-refresh.test.ts

@@ -5,8 +5,6 @@
  * asks its blocks to refresh (refreshPageBlocks). The re-read goes through the
  * same refresh as the toolbar's button, which keeps the rows on screen.
  */
-import { readFileSync } from "node:fs";
-import { resolve } from "node:path";
 import { createApp, defineComponent, h } from "vue";
 import { afterEach, beforeEach, expect, it, vi } from "vitest";
 import type { RealtimeTopicHandler } from "../layers/dms-core/app/composables/realtime/useUserRealtime";
@@ -24,14 +22,6 @@ const { useRefreshTriggers } = await import(
   "../layers/dms-ui/app/build/composables/blocks/useRefreshTriggers"
 );
 
-const tableViewSource = readFileSync(
-  resolve(
-    __dirname,
-    "../layers/dms-ui/app/components/table-view/TableView.vue",
-  ),
-  "utf8",
-);
-
 const UPLOADS_TOPIC = "media:uploads";
 const mounted: Array<{ unmount: () => void }> = [];
 
@@ -75,10 +65,3 @@ it("refreshes on each event of any of its topics, not on a snapshot", () => {
   topicHandlers.get(UPLOADS_TOPIC)?.({ entries: [] } as never);
   expect(block.onRefresh).toHaveBeenCalledTimes(2);
 });
-
-it("wires the table view's realtimeTopic and page refresh to its refresh", () => {
-  expect(tableViewSource).toMatch(/realtimeTopic\?: string \| string\[\];/);
-  expect(tableViewSource).toMatch(
-    /const liveGate = useRefreshTriggers\(\s*props\.realtimeTopic,\s*\(\) => void refreshAll\(\),\s*\);/,
-  );
-});

package/frontend-vue/tests/table-view-sources.test.ts

@@ -182,7 +182,7 @@ describe("source tables", () => {
 
   describe("reading one row (fetchRowUrl)", () => {
     const FETCH_URL = "/api/ws/{{params.ws}}/requests";
-    const ROW_URL = "/api/ws/{{params.ws}}/requests/{id}";
+    const ROW_URL = "/api/ws/{{params.ws}}/requests/{{row.id}}";
 
     function rowsWith(
       api: (url: string) => Promise<unknown>,

package/frontend-vue/tests/table-view-url-tab.test.ts

@@ -6,8 +6,6 @@
  * remounting the page. A tab the user opens is written back to the URL in
  * place, under the same key.
  */
-import { readFileSync } from "node:fs";
-import { resolve } from "node:path";
 import { createApp, defineComponent, h, nextTick, reactive, ref } from "vue";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 import {
@@ -183,15 +181,3 @@ describe("the tab the user opens", () => {
     expect(activeTabId.value).toBe("all");
   });
 });
-
-it("wires the URL tab into the table view", () => {
-  const source = readFileSync(
-    resolve(
-      __dirname,
-      "../layers/dms-ui/app/components/table-view/TableView.vue",
-    ),
-    "utf8",
-  );
-  expect(source).toContain("readTableUrlTab(route.query, urlScope)");
-  expect(source).toContain("useTableUrlTab({");
-});