@antelopejs/dms-media 0.6.0 → 0.6.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (238) hide show
  1. package/README.md +18 -3
  2. package/dist/acl/entries.js +1 -2
  3. package/dist/acl/entries.js.map +1 -1
  4. package/dist/bindings.js +1 -3
  5. package/dist/bindings.js.map +1 -1
  6. package/dist/db/models/mediaFolders.model.d.ts +0 -3
  7. package/dist/db/models/mediaFolders.model.js +0 -29
  8. package/dist/db/models/mediaFolders.model.js.map +1 -1
  9. package/dist/db/tables/mediaDeclarations.table.d.ts +0 -4
  10. package/dist/db/tables/mediaDeclarations.table.js +0 -16
  11. package/dist/db/tables/mediaDeclarations.table.js.map +1 -1
  12. package/dist/declared/assets.d.ts +0 -2
  13. package/dist/declared/assets.js +12 -140
  14. package/dist/declared/assets.js.map +1 -1
  15. package/dist/declared/folders.d.ts +1 -5
  16. package/dist/declared/folders.js +17 -82
  17. package/dist/declared/folders.js.map +1 -1
  18. package/dist/declared/index.d.ts +0 -2
  19. package/dist/declared/index.js +0 -2
  20. package/dist/declared/index.js.map +1 -1
  21. package/dist/declared/records.d.ts +4 -32
  22. package/dist/declared/records.js +6 -35
  23. package/dist/declared/records.js.map +1 -1
  24. package/dist/derivatives.js +14 -23
  25. package/dist/derivatives.js.map +1 -1
  26. package/dist/guards.d.ts +4 -0
  27. package/dist/guards.js +19 -0
  28. package/dist/guards.js.map +1 -0
  29. package/dist/implementations/interface-dms-media/index.d.ts +1 -3
  30. package/dist/implementations/interface-dms-media/index.js +0 -2
  31. package/dist/implementations/interface-dms-media/index.js.map +1 -1
  32. package/dist/library/activity.js +7 -5
  33. package/dist/library/activity.js.map +1 -1
  34. package/dist/library/batches.js +6 -3
  35. package/dist/library/batches.js.map +1 -1
  36. package/dist/library/events.js +4 -4
  37. package/dist/library/events.js.map +1 -1
  38. package/dist/library/module-readout.js +5 -2
  39. package/dist/library/module-readout.js.map +1 -1
  40. package/dist/library/realtime.js.map +1 -1
  41. package/dist/pages/activity.js +1 -1
  42. package/dist/pages/activity.js.map +1 -1
  43. package/dist/routes/media/assets.d.ts +1 -1
  44. package/dist/routes/media/assets.js +5 -5
  45. package/dist/routes/media/assets.js.map +1 -1
  46. package/dist/routes/media/bulk.js +17 -13
  47. package/dist/routes/media/bulk.js.map +1 -1
  48. package/dist/routes/media/delivery-headers.js +9 -9
  49. package/dist/routes/media/delivery-headers.js.map +1 -1
  50. package/dist/routes/media/delivery-stream.js +7 -21
  51. package/dist/routes/media/delivery-stream.js.map +1 -1
  52. package/dist/routes/media/delivery.js.map +1 -1
  53. package/dist/routes/media/manage.js.map +1 -1
  54. package/dist/routes/media/transform.js +13 -8
  55. package/dist/routes/media/transform.js.map +1 -1
  56. package/dist/routes/media/upload.js +2 -5
  57. package/dist/routes/media/upload.js.map +1 -1
  58. package/dist/test/antelope.test.js +17 -16
  59. package/dist/test/antelope.test.js.map +1 -1
  60. package/dist/test/helpers/folders.d.ts +27 -0
  61. package/dist/test/helpers/folders.js +15 -0
  62. package/dist/test/helpers/folders.js.map +1 -1
  63. package/dist/test/helpers/pages.js +10 -6
  64. package/dist/test/helpers/pages.js.map +1 -1
  65. package/dist/test/helpers/permissions-world.d.ts +98 -0
  66. package/dist/test/helpers/permissions-world.js +205 -0
  67. package/dist/test/helpers/permissions-world.js.map +1 -0
  68. package/dist/test/helpers/prototype.d.ts +1 -0
  69. package/dist/test/helpers/prototype.js +11 -0
  70. package/dist/test/helpers/prototype.js.map +1 -0
  71. package/dist/test/integration/derivative-sweep-query.test.js +13 -16
  72. package/dist/test/integration/derivative-sweep-query.test.js.map +1 -1
  73. package/dist/test/integration/folder-query.test.js +5 -9
  74. package/dist/test/integration/folder-query.test.js.map +1 -1
  75. package/dist/test/integration/media-bindings.test.js +2 -2
  76. package/dist/test/integration/media-bindings.test.js.map +1 -1
  77. package/dist/test/integration/media-cleanup.test.js +14 -17
  78. package/dist/test/integration/media-cleanup.test.js.map +1 -1
  79. package/dist/test/integration/media-declared-content.test.js +19 -318
  80. package/dist/test/integration/media-declared-content.test.js.map +1 -1
  81. package/dist/test/integration/media-delivery-editing.test.js +7 -5
  82. package/dist/test/integration/media-delivery-editing.test.js.map +1 -1
  83. package/dist/test/integration/media-delivery.test.js +19 -5
  84. package/dist/test/integration/media-delivery.test.js.map +1 -1
  85. package/dist/test/integration/media-explorer-writes.test.js +2 -2
  86. package/dist/test/integration/media-explorer-writes.test.js.map +1 -1
  87. package/dist/test/integration/media-guards.test.js +18 -7
  88. package/dist/test/integration/media-guards.test.js.map +1 -1
  89. package/dist/test/integration/media-library.test.js +1 -1
  90. package/dist/test/integration/media-library.test.js.map +1 -1
  91. package/dist/test/integration/media-linked-subfolders.test.js +6 -6
  92. package/dist/test/integration/media-linked-subfolders.test.js.map +1 -1
  93. package/dist/test/integration/media-member-access.test.js +2 -5
  94. package/dist/test/integration/media-member-access.test.js.map +1 -1
  95. package/dist/test/integration/media-permissions.test.js +142 -473
  96. package/dist/test/integration/media-permissions.test.js.map +1 -1
  97. package/dist/test/integration/media-project-field.test.js +3 -5
  98. package/dist/test/integration/media-project-field.test.js.map +1 -1
  99. package/dist/test/integration/media-search-query.test.js +11 -16
  100. package/dist/test/integration/media-search-query.test.js.map +1 -1
  101. package/dist/test/integration/media-storage-origin-unreachable.test.js +80 -0
  102. package/dist/test/integration/media-storage-origin-unreachable.test.js.map +1 -0
  103. package/dist/test/integration/media-upload-policy.test.js +2 -2
  104. package/dist/test/integration/media-upload-policy.test.js.map +1 -1
  105. package/dist/test/integration/permissions-management.d.ts +2 -0
  106. package/dist/test/integration/permissions-management.js +189 -0
  107. package/dist/test/integration/permissions-management.js.map +1 -0
  108. package/dist/test/unit/acl/entries.test.js +2 -1
  109. package/dist/test/unit/acl/entries.test.js.map +1 -1
  110. package/dist/test/unit/acl/resolver.test.js +10 -3
  111. package/dist/test/unit/acl/resolver.test.js.map +1 -1
  112. package/dist/test/unit/declared.test.js +0 -66
  113. package/dist/test/unit/declared.test.js.map +1 -1
  114. package/dist/test/unit/library/fixtures.d.ts +1 -1
  115. package/dist/test/unit/library/fixtures.js +6 -1
  116. package/dist/test/unit/library/fixtures.js.map +1 -1
  117. package/dist/test/unit/library/library.test.js +0 -1
  118. package/dist/test/unit/library/library.test.js.map +1 -1
  119. package/dist/test/unit/library/realtime.test.js +1 -0
  120. package/dist/test/unit/library/realtime.test.js.map +1 -1
  121. package/dist/test/unit/library/search-facets.test.js +2 -2
  122. package/dist/test/unit/library/search-facets.test.js.map +1 -1
  123. package/dist/test/unit/pages/toolbar.test.js +24 -7
  124. package/dist/test/unit/pages/toolbar.test.js.map +1 -1
  125. package/dist/test/unit/routes/dto.test.js +7 -6
  126. package/dist/test/unit/routes/dto.test.js.map +1 -1
  127. package/dist/test/unit/routes/file-page.test.js +5 -7
  128. package/dist/test/unit/routes/file-page.test.js.map +1 -1
  129. package/dist/test/unit/routes/preset-row.test.js +2 -1
  130. package/dist/test/unit/routes/preset-row.test.js.map +1 -1
  131. package/dist/transform.js +6 -6
  132. package/dist/transform.js.map +1 -1
  133. package/dist/upload-checks.d.ts +8 -2
  134. package/dist/upload-checks.js.map +1 -1
  135. package/dist/upload-policy.js +8 -8
  136. package/dist/upload-policy.js.map +1 -1
  137. package/dist/validation/declared.schema.d.ts +7 -36
  138. package/dist/validation/declared.schema.js +15 -20
  139. package/dist/validation/declared.schema.js.map +1 -1
  140. package/dist/validation/media.schema.d.ts +1 -1
  141. package/dist/validation/media.schema.js +2 -2
  142. package/dist/validation/media.schema.js.map +1 -1
  143. package/frontend-vue/app/build/imageEditor/editorShapes.ts +118 -0
  144. package/frontend-vue/app/build/imageEditor/useEditorSaving.ts +86 -0
  145. package/frontend-vue/app/build/library/libraryActions.ts +444 -0
  146. package/frontend-vue/app/build/library/libraryCore.ts +136 -0
  147. package/frontend-vue/app/components/ImageEditor.vue +22 -179
  148. package/frontend-vue/app/composables/library/useMediaLibrary.ts +3 -575
  149. package/frontend-vue/app/composables/useMediaApi.ts +21 -5
  150. package/frontend-vue/build/backend-boundary.ts +122 -0
  151. package/frontend-vue/dms.frontend.build.ts +3 -0
  152. package/frontend-vue/eslint.config.mjs +13 -0
  153. package/frontend-vue/package.json +3 -1
  154. package/frontend-vue/pnpm-lock.yaml +217 -61
  155. package/frontend-vue/tests/backend-boundary.test.ts +203 -0
  156. package/frontend-vue/tests/mediaPreviews.test.ts +39 -0
  157. package/package.json +10 -16
  158. package/skills/dms-media/SKILL.md +12 -24
  159. package/skills/dms-media/cases.json +38 -0
  160. package/src/acl/entries.ts +6 -4
  161. package/src/bindings.ts +3 -3
  162. package/src/db/models/mediaFolders.model.ts +0 -44
  163. package/src/db/tables/mediaDeclarations.table.ts +3 -19
  164. package/src/declared/assets.ts +19 -210
  165. package/src/declared/folders.ts +25 -138
  166. package/src/declared/index.ts +0 -2
  167. package/src/declared/records.ts +17 -90
  168. package/src/derivatives.ts +17 -23
  169. package/src/guards.ts +19 -0
  170. package/src/implementations/interface-dms-media/index.ts +1 -8
  171. package/src/library/activity.ts +17 -9
  172. package/src/library/batches.ts +12 -9
  173. package/src/library/events.ts +7 -4
  174. package/src/library/module-readout.ts +6 -2
  175. package/src/library/realtime.ts +5 -1
  176. package/src/library/zip.ts +1 -1
  177. package/src/pages/activity.ts +6 -2
  178. package/src/routes/media/assets.ts +4 -3
  179. package/src/routes/media/bulk.ts +16 -14
  180. package/src/routes/media/delivery-headers.ts +9 -12
  181. package/src/routes/media/delivery-stream.ts +13 -28
  182. package/src/routes/media/delivery.ts +4 -2
  183. package/src/routes/media/manage.ts +4 -6
  184. package/src/routes/media/transform.ts +27 -23
  185. package/src/routes/media/upload.ts +4 -6
  186. package/src/test/antelope.test.ts +25 -21
  187. package/src/test/helpers/folders.ts +22 -0
  188. package/src/test/helpers/pages.ts +12 -5
  189. package/src/test/helpers/permissions-world.ts +326 -0
  190. package/src/test/helpers/prototype.ts +12 -0
  191. package/src/test/integration/derivative-sweep-query.test.ts +19 -21
  192. package/src/test/integration/folder-query.test.ts +11 -11
  193. package/src/test/integration/media-bindings.test.ts +7 -7
  194. package/src/test/integration/media-cleanup.test.ts +25 -37
  195. package/src/test/integration/media-declared-content.test.ts +35 -379
  196. package/src/test/integration/media-delivery-editing.test.ts +11 -7
  197. package/src/test/integration/media-delivery.test.ts +29 -8
  198. package/src/test/integration/media-explorer-writes.test.ts +2 -7
  199. package/src/test/integration/media-guards.test.ts +21 -7
  200. package/src/test/integration/media-library.test.ts +1 -1
  201. package/src/test/integration/media-linked-subfolders.test.ts +12 -21
  202. package/src/test/integration/media-member-access.test.ts +5 -9
  203. package/src/test/integration/media-permissions.test.ts +56 -570
  204. package/src/test/integration/media-project-field.test.ts +5 -7
  205. package/src/test/integration/media-search-query.test.ts +16 -20
  206. package/src/test/integration/media-storage-origin-unreachable.test.ts +111 -0
  207. package/src/test/integration/media-upload-policy.test.ts +2 -8
  208. package/src/test/integration/permissions-management.ts +292 -0
  209. package/src/test/unit/acl/entries.test.ts +2 -1
  210. package/src/test/unit/acl/resolver.test.ts +19 -7
  211. package/src/test/unit/declared.test.ts +0 -87
  212. package/src/test/unit/library/fixtures.ts +9 -3
  213. package/src/test/unit/library/library.test.ts +1 -7
  214. package/src/test/unit/library/realtime.test.ts +2 -0
  215. package/src/test/unit/library/search-facets.test.ts +2 -2
  216. package/src/test/unit/pages/toolbar.test.ts +42 -17
  217. package/src/test/unit/routes/dto.test.ts +7 -6
  218. package/src/test/unit/routes/file-page.test.ts +10 -9
  219. package/src/test/unit/routes/preset-row.test.ts +2 -2
  220. package/src/transform.ts +6 -6
  221. package/src/upload-checks.ts +12 -3
  222. package/src/upload-policy.ts +8 -8
  223. package/src/validation/declared.schema.ts +17 -25
  224. package/src/validation/media.schema.ts +6 -6
  225. package/dist/declared/readiness.d.ts +0 -2
  226. package/dist/declared/readiness.js +0 -52
  227. package/dist/declared/readiness.js.map +0 -1
  228. package/dist/declared/retire.d.ts +0 -3
  229. package/dist/declared/retire.js +0 -118
  230. package/dist/declared/retire.js.map +0 -1
  231. package/dist/test/integration/media-declared-retire.test.js +0 -186
  232. package/dist/test/integration/media-declared-retire.test.js.map +0 -1
  233. package/frontend-vue/tests/engines.test.ts +0 -20
  234. package/frontend-vue/tests/locales.test.ts +0 -61
  235. package/src/declared/readiness.ts +0 -64
  236. package/src/declared/retire.ts +0 -206
  237. package/src/test/integration/media-declared-retire.test.ts +0 -257
  238. /package/dist/test/integration/{media-declared-retire.test.d.ts → media-storage-origin-unreachable.test.d.ts} +0 -0
@@ -1,5 +1,5 @@
1
1
  import type { AxiosInstance } from "axios";
2
- import { expect } from "chai";
2
+ import { assert, expect } from "chai";
3
3
  import { CustomComponent } from "@antelopejs/interface-dms/base/custom";
4
4
  import {
5
5
  GetPermissionId,
@@ -64,16 +64,14 @@ describe("[integration] media project field — a member uses media from a proje
64
64
  });
65
65
  owner = authorizedClient((await ensureOwnerSession()).accessToken);
66
66
  const pagePermission = GetPermissionId(EditorialArticlesPage);
67
- expect(pagePermission, "project page permission").to.be.a("string");
68
- const roleId = await createRole("editorial-editor", [
69
- pagePermission as string,
70
- ]);
67
+ assert.isDefined(pagePermission, "project page permission");
68
+ const roleId = await createRole("editorial-editor", [pagePermission]);
71
69
  editor = await registerMember("EditorialEditor", [roleId]);
72
70
  const linked = (await fetchFolders(owner)).find(
73
71
  (folder) => folder.name === FOLDER_NAME,
74
72
  );
75
- expect(linked, "linked folder").to.not.equal(undefined);
76
- linkedFolderId = (linked as TreeFolderNode).id;
73
+ assert.isDefined(linked, "linked folder");
74
+ linkedFolderId = linked.id;
77
75
  });
78
76
 
79
77
  it("opens the linked folder of the page, and only it, to the picker", async () => {
@@ -3,6 +3,7 @@ import { GetModel } from "@antelopejs/interface-database-decorators";
3
3
  import { expect } from "chai";
4
4
  import { type MediaAsset, MediaAssetModel } from "../../db";
5
5
  import { MediaAssetsController } from "../../routes/media/assets";
6
+ import { patchMethod } from "../helpers/prototype";
6
7
 
7
8
  const TENANT = "stream-search-a";
8
9
  const OTHER_TENANT = "stream-search-b";
@@ -11,7 +12,6 @@ const HIDDEN = "hidden";
11
12
  const SKIPPED = 150;
12
13
  const MATCHING = 120;
13
14
  const LIMIT = 100;
14
- type CursorFactory = (this: Query<unknown>) => AsyncIterable<unknown>;
15
15
 
16
16
  function asset(
17
17
  id: string,
@@ -76,27 +76,23 @@ describe("[integration] streaming asset search", () => {
76
76
  const expected = candidates
77
77
  .filter((row) => row.name.toLowerCase().includes("İ".toLowerCase()))
78
78
  .slice(0, LIMIT);
79
- const original = Object.getOwnPropertyDescriptor(
80
- Query.prototype,
81
- "cursor",
82
- )!;
83
- const readCursor = original.value as CursorFactory;
84
79
  let consumed = 0;
85
80
  let closed = false;
86
- Object.defineProperty(Query.prototype, "cursor", {
87
- ...original,
88
- value: async function* (this: Query<unknown>) {
89
- try {
90
- const cursor = readCursor.call(this);
91
- for await (const row of cursor) {
92
- consumed++;
93
- yield row;
81
+ const restore = patchMethod<Query<unknown>, "cursor">(
82
+ Query.prototype,
83
+ "cursor",
84
+ (readCursor) =>
85
+ async function* (this: Query<unknown>) {
86
+ try {
87
+ for await (const row of readCursor.call(this)) {
88
+ consumed++;
89
+ yield row;
90
+ }
91
+ } finally {
92
+ closed = true;
94
93
  }
95
- } finally {
96
- closed = true;
97
- }
98
- },
99
- });
94
+ },
95
+ );
100
96
  try {
101
97
  const result = await controller(model).search(" İ ", " IMAGE/ ");
102
98
  expect(result.assets.map((row) => row.id)).to.deep.equal(
@@ -106,7 +102,7 @@ describe("[integration] streaming asset search", () => {
106
102
  expect(consumed).to.be.lessThan(candidates.length);
107
103
  expect(closed).to.equal(true);
108
104
  } finally {
109
- Object.defineProperty(Query.prototype, "cursor", original);
105
+ restore();
110
106
  }
111
107
  });
112
108
 
@@ -0,0 +1,111 @@
1
+ import type { AxiosInstance } from "axios";
2
+ import { assert, expect } from "chai";
3
+ import sharp from "sharp";
4
+ import { rawGet, uploadAsset } from "../helpers/assets";
5
+ import { authorizedClient, getBaseUrl } from "../helpers/http";
6
+ import { ensureOwnerSession } from "../helpers/owner";
7
+
8
+ const HTTP_OK = 200;
9
+ const HTTP_FOUND = 302;
10
+ const STORAGE_PATH_PREFIX = "/file-storage/";
11
+ const THUMB_WIDTH = 300;
12
+ const PHOTO_NAME = "wide.png";
13
+ const PHOTO_WIDTH = 640;
14
+ const PHOTO_HEIGHT = 320;
15
+ const SVG_NAME = "badge.svg";
16
+ const SVG_SOURCE =
17
+ '<svg xmlns="http://www.w3.org/2000/svg" width="20" height="10"><rect width="20" height="10" fill="#0a7"/></svg>';
18
+
19
+ function widePng(): Promise<Buffer> {
20
+ return sharp({
21
+ create: {
22
+ width: PHOTO_WIDTH,
23
+ height: PHOTO_HEIGHT,
24
+ channels: 3,
25
+ background: { r: 0, g: 120, b: 200 },
26
+ },
27
+ })
28
+ .png()
29
+ .toBuffer();
30
+ }
31
+
32
+ function requestUrl(input: Parameters<typeof fetch>[0]): URL {
33
+ if (input instanceof Request) return new URL(input.url);
34
+ return new URL(input);
35
+ }
36
+
37
+ /**
38
+ * A backend behind a private network or an egress policy cannot call the
39
+ * storage's public URL (here the API's own /file-storage routes). Clients still
40
+ * reach it, as a browser does through the dashboard; only the server's fetch
41
+ * is cut, so every server-side read and write must go through the storage
42
+ * interface.
43
+ */
44
+ describe("[integration] media when the server cannot reach the storage's public URL", () => {
45
+ const serverFetch = globalThis.fetch;
46
+ let client: AxiosInstance;
47
+ let token: string;
48
+ let folderId: string;
49
+
50
+ before(async function () {
51
+ this.timeout(40_000);
52
+ const session = await ensureOwnerSession();
53
+ token = session.accessToken;
54
+ client = authorizedClient(token);
55
+ const folder = await client.post("/api/media/folders", {
56
+ name: "Unreachable storage origin",
57
+ });
58
+ expect(folder.status).to.equal(HTTP_OK);
59
+ folderId = folder.data.id;
60
+ globalThis.fetch = (input, init) =>
61
+ requestUrl(input).pathname.startsWith(STORAGE_PATH_PREFIX)
62
+ ? Promise.reject(new TypeError("fetch failed: egress blocked"))
63
+ : serverFetch(input, init);
64
+ });
65
+
66
+ after(async () => {
67
+ globalThis.fetch = serverFetch;
68
+ await client.delete(`/api/media/folders/${folderId}`);
69
+ });
70
+
71
+ it("reads an uploaded image's size at confirmation and renders its thumbnail", async () => {
72
+ const asset = await uploadAsset(
73
+ client,
74
+ folderId,
75
+ PHOTO_NAME,
76
+ "image/png",
77
+ await widePng(),
78
+ );
79
+ expect(asset.width).to.equal(PHOTO_WIDTH);
80
+ expect(asset.height).to.equal(PHOTO_HEIGHT);
81
+
82
+ const thumb = await rawGet(`/media/${asset.id}/thumb/${PHOTO_NAME}`, token);
83
+ expect(thumb.status).to.equal(HTTP_FOUND);
84
+ assert.isNotNull(thumb.location);
85
+ const stored = await serverFetch(thumb.location);
86
+ expect(stored.status).to.equal(HTTP_OK);
87
+ const metadata = await sharp(
88
+ Buffer.from(await stored.arrayBuffer()),
89
+ ).metadata();
90
+ expect(metadata.width).to.equal(THUMB_WIDTH);
91
+ });
92
+
93
+ it("streams an SVG through the API", async () => {
94
+ const asset = await uploadAsset(
95
+ client,
96
+ folderId,
97
+ SVG_NAME,
98
+ "image/svg+xml",
99
+ Buffer.from(SVG_SOURCE),
100
+ );
101
+ const response = await serverFetch(
102
+ `${getBaseUrl()}/media/${asset.id}/${SVG_NAME}`,
103
+ { headers: { Authorization: `Bearer ${token}` }, redirect: "manual" },
104
+ );
105
+ expect(response.status).to.equal(HTTP_OK);
106
+ expect(response.headers.get("content-length")).to.equal(
107
+ String(Buffer.byteLength(SVG_SOURCE)),
108
+ );
109
+ expect(await response.text()).to.equal(SVG_SOURCE);
110
+ });
111
+ });
@@ -17,6 +17,7 @@ import {
17
17
  import { runPurgeStaging } from "../../crons/purge-staging";
18
18
  import { MediaFolderModel } from "../../db";
19
19
  import { uploadAsset, uploadPixelPng } from "../helpers/assets";
20
+ import { fetchFolderNodes } from "../helpers/folders";
20
21
  import { authorizedClient } from "../helpers/http";
21
22
  import { ensureOwnerSession } from "../helpers/owner";
22
23
 
@@ -30,12 +31,6 @@ const PDF_FOLDER_NAME = "PDF only uploads";
30
31
  const PURGE_HORIZON_MS = 25 * 60 * 60 * 1000;
31
32
  const EXIF_ROTATED_RIGHT = 6;
32
33
 
33
- interface FolderNode {
34
- id: string;
35
- name: string;
36
- binding: string | null;
37
- }
38
-
39
34
  interface StagedUpload {
40
35
  resourceKey: string;
41
36
  }
@@ -173,8 +168,7 @@ describe("[integration] media upload policy — types, quota, real content and s
173
168
  });
174
169
 
175
170
  it("refuses a file the linked field does not accept", async () => {
176
- const tree = await client.get("/api/media/tree");
177
- const linked = (tree.data.folders as FolderNode[]).find(
171
+ const linked = (await fetchFolderNodes(client)).find(
178
172
  (folder) => folder.binding === PDF_BINDING_ID,
179
173
  );
180
174
  expect(linked, "linked folder").to.not.equal(undefined);
@@ -0,0 +1,292 @@
1
+ import type { AxiosInstance } from "axios";
2
+ import { expect } from "chai";
3
+ import { RegisterAssetBinding } from "@antelopejs/interface-dms-media";
4
+ import { GetPermissionId } from "@antelopejs/interface-dms/page";
5
+ import { UserModel } from "@antelopejs/interface-dms/auth/db";
6
+ import { DEFAULT_TENANT_ID } from "@antelopejs/interface-dms/constants";
7
+ import { GetModel } from "@antelopejs/interface-database-decorators";
8
+ import { MediaUploadsPage } from "../../pages/uploads";
9
+ import { uploadAvailability } from "../../pages/upload-availability";
10
+ import { MEDIA_ROUTES } from "../../library/links";
11
+ import { readFolderAcl, writeFolderAcl } from "../helpers/folders";
12
+ import { readPageAccess } from "../helpers/pages";
13
+ import { setRolePermissions } from "../helpers/members";
14
+
15
+ import {
16
+ assets,
17
+ createFolder,
18
+ fetchTree,
19
+ findById,
20
+ folders,
21
+ HTTP_FORBIDDEN,
22
+ HTTP_NOT_FOUND,
23
+ HTTP_OK,
24
+ LIBRARY_UPLOAD_PERMISSION,
25
+ LIBRARY_VIEW_PERMISSION,
26
+ owner,
27
+ permissionEntry,
28
+ requireById,
29
+ roleEntry,
30
+ roles,
31
+ sessions,
32
+ STOCK_BINDING_ID,
33
+ STOCK_FOLDER_NAME,
34
+ WAREHOUSE_EDIT_PERMISSION,
35
+ WAREHOUSE_VIEW_PERMISSION,
36
+ } from "../helpers/permissions-world";
37
+
38
+ /** Folder management and ACL edition, run after the transform suites. */
39
+ export function folderManagementSuites(): void {
40
+ describe("folder management and ACL edition", () => {
41
+ folderManagementTests();
42
+ folderAclTests();
43
+ });
44
+ }
45
+
46
+ /** Who may create, rename, move and delete folders, and change their visibility. */
47
+ function folderManagementTests(): void {
48
+ it("requires manage at the root to create top-level folders", async () => {
49
+ const denied = await sessions.uploader.client.post("/api/media/folders", {
50
+ name: "Nope",
51
+ });
52
+ expect(denied.status).to.equal(HTTP_FORBIDDEN);
53
+ });
54
+
55
+ it("lets a folder manager create, rename, move and delete folders", async () => {
56
+ const created = await sessions.folderManager.client.post(
57
+ "/api/media/folders",
58
+ { name: "Managed" },
59
+ );
60
+ expect(created.status).to.equal(HTTP_OK);
61
+ const managedId = created.data.id;
62
+ const renamed = await sessions.folderManager.client.post(
63
+ `/api/media/folders/${managedId}/rename`,
64
+ { name: "Managed renamed" },
65
+ );
66
+ expect(renamed.status).to.equal(HTTP_OK);
67
+ const moved = await sessions.folderManager.client.post(
68
+ `/api/media/folders/${managedId}/move`,
69
+ { parentId: folders.depot },
70
+ );
71
+ expect(moved.status).to.equal(HTTP_OK);
72
+ const deleted = await sessions.folderManager.client.delete(
73
+ `/api/media/folders/${managedId}`,
74
+ );
75
+ expect(deleted.status).to.equal(HTTP_OK);
76
+ });
77
+
78
+ it("refuses cascade deletion when a subfolder lacks the manage right", async () => {
79
+ const estate = await createFolder(owner, "Estate");
80
+ const cellar = await createFolder(owner, "EstateCellar", estate);
81
+ await writeFolderAcl(cellar, [roleEntry(roles.secretTeam, ["manage"])]);
82
+ const denied = await sessions.folderManager.client.delete(
83
+ `/api/media/folders/${estate}`,
84
+ );
85
+ expect(denied.status).to.equal(HTTP_FORBIDDEN);
86
+ const cleanup = await owner.delete(`/api/media/folders/${estate}`);
87
+ expect(cleanup.status).to.equal(HTTP_OK);
88
+ });
89
+
90
+ it("checks the target parent's manage right on folder moves", async () => {
91
+ const created = await sessions.folderManager.client.post(
92
+ "/api/media/folders",
93
+ { name: "Nomad" },
94
+ );
95
+ expect(created.status).to.equal(HTTP_OK);
96
+ const nomadId = created.data.id;
97
+ const invisibleTarget = await sessions.folderManager.client.post(
98
+ `/api/media/folders/${nomadId}/move`,
99
+ { parentId: folders.restricted },
100
+ );
101
+ expect(invisibleTarget.status).to.equal(HTTP_NOT_FOUND);
102
+ const unmanagedTarget = await sessions.folderManager.client.post(
103
+ `/api/media/folders/${nomadId}/move`,
104
+ { parentId: folders.readOnlyCorner },
105
+ );
106
+ expect(unmanagedTarget.status).to.equal(HTTP_FORBIDDEN);
107
+ const cleanup = await sessions.folderManager.client.delete(
108
+ `/api/media/folders/${nomadId}`,
109
+ );
110
+ expect(cleanup.status).to.equal(HTTP_OK);
111
+ });
112
+
113
+ it("keeps visibility changes owner-only, even for a folder manager", async () => {
114
+ const folderFlip = await sessions.folderManager.client.post(
115
+ `/api/media/folders/${folders.depot}/visibility`,
116
+ { visibility: "public" },
117
+ );
118
+ expect(folderFlip.status).to.equal(HTTP_FORBIDDEN);
119
+ const assetFlip = await sessions.folderManager.client.post(
120
+ `/api/media/assets/${assets.notes.id}/visibility`,
121
+ { visibility: "public" },
122
+ );
123
+ expect(assetFlip.status).to.equal(HTTP_FORBIDDEN);
124
+ });
125
+ }
126
+
127
+ /** Stored folder ACLs, and what the owner may still do: flip visibility, but not unlock linked folders. */
128
+ function folderAclTests(): void {
129
+ it("applies a stored folder ACL on the next request", async () => {
130
+ const before = await fetchTree(sessions.viewer.client);
131
+ expect(findById(before, folders.curtain), "curtain visible").to.not.equal(
132
+ undefined,
133
+ );
134
+ expect(await readFolderAcl(folders.curtain)).to.equal(undefined);
135
+ await writeFolderAcl(folders.curtain, [
136
+ roleEntry(roles.secretTeam, ["manage"]),
137
+ ]);
138
+ const hidden = await fetchTree(sessions.viewer.client);
139
+ expect(findById(hidden, folders.curtain), "curtain hidden").to.equal(
140
+ undefined,
141
+ );
142
+ });
143
+
144
+ it("never locks the owner out of a folder", async () => {
145
+ await writeFolderAcl(folders.curtain, []);
146
+ const tree = await fetchTree(owner);
147
+ expect(findById(tree, folders.curtain)?.rights.manage).to.equal(true);
148
+ });
149
+
150
+ it("restores inheritance when the ACL is cleared", async () => {
151
+ await writeFolderAcl(folders.curtain, null);
152
+ const tree = await fetchTree(sessions.viewer.client);
153
+ expect(findById(tree, folders.curtain), "curtain back").to.not.equal(
154
+ undefined,
155
+ );
156
+ });
157
+
158
+ it("lets the owner flip folder and asset visibility", async () => {
159
+ const folderFlip = await owner.post(
160
+ `/api/media/folders/${folders.curtain}/visibility`,
161
+ { visibility: "public" },
162
+ );
163
+ expect(folderFlip.status).to.equal(HTTP_OK);
164
+ const folderBack = await owner.post(
165
+ `/api/media/folders/${folders.curtain}/visibility`,
166
+ { visibility: "private" },
167
+ );
168
+ expect(folderBack.status).to.equal(HTTP_OK);
169
+ const assetFlip = await owner.post(
170
+ `/api/media/assets/${assets.notes.id}/visibility`,
171
+ { visibility: "private" },
172
+ );
173
+ expect(assetFlip.status).to.equal(HTTP_OK);
174
+ const assetBack = await owner.post(
175
+ `/api/media/assets/${assets.notes.id}/visibility`,
176
+ { visibility: "inherit" },
177
+ );
178
+ expect(assetBack.status).to.equal(HTTP_OK);
179
+ });
180
+
181
+ it("keeps linked folders locked even for the owner", async () => {
182
+ const rename = await owner.post(
183
+ `/api/media/folders/${folders.stock}/rename`,
184
+ { name: "Hijacked stock" },
185
+ );
186
+ expect(rename.status).to.equal(HTTP_FORBIDDEN);
187
+ });
188
+ }
189
+
190
+ /** Role updates, the uploads page button and the binding lifecycle, run last. */
191
+ export function laterPermissionSuites(): void {
192
+ describe("dynamic role updates", () => {
193
+ it("grants access on the next request when the role gains a permission", async () => {
194
+ const before = await fetchTree(sessions.latecomer.client);
195
+ expect(before.folders).to.deep.equal([]);
196
+ await setRolePermissions(roles.latecomer, [LIBRARY_VIEW_PERMISSION]);
197
+ const after = await fetchTree(sessions.latecomer.client);
198
+ expect(
199
+ findById(after, folders.library),
200
+ "library visible after grant",
201
+ ).to.not.equal(undefined);
202
+ });
203
+
204
+ it("revokes access on the next request when the permission is removed", async () => {
205
+ await setRolePermissions(roles.latecomer, []);
206
+ const tree = await fetchTree(sessions.latecomer.client);
207
+ expect(tree.folders).to.deep.equal([]);
208
+ });
209
+ });
210
+
211
+ describe("upload header button", () => {
212
+ const uploadsPagePermission = GetPermissionId(MediaUploadsPage) ?? "";
213
+
214
+ async function uploadButton(client: AxiosInstance) {
215
+ const layout = await client.get("/dms/pagelayout", {
216
+ params: { slug: MEDIA_ROUTES.uploads },
217
+ });
218
+ expect(layout.status).to.equal(HTTP_OK);
219
+ return layout.data.layout.options.headerActions[0];
220
+ }
221
+
222
+ async function latecomerAvailability() {
223
+ const user = await GetModel(UserModel).get(sessions.latecomer.userId);
224
+ return uploadAvailability({ tenantId: DEFAULT_TENANT_ID, user });
225
+ }
226
+
227
+ after(async () => {
228
+ await setRolePermissions(roles.latecomer, []);
229
+ });
230
+
231
+ it("serves the uploads page to the owner with the button enabled", async () => {
232
+ const button = await uploadButton(owner);
233
+ expect(button.disabled).to.not.equal(true);
234
+ });
235
+
236
+ it("keeps the uploads page from members: module pages are owner-only", async () => {
237
+ await setRolePermissions(roles.latecomer, [
238
+ LIBRARY_VIEW_PERMISSION,
239
+ uploadsPagePermission,
240
+ LIBRARY_UPLOAD_PERMISSION,
241
+ ]);
242
+ const [memberAccess, ownerAccess] = await Promise.all([
243
+ readPageAccess(sessions.latecomer.client, MEDIA_ROUTES.uploads),
244
+ readPageAccess(owner, MEDIA_ROUTES.uploads),
245
+ ]);
246
+ expect(ownerAccess).to.include({
247
+ ownRouteStatus: HTTP_OK,
248
+ hasAccess: true,
249
+ });
250
+ expect(ownerAccess.servedBlocks).to.be.greaterThan(0);
251
+ expect(memberAccess).to.include({ hasAccess: false, servedBlocks: 0 });
252
+ expect(memberAccess.ownRouteStatus).to.not.equal(HTTP_OK);
253
+ });
254
+
255
+ it("is disabled for a member who can upload to no folder", async () => {
256
+ await setRolePermissions(roles.latecomer, [LIBRARY_VIEW_PERMISSION]);
257
+ expect(await latecomerAvailability()).to.deep.equal({
258
+ reason: "$dms_media.uploads.no_writable_folder",
259
+ });
260
+ });
261
+
262
+ it("is enabled once the member may upload somewhere", async () => {
263
+ await setRolePermissions(roles.latecomer, [
264
+ LIBRARY_VIEW_PERMISSION,
265
+ LIBRARY_UPLOAD_PERMISSION,
266
+ ]);
267
+ expect(await latecomerAvailability()).to.equal(undefined);
268
+ });
269
+ });
270
+
271
+ describe("binding lifecycle", () => {
272
+ it("resyncs the linked folder ACL when the mapping changes", async () => {
273
+ RegisterAssetBinding({
274
+ id: STOCK_BINDING_ID,
275
+ folderName: STOCK_FOLDER_NAME,
276
+ permissionMapping: {
277
+ read: [WAREHOUSE_VIEW_PERMISSION],
278
+ write: [WAREHOUSE_EDIT_PERMISSION],
279
+ },
280
+ });
281
+ await fetchTree(owner);
282
+ expect(await readFolderAcl(folders.stock)).to.deep.include(
283
+ permissionEntry(WAREHOUSE_VIEW_PERMISSION, ["read"]),
284
+ );
285
+ const tree = await fetchTree(sessions.clerk.client);
286
+ expect(
287
+ requireById(tree, folders.stock).rights.write,
288
+ "clerk keeps write after resync",
289
+ ).to.equal(true);
290
+ });
291
+ });
292
+ }
@@ -2,6 +2,7 @@ import { expect } from "chai";
2
2
  import { parseFolderAcl, serializeAcl } from "../../../acl/entries";
3
3
  import type { MediaFolder } from "../../../db/tables";
4
4
  import type { AclEntry } from "../../../types";
5
+ import { folder } from "../library/fixtures";
5
6
 
6
7
  const READ_ENTRY: AclEntry = {
7
8
  subject: { kind: "role", id: "editors" },
@@ -9,7 +10,7 @@ const READ_ENTRY: AclEntry = {
9
10
  };
10
11
 
11
12
  function folderWithAcl(json_acl: string | undefined): MediaFolder {
12
- return { json_acl } as MediaFolder;
13
+ return folder("folder", undefined, [], { json_acl });
13
14
  }
14
15
 
15
16
  describe("[unit] acl/entries — parseFolderAcl", () => {
@@ -27,13 +27,23 @@ function buildFolder(seed: FolderSeed): MediaFolder {
27
27
  visibility: "private",
28
28
  createdAt: new Date(),
29
29
  updatedAt: new Date(),
30
- } as MediaFolder;
30
+ };
31
31
  }
32
32
 
33
33
  function buildActor(permissions: string[], roleIds: string[] = []): AclActor {
34
34
  return { permissions: new Set(permissions), roleIds };
35
35
  }
36
36
 
37
+ /** The ids `acl` names as subjects of `kind`: an actor holding them all is matched by every entry. */
38
+ function subjectIds(
39
+ acl: readonly AclEntry[],
40
+ kind: AclEntry["subject"]["kind"],
41
+ ): string[] {
42
+ return acl
43
+ .filter((entry) => entry.subject.kind === kind)
44
+ .map((entry) => entry.subject.id);
45
+ }
46
+
37
47
  const EDIT_ARTICLES_PERMISSION = "articles.table.edit";
38
48
  const LIBRARY_VIEW_PERMISSION = "library.view";
39
49
  const LIBRARY_UPLOAD_PERMISSION = "library.upload";
@@ -218,6 +228,11 @@ describe("[unit] acl/resolver — resolveFolderAccess", () => {
218
228
  const folders = [buildFolder({ id: "root" })];
219
229
  const actor = buildActor([MEDIA_PAGE_PERMISSION]);
220
230
  expect(resolveRootRights(actor, DEFAULT_ROOT_ACL).size).to.equal(0);
231
+ const named = buildActor(
232
+ subjectIds(DEFAULT_ROOT_ACL, "permission"),
233
+ subjectIds(DEFAULT_ROOT_ACL, "role"),
234
+ );
235
+ expect(resolveRootRights(named, DEFAULT_ROOT_ACL).size).to.equal(0);
221
236
  const access = resolveFolderAccess(folders, actor, DEFAULT_ROOT_ACL);
222
237
  expect(access.readable.size).to.equal(0);
223
238
  const owner = resolveFolderAccess(
@@ -282,14 +297,11 @@ describe("[unit] acl/resolver — resolveFolderAccess", () => {
282
297
  });
283
298
 
284
299
  it("ignores unknown rights and unknown subject kinds", () => {
285
- // The fixture is deliberately not an AclEntry -- an unknown right
286
- // and an unknown subject kind are what this test feeds the resolver.
287
- // oxlint-disable-next-line anti-slop/no-chained-type-assertions
288
- const exoticAcl = [
300
+ const exoticAcl = JSON.stringify([
289
301
  { subject: { kind: "role", id: "editors" }, rights: ["teleport"] },
290
302
  { subject: { kind: "group", id: "editors" }, rights: ["manage"] },
291
- ] as unknown as AclEntry[];
292
- const folders = [buildFolder({ id: "root", acl: exoticAcl })];
303
+ ]);
304
+ const folders = [buildFolder({ id: "root", rawAcl: exoticAcl })];
293
305
  const editor = resolveFolderAccess(
294
306
  folders,
295
307
  buildActor([], ["editors"]),