@antelopejs/dms-mailing 0.7.1 → 0.9.0

package/src/routes/metrics.ts

@@ -63,16 +63,16 @@ const TEMPLATE_VOLUME_KEY = "$dms_mailing.metrics.template_volume";
 const FIRST_ROW_OFFSET = 0;
 const SINGLE_ROW = 1;
 
-const KPI_EXTRACTORS: Record<string, TotalsExtractor> = {
-  sends: (totals) => totals.sends,
-  deliverability: (totals) => totals.deliverability,
-  "open-rate": (totals) => totals.openRate,
-  "click-rate": (totals) => totals.clickRate,
-  bounces: (totals) => totals.bounced,
-  unsubscribes: (totals) => totals.unsubscribed,
-  queued: (totals) => totals.queued,
-  latency: (totals) => totals.latencyMedian,
-};
+const KPI_EXTRACTORS = new Map<string, TotalsExtractor>([
+  ["sends", (totals) => totals.sends],
+  ["deliverability", (totals) => totals.deliverability],
+  ["open-rate", (totals) => totals.openRate],
+  ["click-rate", (totals) => totals.clickRate],
+  ["bounces", (totals) => totals.bounced],
+  ["unsubscribes", (totals) => totals.unsubscribed],
+  ["queued", (totals) => totals.queued],
+  ["latency", (totals) => totals.latencyMedian],
+]);
 
 /** The KPIs read from delivery events: unmeasured when nothing reports them. */
 const DELIVERY_METRICS = new Set(["deliverability", "open-rate", "click-rate"]);
@@ -83,18 +83,23 @@ export interface TopMetric {
   minDeliveries: number;
 }
 
-const TOP_METRICS: Record<string, TopMetric> = {
-  "open-rate": {
-    extract: (totals) => totals.openRate,
-    minDeliveries: MIN_RANKED_DELIVERIES,
-  },
-  "click-rate": {
-    extract: (totals) => totals.clickRate,
-    minDeliveries: MIN_RANKED_DELIVERIES,
-  },
-  sends: { extract: (totals) => totals.sends, minDeliveries: 0 },
+const OPEN_RATE_METRIC: TopMetric = {
+  extract: (totals) => totals.openRate,
+  minDeliveries: MIN_RANKED_DELIVERIES,
 };
-const DEFAULT_TOP_METRIC = TOP_METRICS["open-rate"] as TopMetric;
+
+const TOP_METRICS = new Map<string, TopMetric>([
+  ["open-rate", OPEN_RATE_METRIC],
+  [
+    "click-rate",
+    {
+      extract: (totals) => totals.clickRate,
+      minDeliveries: MIN_RANKED_DELIVERIES,
+    },
+  ],
+  ["sends", { extract: (totals) => totals.sends, minDeliveries: 0 }],
+]);
+const DEFAULT_TOP_METRIC = OPEN_RATE_METRIC;
 
 interface FunnelStepDefinition {
   id: string;
@@ -223,7 +228,7 @@ export class MetricsController extends Controller(`${API_BASE_PATH}/metrics`) {
   async kpi(
     @Parameter("metric", "param") metric: string,
   ): Promise<KpiCardData> {
-    const extract = KPI_EXTRACTORS[metric];
+    const extract = KPI_EXTRACTORS.get(metric);
     assert(extract, HTTP_NOT_FOUND, UNKNOWN_METRIC);
     const range = currentRange(this.ctx);
     const [current, previous, tracking] = await Promise.all([
@@ -252,7 +257,7 @@ export class MetricsController extends Controller(`${API_BASE_PATH}/metrics`) {
   @Get("/top-templates")
   async topTemplates() {
     const metric =
-      TOP_METRICS[this.ctx.url.searchParams.get("metric") ?? ""] ??
+      TOP_METRICS.get(this.ctx.url.searchParams.get("metric") ?? "") ??
       DEFAULT_TOP_METRIC;
     const range = currentRange(this.ctx);
     const [sends, previous, templates] = await Promise.all([
@@ -467,22 +472,19 @@ export function comparedSteps(
 /** Which sends the funnel counts: all, or one side of the marketing split. */
 export type FunnelKind = "all" | "marketing" | "transactional";
 
-const FUNNEL_KINDS: Record<string, FunnelKind> = {
-  all: "all",
-  marketing: "marketing",
-  transactional: "transactional",
-};
-
-export function readFunnelKind(raw: string | null): FunnelKind {
-  return FUNNEL_KINDS[raw ?? ""] ?? "all";
-}
-
 const KIND_KEEPS: Record<FunnelKind, (category: string) => boolean> = {
   all: () => true,
   marketing: (category) => isMarketingCategory(category),
   transactional: (category) => !isMarketingCategory(category),
 };
 
+const isFunnelKind = (raw: string): raw is FunnelKind =>
+  Object.hasOwn(KIND_KEEPS, raw);
+
+export function readFunnelKind(raw: string | null): FunnelKind {
+  return raw !== null && isFunnelKind(raw) ? raw : "all";
+}
+
 /**
  * Sends of the templates on one side of the split. A template's category
  * decides: "marketing" is the campaign side, everything else transactional.

package/src/routes/period.ts

@@ -18,10 +18,10 @@ const PREVIOUS_YEAR = "previous-year";
  * What the comparison series is called, by the selector's `comparison`. A
  * custom window, or a caller naming none, is neither of the two.
  */
-const COMPARISON_SERIES_LABELS: Record<string, string> = {
-  "previous-period": "$dms_mailing.metrics.previous",
-  [PREVIOUS_YEAR]: "$dms_mailing.metrics.previous_year",
-};
+const COMPARISON_SERIES_LABELS = new Map([
+  ["previous-period", "$dms_mailing.metrics.previous"],
+  [PREVIOUS_YEAR, "$dms_mailing.metrics.previous_year"],
+]);
 const COMPARED_SERIES_LABEL = "$dms_mailing.metrics.compared";
 
 function readQuery(ctx: RangeContext, key: string): string | undefined {
@@ -67,7 +67,7 @@ export function isComparisonWanted(ctx: RangeContext): boolean {
 /** The label of the comparison series, for the comparison the caller asks. */
 export function comparisonLabel(ctx: RangeContext): string {
   const comparison = readQuery(ctx, "comparison") ?? "previous-period";
-  return COMPARISON_SERIES_LABELS[comparison] ?? COMPARED_SERIES_LABEL;
+  return COMPARISON_SERIES_LABELS.get(comparison) ?? COMPARED_SERIES_LABEL;
 }
 
 function yearBefore(date: Date): Date {

package/src/routes/sends.ts

@@ -10,7 +10,7 @@ import {
 } from "@antelopejs/interface-api";
 import { assert, assertValidation } from "@antelopejs/interface-api-util";
 import { AuthUserWithPermission } from "@antelopejs/interface-dms/guards";
-import { ZodError } from "zod";
+import { ZodError, type z } from "zod";
 import { getRequestTenantId } from "@antelopejs/interface-dms/request-tenant";
 import { TenantScopedModel } from "@antelopejs/interface-dms/tenant-scoped-model";
 import type { User } from "@antelopejs/interface-dms/auth/db";
@@ -68,13 +68,10 @@ import {
   requireTemplate,
   snapshotOfVersion,
 } from "../services/templates";
-import type {
-  SendStatus,
-  SuppressionSummary,
-  TemplateContent,
-  TemplateStatus,
-} from "../types";
+import type { SendStatus, SuppressionSummary, TemplateStatus } from "../types";
+import type { JsonObject } from "../types/json";
 import {
+  type previewVersionSchema,
   realSendSchema,
   replayFailedSchema,
   replaySchema,
@@ -98,12 +95,6 @@ const DRAFT_VERSION = 0;
 /** Renders as the recipient got it, not as the editor previews it. */
 const SEND_MODE: InterpolationMode = "send";
 
-interface TestSendInput {
-  locale: string;
-  content?: TemplateContent;
-  data?: Record<string, unknown>;
-}
-
 export interface SendTemplateSummary {
   id: string;
   name: string;
@@ -194,10 +185,10 @@ const sameAddress = (left: string, right: string): boolean =>
   normalizeAddress(left) === normalizeAddress(right);
 
 /** A bad address gets its own message; any other invalid field is the content's. */
-function sendInputError(error: unknown): string {
-  const isRecipient =
-    error instanceof ZodError &&
-    error.issues.some((issue) => issue.path[0] === RECIPIENT_FIELD);
+function sendInputError(error: ZodError): string {
+  const isRecipient = error.issues.some(
+    (issue) => issue.path[0] === RECIPIENT_FIELD,
+  );
   return isRecipient ? INVALID_RECIPIENT : INVALID_CONTENT;
 }
 
@@ -265,7 +256,8 @@ export class SendsController extends Controller(API_BASE_PATH) {
     const input = assertValidation(
       body,
       (value) => testSendSchema.parse(value),
-      sendInputError,
+      (error) =>
+        error instanceof ZodError ? sendInputError(error) : INVALID_CONTENT,
     );
     const template = await requireTemplate(this.templates, id);
     const ownAddressSuppressed = await this.ownSuppression(input.to);
@@ -274,9 +266,9 @@ export class SendsController extends Controller(API_BASE_PATH) {
         tenantId: this.tenantId,
         to: input.to,
         allowSuppressed: [this.user.email],
-        locale: (input as TestSendInput).locale,
-        variables: (input as TestSendInput).data,
-        content: (input as TestSendInput).content,
+        locale: input.locale,
+        variables: input.data,
+        content: input.content,
         version: requestedVersionOf(input.version),
         isTest: true,
         source: TEST_SEND_SOURCE,
@@ -311,7 +303,8 @@ export class SendsController extends Controller(API_BASE_PATH) {
     const input = assertValidation(
       body,
       (value) => realSendSchema.parse(value),
-      sendInputError,
+      (error) =>
+        error instanceof ZodError ? sendInputError(error) : INVALID_CONTENT,
     );
     const template = await requireTemplate(this.templates, id);
     const result = await this.send(
@@ -578,12 +571,16 @@ export class SendsController extends Controller(API_BASE_PATH) {
  * The version a test of a published version records: a number names one,
  * "draft" or "published" let the send decide.
  */
-function requestedVersionOf(version: unknown): number | undefined {
-  return typeof version === "number" ? version : undefined;
+function requestedVersionOf(
+  version: z.infer<typeof previewVersionSchema> | undefined,
+): number | undefined {
+  return version === "draft" || version === "published" ? undefined : version;
 }
 
-function variablesOf(send: MailingSend): Record<string, unknown> {
-  return JSON.parse(send.json_variables || "{}") as Record<string, unknown>;
+function variablesOf(send: MailingSend): JsonObject {
+  // SAFETY: json_variables is written only as JSON.stringify(params.variables ?? {}) (services/send.ts) or
+  // JSON.stringify(send.variables) (services/send-import.ts), both a JsonObject.
+  return JSON.parse(send.json_variables || "{}") as JsonObject;
 }
 
 function summarize(template: MailingTemplate): SendTemplateSummary {

package/src/routes/settings.ts

@@ -48,6 +48,8 @@ import {
   settingsPatchSchema,
 } from "../validation/settings.schema";
 import { retentionLimit } from "../crons/retention";
+import { isJsonObject } from "../validation/json";
+import { zodIssuesJson } from "./zod-json";
 
 const INVALID_SETTINGS = "$dms_mailing.errors.invalid_settings";
 const CATEGORIES_REASSIGNED = "$dms_mailing.settings.categories.reassigned";
@@ -61,9 +63,9 @@ const NEXT_RUN_MINUTE = 15;
 const RETENTION_DAYS_PARAM = "days";
 
 /** A settings field the form shows under another name. */
-const FORM_FIELD_OF: Record<string, string> = {
-  blockOnMissingVariables: "missingVariables",
-};
+const FORM_FIELD_OF = new Map([
+  ["blockOnMissingVariables", "missingVariables"],
+]);
 
 const retentionDaysSchema = z.coerce
   .number()
@@ -89,7 +91,7 @@ export interface MailingSettingsResponse extends MailingSettingsValues {
 export interface SettingsNotice {
   title: string;
   color?: string;
-  params?: Record<string, unknown>;
+  params?: Record<string, number | string>;
 }
 
 export interface SettingsWriteResponse extends MailingSettingsValues {
@@ -141,14 +143,16 @@ function webhookUrl(
 /** The issue of a refused write, under the form field it belongs to. */
 function formIssue(issue: z.ZodIssue): z.ZodIssue {
   const [field, ...rest] = issue.path;
-  const formField = FORM_FIELD_OF[String(field)];
+  const formField = FORM_FIELD_OF.get(String(field));
   return formField ? { ...issue, path: [formField, ...rest] } : issue;
 }
 
 /** A refused write: the generic message, and each issue for its field. */
-function invalidSettings(error: unknown): unknown {
-  if (!(error instanceof z.ZodError)) return INVALID_SETTINGS;
-  return { message: INVALID_SETTINGS, issues: error.issues.map(formIssue) };
+function invalidSettings(error: z.ZodError) {
+  return {
+    message: INVALID_SETTINGS,
+    issues: zodIssuesJson(error.issues.map(formIssue)),
+  };
 }
 
 function senderNotice(values: MailingSettingsValues): SettingsNotice[] {
@@ -236,13 +240,12 @@ export class MailingSettingsController extends Controller(
   /** The body as a checked patch; 400 for anything else. */
   private readPatch(raw: Buffer): SettingsPatch {
     const body: unknown = parseBody(raw);
-    const isPatch =
-      typeof body === "object" && body !== null && !Array.isArray(body);
-    assert(isPatch, HTTP_BAD_REQUEST, INVALID_SETTINGS);
+    assert(isJsonObject(body), HTTP_BAD_REQUEST, INVALID_SETTINGS);
     return assertValidation(
-      clearedToEmpty(body as Record<string, unknown>),
+      clearedToEmpty(body),
       (value) => settingsPatchSchema.parse(value),
-      invalidSettings,
+      (error) =>
+        error instanceof z.ZodError ? invalidSettings(error) : INVALID_SETTINGS,
     );
   }
 
@@ -296,7 +299,8 @@ export class MailingSettingsController extends Controller(
     return assertValidation(
       raw,
       (value) => retentionDaysSchema.parse(value),
-      invalidSettings,
+      (error) =>
+        error instanceof z.ZodError ? invalidSettings(error) : INVALID_SETTINGS,
     );
   }
 
@@ -307,12 +311,12 @@ export class MailingSettingsController extends Controller(
   @Get("/category-usage")
   async categoryUsage(): Promise<{ counts: Record<string, number> }> {
     const templates = await this.templates.getAll();
-    const counts: Record<string, number> = {};
+    const counts = new Map<string, number>();
     for (const template of templates) {
       if (!template.category || template.status === ARCHIVED_STATUS) continue;
-      counts[template.category] = (counts[template.category] ?? 0) + 1;
+      counts.set(template.category, (counts.get(template.category) ?? 0) + 1);
     }
-    return { counts };
+    return { counts: Object.fromEntries(counts) };
   }
 
   /**

package/src/routes/suppressions.ts

@@ -18,6 +18,7 @@ import { API_BASE_PATH, HTTP_CONFLICT, HTTP_NOT_FOUND } from "../constants";
 import { SuppressionModel } from "../db";
 import { SuppressionsPageController } from "../pages/suppressions";
 import { suppressAddress } from "../services/suppressions";
+import { zodIssuesJson } from "./zod-json";
 
 const INVALID_SUPPRESSION = "$dms_mailing.suppressions.errors.invalid";
 const ALREADY_SUPPRESSED = "$dms_mailing.suppressions.errors.already";
@@ -32,12 +33,6 @@ const manualSuppressionSchema = z.object({
   note: z.string().trim().max(MAX_NOTE_LENGTH).optional(),
 });
 
-/** A refused entry: the generic message, and each issue under its field. */
-function invalidSuppression(error: unknown): unknown {
-  if (!(error instanceof z.ZodError)) return INVALID_SUPPRESSION;
-  return { message: INVALID_SUPPRESSION, issues: error.issues };
-}
-
 /** An address already on the list, told under the address field. */
 const alreadySuppressed = () => ({
   message: ALREADY_SUPPRESSED,
@@ -56,13 +51,22 @@ export class SuppressionsController extends Controller(
   @TenantScopedModel(SuppressionModel)
   declare suppressions: SuppressionModel;
 
-  /** Puts an address on the list by hand: nothing is sent to it any more. */
+  /**
+   * Puts an address on the list by hand: nothing is sent to it any more. A
+   * refused entry answers the generic message, and each issue under its field.
+   */
   @Post("")
   async add(@JSONBody() body: unknown): Promise<{ added: true }> {
     const input = assertValidation(
       body ?? {},
       (value) => manualSuppressionSchema.parse(value),
-      invalidSuppression,
+      (error) => {
+        if (!(error instanceof z.ZodError)) return INVALID_SUPPRESSION;
+        return {
+          message: INVALID_SUPPRESSION,
+          issues: zodIssuesJson(error.issues),
+        };
+      },
     );
     const isAdded = await suppressAddress(getRequestTenantId(this.ctx), {
       email: input.email,

package/src/routes/template-content.ts

@@ -0,0 +1,45 @@
+import type { MailingTemplate } from "../db";
+import type { TemplateChange } from "../engine";
+import type {
+  CategoryInLocale,
+  TemplateContent,
+  VariableDefinition,
+} from "../types";
+import type { JsonObject } from "../types/json";
+
+export interface TemplateSender {
+  name: string;
+  email: string;
+  replyTo: string;
+}
+
+export interface TemplateContentResponse {
+  /** The template, its name in the reader's language. */
+  template: MailingTemplate;
+  /** The content the editor works on: the draft, else the published one. */
+  content: TemplateContent;
+  /** What customers receive; `null` when the template was never published. */
+  publishedContent: TemplateContent | null;
+  hasDraft: boolean;
+  /** Version customers receive; 0 when never published. */
+  version: number;
+  /** The draft revision a save or a publish must carry back. */
+  revision: number;
+  changes: TemplateChange[];
+  /** The declarations the editor works on: the draft's, else the published. */
+  variables: VariableDefinition[];
+  /** Paths the working content references, across every locale. */
+  detectedVariables: string[];
+  /**
+   * The contract callers send against: the published declarations and the
+   * paths the published content references; `null` when never published.
+   */
+  publishedVariables: VariableDefinition[] | null;
+  publishedDetectedVariables: string[] | null;
+  testData: JsonObject;
+  fallbackLocale: string;
+  /** Whether a send missing a variable fails rather than goes out blank. */
+  blockOnMissingVariables: boolean;
+  categories: CategoryInLocale[];
+  sender: TemplateSender;
+}

package/src/routes/templates.ts

@@ -22,7 +22,6 @@ import {
 import {
   collectContentVariablePaths,
   resolveEmail,
-  type TemplateChange,
   valueFormatOf,
 } from "../engine";
 import {
@@ -31,7 +30,7 @@ import {
   type TemplateFields,
   TemplateModel,
 } from "../db";
-import { saveDetails } from "../data/templates-table";
+import { INVALID_TEMPLATE, saveDetails } from "../data/templates-table";
 import { TemplatesPageController } from "../pages/templates";
 import { forAudience, statsWindowStart } from "../services/metrics";
 import { refreshTemplateAttention } from "../services/template-attention";
@@ -75,18 +74,18 @@ import {
 import {
   BUSINESS_AUDIENCE,
   type CategoryInLocale,
-  type TemplateContent,
   type TemplateStatus,
-  type VariableDefinition,
 } from "../types";
 import {
   duplicateSchema,
   previewSchema,
   publishSchema,
   saveContentSchema,
+  templateDetailsSchema,
   testDataSchema,
   variablesSchema,
 } from "../validation/templates.schema";
+import type { TemplateContentResponse } from "./template-content";
 
 const STARTER_NOT_FOUND = "$dms_mailing.errors.starter_not_found";
 const INVALID_CONTENT = "$dms_mailing.errors.invalid_content";
@@ -125,43 +124,6 @@ export interface CategoriesResponse {
   categories: CategoryInLocale[];
 }
 
-export interface TemplateSender {
-  name: string;
-  email: string;
-  replyTo: string;
-}
-
-export interface TemplateContentResponse {
-  /** The template, its name in the reader's language. */
-  template: MailingTemplate;
-  /** The content the editor works on: the draft, else the published one. */
-  content: TemplateContent;
-  /** What customers receive; `null` when the template was never published. */
-  publishedContent: TemplateContent | null;
-  hasDraft: boolean;
-  /** Version customers receive; 0 when never published. */
-  version: number;
-  /** The draft revision a save or a publish must carry back. */
-  revision: number;
-  changes: TemplateChange[];
-  /** The declarations the editor works on: the draft's, else the published. */
-  variables: VariableDefinition[];
-  /** Paths the working content references, across every locale. */
-  detectedVariables: string[];
-  /**
-   * The contract callers send against: the published declarations and the
-   * paths the published content references; `null` when never published.
-   */
-  publishedVariables: VariableDefinition[] | null;
-  publishedDetectedVariables: string[] | null;
-  testData: Record<string, unknown>;
-  fallbackLocale: string;
-  /** Whether a send missing a variable fails rather than goes out blank. */
-  blockOnMissingVariables: boolean;
-  categories: CategoryInLocale[];
-  sender: TemplateSender;
-}
-
 export interface StarterSummary {
   id: string;
   name: string;
@@ -221,9 +183,9 @@ export class TemplatesController extends Controller(
   }
 
   @Get("/starters")
-  starters(): { starters: StarterSummary[] } {
+  starters() {
     return {
-      starters: STARTER_TEMPLATES.map((starter) => ({
+      starters: STARTER_TEMPLATES.map((starter): StarterSummary => ({
         id: starter.id,
         name: starter.name,
         slug: starter.slug,
@@ -352,7 +314,7 @@ export class TemplatesController extends Controller(
       (value) => saveContentSchema.parse(value),
       () => INVALID_CONTENT,
     );
-    const content = input.content as TemplateContent;
+    const { content } = input;
     const template = await requireTemplate(this.templates, id);
     assertCurrentDraft(template, input.revision);
     const variables = input.variables ?? workingVariables(template);
@@ -514,7 +476,7 @@ export class TemplatesController extends Controller(
     const { content, variables } = input.content
       ? {
           ...workingSnapshot(template),
-          content: input.content as TemplateContent,
+          content: input.content,
         }
       : await this.previewSnapshot(template, input.version);
     const settings = await getSettings(this.tenantId);
@@ -542,9 +504,9 @@ export class TemplatesController extends Controller(
     version: "draft" | "published" | number | undefined,
   ): Promise<TemplateDraft> | TemplateDraft {
     if (version === "published") return publishedSnapshot(template);
-    if (typeof version === "number")
-      return snapshotOfVersion(this.tenantId, template, version);
-    return workingSnapshot(template);
+    if (version === undefined || version === "draft")
+      return workingSnapshot(template);
+    return snapshotOfVersion(this.tenantId, template, version);
   }
 
   /**
@@ -559,7 +521,12 @@ export class TemplatesController extends Controller(
     @JSONBody() body: unknown,
   ) {
     const template = await requireTemplate(this.templates, id);
-    await saveDetails(this.ctx, template, body, this.author);
+    const details = assertValidation(
+      body,
+      (value) => templateDetailsSchema.parse(value),
+      () => INVALID_TEMPLATE,
+    );
+    await saveDetails(this.ctx, template, details, this.author);
     return { id };
   }
 

package/src/routes/zod-json.ts

@@ -0,0 +1,28 @@
+import type { HTTPBody } from "@antelopejs/interface-api";
+import type { ZodIssue } from "zod";
+
+function isJson(value: unknown): value is HTTPBody {
+  if (
+    value === null ||
+    typeof value === "string" ||
+    typeof value === "number" ||
+    typeof value === "boolean"
+  ) {
+    return true;
+  }
+  if (Array.isArray(value)) return value.every(isJson);
+  return typeof value === "object" && Object.values(value).every(isJson);
+}
+
+/**
+ * zod's issues as the JSON value `JSON.stringify` writes for them, so a body
+ * holding it serializes byte for byte as one holding the issues. A `ZodError`
+ * nested in an issue (`unionErrors`, `argumentsError`, `returnTypeError`)
+ * becomes its enumerable fields, `issues` and `name`.
+ */
+export function zodIssuesJson(issues: readonly ZodIssue[]): HTTPBody {
+  const json: unknown = JSON.parse(JSON.stringify(issues));
+  if (!isJson(json))
+    throw new TypeError("zod issues did not serialize to JSON");
+  return json;
+}

package/src/services/attention.ts

@@ -11,6 +11,7 @@ import {
   type TemplateAttentionReason,
 } from "../types";
 import { isDeliveryUntracked, type ProviderTracking } from "./metrics";
+import { isNumber } from "../validation/guards";
 
 export type AttentionTone = "error" | "warning" | "neutral";
 
@@ -238,7 +239,7 @@ function namesOf(templates: MailingTemplate[]): ComposedTextParam {
   };
 }
 
-function problemBreakdown(problems: SendSummary[]): Record<string, number> {
+function problemBreakdown(problems: SendSummary[]) {
   const countOf = (status: string) =>
     problems.filter((send) => send.status === status).length;
   return {
@@ -334,9 +335,9 @@ const COUNT_PARAM = "count";
 function feedParams(
   item: AttentionItem,
 ): Record<string, ComposedTextParam> | undefined {
-  const params: Record<string, ComposedTextParam> = { ...item.params };
+  const params = { ...item.params };
   const count = item.count ?? item.params?.[COUNT_PARAM];
-  if (typeof count === "number") {
+  if (isNumber(count)) {
     params[COUNT_PARAM] = { type: "count", value: count };
   }
   return Object.keys(params).length ? params : undefined;
@@ -374,20 +375,21 @@ type TemplateAttentionRule = (
   context: TemplateAttentionContext,
 ) => boolean;
 
-const TEMPLATE_ATTENTION_RULES: Record<
+const TEMPLATE_ATTENTION_RULES = new Map<
   TemplateAttentionReason,
   TemplateAttentionRule
-> = {
-  stale_draft: (template, context) => isStaleDraft(template, context.now),
-  never_sent: (template, context) =>
-    template.status === "live" && !context.sentSlugs.has(template.slug),
-  missing_locale: (template, context) =>
-    isMissingLocale(template, context.knownLocales),
-};
-
-const TEMPLATE_ATTENTION_REASONS = Object.keys(
-  TEMPLATE_ATTENTION_RULES,
-) as TemplateAttentionReason[];
+>([
+  ["stale_draft", (template, context) => isStaleDraft(template, context.now)],
+  [
+    "never_sent",
+    (template, context) =>
+      template.status === "live" && !context.sentSlugs.has(template.slug),
+  ],
+  [
+    "missing_locale",
+    (template, context) => isMissingLocale(template, context.knownLocales),
+  ],
+]);
 
 /**
  * Why a template needs a look, in a stable order: a draft never published and
@@ -398,7 +400,7 @@ export function templateAttentionReasons(
   template: MailingTemplate,
   context: TemplateAttentionContext,
 ): TemplateAttentionReason[] {
-  return TEMPLATE_ATTENTION_REASONS.filter((reason) =>
-    TEMPLATE_ATTENTION_RULES[reason](template, context),
-  );
+  return [...TEMPLATE_ATTENTION_RULES]
+    .filter(([, applies]) => applies(template, context))
+    .map(([reason]) => reason);
 }