@antelopejs/dms-mailing 0.2.3 → 0.3.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antelopejs/dms-mailing",
-  "version": "0.2.3",
+  "version": "0.3.1",
   "license": "Apache-2.0",
   "repository": {
     "type": "git",
@@ -11,6 +11,7 @@
     "LICENSE",
     "README.md",
     "dist",
+    "!dist/.tsbuildinfo",
     "frontend-vue",
     "src"
   ],
@@ -31,20 +32,18 @@
   "dependencies": {
     "@antelopejs/interface-api": ">=0.0.13 <1.0.0",
     "@antelopejs/interface-api-util": ">=0.1.2 <1.0.0",
-    "@antelopejs/interface-core": ">=0.0.13 <1.0.0",
+    "@antelopejs/interface-core": ">=0.1.1 <1.0.0",
     "@antelopejs/interface-data-api": ">=0.1.9 <1.0.0",
     "@antelopejs/interface-database": "0.1.7",
     "@antelopejs/interface-database-decorators": ">=0.1.6 <1.0.0",
-    "@antelopejs/interface-dms": ">=0.1.0 <1.0.0",
-    "@antelopejs/interface-dms-mailing": ">=0.2.0 <1.0.0",
+    "@antelopejs/interface-dms": ">=0.2.1 <1.0.0",
+    "@antelopejs/interface-dms-mailing": ">=0.4.0 <1.0.0",
     "@antelopejs/interface-email": ">=0.0.5 <1.0.0",
     "node-cron": "^4.2.1",
     "zod": "~3.24.2"
   },
   "devDependencies": {
-    "@antelopejs/core": ">=1.8.0 <2",
-    "@antelopejs/dms": ">=0.3.5 <1.0.0",
-    "@antelopejs/dms-frontend": ">=0.2.0 <1.0.0",
+    "@antelopejs/core": ">=1.9.1 <2",
     "@antelopejs/tooling-configs": ">=0.0.6 <1.0.0",
     "@types/chai": "^4.3.20",
     "@types/mocha": "^10",
@@ -60,10 +59,10 @@
     "release-it": "^19.2.4",
     "release-it-changelogen": "^0.1.0",
     "rimraf": "^6.1.3",
-    "typescript": "^5.9.3"
+    "typescript": "^6.0.3"
   },
   "optionalDependencies": {
-    "@antelopejs/interface-dms-automation": ">=0.0.1 <1.0.0"
+    "@antelopejs/interface-dms-automation": ">=0.1.0 <1.0.0"
   },
   "antelopeJs": {
     "baseUrl": "dist",
@@ -73,19 +72,18 @@
     "test": "src/test/antelope.test.ts"
   },
   "scripts": {
-    "build": "rimraf dist && tsc -p tsconfig.build.json",
+    "build": "rimraf dist && tsc",
     "dev": "ajs project run -w -p playground",
     "dev:frontend": "cd playground && pnpm frontend:dev",
     "frontend:dev": "cd playground && pnpm frontend:dev",
     "lint": "oxlint && oxfmt --check . && cd frontend-vue && pnpm lint",
     "lint:fix": "oxlint --fix --max-warnings=1000000 && oxfmt . && cd frontend-vue && pnpm lint:fix",
     "format": "oxfmt . && cd frontend-vue && pnpm format",
-    "typecheck": "tsc -p tsconfig.json",
+    "typecheck": "tsc --noEmit",
     "knip": "knip --dependencies",
     "knip:all": "knip",
     "release": "pnpm --filter @antelopejs/interface-dms-mailing build && pnpm --dir frontend-vue install --frozen-lockfile && release-it",
     "test": "pnpm run test:backend && pnpm run test:layer",
-    "test:frontend": "node scripts/check-frontend.mjs",
     "test:backend": "pnpm run build && ajs module test .",
     "test:layer": "cd frontend-vue && pnpm test",
     "test:unit": "pnpm run build && DMS_MAILING_TEST_DIR=dist/test/unit ajs module test .",

package/src/antelope-modules.ts

@@ -18,12 +18,12 @@ export const SHARED_MODULE_SOURCES = {
   dms: {
     type: "package",
     package: "@antelopejs/dms",
-    version: ">=0.0.1 <1.0.0",
+    version: ">=0.4.3 <1.0.0",
   },
   mongodb: {
     type: "package",
     package: "@antelopejs/mongodb",
-    version: "^1.3.0",
+    version: "^1.3.1",
   },
   "auth-jwt": {
     type: "package",
@@ -33,16 +33,16 @@ export const SHARED_MODULE_SOURCES = {
   api: {
     type: "package",
     package: "@antelopejs/api",
-    version: "1.2.5",
+    version: "^1.3.0",
   },
   "file-storage-local": {
     type: "package",
     package: "@antelopejs/file-storage-local",
-    version: "^0.1.4",
+    version: "^0.1.5",
   },
   nodemailer: {
     type: "package",
     package: "@antelopejs/nodemailer",
-    version: "^0.0.4",
+    version: "^0.0.5",
   },
 } as const;

package/src/constants.ts

@@ -4,10 +4,7 @@ export const TABLES_BASE_PATH = `${API_BASE_PATH}/tables`;
 export const FRONTEND_MODULE_NAME = "@antelopejs/dms-mailing-frontend-vue";
 export const EMAIL_TEMPLATE_NAME = "EmailMailingTemplate";
 
-export const MAILING_ACCESS_PERMISSION = "mailing.access";
-export const MAILING_TEMPLATES_MANAGE_PERMISSION = "mailing.templates.manage";
 export const MAILING_SEND_PERMISSION = "mailing.send";
-export const MAILING_SETTINGS_MANAGE_PERMISSION = "mailing.settings.manage";
 
 export const OVERVIEW_PERIOD_SCOPE = "mailing-overview";
 export const SENDS_PERIOD_SCOPE = "mailing-sends";

package/src/crons/retention.ts

@@ -92,7 +92,9 @@ export async function purgeOrphanEvents(
 }
 
 async function purgeTenant(tenantId: string, now: Date): Promise<number> {
-  const settings = await GetModel(SettingsModel, tenantId).getSingleton();
+  const settings = await GetModel(SettingsModel, tenantId).getSingleton(
+    tenantId,
+  );
   if (!settings || settings.logRetentionDays < MIN_RETENTION_DAYS) return 0;
   const limit = retentionLimit(settings.logRetentionDays, now);
   const purged = await purgeInPages(tenantPass(tenantId, limit));

package/src/data/templates-table.ts

@@ -39,6 +39,7 @@ import { createTemplateSchema } from "../validation/templates.schema";
 import { parseBody } from "./body";
 
 const DUPLICATE_SLUG = "$dms_mailing.errors.duplicate_slug";
+const SLUG_IMMUTABLE = "$dms_mailing.errors.slug_immutable";
 const SOURCE_NOT_FOUND = "$dms_mailing.errors.template_not_found";
 const CREATE_ONLY = { edit: ReadonlyBehaviorType.disabled };
 // Read-only columns render as empty dashes on the create form; the four fields
@@ -99,9 +100,54 @@ function withSeeding(base: DataControllerCallback): DataControllerCallback {
   };
 }
 
+interface EditParams {
+  id: string;
+}
+
+/**
+ * The body an edit may apply. Sends resolve templates by slug and nothing
+ * enforces its uniqueness but the create checks, so a slug never changes once
+ * set: a different one is refused, a missing one (which the data-api edit
+ * would null) is kept.
+ */
+async function withStoredSlug(
+  tenantId: string,
+  templateId: string,
+  body: Buffer | string,
+): Promise<Buffer | string> {
+  const stored = await GetModel(TemplateModel, tenantId).get(templateId);
+  if (!stored) return body;
+  const edit = parseBody(body);
+  if (edit.slug !== undefined && edit.slug !== stored.slug) {
+    throw new HTTPResult(HTTP_CONFLICT, SLUG_IMMUTABLE);
+  }
+  return JSON.stringify({ ...edit, slug: stored.slug });
+}
+
+function withFixedSlug(base: DataControllerCallback): DataControllerCallback {
+  return {
+    ...base,
+    func: async function (
+      this: unknown,
+      ctx: RequestContext,
+      params: EditParams,
+      body: Buffer | string,
+      ...rest: unknown[]
+    ) {
+      const guarded = await withStoredSlug(
+        getRequestTenantId(ctx),
+        params.id,
+        body,
+      );
+      return base.func.call(this, ctx, params, guarded, ...rest);
+    },
+  };
+}
+
 const templateRoutes = {
   ...TableViewRoutes.All,
   new: withSeeding(TableViewRoutes.New),
+  edit: withFixedSlug(TableViewRoutes.Edit),
 };
 
 @RegisterDataController()

package/src/db/models/sends.model.ts

@@ -14,6 +14,9 @@ type NewSend = Omit<
   "_id" | "createdAt" | "revision" | "isRetiring" | "lastActivityAt"
 >;
 
+/** A send as the metrics read it: everything but the rendered variables. */
+export type SendSummary = Omit<MailingSend, "json_variables">;
+
 type SendActivity = Pick<
   MailingSend,
   "status" | "opens" | "clicks" | "lastEventAt" | "provider"
@@ -74,11 +77,12 @@ export class SendModel extends BasicDataModel(
     return rows[0];
   }
 
-  listBetween(from: Date, to: Date): Promise<MailingSend[]> {
+  listBetween(from: Date, to: Date): Promise<SendSummary[]> {
     return this.table
       .filter((row) => row.key("createdAt").ge(from))
       .filter((row) => row.key("createdAt").lt(to))
-      .run();
+      .without("json_variables")
+      .run() as Promise<SendSummary[]>;
   }
 
   listOlderThan(limit: Date, pageSize: number): Promise<MailingSend[]> {

package/src/db/models/settings.model.ts

@@ -5,7 +5,13 @@ export class SettingsModel extends BasicDataModel(
   MailingSettings,
   MAILING_SETTINGS_TABLE_NAME,
 ) {
-  async getSingleton(): Promise<MailingSettings | undefined> {
+  /**
+   * The tenant's settings row, keyed by the tenant id. Rows written before the
+   * key existed carry a random id and are still found by a scan.
+   */
+  async getSingleton(tenantId: string): Promise<MailingSettings | undefined> {
+    const keyed = await this.get(tenantId);
+    if (keyed) return keyed;
     const rows = await this.getAll();
     return rows[0];
   }

package/src/db/tables/send-events.table.ts

@@ -21,7 +21,6 @@ export class MailingSendEvent extends Table {
   @Field("string")
   declare type: SendEventType;
 
-  @Index()
   @Field("date")
   declare at: Date;
 

package/src/db/tables/sends.table.ts

@@ -20,7 +20,6 @@ export class MailingSend extends Table {
   @Field("date")
   declare createdAt: Date;
 
-  @Index()
   @Field("string")
   declare templateId: string;
 

package/src/db/tables/templates.table.ts

@@ -16,7 +16,6 @@ export class MailingTemplate extends Table {
   @Field("string")
   declare _id: string;
 
-  @Index()
   @CreationTime()
   @Field("date")
   declare createdAt: Date;

package/src/hooks/tenant-export.ts

@@ -64,7 +64,7 @@ export async function* jsonArrayChunks<T>(
 async function exportedSettings(
   tenantId: string,
 ): Promise<ExportedSettings | null> {
-  const row = await GetModel(SettingsModel, tenantId).getSingleton();
+  const row = await GetModel(SettingsModel, tenantId).getSingleton(tenantId);
   if (!row) return null;
   return {
     fallbackLocale: row.fallbackLocale,

package/src/pages/editor.ts

@@ -1,7 +1,7 @@
 import { PageController, RegisterPage } from "@antelopejs/interface-dms/page";
 import { CustomComponent } from "@antelopejs/interface-dms/base/custom";
 import { DefaultLayout } from "@antelopejs/interface-dms/base/layouts";
-import { MAILING_TEMPLATES_MANAGE_PERMISSION, MODULE_ID } from "../constants";
+import { MODULE_ID } from "../constants";
 
 const EDITOR_PAGE_ORDER = 2;
 
@@ -15,7 +15,6 @@ export class MailingEditorController extends PageController(
     module: MODULE_ID,
     order: EDITOR_PAGE_ORDER,
     hidden: true,
-    permission: { id: MAILING_TEMPLATES_MANAGE_PERMISSION },
   },
   DefaultLayout({ fullWidth: true }),
 ) {

package/src/pages/overview.ts

@@ -13,7 +13,6 @@ import { CustomComponent } from "@antelopejs/interface-dms/base/custom";
 import { DefaultLayout } from "@antelopejs/interface-dms/base/layouts";
 import {
   API_BASE_PATH,
-  MAILING_ACCESS_PERMISSION,
   MAILING_SENDS_TOPIC,
   MODULE_ID,
   OVERVIEW_PERIOD_SCOPE,
@@ -50,7 +49,6 @@ export class OverviewPageController extends PageController(
     icon: "i-ph-chart-pie-slice",
     module: MODULE_ID,
     order: OVERVIEW_ORDER,
-    permission: { id: MAILING_ACCESS_PERMISSION },
   },
   DefaultLayout({ fullWidth: true }),
 ) {

package/src/pages/sends.ts

@@ -10,12 +10,7 @@ import {
 import { CustomComponent } from "@antelopejs/interface-dms/base/custom";
 import { DefaultLayout } from "@antelopejs/interface-dms/base/layouts";
 import { TableView } from "@antelopejs/interface-dms/base/table-view";
-import {
-  API_BASE_PATH,
-  MAILING_ACCESS_PERMISSION,
-  MODULE_ID,
-  SENDS_PERIOD_SCOPE,
-} from "../constants";
+import { API_BASE_PATH, MODULE_ID, SENDS_PERIOD_SCOPE } from "../constants";
 import { SendsTableAPI } from "../data/sends-table";
 import {
   OPERATIONAL_AUDIENCE,
@@ -58,7 +53,6 @@ export class SendsPageController extends PageController(
     icon: "i-ph-paper-plane-tilt",
     module: MODULE_ID,
     order: SENDS_ORDER,
-    permission: { id: MAILING_ACCESS_PERMISSION },
   },
   DefaultLayout({ fullWidth: true }),
 ) {

package/src/pages/settings/page.ts

@@ -5,7 +5,7 @@ import {
   settingsCategory,
 } from "@antelopejs/interface-dms/page";
 import { DefaultLayout } from "@antelopejs/interface-dms/base/layouts";
-import { MAILING_SETTINGS_MANAGE_PERMISSION, MODULE_ID } from "../../constants";
+import { MODULE_ID } from "../../constants";
 import { mailingSettingsForm } from "./form";
 
 const SETTINGS_ORDER = 3;
@@ -15,7 +15,6 @@ export const mailingSettingsCategory = Category(MODULE_ID, {
   displayName: "$dms_mailing.title",
   icon: "i-ph-envelope-simple",
   order: SETTINGS_ORDER,
-  authOnly: true,
 });
 
 @RegisterPage()
@@ -26,7 +25,6 @@ export class MailingSettingsPage extends PageController(
     description: "$dms_mailing.settings.description",
     icon: "i-ph-gear",
     category: mailingSettingsCategory,
-    permission: { id: MAILING_SETTINGS_MANAGE_PERMISSION },
   },
   DefaultLayout(),
 ) {

package/src/pages/templates.ts

@@ -3,12 +3,7 @@ import { DefaultLayout } from "@antelopejs/interface-dms/base/layouts";
 import type { TableViewTab } from "@antelopejs/interface-dms/base";
 import { CustomComponent } from "@antelopejs/interface-dms/base/custom";
 import { TableView } from "@antelopejs/interface-dms/base/table-view";
-import {
-  API_BASE_PATH,
-  GALLERY_DISPLAY_ID,
-  MAILING_ACCESS_PERMISSION,
-  MODULE_ID,
-} from "../constants";
+import { API_BASE_PATH, GALLERY_DISPLAY_ID, MODULE_ID } from "../constants";
 import { TemplatesTableAPI } from "../data/templates-table";
 import "./module";
 
@@ -43,7 +38,6 @@ export class TemplatesPageController extends PageController(
     icon: "i-ph-envelope-simple",
     module: MODULE_ID,
     order: TEMPLATES_ORDER,
-    permission: { id: MAILING_ACCESS_PERMISSION },
   },
   DefaultLayout({ fullWidth: true }),
 ) {

package/src/permissions.ts

@@ -1,44 +1,16 @@
-import {
-  type Permission,
-  RegisterPermission,
-} from "@antelopejs/interface-dms/permissions";
-import {
-  MAILING_ACCESS_PERMISSION,
-  MAILING_SEND_PERMISSION,
-  MAILING_SETTINGS_MANAGE_PERMISSION,
-  MAILING_TEMPLATES_MANAGE_PERMISSION,
-} from "./constants";
+import { GetPermissionId } from "@antelopejs/interface-dms/page";
+import { RegisterPermission } from "@antelopejs/interface-dms/permissions";
+import { MAILING_SEND_PERMISSION } from "./constants";
+import { SendsPageController } from "./pages/sends";
 
-const MAILING_PERMISSIONS: Permission[] = [
-  {
-    id: MAILING_ACCESS_PERMISSION,
-    title: "Access mailing",
-    icon: "i-ph-envelope-simple",
-    description: "See templates, sends and mailing metrics",
-  },
-  {
-    id: MAILING_TEMPLATES_MANAGE_PERMISSION,
-    title: "Manage e-mail templates",
-    icon: "i-ph-note-pencil",
-    description: "Create, edit, publish, duplicate and archive templates",
-    dependencies: [MAILING_ACCESS_PERMISSION],
-  },
-  {
-    id: MAILING_SEND_PERMISSION,
-    title: "Send e-mails and tests",
-    icon: "i-ph-paper-plane-tilt",
-    description: "Trigger test sends and replay a previous send",
-    dependencies: [MAILING_ACCESS_PERMISSION],
-  },
-  {
-    id: MAILING_SETTINGS_MANAGE_PERMISSION,
-    title: "Manage mailing settings",
-    icon: "i-ph-sliders",
-    description: "Edit sender identity, retention and template categories",
-    dependencies: [MAILING_ACCESS_PERMISSION],
-  },
-];
+// `@RegisterPage` publishes the page synchronously when the class is defined,
+// so the sends page's default permission id is known once it is imported.
+const sendsPagePermissionId = GetPermissionId(SendsPageController);
 
-for (const permission of MAILING_PERMISSIONS) {
-  RegisterPermission(permission.id, permission);
-}
+RegisterPermission(MAILING_SEND_PERMISSION, {
+  id: MAILING_SEND_PERMISSION,
+  title: "Send e-mails and tests",
+  icon: "i-ph-paper-plane-tilt",
+  description: "Trigger test sends and replay a previous send",
+  dependencies: sendsPagePermissionId ? [sendsPagePermissionId] : [],
+});

package/src/routes/events.ts

@@ -11,7 +11,7 @@ import { getRequestTenantId } from "@antelopejs/interface-dms/request-tenant";
 import { z } from "zod";
 import { API_BASE_PATH, HTTP_FORBIDDEN } from "../constants";
 import { recordEmailEvent, webhookSecretMatches } from "../services/events";
-import { getSettings } from "../services/settings";
+import { findSettings } from "../services/settings";
 import { SEND_STATUSES, type SendStatus } from "../types";
 
 const SECRET_HEADER = "x-mailing-webhook-secret";
@@ -39,9 +39,9 @@ export class MailingEventsController extends Controller(
   ) {
     const event = assertValidation(body, (value) => eventSchema.parse(value));
     const tenantId = event.tenantId ?? getRequestTenantId(this.ctx);
-    const settings = await getSettings(tenantId);
+    const settings = await findSettings(tenantId);
     assert(
-      webhookSecretMatches(secret, settings.webhookSecret),
+      webhookSecretMatches(secret, settings?.webhookSecret),
       HTTP_FORBIDDEN,
       BAD_SECRET,
     );

package/src/routes/metrics.ts

@@ -12,7 +12,7 @@ import type { TopListItem } from "@antelopejs/interface-dms/base";
 import type { User } from "@antelopejs/interface-dms/auth/db";
 import { API_BASE_PATH, HTTP_NOT_FOUND } from "../constants";
 import {
-  type MailingSend,
+  type SendSummary,
   type MailingTemplate,
   SendModel,
   TemplateModel,
@@ -91,7 +91,7 @@ export class MetricsController extends Controller(`${API_BASE_PATH}/metrics`) {
     return readAudience(this.ctx.url.searchParams.get(SEND_AUDIENCE_QUERY_KEY));
   }
 
-  private async load(range: DateRange): Promise<MailingSend[]> {
+  private async load(range: DateRange): Promise<SendSummary[]> {
     const rows = await this.sends.listBetween(range.from, range.to);
     return forAudience(rows, this.audience);
   }
@@ -228,7 +228,7 @@ async function readTracking(): Promise<ProviderTracking | null> {
 
 function toTemplateItem(
   slug: string,
-  rows: MailingSend[],
+  rows: SendSummary[],
   templates: MailingTemplate[],
   extract: (totals: Totals) => number,
 ): TopListItem {

package/src/routes/period.ts

@@ -21,14 +21,19 @@ function parseDate(raw: string | undefined): Date | undefined {
   return Number.isNaN(parsed.getTime()) ? undefined : parsed;
 }
 
+/** Every window is read from the send log in full, so none may exceed the cap. */
+function clampToMaxWindow(requested: Date, to: Date): DateRange {
+  const earliest = to.getTime() - MAX_WINDOW_DAYS * DAY_MS;
+  const from = requested.getTime() < earliest ? new Date(earliest) : requested;
+  return { from, to };
+}
+
 export function currentRange(ctx: RangeContext): DateRange {
   const to = parseDate(readQuery(ctx, "to")) ?? new Date();
   const requested =
     parseDate(readQuery(ctx, "from")) ??
     new Date(to.getTime() - DEFAULT_WINDOW_DAYS * DAY_MS);
-  const earliest = to.getTime() - MAX_WINDOW_DAYS * DAY_MS;
-  const from = requested.getTime() < earliest ? new Date(earliest) : requested;
-  return { from, to };
+  return clampToMaxWindow(requested, to);
 }
 
 export function comparisonRange(
@@ -37,7 +42,7 @@ export function comparisonRange(
 ): DateRange {
   const from = parseDate(readQuery(ctx, "compareFrom"));
   const to = parseDate(readQuery(ctx, "compareTo"));
-  if (from && to) return { from, to };
+  if (from && to) return clampToMaxWindow(from, to);
   const span = current.to.getTime() - current.from.getTime();
   return {
     from: new Date(current.from.getTime() - span),

package/src/routes/templates.ts

@@ -96,7 +96,7 @@ export class TemplatesController extends Controller(
 
   /**
    * The tenant's categories for a category picker. Separate from `/settings`,
-   * which is guarded by the settings-manage permission a template editor need
+   * which is guarded by the settings page permission a template editor need
    * not hold.
    */
   @Get("/categories")

package/src/services/attention.ts

@@ -1,4 +1,4 @@
-import type { MailingSend, MailingTemplate } from "../db";
+import type { SendSummary, MailingTemplate } from "../db";
 import { PROBLEM_STATUSES } from "../types";
 
 export type AttentionTone = "error" | "warning" | "neutral";
@@ -24,7 +24,7 @@ const isStaleDraft = (template: MailingTemplate, now: number): boolean =>
   !template.publishedAt &&
   now - new Date(template.updatedAt).getTime() > STALE_DRAFT_DAYS * DAY_MS;
 
-function problemsItem(sends: MailingSend[]): AttentionItem[] {
+function problemsItem(sends: SendSummary[]): AttentionItem[] {
   const problems = sends.filter((send) =>
     PROBLEM_STATUSES.includes(send.status),
   );
@@ -62,7 +62,7 @@ function staleDraftsItem(templates: MailingTemplate[]): AttentionItem[] {
 
 function neverSentItem(
   templates: MailingTemplate[],
-  sends: MailingSend[],
+  sends: SendSummary[],
 ): AttentionItem[] {
   const used = new Set(sends.map((send) => send.templateSlug));
   const unused = templates.filter(
@@ -89,8 +89,8 @@ function neverSentItem(
  */
 export interface AttentionWindow {
   templates: MailingTemplate[];
-  sends: MailingSend[];
-  excluded: MailingSend[];
+  sends: SendSummary[];
+  excluded: SendSummary[];
   /** What the configured provider can report; `null` when it is unreachable. */
   tracking: ProviderTracking | null;
 }

package/src/services/events.ts

@@ -104,14 +104,14 @@ export async function recordEmailEvent(
 /**
  * Whether a webhook request carries the tenant's secret.
  *
- * Fails closed on a blank stored secret: the event endpoint is the module's
- * only unauthenticated route, so "no secret configured" must refuse everything
- * rather than accept an empty header. The comparison itself is constant-time;
+ * Fails closed on a blank or missing stored secret: the event endpoint is the
+ * module's only unauthenticated route, so "no secret configured" must refuse
+ * everything rather than accept an empty header. The comparison itself is constant-time;
  * only the length is observable.
  */
 export function webhookSecretMatches(
   provided: string | undefined,
-  stored: string,
+  stored: string | undefined,
 ): boolean {
   if (!stored || !provided) return false;
   const left = Buffer.from(provided);

package/src/services/metrics.ts

@@ -1,4 +1,4 @@
-import type { MailingSend } from "../db";
+import type { SendSummary } from "../db";
 import {
   BUSINESS_AUDIENCE,
   OPERATIONAL_AUDIENCE,
@@ -6,7 +6,7 @@ import {
   type SendStatus,
 } from "../types";
 
-const AUDIENCE_KEEPS: Record<SendAudience, (send: MailingSend) => boolean> = {
+const AUDIENCE_KEEPS: Record<SendAudience, (send: SendSummary) => boolean> = {
   [BUSINESS_AUDIENCE]: (send) => !send.isTest,
   [OPERATIONAL_AUDIENCE]: () => true,
 };
@@ -22,9 +22,9 @@ export function readAudience(raw: string | null | undefined): SendAudience {
 }
 
 export function forAudience(
-  sends: MailingSend[],
+  sends: SendSummary[],
   audience: SendAudience,
-): MailingSend[] {
+): SendSummary[] {
   return sends.filter(AUDIENCE_KEEPS[audience]);
 }
 
@@ -72,13 +72,13 @@ export const ratio = (part: number, whole: number): number =>
   whole ? (part / whole) * PERCENT : 0;
 
 const countIf = (
-  sends: MailingSend[],
-  predicate: (send: MailingSend) => boolean,
+  sends: SendSummary[],
+  predicate: (send: SendSummary) => boolean,
 ): number => sends.filter(predicate).length;
 
 const byStatus =
   (status: SendStatus) =>
-  (send: MailingSend): boolean =>
+  (send: SendSummary): boolean =>
     send.status === status;
 
 function median(values: number[]): number {
@@ -87,7 +87,7 @@ function median(values: number[]): number {
   return sorted[Math.floor(sorted.length / 2)] as number;
 }
 
-export function aggregate(sends: MailingSend[]): Totals {
+export function aggregate(sends: SendSummary[]): Totals {
   const delivered = countIf(sends, (send) =>
     DELIVERED_LIKE.includes(send.status),
   );
@@ -138,7 +138,7 @@ const dayKey = (date: Date): string =>
  * still counted it.
  */
 export function dailySeries(
-  sends: MailingSend[],
+  sends: SendSummary[],
   from: Date,
   to: Date,
 ): SeriesPoint[] {