@anolilab/eslint-config 4.0.3 → 4.0.4

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+### @anolilab/eslint-config [4.0.4](https://github.com/anolilab/javascript-style-guide/compare/@anolilab/eslint-config@4.0.3...@anolilab/eslint-config@4.0.4) (2022-05-17)
+
+
+### Bug Fixes
+
+* fixed more found issues with the config loading ([f8042c9](https://github.com/anolilab/javascript-style-guide/commit/f8042c91c6b8bfc3b009e014fb34e978c6c64b32))
+
 ### @anolilab/eslint-config [4.0.3](https://github.com/anolilab/javascript-style-guide/compare/@anolilab/eslint-config@4.0.2...@anolilab/eslint-config@4.0.3) (2022-05-16)
 
 

package/README.md

@@ -111,52 +111,7 @@ As for whether two spaces or four spaces are used for indentation and whether th
 
 `@anolilab/eslint-config` does not include all style-related rules, so there is no need to install `eslint-config-prettier`. Install `prettier` and if you use `VSCode` the related plugins.
 
-Here is a `.prettierrc.cjs` configuration used by Anolilab Team for reference only:
-
-```js
-// .prettierrc.cjs
-export default {
-  // max 120 characters per line
-  printWidth: 120,
-  // use 2 spaces for indentation
-  tabWidth: 4,
-  // use spaces instead of indentations
-  useTabs: false,
-  // semicolon at the end of the line
-  semi: true,
-  // use single quotes
-  singleQuote: false,
-  // object's key is quoted only when necessary
-  quoteProps: 'as-needed',
-  // use double quotes instead of single quotes in jsx
-  jsxSingleQuote: false,
-  // no comma at the end
-  trailingComma: 'all',
-  // spaces are required at the beginning and end of the braces
-  bracketSpacing: true,
-  // end tag of jsx need to wrap
-  jsxBracketSameLine: false,
-  // brackets are required for arrow function parameter, even when there is only one parameter
-  arrowParens: 'always',
-  // format the entire contents of the file
-  rangeStart: 0,
-  rangeEnd: Infinity,
-  // no need to write the beginning @prettier of the file
-  requirePragma: false,
-  // No need to automatically insert @prettier at the beginning of the file
-  insertPragma: false,
-  // use default break criteria
-  proseWrap: 'preserve',
-  // decide whether to break the html according to the display style
-  htmlWhitespaceSensitivity: 'css',
-  // vue files script and style tags indentation
-  vueIndentScriptAndStyle: false,
-  // lf for newline
-  endOfLine: 'lf',
-  // formats quoted code embedded
-  embeddedLanguageFormatting: 'auto',
-};
-```
+This the used [.prettierrc.cjs](../prettier-config/index.cjs) configuration by Anolilab Team only for reference.
 
 ## Using experimental features with JavaScript
 

package/config.cjs

@@ -69,7 +69,7 @@ testRules.forEach((depRule) => {
 
 if (hasTypescript) {
     pRules.push("typescript");
-    extraInstalled.push(["@typescript-eslint/parser", "@typescript-eslint/eslint-plugin"]);
+    extraInstalled.push(["typescript", "@typescript-eslint/parser"], ["typescript", "@typescript-eslint/eslint-plugin"]);
 
     if (hasAnyDep("eslint-plugin-typescript-sort-keys")) {
         pRules.push("typescript-sort-keys");

package/index.cjs

@@ -6,7 +6,7 @@ const { rules, pluginRules, extraInstallPackage } = require("./config.cjs");
 // Workaround VS Code trying to run this file twice!
 if (!global.hasAnolilabEsLintConfigLoaded) {
     checkMissing(pluginRules, extraInstallPackage);
-    showLoaded(pluginRules, []);
+    showLoaded(pluginRules, extraInstallPackage);
 
     global.hasAnolilabEsLintConfigLoaded = true;
 }

package/lib/check-missing.cjs

@@ -1,7 +1,7 @@
 const isModuleAvailable = require("./is-module-available.cjs");
 const { consoleLog } = require("./loggers.cjs");
 
-const moduleNotAvailable = (package_) => !isModuleAvailable(package_.split("@")[0]);
+const moduleNotAvailable = (package_) => !isModuleAvailable(package_);
 
 const atLatest = (package_) => {
     if (!package_.split("@").includes("@")) {
@@ -42,7 +42,10 @@ or
 
   yarn add ${notInstalled.map((element) => atLatest(element)).join(" ")} --dev
 
-  `);
+or
+
+  pnpm add ${notInstalled.map((element) => atLatest(element)).join(" ")} -D
+`);
 
     // process.exit(1); // eslint-disable-line unicorn/no-process-exit
 };

package/lib/show-loaded.cjs

@@ -1,13 +1,21 @@
 const { consoleLog, consolePlugin } = require("./loggers.cjs");
 
 module.exports = function showLoaded(rules, extraInstallPackage) {
+    const all = [...rules];
+
     extraInstallPackage.forEach(([rule, package_]) => {
-        if (rules.includes(rule)) {
-            rules.push(package_);
+        if (all.includes(rule)) {
+            all.push(package_);
         }
     });
 
     consoleLog("\n@anolilab/eslint-config loaded the following packages:\n");
 
-    rules.forEach((element) => { consolePlugin(element); });
+    all.forEach((element) => {
+        if (element[0] === "@") {
+            consoleLog(`  ${element}`);
+        } else {
+            consolePlugin(element);
+        }
+    });
 };

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@anolilab/eslint-config",
-    "version": "4.0.3",
+    "version": "4.0.4",
     "description": "ESLint shareable config for the Anolilab JavaScript style guide.",
     "keywords": [
         "css",
@@ -79,7 +79,7 @@
     "devDependencies": {
         "@testing-library/dom": "8.13.0",
         "@typescript-eslint/eslint-plugin": "^5.19.0",
-        "@typescript-eslint/parser": "5.23.0",
+        "@typescript-eslint/parser": "5.24.0",
         "eslint": "8.15.0",
         "eslint-find-rules": "4.1.0",
         "eslint-plugin-babel": "5.3.1",

package/rules/plugins/typescript.cjs

@@ -4,6 +4,16 @@ const { rules: baseES6Rules } = require("../es6.cjs");
 const { rules: baseImportsRules } = require("./import.cjs");
 const { rules: baseStyleRules } = require("../style.cjs");
 const { rules: baseVariablesRules } = require("../variables.cjs");
+const { hasDep } = require("../../lib/utils.cjs");
+const { consoleLog } = require("../../lib/loggers.cjs");
+
+let { indent } = baseStyleRules;
+
+if (hasDep("prettier")) {
+    consoleLog("Found prettier as dependency, disabling the '@typescript-eslint/indent' rule to fix wrong behavior of the rule; @see https://github.com/typescript-eslint/typescript-eslint/issues/1824");
+
+    indent = "off";
+}
 
 module.exports = {
     overrides: [
@@ -92,7 +102,7 @@ module.exports = {
                 // Replace 'indent' rule with '@typescript-eslint' version
                 // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/indent.md
                 indent: "off",
-                "@typescript-eslint/indent": baseStyleRules.indent,
+                "@typescript-eslint/indent": indent,
 
                 // Replace 'keyword-spacing' rule with '@typescript-eslint' version
                 // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/keyword-spacing.md