@ankhorage/devtools 1.4.1 → 1.5.1

package/dist/tools/eslint/index.d.ts

@@ -1,9 +1,9 @@
-import tseslint from 'typescript-eslint';
+import type { Linter } from 'eslint';
 import type { DevtoolsConfigOptions } from './types.js';
 export declare const defaultIgnores: readonly ["**/ios/**", "**/android/**", "**/dist/**", "**/build/**", "**/.expo/**", "**/.next/**", "**/node_modules/**", "**/*.d.ts", "**/templates/**", "**/files/**"];
 export declare const defaultRestrictedImports: readonly [{
     readonly name: "react-native-reanimated-dnd";
     readonly message: "Forbidden in Ankhorage packages. Use '@ankhorage/react-native-reanimated-dnd-web' directly.";
 }];
-export declare function createConfig(options: DevtoolsConfigOptions): ReturnType<typeof tseslint.config>;
+export declare function createConfig(options: DevtoolsConfigOptions): Linter.Config[];
 export type { DevtoolsConfigOptions, DevtoolsEslintProfile, FlatConfigItem, ResolvedDevtoolsEslintProfile, RestrictedImport, } from './types.js';

package/dist/tools/eslint/index.js

@@ -4,13 +4,13 @@
  * The default `profile: 'auto'` reads the nearest `package.json` from `tsconfigRootDir` and uses
  * `@ankhorage/utility/project` to select overlapping project traits. React Native and Expo select
  * the `react-native` profile, React and Next.js select `react`, and other projects use `base`.
- * Consumers can explicitly select `base`, `react`, or `react-native` when automatic detection is
- * not appropriate.
  *
  * Every profile includes the shared TypeScript, import, unused-import, Prettier, security, and
  * quality rules. The common quality limits are 50 effective lines per function, 300 effective
- * lines per file, and modified cyclomatic complexity 15. React adds React and Hooks correctness
- * rules; React Native composes the React profile and adds focused React Native rules.
+ * lines per file, and modified cyclomatic complexity 15. Forward exports are forbidden outside
+ * declared package entrypoints and explicit `index.*` barrels so implementation files export only
+ * symbols they own. React adds React and Hooks correctness rules; React Native composes the React
+ * profile and adds focused React Native rules.
  *
  * Repository-specific behavior stays additive: `additionalIgnores`, `restrictedImports`, and
  * `overrides` extend the central policy instead of replacing it. Narrow local overrides remain the
@@ -21,6 +21,7 @@
  */
 import { fixupPluginRules } from '@eslint/compat';
 import js from '@eslint/js';
+import { defineConfig } from 'eslint/config';
 import prettierConfig from 'eslint-config-prettier';
 import importPlugin from 'eslint-plugin-import';
 import prettierPlugin from 'eslint-plugin-prettier';
@@ -31,6 +32,8 @@ import securityPlugin from 'eslint-plugin-security';
 import simpleImportSort from 'eslint-plugin-simple-import-sort';
 import unusedImports from 'eslint-plugin-unused-imports';
 import tseslint from 'typescript-eslint';
+import { createModuleOwnershipConfig } from './moduleOwnership.js';
+import { resolvePackageEntrypointFiles } from './packageEntrypoints.js';
 import { resolveEslintProfile } from './profile.js';
 export const defaultIgnores = [
     '**/ios/**',
@@ -53,7 +56,8 @@ export const defaultRestrictedImports = [
 export function createConfig(options) {
     const normalized = normalizeOptions(options);
     const profile = resolveEslintProfile(options);
-    return tseslint.config({ ignores: [...defaultIgnores, ...normalized.additionalIgnores] }, { ...js.configs.recommended, files: normalized.files }, ...createTypeCheckedConfigs(normalized), createBaseConfig(normalized), ...createProfileConfigs(profile, normalized.files), ...normalized.overrides, ...(normalized.includePrettier ? [prettierConfig] : []));
+    const packageEntrypoints = resolvePackageEntrypointFiles(options);
+    return defineConfig({ ignores: [...defaultIgnores, ...normalized.additionalIgnores] }, { ...js.configs.recommended, files: normalized.files }, ...createTypeCheckedConfigs(normalized), createBaseConfig(normalized), createModuleOwnershipConfig(normalized.files, packageEntrypoints), ...createProfileConfigs(profile, normalized.files), ...normalized.overrides, ...(normalized.includePrettier ? [prettierConfig] : []));
 }
 function normalizeOptions(options) {
     return {
@@ -161,7 +165,10 @@ function createProfileConfigs(profile, files) {
 function createReactConfig(files) {
     return {
         files,
-        plugins: { react: reactPlugin, 'react-hooks': reactHooksPlugin },
+        plugins: {
+            react: reactPlugin,
+            'react-hooks': fixupPluginRules({ rules: reactHooksPlugin.rules }),
+        },
         settings: { react: { version: 'detect' } },
         rules: {
             'react/no-danger': 'error',

package/dist/tools/eslint/moduleOwnership.d.ts

@@ -0,0 +1,2 @@
+import type { FlatConfigItem } from './types.js';
+export declare function createModuleOwnershipConfig(files: string[], packageEntrypoints?: string[]): FlatConfigItem;

package/dist/tools/eslint/moduleOwnership.js

@@ -0,0 +1,64 @@
+import { basename, normalize } from 'node:path';
+const INDEX_BARREL_FILE = /^index\.(?:ts|tsx|js|jsx|mts|cts|mjs|cjs)$/u;
+function isForwardExport(context, node) {
+    const tokens = context.sourceCode.getTokens(node);
+    if (tokens.at(0)?.value !== 'export')
+        return false;
+    return tokens.some((token, index) => token.value === 'from' && tokens.at(index + 1)?.type === 'String');
+}
+function isAllowedForwardExportFile(context) {
+    const filename = normalize(context.filename);
+    if (INDEX_BARREL_FILE.test(basename(filename)))
+        return true;
+    return readAllowedFiles(context.options.at(0)).some((file) => normalize(file) === filename);
+}
+function readAllowedFiles(value) {
+    if (!isRecord(value))
+        return [];
+    const { allowedFiles } = value;
+    if (!Array.isArray(allowedFiles))
+        return [];
+    return allowedFiles.filter((file) => typeof file === 'string');
+}
+function isRecord(value) {
+    return typeof value === 'object' && value !== null && !Array.isArray(value);
+}
+const noForwardExportsRule = {
+    meta: {
+        type: 'problem',
+        schema: [
+            {
+                type: 'object',
+                properties: {
+                    allowedFiles: { type: 'array', items: { type: 'string' } },
+                },
+                additionalProperties: false,
+            },
+        ],
+        messages: {
+            forwardExport: 'Forward exports are forbidden outside package entrypoints and index barrels. Import directly from the owning module.',
+        },
+    },
+    create(context) {
+        if (isAllowedForwardExportFile(context))
+            return {};
+        return {
+            'Program > *'(node) {
+                if (isForwardExport(context, node))
+                    context.report({ node, messageId: 'forwardExport' });
+            },
+        };
+    },
+};
+const moduleOwnershipPlugin = {
+    rules: { 'no-forward-exports': noForwardExportsRule },
+};
+export function createModuleOwnershipConfig(files, packageEntrypoints = []) {
+    return {
+        files,
+        plugins: { ankhorage: moduleOwnershipPlugin },
+        rules: {
+            'ankhorage/no-forward-exports': ['error', { allowedFiles: packageEntrypoints }],
+        },
+    };
+}

package/dist/tools/eslint/packageEntrypoints.d.ts

@@ -0,0 +1,2 @@
+import type { DevtoolsConfigOptions } from './types.js';
+export declare function resolvePackageEntrypointFiles(options: DevtoolsConfigOptions): string[];

package/dist/tools/eslint/packageEntrypoints.js

@@ -0,0 +1,47 @@
+import { readFileSync } from 'node:fs';
+import { dirname, resolve } from 'node:path';
+import { resolveProjectPackageJsonPath } from './packageJsonPath.js';
+const SOURCE_EXTENSIONS = ['ts', 'tsx', 'js', 'jsx', 'mts', 'cts', 'mjs', 'cjs'];
+const OUTPUT_EXTENSION = /(?:\.d)?\.(?:ts|tsx|js|jsx|mts|cts|mjs|cjs)$/u;
+export function resolvePackageEntrypointFiles(options) {
+    const packageJsonPath = resolveProjectPackageJsonPath(options);
+    if (packageJsonPath === null)
+        return [];
+    const packageJson = readPackageJson(packageJsonPath);
+    const targets = [
+        ...collectStringTargets(packageJson.main),
+        ...collectStringTargets(packageJson.types),
+        ...collectStringTargets(packageJson.exports),
+    ];
+    return [...new Set(targets.flatMap((target) => toSourceCandidates(target, packageJsonPath)))];
+}
+function readPackageJson(packageJsonPath) {
+    const parsed = JSON.parse(readFileSync(packageJsonPath, 'utf8'));
+    if (!isRecord(parsed)) {
+        throw new Error(`Expected package.json to contain a JSON object: ${packageJsonPath}`);
+    }
+    return parsed;
+}
+function collectStringTargets(value) {
+    if (typeof value === 'string')
+        return [value];
+    if (Array.isArray(value))
+        return value.flatMap(collectStringTargets);
+    if (!isRecord(value))
+        return [];
+    return Object.values(value).flatMap(collectStringTargets);
+}
+function toSourceCandidates(target, packageJsonPath) {
+    const normalizedTarget = target.replace(/^\.\//u, '');
+    const sourceTarget = normalizedTarget.startsWith('dist/')
+        ? `src/${normalizedTarget.slice('dist/'.length)}`
+        : normalizedTarget;
+    if (!sourceTarget.startsWith('src/'))
+        return [];
+    const sourceBase = sourceTarget.replace(OUTPUT_EXTENSION, '');
+    const absoluteBase = resolve(dirname(packageJsonPath), sourceBase);
+    return SOURCE_EXTENSIONS.map((extension) => `${absoluteBase}.${extension}`);
+}
+function isRecord(value) {
+    return typeof value === 'object' && value !== null && !Array.isArray(value);
+}

package/dist/tools/eslint/packageJsonPath.d.ts

@@ -0,0 +1,2 @@
+import type { DevtoolsConfigOptions } from './types.js';
+export declare function resolveProjectPackageJsonPath(options: DevtoolsConfigOptions): string | null;

package/dist/tools/eslint/packageJsonPath.js

@@ -0,0 +1,17 @@
+import { existsSync } from 'node:fs';
+import { dirname, resolve } from 'node:path';
+export function resolveProjectPackageJsonPath(options) {
+    if (options.packageJsonPath !== undefined) {
+        return resolve(options.tsconfigRootDir, options.packageJsonPath);
+    }
+    let directory = resolve(options.tsconfigRootDir);
+    for (;;) {
+        const candidate = resolve(directory, 'package.json');
+        if (existsSync(candidate))
+            return candidate;
+        const parent = dirname(directory);
+        if (parent === directory)
+            return null;
+        directory = parent;
+    }
+}

package/dist/tools/eslint/profile.js

@@ -1,42 +1,22 @@
-import { existsSync, readFileSync } from 'node:fs';
-import { dirname, resolve } from 'node:path';
+import { readFileSync } from 'node:fs';
 import { detectProject, } from '@ankhorage/utility/project';
+import { resolveProjectPackageJsonPath } from './packageJsonPath.js';
 export function resolveEslintProfile(options) {
     const requestedProfile = options.profile ?? 'auto';
-    if (requestedProfile !== 'auto') {
+    if (requestedProfile !== 'auto')
         return requestedProfile;
-    }
     const packageJsonPath = resolveProjectPackageJsonPath(options);
     const input = packageJsonPath === null ? {} : readDetectionInput(packageJsonPath);
     return resolveEslintProfileFromDetectionInput('auto', input);
 }
 export function resolveEslintProfileFromDetectionInput(requestedProfile, input) {
-    if (requestedProfile !== 'auto') {
+    if (requestedProfile !== 'auto')
         return requestedProfile;
-    }
     const { traits } = detectProject(input);
-    if (traits.has('react-native') || traits.has('expo')) {
+    if (traits.has('react-native') || traits.has('expo'))
         return 'react-native';
-    }
     return traits.has('react') ? 'react' : 'base';
 }
-function resolveProjectPackageJsonPath(options) {
-    if (options.packageJsonPath !== undefined) {
-        return resolve(options.tsconfigRootDir, options.packageJsonPath);
-    }
-    let directory = resolve(options.tsconfigRootDir);
-    for (;;) {
-        const candidate = resolve(directory, 'package.json');
-        if (existsSync(candidate)) {
-            return candidate;
-        }
-        const parent = dirname(directory);
-        if (parent === directory) {
-            return null;
-        }
-        directory = parent;
-    }
-}
 function readDetectionInput(packageJsonPath) {
     const parsed = JSON.parse(readFileSync(packageJsonPath, 'utf8'));
     if (!isRecord(parsed)) {
@@ -55,21 +35,18 @@ function optionalDependencyMap(key, value) {
     return dependencyMap === undefined ? {} : { [key]: dependencyMap };
 }
 function toDependencyMap(value) {
-    if (!isRecord(value)) {
+    if (!isRecord(value))
         return undefined;
-    }
     const dependencies = {};
     for (const [name, version] of Object.entries(value)) {
-        if (typeof version === 'string') {
+        if (typeof version === 'string')
             dependencies[name] = version;
-        }
     }
     return dependencies;
 }
 function optionalEngines(value) {
-    if (!isRecord(value)) {
+    if (!isRecord(value))
         return {};
-    }
     const engines = {
         ...(typeof value.bun === 'string' ? { bun: value.bun } : {}),
         ...(typeof value.node === 'string' ? { node: value.node } : {}),

package/dist/tools/eslint/types.d.ts

@@ -1,6 +1,5 @@
-import type tseslint from 'typescript-eslint';
-type FlatConfig = ReturnType<typeof tseslint.config>;
-export type FlatConfigItem = FlatConfig[number];
+import type { Linter } from 'eslint';
+export type FlatConfigItem = Linter.Config;
 export interface RestrictedImport {
     readonly name: string;
     readonly message: string;
@@ -19,4 +18,3 @@ export interface DevtoolsConfigOptions {
     readonly overrides?: FlatConfigItem[];
     readonly includePrettier?: boolean;
 }
-export {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ankhorage/devtools",
-  "version": "1.4.1",
+  "version": "1.5.1",
   "description": "Shared development tools and repository standards for Ankhorage",
   "license": "MIT",
   "homepage": "https://github.com/ankhorage/devtools#readme",