@animastor/orchestration 0.1.3 → 0.1.4

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@animastor/orchestration",
-    "version": "0.1.3",
+    "version": "0.1.4",
     "description": "Animastor Orchestration — the generation orchestration/runtime contour of the Animastor backend, physically extracted from the host (§32.30): the unified generation lifecycle owner (orchestrator facade, stage executor, scene callbacks/restoration), the dispatch engine and its lease/quota/retry managers, the reconciliation engine and counter reconciliation, the scene window/scheduler/worker-health, the runtime-result emitter/consumer, and the eight O-2..O-10 port contracts (Persistence, SceneData, PlaceholderAudio, ProgressEvents, AudioFsm, VideoFsm, HubCancel, LayerConfig). The package reaches the host (runtime config slices, Redis-domain state layer, media facades, the S-5 seam registry, the artifact root, the PW-2 workspace resolver) ONLY through the composition-root host-bindings seam — no backend/src require, no storage/book/routes/services, no Redis, no PG, no Express inside.",
     "keywords": [
         "animastor",

package/src/orchestration/scene-callbacks.js

@@ -278,7 +278,7 @@ async function handleImageCompleted(redis, bookId, chapterId, sceneId, buildId)
     log(`IMAGE_CALLBACK: ${bookId}/${chapterId}/${sceneId}`);
 
     const sceneImage = image.resolveCanonicalSceneImage(
-        '/data/output', buildId, bookId, chapterId, sceneId
+        artifactRoot(), buildId, bookId, chapterId, sceneId
     );
 
     // Per-asset check
@@ -390,7 +390,7 @@ async function handleVideoCompleted(redis, bookId, chapterId, sceneId, buildId)
     // T1: возвращает { ok, retryable, reason, artifact }
     log(`VIDEO_CALLBACK: ${bookId}/${chapterId}/${sceneId}`);
 
-    const videoPath = `/data/output/${buildId}/${bookId}_${chapterId}_${sceneId}.mp4`;
+    const videoPath = `${artifactRoot()}/${buildId}/${bookId}_${chapterId}_${sceneId}.mp4`;
     const { valid, duration, metadata } = video.validateVideoFile(videoPath);
 
     const assetStates = await state.getAssetStates(redis, bookId, chapterId, sceneId);

package/src/runtime/reconciliation-engine.js

@@ -15,9 +15,12 @@ const fs = require('fs').promises;
 const syncFs = require('fs');
 const syncPath = require('path');
 
-const { lazyHostBinding } = require('../host/host-bindings');
+const { lazyHostBinding, hostBinding } = require('../host/host-bindings');
 // §32.30: former host requires resolve lazily through the host-bindings seam.
 const state = lazyHostBinding('state');
+// §32.30: the artifact root resolves through the composition-root seam at
+// call time (Stage 96: former hardcoded artifact root closed here).
+const artifactRoot = () => hostBinding('artifactRoot');
 // S-4: filename grammar composed from the canonical owner (bytes unchanged)
 const artifactNaming = require('@animastor/generation').artifactNaming;
 // S-2: registered stage list resolved from media registry
@@ -121,7 +124,7 @@ async function checkOrphanVideoState(redis, bookId, chapterId, sceneId) {
     }
 
     const buildId = resolveBookBuildId(bookId);
-    const videoPath = `/data/output/${buildId}/${bookId}_${chapterId}_${sceneId}.mp4`;
+    const videoPath = `${artifactRoot()}/${buildId}/${bookId}_${chapterId}_${sceneId}.mp4`;
 
     try {
         await fs.access(videoPath);
@@ -155,7 +158,7 @@ async function checkOrphanImageState(redis, bookId, chapterId, sceneId) {
     const buildId = resolveBookBuildId(bookId);
     const imageModule = lazyHostBinding('media.image');
     const imageInfo = imageModule.resolveCanonicalSceneImage(
-        '/data/output',
+        artifactRoot(),
         buildId,
         bookId,
         chapterId,

package/test/artifact-root-binding.test.js

@@ -0,0 +1,174 @@
+// ======================================================
+// STAGE 96 — ARTIFACT ROOT BINDING (поведение закрытых литералов)
+// ======================================================
+// Четыре production-литерала '/data/output' в orchestration-пакете
+// (scene-callbacks.js:281,393 · reconciliation-engine.js:124,158)
+// переведены на существующий шов artifactRoot (host-bindings, §32.30).
+//
+// Тесты проверяют ПОВЕДЕНИЕ на свежих исходниках пакета (src/, а не
+// npm-копия в backend/node_modules):
+//   — путь строится из привязанного корня, а не из литерала;
+//   — при корне '/data/output' (контракт сохранённых данных PG/Redis)
+//     результирующая строка байт-в-байт равна прежней.
+// ======================================================
+
+const { expect } = require('chai');
+const fs = require('fs');
+const os = require('os');
+const path = require('path');
+const { bindHostModules } = require('../src/host/host-bindings');
+const { createMockRedis } = require('./mocks/redis-mock');
+
+const engine = require('../src/runtime/reconciliation-engine');
+const callbacks = require('../src/orchestration/scene-callbacks');
+
+const BOOK = 'b1';
+const CHAPTER = 'ch1';
+const SCENE = 'sc1';
+
+let tmpRoot;
+let redis;
+let currentStates;
+
+const imageStub = {
+    resolveCanonicalSceneImage: () => null,
+    getImageMetadata: async () => null,
+};
+const videoStub = {
+    validateVideoFile: () => ({ valid: false, duration: null, metadata: null }),
+};
+
+const stateStub = {
+    AssetState: {
+        NEW: 'new', DIRTY: 'dirty', PENDING: 'pending',
+        GENERATING: 'generating', READY: 'ready',
+        FAILED: 'failed', PLACEHOLDER: 'placeholder',
+    },
+    getAssetStates: async () => ({ audio: 'new', ...currentStates }),
+};
+
+const failFast = (name) => () => {
+    throw new Error(`[ARTIFACT-ROOT-TEST] ${name} not wired`);
+};
+
+function wire(artifactRootValue) {
+    bindHostModules({
+        state: () => stateStub,
+        media: () => ({ audio: {}, image: imageStub, video: videoStub }),
+        journal: () => ({ appendSceneEvent: async () => {} }),
+        artifactRoot: () => artifactRootValue,
+    });
+}
+
+describe('Stage 96 — artifactRoot-шов вместо литералов', () => {
+    before(() => {
+        tmpRoot = fs.mkdtempSync(path.join(os.tmpdir(), 'stage96-artifact-root-'));
+        fs.mkdirSync(path.join(tmpRoot, 'default'), { recursive: true });
+        redis = createMockRedis();
+        wire(tmpRoot);
+    });
+
+    after(() => {
+        // Вернуть дефолтный fail-fast, как в test/test-bindings.js
+        bindHostModules({
+            state: failFast('state'),
+            media: failFast('media'),
+            journal: failFast('journal'),
+            artifactRoot: failFast('artifactRoot'),
+        });
+        fs.rmSync(tmpRoot, { recursive: true, force: true });
+    });
+
+    describe('reconciliation-engine — checkOrphanVideoState', () => {
+        it('missingFile строится из привязанного корня, а не из литерала', async () => {
+            currentStates = { video: 'ready' };
+            const res = await engine.checkOrphanVideoState(redis, BOOK, CHAPTER, SCENE);
+            expect(res).to.be.an('object');
+            expect(res.missingFile).to.equal(`${tmpRoot}/default/${BOOK}_${CHAPTER}_${SCENE}.mp4`);
+        });
+
+        it('null, когда файл существует ПОД ПРИВЯЗАННЫМ корнем', async () => {
+            const file = path.join(tmpRoot, 'default', `${BOOK}_${CHAPTER}_${SCENE}.mp4`);
+            fs.writeFileSync(file, 'x');
+            try {
+                currentStates = { video: 'ready' };
+                expect(await engine.checkOrphanVideoState(redis, BOOK, CHAPTER, SCENE)).to.be.null;
+            } finally {
+                fs.rmSync(file, { force: true });
+            }
+        });
+    });
+
+    describe('reconciliation-engine — checkOrphanImageState', () => {
+        it('resolveCanonicalSceneImage получает привязанный корень', async () => {
+            let seenRoot = null;
+            imageStub.resolveCanonicalSceneImage = (root) => { seenRoot = root; return null; };
+            try {
+                currentStates = { image: 'ready' };
+                const res = await engine.checkOrphanImageState(redis, BOOK, CHAPTER, SCENE);
+                expect(seenRoot).to.equal(tmpRoot);
+                expect(res).to.be.an('object');
+                expect(res.type).to.equal('orphan_image_state');
+            } finally {
+                imageStub.resolveCanonicalSceneImage = () => null;
+            }
+        });
+    });
+
+    describe('scene-callbacks — handleVideoCompleted', () => {
+        it('validateVideoFile получает путь под привязанным корнем', async () => {
+            let seenPath = null;
+            videoStub.validateVideoFile = (p) => {
+                seenPath = p;
+                return { valid: false, duration: null, metadata: null };
+            };
+            try {
+                currentStates = { video: 'generating' };
+                const res = await callbacks.handleVideoCompleted(redis, BOOK, CHAPTER, SCENE, 'build1');
+                expect(seenPath).to.equal(`${tmpRoot}/build1/${BOOK}_${CHAPTER}_${SCENE}.mp4`);
+                expect(res).to.deep.include({ ok: false, retryable: true, reason: 'video_invalid' });
+            } finally {
+                videoStub.validateVideoFile = () => ({ valid: false, duration: null, metadata: null });
+            }
+        });
+    });
+
+    describe('scene-callbacks — handleImageCompleted', () => {
+        it('resolveCanonicalSceneImage получает привязанный корень', async () => {
+            let seenRoot = null;
+            imageStub.resolveCanonicalSceneImage = (root) => { seenRoot = root; return null; };
+            try {
+                currentStates = { image: 'generating' };
+                const res = await callbacks.handleImageCompleted(redis, BOOK, CHAPTER, SCENE, 'build1');
+                expect(seenRoot).to.equal(tmpRoot);
+                expect(res).to.deep.include({ ok: false, retryable: true, reason: 'image_not_found' });
+            } finally {
+                imageStub.resolveCanonicalSceneImage = () => null;
+            }
+        });
+    });
+
+    describe('обратная совместимость (контракт контейнерных путей)', () => {
+        it('при корне /data/output строка байт-в-байт равна прежнему литералу', async () => {
+            wire('/data/output');
+            try {
+                let seenPath = null;
+                videoStub.validateVideoFile = (p) => {
+                    seenPath = p;
+                    return { valid: false, duration: null, metadata: null };
+                };
+                currentStates = { video: 'generating' };
+                await callbacks.handleVideoCompleted(redis, BOOK, CHAPTER, SCENE, 'build1');
+                // ровно то, что до Stage 96 формировал шаблон
+                expect(seenPath).to.equal(`/data/output/build1/${BOOK}_${CHAPTER}_${SCENE}.mp4`);
+
+                currentStates = { video: 'ready' };
+                const orphan = await engine.checkOrphanVideoState(redis, BOOK, CHAPTER, SCENE);
+                expect(orphan.missingFile).to.equal(`/data/output/default/${BOOK}_${CHAPTER}_${SCENE}.mp4`);
+            } finally {
+                videoStub.validateVideoFile = () => ({ valid: false, duration: null, metadata: null });
+                wire(tmpRoot);
+            }
+        });
+    });
+});