@animalabs/agent-framework 0.27.0 → 0.29.0

package/dist/src/mcpl/channel-registry.js

@@ -12,7 +12,9 @@
  * - Expose synthesized tools: channel_list, channel_open, channel_close, channel_publish
  * - Build channel context for beforeInference params
  */
-import { convertBlock } from './convert-block.js';
+import { NOTICE_TAG } from '../notice-tags.js';
+import { convertBlocks } from './convert-block.js';
+import { cutToFit, markedText, markNoticeOpenings, nameToTypeBack, quotedValue, showsAsItself, suppliedValue } from '../supplied-text.js';
 import { isDeepStrictEqual } from 'node:util';
 import { ensureStateRegistered } from '../module-registry.js';
 import { expandCoreTags, isMarkerTagged } from './tags.js';
@@ -22,7 +24,7 @@ import { logDetail, logValue } from './log-value.js';
 import { RefusalLines } from './refusal-lines.js';
 import { CapabilityGrant } from './capability-grant.js';
 import { McplRequestError } from './server-connection.js';
-import { readSkipReplyWake } from './skip-reply-wake.js';
+import { readSkipReplyWake, skipReplyNote } from './skip-reply-wake.js';
 import { isProseTargetToken } from './prose-grammar.js';
 // ============================================================================
 // Typing indicator interval (Discord typing lasts ~10s, so 7s keeps it alive)
@@ -410,20 +412,22 @@ const CHANNEL_TOOL_DEFINITIONS = [
 // ============================================================================
 // Constructor Options
 // ============================================================================
-/** Bound connector values for notices, logs and an outcome's reason. A
- *  PublishOutcome keeps the connector's structured data (`detail`) as the
- *  connection gives it, its strings redacted (redactedData). */
+/** Bound connector values for notices, logs and an outcome's reason, on one
+ *  line with their notice openings marked (suppliedValue). A PublishOutcome
+ *  keeps the connector's structured data (`detail`) as the connection gives
+ *  it, its strings redacted (redactedData). */
 export function connectorText(value) {
     let text;
     try {
         text = typeof value === 'string' ? value : JSON.stringify(value) ?? String(value);
     }
     catch {
-        return '[unserializable connector value]';
+        return `[${NOTICE_TAG.unserializableConnectorValue}]`;
     }
     const limit = 2000;
-    const suffix = '… [truncated]';
-    return text.length > limit ? text.slice(0, limit - suffix.length) + suffix : text;
+    const suffix = `… [${NOTICE_TAG.truncated}]`;
+    const shown = suppliedValue(text);
+    return shown.length > limit ? cutToFit(shown, limit - suffix.length) + suffix : shown;
 }
 /** One key per channel, its server and id: unlike joining the two with a
  *  separator, no two channels share one, whatever their ids hold. */
@@ -437,6 +441,8 @@ export function sameChannel(a, b) {
         return !a && !b;
     return a.serverId === b.serverId && a.channelId === b.channelId;
 }
+export const NO_CHANNEL_EXAMPLE = '#<channel>';
+export const NO_PERSON_EXAMPLE = '@<person>';
 /**
  * A channel's server-qualified name, `serverId:channelId`. A name given as a
  * string (a tool's channelId, a `>>` target, a host's call) may take this
@@ -447,11 +453,32 @@ export function sameChannel(a, b) {
 export function qualifiedChannelName(ref) {
     return `${ref.serverId}:${ref.channelId}`;
 }
+function markedHistory(history) {
+    return history.map((item) => {
+        if (item === null || typeof item !== 'object' || Array.isArray(item) || !('content' in item))
+            return item;
+        const { content } = item;
+        if (Array.isArray(content))
+            return { ...item, content: markNoticeOpenings(content.map(withEmbeddedTextMarked)) };
+        return typeof content === 'string' ? { ...item, content: markedText(content) } : item;
+    });
+}
+function withEmbeddedTextMarked(block) {
+    if (block === null || typeof block !== 'object' || block.type !== 'resource')
+        return block;
+    const { resource } = block;
+    if (resource === null || typeof resource !== 'object' || typeof resource.text !== 'string')
+        return block;
+    return { ...block, resource: { ...resource, text: markedText(resource.text) } };
+}
 /** A channel told apart by its id and its server, for one no string picks
- *  alone: `"b:room" on server "a"`. No input takes it for a name. */
+ *  alone or whose name wouldn't show as itself: `"b:room" on server "a"`,
+ *  each a JSON literal a channel tool's channelId and serverId take back
+ *  (quotedValue). No input takes the whole form for a name. */
 function channelOnServer(ref) {
-    return `${JSON.stringify(ref.channelId)} on server ${JSON.stringify(ref.serverId)}`;
+    return `${quotedValue(ref.channelId)} on server ${quotedValue(ref.serverId)}`;
 }
+const CHANNEL_ON_SERVER_AT_END = /("(?:[^"\\]|\\.)*") on server ("(?:[^"\\]|\\.)*")$/;
 /**
  * A failed request's words, bounded, for a reason that a caller composes.
  * This host's own words, for a request that wasn't sent or wasn't answered
@@ -1328,7 +1355,7 @@ export class ChannelRegistry {
             }
             if (message.tags)
                 message.tags = expandCoreTags(message.tags);
-            const convertedContent = message.content.map((block) => convertBlock(block, 'attachment on channel message', serverId));
+            const convertedContent = convertBlocks(message.content, 'attachment on channel message', serverId);
             if (!emptyAllowed && isVisiblyEmptyConversion(message.content, convertedContent)) {
                 rejectEmpty();
                 continue;
@@ -1342,7 +1369,8 @@ export class ChannelRegistry {
             const incomingEntry = this.channels.get(incomingKey);
             const markAccepted = (firstView = false) => {
                 // Non-conversational markers (a reaction added or removed, an edit, a
-                // deletion) are ABOUT a message, not one the agent replies to: they
+                // deletion, and a chat:system notice such as a join or the weather)
+                // are ABOUT a message or the place, not one the agent replies to: they
                 // must not retarget the default publish locus or become
                 // `context.incoming`'s reply anchor. An edit the coalescer delivered
                 // as the agent's first view counts as the message it replaced.
@@ -1763,7 +1791,7 @@ export class ChannelRegistry {
             case 'journal':
                 return this.handleToolJournal(input);
             case 'skip_reply':
-                return this.handleToolSkipReply(input);
+                return this.handleToolSkipReply(input, origin?.kind === 'agent' ? origin.earlierWake : undefined);
             default:
                 // Not every agent is given every channel tool, so the refusal points
                 // to the ones this agent has rather than listing them all.
@@ -1816,7 +1844,8 @@ export class ChannelRegistry {
         // declared it inbound-only, since speech isn't posted there): a conversation
         // fork's home channel, else this turn's channel (single trunk agent — item-3
         // redux: its locus, else its triggering channel), else the global default
-        // (heartbeats). Without this, a fork
+        // (a no-trigger turn's, but not a heartbeat's, whose turn takes none).
+        // Without this, a fork
         // was advertised the global locus but published somewhere else; and a trunk
         // agent was told the wrong channel under concurrency.
         // Each lookup is keyed on whether a name was given, not its truthiness:
@@ -3214,13 +3243,20 @@ export class ChannelRegistry {
      * name, only where no registered channel takes that name, as a channel
      * tool reads it or a `>>` target does (by label or raw id too), so the
      * name can't send anything to another channel; else by its id and server.
+     * A name that wouldn't show as itself (showsAsItself: one holding a line
+     * break, a notice opening, a quote, a backslash or a lone surrogate, or
+     * whitespace at its edges) is shown by its id and its server too, which
+     * the channel tools take exactly and the prose resolver doesn't, so no name
+     * shown can be another channel's.
      */
     nameShown(ref) {
         const entry = this.entryAt(ref);
-        if (entry)
-            return this.nameFor(entry) ?? channelOnServer(ref);
+        if (entry) {
+            const name = this.nameFor(entry);
+            return name !== undefined && showsAsItself(name) ? name : channelOnServer(ref);
+        }
         for (const name of [ref.channelId, qualifiedChannelName(ref)]) {
-            if (this.entriesNamed(name).length === 0 && !('channelId' in this.resolveProseTarget(name)))
+            if (showsAsItself(name) && this.entriesNamed(name).length === 0 && !('channelId' in this.resolveProseTarget(name)))
                 return name;
         }
         return channelOnServer(ref);
@@ -3257,7 +3293,7 @@ export class ChannelRegistry {
     tuneOutEndText(entry, tool) {
         const close = tool === 'channel_close';
         return this.nameFor(entry) !== undefined
-            ? `Call tune_out with channelId ${this.quotedShown(refOf(entry))} and mode "cancel" for it to resume normal ` +
+            ? `Call tune_out with channelId ${quotedValue(this.nameFor(entry))} and mode "cancel" for it to resume normal ` +
                 `attention; cancelling delivers the diverted backlog${close ? ', and channel_close closes it after that.' : '.'}`
             : 'No channelId names it alone, so tune_out can\'t cancel it: its tune-out ends by itself when its duration ' +
                 'runs out, or at the first wake past its wake budget, and its backlog is delivered then.' +
@@ -3269,7 +3305,7 @@ export class ChannelRegistry {
      */
     quotedShown(ref) {
         const shown = this.nameShown(ref);
-        return shown === channelOnServer(ref) ? shown : JSON.stringify(shown);
+        return shown === channelOnServer(ref) ? shown : quotedValue(shown);
     }
     /**
      * The string that names exactly this entry by entriesNamed: its id when no
@@ -3302,7 +3338,7 @@ export class ChannelRegistry {
         const nothing = opts.nothing ?? 'nothing ran';
         const names = entries.map((e) => this.nameFor(e));
         if (names.every((n) => n !== undefined)) {
-            const listed = names.map((n) => JSON.stringify(n)).join(', ');
+            const listed = names.map((n) => quotedValue(n)).join(', ');
             const servers = [...new Set(entries.map((e) => JSON.stringify(e.serverId)))];
             // One server's two channels can answer to one name too, as `s`'s
             // `s:room` and `room` both do to `s:room`; its server picks neither.
@@ -3324,8 +3360,8 @@ export class ChannelRegistry {
             if (own === undefined && !opts.takesServerId)
                 return `- ${where}: no channelId reaches it alone.`;
             return own !== undefined
-                ? `- ${where}: call again with channelId ${JSON.stringify(own)}.`
-                : `- ${where}: call again with channelId ${JSON.stringify(e.descriptor.id)} and serverId ${JSON.stringify(e.serverId)}.`;
+                ? `- ${where}: call again with channelId ${quotedValue(own)}.`
+                : `- ${where}: call again with channelId ${quotedValue(e.descriptor.id)} and serverId ${JSON.stringify(e.serverId)}.`;
         });
         const count = entries.length === 2 ? 'either of two channels' : `any of ${entries.length} channels`;
         return `Channel ${JSON.stringify(name)} could mean ${count}, so ${nothing}:\n${lines.join('\n')}`;
@@ -3363,7 +3399,7 @@ export class ChannelRegistry {
             if (!alone)
                 return 'channel_list shows the channels and their servers.';
             const one = named[0];
-            const names = `${JSON.stringify(channelId)} alone names channel ${JSON.stringify(one.descriptor.id)} on server `
+            const names = `${JSON.stringify(channelId)} alone names channel ${quotedValue(one.descriptor.id)} on server `
                 + JSON.stringify(one.serverId);
             return takesServerId ? `${names}: for that one, call again with serverId left out.` : `${names}.`;
         }
@@ -3375,7 +3411,7 @@ export class ChannelRegistry {
             const places = elsewhere.map((e) => {
                 const at = `on server ${JSON.stringify(e.serverId)}`;
                 const name = this.nameFor(e);
-                return name === undefined ? `${at} (no channelId reaches it alone)` : `${at} as ${JSON.stringify(name)}`;
+                return name === undefined ? `${at} (no channelId reaches it alone)` : `${at} as ${quotedValue(name)}`;
             });
             return `It's ${places.length === 1 ? places[0] : `${places.slice(0, -1).join(', ')} and ${places.at(-1)}`}.`;
         }
@@ -3638,19 +3674,22 @@ export class ChannelRegistry {
      * before any other spelling (ownChannelNamed).
      */
     resolveProseTarget(spec, opts) {
-        const own = this.ownChannelNamed(spec.trim(), opts?.own);
+        const name = spec.trim();
+        if (name === NO_CHANNEL_EXAMPLE || name === NO_PERSON_EXAMPLE)
+            return { error: `${name} is the example's placeholder: write the name it stands for in its place` };
+        const own = this.ownChannelNamed(name, opts?.own);
         let resolved;
         if (own === undefined) {
-            resolved = this.resolveTargetByName(spec);
+            resolved = this.resolveTargetByName(name);
         }
         else if ('neither' in own) {
-            resolved = { error: `"${spec.trim()}" is the id of this turn's channels on more than one server`, candidates: this.ownCandidates(own.neither).map((c) => c.text) };
+            resolved = { error: `"${name}" is the id of this turn's channels on more than one server`, candidates: this.ownCandidates(own.neither).map((c) => c.prose) };
         }
         else {
             const entry = this.entryAt(own.channel);
             resolved = entry
                 ? { channelId: entry.descriptor.id, serverId: entry.serverId, label: entry.descriptor.label }
-                : { error: `${this.ownChannelGoneText(spec.trim(), own.channel)}, and nothing can be sent there until that server registers it again` };
+                : { error: `${this.ownChannelGoneText(name, own.channel)}, and nothing can be sent there until that server registers it again` };
         }
         if (!opts?.forSpeech || 'error' in resolved)
             return resolved;
@@ -3703,7 +3742,7 @@ export class ChannelRegistry {
             return undefined;
         if ('neither' in mine) {
             const done = tool === 'publish' ? 'was posted' : tool === 'deliver' ? 'was delivered' : 'ran';
-            return { error: this.ownNeitherRefusal(name, mine.neither, done) };
+            return { error: this.ownNeitherRefusal(name, mine.neither, done, false) };
         }
         return this.entryAt(mine.channel) ? { channel: mine.channel } : { error: this.ownChannelGoneRefusal(name, mine.channel, tool) };
     }
@@ -3720,32 +3759,73 @@ export class ChannelRegistry {
     /**
      * The turn's channels a name means neither of (ownChannelNamed), each by a
      * string that reaches it outside the turn's rule: its server-qualified
-     * name, where that picks it alone, since its id is the name refused. One
-     * no string picks alone, and one its server no longer registers, is named
-     * by its id and server, saying so; `reaches` says which a name reaches.
+     * name, where that picks it alone, since its id is the name refused. `text`
+     * is that name, which a refusal writes as JSON; `prose`, which a `>>`
+     * target reads, is that name where it shows as itself, else its id and
+     * server. One no string picks alone, and one its server no longer
+     * registers, are named by id and server in both, saying so. `reaches` says
+     * which a name reaches.
      */
     ownCandidates(channels) {
         return channels.map((c) => {
             const entry = this.entryAt(c);
-            if (!entry)
-                return { text: `${channelOnServer(c)} (its server no longer registers it)`, reaches: false };
+            if (!entry) {
+                const text = `${channelOnServer(c)} (its server no longer registers it)`;
+                return { text, prose: text, reaches: false, byServer: false };
+            }
             const qualified = qualifiedChannelName(c);
             const picked = this.entriesNamed(qualified);
-            return picked.length === 1 && picked[0] === entry
-                ? { text: qualified, reaches: true }
-                : { text: `${channelOnServer(c)} (no channelId reaches it alone)`, reaches: false };
+            if (picked.length !== 1 || picked[0] !== entry) {
+                const text = `${channelOnServer(c)} (no channelId reaches it alone)`;
+                return { text, prose: text, reaches: false, byServer: true };
+            }
+            return { text: qualified, prose: showsAsItself(qualified) ? qualified : channelOnServer(c), reaches: true, byServer: false };
         });
     }
+    /**
+     * What a refusal listing these candidates says of each one that is a
+     * channel shown by its id and server: the channelId channel_publish reaches
+     * it by, or that no channelId reaches it alone. That is its server-qualified
+     * name where that picks it alone, since a bare id is what a turn's own
+     * channels answer to first, whether or not their server still registers
+     * them (ownChannelNamed), and else its id where that picks it alone and
+     * isn't empty (channel_publish refuses an empty one). It leaves out a channel no
+     * longer registered and a candidate that already says no channelId reaches
+     * it alone, and is empty when nothing is left.
+     */
+    publishRouteFor(candidates) {
+        const parts = new Set();
+        for (const candidate of candidates) {
+            const shown = CHANNEL_ON_SERVER_AT_END.exec(candidate);
+            if (!shown)
+                continue;
+            const ref = { channelId: JSON.parse(shown[1]), serverId: JSON.parse(shown[2]) };
+            const entry = this.entryAt(ref);
+            if (!entry)
+                continue;
+            const name = [qualifiedChannelName(ref), ref.channelId].find((n) => {
+                const named = n === '' ? [] : this.entriesNamed(n);
+                return named.length === 1 && named[0] === entry;
+            });
+            parts.add(name !== undefined
+                ? `channel_publish reaches ${channelOnServer(ref)} with channelId ${quotedValue(name)}`
+                : `no channelId reaches ${channelOnServer(ref)} alone`);
+        }
+        return parts.size ? ` For a channel shown by its id and server: ${[...parts].join('; ')}.` : '';
+    }
     /** A tool's refusal of a name the turn's channels on more than one server
      *  answer to by their id (ownChannelNamed's neither). */
-    ownNeitherRefusal(name, channels, done) {
+    ownNeitherRefusal(name, channels, done, takesServer = true) {
         const candidates = this.ownCandidates(channels);
-        const named = candidates.filter((c) => c.reaches).map((c) => JSON.stringify(c.text));
+        const named = candidates.filter((c) => c.reaches).map((c) => quotedValue(c.text));
         const pick = named.length === candidates.length ? ' Call again with channelId set to one of them.'
             : named.length === 1 ? ` Call again with channelId ${named[0]}.`
                 : named.length > 1 ? ` Call again with channelId set to one of ${named.join(', ')}.` : '';
-        const listed = candidates.map((c) => (c.reaches ? JSON.stringify(c.text) : c.text)).join(', ');
-        return `"${name}" is the id of this turn's channels on more than one server (${listed}), so nothing ${done}.${pick}`;
+        const listed = candidates.map((c) => (c.reaches ? quotedValue(c.text) : c.text)).join(', ');
+        const byServer = takesServer && candidates.some((c) => c.byServer)
+            ? ' For a channel shown by its id and server, call again with that channelId and that serverId.'
+            : '';
+        return `"${name}" is the id of this turn's channels on more than one server (${listed}), so nothing ${done}.${pick}${byServer}`;
     }
     resolveTargetByName(spec) {
         const entries = [...this.channels.values()];
@@ -3756,7 +3836,7 @@ export class ChannelRegistry {
         // A candidate is named by the token that picks it alone (nameFor), so
         // two servers' channels with one id or one label can be told apart, or,
         // where no string picks it alone, by its id and its server.
-        const token = (e) => this.nameFor(e) ?? channelOnServer(refOf(e));
+        const token = (e) => this.nameShown(refOf(e));
         // A DM is shown by its label, the person, where that label, given as a
         // target, picks that DM. It doesn't where another channel answers to that
         // label too, as two servers' DMs with one person do (a label is matched
@@ -3773,7 +3853,7 @@ export class ChannelRegistry {
         };
         const dmShown = (list) => list.map((e) => {
             const label = e.descriptor.label ?? e.descriptor.id;
-            return labelPicks(e, label) ? label : token(e);
+            return showsAsItself(label) && labelPicks(e, label) ? label : token(e);
         });
         // A channel id, or its server-qualified name (entriesNamed).
         const exact = this.entriesNamed(trimmed);
@@ -3878,7 +3958,7 @@ export class ChannelRegistry {
         if (byName.length > 1) {
             return {
                 error: `"${trimmed}" matches several channels`,
-                candidates: byName.map((e) => `${e.descriptor.label} = ${token(e)}`),
+                candidates: byName.map((e) => `${nameToTypeBack(e.descriptor.label ?? '')} = ${token(e)}`),
             };
         }
         // No match: offer near-candidates (labels containing the name) so the
@@ -3886,7 +3966,7 @@ export class ChannelRegistry {
         const near = entries
             .filter((e) => norm(e.descriptor.label ?? '').includes(norm(trimmed)))
             .slice(0, 5)
-            .map((e) => `${e.descriptor.label} = ${token(e)}`);
+            .map((e) => `${nameToTypeBack(e.descriptor.label ?? '')} = ${token(e)}`);
         return { error: `no channel matches "${trimmed}"`, ...(near.length ? { candidates: near } : {}) };
     }
     /**
@@ -3923,7 +4003,7 @@ export class ChannelRegistry {
             qualifiedChannelName(ref),
         ];
         for (const c of candidates) {
-            if (!isProseTargetToken(c) || c === '#')
+            if (!isProseTargetToken(c) || c === '#' || !showsAsItself(c))
                 continue;
             const r = this.resolveProseTarget(c, { forSpeech: true });
             if ('channelId' in r && sameChannel(r, ref))
@@ -4191,7 +4271,7 @@ export class ChannelRegistry {
                     channelId: input.channelId,
                     serverId: entry.serverId,
                     status: alreadyDesiredOpen ? 'reconciled' : 'opened',
-                    ...(result.history ? { history: result.history } : {}),
+                    ...(result.history ? { history: markedHistory(result.history) } : {}),
                     ...(result.historyTruncated ? { historyTruncated: true } : {}),
                 },
             };
@@ -4648,13 +4728,14 @@ export class ChannelRegistry {
      * tool, so any trailing prose this turn is NOT posted. Replaces the old
      * overloaded use of `think` for staying silent.
      */
-    handleToolSkipReply(input) {
+    handleToolSkipReply(input, earlierWake) {
         // The self-wake itself is armed by the framework (which owns the
         // EventGate) BEFORE its dispatch reaches this handler, from the same
         // reading, and the framework refuses a wake the host can't set before
         // dispatching. A caller of this registry's handleChannelToolCall
         // (AgentFramework.channels) goes past both, so its note names a wake
-        // nothing armed.
+        // nothing armed. The framework, which also owns the heartbeat, says
+        // which of its wakes is due before the self-wake (`earlierWake`).
         const wake = readSkipReplyWake(input);
         const selfWake = wake.kind === 'wake' ? wake.seconds : undefined;
         return {
@@ -4670,9 +4751,7 @@ export class ChannelRegistry {
             // on Fable: ~60% of skip_reply result bytes were verbatim input echo).
             data: {
                 skipped: true,
-                note: selfWake !== undefined
-                    ? `Turn ended; nothing sent. Self-wake in ~${selfWake}s unless something wakes you first.`
-                    : 'Turn ended; nothing sent.',
+                note: skipReplyNote(selfWake, selfWake !== undefined ? earlierWake : undefined),
             },
         };
     }
@@ -5227,7 +5306,7 @@ export class ChannelRegistry {
         else if (own && 'neither' in own) {
             if (seen)
                 seen.refusal = 'shared-id';
-            return { success: false, error: this.ownNeitherRefusal(input.channelId, own.neither, 'was posted'), isError: true };
+            return { success: false, error: this.ownNeitherRefusal(input.channelId, own.neither, 'was posted', false), isError: true };
         }
         else if (own) {
             entry = this.entryAt(own.channel);
@@ -5264,7 +5343,7 @@ export class ChannelRegistry {
                 // channel with its id isn't where its message came from.
                 error: input.channelId === undefined
                     ? serverGiven
-                        ? `Server "${input.serverId}" has no channel "${fallback.channelId}", the id of the channel this call would default to, so nothing was posted.`
+                        ? `Server "${input.serverId}" has no channel ${quotedValue(fallback.channelId)}, the id of the channel this call would default to, so nothing was posted.`
                         : `The channel this would default to, ${this.quotedShown(fallback)}, isn't registered now, so nothing was posted.`
                     // This tool's schema has no serverId, so one given here is a host's
                     // ref (publishForAgent), or one an agent added unasked, and the