@anguless/angulux 22.2.3 → 22.3.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/README.md CHANGED
@@ -43,8 +43,8 @@ its own. It works in any project; it does not require angulux.
43
43
  angulux is **not** a drop-in replacement for PrimeNG, and it is **not** trying to be the
44
44
  community's continuation of it. Three facts decide whether you should keep reading:
45
45
 
46
- 1. **It ships 64 of PrimeNG's 117 modules.** Editor, Tree, OrganizationChart, PickList,
47
- OrderList, Listbox and 47 others are not ported — all 53 are listed in
46
+ 1. **It ships 65 of PrimeNG's 117 modules.** Editor, Tree, OrganizationChart, PickList,
47
+ OrderList and Listbox are among those not ported — all 52 are listed in
48
48
  [`packages/angulux/attic/`](packages/angulux/attic/). See
49
49
  [What angulux is NOT](#what-angulux-is-not).
50
50
  2. **Selectors were renamed.** `p-button` is `agl-button`, `pTooltip` is `aglTooltip`.
@@ -70,13 +70,13 @@ The interesting part is not the fork. It is that the boundary is enforced by mac
70
70
 
71
71
  ### 1. Every release is machine-proven MIT
72
72
 
73
- Seventeen gates run on every commit and every pull request. They do not check style — each one
73
+ Eighteen gates run on every commit and every pull request. They do not check style — each one
74
74
  closes a class of failure that has already happened in this repository.
75
75
 
76
76
  | Gate | What it refuses to let through |
77
77
  |---|---|
78
78
  | `check:catalog` | a dependency version drifting off the pinned catalog |
79
- | `check:scope` | the transitive closure drifting off the 64 warranted modules |
79
+ | `check:scope` | the transitive closure drifting off the 65 warranted modules |
80
80
  | `check:license` | any PrimeTek package from a post-MIT release entering the tree — and, separately, any licence-flagged material sitting in `ref/` that `PROVENANCE.md` does not declare |
81
81
  | `check:names` | PrimeNG names surviving in selector, API or **trademark** positions — including inside bare strings, JSDoc links and DOM attributes |
82
82
  | `check:risk-coverage` | the browser gate's scope drifting off the risky decorators computed from source |
@@ -91,10 +91,11 @@ closes a class of failure that has already happened in this repository.
91
91
  | `check:demo-code` | the documentation site claiming something the library does not do — a demo whose shown code stopped matching the demo that ran, a page entry pointing at a different file than it names, or a module documented on the public web that no release contains |
92
92
  | `check:peer-licence` | angulux's own manifest telling a **consumer's** package manager to install a commercially-licensed PrimeTek package — `check:license` proves the tree installed *here* is clean, which is a different question from what the published version ranges admit |
93
93
  | `check:install-scripts` | a dependency running arbitrary code during `pnpm install` without anyone deciding it should — the release job installs while holding `id-token: write`, so one compromised transitive package could mint an npm credential and publish as this project with a valid attestation |
94
+ | `check:module-counts` | the project's central claim — "65 of PrimeNG's 117 modules" — going stale in the fifty-odd places it is written down, including the MCP tool descriptions that leave the repository; the three counts are re-derived from the closure and the attic directory, and the attic cost table is compared as a **set**, so a promoted module cannot linger in it while every number on the page stays right |
94
95
  | `check:gate-count` | this list going stale — the count and the gate names are re-derived from `package.json` and checked against every place they are written down |
95
96
 
96
97
  ```bash
97
- npm run check # all seventeen, no build needed
98
+ npm run check # all eighteen, no build needed
98
99
  ```
99
100
 
100
101
  Two further checks run after the build rather than inside that suite, because neither has
@@ -136,12 +137,19 @@ markup a spec sets up — and measures whether what the library draws survives i
136
137
  CSS: an element's rectangle intersected with every clipping ancestor. It exists because
137
138
  a badge shipped that was present, correct and 32% visible.
138
139
 
139
- Current evidence, reproducible from a clean checkout:
140
+ Evidence measured at `22.2.3`, reproducible from a clean checkout:
141
+
142
+ <!-- Anchored to a version on purpose. Two of these numbers cannot be gated cheaply: the
143
+ spec count needs a 90-second suite run and the browser gate needs a browser, while
144
+ `npm run check` exists to answer in three seconds. A number that cannot be gated must
145
+ not be written in the present tense, or it becomes a claim that quietly stops being
146
+ true — which is the failure this repository keeps finding in other people's prose.
147
+ `17/17` IS gated, by check:gate-count. -->
140
148
 
141
149
  ```
142
- 17/17 gates exit 0
143
- library build exit 0 · 210 entrypoints
144
- inherited spec suite 3795 SUCCESS
150
+ 18/18 gates exit 0
151
+ library build exit 0 · 211 entrypoints
152
+ inherited spec suite 3809 SUCCESS
145
153
  browser gate 70 tests · 14 behaviour + 56 visibility
146
154
  runtime deps tslib + four first-party angulux-* packages. Zero PrimeTek.
147
155
  ```
@@ -152,9 +160,9 @@ The commitment is **a green build within 14 days of every Angular major RC**, ve
152
160
  nightly job that builds against `@angular/core@next` and reports publicly. angulux's major
153
161
  version is locked to Angular's major, so `angulux@22.x` targets Angular 22 and nothing else.
154
162
 
155
- ### 3. 64 warranted modules instead of 117 unverified ones
163
+ ### 3. 65 warranted modules instead of 117 unverified ones
156
164
 
157
- Every shipped module is inside the closure that the gates cover. The other 53 live in
165
+ Every shipped module is inside the closure that the gates cover. The other 52 live in
158
166
  [`packages/angulux/attic/`](packages/angulux/attic/) — verbatim upstream source, not built,
159
167
  not published, kept in the open as a roadmap. Promoting one is a well-defined contribution; see
160
168
  [CONTRIBUTING.md](CONTRIBUTING.md).
@@ -162,7 +170,7 @@ not published, kept in the open as a roadmap. Promoting one is a well-defined co
162
170
  ## What angulux is NOT
163
171
 
164
172
  - **Not a drop-in replacement.** Selectors changed. A migration codemod is planned, not shipped.
165
- - **Not feature-parity with PrimeNG.** 64 of 117 modules. Missing, among others: Editor,
173
+ - **Not feature-parity with PrimeNG.** 65 of 117 modules. Missing, among others: Editor,
166
174
  Tree, TreeSelect, OrganizationChart, PickList, OrderList, Listbox, Terminal, Dock.
167
175
  (TreeTable **is** shipped; Tree is not.)
168
176
  - **Not affiliated with PrimeTek or Google.** See [NOTICE](NOTICE).
@@ -200,7 +208,7 @@ so locking them to Angular's major would be a lie about their compatibility.
200
208
 
201
209
  ```bash
202
210
  corepack pnpm install
203
- npm run check # the 17 gates
211
+ npm run check # the 18 gates
204
212
 
205
213
  # the four forked packages build BEFORE the library — dependency order matters
206
214
  for p in utils styled motion styles; do
@@ -208,9 +216,9 @@ for p in utils styled motion styles; do
208
216
  done
209
217
 
210
218
  corepack pnpm --filter angulux run build # → 210 entrypoints
211
- corepack pnpm --filter angulux run test:unit # → 3765 specs
219
+ corepack pnpm --filter angulux run test:unit # the inherited spec suite
212
220
  corepack pnpm --filter @angulux/verify run build
213
- npx playwright test --config e2e/playwright.config.ts # browser gate → 70 tests
221
+ npx playwright test --config e2e/playwright.config.ts # browser gate
214
222
  ```
215
223
 
216
224
  `pnpm` runs through corepack and is not on `PATH`; use `corepack pnpm`. Karma needs
@@ -219,7 +227,7 @@ npx playwright test --config e2e/playwright.config.ts # browser gate → 70 te
219
227
  ## Documentation
220
228
 
221
229
  <https://angulux.anguless.com> is the documentation site: a page per module with runnable
222
- demos, and an API reference for all 64 modules generated from `corpus/corpus.json` — the same
230
+ demos, and an API reference for all 65 modules generated from `corpus/corpus.json` — the same
223
231
  corpus that produces the files in the next section, so the two cannot say different things
224
232
  about the same API.
225
233
 
@@ -2305,21 +2305,35 @@ class DatePicker extends BaseInput {
2305
2305
  }
2306
2306
  switch (true // intentional fall through
2307
2307
  ) {
2308
- case isMinDate && minHoursExceeds12 && this.minDate.getHours() === 12 && this.minDate.getHours() > convertedHour:
2309
- returnTimeTriple[0] = 11;
2310
- case isMinDate && this.minDate.getHours() === convertedHour && this.minDate.getMinutes() > minute:
2311
- returnTimeTriple[1] = this.minDate.getMinutes();
2312
- case isMinDate && this.minDate.getHours() === convertedHour && this.minDate.getMinutes() === minute && this.minDate.getSeconds() > second:
2313
- returnTimeTriple[2] = this.minDate.getSeconds();
2314
- break;
2315
- case isMinDate && !minHoursExceeds12 && this.minDate.getHours() - 1 === convertedHour && this.minDate.getHours() > convertedHour:
2316
- returnTimeTriple[0] = 11;
2317
- this.pm = true;
2318
- case isMinDate && this.minDate.getHours() === convertedHour && this.minDate.getMinutes() > minute:
2319
- returnTimeTriple[1] = this.minDate.getMinutes();
2320
- case isMinDate && this.minDate.getHours() === convertedHour && this.minDate.getMinutes() === minute && this.minDate.getSeconds() > second:
2321
- returnTimeTriple[2] = this.minDate.getSeconds();
2322
- break;
2308
+ // TWO BRANCHES REMOVED HERE, both of which assigned a hard-coded 11.
2309
+ //
2310
+ // They read:
2311
+ //
2312
+ // case isMinDate && minHoursExceeds12 && minDate.getHours() === 12
2313
+ // && minDate.getHours() > convertedHour:
2314
+ // returnTimeTriple[0] = 11;
2315
+ // case isMinDate && !minHoursExceeds12 && minDate.getHours() - 1 === convertedHour
2316
+ // && minDate.getHours() > convertedHour:
2317
+ // returnTimeTriple[0] = 11;
2318
+ // this.pm = true;
2319
+ //
2320
+ // 11 is neither the minimum nor the hour the user asked for. With minDate and the
2321
+ // value both at 09:00 and one step down, the second branch matched (9 - 1 === 8 and
2322
+ // 9 > 8) and the picker rendered 11 — then updateTime() wrote 11:00 into the bound
2323
+ // model. The application asked for a minimum of 09:00 and received a later time it
2324
+ // never chose, with nothing reported. Measured in e2e/upstream-repro.spec.ts.
2325
+ //
2326
+ // Deleting them is safe because each condition is a STRICT SUBSET of a general
2327
+ // clamp further down, and those clamps already do the right thing:
2328
+ // • the first is subsumed by the minHoursExceeds12 branch below, which converts
2329
+ // properly through setCurrentHourPM() instead of guessing;
2330
+ // • the second is subsumed by the plain "minDate.getHours() > convertedHour"
2331
+ // branch, which assigns the minimum itself.
2332
+ // The minute and second lines they fell through into are repeated verbatim in both
2333
+ // of those groups, so minute and second clamping is unchanged.
2334
+ //
2335
+ // this.pm = true was wrong on its own terms as well: that branch only ran when the
2336
+ // minimum was BEFORE noon.
2323
2337
  case isMinDate && minHoursExceeds12 && this.minDate.getHours() > convertedHour && convertedHour !== 12:
2324
2338
  this.setCurrentHourPM(this.minDate.getHours());
2325
2339
  returnTimeTriple[0] = this.currentHour || 0;