@angular/core 20.0.0-next.4 → 20.0.0-next.6

package/schematics/bundles/output-migration.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v20.0.0-next.4
+ * @license Angular v20.0.0-next.6
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */
@@ -8,12 +8,13 @@
 
 var ts = require('typescript');
 require('os');
-var checker = require('./checker-k591b6WQ.js');
-var index$1 = require('./index-B4OAlHh8.js');
+var checker = require('./checker-BFBQyesT.js');
+var compiler = require('./compiler-BQ7R7w2v.js');
+var index$1 = require('./index-Cv4Q415G.js');
 require('path');
-var run_in_devkit = require('./run_in_devkit-CkvEksWP.js');
-var apply_import_manager = require('./apply_import_manager-CeNv8GIG.js');
-var index = require('./index-BhELUmYx.js');
+var project_paths = require('./project_paths-ql6qcf_c.js');
+var apply_import_manager = require('./apply_import_manager-DnMqg1pY.js');
+var index = require('./index-D8tMJPKa.js');
 require('@angular-devkit/core');
 require('node:path/posix');
 require('fs');
@@ -90,7 +91,7 @@ function getOutputDecorator(node, reflector) {
 // THINK: this utility + type is not specific to @Output, really, maybe move it to tsurge?
 /** Computes an unique ID for a given Angular `@Output` property. */
 function getUniqueIdForProperty(info, prop) {
-    const { id } = run_in_devkit.projectFile(prop.getSourceFile(), info);
+    const { id } = project_paths.projectFile(prop.getSourceFile(), info);
     id.replace(/\.d\.ts$/, '.ts');
     return `${id}@@${prop.parent.name ?? 'unknown-class'}@@${prop.name.getText()}`;
 }
@@ -114,7 +115,7 @@ function checkNonTsReferenceAccessesField(ref, fieldName) {
     if (ref.from.read !== readFromPath) {
         return null;
     }
-    if (!(parentRead instanceof checker.PropertyRead) || parentRead.name !== fieldName) {
+    if (!(parentRead instanceof compiler.PropertyRead) || parentRead.name !== fieldName) {
         return null;
     }
     return parentRead;
@@ -144,9 +145,13 @@ function checkNonTsReferenceCallsField(ref, fieldName) {
 const printer = ts.createPrinter();
 function calculateDeclarationReplacement(info, node, aliasParam) {
     const sf = node.getSourceFile();
-    const payloadTypes = node.initializer !== undefined && ts.isNewExpression(node.initializer)
-        ? node.initializer?.typeArguments
-        : undefined;
+    let payloadTypes;
+    if (node.initializer && ts.isNewExpression(node.initializer) && node.initializer.typeArguments) {
+        payloadTypes = node.initializer.typeArguments;
+    }
+    else if (node.type && ts.isTypeReferenceNode(node.type) && node.type.typeArguments) {
+        payloadTypes = ts.factory.createNodeArray(node.type.typeArguments);
+    }
     const outputCall = ts.factory.createCallExpression(ts.factory.createIdentifier('output'), payloadTypes, aliasParam !== undefined
         ? [
             ts.factory.createObjectLiteralExpression([
@@ -169,7 +174,7 @@ function calculateImportReplacements(info, sourceFiles) {
         const importManager = new checker.ImportManager();
         const addOnly = [];
         const addRemove = [];
-        const file = run_in_devkit.projectFile(sf, info);
+        const file = project_paths.projectFile(sf, info);
         importManager.addImport({
             requestedFile: sf,
             exportModuleSpecifier: '@angular/core',
@@ -225,21 +230,21 @@ function calculatePipeCallReplacement(info, node) {
 }
 function prepareTextReplacementForNode(info, node, replacement, start) {
     const sf = node.getSourceFile();
-    return new run_in_devkit.Replacement(run_in_devkit.projectFile(sf, info), new run_in_devkit.TextUpdate({
+    return new project_paths.Replacement(project_paths.projectFile(sf, info), new project_paths.TextUpdate({
         position: start ?? node.getStart(),
         end: node.getEnd(),
         toInsert: replacement,
     }));
 }
 function prepareTextReplacement(file, replacement, start, end) {
-    return new run_in_devkit.Replacement(file, new run_in_devkit.TextUpdate({
+    return new project_paths.Replacement(file, new project_paths.TextUpdate({
         position: start,
         end: end,
         toInsert: replacement,
     }));
 }
 
-class OutputMigration extends run_in_devkit.TsurgeFunnelMigration {
+class OutputMigration extends project_paths.TsurgeFunnelMigration {
     config;
     constructor(config = {}) {
         super();
@@ -290,7 +295,7 @@ class OutputMigration extends run_in_devkit.TsurgeFunnelMigration {
                             id: getUniqueIdForProperty(info, node),
                             aliasParam: outputDecorator.args?.at(0),
                         };
-                        const outputFile = run_in_devkit.projectFile(node.getSourceFile(), info);
+                        const outputFile = project_paths.projectFile(node.getSourceFile(), info);
                         if (this.config.shouldMigrate === undefined ||
                             this.config.shouldMigrate({
                                 key: outputDef.id,
@@ -318,7 +323,7 @@ class OutputMigration extends run_in_devkit.TsurgeFunnelMigration {
                 const propertyDeclaration = isTargetOutputDeclaration(node.expression.expression, checker$1, reflector, dtsReader);
                 if (propertyDeclaration !== null) {
                     const id = getUniqueIdForProperty(info, propertyDeclaration);
-                    const outputFile = run_in_devkit.projectFile(node.getSourceFile(), info);
+                    const outputFile = project_paths.projectFile(node.getSourceFile(), info);
                     addOutputReplacement(outputFieldReplacements, id, outputFile, calculateNextFnReplacement(info, node.expression.name));
                 }
             }
@@ -327,7 +332,7 @@ class OutputMigration extends run_in_devkit.TsurgeFunnelMigration {
                 const propertyDeclaration = isTargetOutputDeclaration(node.expression.expression, checker$1, reflector, dtsReader);
                 if (propertyDeclaration !== null) {
                     const id = getUniqueIdForProperty(info, propertyDeclaration);
-                    const outputFile = run_in_devkit.projectFile(node.getSourceFile(), info);
+                    const outputFile = project_paths.projectFile(node.getSourceFile(), info);
                     if (ts.isExpressionStatement(node.parent)) {
                         addOutputReplacement(outputFieldReplacements, id, outputFile, calculateCompleteCallReplacement(info, node.parent));
                     }
@@ -336,6 +341,7 @@ class OutputMigration extends run_in_devkit.TsurgeFunnelMigration {
                     }
                 }
             }
+            addCommentForEmptyEmit(node, info, checker$1, reflector, dtsReader, outputFieldReplacements);
             // detect imports of test runners
             if (isTestRunnerImport(node)) {
                 isTestFile = true;
@@ -346,7 +352,7 @@ class OutputMigration extends run_in_devkit.TsurgeFunnelMigration {
                 if (propertyDeclaration !== null) {
                     const id = getUniqueIdForProperty(info, propertyDeclaration);
                     if (isTestFile) {
-                        const outputFile = run_in_devkit.projectFile(node.getSourceFile(), info);
+                        const outputFile = project_paths.projectFile(node.getSourceFile(), info);
                         addOutputReplacement(outputFieldReplacements, id, outputFile, ...calculatePipeCallReplacement(info, node));
                     }
                     else {
@@ -390,7 +396,7 @@ class OutputMigration extends run_in_devkit.TsurgeFunnelMigration {
         }
         // calculate import replacements but do so only for files that have output declarations
         const importReplacements = calculateImportReplacements(info, filesWithOutputDeclarations);
-        return run_in_devkit.confirmAsSerializable({
+        return project_paths.confirmAsSerializable({
             problematicDeclarationCount,
             outputFields: outputFieldReplacements,
             importReplacements,
@@ -420,7 +426,7 @@ class OutputMigration extends run_in_devkit.TsurgeFunnelMigration {
                 problematicUsages[declId] = unit.problematicUsages[declId];
             }
         }
-        return run_in_devkit.confirmAsSerializable({
+        return project_paths.confirmAsSerializable({
             problematicDeclarationCount,
             outputFields,
             importReplacements,
@@ -442,7 +448,7 @@ class OutputMigration extends run_in_devkit.TsurgeFunnelMigration {
             }
         }
         // Noop here as we don't have any form of special global metadata.
-        return run_in_devkit.confirmAsSerializable(combinedData);
+        return project_paths.confirmAsSerializable(combinedData);
     }
     async stats(globalMetadata) {
         const detectedOutputs = new Set(Object.keys(globalMetadata.outputFields)).size +
@@ -498,10 +504,62 @@ function addOutputReplacement(outputFieldReplacements, outputId, file, ...replac
     }
     existingReplacements.replacements.push(...replacements);
 }
+function addCommentForEmptyEmit(node, info, checker, reflector, dtsReader, outputFieldReplacements) {
+    if (!isEmptyEmitCall(node))
+        return;
+    const propertyAccess = getPropertyAccess(node);
+    if (!propertyAccess)
+        return;
+    const symbol = checker.getSymbolAtLocation(propertyAccess.name);
+    if (!symbol || !symbol.declarations?.length)
+        return;
+    const propertyDeclaration = isTargetOutputDeclaration(propertyAccess, checker, reflector, dtsReader);
+    if (!propertyDeclaration)
+        return;
+    const eventEmitterType = getEventEmitterArgumentType(propertyDeclaration);
+    if (!eventEmitterType)
+        return;
+    const id = getUniqueIdForProperty(info, propertyDeclaration);
+    const file = project_paths.projectFile(node.getSourceFile(), info);
+    const formatter = getFormatterText(node);
+    const todoReplacement = new project_paths.TextUpdate({
+        toInsert: `${formatter.indent}// TODO: The 'emit' function requires a mandatory ${eventEmitterType} argument\n`,
+        end: formatter.lineStartPos,
+        position: formatter.lineStartPos,
+    });
+    addOutputReplacement(outputFieldReplacements, id, file, new project_paths.Replacement(file, todoReplacement));
+}
+function isEmptyEmitCall(node) {
+    return (ts.isCallExpression(node) &&
+        ts.isPropertyAccessExpression(node.expression) &&
+        node.expression.name.text === 'emit' &&
+        node.arguments.length === 0);
+}
+function getPropertyAccess(node) {
+    const propertyAccessExpression = node.expression.expression;
+    return ts.isPropertyAccessExpression(propertyAccessExpression) ? propertyAccessExpression : null;
+}
+function getEventEmitterArgumentType(propertyDeclaration) {
+    const initializer = propertyDeclaration.initializer;
+    if (!initializer || !ts.isNewExpression(initializer))
+        return null;
+    const isEventEmitter = ts.isIdentifier(initializer.expression) && initializer.expression.getText() === 'EventEmitter';
+    if (!isEventEmitter)
+        return null;
+    const [typeArg] = initializer.typeArguments ?? [];
+    return typeArg ? typeArg.getText() : null;
+}
+function getFormatterText(node) {
+    const sourceFile = node.getSourceFile();
+    const { line } = sourceFile.getLineAndCharacterOfPosition(node.getStart());
+    const lineStartPos = sourceFile.getPositionOfLineAndCharacter(line, 0);
+    const indent = sourceFile.text.slice(lineStartPos, node.getStart());
+    return { indent, lineStartPos };
+}
 
 function migrate(options) {
     return async (tree, context) => {
-        await run_in_devkit.runMigrationInDevkit({
+        await project_paths.runMigrationInDevkit({
             tree,
             getMigration: (fs) => new OutputMigration({
                 shouldMigrate: (_, file) => {
@@ -509,8 +567,13 @@ function migrate(options) {
                         !/(^|\/)node_modules\//.test(file.rootRelativePath));
                 },
             }),
-            beforeProgramCreation: (tsconfigPath) => {
-                context.logger.info(`Preparing analysis for: ${tsconfigPath}...`);
+            beforeProgramCreation: (tsconfigPath, stage) => {
+                if (stage === project_paths.MigrationStage.Analysis) {
+                    context.logger.info(`Preparing analysis for: ${tsconfigPath}...`);
+                }
+                else {
+                    context.logger.info(`Running migration for: ${tsconfigPath}...`);
+                }
             },
             afterProgramCreation: (info, fs) => {
                 const analysisPath = fs.resolve(options.analysisDir);