@angular/core 19.2.6 → 19.2.8

package/schematics/bundles/inject-migration.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */
@@ -8,13 +8,13 @@
 
 var schematics = require('@angular-devkit/schematics');
 var p = require('path');
-var compiler_host = require('./compiler_host-BUKEE1cA.js');
+var compiler_host = require('./compiler_host-BafHjBMK.js');
 var ts = require('typescript');
 var ng_decorators = require('./ng_decorators-DznZ5jMl.js');
 var imports = require('./imports-CIX-JgAN.js');
 var nodes = require('./nodes-B16H9JUd.js');
 var leading_space = require('./leading_space-D9nQ8UQC.js');
-require('./checker-DoX_7XCa.js');
+require('./checker-BNmiXJIJ.js');
 require('os');
 require('fs');
 require('module');
@@ -371,7 +371,7 @@ function isInlineFunction(node) {
  * @param constructor Constructor declaration of the class being migrated.
  * @param localTypeChecker Type checker scoped to the current file.
  */
-function findUninitializedPropertiesToCombine(node, constructor, localTypeChecker) {
+function findUninitializedPropertiesToCombine(node, constructor, localTypeChecker, options) {
     let toCombine = null;
     let toHoist = [];
     const membersToDeclarations = new Map();
@@ -389,10 +389,13 @@ function findUninitializedPropertiesToCombine(node, constructor, localTypeChecke
     if (memberInitializers === null) {
         return null;
     }
+    const inlinableParameters = options._internalReplaceParameterReferencesInInitializers
+        ? findInlinableParameterReferences(constructor, localTypeChecker)
+        : new Set();
     for (const [name, decl] of membersToDeclarations.entries()) {
         if (memberInitializers.has(name)) {
             const initializer = memberInitializers.get(name);
-            if (!hasLocalReferences(initializer, constructor, localTypeChecker)) {
+            if (!hasLocalReferences(initializer, constructor, inlinableParameters, localTypeChecker)) {
                 toCombine ??= [];
                 toCombine.push({ declaration: membersToDeclarations.get(name), initializer });
             }
@@ -534,13 +537,70 @@ function getMemberInitializers(constructor) {
     }
     return memberInitializers;
 }
+/**
+ * Checks if the node is an identifier that references a property from the given
+ * list. Returns the property if it is.
+ */
+function getIdentifierReferencingProperty(node, localTypeChecker, propertyNames, properties) {
+    if (!ts.isIdentifier(node) || !propertyNames.has(node.text)) {
+        return undefined;
+    }
+    const declarations = localTypeChecker.getSymbolAtLocation(node)?.declarations;
+    if (!declarations) {
+        return undefined;
+    }
+    for (const decl of declarations) {
+        if (properties.has(decl)) {
+            return decl;
+        }
+    }
+    return undefined;
+}
+/**
+ * Returns true if the node introduces a new `this` scope (so we can't
+ * reference the outer this).
+ */
+function introducesNewThisScope(node) {
+    return (ts.isFunctionDeclaration(node) ||
+        ts.isFunctionExpression(node) ||
+        ts.isMethodDeclaration(node) ||
+        ts.isClassDeclaration(node) ||
+        ts.isClassExpression(node));
+}
+/**
+ * Finds constructor parameter references which can be inlined as `this.prop`.
+ * - prop must be a readonly property
+ * - the reference can't be in a nested function where `this` might refer
+ *   to something else
+ */
+function findInlinableParameterReferences(constructorDeclaration, localTypeChecker) {
+    const eligibleProperties = constructorDeclaration.parameters.filter((p) => ts.isIdentifier(p.name) && p.modifiers?.some((s) => s.kind === ts.SyntaxKind.ReadonlyKeyword));
+    const eligibleNames = new Set(eligibleProperties.map((p) => p.name.text));
+    const eligiblePropertiesSet = new Set(eligibleProperties);
+    function walk(node, canReferenceThis) {
+        const property = getIdentifierReferencingProperty(node, localTypeChecker, eligibleNames, eligiblePropertiesSet);
+        if (property && !canReferenceThis) {
+            // The property is referenced in a nested context where
+            // we can't use `this`, so we can't inline it.
+            eligiblePropertiesSet.delete(property);
+        }
+        else if (introducesNewThisScope(node)) {
+            canReferenceThis = false;
+        }
+        ts.forEachChild(node, (child) => {
+            walk(child, canReferenceThis);
+        });
+    }
+    walk(constructorDeclaration, true);
+    return eligiblePropertiesSet;
+}
 /**
  * Determines if a node has references to local symbols defined in the constructor.
  * @param root Expression to check for local references.
  * @param constructor Constructor within which the expression is used.
  * @param localTypeChecker Type checker scoped to the current file.
  */
-function hasLocalReferences(root, constructor, localTypeChecker) {
+function hasLocalReferences(root, constructor, allowedParameters, localTypeChecker) {
     const sourceFile = root.getSourceFile();
     let hasLocalRefs = false;
     const walk = (node) => {
@@ -562,7 +622,8 @@ function hasLocalReferences(root, constructor, localTypeChecker) {
             // The source file check is a bit redundant since the type checker
             // is local to the file, but it's inexpensive and it can prevent
             // bugs in the future if we decide to use a full type checker.
-            decl.getSourceFile() === sourceFile &&
+            !allowedParameters.has(decl) &&
+                decl.getSourceFile() === sourceFile &&
                 decl.getStart() >= constructor.getStart() &&
                 decl.getEnd() <= constructor.getEnd() &&
                 !isInsideInlineFunction(decl, constructor));
@@ -626,7 +687,7 @@ function migrateFile(sourceFile, options) {
         const removedStatements = new Set();
         const removedMembers = new Set();
         if (options._internalCombineMemberInitializers) {
-            applyInternalOnlyChanges(node, constructor, localTypeChecker, tracker, printer, removedStatements, removedMembers, prependToClass, afterInjectCalls, memberIndentation);
+            applyInternalOnlyChanges(node, constructor, localTypeChecker, tracker, printer, removedStatements, removedMembers, prependToClass, afterInjectCalls, memberIndentation, options);
         }
         migrateClass(node, constructor, superCall, options, memberIndentation, prependToClass, afterInjectCalls, removedStatements, removedMembers, localTypeChecker, printer, tracker);
     });
@@ -1097,8 +1158,8 @@ function getNextPreservedStatement(startNode, removedStatements) {
  * @param afterInjectCalls Text that will be inserted after the newly-added `inject` calls.
  * @param memberIndentation Indentation string of the class' members.
  */
-function applyInternalOnlyChanges(node, constructor, localTypeChecker, tracker, printer, removedStatements, removedMembers, prependToClass, afterInjectCalls, memberIndentation) {
-    const result = findUninitializedPropertiesToCombine(node, constructor, localTypeChecker);
+function applyInternalOnlyChanges(node, constructor, localTypeChecker, tracker, printer, removedStatements, removedMembers, prependToClass, afterInjectCalls, memberIndentation, options) {
+    const result = findUninitializedPropertiesToCombine(node, constructor, localTypeChecker, options);
     if (result === null) {
         return;
     }
@@ -1111,21 +1172,25 @@ function applyInternalOnlyChanges(node, constructor, localTypeChecker, tracker,
     }
     result.toCombine.forEach(({ declaration, initializer }) => {
         const initializerStatement = nodes.closestNode(initializer, ts.isStatement);
+        // Strip comments if we are just going modify the node in-place.
+        const modifiers = preserveInitOrder
+            ? declaration.modifiers
+            : cloneModifiers(declaration.modifiers);
+        const name = preserveInitOrder ? declaration.name : cloneName(declaration.name);
+        const newProperty = ts.factory.createPropertyDeclaration(modifiers, name, declaration.questionToken, declaration.type, undefined);
+        const propText = printer.printNode(ts.EmitHint.Unspecified, newProperty, declaration.getSourceFile());
+        const initializerText = replaceParameterReferencesInInitializer(initializer, constructor, localTypeChecker);
+        const withInitializer = `${propText.slice(0, -1)} = ${initializerText};`;
         // If the initialization order is being preserved, we have to remove the original
         // declaration and re-declare it. Otherwise we can do the replacement in-place.
         if (preserveInitOrder) {
-            // Preserve comment in the new property since we are removing the entire node.
-            const newProperty = ts.factory.createPropertyDeclaration(declaration.modifiers, declaration.name, declaration.questionToken, declaration.type, initializer);
             tracker.removeNode(declaration, true);
             removedMembers.add(declaration);
-            afterInjectCalls.push(memberIndentation +
-                printer.printNode(ts.EmitHint.Unspecified, newProperty, declaration.getSourceFile()));
+            afterInjectCalls.push(memberIndentation + withInitializer);
         }
         else {
-            // Strip comments from the declaration since we are replacing just
-            // the node, not the leading comment.
-            const newProperty = ts.factory.createPropertyDeclaration(cloneModifiers(declaration.modifiers), cloneName(declaration.name), declaration.questionToken, declaration.type, initializer);
-            tracker.replaceNode(declaration, newProperty);
+            const sourceFile = declaration.getSourceFile();
+            tracker.replaceText(sourceFile, declaration.getStart(), declaration.getWidth(), withInitializer);
         }
         // This should always be defined, but null check it just in case.
         if (initializerStatement) {
@@ -1143,6 +1208,30 @@ function applyInternalOnlyChanges(node, constructor, localTypeChecker, tracker,
         prependToClass.push('');
     }
 }
+function replaceParameterReferencesInInitializer(initializer, constructor, localTypeChecker) {
+    // 1. Collect the locations of identifier nodes that reference constructor parameters.
+    // 2. Add `this.` to those locations.
+    const insertLocations = [0];
+    function walk(node) {
+        if (ts.isIdentifier(node) &&
+            !(ts.isPropertyAccessExpression(node.parent) && node === node.parent.name) &&
+            localTypeChecker
+                .getSymbolAtLocation(node)
+                ?.declarations?.some((decl) => constructor.parameters.includes(decl))) {
+            insertLocations.push(node.getStart() - initializer.getStart());
+        }
+        ts.forEachChild(node, walk);
+    }
+    walk(initializer);
+    const initializerText = initializer.getText();
+    insertLocations.push(initializerText.length);
+    insertLocations.sort((a, b) => a - b);
+    const result = [];
+    for (let i = 0; i < insertLocations.length - 1; i++) {
+        result.push(initializerText.slice(insertLocations[i], insertLocations[i + 1]));
+    }
+    return result.join('this.');
+}
 
 function migrate(options) {
     return async (tree) => {

package/schematics/bundles/leading_space-D9nQ8UQC.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */

package/schematics/bundles/{migrate_ts_type_references-DQVDid4G.js → migrate_ts_type_references-BIV-FPWl.js}

@@ -1,19 +1,19 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */
 'use strict';
 
-var checker = require('./checker-DoX_7XCa.js');
+var checker = require('./checker-BNmiXJIJ.js');
 var ts = require('typescript');
 require('os');
 var assert = require('assert');
-var index = require('./index-CpZKzrqM.js');
-var project_paths = require('./project_paths-C3etOlgT.js');
+var index = require('./index-rvZ5aROS.js');
+var project_paths = require('./project_paths-A9I0g_ID.js');
 var leading_space = require('./leading_space-D9nQ8UQC.js');
-require('./index-B4b0V0Vo.js');
+require('./index-CAJ-Rm56.js');
 require('path');
 
 /**

package/schematics/bundles/ng_decorators-DznZ5jMl.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */

package/schematics/bundles/nodes-B16H9JUd.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */

package/schematics/bundles/output-migration.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */
@@ -8,12 +8,12 @@
 
 var ts = require('typescript');
 require('os');
-var checker = require('./checker-DoX_7XCa.js');
-var index$1 = require('./index-B4b0V0Vo.js');
+var checker = require('./checker-BNmiXJIJ.js');
+var index$1 = require('./index-CAJ-Rm56.js');
 require('path');
-var project_paths = require('./project_paths-C3etOlgT.js');
-var apply_import_manager = require('./apply_import_manager-DFADpdFu.js');
-var index = require('./index-CpZKzrqM.js');
+var project_paths = require('./project_paths-A9I0g_ID.js');
+var apply_import_manager = require('./apply_import_manager-COqnCltX.js');
+var index = require('./index-rvZ5aROS.js');
 require('@angular-devkit/core');
 require('node:path/posix');
 require('fs');

package/schematics/bundles/pending-tasks.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */
@@ -9,11 +9,11 @@
 var schematics = require('@angular-devkit/schematics');
 var p = require('path');
 var project_tsconfig_paths = require('./project_tsconfig_paths-CDVxT6Ov.js');
-var compiler_host = require('./compiler_host-BUKEE1cA.js');
+var compiler_host = require('./compiler_host-BafHjBMK.js');
 var ts = require('typescript');
 var imports = require('./imports-CIX-JgAN.js');
 require('@angular-devkit/core');
-require('./checker-DoX_7XCa.js');
+require('./checker-BNmiXJIJ.js');
 require('os');
 require('fs');
 require('module');

package/schematics/bundles/{project_paths-C3etOlgT.js → project_paths-A9I0g_ID.js}

@@ -1,18 +1,18 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */
 'use strict';
 
-var index = require('./index-B4b0V0Vo.js');
+var index = require('./index-CAJ-Rm56.js');
 var schematics = require('@angular-devkit/schematics');
 var core = require('@angular-devkit/core');
 var posixPath = require('node:path/posix');
 var os = require('os');
 var ts = require('typescript');
-var checker = require('./checker-DoX_7XCa.js');
+var checker = require('./checker-BNmiXJIJ.js');
 require('path');
 var project_tsconfig_paths = require('./project_tsconfig_paths-CDVxT6Ov.js');
 

package/schematics/bundles/project_tsconfig_paths-CDVxT6Ov.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */

package/schematics/bundles/property_name-BBwFuqMe.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */

package/schematics/bundles/provide-initializer.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */
@@ -9,11 +9,11 @@
 var schematics = require('@angular-devkit/schematics');
 var p = require('path');
 var project_tsconfig_paths = require('./project_tsconfig_paths-CDVxT6Ov.js');
-var compiler_host = require('./compiler_host-BUKEE1cA.js');
+var compiler_host = require('./compiler_host-BafHjBMK.js');
 var ts = require('typescript');
 var imports = require('./imports-CIX-JgAN.js');
 require('@angular-devkit/core');
-require('./checker-DoX_7XCa.js');
+require('./checker-BNmiXJIJ.js');
 require('os');
 require('fs');
 require('module');

package/schematics/bundles/route-lazy-loading.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */
@@ -9,10 +9,10 @@
 var schematics = require('@angular-devkit/schematics');
 var fs = require('fs');
 var p = require('path');
-var compiler_host = require('./compiler_host-BUKEE1cA.js');
+var compiler_host = require('./compiler_host-BafHjBMK.js');
 var project_tsconfig_paths = require('./project_tsconfig_paths-CDVxT6Ov.js');
 var ts = require('typescript');
-var checker = require('./checker-DoX_7XCa.js');
+var checker = require('./checker-BNmiXJIJ.js');
 var property_name = require('./property_name-BBwFuqMe.js');
 require('os');
 require('@angular-devkit/core');

package/schematics/bundles/self-closing-tags-migration.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */
@@ -8,10 +8,10 @@
 
 var ts = require('typescript');
 require('os');
-var checker = require('./checker-DoX_7XCa.js');
-require('./index-B4b0V0Vo.js');
+var checker = require('./checker-BNmiXJIJ.js');
+require('./index-CAJ-Rm56.js');
 require('path');
-var project_paths = require('./project_paths-C3etOlgT.js');
+var project_paths = require('./project_paths-A9I0g_ID.js');
 var ng_decorators = require('./ng_decorators-DznZ5jMl.js');
 var property_name = require('./property_name-BBwFuqMe.js');
 require('@angular-devkit/core');

package/schematics/bundles/signal-input-migration.js

@@ -1,21 +1,21 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */
 'use strict';
 
-var migrate_ts_type_references = require('./migrate_ts_type_references-DQVDid4G.js');
+var migrate_ts_type_references = require('./migrate_ts_type_references-BIV-FPWl.js');
 var ts = require('typescript');
 require('os');
-var checker = require('./checker-DoX_7XCa.js');
-var index$1 = require('./index-B4b0V0Vo.js');
+var checker = require('./checker-BNmiXJIJ.js');
+var index$1 = require('./index-CAJ-Rm56.js');
 require('path');
-var project_paths = require('./project_paths-C3etOlgT.js');
-var index = require('./index-CpZKzrqM.js');
+var project_paths = require('./project_paths-A9I0g_ID.js');
+var index = require('./index-rvZ5aROS.js');
 var assert = require('assert');
-var apply_import_manager = require('./apply_import_manager-DFADpdFu.js');
+var apply_import_manager = require('./apply_import_manager-COqnCltX.js');
 require('@angular-devkit/core');
 require('node:path/posix');
 require('./leading_space-D9nQ8UQC.js');

package/schematics/bundles/signal-queries-migration.js

@@ -1,21 +1,21 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */
 'use strict';
 
-var checker = require('./checker-DoX_7XCa.js');
+var checker = require('./checker-BNmiXJIJ.js');
 var ts = require('typescript');
 require('os');
-var index$1 = require('./index-B4b0V0Vo.js');
+var index$1 = require('./index-CAJ-Rm56.js');
 require('path');
-var project_paths = require('./project_paths-C3etOlgT.js');
-var apply_import_manager = require('./apply_import_manager-DFADpdFu.js');
-var migrate_ts_type_references = require('./migrate_ts_type_references-DQVDid4G.js');
+var project_paths = require('./project_paths-A9I0g_ID.js');
+var apply_import_manager = require('./apply_import_manager-COqnCltX.js');
+var migrate_ts_type_references = require('./migrate_ts_type_references-BIV-FPWl.js');
 var assert = require('assert');
-var index = require('./index-CpZKzrqM.js');
+var index = require('./index-rvZ5aROS.js');
 require('@angular-devkit/core');
 require('node:path/posix');
 require('fs');

package/schematics/bundles/signals.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */
@@ -10,22 +10,22 @@ var schematics = require('@angular-devkit/schematics');
 var signalQueriesMigration = require('./signal-queries-migration.js');
 var signalInputMigration = require('./signal-input-migration.js');
 var outputMigration = require('./output-migration.js');
-require('./checker-DoX_7XCa.js');
+require('./checker-BNmiXJIJ.js');
 require('typescript');
 require('os');
 require('fs');
 require('module');
 require('path');
 require('url');
-require('./index-B4b0V0Vo.js');
-require('./project_paths-C3etOlgT.js');
+require('./index-CAJ-Rm56.js');
+require('./project_paths-A9I0g_ID.js');
 require('@angular-devkit/core');
 require('node:path/posix');
 require('./project_tsconfig_paths-CDVxT6Ov.js');
-require('./apply_import_manager-DFADpdFu.js');
-require('./migrate_ts_type_references-DQVDid4G.js');
+require('./apply_import_manager-COqnCltX.js');
+require('./migrate_ts_type_references-BIV-FPWl.js');
 require('assert');
-require('./index-CpZKzrqM.js');
+require('./index-rvZ5aROS.js');
 require('./leading_space-D9nQ8UQC.js');
 
 function migrate(options) {

package/schematics/bundles/standalone-migration.js

@@ -1,22 +1,22 @@
 'use strict';
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */
 'use strict';
 
 var schematics = require('@angular-devkit/schematics');
-var index = require('./index-B4b0V0Vo.js');
+var index = require('./index-CAJ-Rm56.js');
 var fs = require('fs');
 var p = require('path');
 var ts = require('typescript');
-var compiler_host = require('./compiler_host-BUKEE1cA.js');
+var compiler_host = require('./compiler_host-BafHjBMK.js');
 var project_tsconfig_paths = require('./project_tsconfig_paths-CDVxT6Ov.js');
 var ng_decorators = require('./ng_decorators-DznZ5jMl.js');
 var nodes = require('./nodes-B16H9JUd.js');
 var imports = require('./imports-CIX-JgAN.js');
-var checker = require('./checker-DoX_7XCa.js');
+var checker = require('./checker-BNmiXJIJ.js');
 require('os');
 require('@angular-devkit/core');
 require('module');

package/testing/index.d.ts

@@ -1,5 +1,5 @@
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */

package/weak_ref.d-DWHPG08n.d.ts

@@ -1,5 +1,5 @@
 /**
- * @license Angular v19.2.6
+ * @license Angular v19.2.8
  * (c) 2010-2025 Google LLC. https://angular.io/
  * License: MIT
  */