@angular/core 19.0.0-rc.0 → 19.0.0-rc.2

package/schematics/bundles/signal-input-migration.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.0.0-rc.0
+ * @license Angular v19.0.0-rc.2
  * (c) 2010-2024 Google LLC. https://angular.io/
  * License: MIT
  */
@@ -9,16 +9,16 @@
 Object.defineProperty(exports, '__esModule', { value: true });
 
 var schematics = require('@angular-devkit/schematics');
-var migrate_ts_type_references = require('./migrate_ts_type_references-ab18a7c3.js');
+var migrate_ts_type_references = require('./migrate_ts_type_references-0bcee7cb.js');
 var ts = require('typescript');
 require('os');
-var checker = require('./checker-2451e7c5.js');
-var program = require('./program-58424797.js');
+var checker = require('./checker-cd95ebda.js');
+var program = require('./program-8f30df93.js');
 require('path');
-var combine_units = require('./combine_units-c52492ab.js');
+var combine_units = require('./combine_units-528c4a5d.js');
 var assert = require('assert');
-var project_tsconfig_paths = require('./project_tsconfig_paths-6c9cde78.js');
-require('./leading_space-6e7a8ec6.js');
+var project_tsconfig_paths = require('./project_tsconfig_paths-e9ccccbf.js');
+require('./leading_space-d190b83b.js');
 require('fs');
 require('module');
 require('url');
@@ -259,27 +259,29 @@ class KnownInputs {
  * and can be used for integrations with e.g. the language service.
  */
 function prepareAnalysisInfo(userProgram, compiler, programAbsoluteRootPaths) {
-    // Analyze sync and retrieve necessary dependencies.
-    // Note: `getTemplateTypeChecker` requires the `enableTemplateTypeChecker` flag, but
-    // this has negative effects as it causes optional TCB operations to execute, which may
-    // error with unsuccessful reference emits that previously were ignored outside of the migration.
-    // The migration is resilient to TCB information missing, so this is fine, and all the information
-    // we need is part of required TCB operations anyway.
-    const { refEmitter, metaReader, templateTypeChecker } = compiler['ensureAnalyzed']();
-    // Generate all type check blocks.
-    templateTypeChecker.generateAllTypeCheckBlocks();
+    let refEmitter = null;
+    let metaReader = null;
+    let templateTypeChecker = null;
+    let resourceLoader = null;
+    if (compiler !== null) {
+        // Analyze sync and retrieve necessary dependencies.
+        // Note: `getTemplateTypeChecker` requires the `enableTemplateTypeChecker` flag, but
+        // this has negative effects as it causes optional TCB operations to execute, which may
+        // error with unsuccessful reference emits that previously were ignored outside of the migration.
+        // The migration is resilient to TCB information missing, so this is fine, and all the information
+        // we need is part of required TCB operations anyway.
+        const state = compiler['ensureAnalyzed']();
+        resourceLoader = compiler['resourceManager'];
+        refEmitter = state.refEmitter;
+        metaReader = state.metaReader;
+        templateTypeChecker = state.templateTypeChecker;
+        // Generate all type check blocks.
+        state.templateTypeChecker.generateAllTypeCheckBlocks();
+    }
     const typeChecker = userProgram.getTypeChecker();
     const reflector = new checker.TypeScriptReflectionHost(typeChecker);
     const evaluator = new program.PartialEvaluator(reflector, typeChecker, null);
     const dtsMetadataReader = new program.DtsMetadataReader(typeChecker, reflector);
-    const resourceLoader = compiler['resourceManager'];
-    // Optional filter for testing. Allows for simulation of parallel execution
-    // even if some tsconfig's have overlap due to sharing of TS sources.
-    // (this is commonly not the case in g3 where deps are `.d.ts` files).
-    const limitToRootNamesOnly = process.env['LIMIT_TO_ROOT_NAMES_ONLY'] === '1';
-    if (limitToRootNamesOnly) {
-        assert__default["default"](programAbsoluteRootPaths !== undefined, 'Expected absolute root paths when limiting to root names.');
-    }
     return {
         metaRegistry: metaReader,
         dtsMetadataReader,
@@ -315,8 +317,8 @@ class MigrationResult {
 }
 
 /** Attempts to extract metadata of a potential TypeScript `@Input()` declaration. */
-function extractDecoratorInput(node, host, reflector, metadataReader, evaluator, refEmitter) {
-    return (extractSourceCodeInput(node, host, reflector, evaluator, refEmitter) ??
+function extractDecoratorInput(node, host, reflector, metadataReader, evaluator) {
+    return (extractSourceCodeInput(node, host, reflector, evaluator) ??
         extractDtsInput(node, metadataReader));
 }
 /**
@@ -366,7 +368,7 @@ function extractDtsInput(node, metadataReader) {
  * Attempts to extract `@Input()` information for the given node, assuming it's
  * directly defined inside a source file (`.ts`).
  */
-function extractSourceCodeInput(node, host, reflector, evaluator, refEmitter) {
+function extractSourceCodeInput(node, host, reflector, evaluator) {
     if (!combine_units.isInputContainerNode(node) ||
         !ts__default["default"].isIdentifier(node.name) ||
         node.getSourceFile().isDeclarationFile) {
@@ -399,7 +401,7 @@ function extractSourceCodeInput(node, host, reflector, evaluator, refEmitter) {
                 isRequired = !!evaluatedInputOpts.get('required');
             }
             if (evaluatedInputOpts.has('transform') && evaluatedInputOpts.get('transform') != null) {
-                transformResult = parseTransformOfInput(evaluatedInputOpts, node, reflector, refEmitter);
+                transformResult = parseTransformOfInput(evaluatedInputOpts, node, reflector);
             }
         }
     }
@@ -418,13 +420,25 @@ function extractSourceCodeInput(node, host, reflector, evaluator, refEmitter) {
  * Gracefully attempts to parse the `transform` option of an `@Input()`
  * and extracts its metadata.
  */
-function parseTransformOfInput(evaluatedInputOpts, node, reflector, refEmitter) {
+function parseTransformOfInput(evaluatedInputOpts, node, reflector) {
     const transformValue = evaluatedInputOpts.get('transform');
     if (!(transformValue instanceof checker.DynamicValue) && !(transformValue instanceof checker.Reference)) {
         return null;
     }
+    // For parsing the transform, we don't need a real reference emitter, as
+    // the emitter is only used for verifying that the transform type could be
+    // copied into e.g. an `ngInputAccept` class member.
+    const noopRefEmitter = new checker.ReferenceEmitter([
+        {
+            emit: () => ({
+                kind: checker.ReferenceEmitKind.Success,
+                expression: migrate_ts_type_references.NULL_EXPR,
+                importedFile: null,
+            }),
+        },
+    ]);
     try {
-        return program.parseDecoratorInputTransformFunction(node.parent, node.name.text, transformValue, reflector, refEmitter, checker.CompilationMode.FULL);
+        return program.parseDecoratorInputTransformFunction(node.parent, node.name.text, transformValue, reflector, noopRefEmitter, checker.CompilationMode.FULL);
     }
     catch (e) {
         if (!(e instanceof checker.FatalDiagnosticError)) {
@@ -584,9 +598,9 @@ function isPrimitiveImportableTypeNode(type) {
  * Phase where we iterate through all source files of the program (including `.d.ts`)
  * and keep track of all `@Input`'s we discover.
  */
-function pass1__IdentifySourceFileAndDeclarationInputs(sf, host, checker, reflector, dtsMetadataReader, evaluator, refEmitter, knownDecoratorInputs, result) {
+function pass1__IdentifySourceFileAndDeclarationInputs(sf, host, checker, reflector, dtsMetadataReader, evaluator, knownDecoratorInputs, result) {
     const visitor = (node) => {
-        const decoratorInput = extractDecoratorInput(node, host, reflector, dtsMetadataReader, evaluator, refEmitter);
+        const decoratorInput = extractDecoratorInput(node, host, reflector, dtsMetadataReader, evaluator);
         if (decoratorInput !== null) {
             assert__default["default"](combine_units.isInputContainerNode(node), 'Expected input to be declared on accessor or property.');
             const inputDescr = getInputDescriptor(host, node);
@@ -671,13 +685,13 @@ function pass2_IdentifySourceFileReferences(programInfo, checker, reflector, res
  *   - determining incompatible inputs
  *   - checking inheritance
  */
-function executeAnalysisPhase(host, knownInputs, result, { sourceFiles, fullProgramSourceFiles, reflector, dtsMetadataReader, typeChecker, templateTypeChecker, resourceLoader, evaluator, refEmitter, }) {
+function executeAnalysisPhase(host, knownInputs, result, { sourceFiles, fullProgramSourceFiles, reflector, dtsMetadataReader, typeChecker, templateTypeChecker, resourceLoader, evaluator, }) {
     // Pass 1
     fullProgramSourceFiles.forEach((sf) => 
     // Shim shim files. Those are unnecessary and might cause unexpected slowness.
     // e.g. `ngtypecheck` files.
     !checker.isShim(sf) &&
-        pass1__IdentifySourceFileAndDeclarationInputs(sf, host, typeChecker, reflector, dtsMetadataReader, evaluator, refEmitter, knownInputs, result));
+        pass1__IdentifySourceFileAndDeclarationInputs(sf, host, typeChecker, reflector, dtsMetadataReader, evaluator, knownInputs, result));
     const fieldNamesToConsiderForReferenceLookup = new Set();
     for (const input of knownInputs.knownInputIds.values()) {
         if (host.config.shouldMigrateInput?.(input) === false) {
@@ -1254,9 +1268,9 @@ class SignalInputMigration extends combine_units.TsurgeComplexMigration {
         super();
         this.config = config;
     }
-    // Override the default ngtsc program creation, to add extra flags.
+    // Override the default program creation, to add extra flags.
     createProgram(tsconfigAbsPath, fs) {
-        return combine_units.createNgtscProgram(tsconfigAbsPath, fs, {
+        return combine_units.createBaseProgramInfo(tsconfigAbsPath, fs, {
             _compilePoisonedComponents: true,
             // We want to migrate non-exported classes too.
             compileNonExportedClasses: true,
@@ -1284,7 +1298,6 @@ class SignalInputMigration extends combine_units.TsurgeComplexMigration {
     }
     // Extend the program info with the analysis information we need in every phase.
     prepareAnalysisDeps(info) {
-        assert__default["default"](info.ngCompiler !== null, 'Expected `NgCompiler` to be configured.');
         const analysisInfo = {
             ...info,
             ...prepareAnalysisInfo(info.program, info.ngCompiler, info.programAbsoluteRootFileNames),

package/schematics/bundles/signal-queries-migration.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.0.0-rc.0
+ * @license Angular v19.0.0-rc.2
  * (c) 2010-2024 Google LLC. https://angular.io/
  * License: MIT
  */
@@ -9,21 +9,21 @@
 Object.defineProperty(exports, '__esModule', { value: true });
 
 var schematics = require('@angular-devkit/schematics');
-var project_tsconfig_paths = require('./project_tsconfig_paths-6c9cde78.js');
-var combine_units = require('./combine_units-c52492ab.js');
+var project_tsconfig_paths = require('./project_tsconfig_paths-e9ccccbf.js');
+var combine_units = require('./combine_units-528c4a5d.js');
 require('os');
 var ts = require('typescript');
-var checker = require('./checker-2451e7c5.js');
-var program = require('./program-58424797.js');
-var assert = require('assert');
+var checker = require('./checker-cd95ebda.js');
+var program = require('./program-8f30df93.js');
 require('path');
-var migrate_ts_type_references = require('./migrate_ts_type_references-ab18a7c3.js');
+var migrate_ts_type_references = require('./migrate_ts_type_references-0bcee7cb.js');
+var assert = require('assert');
 require('@angular-devkit/core');
 require('node:path/posix');
 require('fs');
 require('module');
 require('url');
-require('./leading_space-6e7a8ec6.js');
+require('./leading_space-d190b83b.js');
 
 function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { 'default': e }; }
 
@@ -722,9 +722,15 @@ class SignalQueriesMigration extends combine_units.TsurgeComplexMigration {
         this.config = config;
     }
     async analyze(info) {
-        assert__default["default"](info.ngCompiler !== null, 'Expected queries migration to have an Angular program.');
         // Pre-Analyze the program and get access to the template type checker.
-        const { templateTypeChecker } = info.ngCompiler['ensureAnalyzed']();
+        const { templateTypeChecker } = info.ngCompiler?.['ensureAnalyzed']() ?? {
+            templateTypeChecker: null,
+        };
+        const resourceLoader = info.ngCompiler?.['resourceManager'] ?? null;
+        // Generate all type check blocks, if we have Angular template information.
+        if (templateTypeChecker !== null) {
+            templateTypeChecker.generateAllTypeCheckBlocks();
+        }
         const { sourceFiles, program: program$1 } = info;
         const checker$1 = program$1.getTypeChecker();
         const reflector = new checker.TypeScriptReflectionHost(checker$1);
@@ -796,8 +802,7 @@ class SignalQueriesMigration extends combine_units.TsurgeComplexMigration {
                 // of the queries since there aren't any other compilation units.
                 // Ignore references to non-query class fields.
                 if (this.config.assumeNonBatch &&
-                    descriptor !== null &&
-                    !filteredQueriesForCompilationUnit.has(descriptor.key)) {
+                    (descriptor === null || !filteredQueriesForCompilationUnit.has(descriptor.key))) {
                     return null;
                 }
                 // In batch mode, we eagerly, rather expensively, track all references.
@@ -807,7 +812,7 @@ class SignalQueriesMigration extends combine_units.TsurgeComplexMigration {
                 return descriptor;
             },
         };
-        groupedAstVisitor.register(combine_units.createFindAllSourceFileReferencesVisitor(info, checker$1, reflector, info.ngCompiler['resourceManager'], evaluator, templateTypeChecker, allFieldsOrKnownQueries, 
+        groupedAstVisitor.register(combine_units.createFindAllSourceFileReferencesVisitor(info, checker$1, reflector, resourceLoader, evaluator, templateTypeChecker, allFieldsOrKnownQueries, 
         // In non-batch mode, we know what inputs exist and can optimize the reference
         // resolution significantly (for e.g. VSCode integration)— as we know what
         // field names may be used to reference potential queries.
@@ -908,9 +913,12 @@ class SignalQueriesMigration extends combine_units.TsurgeComplexMigration {
         return combine_units.confirmAsSerializable(globalUnitData);
     }
     async migrate(globalMetadata, info) {
-        assert__default["default"](info.ngCompiler !== null, 'Expected queries migration to have an Angular program.');
         // Pre-Analyze the program and get access to the template type checker.
-        const { templateTypeChecker, metaReader } = info.ngCompiler['ensureAnalyzed']();
+        const { templateTypeChecker, metaReader } = info.ngCompiler?.['ensureAnalyzed']() ?? {
+            templateTypeChecker: null,
+            metaReader: null,
+        };
+        const resourceLoader = info.ngCompiler?.['resourceManager'] ?? null;
         const { program: program$1, sourceFiles } = info;
         const checker$1 = program$1.getTypeChecker();
         const reflector = new checker.TypeScriptReflectionHost(checker$1);
@@ -951,7 +959,6 @@ class SignalQueriesMigration extends combine_units.TsurgeComplexMigration {
             }
             ts__default["default"].forEachChild(node, queryWholeProgramVisitor);
         };
-        this.config.reportProgressFn?.(40, 'Tracking query declarations..');
         for (const sf of info.fullProgramSourceFiles) {
             ts__default["default"].forEachChild(sf, queryWholeProgramVisitor);
         }
@@ -966,7 +973,7 @@ class SignalQueriesMigration extends combine_units.TsurgeComplexMigration {
             referenceResult.references = globalMetadata.reusableAnalysisReferences;
         }
         else {
-            groupedAstVisitor.register(combine_units.createFindAllSourceFileReferencesVisitor(info, checker$1, reflector, info.ngCompiler['resourceManager'], evaluator, templateTypeChecker, knownQueries, fieldNamesToConsiderForReferenceLookup, referenceResult).visitor);
+            groupedAstVisitor.register(combine_units.createFindAllSourceFileReferencesVisitor(info, checker$1, reflector, resourceLoader, evaluator, templateTypeChecker, knownQueries, fieldNamesToConsiderForReferenceLookup, referenceResult).visitor);
         }
         // Check inheritance.
         // NOTE: Inheritance is only checked in the migrate stage as we cannot reliably
@@ -977,12 +984,12 @@ class SignalQueriesMigration extends combine_units.TsurgeComplexMigration {
             getFieldsForClass: (n) => knownQueries.getQueryFieldsOfClass(n) ?? [],
             isClassWithKnownFields: (clazz) => knownQueries.getQueryFieldsOfClass(clazz) !== undefined,
         });
-        this.config.reportProgressFn?.(70, 'Checking inheritance..');
+        this.config.reportProgressFn?.(80, 'Checking inheritance..');
         groupedAstVisitor.execute();
         if (this.config.bestEffortMode) {
             filterBestEffortIncompatibilities(knownQueries);
         }
-        this.config.reportProgressFn?.(80, 'Migrating queries..');
+        this.config.reportProgressFn?.(90, 'Migrating queries..');
         // Migrate declarations.
         for (const extractedQuery of sourceQueries) {
             const node = extractedQuery.node;

package/schematics/bundles/signals.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.0.0-rc.0
+ * @license Angular v19.0.0-rc.2
  * (c) 2010-2024 Google LLC. https://angular.io/
  * License: MIT
  */
@@ -12,21 +12,21 @@ var schematics = require('@angular-devkit/schematics');
 var signalQueriesMigration = require('./signal-queries-migration.js');
 var signalInputMigration = require('./signal-input-migration.js');
 var outputMigration = require('./output-migration.js');
-require('./project_tsconfig_paths-6c9cde78.js');
+require('./project_tsconfig_paths-e9ccccbf.js');
 require('@angular-devkit/core');
-require('./combine_units-c52492ab.js');
+require('./combine_units-528c4a5d.js');
 require('node:path/posix');
 require('os');
 require('typescript');
-require('./checker-2451e7c5.js');
+require('./checker-cd95ebda.js');
 require('fs');
 require('module');
 require('path');
 require('url');
-require('./program-58424797.js');
+require('./program-8f30df93.js');
+require('./migrate_ts_type_references-0bcee7cb.js');
 require('assert');
-require('./migrate_ts_type_references-ab18a7c3.js');
-require('./leading_space-6e7a8ec6.js');
+require('./leading_space-d190b83b.js');
 
 function migrate(options) {
     // The migrations are independent so we can run them in any order, but we sort them here