@angular/core 19.0.0-next.10 → 19.0.0-next.11

package/schematics/bundles/pending-tasks.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.0.0-next.10
+ * @license Angular v19.0.0-next.11
  * (c) 2010-2024 Google LLC. https://angular.io/
  * License: MIT
  */
@@ -11,11 +11,11 @@ Object.defineProperty(exports, '__esModule', { value: true });
 var schematics = require('@angular-devkit/schematics');
 var p = require('path');
 var project_tsconfig_paths = require('./project_tsconfig_paths-e9ccccbf.js');
-var compiler_host = require('./compiler_host-81f430d9.js');
+var compiler_host = require('./compiler_host-d7f120f0.js');
 var ts = require('typescript');
 var imports = require('./imports-4ac08251.js');
 require('@angular-devkit/core');
-require('./checker-77660732.js');
+require('./checker-51c08a1b.js');
 require('os');
 require('fs');
 require('module');

package/schematics/bundles/{program-1413936a.js → program-6e6520d8.js}

@@ -1,12 +1,12 @@
 'use strict';
 /**
- * @license Angular v19.0.0-next.10
+ * @license Angular v19.0.0-next.11
  * (c) 2010-2024 Google LLC. https://angular.io/
  * License: MIT
  */
 'use strict';
 
-var checker = require('./checker-77660732.js');
+var checker = require('./checker-51c08a1b.js');
 var ts = require('typescript');
 var p = require('path');
 require('os');
@@ -930,7 +930,7 @@ const MINIMUM_PARTIAL_LINKER_DEFER_SUPPORT_VERSION = '18.0.0';
 function compileDeclareClassMetadata(metadata) {
     const definitionMap = new checker.DefinitionMap();
     definitionMap.set('minVersion', checker.literal(MINIMUM_PARTIAL_LINKER_VERSION$5));
-    definitionMap.set('version', checker.literal('19.0.0-next.10'));
+    definitionMap.set('version', checker.literal('19.0.0-next.11'));
     definitionMap.set('ngImport', checker.importExpr(checker.Identifiers.core));
     definitionMap.set('type', metadata.type);
     definitionMap.set('decorators', metadata.decorators);
@@ -948,7 +948,7 @@ function compileComponentDeclareClassMetadata(metadata, dependencies) {
     callbackReturnDefinitionMap.set('ctorParameters', metadata.ctorParameters ?? checker.literal(null));
     callbackReturnDefinitionMap.set('propDecorators', metadata.propDecorators ?? checker.literal(null));
     definitionMap.set('minVersion', checker.literal(MINIMUM_PARTIAL_LINKER_DEFER_SUPPORT_VERSION));
-    definitionMap.set('version', checker.literal('19.0.0-next.10'));
+    definitionMap.set('version', checker.literal('19.0.0-next.11'));
     definitionMap.set('ngImport', checker.importExpr(checker.Identifiers.core));
     definitionMap.set('type', metadata.type);
     definitionMap.set('resolveDeferredDeps', compileComponentMetadataAsyncResolver(dependencies));
@@ -1043,7 +1043,7 @@ function createDirectiveDefinitionMap(meta) {
     const definitionMap = new checker.DefinitionMap();
     const minVersion = getMinimumVersionForPartialOutput(meta);
     definitionMap.set('minVersion', checker.literal(minVersion));
-    definitionMap.set('version', checker.literal('19.0.0-next.10'));
+    definitionMap.set('version', checker.literal('19.0.0-next.11'));
     // e.g. `type: MyDirective`
     definitionMap.set('type', meta.type.value);
     if (meta.isStandalone !== undefined) {
@@ -1462,7 +1462,7 @@ const MINIMUM_PARTIAL_LINKER_VERSION$4 = '12.0.0';
 function compileDeclareFactoryFunction(meta) {
     const definitionMap = new checker.DefinitionMap();
     definitionMap.set('minVersion', checker.literal(MINIMUM_PARTIAL_LINKER_VERSION$4));
-    definitionMap.set('version', checker.literal('19.0.0-next.10'));
+    definitionMap.set('version', checker.literal('19.0.0-next.11'));
     definitionMap.set('ngImport', checker.importExpr(checker.Identifiers.core));
     definitionMap.set('type', meta.type.value);
     definitionMap.set('deps', compileDependencies(meta.deps));
@@ -1497,7 +1497,7 @@ function compileDeclareInjectableFromMetadata(meta) {
 function createInjectableDefinitionMap(meta) {
     const definitionMap = new checker.DefinitionMap();
     definitionMap.set('minVersion', checker.literal(MINIMUM_PARTIAL_LINKER_VERSION$3));
-    definitionMap.set('version', checker.literal('19.0.0-next.10'));
+    definitionMap.set('version', checker.literal('19.0.0-next.11'));
     definitionMap.set('ngImport', checker.importExpr(checker.Identifiers.core));
     definitionMap.set('type', meta.type.value);
     // Only generate providedIn property if it has a non-null value
@@ -1548,7 +1548,7 @@ function compileDeclareInjectorFromMetadata(meta) {
 function createInjectorDefinitionMap(meta) {
     const definitionMap = new checker.DefinitionMap();
     definitionMap.set('minVersion', checker.literal(MINIMUM_PARTIAL_LINKER_VERSION$2));
-    definitionMap.set('version', checker.literal('19.0.0-next.10'));
+    definitionMap.set('version', checker.literal('19.0.0-next.11'));
     definitionMap.set('ngImport', checker.importExpr(checker.Identifiers.core));
     definitionMap.set('type', meta.type.value);
     definitionMap.set('providers', meta.providers);
@@ -1581,7 +1581,7 @@ function createNgModuleDefinitionMap(meta) {
         throw new Error('Invalid path! Local compilation mode should not get into the partial compilation path');
     }
     definitionMap.set('minVersion', checker.literal(MINIMUM_PARTIAL_LINKER_VERSION$1));
-    definitionMap.set('version', checker.literal('19.0.0-next.10'));
+    definitionMap.set('version', checker.literal('19.0.0-next.11'));
     definitionMap.set('ngImport', checker.importExpr(checker.Identifiers.core));
     definitionMap.set('type', meta.type.value);
     // We only generate the keys in the metadata if the arrays contain values.
@@ -1632,7 +1632,7 @@ function compileDeclarePipeFromMetadata(meta) {
 function createPipeDefinitionMap(meta) {
     const definitionMap = new checker.DefinitionMap();
     definitionMap.set('minVersion', checker.literal(MINIMUM_PARTIAL_LINKER_VERSION));
-    definitionMap.set('version', checker.literal('19.0.0-next.10'));
+    definitionMap.set('version', checker.literal('19.0.0-next.11'));
     definitionMap.set('ngImport', checker.importExpr(checker.Identifiers.core));
     // e.g. `type: MyPipe`
     definitionMap.set('type', meta.type.value);
@@ -5951,6 +5951,8 @@ function makeUnknownComponentDeferredImportDiagnostic(ref, rawExpr) {
     return checker.makeDiagnostic(checker.ErrorCode.COMPONENT_UNKNOWN_DEFERRED_IMPORT, getDiagnosticNode(ref, rawExpr), `Component deferred imports must be standalone components, directives or pipes.`);
 }
 
+/** Value used to mark a module whose scope is in the process of being resolved. */
+const IN_PROGRESS_RESOLUTION = {};
 /**
  * A registry which collects information about NgModules, Directives, Components, and Pipes which
  * are local (declared in the ts.Program being compiled), and can produce `LocalModuleScope`s
@@ -6122,8 +6124,12 @@ class LocalModuleScopeRegistry {
      */
     getScopeOfModuleReference(ref) {
         if (this.cache.has(ref.node)) {
-            return this.cache.get(ref.node);
+            const cachedValue = this.cache.get(ref.node);
+            if (cachedValue !== IN_PROGRESS_RESOLUTION) {
+                return cachedValue;
+            }
         }
+        this.cache.set(ref.node, IN_PROGRESS_RESOLUTION);
         // Seal the registry to protect the integrity of the `LocalModuleScope` cache.
         this.sealed = true;
         // `ref` should be an NgModule previously added to the registry. If not, a scope for it
@@ -6168,13 +6174,18 @@ class LocalModuleScopeRegistry {
         for (const decl of ngModule.imports) {
             const importScope = this.getExportedScope(decl, diagnostics, ref.node, 'import');
             if (importScope !== null) {
-                if (importScope === 'invalid' || importScope.exported.isPoisoned) {
+                if (importScope === 'invalid' ||
+                    importScope === 'cycle' ||
+                    importScope.exported.isPoisoned) {
                     // An import was an NgModule but contained errors of its own. Record this as an error too,
                     // because this scope is always going to be incorrect if one of its imports could not be
                     // read.
-                    diagnostics.push(invalidTransitiveNgModuleRef(decl, ngModule.rawImports, 'import'));
                     isPoisoned = true;
-                    if (importScope === 'invalid') {
+                    // Prevent the module from reporting a diagnostic about itself when there's a cycle.
+                    if (importScope !== 'cycle') {
+                        diagnostics.push(invalidTransitiveNgModuleRef(decl, ngModule.rawImports, 'import'));
+                    }
+                    if (importScope === 'invalid' || importScope === 'cycle') {
                         continue;
                     }
                 }
@@ -6260,13 +6271,18 @@ class LocalModuleScopeRegistry {
         for (const decl of ngModule.exports) {
             // Attempt to resolve decl as an NgModule.
             const exportScope = this.getExportedScope(decl, diagnostics, ref.node, 'export');
-            if (exportScope === 'invalid' || (exportScope !== null && exportScope.exported.isPoisoned)) {
+            if (exportScope === 'invalid' ||
+                exportScope === 'cycle' ||
+                (exportScope !== null && exportScope.exported.isPoisoned)) {
                 // An export was an NgModule but contained errors of its own. Record this as an error too,
                 // because this scope is always going to be incorrect if one of its exports could not be
                 // read.
-                diagnostics.push(invalidTransitiveNgModuleRef(decl, ngModule.rawExports, 'export'));
                 isPoisoned = true;
-                if (exportScope === 'invalid') {
+                // Prevent the module from reporting a diagnostic about itself when there's a cycle.
+                if (exportScope !== 'cycle') {
+                    diagnostics.push(invalidTransitiveNgModuleRef(decl, ngModule.rawExports, 'export'));
+                }
+                if (exportScope === 'invalid' || exportScope === 'cycle') {
                     continue;
                 }
             }
@@ -6371,6 +6387,12 @@ class LocalModuleScopeRegistry {
             return this.dependencyScopeReader.resolve(ref);
         }
         else {
+            if (this.cache.get(ref.node) === IN_PROGRESS_RESOLUTION) {
+                diagnostics.push(checker.makeDiagnostic(type === 'import'
+                    ? checker.ErrorCode.NGMODULE_INVALID_IMPORT
+                    : checker.ErrorCode.NGMODULE_INVALID_EXPORT, checker.identifierOfNode(ref.node) || ref.node, `NgModule "${type}" field contains a cycle`));
+                return 'cycle';
+            }
             // The NgModule is declared locally in the current program. Resolve it from the registry.
             return this.getScopeOfModuleReference(ref);
         }
@@ -19749,7 +19771,7 @@ var semver = /*@__PURE__*/getDefaultExportFromCjs(semverExports);
  * @param minVersion Minimum required version for the feature.
  */
 function coreVersionSupportsFeature(coreVersion, minVersion) {
-    // A version of `19.0.0-next.10` usually means that core is at head so it supports
+    // A version of `19.0.0-next.11` usually means that core is at head so it supports
     // all features. Use string interpolation prevent the placeholder from being replaced
     // with the current version during build time.
     if (coreVersion === `0.0.0-${'PLACEHOLDER'}`) {

package/schematics/bundles/project_tsconfig_paths-e9ccccbf.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.0.0-next.10
+ * @license Angular v19.0.0-next.11
  * (c) 2010-2024 Google LLC. https://angular.io/
  * License: MIT
  */

package/schematics/bundles/provide-initializer.js

@@ -0,0 +1,190 @@
+'use strict';
+/**
+ * @license Angular v19.0.0-next.11
+ * (c) 2010-2024 Google LLC. https://angular.io/
+ * License: MIT
+ */
+'use strict';
+
+Object.defineProperty(exports, '__esModule', { value: true });
+
+var schematics = require('@angular-devkit/schematics');
+var p = require('path');
+var project_tsconfig_paths = require('./project_tsconfig_paths-e9ccccbf.js');
+var compiler_host = require('./compiler_host-d7f120f0.js');
+var ts = require('typescript');
+var imports = require('./imports-4ac08251.js');
+var nodes = require('./nodes-a535b2be.js');
+require('@angular-devkit/core');
+require('./checker-51c08a1b.js');
+require('os');
+require('fs');
+require('module');
+require('url');
+
+function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { 'default': e }; }
+
+var ts__default = /*#__PURE__*/_interopDefaultLegacy(ts);
+
+function migrateFile(sourceFile, rewriteFn) {
+    const changeTracker = new compiler_host.ChangeTracker(ts__default["default"].createPrinter());
+    const visitNode = (node) => {
+        const provider = tryParseProviderExpression(node);
+        if (provider) {
+            replaceProviderWithNewApi({
+                sourceFile: sourceFile,
+                node: node,
+                provider: provider,
+                changeTracker,
+            });
+            return;
+        }
+        ts__default["default"].forEachChild(node, visitNode);
+    };
+    ts__default["default"].forEachChild(sourceFile, visitNode);
+    for (const change of changeTracker.recordChanges().get(sourceFile)?.values() ?? []) {
+        rewriteFn(change.start, change.removeLength ?? 0, change.text);
+    }
+}
+function replaceProviderWithNewApi({ sourceFile, node, provider, changeTracker, }) {
+    const { initializerCode, importInject, provideInitializerFunctionName, initializerToken } = provider;
+    const initializerTokenSpecifier = imports.getImportSpecifier(sourceFile, angularCoreModule, initializerToken);
+    // The token doesn't come from `@angular/core`.
+    if (!initializerTokenSpecifier) {
+        return;
+    }
+    // Replace the provider with the new provide function.
+    changeTracker.replaceText(sourceFile, node.getStart(), node.getWidth(), `${provideInitializerFunctionName}(${initializerCode})`);
+    // Import declaration and named imports are necessarily there.
+    const namedImports = nodes.closestNode(initializerTokenSpecifier, ts__default["default"].isNamedImports);
+    // `provide*Initializer` function is already imported.
+    const hasProvideInitializeFunction = namedImports.elements.some((element) => element.name.getText() === provideInitializerFunctionName);
+    const newNamedImports = ts__default["default"].factory.updateNamedImports(namedImports, [
+        // Remove the `*_INITIALIZER` token from imports.
+        ...namedImports.elements.filter((element) => element !== initializerTokenSpecifier),
+        // Add the `inject` function to imports if needed.
+        ...(importInject ? [createImportSpecifier('inject')] : []),
+        // Add the `provide*Initializer` function to imports.
+        ...(!hasProvideInitializeFunction
+            ? [createImportSpecifier(provideInitializerFunctionName)]
+            : []),
+    ]);
+    changeTracker.replaceNode(namedImports, newNamedImports);
+}
+function createImportSpecifier(name) {
+    return ts__default["default"].factory.createImportSpecifier(false, undefined, ts__default["default"].factory.createIdentifier(name));
+}
+function tryParseProviderExpression(node) {
+    if (!ts__default["default"].isObjectLiteralExpression(node)) {
+        return;
+    }
+    let deps = [];
+    let initializerToken;
+    let useExisting;
+    let useFactory;
+    let useValue;
+    let multi = false;
+    for (const property of node.properties) {
+        if (!ts__default["default"].isPropertyAssignment(property) || !ts__default["default"].isIdentifier(property.name)) {
+            continue;
+        }
+        switch (property.name.text) {
+            case 'deps':
+                if (ts__default["default"].isArrayLiteralExpression(property.initializer)) {
+                    deps = property.initializer.elements.map((el) => el.getText());
+                }
+                break;
+            case 'provide':
+                initializerToken = property.initializer.getText();
+                break;
+            case 'useExisting':
+                useExisting = property.initializer;
+                break;
+            case 'useFactory':
+                useFactory = property.initializer;
+                break;
+            case 'useValue':
+                useValue = property.initializer;
+                break;
+            case 'multi':
+                multi = property.initializer.kind === ts__default["default"].SyntaxKind.TrueKeyword;
+                break;
+        }
+    }
+    if (!initializerToken || !multi) {
+        return;
+    }
+    const provideInitializerFunctionName = initializerTokenToFunctionMap.get(initializerToken);
+    if (!provideInitializerFunctionName) {
+        return;
+    }
+    const info = {
+        initializerToken,
+        provideInitializerFunctionName,
+        importInject: false,
+    };
+    if (useExisting) {
+        return {
+            ...info,
+            importInject: true,
+            initializerCode: `() => inject(${useExisting.getText()})()`,
+        };
+    }
+    if (useFactory) {
+        const args = deps.map((dep) => `inject(${dep})`);
+        return {
+            ...info,
+            importInject: deps.length > 0,
+            initializerCode: `() => { return (${useFactory.getText()})(${args.join(', ')}); }`,
+        };
+    }
+    if (useValue) {
+        return { ...info, initializerCode: useValue.getText() };
+    }
+    return;
+}
+const angularCoreModule = '@angular/core';
+const initializerTokenToFunctionMap = new Map([
+    ['APP_INITIALIZER', 'provideAppInitializer'],
+    ['ENVIRONMENT_INITIALIZER', 'provideEnvironmentInitializer'],
+    ['PLATFORM_INITIALIZER', 'providePlatformInitializer'],
+]);
+
+function migrate() {
+    return async (tree) => {
+        const { buildPaths, testPaths } = await project_tsconfig_paths.getProjectTsConfigPaths(tree);
+        const basePath = process.cwd();
+        const allPaths = [...buildPaths, ...testPaths];
+        if (!allPaths.length) {
+            throw new schematics.SchematicsException('Could not find any tsconfig file. Cannot run the provide initializer migration.');
+        }
+        for (const tsconfigPath of allPaths) {
+            runMigration(tree, tsconfigPath, basePath);
+        }
+    };
+}
+function runMigration(tree, tsconfigPath, basePath) {
+    const program = compiler_host.createMigrationProgram(tree, tsconfigPath, basePath);
+    const sourceFiles = program
+        .getSourceFiles()
+        .filter((sourceFile) => compiler_host.canMigrateFile(basePath, sourceFile, program));
+    for (const sourceFile of sourceFiles) {
+        let update = null;
+        const rewriter = (startPos, width, text) => {
+            if (update === null) {
+                // Lazily initialize update, because most files will not require migration.
+                update = tree.beginUpdate(p.relative(basePath, sourceFile.fileName));
+            }
+            update.remove(startPos, width);
+            if (text !== null) {
+                update.insertLeft(startPos, text);
+            }
+        };
+        migrateFile(sourceFile, rewriter);
+        if (update !== null) {
+            tree.commitUpdate(update);
+        }
+    }
+}
+
+exports.migrate = migrate;

package/schematics/bundles/route-lazy-loading.js

@@ -1,6 +1,6 @@
 'use strict';
 /**
- * @license Angular v19.0.0-next.10
+ * @license Angular v19.0.0-next.11
  * (c) 2010-2024 Google LLC. https://angular.io/
  * License: MIT
  */
@@ -11,10 +11,10 @@ Object.defineProperty(exports, '__esModule', { value: true });
 var schematics = require('@angular-devkit/schematics');
 var fs = require('fs');
 var p = require('path');
-var compiler_host = require('./compiler_host-81f430d9.js');
+var compiler_host = require('./compiler_host-d7f120f0.js');
 var project_tsconfig_paths = require('./project_tsconfig_paths-e9ccccbf.js');
 var ts = require('typescript');
-require('./checker-77660732.js');
+require('./checker-51c08a1b.js');
 require('os');
 require('module');
 require('url');