@angular/compiler-cli 15.2.0-rc.0 → 16.0.0-next.0

package/package.json

@@ -1,10 +1,9 @@
 {
   "name": "@angular/compiler-cli",
-  "version": "15.2.0-rc.0",
+  "version": "16.0.0-next.0",
   "description": "Angular - the compiler CLI for Node.js",
   "typings": "index.d.ts",
   "bin": {
-    "ngcc": "./bundles/ngcc/main-ngcc.js",
     "ngc": "./bundles/src/bin/ngc.js",
     "ng-xi18n": "./bundles/src/bin/ng_xi18n.js"
   },
@@ -17,10 +16,6 @@
     "./package.json": {
       "default": "./package.json"
     },
-    "./ngcc": {
-      "types": "./ngcc/index.d.ts",
-      "default": "./bundles/ngcc/index.js"
-    },
     "./linker": {
       "types": "./linker/index.d.ts",
       "default": "./bundles/linker/index.js"
@@ -44,12 +39,6 @@
     "./private/tooling": {
       "types": "./private/tooling.d.ts",
       "default": "./bundles/private/tooling.js"
-    },
-    "./ngcc/src/execution/cluster/ngcc_cluster_worker": {
-      "default": "./bundles/ngcc/src/execution/cluster/ngcc_cluster_worker.js"
-    },
-    "./ngcc/src/locking/lock_file_with_child_process/ngcc_lock_unlocker": {
-      "default": "./bundles/ngcc/src/locking/lock_file_with_child_process/ngcc_lock_unlocker.js"
     }
   },
   "dependencies": {
@@ -58,14 +47,12 @@
     "reflect-metadata": "^0.1.2",
     "chokidar": "^3.0.0",
     "convert-source-map": "^1.5.1",
-    "dependency-graph": "^0.11.0",
-    "magic-string": "^0.27.0",
     "semver": "^7.0.0",
     "tslib": "^2.3.0",
     "yargs": "^17.2.1"
   },
   "peerDependencies": {
-    "@angular/compiler": "15.2.0-rc.0",
+    "@angular/compiler": "16.0.0-next.0",
     "typescript": ">=4.8.2 <5.0"
   },
   "repository": {

package/src/ngtsc/annotations/ng_module/src/handler.d.ts

@@ -14,7 +14,6 @@ import { PartialEvaluator } from '../../../partial_evaluator';
 import { PerfRecorder } from '../../../perf';
 import { ClassDeclaration, Decorator, ReflectionHost } from '../../../reflection';
 import { LocalModuleScopeRegistry } from '../../../scope';
-import { FactoryTracker } from '../../../shims/api';
 import { AnalysisOutput, CompileResult, DecoratorHandler, DetectResult, HandlerPrecedence, ResolveResult } from '../../../transform';
 import { InjectableClassRegistry, ReferencesRegistry } from '../../common';
 export interface NgModuleAnalysis {
@@ -62,12 +61,11 @@ export declare class NgModuleDecoratorHandler implements DecoratorHandler<Decora
     private referencesRegistry;
     private isCore;
     private refEmitter;
-    private factoryTracker;
     private annotateForClosureCompiler;
     private onlyPublishPublicTypings;
     private injectableRegistry;
     private perf;
-    constructor(reflector: ReflectionHost, evaluator: PartialEvaluator, metaReader: MetadataReader, metaRegistry: MetadataRegistry, scopeRegistry: LocalModuleScopeRegistry, referencesRegistry: ReferencesRegistry, isCore: boolean, refEmitter: ReferenceEmitter, factoryTracker: FactoryTracker | null, annotateForClosureCompiler: boolean, onlyPublishPublicTypings: boolean, injectableRegistry: InjectableClassRegistry, perf: PerfRecorder);
+    constructor(reflector: ReflectionHost, evaluator: PartialEvaluator, metaReader: MetadataReader, metaRegistry: MetadataRegistry, scopeRegistry: LocalModuleScopeRegistry, referencesRegistry: ReferencesRegistry, isCore: boolean, refEmitter: ReferenceEmitter, annotateForClosureCompiler: boolean, onlyPublishPublicTypings: boolean, injectableRegistry: InjectableClassRegistry, perf: PerfRecorder);
     readonly precedence = HandlerPrecedence.PRIMARY;
     readonly name: string;
     detect(node: ClassDeclaration, decorators: Decorator[] | null): DetectResult<Decorator> | undefined;

package/src/ngtsc/core/api/src/adapter.d.ts

@@ -7,7 +7,6 @@
  */
 import ts from 'typescript';
 import { AbsoluteFsPath } from '../../../file_system';
-import { FactoryTracker } from '../../../shims/api';
 import { ExtendedTsCompilerHost, UnifiedModulesHost } from './interfaces';
 /**
  * Names of methods from `ExtendedTsCompilerHost` that need to be provided by the
@@ -43,12 +42,6 @@ export interface NgCompilerAdapter extends Omit<ts.ModuleResolutionHost, 'getCur
      * command-line ngc.
      */
     readonly ignoreForEmit: Set<ts.SourceFile>;
-    /**
-     * A tracker for usage of symbols in `.ngfactory` shims.
-     *
-     * This can be left `null` if such shims are not a part of the `ts.Program`.
-     */
-    readonly factoryTracker: FactoryTracker | null;
     /**
      * A specialized interface provided in some environments (such as Bazel) which overrides how
      * import specifiers are generated.

package/src/ngtsc/core/api/src/options.d.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 import ts from 'typescript';
-import { BazelAndG3Options, DiagnosticOptions, I18nOptions, LegacyNgcOptions, MiscOptions, NgcCompatibilityOptions, StrictTemplateOptions, TargetOptions } from './public_options';
+import { BazelAndG3Options, DiagnosticOptions, I18nOptions, LegacyNgcOptions, MiscOptions, StrictTemplateOptions, TargetOptions } from './public_options';
 /**
  * Non-public options which are useful during testing of the compiler.
  */
@@ -36,6 +36,6 @@ export interface InternalOptions {
  *
  * Also includes a few miscellaneous options.
  */
-export interface NgCompilerOptions extends ts.CompilerOptions, LegacyNgcOptions, BazelAndG3Options, DiagnosticOptions, NgcCompatibilityOptions, StrictTemplateOptions, TestOnlyOptions, I18nOptions, TargetOptions, InternalOptions, MiscOptions {
+export interface NgCompilerOptions extends ts.CompilerOptions, LegacyNgcOptions, BazelAndG3Options, DiagnosticOptions, StrictTemplateOptions, TestOnlyOptions, I18nOptions, TargetOptions, InternalOptions, MiscOptions {
     [prop: string]: any;
 }

package/src/ngtsc/core/api/src/public_options.d.ts

@@ -77,31 +77,6 @@ export interface LegacyNgcOptions {
      */
     preserveWhitespaces?: boolean;
 }
-/**
- * Options which were added to the Angular Ivy compiler to support backwards compatibility with
- * existing View Engine applications.
- *
- * These are expected to be removed at some point in the future.
- *
- * @publicApi
- */
-export interface NgcCompatibilityOptions {
-    /**
-     * Controls whether ngtsc will emit `.ngfactory.js` shims for each compiled `.ts` file.
-     *
-     * These shims support legacy imports from `ngfactory` files, by exporting a factory shim
-     * for each component or NgModule in the original `.ts` file.
-     */
-    generateNgFactoryShims?: boolean;
-    /**
-     * Controls whether ngtsc will emit `.ngsummary.js` shims for each compiled `.ts` file.
-     *
-     * These shims support legacy imports from `ngsummary` files, by exporting an empty object
-     * for each NgModule in the original `.ts` file. The only purpose of summaries is to feed them to
-     * `TestBed`, which is a no-op in Ivy.
-     */
-    generateNgSummaryShims?: boolean;
-}
 /**
  * Options related to template type-checking and its strictness.
  *

package/src/ngtsc/core/src/host.d.ts

@@ -8,7 +8,6 @@
 import ts from 'typescript';
 import { AbsoluteFsPath } from '../../file_system';
 import { ShimAdapter, ShimReferenceTagger } from '../../shims';
-import { FactoryTracker } from '../../shims/api';
 import { RequiredDelegations } from '../../util/src/typescript';
 import { ExtendedTsCompilerHost, NgCompilerAdapter, NgCompilerOptions, UnifiedModulesHost } from '../api';
 /**
@@ -54,8 +53,8 @@ export declare class DelegatingCompilerHost implements Omit<RequiredDelegations<
  * A wrapper around `ts.CompilerHost` (plus any extension methods from `ExtendedTsCompilerHost`).
  *
  * In order for a consumer to include Angular compilation in their TypeScript compiler, the
- * `ts.Program` must be created with a host that adds Angular-specific files (e.g. factories,
- * summaries, the template type-checking file, etc) to the compilation. `NgCompilerHost` is the
+ * `ts.Program` must be created with a host that adds Angular-specific files (e.g.
+ * the template type-checking file, etc) to the compilation. `NgCompilerHost` is the
  * host implementation which supports this.
  *
  * The interface implementations here ensure that `NgCompilerHost` fully delegates to
@@ -64,12 +63,11 @@ export declare class DelegatingCompilerHost implements Omit<RequiredDelegations<
 export declare class NgCompilerHost extends DelegatingCompilerHost implements RequiredDelegations<ExtendedTsCompilerHost>, ExtendedTsCompilerHost, NgCompilerAdapter {
     private shimAdapter;
     private shimTagger;
-    readonly factoryTracker: FactoryTracker | null;
     readonly entryPoint: AbsoluteFsPath | null;
     readonly constructionDiagnostics: ts.Diagnostic[];
     readonly inputFiles: ReadonlyArray<string>;
     readonly rootDirs: ReadonlyArray<AbsoluteFsPath>;
-    constructor(delegate: ExtendedTsCompilerHost, inputFiles: ReadonlyArray<string>, rootDirs: ReadonlyArray<AbsoluteFsPath>, shimAdapter: ShimAdapter, shimTagger: ShimReferenceTagger, entryPoint: AbsoluteFsPath | null, factoryTracker: FactoryTracker | null, diagnostics: ts.Diagnostic[]);
+    constructor(delegate: ExtendedTsCompilerHost, inputFiles: ReadonlyArray<string>, rootDirs: ReadonlyArray<AbsoluteFsPath>, shimAdapter: ShimAdapter, shimTagger: ShimReferenceTagger, entryPoint: AbsoluteFsPath | null, diagnostics: ts.Diagnostic[]);
     /**
      * Retrieves a set of `ts.SourceFile`s which should not be emitted as JS files.
      *

package/src/ngtsc/imports/index.d.ts

@@ -9,6 +9,7 @@ export { AliasingHost, AliasStrategy, PrivateExportAliasingHost, UnifiedModulesA
 export { ImportRewriter, NoopImportRewriter, R3SymbolsImportRewriter, validateAndRewriteCoreSymbol } from './src/core';
 export { DefaultImportTracker } from './src/default';
 export { AbsoluteModuleStrategy, assertSuccessfulReferenceEmit, EmittedReference, FailedEmitResult, ImportedFile, ImportFlags, LocalIdentifierStrategy, LogicalProjectStrategy, ReferenceEmitKind, ReferenceEmitResult, ReferenceEmitStrategy, ReferenceEmitter, RelativePathStrategy, UnifiedModulesStrategy } from './src/emitter';
+export { isAliasImportDeclaration, loadIsReferencedAliasDeclarationPatch } from './src/patch_alias_reference_resolution';
 export { Reexport } from './src/reexport';
 export { OwningModule, Reference } from './src/references';
 export { ModuleResolver } from './src/resolver';

package/src/ngtsc/imports/src/default.d.ts

@@ -39,18 +39,18 @@ export declare function getDefaultImportDeclaration(expr: WrappedNodeExpr<unknow
  * a dangling reference, as TS will elide the import because it was only used in the type position
  * originally.
  *
- * To avoid this, the compiler must "touch" the imports with `ts.getMutableClone`, and should
- * only do this for imports which are actually consumed. The `DefaultImportTracker` keeps track of
- * these imports as they're encountered and emitted, and implements a transform which can correctly
- * flag the imports as required.
+ * To avoid this, the compiler must patch the emit resolver, and should only do this for imports
+ * which are actually consumed. The `DefaultImportTracker` keeps track of these imports as they're
+ * encountered and emitted, and implements a transform which can correctly flag the imports as
+ * required.
  *
  * This problem does not exist for non-default imports as the compiler can easily insert
  * "import * as X" style imports for those, and the "X" identifier survives transformation.
  */
 export declare class DefaultImportTracker {
     /**
-     * A `Map` which tracks the `Set` of `ts.ImportDeclaration`s for default imports that were used in
-     * a given `ts.SourceFile` and need to be preserved.
+     * A `Map` which tracks the `Set` of `ts.ImportClause`s for default imports that were used in
+     * a given file name.
      */
     private sourceFileToUsedImports;
     recordUsedImport(importDecl: ts.ImportDeclaration): void;
@@ -61,8 +61,4 @@ export declare class DefaultImportTracker {
      * This transformer must run after any other transformers which call `recordUsedImport`.
      */
     importPreservingTransformer(): ts.TransformerFactory<ts.SourceFile>;
-    /**
-     * Process a `ts.SourceFile` and replace any `ts.ImportDeclaration`s.
-     */
-    private transformSourceFile;
 }

package/src/ngtsc/imports/src/patch_alias_reference_resolution.d.ts

@@ -0,0 +1,61 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+import ts from 'typescript';
+/**
+ * Patches the alias declaration reference resolution for a given transformation context
+ * so that TypeScript knows about the specified alias declarations being referenced.
+ *
+ * This exists because TypeScript performs analysis of import usage before transformers
+ * run and doesn't refresh its state after transformations. This means that imports
+ * for symbols used as constructor types are elided due to their original type-only usage.
+ *
+ * In reality though, since we downlevel decorators and constructor parameters, we want
+ * these symbols to be retained in the JavaScript output as they will be used as values
+ * at runtime. We can instruct TypeScript to preserve imports for such identifiers by
+ * creating a mutable clone of a given import specifier/clause or namespace, but that
+ * has the downside of preserving the full import in the JS output. See:
+ * https://github.com/microsoft/TypeScript/blob/3eaa7c65f6f076a08a5f7f1946fd0df7c7430259/src/compiler/transformers/ts.ts#L242-L250.
+ *
+ * This is a trick the CLI used in the past  for constructor parameter downleveling in JIT:
+ * https://github.com/angular/angular-cli/blob/b3f84cc5184337666ce61c07b7b9df418030106f/packages/ngtools/webpack/src/transformers/ctor-parameters.ts#L323-L325
+ * The trick is not ideal though as it preserves the full import (as outlined before), and it
+ * results in a slow-down due to the type checker being involved multiple times. The CLI worked
+ * around this import preserving issue by having another complex post-process step that detects and
+ * elides unused imports. Note that these unused imports could cause unused chunks being generated
+ * by Webpack if the application or library is not marked as side-effect free.
+ *
+ * This is not ideal though, as we basically re-implement the complex import usage resolution
+ * from TypeScript. We can do better by letting TypeScript do the import eliding, but providing
+ * information about the alias declarations (e.g. import specifiers) that should not be elided
+ * because they are actually referenced (as they will now appear in static properties).
+ *
+ * More information about these limitations with transformers can be found in:
+ *   1. https://github.com/Microsoft/TypeScript/issues/17552.
+ *   2. https://github.com/microsoft/TypeScript/issues/17516.
+ *   3. https://github.com/angular/tsickle/issues/635.
+ *
+ * The patch we apply to tell TypeScript about actual referenced aliases (i.e. imported symbols),
+ * matches conceptually with the logic that runs internally in TypeScript when the
+ * `emitDecoratorMetadata` flag is enabled. TypeScript basically surfaces the same problem and
+ * solves it conceptually the same way, but obviously doesn't need to access an internal API.
+ *
+ * The set that is returned by this function is meant to be filled with import declaration nodes
+ * that have been referenced in a value-position by the transform, such the installed patch can
+ * ensure that those import declarations are not elided.
+ *
+ * See below. Note that this uses sourcegraph as the TypeScript checker file doesn't display on
+ * Github.
+ * https://sourcegraph.com/github.com/microsoft/TypeScript@3eaa7c65f6f076a08a5f7f1946fd0df7c7430259/-/blob/src/compiler/checker.ts#L31219-31257
+ */
+export declare function loadIsReferencedAliasDeclarationPatch(context: ts.TransformationContext): Set<ts.Declaration>;
+/**
+ * Gets whether a given node corresponds to an import alias declaration. Alias
+ * declarations can be import specifiers, namespace imports or import clauses
+ * as these do not declare an actual symbol but just point to a target declaration.
+ */
+export declare function isAliasImportDeclaration(node: ts.Node): node is ts.ImportSpecifier | ts.NamespaceImport | ts.ImportClause;

package/src/ngtsc/shims/api.d.ts

@@ -42,22 +42,3 @@ export interface PerFileShimGenerator {
      */
     generateShimForFile(sf: ts.SourceFile, genFilePath: AbsoluteFsPath, priorShimSf: ts.SourceFile | null): ts.SourceFile;
 }
-/**
- * Maintains a mapping of which symbols in a .ngfactory file have been used.
- *
- * .ngfactory files are generated with one symbol per defined class in the source file, regardless
- * of whether the classes in the source files are NgModules (because that isn't known at the time
- * the factory files are generated). A `FactoryTracker` supports removing factory symbols which
- * didn't end up being NgModules, by tracking the ones which are.
- */
-export interface FactoryTracker {
-    readonly sourceInfo: Map<string, FactoryInfo>;
-    track(sf: ts.SourceFile, moduleInfo: ModuleInfo): void;
-}
-export interface FactoryInfo {
-    sourceFilePath: string;
-    moduleSymbols: Map<string, ModuleInfo>;
-}
-export interface ModuleInfo {
-    name: string;
-}

package/src/ngtsc/shims/index.d.ts

@@ -7,6 +7,4 @@
  */
 export { ShimAdapter } from './src/adapter';
 export { copyFileShimData, isShim, retagAllTsFiles, retagTsFile, sfExtensionData, untagAllTsFiles, untagTsFile } from './src/expando';
-export { FactoryGenerator, generatedFactoryTransform } from './src/factory_generator';
 export { ShimReferenceTagger } from './src/reference_tagger';
-export { SummaryGenerator } from './src/summary_generator';

package/src/transformers/api.d.ts

@@ -25,11 +25,6 @@ export interface CompilerOptions extends NgCompilerOptions, ts.CompilerOptions {
     i18nInFormat?: string;
     i18nInFile?: string;
     i18nInMissingTranslations?: 'error' | 'warning' | 'ignore';
-    /**
-     * Whether to generate .ngsummary.ts files that allow to use AOTed artifacts
-     * in JIT mode. This is off by default.
-     */
-    enableSummariesForJit?: boolean;
     /**
      * Whether to replace the `templateUrl` and `styleUrls` property in all
      * @Component decorators with inlined contents in `template` and `styles`

package/bundles/chunk-7DUI3BSX.js

@@ -1,29 +0,0 @@
-
-      import {createRequire as __cjsCompatRequire} from 'module';
-      const require = __cjsCompatRequire(import.meta.url);
-    
-
-// bazel-out/darwin_arm64-fastbuild/bin/packages/compiler-cli/ngcc/src/locking/lock_file_with_child_process/util.mjs
-function removeLockFile(fs, logger, lockFilePath, pid) {
-  try {
-    logger.debug(`Attempting to remove lock-file at ${lockFilePath}.`);
-    const lockFilePid = fs.readFile(lockFilePath);
-    if (lockFilePid === pid) {
-      logger.debug(`PIDs match (${pid}), so removing ${lockFilePath}.`);
-      fs.removeFile(lockFilePath);
-    } else {
-      logger.debug(`PIDs do not match (${pid} and ${lockFilePid}), so not removing ${lockFilePath}.`);
-    }
-  } catch (e) {
-    if (e.code === "ENOENT") {
-      logger.debug(`The lock-file at ${lockFilePath} was already removed.`);
-    } else {
-      throw e;
-    }
-  }
-}
-
-export {
-  removeLockFile
-};
-//# sourceMappingURL=chunk-7DUI3BSX.js.map

package/bundles/chunk-7DUI3BSX.js.map

@@ -1,6 +0,0 @@
-{
-  "version": 3,
-  "sources": ["../../../../../../packages/compiler-cli/ngcc/src/locking/lock_file_with_child_process/util.ts"],
-  "mappings": ";;;;;;AAgBM,SAAU,eACZ,IAAgB,QAAgB,cAA8B,KAAW;AAC3E,MAAI;AACF,WAAO,MAAM,qCAAqC,eAAe;AACjE,UAAM,cAAc,GAAG,SAAS,YAAY;AAC5C,QAAI,gBAAgB,KAAK;AACvB,aAAO,MAAM,eAAe,qBAAqB,eAAe;AAChE,SAAG,WAAW,YAAY;WACrB;AACL,aAAO,MACH,sBAAsB,WAAW,iCAAiC,eAAe;;WAEhF,GAAP;AACA,QAAI,EAAE,SAAS,UAAU;AACvB,aAAO,MAAM,oBAAoB,mCAAmC;WAE/D;AACL,YAAM;;;AAGZ;",
-  "names": []
-}